Bug #21299

Can't restore a deleted page in draft workspace

Added by Robert Heel about 11 years ago. Updated about 1 year ago.

Status:
Accepted
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
-
Start date:
2009-10-19
Due date:
% Done:

0%

TYPO3 Version:
4.2
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Create a page in draft workspace and delete it. Try to restore this page. Everything in history is shown correct, but the page didn't appear in the page tree.

(issue imported from #M12268)

Cattura2.PNG View (18.2 KB) Riccardo De Contardi, 2013-05-07 11:25


Related issues

Related to TYPO3 Core - Bug #36292: Rolling back deletion of a draft element fails and will undelete the placeholder Rejected 2012-04-18
Related to TYPO3 Core - Bug #89383: Restoring deleted content element in workspace fails New 2019-10-09
Related to TYPO3 Core - Bug #90679: "Restore record" does not restore record Closed 2020-03-08
Related to TYPO3 Core - Bug #92056: Recycler shows workspace records in live workspace Closed 2020-08-20

Associated revisions

Revision 186510ce (diff)
Added by Christian Kuhn 2 months ago

[BUGFIX] Recycler does not show workspace records in live

The patch fixes a couple of database restrictions to prevent
the recycler from showing workspace related records in live
workspace.
Note there are further issues with the recycler in workspace
context. Those need work on workspace record lifecycles first,
and are not tackled with the patch.

Resolves: #92056
Related: #21299
Releases: master, 10.4
Change-Id: Ib2d9a14231d01a861c731f4ce39b8f0cf5eddc73
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65394
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Achim Fritz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Achim Fritz <>
Reviewed-by: Daniel Goerz <>

Revision 2af3338f (diff)
Added by Christian Kuhn 2 months ago

[BUGFIX] Recycler does not show workspace records in live

The patch fixes a couple of database restrictions to prevent
the recycler from showing workspace related records in live
workspace.
Note there are further issues with the recycler in workspace
context. Those need work on workspace record lifecycles first,
and are not tackled with the patch.

Resolves: #92056
Related: #21299
Releases: master, 10.4
Change-Id: Ib2d9a14231d01a861c731f4ce39b8f0cf5eddc73
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65414
Tested-by: TYPO3com <>
Tested-by: Daniel Goerz <>
Reviewed-by: Daniel Goerz <>

History

#1 Updated by Robert Heel about 11 years ago

undeleteRecord doesn't restore the t3ver_wsid and undelete the workspace version.

#2 Updated by Susanne Moog over 9 years ago

  • Status changed from New to Accepted
  • Target version deleted (0)

#3 Updated by Oliver Hader over 9 years ago

  • Status changed from Accepted to Needs Feedback

Can you please tell how this issue can be reproduced?

#4 Updated by Oliver Hader over 9 years ago

  • Assignee set to Oliver Hader

#5 Updated by Robert Heel over 9 years ago

1) Switch to a draft workspace
2) Create a page
3) Delete the page again.
4) Go to this history of the parent page. Try to undelete it.
No error message, but no undeleted page.

#6 Updated by Tolleiv Nietsch about 9 years ago

  • Status changed from Needs Feedback to Accepted

#7 Updated by Riccardo De Contardi over 7 years ago

Procedure followed in TYPO3 6.1:

1) Switch to a draft workspace
2) Create a page (called "to delete 2", ID=31)
3) Delete the page again.
4) switch to live workspace
5) the page is still present and live (correct, I guess)
6) Go to parent page.
7) list view
8) click on history/undo
9) click on rollback/preview; click on "rollback all changes shown"; the result is shown in attached file

As far as I can see the page has been restored

BTW: the recycler module does not work at all in custom workspace: is it a bug or intentional?

#8 Updated by Michael Stucki almost 7 years ago

  • Category set to Workspaces

#9 Updated by Michael Stucki almost 7 years ago

  • Project changed from Workspaces & Versioning to TYPO3 Core
  • Category changed from Workspaces to Workspaces

#10 Updated by Mathias Schreiber almost 6 years ago

  • Target version set to 7.5

#11 Updated by Benni Mack about 5 years ago

  • Target version changed from 7.5 to 7 LTS

#12 Updated by Mathias Schreiber almost 5 years ago

  • Target version deleted (7 LTS)

#13 Updated by Riccardo De Contardi over 3 years ago

I performed a test with 6.2.30, 7.6.18 and latest master:

Test procedure and result with 6.2.30:

  1. Switch to a Custom Workspace
  2. Create a page
  3. Delete the page
  4. Switch to LIVE > result: the page is absent
  5. Recycler: the page can be restored (only LIVE - the recycler does not work in custom worskspace)

Test procedure and result with 7.6.18 and latest master:

Note: the recycler seems to work in Custom Workspace - it shows the same elements already deleted in LIVE workspace.

  1. Switch to a Custom Workspace
  2. Create a page
  3. Delete the page
  4. go to recycler - the page is NOT listed
  5. Switch to LIVE > result: the page is absent
  6. go to recycler: the page IS LISTED and the page can be restored (only LIVE, then as the page is not listed when the recycler is accessed in Custom Workspace)

#14 Updated by Riccardo De Contardi over 2 years ago

my last comment still applies to 9.4-dev (latest master)

#15 Updated by Christian Weiske about 1 year ago

This still happens on TYPO3 9.5.9.
When restoring the page in the workspace (via parent page context menu: history/undo), the "deleted"-flag of the "initial placeholder" version is set to 0, but the "first draft version" record keeps "deleted=1".

Clicking on the restored page in the page tree gives us an exception:

(1/1) #1534710048 TYPO3\CMS\Core\Exception\SiteNotFoundException
No pseudo-site found in root line of page 228

#16 Updated by Christian Weiske about 1 year ago

  • Related to Bug #89383: Restoring deleted content element in workspace fails added

#17 Updated by Christian Kuhn 3 months ago

  • Related to Bug #90679: "Restore record" does not restore record added

#18 Updated by Christian Kuhn 2 months ago

  • Related to Bug #92056: Recycler shows workspace records in live workspace added

Also available in: Atom PDF