TYPO3 Core

increased priority, I take the amount of people monitoring this issue as a sign of interest in getting this issue fixed...

Hey Steffen,

a lot of people seem interested in this issue, could you take a look at it please?

Steffen Kamper wrote:

I look into this amd try to find a solution. It's not really a pageRenderer issue but the logic behind substitution in USER_INT. Now i'm aware of this problem again ;)

I have fixed this issue. Should I attach here an patch, when I have complete done?

Tobias, I would personally appreciate to have a patch, or at least some hints how to fix, as I need this really!

thxal in adv, clemens

Tobias? Could you please provide the patch?

Thanks for your contribution!
Steffen

hey sorry for my late! I will answer later with Patch. Have to done an task now/currently.

Yes, basically looks good. A quick formal review:

• General
  • indentation always with tabs
• class.tslib_fe.php
  • I think the patch - at least class.tslib_fe.php - is in the wrong direction (your new lines are displayed as "to be removed" and vice versa).
  • Only that one hunk around lines 3199 with your changes should be there. The rest not.
  • Shorten the comment. One or two lines above your new lines are enough.
• class.t3lib_pagerenderer.php
  • Did you use the same code as a base for both file versions? I am asking because of the many changes, new functions and so on. It would be ideal if you took the most current version from the branch you are working with from http://git.typo3.org/TYPO3v4/Core.git (look for "heads" at bottom of page).
  • remove debug() code.
  • do not comment unused code, but remove it completely.
  • do not add "@author" tags and "@see forge.typo3...".

okay, thanks for the advice. I will try to consider them in the future, but don't hesitate to give me more advices.

I will check the patch/code for adding an clean Version of it.

I have use the same base version of the file. Without looking into the file now, I would say that the many new functions are from me. I have packed some Code into few small function's to get it working correctly and reducing doubled code.

Not used the git version yet of typo3. Shorting comments is possible.(question of taste). If I find time, I will implement the patch for the git-Version.

Indentation, that's an terrible thing. In one Project they use tabs and in an other they use spaces. I use normally 4 Spaces for intending.

any progress here?

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

i missed the "jsFooterFiles" in this patch.

perhaps was this a solution:

$this->content = str_replace('</body>', $additionalHeaderDataForUserIntPlugin['jsFooterFiles'] . $additionalHeaderDataForUserIntPlugin['jsFooterInline'] . '</body>', $this->content);

What do you mean with "I missed"?

If you have a comment to the code, please post it directly in gerrit.

I dont know how to do this.

learn how to do it: http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine ;)

1. do a checkout with the url in gerrit
2. make your changes
3. add them
4. git commit --amend
5. push them

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

I make an Update of the patch from "Dominique Feyer" that includes a Fix for TS Option "config.moveJsFromHeaderToFooter".

It is available at http://review.typo3.org/7465

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Just for the records, here is how the rendering of *_INT works respecting the additionalHeaderData and additionalFooterData:

First Hit (or uncachable page):¶

1. render page cObjects (tslib_pagegen::renderContent )
2. add placeholders for uncached objects during this rendering (tslib_content_*Internal)
3. Store additionalHeaderData and additionalFooterData in cached config (tslib_pagegen::renderContentWithHeader starting from if (is_array($GLOBALS['TSFE']->config['INTincScript'])) {)
4. Replace additionalHeaderData and additionalFooterData data array with placeholders ($GLOBALS['TSFE']->additionalHeaderData = array ('<!--HD_' . $GLOBALS['TSFE']->config['INTincScript_ext']['divKey'] . '-->'); // Clearing the array)
5. render the page with all placeholders (tslib_pagegen::renderContentWithHeader)
6. cache HTML page + config ($TSFE->generatePage_postProcessing();)
7. restore additionalHeaderData and additionalFooterData from config ($TSFE->INTincScript();)
8. replace placeholders of uncached objects ($TSFE->INTincScript();)
9. replace additionalHeaderData and additionalFooterData placeholders ($TSFE->INTincScript();)

Cache Hit:¶

1. get placehoder HTML + config from cache ($TSFE->getFromCache();)
2. restore additionalHeaderData and additionalFooterData from config ($TSFE->INTincScript();)
3. replace placeholders of uncached objects ($TSFE->INTincScript();)
4. replace additionalHeaderData and additionalFooterData placeholders ($TSFE->INTincScript();)

As you can see, the last 3 steps are always the same. To get this working with the pageRenderer, we need to store the current state of it at step 3. of the uncached rendering and restore this state before the uncached objects are executed. This needs to be done to avoid double inclusion of assets with the pageRenderer which is easy with additionalHeaderData and additionalFooterData if unique keys for the arrays are used.

Hope this makes it a bit clearer and serves as a reference for future changes in this area.

Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Patch set 12 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7465

Hello, great that this issue is finally fixed! will it be backported into the versions 4.5, 4.6, 4.7? Some extensions requires the pageRenderer (fed, dmf_galleria ...) and would love to see this fix for the 4.x branch. Cheers Dominic

Hello Dominnic,

as i would interpret that as a bug, please just cherrypick the current fix and port it to 4.5, 4.6 and 4.7 as seperate changerequest :D

I hope it will than be included in the next release - i stumbled upon that bug during the development of my dynamic css extension as well.
Especially stuff from ts (get files and replace them (*.less -> *.css) hasn't worked well with enabled caching :(

Regards
Kay

Hi,

Kay Strobach wrote:

as i would interpret that as a bug, please just cherrypick the current fix and port it to 4.5, 4.6 and 4.7 as seperate changerequest :D

I would also consider this a bug, but the fix was rather complicated and included a lot of prior refactoring of the pageRenderer.
This change will not go into released branches, sorry.