TYPO3 Core

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/43508

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

First: I want guzzle, too!

But imho, this area needs a full re-work and this patch does not go far enough.

• getUrl with curl
• getUrl with fsock
• getUrl with file_get_contents
• http2 with a slim core "fassade" that is extending http2.

Additionally we have a series of configuration options that are half deprecated within typo3_conf_vars. Furthermore getUrl() is also able to retrieve local files.

• getUrl: fetching local files and getting remote content are 2 different things, getUrl hides that, but imho a controller should know and steer this. so hiding these 2 concerns is not a good idea. core could help with a helper to find out if a given string is a local page number, a local file or an external ressource, maybe more. So in general i'd like to have getUrl() deprecated!
• http2: the "fassade" still exposes all http2 details while it should probably hide for instance the configuration setters to consumers.
• current pending patch with guzzle creates a direct dependency from a controller to guzzle without a fassade. there is not even a way to transfer configuration options from core to initialize guzzle options.
• there is no sane default configuration / detection done.

If we start fixing this mess with guzzle, I'd require to have some core support that fixes all of the above stuff and does not just add something. I want the technical debt to be solved once and for all, in detail:

• Have a stable API to fetch remote content that does not change if we substitute the implementation with something else.
• Have a proper detection of settings within install tool.
• Do not expose the whole guzzle API to the outside but only things that make sense for consumers, and clearly state what is not exposed. Goal is here to have a package in the core that is properly pre-configured. If extensions need more, they still may use guzzle directly, but then they're on their own.
• Separate remote fetching from local ressources, help extensions to find out which type of a resource they are handling so they can steer further stuff.
• Get rid of getUrl()

In general I'd like to finally have a proper modeling for this stuff in the core and a solution path of things that need to be done instead of cowboy hacking guzzle into the system now. The above are just some ideas, I'd love to have some feedback / more detailed discussion and will help with finding a solution path if someone wants to do something like that.

Well, I second this, although I already did most of the work years ago. I hope now since change is more accepted and separation of concerns came into focus that this getUrl mess is finally resolved.

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/43508