TYPO3 Core

Same here when upgrading from 7.6.16 to 8.7.2.
I have the linkhandler extension installed.

A little bit lazy, but works with

if (empty($parameters['identifier']) || empty($parameters['uid'])) {
                $new = explode(":", $parameters['value']);
                if (count($new) == 2) {
                                $parameters['identifier'] = $new[0];
                                $parameters['uid'] = $new[1];
                }
        }

in typo3_src-8.7.4/typo3/sysext/core/Classes/LinkHandling/RecordLinkHandler.php:39

In the end i think it's not really a core issue and more an extension issue.

If you use AOE link handler and have links in your DB entries like

<link record:tx_anyextension_model:123 ...

you need to change these links befor running Upgrade Wizard 'Execute database migrations on single rows' - else this upgrade wizard will never finish its purpose.

If you're right in the middle of an update and need a quick fix for this problem I recommend to apply the following patch to method transformLinkTagsIfFound in file /typo3/sysext/install/Classes/Updates/RowUpdater/RteLinkSyntaxUpdater.php:180 and run the upgrade wizard again:

$linkParts = $linkService->resolve($link);
if (
    array_key_exists('type', $linkParts) &&
    $linkParts['type'] === LinkService::TYPE_RECORD &&
    array_key_exists('url', $linkParts) &&
    is_array($linkParts['url'])) {
    $linkParts['identifier'] = $linkParts['url']['identifier'];
    $linkParts['uid'] = $linkParts['url']['uid'];
}
$anchorTagAttributes['href'] = $linkService->asString($linkParts);

This just adds an condition to check for links like record:tx_news:tx_news_domain_model_news:1234.

Trapped into this, too. Added my patch to #79647

Made #note-7 available as https://github.com/jpmschuler/install/commit/e9d12ba38d30635f02f326b0aeae9458589eaebe.patch for easier composer patching in the meanwhile.

As this Install Tool step is mandatory and it throws an exception just because stupid RTE content exists, it is a core issue IMHO. It is okay to not parse the extensions links at all, but chocking to death is a core issue.

I can confirm that this issue still exists.

I'd propose that, if this cannot be considered a core issue, an update helper extension is built and distributed with the core update (could be registered as require-dev in composer mode), this would probably help some people.

In the meantime JPM's patch seems to work as expected :-)

If the bugfix of Tobias Schmidt and J. Peter M. Schuler isn't working try following Patch:

if (
   array_key_exists('type', $linkParts) &&
   $linkParts['type'] === LinkService::TYPE_RECORD  &&
   array_key_exists('url', $linkParts)  &&
   is_array($linkParts['url'])
   ) {
   $linkPartsClean['identifier'] = $linkParts['url']['identifier'];
   $linkPartsClean['uid'] = $linkParts['url']['uid'];

   $linkParts = $linkPartsClean;
}

$anchorTagAttributes['href'] = $linkService->asString($linkParts);

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58964

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58964

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58964

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58964