TYPO3 Core

Hi Wouter,

I do not use Flux.

I only use DCE (1.4.8) and included
- Fluid Content Elements (fluid_styled_content)
- Fluid Content Elements CSS (optional) (fluid_styled_content)

Regards
Michael

I can confirm the problem, but only for my special case. I have several custom elements (new CTypes) that can contain IRRE elements. The IRRE element itself has a text field, which should contain an RTE only on a particular CType.

By using a configuration like this, I get duplicate p-tags each time I save the particular CType.

$GLOBALS['TCA']['tt_content']['types']['ce_custom'] = [
    'columnsOverrides' => [
        'tx_domain_model_records' => [
            'config' => [
                'overrideChildTca' => [
                    'columns' => [
                        'text' => [
                            'config' => [
                                'enableRichtext' => true,
                                'richtextConfiguration' => 'default',
                            ],
                        ],
                    ],
                ],
            ],
        ],
    ],
],

If I activate the RTE for the text field of the IRRE element in general (and not just for the specific CType), the problem does not occur.

• TYPO3 CMS 8.7.5-dev
• rte_ckeditor (8.7.5)
• fluid_styled_content (8.7.5)

I don't use Flux or DCE. In normal content elements like 'text' or 'textmedia' the problem does not occur as well.

I use the columnsOverrides and overrideChildTca TCA feature to enable the RTE on the "description" field of a sys_file_reference.

Configuration/TCA/Overrides/tt_content.php:

    \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule(
        $GLOBALS['TCA']['tt_content'],
        [
            'types' => [
                'textmedia' => [
                    'columnsOverrides' => [
                        'assets' => [
                            'config' => [
                                'overrideChildTca' => [
                                    'columns' => [
                                        'description' => [
                                            'config' => [
                                                'enableRichtext' => true,
                                                'richtextConfiguration' => 'default'
                                            ],
                                        ],
                                    ],
                                ],
                            ],
                        ],
                    ],
                ],
            ],
        ]
    );

When saving, the DataHandler does not know what was overwritten by the parent element:
https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7-4/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L1770

The DataHandler takes the "default" configuration of "$GLOBALS['TCA']['sys_file_reference']['types']²['columnsOverrides']['description']['config']" and ignores the "overrideChildTca" configuration from the parent element.
Therefore, "'enableRichtext' => true" is not set and the DataHandler does not execute the required RTE transformations.

I have this Problem on TYPO3 8.7.9 with News 6.2.0
If I add a Content element that has a ck_editor to a news entry, I get the new lines on every save.

Is this still an issue? I tried to use

- TYPO3 9.5.5
- Ext:news 7.1.0

I followed the following steps:

1) create a sysfolder
2) create a news record
3) tab "content elements" > create a "text" content element
4) write some text in it
5) Save

So far, I've not experienced that each save adds a line. Is a different test required?

I currently have this bug sometimes in a 9.5.13. Looks like there will be added a <p> </p> every time there is more than one line break between 2 p blocks. With each save there comes an additional line of empty p. Switching to the source view and delete every line break between the p's is a workaround.

Can confirm this with

TYPO3 9.5.13
tt_news 9.5.3
gridelements 9.3.0

Gridelements are installed but not used here.

I can confirm this issue in TYPO3 9.5.24.

I've configured the sys_file_reference.description to use the RTE (code above: #note-8). After saving the Editor adds <p>&nbsp;</p> at top and bottom and replaces every linebreak with <p>&nbsp;</p> as well.

If activate the RTE in the TCA of sys_file_reference directly (no columnsOverrides), it works.

I can also confirm this issue in TYPO3 9.5.27, same conditions as described by Daniel. Can someone reopen this who has permissions to do so?

Addendum: I had tried to activate the RTE for selected content elements in the description field of sys_file_reference and encountered the same problem as Ralf Zimmermann, that after saving new paragraphs were created in the RTE.

Afterwards I manually extended sys_file_reference with a new field "bodytext" ...

CREATE TABLE sys_file_reference (
    bodytext mediumtext,
);

    // Configure new fields:
    $newfields = array(
        'bodytext' => array(
            'exclude' => 1,
            'label' => 'LLL:EXT:core/Resources/Private/Language/locallang_general.xlf:LGL.text',
            'config' => array(
                'type' => 'text',
                'cols' => '80',
                'rows' => '15',
                'wrap' => 'off',
                'softref' => 'typolink_tag,images,email[subst],url',
                'format' => 'html',
                'enableRichtext' => true,
                'richtextConfiguration' => 'default'
            )
        )
    );
    // Add new fields:
    \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addTCAcolumns('sys_file_reference', $newfields);

... and assigned this field to my content element:

    $GLOBALS['TCA']['tt_content']['types']['mycontentelement'] = array(
        'showitem' => '
            --div--;LLL:EXT:core/Resources/Private/Language/Form/locallang_tabs.xlf:general,
            --palette--;;general,
            --palette--;;headers,
            image,
        ',
        'columnsOverrides' => [
            'image' => [
                'config' => [
                    'overrideChildTca' => [
                        'types' => [
                            2 => [
                                'showitem' => '
                                    bodytext,
                                    --palette--;;basicoverlayPalette,--palette--;;filePalette
                                ',
                                'columnsOverrides' => [
                                    'description' => [
                                        'config' => [
                                            'placeholder' => '',
                                            'mode' => '',
                                            'enableRichtext' => 1,
                                            'richtextConfiguration' => 'default',
                                        ],
                                    ],
                                ],
                            ],
                        ],
                    ],
                ],
            ],
        ],
    );

This worked now. The above TCA example contains both cases:
1. the working new field "bodytext" with RTE
2. the problematic "description" field with RTE, which creates empty lines when saving.

The problem, where the linefeed are added, happens at this place: https://github.com/TYPO3/typo3/blob/946825899102f8a603bc487f60ae87ca9859d31a/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L1650-L1656

This is because a wrong field config is used. The TCA columnOverrides are respected but overrideChildTca settings are not respected:
https://github.com/TYPO3/typo3/blob/946825899102f8a603bc487f60ae87ca9859d31a/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L1457

So enabling the RTE via overrideChildTca does still produce the problem.

I created a ddev project where this issue can bea easily reproduced to help track the bug down :)

It demonstrates exactly the issue from https://forge.typo3.org/issues/81893#note-8 and https://forge.typo3.org/issues/81893#note-24

Attached I am sending you the repository: https://github.com/micron/typo3-81893

All instructions can be found in the README.md.

Just to update: The problem still occurs in v11.5 (had it just today). Neither "columnsOverrides" nor "columns" worked for me when placed in "overrideChildTca" (see reduced example configuration):

$tcaCustomField = [
    'columns' => [
        'custom_field' => [
            'config' => [
                'type' => 'inline',
                'overrideChildTca' => [
                    'types' => [
                        '0' => [
                            'showitem' => 'bodytext,',
                            'columnsOverrides' => [
                                'bodytext' => [
                                    'config' => [
                                        'enableRichtext' => true,
                                        'richtextConfiguration' => 'default',
                                    ],
                                ],
                            ],
                        ],
                    ],
                ],
            ],
        ],
    ],
];
$GLOBALS['TCA']['pages'] = array_replace_recursive(
    $GLOBALS['TCA']['pages'],
    $tcaCustomField
);

$tcaCustomField = [
    'columns' => [
        'custom_field' => [
            'config' => [
                'type' => 'inline',
                'overrideChildTca' => [
                    'types' => [...],
                    'columns' => [
                        'bodytext' => [
                            'config' => [
                                'enableRichtext' => true,
                                'richtextConfiguration' => 'default',
                            ],
                        ],
                    ]
                ],
            ],
        ],
    ],
];
$GLOBALS['TCA']['pages'] = array_replace_recursive(
    $GLOBALS['TCA']['pages'],
    $tcaCustomField
);

Tested with v11.5.28 and PHP 8.1. Haven't tested it with v12.

Also in 11.5.37

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85148

I have added an EXT:styleguide case for this in v13/main. I could not reproduce this case there, I believe it got properly addressed with the TCA SchemaFactory implementation of v13, which now properly evaluates overrides so that DataHandler uses the final configuration.

I tested it with both a custom IRRE relation as well as with the "file" metadata one.

I also backported this to v12 where I could not reproduce it either.

(Note: I could reproduce it in 11.5 - so I do think this got fixed with v12, probably due to the CKEditor5 upgrade?

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85148