Project

General

Profile

Activity

From 2022-08-25 to 2022-09-23

2022-09-23

19:48 Revision ac1703ae: [BUGFIX] Restore and streamline auth log with MFA
MFA was preventing the login log entry to be written
as after successful username/password auth MFA was
triggered wit...
Susanne Moog
17:32 Revision a9d1d692: [BUGFIX] Fix glitches in controls of EXT:viewpage
The controls of EXT:viewpage have several glitches which are fixed in
this patch:
* Setting a custom width now prope...
Andreas Fernandez
14:54 Revision 50059a0f: [BUGFIX] Restore and streamline auth log with MFA
MFA was preventing the login log entry to be written
as after successful username/password auth MFA was
triggered wit...
Susanne Moog
14:53 Revision 5493dbef: [BUGFIX] Fix glitches in controls of EXT:viewpage
The controls of EXT:viewpage have several glitches which are fixed in
this patch:
* The label of the "Custom" preset...
Andreas Fernandez
10:48 Revision 34260c12: [TASK] Streamline FormEngine inline-relation JavaScript module loading
Support for non JavaScriptModuleInstruction RequireJS invocations
in FormEngine has been dropped in #96221, but the s...
Benjamin Franzke
09:52 Revision 16afa1cd: [TASK] Remove invalid deprecation trigger in dashboard
The method DashboardInitializationService::getRequireJsModules()
triggers a deprecation error, but is is actually in ...
Benjamin Franzke

2022-09-22

13:49 Revision 518db50d: [BUGFIX] Show correct group label for system records
The New Record Wizard shows the correct header for
the "system" group again.
The change preserves the group's title ...
Markus Klein
12:53 Revision 308b6e5b: [BUGFIX] Improve performance of "View Upgrade Documentation"
This patch greatly improves the performance of the
"View Upgrade Documentation" module in the Install Tool.
The foll...
Andreas Fernandez
12:51 Revision 22082c47: [BUGFIX] Show correct group label for system records
The New Record Wizard shows the correct header for
the "system" group again.
The change preserves the group's title ...
Markus Klein
12:46 Revision 394d30a8: [BUGFIX] Prevent undefined array key in ProcessedFile
Resolves: #98412
Releases: main, 11.5
Change-Id: Idcb0a18ece3162940e0c883d41f0f2f9e1a740bd
Reviewed-on: https://revie...
Daniel Siepmann
12:46 Revision a05f9432: [BUGFIX] Prevent failed property access in PublicPropertyDeprecationTrait
Resolves: #98418
Releases: main, 11.5
Change-Id: Ic97959c358978b2032e5fa18aaec915552e2ff1a
Reviewed-on: https://revie...
Daniel Siepmann
12:35 Revision 2f082566: [BUGFIX] Prevent undefined array key in ProcessedFile
Resolves: #98412
Releases: main, 11.5
Change-Id: Idcb0a18ece3162940e0c883d41f0f2f9e1a740bd
Reviewed-on: https://revie...
Daniel Siepmann
12:34 Revision c40ba4a2: [TASK] Type hint BackendUserAuthentication->workspace to int
Public property BackendUserAuthentication->workspace is
always an integer and should be declared as such. This
avoids...
Christian Kuhn
12:22 Revision c6fed04a: [BUGFIX] Prevent failed property access in PublicPropertyDeprecationTrait
Resolves: #98418
Releases: main, 11.5
Change-Id: Ic97959c358978b2032e5fa18aaec915552e2ff1a
Reviewed-on: https://revie...
Daniel Siepmann
12:14 Revision defedd2d: [BUGFIX] Prevent undefined array key in AbstractItemProvider
Resolves: #98406
Releases: main, 11.5
Change-Id: I856ebd36c1f8c8906fa6b23834704bd2ee5531ad
Reviewed-on: https://revie...
Daniel Siepmann
11:39 Revision b0b2a1b3: [BUGFIX] Prevent undefined array key in AbstractItemProvider
Resolves: #98406
Releases: main, 11.5
Change-Id: I856ebd36c1f8c8906fa6b23834704bd2ee5531ad
Reviewed-on: https://revie...
Daniel Siepmann
11:10 Revision 7e5c9ed1: [BUGFIX] Render proper markup for datetime picker buttons
To make datetimer picker buttons focus the belonging textfield, the
buttons were rendered as `<label>` which is a ver...
Andreas Fernandez
08:54 Revision 2f70b7a1: [BUGFIX] Prevent undefined array key in SaveToDatabaseFinisher
Resolves: #98274
Releases: main, 11.5
Change-Id: I75e778b7c57ac5c165045aaec40c6f134c3ddb72
Reviewed-on: https://revie...
Oliver Bartsch
08:16 Revision 1e6d54e0: [BUGFIX] Prevent undefined array key in SearchController
Resolves: #98243
Releases: main, 11.5
Change-Id: I4347b6f293e582d00cffa4105d5a2641bf425bf9
Reviewed-on: https://revie...
Oliver Bartsch
08:15 Revision 16dcd211: [BUGFIX] Prevent undefined array key in SaveToDatabaseFinisher
Resolves: #98274
Releases: main, 11.5
Change-Id: I75e778b7c57ac5c165045aaec40c6f134c3ddb72
Reviewed-on: https://revie...
Oliver Bartsch
08:05 Revision 2b9bbbaa: [!!!][TASK] Enable natural ordering of YAML imports
A new feature flag "yamlImportsFollowDeclarationOrder"
was introduced with #92100 which was available in TYPO3 v10 an...
Benni Mack
07:56 Revision 7be898ac: [BUGFIX] Prevent undefined array key in SearchController
Resolves: #98243
Releases: main, 11.5
Change-Id: I4347b6f293e582d00cffa4105d5a2641bf425bf9
Reviewed-on: https://revie...
Oliver Bartsch
07:56 Revision 23454728: [TASK] Prevent undefined array key warnings in ext:adminpanel
This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
...
Oliver Hader
07:47 Revision 209c3b38: [BUGFIX] Streamline Changelog documentation tags
Tags attached to Changelog documentation files are
used in the install tool "View Upgrade Documentation"
as filters.
...
Christian Kuhn
07:40 Revision caec6d15: [TASK] Prevent undefined array key warnings in ext:adminpanel
This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
...
Oliver Hader
07:34 Revision cf39675a: [BUGFIX] Streamline Changelog documentation tags
Tags attached to Changelog documentation files are
used in the install tool "View Upgrade Documentation"
as filters.
...
Christian Kuhn
06:52 Revision fbe9c90b: [BUGFIX] Enforce EXT:backend as source for Source Sans fonts
As relative paths to the Source Sans font are used, this leads to errors
in the backend module of EXT:form as the pat...
Andreas Fernandez

2022-09-21

21:11 Revision eb96ea2d: [BUGFIX] Prevent undefined array keys in AbstractMenuContentObject
Resolves: #98248
Releases: main, 11.5
Change-Id: I365236b8aa959db5092a7c8ba1731674b12f053c
Reviewed-on: https://revie...
Oliver Bartsch
21:02 Revision f0cb504a: [BUGFIX] Prevent undefined array keys in AbstractMenuContentObject
Resolves: #98248
Releases: main, 11.5
Change-Id: I365236b8aa959db5092a7c8ba1731674b12f053c
Reviewed-on: https://revie...
Oliver Bartsch
19:15 Revision 62777247: [BUGFIX] Use values for link types
With #92715 the structure of the link types array
was unified to always use the types as array values.
This patch ad...
Oliver Bartsch
19:13 Revision 9a70d5f7: [TASK] Add label text to various buttons in docheader
All buttons on the left side of the docheader
should get a label to describe the functionality better.
In the next st...
Benni Mack
15:49 Revision 163e27ff: [TASK] Clean up AbstractUserAuthentication
This change renames variables and splits up
some logic in AbstractUserAuthentication in order
to allow further change...
Benni Mack
15:20 Revision 3b526e83: [BUGFIX] Use values for link types
With #92715 the structure of the link types array
was unified to always use the types as array values.
This patch ad...
Oliver Bartsch
15:02 Revision 5ee75580: [!!!][FEATURE] Add PSR-14 ModifyEditFormUserAccessEvent
This introduces a new PSR-14 event, enabling
extension authors to modify the user access
decision for creating / edit...
Oliver Bartsch
14:59 Revision 236ce5fc: [TASK] Avoid usage of UriBuilder and Extbase Request
Due to cleanups some, usages of Extbase's Request
and UriBuilder can be removed.
Resolves: #98398
Releases: main
Cha...
Benni Mack
14:37 Revision dabe04ec: [BUGFIX] Replace deprecated source-sans-pro with source-sans
The package `source-sans-pro` was renamed to `source-sans` in September
2020. npm annotates this deprecation during i...
Andreas Fernandez
14:35 Revision faa55d2f: [TASK] Have a minor phpstan happification in ext:belog
Resolves: #98397
Releases: main
Change-Id: Id3c3ee0a9de93062840ee0acc39a8c8917326535
Reviewed-on: https://review.typo...
Christian Kuhn
14:12 Revision fee75b26: [!!!][TASK] Enable internal subrequests for error pages
With TYPO3 v11, a new feature flag "subrequestPageErrors"
was added to avoid external requests when loading error pag...
Benni Mack
13:36 Revision f24de0da: [BUGFIX] Allow sorting of pages on root level
This patch takes care of a missing id in the request, which is the case
for the rootpage.
Resolves: #98392
Releases:...
Frank Nägler
13:36 Revision 07a7e335: [BUGFIX] Disable horizontal scrollbar in module menu
Resolves: #98395
Releases: main, 11.5
Change-Id: If2a8fba27d4a6250114b591055e3f49d603881d5
Reviewed-on: https://revie...
Andreas Fernandez
13:26 Revision 1ca828ac: [BUGFIX] Update missing file properties
Do not expect all properties to already exist.
Update properties with different value as well as missing properties.
...
Daniel Siepmann
13:18 Revision 088b745d: [!!!][TASK] Require ServerRequestInterface in Extbase Request
The Extbase Request still had a fallback to fetch
the base Request from $GLOBALS. The base Request
is of course a har...
Christian Kuhn
13:14 Revision d082f5e3: [BUGFIX] Allow sorting of pages on root level
This patch takes care of a missing id in the request, which is the case
for the rootpage.
Resolves: #98392
Releases:...
Frank Nägler
13:08 Revision 1d9e8248: [TASK] Avoid getIndpEnv and TYPO3_REQUEST in Link Builder
This change removes any usage of GeneralUtility::getIndpEnv()
in favor of NormalizedParams (non-global state) and
usi...
Benni Mack
13:03 Revision 3563b7d5: [BUGFIX] Disable horizontal scrollbar in module menu
Resolves: #98395
Releases: main, 11.5
Change-Id: If2a8fba27d4a6250114b591055e3f49d603881d5
Reviewed-on: https://revie...
Andreas Fernandez
13:02 Revision 37a3d6a3: [BUGFIX] Update missing file properties
Do not expect all properties to already exist.
Update properties with different value as well as missing properties.
...
Daniel Siepmann
13:00 Revision 56198c25: [BUGFIX] Don't ignore TCA 'ctrl' 'groupName'
The new records controller (list modul "+" button) tries
to group records. TCA 'ctrl' property 'groupName'
can be use...
Christian Kuhn
12:48 Revision f2981575: [BUGFIX] Don't ignore TCA 'ctrl' 'groupName'
The new records controller (list modul "+" button) tries
to group records. TCA 'ctrl' property 'groupName'
can be use...
Christian Kuhn
10:30 Revision c2df29b3: [BUGFIX] Darken progress bar for default and light panel
To have the progress bar visible on a panels using the
"default" or "light" theme variant, the progress bar
color is ...
Oliver Bartsch

2022-09-20

16:39 Revision a8887210: [BUGFIX] Use correct selector class in upgrade doc filter
The class `item` was removed in #98349, but the existing JavaScript code
still relied on that class. To solve the iss...
Andreas Fernandez
11:33 Revision a5fd2a71: [TASK] Remove unused configuration option
The feature flag "unifiedPageTranslationHandling"
has been active since TYPO3 v10, and can be removed
from the defaul...
Benni Mack
10:49 Revision 2accdb05: [TASK] Remove unused configuration option
The feature flag "unifiedPageTranslationHandling"
has been active since TYPO3 v10, and can be removed
from the defaul...
Benni Mack
07:21 Revision 06b37b43: [TASK] Type hint ext:fluid RenderingContext
The ext:fluid RenderingContext extends standalone fluid
RenderingContextInterface by adding getRequest(). This
object...
Christian Kuhn

2022-09-19

22:26 Revision 471d9178: [TASK] Avoid an invalid test prophecy
The class prophecy has not been imported and does
not seem to be needed for the test.
Resolves: #98379
Releases: mai...
Christian Kuhn
21:23 Revision 8660a5bb: [TASK] Clean up unused code from PreviewRenderer pattern
The PreviewRenderer pattern was added very late in
v10 development, along with a Resolver concept,
which was never pr...
Benni Mack
20:55 Revision edf20a9a: [!!!][TASK] Remove the not-useful hooks from EditFileController
Per the existing todo messages, these hooks are not useful and
better alternatives already exist. There's therefore n...
Larry Garfield
17:48 Revision 9202450c: [!!!][FEATURE] Add PSR-14 Events for customized Page Module rendering
The three legacy hooks
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['record_is_u...
Benni Mack
15:22 Revision 7ab6610d: [TASK] Prevent undefined array key warnings in ext:beuser
This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
...
Oliver Hader
15:22 Revision 08625d36: [TASK] Prevent undefined array key warnings in ext:beuser
This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
...
Oliver Hader
13:28 Revision 49006d96: [TASK] Prevent undefined array key warnings in ext:dashboard
This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
...
Oliver Hader
13:27 Revision 89281016: [TASK] Prevent undefined array key warnings in ext:dashboard
This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
...
Oliver Hader
09:25 Revision cdf920a6: [!!!][TASK] Upgrade to CodeMirror v6
CodeMirror v6 is a major rewrite of CodeMirror v5.
Existing addons and language parsers need to be rewritten.
There i...
Benjamin Franzke

2022-09-18

18:59 Revision b79f2853: [TASK] Deprecate StandaloneView getters
Views should be data sinks, but not data sources:
In Fluid, RenderingContext is the main state object
used to carry r...
Christian Kuhn
17:51 Revision d70a4798: [!!!][TASK] Cleanup and harden Extbase Request
The Extbase Request has been turned into a
PSR-7 decorator in v11. Most interface changes
have not been enforced in v...
Christian Kuhn
14:28 Revision 79459bb7: [TASK] Remove _DEFAULT_PI_VARS from TypoScript
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/75655 the `AbstractPlugin` was made internal.
Option `_DEFAULT_...
Lina Wolf
07:28 Revision 7117ba70: [BUGFIX] Guard array key access in TypoScriptFrontendController
This change ensure guarded array key access to avoid corresponding
native PHP undefined array key access warnings in ...
Stefan Bürk
07:24 Revision c82290c3: [BUGFIX] Avoid undefined array key access in HtmlParser
Resolves: #98317
Releases: main, 11.5
Change-Id: I4fc1cbd52dda8a9440a6256a5e61be7d89323232
Reviewed-on: https://revie...
Stefan Bürk
07:15 Revision b136c7a3: [BUGFIX] Guard array key access in TypoScriptFrontendController
This change ensure guarded array key access to avoid corresponding
native PHP undefined array key access warnings in ...
Stefan Bürk
07:14 Revision d7eed01d: [BUGFIX] Avoid undefined array key access in HtmlParser
Resolves: #98317
Releases: main, 11.5
Change-Id: I4fc1cbd52dda8a9440a6256a5e61be7d89323232
Reviewed-on: https://revie...
Stefan Bürk

2022-09-17

16:09 Revision 7c9f7627: [TASK] Request in ContentObject is not nullable
Single FE content objects (TEXT, IMAGE, ...) always receive
the PSR-7 request since v11: Instances are created via
Co...
Christian Kuhn

2022-09-16

19:12 Revision 574dc087: [TASK] Revamp Constant Editor
The patch rewrites TypoScript related code that uses
the comment based TypoScript configuration magic towards
the new...
Christian Kuhn
15:34 Revision 8aa42939: [FEATURE] Refactor Live Search UI and introduce keyboard shortcut to open
The live search located at the top right side of the TYPO3 backend now
uses a modal window to render the search contr...
Andreas Fernandez
14:22 Revision d65db90e: [TASK] Raise styleguide and testing-framework
Casual raise of typo3/cms-styleguide and typo3/testing-framework
to latest dev versions in main.
> composer u --dev ...
Christian Kuhn
13:06 Revision e6577539: [BUGFIX] Fix hide/unhide inline control for a special case
In case an inline field doesn't define the "disabled" column
in its "showitem" list, a hidden checkbox is now rendere...
Nikita Hovratov
12:38 Revision bc3d79e2: [DOCS] Clarify the page TSconfig settings for RTE
Link to the TSconfig reference where it makes sense,
also for setting page TSConfic, as this changed in v12.
We do no...
Lina Wolf
12:28 Revision 7c852b82: [BUGFIX] Fix hide/unhide inline control for a special case
In case an inline field doesn't define the "disabled" column
in its "showitem" list, a hidden checkbox is now rendere...
Nikita Hovratov
12:24 Revision df52a477: [BUGFIX] Fix avatar sizes and use medium size in SetupModuleController
If no size is explicitly given, the avatar size is based on the text
size, similar to icons. In the SetupModuleContro...
Andreas Fernandez
12:17 Revision dc105e34: [TASK] Streamline scheduler flash messages
The flash messages for the executed state and the
not executed state have been adapted to the previous flash messages...
Guido Schmechel
12:17 Revision 027b8804: [TASK] Streamline scheduler flash messages
The flash messages for the executed state and the
not executed state have been adapted to the previous flash messages...
Guido Schmechel
12:11 Revision 11caa711: [TASK] Add notification when Grunt "watch" finished compilation
This outputs a "bell" character to notify the developer that the "watch"
task has picked up and finished compilation ...
Jonas Eberle
12:09 Revision c5e1078a: [TASK] Remove wrong doc comments in \TYPO3\CMS\Core\Database\Connection
The doc comments for some functions in `\TYPO3\CMS\Core\Database\Connection`
state, that table expressions and column...
Torben Hansen
12:09 Revision 2861cbb5: [TASK] Remove wrong doc comments in \TYPO3\CMS\Core\Database\Connection
The doc comments for some functions in `\TYPO3\CMS\Core\Database\Connection`
state, that table expressions and column...
Torben Hansen
12:04 Revision 3df00792: [BUGFIX] Use array key access guard in WorkspaceVersionRecordsCommand
Resolves: #98337
Releases: main, 11.5
Change-Id: I048defb5d96c4365a2005a5a2c0adae806b3e298
Reviewed-on: https://revie...
Daniel Siepmann
12:04 Revision ffe8c056: [BUGFIX] Use array key access guard in WorkspaceVersionRecordsCommand
Resolves: #98337
Releases: main, 11.5
Change-Id: I048defb5d96c4365a2005a5a2c0adae806b3e298
Reviewed-on: https://revie...
Daniel Siepmann
11:54 Revision 4e303636: [!!!][TASK] Make the AbstractPlugin @internal
`\TYPO3\CMS\Frontend\Plugin\AbstractPlugin` is not a recommended way of
developing Frontend Plugins anymore. As long ...
Lina Wolf
11:52 Revision 65580b5a: [TASK] Allow flushing the makeInstance class name caches for testing
`GeneralUtility::flushInternalRuntimeCaches` now also flushes the caches
used by `makeInstance` to determine the fina...
Oliver Klee
11:51 Revision 0befe34d: [TASK] Remove wrong doc comments in \TYPO3\CMS\Core\Database\Connection
The doc comments for some functions in `\TYPO3\CMS\Core\Database\Connection`
state, that table expressions and column...
Torben Hansen
11:48 Revision 99a1a5d0: [TASK] Allow flushing the makeInstance class name caches for testing
`GeneralUtility::flushInternalRuntimeCaches` now also flushes the caches
used by `makeInstance` to determine the fina...
Oliver Klee
11:47 Revision 89e93da2: [BUGFIX] Avoid FE error if url field on external pages is empty
Circumvent 'Unitialized string offset' error when trying to prefix the
url of a page from type 'external page' when f...
Marc Willmann
11:38 Revision 58b6a5be: [BUGFIX] Use array key access guard in WorkspaceVersionRecordsCommand
Resolves: #98361
Releases: main, 11.5
Change-Id: Ib94267b45199a5cf5cce3fa48df51e53cff9a256
Reviewed-on: https://revie...
Daniel Siepmann
11:34 Revision 17018c84: [TASK] Allow flushing the makeInstance class name caches for testing
`GeneralUtility::flushInternalRuntimeCaches` now also flushes the caches
used by `makeInstance` to determine the fina...
Oliver Klee
11:32 Revision bbeb1ea7: [BUGFIX] Use array key access guard in SchedulerCommand
Resolves: #98359
Releases: main, 11.5
Change-Id: I2651ca3b0c5bbad93fc931134d2d2480d51f7af6
Reviewed-on: https://revie...
Daniel Siepmann
11:32 Revision 80d1fc5d: [BUGFIX] Avoid FE error if url field on external pages is empty
Circumvent 'Unitialized string offset' error when trying to prefix the
url of a page from type 'external page' when f...
Marc Willmann
11:25 Revision 114b6771: [BUGFIX] Use array key access guard in WorkspaceVersionRecordsCommand
Resolves: #98361
Releases: main, 11.5
Change-Id: Ib94267b45199a5cf5cce3fa48df51e53cff9a256
Reviewed-on: https://revie...
Daniel Siepmann
11:24 Revision 375ed157: [BUGFIX] Use array key access guard in SchedulerCommand
Resolves: #98359
Releases: main, 11.5
Change-Id: I2651ca3b0c5bbad93fc931134d2d2480d51f7af6
Reviewed-on: https://revie...
Daniel Siepmann
11:19 Revision 1f7cd867: [TASK] Add note about the Testing app context
The documentation clearly states that the Testing application context
may only be used internally.
This information ...
Markus Klein
11:19 Revision 26d15e3e: [BUGFIX] Avoid undefined array key in RecordLinkHandler
Resolves: #98232
Releases: main, 11.5
Change-Id: I8c1277a1d9b611785c6c852069d976033abda813
Reviewed-on: https://revie...
Kevin Appelt
11:19 Revision 48911e04: [TASK] Simplify BackendUserGroupRepository::findByUidList
Instead of creating new database queries for each user group,
corresponding items are fetched in just one query.
Res...
Oliver Hader
10:56 Revision a7e86376: [TASK] Simplify BackendUserGroupRepository::findByUidList
Instead of creating new database queries for each user group,
corresponding items are fetched in just one query.
Res...
Oliver Hader
10:49 Revision 4d2e0037: [BUGFIX] Avoid undefined array key in RecordLinkHandler
Resolves: #98232
Releases: main, 11.5
Change-Id: I8c1277a1d9b611785c6c852069d976033abda813
Reviewed-on: https://revie...
Kevin Appelt
10:48 Revision 899b23e3: [TASK] Remove superfluous jQuery UI theme in ext:viewpage
In ext:viewpage, jQuery UI resizable is used to allow an editor
to resize the iframe with the page preview. The fluid...
Torben Hansen
10:47 Revision 6a547d11: [TASK] Add note about the Testing app context
The documentation clearly states that the Testing application context
may only be used internally.
This information ...
Markus Klein
10:17 Revision 2a348bed: [BUGFIX] Use array key access guard in ExtensionManagementUtility
Resolves: #98358
Releases: main, 11.5
Change-Id: I4f1080dc4308660eff99c3a70a35c3917d688ab6
Reviewed-on: https://revie...
Daniel Siepmann
09:29 Revision 5a4e2ceb: [BUGFIX] Use array key access guard in ExtensionManagementUtility
Resolves: #98358
Releases: main, 11.5
Change-Id: I4f1080dc4308660eff99c3a70a35c3917d688ab6
Reviewed-on: https://revie...
Daniel Siepmann
09:24 Revision dfeebaa5: [TASK] Streamline colors, correct contrast colors
The core currently uses a wide range of
state colors across the backend. This is
a mixture of defined colors for spec...
Benjamin Kott
09:12 Revision 3efb7afc: [BUGFIX] Rename modal's title property to modalTitle
In #98288 the modal component was rewritten to be a lit element. The
modal title was defined by a `title` attribute. ...
Andreas Fernandez

2022-09-15

21:20 Revision 3aa034cd: [BUGFIX] Allow injection of RenderingContextFactory
This change allows the injection of the fluid
RenderingContextFactory while disallowing the
direct injection of the R...
Susanne Moog
13:44 Revision 4f58efdd: [DOCS] Improve doc comments for events for modifying flex form parsing
I added and improved non-trivial method descriptions from the Changelog
descriptions here: https://review.typo3.org/c...
Lina Wolf

2022-09-13

17:10 Revision 2996c211: [TASK] styleguide: Add ext_conf_template.txt documented bool different true value
This is documented but not working in current
ext-settings core.
Christian Kuhn
16:08 Revision 878af9a8: [TASK] styleguide: Finetune ext_conf_template.txt
int=int+ with range is supposed to work, but does not
add min/max to input fields right now.
Releases: main, 11
Christian Kuhn
11:37 Revision fd66367a: [TASK] styleguide: Slightly restructure ext_conf_template.txt examples
Releases: main, 11 Christian Kuhn
09:55 Revision f1e23cd7: [TASK] Set TYPO3 version to 11.5.17-dev
Change-Id: I4b2648148ee8b112fc71d76d0730893f102785a1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/757...
Oliver Hader
09:53 Revision dd0c7dbb: [TASK] Set TYPO3 version to 10.4.33-dev
Change-Id: Ib8ba8cc8c720f50691897abc59fda00fef32e905
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/757...
Oliver Hader
08:55 Revision bb2cf378: [RELEASE] Release of TYPO3 11.5.16
Change-Id: I5d3e7def4c0c254f46061591081e7ccc33b60bc5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/757...
Oliver Hader
08:51 Revision 1a3a7c13: [RELEASE] Release of TYPO3 10.4.32
Change-Id: I6dc1c8bd8f1c308ccc283de2d801e0821fb7253e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/757...
Oliver Hader
08:11 Revision d4f26057: [SECURITY] Upgrade to typo3/html-sanitizer v2.0.16
see https://github.com/TYPO3/html-sanitizer/releases/tag/v2.0.16
composer req masterminds/html5:^2.7.6 typo3/html-sa...
Oliver Hader
08:10 Revision 6863f738: [SECURITY] Encode child node variables in f:asset.css view helper
Variables in child nodes like `<f:asset.css>{value}</f:asset.css>`
were not encoded and allow cross-site scripting. I...
Oliver Hader
08:09 Revision bd58d2ff: [SECURITY] Mitigate cross-site-scripting in FileDumpController
FileDumpController is used to expose stored files from the backend
user interface through a corresponding service-sid...
Oliver Hader
08:09 Revision 56af2bd3: [SECURITY] Respect expiration time of password reset token
When a TYPO3 backend user performs a password reset request, a
password reset link including an expiration time is se...
Torben Hansen
08:08 Revision f8b83ce1: [SECURITY] Mitigate timing discrepancies during user authentication
Observing response time during user authentication can be used to
distinguish between existing and non-existing user ...
Oliver Hader
08:08 Revision 179dd7cd: [SECURITY] Mitigate denial-of-service scenarios in page error handler
This fixes TYPO3-CORE-SA-2021-005 again, which accidentally had
been removed during TYPO3 v11 development. An inacces...
Oliver Hader
08:07 Revision ff648557: [SECURITY] Upgrade to typo3/html-sanitizer v2.0.16
see https://github.com/TYPO3/html-sanitizer/releases/tag/v2.0.16
composer req masterminds/html5:^2.7.6 typo3/html-sa...
Oliver Hader
08:07 Revision c62e16fa: [SECURITY] Encode child node variables in f:asset.css view helper
Variables in child nodes like `<f:asset.css>{value}</f:asset.css>`
were not encoded and allow cross-site scripting. I...
Oliver Hader
08:07 Revision 54620842: [SECURITY] Mitigate cross-site-scripting in FileDumpController
FileDumpController is used to expose stored files from the backend
user interface through a corresponding service-sid...
Oliver Hader
08:07 Revision 00b52a44: [SECURITY] Respect expiration time of password reset token
When a TYPO3 backend user performs a password reset request, a
password reset link including an expiration time is se...
Torben Hansen
08:07 Revision f0fc9c4c: [SECURITY] Mitigate timing discrepancies during user authentication
Observing response time during user authentication can be used to
distinguish between existing and non-existing user ...
Oliver Hader
08:07 Revision fc51ccbf: [SECURITY] Mitigate denial-of-service scenarios in page error handler
This fixes TYPO3-CORE-SA-2021-005 again, which accidentally had
been removed during TYPO3 v11 development. An inacces...
Oliver Hader
08:07 Revision f421d079: [SECURITY] Upgrade to typo3/html-sanitizer v2.0.16
see https://github.com/TYPO3/html-sanitizer/releases/tag/v2.0.16
composer req masterminds/html5:^2.7.6 typo3/html-sa...
Oliver Hader
08:06 Revision ffb89e07: [SECURITY] Encode child node variables in f:asset.css view helper
Variables in child nodes like `<f:asset.css>{value}</f:asset.css>`
were not encoded and allow cross-site scripting. I...
Oliver Hader
08:06 Revision b880477e: [SECURITY] Mitigate cross-site-scripting in FileDumpController
FileDumpController is used to expose stored files from the backend
user interface through a corresponding service-sid...
Oliver Hader
08:06 Revision dffc7506: [SECURITY] Respect expiration time of password reset token
When a TYPO3 backend user performs a password reset request, a
password reset link including an expiration time is se...
Torben Hansen
08:06 Revision 84285835: [SECURITY] Mitigate timing discrepancies during user authentication
Observing response time during user authentication can be used to
distinguish between existing and non-existing user ...
Oliver Hader
07:57 Revision 8f788d94: [TASK] Prevent undefined array key warnings in ext:belog
This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
...
Oliver Hader
07:50 Revision fdef8e79: [BUGFIX] Revert modified cache handling in form framework
The changes applied for issue #93887 introduced a bunch of
regressions, which were partially addressed. However, ther...
Oliver Hader
07:50 Revision 052e4f6d: [BUGFIX] Revert modified cache handling in form framework
The changes applied for issue #93887 introduced a bunch of
regressions, which were partially addressed. However, ther...
Oliver Hader
07:37 Revision fce78035: [TASK] Prevent undefined array key warnings in ext:belog
This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
...
Oliver Hader
05:46 Revision bf351f80: [TASK] Resolve cgl violations in php files
With #98331 friendsofphp/php-cs-fixer has been raised in
v11. However, pre-merge ci only scans for cgl in changed
php...
Stefan Bürk

2022-09-12

15:03 Revision 8809778f: [BUGFIX] Mark config.disableImgBorderAttr as removed
With the change #98308 it was forgotten that the
TypoScript property "config.disableImgBorderAttr"
is removed as well...
Benni Mack
12:07 Revision 1e51b1e8: [!!!][TASK] Remove TypoScript option page.CSS_inlineStyle
In order to consolidate TypoScript options,
the TypoScript option page.CSS_inlineStyle is removed
in favor of the muc...
Benni Mack
10:13 Revision 74b597cb: [TASK] Use same version of friendsofphp/php-cs-fixer as in v12
To avoid divergent code-style results among other Git branches,
package friendsofphp/php-cs-fixer is upgraded to vers...
Oliver Hader
09:08 Revision 15244ac2: Register Icons in Icons.php (#350)
See https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.4/Feature-94692-RegisteringIconsViaServiceContain... Lina Wolf

2022-09-09

11:00 Revision 50a2955d: [TASK] Unify badge rendering
Badges are currently in an inconsistent state
and sometimes the severity it shows is not
related to the contents of t...
Benjamin Kott
10:36 Revision 3886f492: [!!!][TASK] Remove border and longdescURL properties from IMAGE cObject
HTML deprecated the "border" attribute and the "longdesc"
attributes which are not set anymore by TYPO3's Frontend.
...
Benni Mack
09:49 Revision 85ee6967: [!!!][FEATURE] Add generic language overlay PSR-14 events instead of hooks
New PSR-14 events are introduced in favor of old hooks
within PageRepository which are related to overlaying
records....
Benni Mack
09:45 Revision 91d81bde: [BUGFIX] Handle undefined tt_content_defValues in NewContentElementController
Resolves: #98306
Releases: 11.5
Change-Id: I7a5ec64e330a6a779abb5ed95eb6c70acb221785
Reviewed-on: https://review.typo...
Andreas Fernandez
09:43 Revision 2ac5966b: [FEATURE] Option to configure primary actions in File List
The primary actions in the file list visible as dedicated buttons in the
table list are now configurable on a backend...
Shehfinaz Kadavil
09:40 Revision 4ed3e780: [DOCS] Fix rendering of Events in the docu
Fixed the display of pseudocode to simple rest as these get
displayed in TYPO3 Explained. This resolves rendering
war...
Lina Wolf
09:18 Revision 71d08252: [DOCS] Fix rendering of Events in the docu
Fixed the display of pseudocode to simple rest as these get
displayed in TYPO3 Explained. This resolves rendering
war...
Lina Wolf
09:14 Revision 9413a841: [TASK] Cleanup Components
This patch cleans up and streamlines the dropdown,
datepicker and context menu css components.
They now look unified...
Benjamin Kott
07:00 Revision ac0a6917: [!!!][TASK] Remove jQuery in PersistentStorage
All requests are changed to use the AJAX API. Due to this, the return
type of some methods is changed, resulting in a...
Andreas Fernandez

2022-09-08

18:08 Revision 38911bf9: [TASK] Provide more details when calling TSFE->set_no_cache()
When TSFE->set_no_cache() is called without a reason
(usually through third-party code), the Logger now
ships with mo...
Benni Mack
16:16 Revision f71c9f8e: [BUGFIX] Prevent undefined array key error in StoragePermissionsAspect
For not yet migrated filemount records, the
StoragePermissionsAspect previously triggered
an undefined array key sinc...
Oliver Bartsch
15:32 Revision a6c6c0d7: [BUGFIX] Trim provided external URL in linkwizard modal
Avoid mistakes, especially by copy & paste, and trim the given data
before closing the modal and delegating the data....
Georg Ringer
15:28 Revision d5deccc1: [!!!][TASK] Migrate backend modal component to lit
Avoid jQuery and especially the bootstrap
jQuery compat layer.
Use lit as template engine instead of jQuery compositi...
Benjamin Franzke
15:20 Revision 3b6bba8e: [BUGFIX] Trim provided external URL in linkwizard modal
Avoid mistakes, especially by copy & paste, and trim the given data
before closing the modal and delegating the data....
Georg Ringer
15:19 Revision aac4dbd8: [BUGFIX] Properly evaluate whether toolbar item provides a dropdown
The ToolbarItemInterface requires the methods
hasDropDown() as well as getDropDown(). Since
#98214 the evaluation whe...
Oliver Bartsch
14:52 Revision 13d9833e: [BUGFIX] Do not render clipboard errors as notification
If a backend user switches pages in the list module right after the
clipboard is being loaded, the error message "An ...
Andreas Fernandez
14:37 Revision c15ce087: [BUGFIX] Remove fixed height of login news carousel
Resolves: #98245
Releases: main
Change-Id: I03f3d485b75e1475d651479142bed40897c2b992
Reviewed-on: https://review.typo...
Oliver Bartsch
14:35 Revision 9dcfb07d: [BUGFIX] Do not render clipboard errors as notification
If a backend user switches pages in the list module right after the
clipboard is being loaded, the error message "An ...
Andreas Fernandez
11:48 Revision 0e075d1e: [!!!][FEATURE] Add PSR-14 Events for flex form parsing
Four new PSR-14 Events are added, which allow to fully
control the flex form parsing in an object-oriented
way. They ...
Larry Garfield

2022-09-07

18:39 Revision 8ec21ef9: [TASK] Streamline datepicker component styling
The datetimepicker (flatpickr) is now not based on
the Bootstrap DateTimePicker (which was used before),
but uses nat...
Benjamin Kott
17:56 Revision 6a60892c: [TASK] Avoid further usages of Environment::getBackendPath()
This change adapts various places where tests
are run / simulated to be in "Backend Context" (such as
ConditionMatche...
Benni Mack
17:33 Revision 0056c946: [TASK] Remove jQuery from create multiple pages wizard
Resolves: #98280
Releases: main
Change-Id: I81078af2444b78df9eb26d0495fcb7cc73315162
Reviewed-on: https://review.typo...
Oliver Bartsch
17:19 Revision cd71e842: [TASK] Remove jQuery from link browser component
This patch removes any usage of jQuery from the link browser
JS component. Additionally, some obsolete functionality
...
Oliver Bartsch
17:17 Revision 39a05afd: [FEATURE] Add TypeConverter for enums
With PHP 8.1 we got Enums, to use them also in our extbase actions,
a new TypeConverter is added with this patch.
Th...
Matthias Vogel
16:08 Revision 7a2600c5: [TASK] Deprecate TYPO3_mainDir
This patch deprecates the constant "TYPO3_mainDir"
in favor of a BackendEntryPointResolver which
contains the informa...
Benni Mack
15:24 Revision 7f07a56e: [TASK] Remove jQuery from EXT:rte_ckeditor
This patch removes any usage of jQuery from EXT:rte_ckeditor. Some
obsolete handling from times when the link browser...
Andreas Fernandez
12:20 Revision 801003d1: [TASK] Use current git repository links
README.md and CONTRIBUTING.md use the current repository links with this change.
The change also includes several min...
Stephan Großberndt
12:20 Revision 08cc061f: [TASK] Use current git repository links
README.md and CONTRIBUTING.md use the current repository links with this change.
The change also includes several min...
Stephan Großberndt
12:19 Revision 184a8e9c: [BUGFIX] Use correct data attribute name for doktype select
When changing the doktype of a page in the "create multiple pages"
wizard, the corresponding icon does now correctly ...
Oliver Bartsch
12:00 Revision ca78f10b: [TASK] Remove jQuery from constant editor
This patch removes any usage of jQuery from the constant
editor JS component. Additionally, some obsolete functionali...
Oliver Bartsch
11:56 Revision 92a49822: [BUGFIX] Use correct data attribute name for doktype select
When changing the doktype of a page in the "create multiple pages"
wizard, the corresponding icon does now correctly ...
Oliver Bartsch
09:55 Revision 9c619ca0: [TASK] Avoid using AJAX request route in Backend
Since TYPO3 v7 the RequestType Ajax was used
to identify AJAX routes. This is nowadays only
used in FormProtectionFac...
Benni Mack
09:27 Revision df53c96b: [!!!][TASK] Remove possibility to pre-define link titles in link browser
Back in the old HTMLArea it was possible to pre-define a link title in
the `classesAnchor` configuration which got ap...
Andreas Fernandez
08:34 Revision 21414f53: [BUGFIX] Check if titleText is available in classesAnchor RTE config
Resolves: #98273
Releases: main, 11.5
Change-Id: I521d855fb4dc8fbafb302de16f8d446abfb4d9e1
Reviewed-on: https://revie...
Andreas Fernandez
07:37 Revision 38f19026: [BUGFIX] Check if titleText is available in classesAnchor RTE config
Resolves: #98273
Releases: main, 11.5
Change-Id: I521d855fb4dc8fbafb302de16f8d446abfb4d9e1
Reviewed-on: https://revie...
Andreas Fernandez
04:35 Revision bbaccb71: [DOCS] Clarify the page TSconfig settings for RTE
Link to the TSconfig reference where it makes sense,
also for setting page TSConfic, as this changed in v12.
We do no...
Lina Wolf

2022-09-06

20:41 Revision 77d89a97: [TASK] Drop usage of sass:math
Resolves: #98269
Releases: main
Change-Id: Ibdaf9319071b3b596330a3be41c17a862a247b8a
Reviewed-on: https://review.typo...
Benjamin Kott
20:37 Revision 5ec5f3b8: [TASK] Drop unneeded file .cache/.npmrc
`unsafe-perm = true` is not available in npm v8 documentation,
and TYPO3 core requires npm =>v8.
The file has been in...
Benjamin Franzke
20:35 Revision b1b0005a: [TASK] Avoid PHP8.2 related deprecation failure in unit test
With PHP8.2 setting dynamic properties has been deprecated. This
is also valid if it is set through unserialization a...
Stefan Bürk
19:53 Revision f6777841: [TASK] Use current git repository links
README.md and CONTRIBUTING.md use the current repository links with this change.
The change also includes several min...
Stephan Großberndt
19:22 Revision ba6a5c73: [TASK] Update stylelint to ^14
Commands executed:
npm install --save-dev grunt-stylelint@^0.18 stylelint@^14.11 stylelint-order stylelint-scss
n...
Benjamin Kott
18:34 Revision c53a565d: [TASK] Avoid PHP8.2 related deprecation failure in unit test
With PHP8.2 setting dynamic properties has been deprecated. This
is also valid if it is set through unserialization a...
Stefan Bürk
18:16 Revision 74eafb8a: [BUGFIX] Correct Backend Scaffold
During the migration to bootstrap the scaffold was reworked and is now flowing
incorrectly. The introduction flex on ...
Benjamin Kott
18:14 Revision 969c2a9e: [FEATURE] Set content language direction in RichText elements
Set the content language of RichText elements based on the direction
of the site language of the given element.
Reso...
Georg Ringer
16:04 Revision d868873c: [TASK] Modernize ext:belog
* Use strict function argument and return types where possible
* Removed superfluous argument and return type doc com...
Torben Hansen
09:48 Revision eb97d4c3: [BUGFIX] List invalid field in FormEngine review
The FormEngine review module broke with the introduction of Bootstrap 5
due to changed API of its Popover module.
Ou...
Andreas Fernandez
07:49 Revision 8e860361: [TASK] Use getLanguageOverlay() consistently
This change removes all usages of "getRecordOverlay"
to slowly phase out "getRecordOverlay" as a legacy method,
where...
Benni Mack
07:24 Revision 08e7dc70: [!!!][TASK] Remove jQuery in Popover
The support for jQuery in the module `@typo3/backend/popover` has been
dropped. Passing jQuery elements to the module...
Andreas Fernandez

2022-09-05

13:17 Revision 2e9a6710: [BUGFIX] List invalid field in FormEngine review
The FormEngine review module broke with the introduction of Bootstrap 5
due to changed API of its Popover module.
Ou...
Andreas Fernandez
10:24 Revision 285ae7d3: [BUGFIX] Fix condition in EXT:impexp to check for export view
The check for `inData.action` didn't work anymore for a long time as
`action` is not set in the controllers anymore. ...
Andreas Fernandez
10:23 Revision 258645ae: [TASK] Remove jQuery from EXT:impexp and EXT:info
Some small JavaScripts used in EXT:impexp and EXT:info are migrated to
remove the dependency on jQuery.
Resolves: #9...
Andreas Fernandez
10:15 Revision c68017aa: [TASK] Update settings snippet: use default values everywhere
All values are default values except the redirectTTL value.
Releases: main, 11.5, 10.4
Resolves: #98238
Change-Id: I...
Josef Glatz
10:15 Revision 2e67318d: [TASK] Update settings snippet: use default values everywhere
All values are default values except the redirectTTL value.
Releases: main, 11.5, 10.4
Resolves: #98238
Change-Id: I...
Josef Glatz
10:01 Revision 44a189ab: [BUGFIX] Fix condition in EXT:impexp to check for export view
The check for `inData.action` didn't work anymore for a long time as
`action` is not set in the controllers anymore. ...
Andreas Fernandez

2022-09-02

19:20 Revision e501f49d: [TASK] Temporarly avoid PHPStan composer-max tests fails
PHPStan fails with composer max installation due
changes in the detection. Raising the version to
corresponding versi...
Stefan Bürk
18:23 Revision 1354558d: [TASK] Temporarly avoid PHPStan composer-max tests fails
PHPStan fails with composer max installation due
changes in the detection. Raising the version to
corresponding versi...
Stefan Bürk
15:57 Revision 8bfd84d5: [TASK] Update settings snippet: use default values everywhere
All values are default values except the redirectTTL value.
Releases: main, 11.5, 10.4
Resolves: #98238
Change-Id: I...
Josef Glatz
14:48 Revision 85e317d5: [TASK] Avoid unsolveable phpstan error for return-type mismatch
PHP8.1 introduced native return types to native methods
and interfaces, which crashes if they are not compatible.
As ...
Stefan Bürk
14:48 Revision 6bed3af2: [TASK] Avoid unsolveable phpstan error for return-type mismatch
PHP8.1 introduced native return types to native methods
and interfaces, which crashes if they are not compatible.
As ...
Stefan Bürk
12:48 Revision fc06de9e: [TASK] Render toolbar items in Fluid
Items were previously rendered in BackendController into a large HTML
string that was passed to Fluid. This commit re...
Andreas Fernandez
10:54 Revision d0f2fc6b: [BUGFIX] Add missing outer-container classes for foreign selector types
With patch #97786 a bug was fixed, to only toggle inline controls in
their own scope. For this a new helper class was...
Nikita Hovratov
10:39 Revision c7c48069: [BUGFIX] Add missing outer-container classes for foreign selector types
With patch #97786 a bug was fixed, to only toggle inline controls in
their own scope. For this a new helper class was...
Nikita Hovratov

2022-09-01

09:22 Revision 1582cdc3: [TASK] Remove unused variable $dbType in DataHandler
Resolves: #98234
Related: #97462
Releases: main
Change-Id: I415b289ce4cb889e5b6fb85e9fb0746aac771865
Reviewed-on: htt...
Nikita Hovratov

2022-08-30

11:34 Revision 6130ea33: [DOCS] Fix links to Events
Releases: main, 11.5
Resolves: #98219
Change-Id: Ib60a14ff4a80eb4333187d3eff4ebf2a0262383d
Reviewed-on: https://revie...
Lina Wolf
10:59 Revision ca7ac42d: [DOCS] Fix links to Events
Releases: main, 11.5
Resolves: #98219
Change-Id: Ib60a14ff4a80eb4333187d3eff4ebf2a0262383d
Reviewed-on: https://revie...
Lina Wolf
10:59 Revision 1095aa5b: [DOCS] Fix section on how to open the dashboard
Replace the todo with information. Thanks at Florian Weiss for pointing this
out and providing me with the screenshot...
Lina Wolf
10:58 Revision f3293b7c: [DOCS] Fix section on how to open the dashboard
Replace the todo with information. Thanks at Florian Weiss for pointing this
out and providing me with the screenshot...
Lina Wolf

2022-08-27

22:32 Revision 4745dcc6: [TASK] Temporarly skip mailer unit test execution with PHP8.1
Symfony recently released new version v5.4.12 and v6.1.4 of the
framework which contains a change in `symfony/mailer`...
Stefan Bürk
22:30 Revision dd9cd004: [TASK] Temporarly skip mailer unit test execution with PHP8.1
Symfony recently released new version v5.4.12 and v6.1.4 of the
framework which contains a change in `symfony/mailer`...
Stefan Bürk

2022-08-26

17:19 Revision 1e52b401: [TASK] Ensure php files contain correct legal file header
Core php file header check got silently be disabled. Since
then the one or other file header error has slipped into
t...
Stefan Bürk

2022-08-25

12:03 Revision af2e5c07: [TASK] Streamline core php files header
Automatic check of php file header has been silently disabled
somewhere in the past, thus wrong file headers has slip...
Stefan Bürk
07:44 Revision 35785561: [TASK] Set TYPO3 version to 11.5.16-dev
Change-Id: Ic0df4413b78775ca2c9fc17e0180c4f1ba3db6c5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/755...
Oliver Hader
07:04 Revision 54ef8cee: [RELEASE] Release of TYPO3 11.5.15
Change-Id: I16a29c9ce3ae6d3d430b2d09b0cc952533e67cfe
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/755...
Oliver Hader
03:35 Revision 0787c222: [TASK] Update vulnerable build dependencies
Update (most) vulnerable dependencies/packages found by
`npm audit fix --force --dry-run`.
Notes redarding package c...
Benjamin Franzke
 

Also available in: Atom