TYPO3 Core

As amazing at is may sound, I confirm that it is so. I was facing a blank page in a workspace preview and started looking for related bugs. Disabling my page made the content appear...

Can confirm this problem and behavior.

I can confirm this behavior in TYPO3 8.7.8. I tried Florian's patch, and it does appear to fix the issue (after starting over with the content edits). Should this be considered a regression?

Just tried the patch and it worked for us. TYPO3 8.7.10.

Sorry wrong patch target commit. My apologies

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55967

The patch doesn't work for us. We've tried on TYPO3 8.7.20 (cleaned).

These the start conditions:
- In LIVE, page already published, but not visible (hidden=1)
- In WORKSPACE, the same page was modified adding a new content element

If the page in workspace is hidden as in LIVE, the new content is visible via preview and preview link.
If the page in workspace is visible (hidden=0), all contents in the page aren't visible.

We have found a possible problem in the TYPO3 core:

class: TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController
method: determineIdIsHiddenPage

protected function determineIdIsHiddenPage()
{
   //...
   if ($workspace !== 0 && $workspace !== false) {
        // Fetch overlay of page if in workspace and check if it is hidden
        $pageSelectObject = GeneralUtility::makeInstance(PageRepository::class);
        $pageSelectObject->versioningPreview = true;
        $pageSelectObject->init(false);
        $targetPage = $pageSelectObject->getWorkspaceVersionOfRecord($this->whichWorkspace(), 'pages',
          $page['uid']);

        //>>>>>>> here a problem: in this case getWorkspaceVersionOfRecord return an array with ws page
        $result = $targetPage === -1 || $targetPage === -2 || (is_array($targetPage) && $targetPage['hidden'] == 0 && $page['hidden'] == 1);
        //<<<<<<
   } else {
       $result = is_array($page) && ($page['hidden'] || $page['starttime'] > $GLOBALS['SIM_EXEC_TIME'] || $page['endtime'] != 0 && $page['endtime'] <= $GLOBALS['SIM_EXEC_TIME']);
   }
}

As a work around, we fixed with this row:

$result = $targetPage === -1 || $targetPage === -2 || (is_array($targetPage) && $targetPage['hidden'] == 0 && $page['hidden'] == 1);

Gianluca

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55967

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55967

The issue still exists in v9.5.4 and is reproducible with the exact same steps as in the initial bug report.
However, we've also encountered this issue when creating a new page in the workspace.

Steps to reproduce:
1. Create a workspace and use it
2. Create a new page
3. Add some content elements to the page
4. Enable the newly created page (Right click in the page tree on the page -> "Enable")
5. Preview the page (Right click in the page tree on the page -> "Show")

Result: The created content elements are not visible.

To get the expected result (be able to view the content elements) you must disable the page.
1. Disable the created page again (Right click in the page tree on the page -> "disable")
2. Reload the preview page

Result: The content elements are visible.

You'll be able to view the content elements, regardless if the page is enabled or not, if you apply the workaround from Gianluca Strafella.
Note: You must flush all caches after editing the TypoScriptFrontendController.

I report here my comment 6 on #83065 as a quick way to reproduce the issue on the latest master:

The issue is still present on 10.0.0-dev (latest master); it is easy to reproduce:

1) Have a plain TYPO3 installation
2) Create a draft Workspace
3) Create a page in the Workspace
4) Add a content element to the page
5) Save and preview the page

Expected result:¶

the content element should be visible in the preview

Current result¶

the content element is not visible.

if the page created in workspace is marked as hidden (disabled), then the content element becomes visible (tested with 10.0.0-dev).

Please note that #83065 had this review attached https://review.typo3.org/54724 that was abandoned.

Please note that #85742 had this review attached https://review.typo3.org/57822 that was reverted with https://review.typo3.org/58838

Im not sure if i should open up a new bug but i think this is related:
This also applies to live pages with unmet start and expiration date conditions.

Steps to reproduce (TYPO3 8-10):
1) Have a plain TYPO3 installation
2) Create a draft Workspace
3) Create a page in live mode
4) Add a content element to that page
5) Set the expiration date of the page to something in the past and save
6) Switch to draft Workspace
7) Remove the expiration date from the page
8) Save and preview the page

Expected result:
You should be able to see page and its content elements.

Current result:
You'll be able to view the page but no content elements appear.

The patch in this issue fixes the problem for this issue but not for the related #85003. The proposed patch of Gianluca fixes both issues. But as I stated in #85003 it seems to me that none of the patches tackle the right spot.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215

If I repeat my test on comment 16, it looks like the issue is already resolved even without the patch (tested on latest master) ; am I wrong?

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215

Test on comment 18 still happens on latest master