Bug #91808

Nested IRRE with maxitems hides last inline control button / toggles inline control buttons wrong

Added by Philipp Thiele 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2020-07-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In TYPO3 Version 10.4.5 i have configured a nested inline relation:

'tx_sitepackage_stageitems' => [
    'exclude' => 1,
    'label' => 'LLL:EXT:sitepackage/Resources/Private/Language/locallang_db.xlf:tt_content.tx_sitepackage_stageitems',
    'config' => [
        'type' => 'inline',
        'foreign_table' => 'tx_sitepackage_domain_model_stageitem',
        'foreign_field' => 'contentelement',
        'minitems' => 1,
        'maxitems' => 3,
        'appearance' => [
            'collapseAll' => 1
        ],
    ]
],

In tx_sitepackage_stageitems i have configured a FAL relation:

'image' => array(
    'exclude' => 0,
    'label' => 'LLL:EXT:sitepackage/Resources/Private/Language/locallang_db.xlf:tx_sitepackage_domain_model_stageitem.image',
    'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
        'image',
        [
            'appearance' => [
                'fileUploadAllowed' => false
            ],
            'minitems' => 1,
            'maxitems' => 1
        ],
        $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
    ),
),

When an editor adds the last (third) tx_sitepackage_domain_model_stageitem, in this last one no file selector is shown for the image field.
sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js toggles all (even the nested) .t3js-inline-controls, and not only its own.


Files


Related issues

Related to TYPO3 Core - Bug #92381: Button "Create new" does not re-appear for inline (IRRE) elements after reaching maxitems and removing one elementClosed2020-09-23

Actions
Related to TYPO3 Core - Bug #78479: FAL field (in flexform) with minitems=1 and maxitems=1 has no possibility to add image after deleting the previous oneClosed2016-10-28

Actions
Related to TYPO3 Core - Bug #92382: levelLinksPosition=bottom is not working correctly especially with minitems=1 set and leads to misbehaviour in inline children Accepted2020-09-23

Actions
#1

Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65058

#2

Updated by Daniel Goerz 4 months ago

  • Description updated (diff)
#3

Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65058

#4

Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65058

#5

Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65058

#6

Updated by Anja Leichsenring 3 months ago

I created a styleguide example for the issue: https://github.com/TYPO3/styleguide/pull/159

#7

Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65728

#8

Updated by Nikita Hovratov 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Gerrit Code Review 2 months ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65728

#10

Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65728

#11

Updated by Nikita Hovratov 2 months ago

  • Status changed from Under Review to Resolved
#12

Updated by Oliver Bartsch 2 months ago

  • Related to Bug #92381: Button "Create new" does not re-appear for inline (IRRE) elements after reaching maxitems and removing one element added
#13

Updated by Oliver Bartsch 2 months ago

  • Related to Bug #78479: FAL field (in flexform) with minitems=1 and maxitems=1 has no possibility to add image after deleting the previous one added
#14

Updated by Christian Buelter 2 months ago

  • Related to Bug #92382: levelLinksPosition=bottom is not working correctly especially with minitems=1 set and leads to misbehaviour in inline children added
#15

Updated by Benni Mack 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF