Activity
From 2022-01-15 to 2022-02-13
2022-02-13
-
10:47 Revision a80d2079: [TASK] Tag importmaps to include configuration for dynamic imports
- Dynamic JavaScript imports require their respective importmap
configurations to be loaded, therefore it is now allowe...
2022-02-12
-
15:08 Revision 900a91ef: [BUGFIX] Avoid always enabled clipboard in RecordListController
- Streamlining RecordListController with #96784 simplified
determiniation, if clipboard should be displayed or not.
Thi... -
13:58 Revision 1a215aa7: [!!!][TASK] Remove handling core caches with 'cache_' prefix
- The core related caches have been renamed from
'cache_foo' to 'foo' in v10 already, together with
a deprecation fallb... -
13:48 Revision f3324616: [TASK] Remove confusing doc comments in extbase
- Some extbase classes related to FAL have been added
back in 2012 with the doc comment, that classes are
experimental ... -
- Casual "pre-merge" patches (pushing a patch) to CI
gives us two stages: An "early" stage checking CGL
and composer ba... -
- There are a couple of functional tests marked
"incomplete" since 2019. Tests that have been
skipped for so long are p... -
- Casual "pre-merge" patches (pushing a patch) to CI
gives us two stages: An "early" stage checking CGL
and composer ba... -
13:16 Revision 6361a1ca: [TASK] Replace GeneralUtility::_GP in database and file browser
- Use the PSR-7 request instead of Superglobals.
Resolves: #96840
Releases: main
Change-Id: Iec2e1299584b09aa1967a93c3... -
- There are a couple of functional tests marked
"incomplete" since 2019. Tests that have been
skipped for so long are p... -
12:32 Revision 7638cd3e: [TASK] Declare all controllers of ext:recycler as strict typed
- Set all missing files to declare(strict_types=1);
Resolves: #96847
Releases: main
Change-Id: Ic4ba42f904702357b4b52c... -
- Set all missing files to declare(strict_types=1);
Resolves: #96842
Releases: main
Change-Id: Ia7ec9ed049fd875481bcf2... -
- Set all missing files to declare(strict_types=1);
Resolves: #96849
Releases: main
Change-Id: I1eef4d9abcfbf3a6fa8b44... -
- Set all missing files to declare(strict_types=1);
Resolves: #96848
Releases: main
Change-Id: I1257e664f9e70b375fc6d2... -
- Set all missing files to declare(strict_types=1);
Resolves: #96846
Releases: main
Change-Id: I6a9ba07d25c6c8b795ffaa... -
- Set all missing files to declare(strict_types=1);
Resolves: #96845
Releases: main
Change-Id: Iaba999b1dbb7a949f6a919... -
- Set all missing files to declare(strict_types=1);
Resolves: #96851
Releases: main
Change-Id: I844c2136f8a43c95b8b2ad... -
- Set all missing files to declare(strict_types=1);
Resolves: #96850
Releases: main
Change-Id: I03d9ba6ea000be9195e0cb... -
- Our LICENSE.txt files contain a custom header
mentioning details of a 3rd party library.
The patch resets LICENSE.tx... -
- Our LICENSE.txt files contain a custom header
mentioning details of a 3rd party library.
The patch resets LICENSE.tx... -
- Our LICENSE.txt files contain a custom header
mentioning details of a 3rd party library.
The patch resets LICENSE.tx...
2022-02-11
-
17:39 Revision dba7bbed: [BUGFIX] Reduce issues when linking to pages
- This issue solves a few phpstan related errors.
Resolves: #96834
Releases: main, 11.5
Change-Id: I4b6c9d6ef618c5a791... -
- This issue solves a few phpstan related errors.
Resolves: #96834
Releases: main, 11.5
Change-Id: I4b6c9d6ef618c5a791... -
15:30 Revision 766139d1: [TASK] Avoid some phpstan warnings in EXT:scheduler
- Resolves: #96833
Releases: main, 11.5
Change-Id: I69a3a15e9ca694456fcaf24abeef84318d9e5d6c
Reviewed-on: https://revie... -
- Resolves: #96833
Releases: main, 11.5
Change-Id: I69a3a15e9ca694456fcaf24abeef84318d9e5d6c
Reviewed-on: https://revie... -
- In case the "f:format.html" ViewHelper is called
in the install tool or via CLI, the request might
miss the applicati... -
- In case the "f:format.html" ViewHelper is called
in the install tool or via CLI, there might be either
no request obj... -
- This patch finishes the migration to the new backend
templating strategy. Affected are the backend page
module and th... -
- BackendUtility::getFuncInput() is a (core) unused
utility method that violates Content-Security-Policy
headers due to... -
- The NewContentElementController (+content button in page
or list) view handling is odd: The single items are
rendered... -
- This change adapts some comments
and makes the usage of "uc" clearer in various
places.
In addition, one change is r... -
- Protected controller method getErrorMessageForAJAX() is
unused since v7 and can be safely removed.
Resolves: #96828
... -
- Fix some typos and visual glitches.
Additionally, correct the headings in Index.rst.
Resolves: #96827
Related: #9673... -
- Resolves: #96826
Related: #96776
Releases: main
Change-Id: I8f4f0cd2efdf815c6f0d9d2ab146ce4859d1ecad
Reviewed-on: htt... -
09:26 Revision 7fb2d2f0: [TASK] Extend test cases for shortcut redirects
- Test cases for shortcut redirects are extended to
make the actual behavior more explicit there.
Resolves: #96821
Rel... -
00:35 Revision 310d0f22: [BUGFIX] Add hidden fields when opening collapsed IRRE elements
- A record is rendered that has an inline record. That
record is rendered collapsed (only header rendered).
If such a c...
2022-02-10
-
- A record is rendered that has an inline record. That
record is rendered collapsed (only header rendered).
If such a c... -
20:36 Revision a8d41606: [TASK] Migrate FilesContentObjectTest to functional test
- This UnitTest makes some heavy usage of mocking and
way too smart logic for a test. By migrating it to
a functional t... -
- This UnitTest makes some heavy usage of mocking and
way too smart logic for a test. By migrating it to
a functional t... -
- With #96597 custom evaluations registered via
FormEngineValidation.registerCustomEvaluation()
have no longer been eva... -
- see https://github.com/TYPO3/testing-framework/pull/328
composer req --dev typo3/testing-framework:^6.15.3
Besides ... -
- Since TYPO3 v11, the PSR-7 Request Object
is always available in ContentObjectRenderer,
so it can be used to access G... -
- With empty permissions in a user to be compared, this
error does not appear anymore.
Resolves: #96793
Releases: main... -
- With empty permissions in a user to be compared, this
error does not appear anymore.
Resolves: #96793
Releases: main... -
- Avoid repeating the `type` query parameter when redirecting shortcuts
in the frontend rendering process - the page ty... -
- Avoid repeating the `type` query parameter when redirecting shortcuts
in the frontend rendering process - the page ty... -
- Adds a .gitattributes file.
Releases: main, 11 -
- That method will be deprecated in core soon, consumers
should inline required HTML directly. -
- Variable `extraHidden` was used in legacy pi-based plugins (which
have been removed in TYPO3 v11). Actually this vari... -
- Variable `extraHidden` was used in legacy pi-based plugins (which
have been removed in TYPO3 v11). Actually this vari... -
- Resolves: #96816
Releases: main, 11.5
Change-Id: Id869a55136c6985e3fa609428099e5682c0eee12
Reviewed-on: https://revie... -
- Resolves: #96816
Releases: main, 11.5
Change-Id: Id869a55136c6985e3fa609428099e5682c0eee12
Reviewed-on: https://revie... -
- The new PSR-14 event ModifyButtonBarEvent is added
as a direct replacement for the now removed hook
$TYPO3_CONF_VARS[... -
09:52 Revision e5e2896a: [DOCS] Mention "PackageArtifact.php" in Changelog entry
- This enables developers to search for "PackageArtifact" in the changelog and documentation search.
References: https... -
- This enables developers to search for "PackageArtifact" in the changelog and documentation search.
References: https... - 07:36 Revision ea7cca56: [FEATURE] Mark current page in fluid_styled_content menu content elements
- This adds an aria-current="page" attribute to link tag of current menu-item in fluid_styled_content menu content elem...
-
- Just a tiny test change to sort out more details
regarding GeneralUtility::intExplode().
Change-Id: I9df58610ff5b5c7...
2022-02-09
-
- ExtendedTemplateService functionality is moved
into the actual controllers in EXT:tstemplate
that use the functionali... -
13:08 Revision 31a44a88: [FEATURE] Provide SiteLanguageProcessor
- The SiteLanguageProcessor retrieves the current siteLanguage entity as
it can be useful to have this information avai... -
- Resolves: #96786
Releases: main, 11.5
Change-Id: I69742ee10a6704cd43f8c68733bf13302200b975
Reviewed-on: https://revie... -
- Apply a basic cleanup to the RecordListController
(list module) and apply new backend templating
strategy.
Resolves:... -
- This is a followup for #96777, which uses the
factory method instead of instantiating the
PreviewUriBuilder via makeI... -
- Set all missing files to declare(strict_types=1);
Resolves: #96790
Releases: main
Change-Id: I347263bf182200c304c5f4... -
- Resolves: #96786
Releases: main, 11.5
Change-Id: I69742ee10a6704cd43f8c68733bf13302200b975
Reviewed-on: https://revie... -
- Set all missing files to declare(strict_types=1);
Resolves: #96791
Releases: main
Change-Id: I7bec6ced5e284232cba0e5... -
- This change uses the fluent API for generating
preview URLs. This way, we can replace
BackendUtility::getPreviewUri()... -
- Default values should be integer for the newly
introduced MAIL options in
https://review.typo3.org/c/Packages/TYPO3.C... -
- Remove usage of TSFE and access the site entity via
`cObj->getRequest()`.
Resolves: #96801
Releases: main
Change-Id:... -
- Instead of referencing a language file, which has to
contain three labels with predefined names, such as
"mlang_labe... -
- Apply the new templating strategy to EditDocumentController
(FormEngine record editing) by adding a first template an... -
- Since introduction of the new module registration API (#96733),
the TYPO3 backend route object might contain a Module... -
- Set all missing files to declare(strict_types=1);
Resolves: #96792
Releases: main
Change-Id: I65946055f720830d2a4317... -
- The InfoModuleController previously added the form
action url as "moduleName" to the view. Since #96730,
this variabl...
2022-02-08
-
- Resolves: #96723
Releases: main, 11.5
Change-Id: Idb880e7a45ed91f472adfbfc5b9093c14d074a7e
Reviewed-on: https://revie... -
- The match expression in PHP needs default as
keyword, not as string literal.
Change-Id: I8f242b47c74920034e046ce957c... -
- Resolves: #96723
Releases: main, 11.5
Change-Id: Idb880e7a45ed91f472adfbfc5b9093c14d074a7e
Reviewed-on: https://revie... -
17:01 Revision e3e24d70: [FEATURE] Introduce Attributes for Extbase Annotations
- Since PHP 8, native attributes are supported. In comparison to
annotations, attributes have auto-completion, are bett... -
- Refactoring of ext:linkvalidator backend controller
towards new backend templating strategy together
with a series of... -
- The ModuleStateStorage introduced in #94762
as replacement for fsMod is only used via an
<typo3-immediate-action> cus... - 13:00 Revision c0cc9c17: [DOCS] Fix the code block in the changelog
- Releases: main
Resolves: #96783
Change-Id: Ic4a36692a7dfffacca062e3c54e0ade1d8cda5ab
Reviewed-on: https://review.typo... -
- Change-Id: I46b6ad09eacc8e7da38743607d3537323108d36d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/733... -
- Change-Id: I1e189d7ca6196d4850a8625b980e0a895b043a10
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/733... -
- Change-Id: I63603e8a8511b2599b20ee1d1065e7cca730e6b9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/733... -
- Change-Id: I7e525f9534256a45f68226fc7c9d2db0ff9911cc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/733... -
- The WorkspaceService->fetchPagesWithVersionsInTable()
method is used to fetch all pages, which contain versioned
reco... -
- The WorkspaceService->fetchPagesWithVersionsInTable()
method is used to fetch all pages, which contain versioned
reco...
2022-02-07
-
- It's a no-op in master.
-
- - Use native typehints instead of doctype
- Add return types
- Use strict types
- Use DI: abstract class uses inject*... -
- To dynamically use the search word operator
as part of a locallang key, it has to be formatted
(lowercase and no whit... -
21:41 Revision 8114a5ed: [TASK] Modernize code in the Mail system
- This is just a general cleanup and tidying to use constructor
promotion, typed properties, and other modern language ... -
- To dynamically use the search word operator
as part of a locallang key, it has to be formatted
(lowercase and no whit... -
- The patch gives SetupModuleController some love by
adding a first template for the outer module HTML,
cleanup up vari... -
- The following extensions now only use CSV files for test fixtures:
* felogin
* recordlist
* seo
Resolves: #96770
Rel... -
- The following extensions now only use CSV files for test fixtures:
* felogin
* recordlist
* seo
Resolves: #96770
Rel... -
- We need to move the main templates around a bit
to apply new backend templating strategy to the
ext:form backend cont... -
- Rather straight refactoring of the indexed_search
AdministrationController towards new backend
templating strategy.
... -
- Straight implementation of the new backend
templating strategy in ext:impexp.
Resolves: #96773
Related: #96730
Relea... -
- Basic refactoring of ElementInformationController (the
"info" modal on records). The entry method is more
clean, the ... -
- Having the parent page information available for
references can be helpful for editors.
Resolves: #94601
Releases: m... -
- A rather straight refactoring of the ext:tstemplate
"entry" controller to use the new backend templating
strategy.
R... -
- This is a straight inclusion of new backend templating
strategy for main "info" dispatcher controller
"InfoModuleCont... -
- Improve the accessibility of the record history module by
binding the label to the related field.
Resolves: #96769
R... -
- Having the parent page information available for
references can be helpful for editors.
Resolves: #94601
Releases: m... -
- Improve the accessibility of the record history module by
binding the label to the related field.
Resolves: #96769
R... -
- The script "Build/Scripts/checkIntegrityComposer.php"
verifies composer.json dependencies of each system
extension to... -
- As prepared in #91316, PageRenderer state is now
serialized instead of serializing the entire object,
this means that... -
- The script "Build/Scripts/checkIntegrityComposer.php"
verifies composer.json dependencies of each system
extension to... -
- https://github.com/TYPO3-CMS/styleguide/pull/288
Since the introduction of ckeditor, this fieldControl
is not availa... -
- This change introduces a new way to register
TYPO3 Backend Modules.
Each module is now registered during build-time
... -
- Resolves: #96762
Releases: main, 11.5
Change-Id: I3f8300389fae0b6f30a7dc826afb8b2260ea41df
Reviewed-on: https://revie... -
- Resolves: #96762
Releases: main, 11.5
Change-Id: I3f8300389fae0b6f30a7dc826afb8b2260ea41df
Reviewed-on: https://revie... -
09:04 Revision 8a17ee1b: [BUGFIX] Fix undefined key warning in cObj->imageLinkWrap
- The default configuration for JSWindow in
lib.contentElement doesn't contain the params
property, so after stdWrappin... -
- During backend view refactoring with #96605 it was overseen
that essential JavaScript on permission edit view is no l... -
- This reduces the amount of mocking drastically.
Resolves: #96758
Releases: main, 11.5
Change-Id: Ia6d5e6086c23de4fe8... -
- Resolves: #96761
Releases: main, 11.5
Change-Id: Ie3591fa68e2ae5a7a0d8075b6c992452bb48750e
Reviewed-on: https://revie... -
- Resolves: #96760
Releases: main, 11.5
Change-Id: I7007c579fd3677e09229b0941f905dce8014cdfa
Reviewed-on: https://revie... -
- The default configuration for JSWindow in
lib.contentElement doesn't contain the params
property, so after stdWrappin... -
- This reduces the amount of mocking drastically.
Resolves: #96758
Releases: main, 11.5
Change-Id: Ia6d5e6086c23de4fe8... -
- Resolves: #96761
Releases: main, 11.5
Change-Id: Ie3591fa68e2ae5a7a0d8075b6c992452bb48750e
Reviewed-on: https://revie... -
- Resolves: #96760
Releases: main, 11.5
Change-Id: I7007c579fd3677e09229b0941f905dce8014cdfa
Reviewed-on: https://revie... -
- With #96749 superflous polyfills has been removed from root
composer.json. This patch removes missed occurrences in t... -
- The ext:install BackendModuleController which renders
the install tool login modal now bows to the general
backend te... -
08:06 Revision b4a98862: [TASK] Improve wording shown at the top of the Install Tool
- The paragraph that provides some basic details about how global
configuration options are stored and how these can be... -
- General refactoring of this controller with various
simplifications like less state and transition to
new backend tem... -
- General refactoring of this controller with various
simplifications like less state and transition to
new backend tem...
2022-02-05
-
- Many classes in TYPO3 have a function called
getBackendUser() or getBackendUserAuthentication(). The
function definit... -
- 'ElementInformationController::getPropertiesForTable()'
checks two properties in an if condition with interface
check... -
- Checking relations to tables that don't exist in the
database for whatever reason crashes MissingRelationsCommand.
C... -
- Due to the removal of move placeholders in TYPO3 v11,
moved records on translated pages could not be resolved
anymore... - 12:29 Revision cef21151: [BUGFIX] Avoid PHP 8.0/8.1 error in RecordHistory
- When passing null as $value parameter, an exception is
thrown as the return value must be of type string. We
avoid th... - 12:28 Revision 4d8f097c: [TASK] Improve PHP code examples in a ReST file
- Releases: main, 11.5
Resolves: #96680
Change-Id: I555b68ccaaebe8e79e57d828635b3e17e38bb28f
Reviewed-on: https://revie... -
12:28 Revision 48cece75: [BUGFIX] Prevent undefined index in ContentObjectRenderer
- A straight sanitation in COR->splitObj(). A
test needs adaptions since the method no longer
throws an exception with ... -
- Due to the removal of move placeholders in TYPO3 v11,
moved records on translated pages could not be resolved
anymore... -
- Checking relations to tables that don't exist in the
database for whatever reason crashes MissingRelationsCommand.
C... -
- BU::getRecord() and BU::getRecordWSOL() actually
return an array or NULL. This is now reflected in
@param annotations... -
- The extension has been removed from core a
while ago. There is no point in mentioning
it in the Admin Panel docs.
Re... -
- The patch adds proper typehints for 'andX()' and 'orX()'
of core 'ExpressionBuilder()' facade implementation.
This el... -
- This patch updates the link and points users to the new
documentation as the previous link became invalid. In
additio... -
- This patch updates the link and points users to the new
documentation as the previous link became invalid. In
additio... -
- As the minimum requirement for TYPO3 v12 is PHP 8.1 these polyfills are
not needed anymore by TYPO3 itself. However, ... -
- BU::getRecord() and BU::getRecordWSOL() actually
return an array or NULL. This is now reflected in
@param annotations... -
- The extension has been removed from core a
while ago. There is no point in mentioning
it in the Admin Panel docs.
Re... - 11:35 Revision f600ccff: [TASK] Improve PHP code examples in a ReST file
- Releases: main, 11.5
Resolves: #96680
Change-Id: I555b68ccaaebe8e79e57d828635b3e17e38bb28f
Reviewed-on: https://revie... -
- 'ElementInformationController::getPropertiesForTable()'
checks two properties in an if condition with interface
check... -
- A straight sanitation in COR->splitObj(). A
test needs adaptions since the method no longer
throws an exception with ... - 11:25 Revision 140e1e5d: [BUGFIX] Avoid PHP 8.0/8.1 error in RecordHistory
- When passing null as $value parameter, an exception is
thrown as the return value must be of type string. We
avoid th... -
- If the class can't be unserialized, an exception should
be caught to avoid having a state which is not solvable
via b... -
- The unserialization of scheduler tasks was very
error-prone, due to a lack of exception handling.
To stabilize and u... -
- Fixing an issue with package informations to list extensions for
the cli command 'extension:list' code has been moved... -
- phpstan complained about a superfluous 'elseif()' condition
in 'TcaPreparation::configureCategoryRelations()'.
This ... -
- phpstan complained about a superfluous 'elseif()' condition
in 'TcaPreparation::configureCategoryRelations()'.
This ...
2022-02-04
-
- This adapts a series of controllers and view
templates to use the ModuleTemplate as view.
The strategy is similar: $... -
- Resolves: #96750
Related: #95310
Releases: main, 11.5
Change-Id: I1167b20cd2fdce44ed23f6cb714ae4d56bcd917a
Reviewed-o... -
- Resolves: #96750
Related: #95310
Releases: main, 11.5
Change-Id: I1167b20cd2fdce44ed23f6cb714ae4d56bcd917a
Reviewed-o... - 17:11 Revision 682858a1: [TASK] Improve TCA title, to make it more specific
- This should improve search results when people look for "TCA"
see https://github.com/TYPO3-Documentation/t3docs-searc... -
- This brings a couple of fixes for false positives
that shrink the baseline by around 90 errors.
> composer req --dev... -
- This is just a small clean up to make more things injectable.
Enables further work.
Resolves: #96742
Releases: main
... -
- This brings a couple of fixes for false positives
that shrink the baseline by around 90 errors.
> composer req --dev... -
15:09 Revision 2f61d6c4: [BUGFIX] Fix PHPStan warnings in StagesService
- Resolves: #96734
Releases: main, 11.5
Change-Id: I5dfe1c853d65c6798bcadd1d2624bbcb81616bd6
Reviewed-on: https://revie... -
- Resolves: #96734
Releases: main, 11.5
Change-Id: I5dfe1c853d65c6798bcadd1d2624bbcb81616bd6
Reviewed-on: https://revie... -
- https://github.com/TYPO3-CMS/styleguide/pull/286
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/73058
The old r... -
- See https://forge.typo3.org/issues/96730
-
- Resolves: #96735
Releases: main, 11.5
Change-Id: Idc5343bbc42a01138b82df27f39ff1893c9d1469
Reviewed-on: https://revie... -
- Resolves: #96735
Releases: main, 11.5
Change-Id: Idc5343bbc42a01138b82df27f39ff1893c9d1469
Reviewed-on: https://revie...
2022-02-03
-
- Resolves: #96740
Releases: main, 11.5
Change-Id: I25247317f375bef1130560b5164224fb609cbe81
Reviewed-on: https://revie... -
- Resolves: #96740
Releases: main, 11.5
Change-Id: I25247317f375bef1130560b5164224fb609cbe81
Reviewed-on: https://revie... -
- This change introduces new functionality to revamp
the way the core works with views, especially in
backend context t... -
10:40 Revision b421bb80: [BUGFIX] Fix typos in description of languages in site configuration
- Resolves: #96736
Releases: main, 11.5
Change-Id: I74ba6a0eab2827d8faf136e32212c084e152fac1
Reviewed-on: https://revie... -
- Resolves: #96736
Releases: main, 11.5
Change-Id: I74ba6a0eab2827d8faf136e32212c084e152fac1
Reviewed-on: https://revie... -
- With #96713 all type annotations on class properties
in tests have been reduced to ObjectProphecy only,
removing the ... -
- With #96713 all type annotations on class properties
in tests have been reduced to ObjectProphecy only,
removing the ...
2022-02-02
-
- Many classes in TYPO3 have a function called
getLanguageService(). The function definition
is not always equal and so...
2022-02-01
-
- This change removes the RequestHandler concept from
Extbase, which means removing one level of abstraction
within Ext... -
- This change removes the discouraged usage of '%currentWorkingDirectory%'
throughout the phpstan configuration.
See: ... -
- With the following changes, we can get rid of a whole bunch
of warnings from the PHPStan baseline:
1. Now that we ar... -
- With the following changes, we can get rid of a whole bunch
of warnings from the PHPStan baseline:
1. Now that we ar...
2022-01-31
-
- 'EditDocumentController::parseAdditionalGetParameters()'
was implemented to remove dots from key identifiers in
TypoS... -
- Event.target identifies the element on which the event
occurred and may a descendant of the element to which
the even... -
- Event.target identifies the element on which the event
occurred and may a descendant of the element to which
the even... -
- The HTML standard "accesskey" is built into TYPO3's
HMENU functionality, with only limited support:
* No cross-platf... -
- PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not contain a proper test
setup, ... - 12:31 Revision fcbdad65: [!!!][FEATURE] Register extbase type converters as services
- Extbase Type Converters are now registered as container
services. Corresponding configuration, such as the source
and... -
- PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not contain a proper test
setup, ... -
- Do only auto-resolve the event name if the reflection type
of the first parameter is a ReflectionNamedType [1] as
onl... -
- Releases: main, 11.5
Resolves: #96707
Change-Id: I0d5808a48d8ed56d5688235feeb465499dd74c5b
Reviewed-on: https://revie... -
- This change registers all possible cObjects for frontend rendering
via Services.yaml and allows for ContentObjects to... -
- Do only auto-resolve the event name if the reflection type
of the first parameter is a ReflectionNamedType [1] as
onl... -
- Releases: main, 11.5
Resolves: #96707
Change-Id: I0d5808a48d8ed56d5688235feeb465499dd74c5b
Reviewed-on: https://revie... -
- findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an ... -
- By adding a couple of dedicated type hints here
and there, phpstan and phpstorm understand _call()
and _set() much be... -
- findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an ... -
- By adding a couple of dedicated type hints here
and there, phpstan and phpstorm understand _call()
and _set() much be... -
07:30 Revision b1d8b75c: [BUGFIX] Fix "undefined array key" issues in LiveSearch's page jump
- This patch adds a few null-coalesce conditions in the LiveSearch in case
a field not defined in TCA (in most cases ui... -
- This patch adds a few null-coalesce conditions in the LiveSearch in case
a field not defined in TCA (in most cases ui... -
- The testing-framework got a change to declare
_call() of getAccessibleMock() and
getAccessibleMockForAbstractClass() ...
2022-01-30
-
- Increase level from 3 to 5 and generate baseline.
Level 5 is a nice goal to fix around on for a while,
since it find... -
- Annotations are sometimes:
/** @param $foo */
/** @param $foo MyType */
But should be (at least):
/** @param MyType ... -
- Increase level from 3 to 5 and generate baseline.
Level 5 is a nice goal to fix around on for a while,
since it find... -
- Various tests add subjects or mocks as class
property without declaring the property.
Resolves: #96695
Releases: mai... -
- The global config "wait" is a max timout for
various "implicit wait" operations WebDriver
performs.
Depending on loa... -
- The global config "wait" is a max timout for
various "implicit wait" operations WebDriver
performs.
Depending on loa... -
- Various tests add subjects or mocks as class
property without declaring the property.
Resolves: #96695
Releases: mai... -
- The function getErrorFlashMessage() in ActionController can either
return a string or a boolean. This patch adds bool... -
- Annotations are sometimes:
/** @param $foo */
/** @param $foo MyType */
But should be (at least):
/** @param MyType ... -
- The function getErrorFlashMessage() in ActionController can either
return a string or a boolean. This patch adds bool... -
- Fixes the doc comment for processRequest in BlogController by
removing annotations that are already explained by the
... -
- Fixes the doc comment for processRequest in BlogController by
removing annotations that are already explained by the
... -
- Remove a superfluous null coalescing operator in
AbstractConfigurationManager since the $conf variable
is always an a... -
- Remove a superfluous null coalescing operator in
AbstractConfigurationManager since the $conf variable
is always an a... -
- Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */
The patch fixes this in al... -
- Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */
The patch fixes this in al... -
- The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in ... -
- The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in ... -
- Adding phpstan/phpstan-phpunit makes phpstan
"understand" mocking and a couple of related things.
Loading the extens... -
- Adding phpstan/phpstan-phpunit makes phpstan
"understand" mocking and a couple of related things.
Loading the extens... -
- This patch fixes a typo in the label for the dropdown box
"scheduler_ipAnonymization_table" where backend users can s... -
- This patch fixes a typo in the label for the dropdown box
"scheduler_ipAnonymization_table" where backend users can s... -
- There is often no point in having test class state
which may lead to undefined class properties and
more complex test... -
- There is often no point in having test class state
which may lead to undefined class properties and
more complex test... -
- This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock ... -
- This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock ...
2022-01-29
-
- Having jangregor/phpstan-prophecy and including it
in the phpstan config cuts the baseline by ~half.
Details can now ... -
- Having jangregor/phpstan-prophecy and including it
in the phpstan config cuts the baseline by ~half.
Details can now ... -
- Resolves: #96681
Releases: main, 11.5
Change-Id: I71ff411cd4cd639ad8d68dfcf02e46ac8818705d
Reviewed-on: https://revie... -
- Resolves: #96681
Releases: main, 11.5
Change-Id: I71ff411cd4cd639ad8d68dfcf02e46ac8818705d
Reviewed-on: https://revie... -
- * Too many arguments to __construct()
* Inconsistent naming
* Undeclared properties
Change-Id: I16ac778db7afdeaa9348... -
- * Too many arguments to __construct()
* Inconsistent naming
* Undeclared properties
Change-Id: I16ac778db7afdeaa9348... -
- Constant LANGUAGE_PRESETS must be defined in tests
using SiteBasedTestTrait and needs to be accessible.
> Build/Scri... -
- Constant LANGUAGE_PRESETS must be defined in tests
using SiteBasedTestTrait and needs to be accessible.
> Build/Scri... -
- The index.php entry point handling and package
handling core scripts are composer plugins. As
such, they rely on comp... -
- The index.php entry point handling and package
handling core scripts are composer plugins. As
such, they rely on comp... -
- $relativeToCurrentScript has been removed from
'ProcessedFile::getPublicUrl()' with #9620.
However one call to this ... -
- We currently have the situation that phpstan is
hard to update and maintain due to the phpstan
config file that sets ... -
- We currently have the situation that phpstan is
hard to update and maintain due to the phpstan
config file that sets ... -
-
- composer and phpstan caches in .Build/.cache
-
- Have latest phpstan in composer.json:
> composer req --dev phpstan/phpstan:^1.4.3 -
- Instead of manually handling exceptions for phpstan,
baseline handling has been implemented.
Whenever dealing with p... -
2022-01-28
-
- Since the element information window can also be opened from
an IRRE within a Flexform element, the table name might ... -
- 'LanguageService->sL()' could be called with an empty
input string, thus reading language files and caching
the resul... -
- Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding fl... -
- Since the element information window can also be opened from
an IRRE within a Flexform element, the table name might ... -
- Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding fl... -
- 'LanguageService->sL()' could be called with an empty
input string, thus reading language files and caching
the resul... -
- TYPO3 should never expose its EventDispatcher
implementation but only work with the PSR-14 interface
(SOLID principle... -
- TYPO3 should never expose its EventDispatcher
implementation but only work with the PSR-14 interface
(SOLID principle... -
08:42 Revision e05192c8: [TASK] Remove @internal from configuration exceptions
- This change removes the `@internal` declaration from two exceptions
thrown by `ExtensionConfiguration->get()` which i...
2022-01-27
-
- This change removes the `@internal` declaration from two exceptions
thrown by `ExtensionConfiguration->get()` which i...
2022-01-26
-
- Adapt to a patch in typo3/testing-framework,
adding strict typing to functional test case.
Releases: main
2022-01-25
-
- There are a couple of login related controllers:
* LoginController - handles user+password login
* ResetPasswordContr... -
18:46 Revision 73fbce5a: [TASK] Adapt to strict FunctionalTestCase
- Adapt to a patch in typo3/testing-framework, thus
update of typo3/testing-framework in composer.lock
is mantandory in... -
- The form tag in 'User Settings' is never closed
since that tag is added too late to $this->content.
Resolves: #96645... -
- The form tag in 'User Settings' is never closed
since that tag is added too late to $this->content.
Resolves: #96645... -
- The link handler, used when e.g. selecting things in
tt_content header_link and when editing links in RTE,
are modals... -
- Resolves: #96643
Releases: main, 11.5
Change-Id: I561b4ccfc3722778c102460d4e79732be020a41a
Reviewed-on: https://revie... -
- Resolves: #96643
Releases: main, 11.5
Change-Id: I561b4ccfc3722778c102460d4e79732be020a41a
Reviewed-on: https://revie... -
- There have been reports that DOM elements that were assigned in the
constructor of NavigationContainer actually were ... -
- There have been reports that DOM elements that were assigned in the
constructor of NavigationContainer actually were ... -
- Resolves: #96642
Releases: main, 11.5
Change-Id: I2be1ae3fc90ab72e86c534b5f3e7406ae39e960f
Reviewed-on: https://revie... -
- Extend PHPStorm meta file with further definitions for autocompletion
support and avoid unnecessary php docblocks in ... -
- The element browser - selecting records for type="group"
and "Add image" in FAL - are modals without doc header
and s... -
- Resolves: #96642
Releases: main, 11.5
Change-Id: I2be1ae3fc90ab72e86c534b5f3e7406ae39e960f
Reviewed-on: https://revie... -
- The module syntax is moved from AMD to ES6.
To avoid reindenting every javasscript line (>10000 LOC),
the existings f... -
- The element browser 'file_reference' can't be reached
anymore since the removal of type="group"
internal_type="file_r... -
- Extend PHPStorm meta file with further definitions for autocompletion
support and avoid unnecessary php docblocks in ... -
- Fixing an issue with package informations to list extensions for
the cli command 'extension:list' code has been moved... -
- This change also sets a "userGroups" record for a
simulated user group, and also the user, in order
to build a proper... -
- When dumping table data, the admin panel formats values
dependent on their type. The boolean type was missing
resulti... -
- This change also sets a "userGroups" record for a
simulated user group, and also the user, in order
to build a proper... -
- When dumping table data, the admin panel formats values
dependent on their type. The boolean type was missing
resulti... - 06:02 Revision bdc0a6c0: [TASK] Add acceptance test reports to Gitlab
- Gitlab is able to give a nice overview of tests
and how often a test failed recently which
makes it easier to investi...
2022-01-24
-
- This fixes the sorting of backend layout rows
and cols in the page module, depending on TSconfig.
1. The rows are no... -
- This fixes the sorting of backend layout rows
and cols in the page module, depending on TSconfig.
1. The rows are no... -
- The LinkValidator is an own module called "Check Links". Replaced affected screenshots and texts.
Resolves: #96633
R... -
- Check if the decoded menu is iterable,
before passing it to "foreach".
Note: No early return is used, since
this wou... -
- Check if the decoded menu is iterable,
before passing it to "foreach".
Note: No early return is used, since
this wou... - 17:42 Revision b9754f67: [TASK] Add acceptance test reports to Gitlab
- Gitlab is able to give a nice overview of tests
and how often a test failed recently which
makes it easier to investi... -
- This is a partial revert for #96354.
In order to prevent PHP 8.1 warnings when using
built-in functions like "trim" ... -
- It seems a nested variable access in Fluid `{{var}}` instead of
`{var}` has been used - which leads to a fatal error ... -
- This is a partial revert for #96354.
In order to prevent PHP 8.1 warnings when using
built-in functions like "trim" ... -
- Resolves: #96630
Releases: main, 11.5
Change-Id: Id40930d70250b93c871917160de9173cdc59d750
Reviewed-on: https://revie... -
- Resolves: #96630
Releases: main, 11.5
Change-Id: Id40930d70250b93c871917160de9173cdc59d750
Reviewed-on: https://revie... -
- Matching method name render() with more than zero
arguments is so generic that it gives tons of false
positives in th... -
- Matching method name render() with more than zero
arguments is so generic that it gives tons of false
positives in th... -
- The current version of PHP Parser we're using doesn't support
all the new PHP 8.1 syntax yet. So update it.
Used co... -
- We missed an f:translate transition to full
LLL: syntax in ext:workspaces with #96548.
Resolves: #96625
Related: #96... -
- The current version of PHP Parser we're using doesn't support
all the new PHP 8.1 syntax yet. So update it.
Used co... -
- With the deprecation and removal of DocumentTemplate
the backend controllers have been transitioned to use
ModuleTemp...
2022-01-22
-
- ExtensionConfiguration uses inline JavaScript for the ColorPicker
initialization. Move the ColorPicker initialization... -
- Since #96511 RequireJS is no longer loaded in the InstallTool.
This revealed that the ExtensionConfiguration uses inl... -
- Implement top-frame-module loading for ES6 modules.
With RequireJS we could simply invoke top.require(), but
for nati... -
- Using null coalescing operator with fallback to 'false'
to avoid undefined array key access warnings when key
'casese... -
- Using null coalescing operator with fallback to 'false'
to avoid undefined array key access warnings when key
'casese... -
- Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu... -
- Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu... -
- Due to the fact that PageRepository->getRawRecord()
can return an array OR 0 (int) Typo3DbBackend must check
for an a... -
- Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu... -
- Due to the fact that PageRepository->getRawRecord()
can return an array OR 0 (int) Typo3DbBackend must check
for an a...
2022-01-21
-
- The pages.fe_login_mode field was initially introduced
to allow reducing the amount of possible cache variants.
Sinc... -
- This is a pre-patch for multi-level language fallback
Resolves: #96611
Releases: main
Change-Id: I82e2063a7d17d29bf9... -
- This change adds a new way to load globally defined
PageTsConfig which was previously handled
via "ExtensionManagemen... -
- This change properly fetches a record, even if the
record was deleted in a workspace, so the TSconfig
is still fetche... -
- This change properly fetches a record, even if the
record was deleted in a workspace, so the TSconfig
is still fetche... -
- TBE_EDITOR is only needed for the legacy, inline-javascript based,
TBE_EDITOR.customEvalFunctions registry, therefore... -
- The DragUploader module initializes itself by calling
initialize() as last execution step, therefore the
function doe... -
- The DragUploader module initializes itself by calling
initialize() as last execution step, therefore the
function doe... -
- Resolves: #96604
Related: #96107
Related: #91786
Change-Id: I208e320d6c7c2895bb70fc299317541d60c84131
Reviewed-on: ht... -
- To demonstrate it's possible to use the native
TYPO3 "standalone" Fluid TemplateView in the frontend,
the patch chang... -
- To workaround the issue that a focus area cannot get dragged anymore,
the cropper now gets disabled if interaction wi... -
- To workaround the issue that a focus area cannot get dragged anymore,
the cropper now gets disabled if interaction wi... -
- Invoking ContentObjectRenderer::parseFunc without configuration
or TypoScript reference is not possible anymore and i... -
- Usages have been converted with:
git grep -l includeRequireJsModules= | \
grep -v /Documentation/Changelog/ | ... -
- Do no longer add the .js suffix in the javascript module, but
supply it via the templates and use a new data-import a... -
- Change the default DBMS for functional tests in
runTests.sh from mariadb to sqlite: sqlite is
sigificantly quicker wi... -
- Change the default DBMS for functional tests in
runTests.sh from mariadb to sqlite: sqlite is
sigificantly quicker wi... -
- This goes through a series of relatively simple
controllers, switching them to BackendTemplateView.
Change-Id: Icde1... -
- Use the JavaScript module and importmap Feature introduced
in #96510 to import JavaScript as native browser modules
(... -
- If compression of JavaScript files is disabled, we need to add cache
busting parameters to any backend JavaScript res... -
- Core has raised requirements of MySQL to 8.0 which we
adopt now and raise testing to MySQL 8.0 now to align
with this... -
-
- Typo3 core has dropped MSSQL support for v12, this we
remove this from v12 styleguide also.
* removed mssql dbms and... -
- To align with raised core and testing-framework minimum php version
requirement, we remove PHP7.4 and PHP8.0 from git... -
- Added fixed code files after running php-cs-fixer with updated
ruleset from typo3/coding-standards.
used commands:
... -
- Ensure that cgl runs with PHP8.1, which is a pre-patch
for switching to PHP8.1 only on main branch, and enable
cgl te...
2022-01-20
-
- If the special menu type 'list' is used, the order
must be kept as provided within the list configuration.
Resolves:... -
- If the special menu type 'list' is used, the order
must be kept as provided within the list configuration.
Resolves:... -
- The "View webpage" button in the docheader of the
page module allows to view the page in the currently
selected langu... -
- The "View webpage" button in the docheader of the
page module allows to view the page in the currently
selected langu... -
20:32 Revision ff98f405: [BUGFIX] Revert behaviour of stdWrap ifEmpty
- The stdWrap function ifEmpty must return true if a
PHP falsy value is given. That means e.g. an empty
string or a "0"... -
- The stdWrap function ifEmpty must return true if a
PHP falsy value is given. That means e.g. an empty
string or a "0"... -
- Under some circumstances, e.g. in a translations
only page module, a given $languageId (in this case
the default `0`)... -
- This affects the list module and the link
browser. A heavy-mocking unit test without
much benefit is removed along th... -
- Switching from StandaloneView to BackendTemplateView
in ext:info, minor template adaptions.
Resolves: #96598
Related... -
- When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ... -
- Long story short, through multiple refactorings along the road, from
the inital introduction of the 'mod.newContentEl... -
- Long story short, through multiple refactorings along the road, from
the inital introduction of the 'mod.newContentEl...
2022-01-19
-
- Resolves: #96565
Releases: main, 11.5
Change-Id: Iace92f424acf20fa9329dc5380facd30abe87b00
Reviewed-on: https://revie... -
- Resolves: #96565
Releases: main, 11.5
Change-Id: Iace92f424acf20fa9329dc5380facd30abe87b00
Reviewed-on: https://revie... -
- When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ... -
- This is a rather straight implementation of
BackendTemplateView in favor of StandaloneView
in ext:tstemplate - refact... -
- When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ... -
- ShortcutController has recieved an modernization overhaul
and shifted data changing actions from 'GET' and 'POST'
han... -
- Show columns selection functionality has been improved
for issue #94474, but during refactoring some code it
falsly t... -
- Show columns selection functionality has been improved
for issue #94474, but during refactoring some code it
falsly t... -
- We're not actively testing Microsoft SQL Server
anymore. The functional test related group annotation
not-mssql can b... -
- Resolves: #96587
Releases: main
Change-Id: I2c44ce44a667f246c25eaab4c87cb57a3a21c6cb
Reviewed-on: https://review.typo... -
- A couple of 'ignoreFiles' don't exist anymore.
Change-Id: I11200265f71035e70023fa396df44c336ab0649b
Resolves: #96586... -
- This is a careful rewrite of the scheduler backend
module controller and its view. It reaches a
significantly better ... -
- StandaloneView() initalizes an ExtbaseRequest in
__construct() and adds it to the rendering context.
This is unfortu... -
- Obsolete with TYPO3 v12 core being PHP >= 8.1.
Resolves: #96584
Releases: main
Change-Id: Idbe713b4b45f0e7f870bdeb60... - 14:17 Revision 34edd496: [BUGFIX] Avoid calling trim(null) in ContentObjectRenderer
- 'ContentObjectRenderer->stdWrap()' calls subfunction starting
with 'stdWrap_' which may not only return strings, but ... -
- libxml bundled in PHP before 8.0 was suspectible
to XXE. The core mitigated this by setting
libxml_disable_entity_loa... - 13:57 Revision b09c4e5c: [BUGFIX] Avoid calling trim(null) in ContentObjectRenderer
- 'ContentObjectRenderer->stdWrap()' calls subfunction starting
with 'stdWrap_' which may not only return strings, but ... -
- Resolves: #96582
Releases: main, 11.5
Change-Id: I3a9ebbf55230d526a7e0f92118cb04f1fa19254c
Reviewed-on: https://revie... -
- When creating the module template, also default CSS
and JS is added (using PageRenderer).
In the PreviewController, ... -
- Resolves: #96582
Releases: main, 11.5
Change-Id: I3a9ebbf55230d526a7e0f92118cb04f1fa19254c
Reviewed-on: https://revie... -
- Additionally, the versions in the Settings.cfg are
fixed.
Resolves: #91739
Releases: main, 11.5
Change-Id: If2128ad3... -
- The default dashboard for new users adds the
"TYPO3 news" widget which fetches an RSS feed
from typo3.org.
This migh... -
- Additionally, the versions in the Settings.cfg are
fixed.
Resolves: #91739
Releases: main, 11.5
Change-Id: If2128ad3... -
- The default dashboard for new users adds the
"TYPO3 news" widget which fetches an RSS feed
from typo3.org.
This migh... -
- Resolves: #96572
Releases: main, 11.5
Change-Id: I162a8e98abe6e4d975d0d972f395484b47808f30
Reviewed-on: https://revie... - 10:02 Revision 98f40489: [BUGFIX] Add PHP 8.0/8.1 compatibility for Import
- Importer fails to process soft references (e.g. phone numbers, email,
links etc.) in PHP 8.0/8.1 with "Undefined arra... -
- Resolves: #96572
Releases: main, 11.5
Change-Id: I162a8e98abe6e4d975d0d972f395484b47808f30
Reviewed-on: https://revie... - 09:33 Revision 7bcbd80e: [BUGFIX] Add PHP 8.0/8.1 compatibility for Import
- Importer fails to process soft references (e.g. phone numbers, email,
links etc.) in PHP 8.0/8.1 with "Undefined arra... -
- Trait 'CompileWithContentArgumentAndRenderStatic' provides
magic handling trying to retrieve the first optional
regis...
2022-01-18
-
- Resolves: #95835
Releases: main, 11.5
Change-Id: Iaa79aa4daa763c66c073d407168a7494cc11e938
Reviewed-on: https://revie... -
- System Requirements have been announced for TYPO3
v12 [1]: PHP 8.1 and higher, raised minimum DBMS
versions and remov... -
- doctrine/dbal implemented single purpose method to replace the
compound 'execute()' in QueryBuilder to avoid the inco... -
- doctrine/dbal implemented single purpose method to replace the
compound 'execute()' in QueryBuilder to avoid the inco... -
- Resolves: #95835
Releases: main, 11.5
Change-Id: Iaa79aa4daa763c66c073d407168a7494cc11e938
Reviewed-on: https://revie... -
- JavaScript ES6 modules may now be used instead of AMD modules, both in
backend and frontend context. JavaScript node-...
2022-01-17
-
- The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w... -
- The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w... -
- The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w... -
- A bigger but careful refactoring of the
ImportController and ExportController together
with a view adaption. The modu... -
- With composer >=2.2.0, allowed composer plugins have
to be added to composer.json as config/allowed_plugins.
This ha... -
- With composer >=2.2.0, allowed composer plugins have
to be added to composer.json as config/allowed_plugins.
This ha... -
- Since the file property of an IMG_RESOURCE cObj might have
no direct value set, trying to access it must be protected... -
- Since the file property of an IMG_RESOURCE cObj might have
no direct value set, trying to access it must be protected...
2022-01-16
-
- $GLOBALS['TYPO3_CONF_VARS']['SYS']['USdateFormat'] = true/false
has been added in TYPO3 4.0 with a happy "Go US!" mes... -
- PHPStan configuration option 'excludes_analyse' is deprecated and
should be replaced with the new option 'excludePath... -
- composer 2.2.x checks if plugins are allowed, and if not asks for
confirmation to execute (and add) it.
This change ... -
-
-
- * Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Less class state
* Declare s... -
- * Simplified routing without browser redirects
* Hide main drop-down if there is only one report
* Show main report b...
2022-01-15
-
- This one nagged me since "ever": The reports module
provides a sub-view to show registered services.
The old "servic...
Also available in: Atom