Bug #20852

Can create preview links only for the default language of a page

Added by Stefan about 10 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Workspaces
Target version:
Start date:
2009-08-07
Due date:
% Done:

100%

TYPO3 Version:
4.1
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

You can't create preview links for alternative page languages.
Only a preview link for the default page language is available.

I have patched this by creating a preview link for each alternative language available on the page.

(issue imported from #M11672)

index.php View (2.96 KB) Administrator Admin, 2009-08-07 17:43

index_old.php View (66.6 KB) Administrator Admin, 2009-08-07 17:47

bug_11672.diff View (2.75 KB) Administrator Admin, 2010-06-09 16:47


Related issues

Related to TYPO3 Core - Bug #26612: Preview does not include L parameter if not default language Closed 2011-05-04
Related to TYPO3 Core - Bug #45519: Workspace Preview Link Generator problem Closed 2013-02-15
Related to TYPO3 Core - Bug #12970: Generate Workspace Preview Link should honor options.view.languageOrder Closed 2011-02-11
Related to TYPO3 Core - Bug #69637: Creating preview links overloads user interface Closed 2015-09-10

Associated revisions

Revision c99042a9 (diff)
Added by Stefan Rotsch about 4 years ago

[BUGFIX] Workspace preview links for multiple languages

The workspace preview link will only be generated for one language at
a time, so it might require some effort to generate preview links for
multiple languages.

For convenience of editors, preview links will now be generated for
all available translations of a certain page in a batch.

Resolves: #20852
Resolves: #12970
Releases: master, 6.2
Change-Id: I6de6f2c7b741e238fc373f0756bc29f0100a19f0
Reviewed-on: http://review.typo3.org/26993
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Daniel Maier <>
Tested-by: Daniel Maier <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 0f30972b (diff)
Added by Stefan Rotsch about 4 years ago

[BUGFIX] Workspace preview links for multiple languages

The workspace preview link will only be generated for one language at
a time, so it might require some effort to generate preview links for
multiple languages.

For convenience of editors, preview links will now be generated for
all available translations of a certain page in a batch.

Resolves: #20852
Resolves: #12970
Releases: master, 6.2
Change-Id: I6de6f2c7b741e238fc373f0756bc29f0100a19f0
Reviewed-on: http://review.typo3.org/42417
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Stefan about 10 years ago

The concerning file is typo3/sysext/version/cm1/index.php.
The uploaded file index.php includes my patch and index_old.php is the current version.

The TYPO3 core version is 4.1.12.
My patch is from line 682 to 707.

#2 Updated by Tolleiv Nietsch about 10 years ago

if you open up the workspace-preview module with in right language the generated preview-link will carry-on that language

btw your "patch" creates links without checking whether the User has a right to "view" the language...

btw you might want to read this before you send out "patches"...
http://typo3.org/development/bug-fixing/diff-and-patch/

#3 Updated by Constantin Lebrecht over 9 years ago

The way he produced the patch might be faulty, but I can confirm that the generated preview link is in the default language. I tried it with TYPO3 4.2.12 and 4.3.3. Both times the same problem.
The generated Preview is in english but not the extra generated Preview link for Foreigners without BE-Access.

#4 Updated by Constantin Lebrecht over 9 years ago

that patch for 4.3.3 generates Preview-Links for all valid languages on the given page...

#5 Updated by Administrator Admin about 9 years ago

the patch bug_11672.diff works well for us in typo3 4.3.3

#6 Updated by Susanne Moog over 8 years ago

  • Status changed from New to Accepted
  • Target version deleted (0)

I can reproduce this issue with current trunk.

#7 Updated by Sonja Schubert over 8 years ago

  • Assignee set to Steffen Ritter

#8 Updated by Steffen Ritter over 7 years ago

  • Status changed from Accepted to On Hold

#9 Updated by Stefan Neufeind almost 7 years ago

Steffen, was this "on hold" for some certain reason?

#10 Updated by Sascha Egerer almost 6 years ago

Any update here? Does the issue still exist?

#11 Updated by Michael Stucki almost 6 years ago

  • Category set to Workspaces

#12 Updated by Michael Stucki almost 6 years ago

  • Project changed from Workspaces & Versioning to TYPO3 Core
  • Category changed from Workspaces to Workspaces

#13 Updated by Gerrit Code Review over 5 years ago

  • Status changed from On Hold to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26993

#14 Updated by Stefan Rotsch over 5 years ago

As an attempt to get this issue resolved after over 4 years, I've pushed a possible solution to Gerrit.

#15 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26993

#16 Updated by Moritz Ahl about 5 years ago

What can I do to get this done?

#17 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993

#18 Updated by Mathias Schreiber over 4 years ago

  • Target version set to 7.5

#19 Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993

#20 Updated by Daniel Goerz about 4 years ago

  • Is Regression set to No
  • Sprint Focus set to On Location Sprint

#21 Updated by Gerrit Code Review about 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993

#22 Updated by Gerrit Code Review about 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993

#23 Updated by Gerrit Code Review about 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993

#24 Updated by Gerrit Code Review about 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993

#25 Updated by Gerrit Code Review about 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993

#26 Updated by Stefan Rotsch about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#27 Updated by Gerrit Code Review about 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42417

#28 Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42417

#29 Updated by Stefan Rotsch about 4 years ago

  • Status changed from Under Review to Resolved

#30 Updated by Anja Leichsenring over 3 years ago

  • Sprint Focus deleted (On Location Sprint)

#31 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF