Bug #20852
closed
Can create preview links only for the default language of a page
Added by Stefan Sprenger over 14 years ago. Updated over 6 years ago.
100%
Description
You can't create preview links for alternative page languages.
Only a preview link for the default page language is available.
I have patched this by creating a preview link for each alternative language available on the page.
(issue imported from #M11672)
Files
| index.php (2.96 KB) index.php | Administrator Admin, 2009-08-07 17:43 | ||
| index_old.php (66.6 KB) index_old.php | Administrator Admin, 2009-08-07 17:47 | ||
| bug_11672.diff (2.75 KB) bug_11672.diff | Administrator Admin, 2010-06-09 16:47 |
Updated by Stefan Sprenger over 14 years ago
The concerning file is typo3/sysext/version/cm1/index.php.
The uploaded file index.php includes my patch and index_old.php is the current version.
The TYPO3 core version is 4.1.12.
My patch is from line 682 to 707.
Updated by Tolleiv Nietsch over 14 years ago
if you open up the workspace-preview module with in right language the generated preview-link will carry-on that language
btw your "patch" creates links without checking whether the User has a right to "view" the language...
btw you might want to read this before you send out "patches"...
http://typo3.org/development/bug-fixing/diff-and-patch/
Updated by Constantin Lebrecht almost 14 years ago
The way he produced the patch might be faulty, but I can confirm that the generated preview link is in the default language. I tried it with TYPO3 4.2.12 and 4.3.3. Both times the same problem.
The generated Preview is in english but not the extra generated Preview link for Foreigners without BE-Access.
Updated by Constantin Lebrecht almost 14 years ago
that patch for 4.3.3 generates Preview-Links for all valid languages on the given page...
Updated by Administrator Admin over 13 years ago
the patch bug_11672.diff works well for us in typo3 4.3.3
Updated by Susanne Moog about 13 years ago
- Status changed from New to Accepted
- Target version deleted (
0)
I can reproduce this issue with current trunk.
Updated by
Updated by Steffen Ritter about 12 years ago
- Status changed from Accepted to On Hold
Updated by Stefan Neufeind over 11 years ago
Steffen, was this "on hold" for some certain reason?
Updated by Sascha Egerer over 10 years ago
Any update here? Does the issue still exist?
Updated by Michael Stucki over 10 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
Updated by Gerrit Code Review about 10 years ago
- Status changed from On Hold to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26993
Updated by Stefan Rotsch about 10 years ago
As an attempt to get this issue resolved after over 4 years, I've pushed a possible solution to Gerrit.
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26993
Updated by
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993
Updated by
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993
Updated by Daniel Goerz over 8 years ago
- Is Regression set to No
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review over 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993
Updated by Gerrit Code Review over 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993
Updated by Gerrit Code Review over 8 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993
Updated by Gerrit Code Review over 8 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993
Updated by Gerrit Code Review over 8 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/26993
Updated by Stefan Rotsch over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c99042a91b3d6a927b7f460fdbd896376f20a08d.
Updated by Gerrit Code Review over 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42417
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42417
Updated by Stefan Rotsch over 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 0f30972bd471757f95125e599ca5ec5796a6ee55.
Updated by Anja Leichsenring over 8 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed