TYPO3 Core

Did you already have a look at ticket #53514? Saves a lot of queries, too.

Edit: wrong ticket number.

yep, got this on my list, thanks.

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27555

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27555

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27555

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27555

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27555

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27555

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27555

After the patch was applied I get this SQL error with the news extension:

SELECT COUNT(*) 
FROM tx_news_domain_model_news
WHERE
    (
        tx_news_domain_model_news.uid IN (
            SELECT uid_local FROM tx_news_domain_model_news_category_mm WHERE uid_foreign=?
        )
        AND tx_news_domain_model_news.pid IN ('99999999')
    )
    AND tx_news_domain_model_news.deleted=0 AND tx_news_domain_model_news.t3ver_state<=0
    AND tx_news_domain_model_news.pid<>-1 AND tx_news_domain_model_news.hidden=0
    AND tx_news_domain_model_news.starttime<=1395170580 AND (tx_news_domain_model_news.endtime=0 OR tx_news_domain_model_news.endtime>1395170580)
    AND (tx_news_domain_model_news.fe_group=''
        OR tx_news_domain_model_news.fe_group IS NULL
        OR tx_news_domain_model_news.fe_group='0'
        OR FIND_IN_SET('0',tx_news_domain_model_news.fe_group)
        OR FIND_IN_SET('-1',tx_news_domain_model_news.fe_group)
    )
    AND (tx_news_domain_model_news.sys_language_uid IN (0,-1))

This is a var_dump of the sql query parts:

array (size=9)
  'keywords' => 
    array (size=0)
      empty
  'tables' => 
    array (size=1)
      'tx_news_domain_model_news' => string 'tx_news_domain_model_news' (length=25)
  'unions' => 
    array (size=0)
      empty
  'fields' => 
    array (size=1)
      'tx_news_domain_model_news' => string 'tx_news_domain_model_news.*' (length=27)
  'where' => 
    array (size=5)
      0 => string '(' (length=1)
      1 => string 'tx_news_domain_model_news.uid IN (SELECT uid_local FROM tx_news_domain_model_news_category_mm WHERE uid_foreign=?)' (length=114)
      2 => string ' AND ' (length=5)
      3 => string 'tx_news_domain_model_news.pid IN (:AND1pid)' (length=43)
      4 => string ')' (length=1)
  'additionalWhereClause' => 
    array (size=0)
      empty
  'orderings' => 
    array (size=1)
      0 => string 'tx_news_domain_model_news.datetime DESC' (length=39)
  'limit' => null
  'offset' => null

This is the error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?) AND tx_news_domain_model_news.pid IN ('99999999')) AND tx_news_domain_model_n' at line 1

I think the problem is the unnamed parameter (?) in the uid_foreign query.

I also pointed out some problems in the code in Gerrit.

Think I found it. Regression in https://forge.typo3.org/issues/57053

Also #57130 seems to be another regression..