Activity
From 2022-01-07 to 2022-02-05
2022-02-05
-
21:43 Revision bc15ad4b: [TASK] Streamline functions returning $GLOBALS['BE_USER']
- Many classes in TYPO3 have a function called
getBackendUser() or getBackendUserAuthentication(). The
function definit... -
12:33 Revision 4655d1e7: [TASK] Avoid a 'Result of || is always true' phpstan error
- 'ElementInformationController::getPropertiesForTable()'
checks two properties in an if condition with interface
check... -
- Checking relations to tables that don't exist in the
database for whatever reason crashes MissingRelationsCommand.
C... -
12:32 Revision 3a53a45f: [BUGFIX] Render translated records in workspace frontends
- Due to the removal of move placeholders in TYPO3 v11,
moved records on translated pages could not be resolved
anymore... - 12:29 Revision cef21151: [BUGFIX] Avoid PHP 8.0/8.1 error in RecordHistory
- When passing null as $value parameter, an exception is
thrown as the return value must be of type string. We
avoid th... - 12:28 Revision 4d8f097c: [TASK] Improve PHP code examples in a ReST file
- Releases: main, 11.5
Resolves: #96680
Change-Id: I555b68ccaaebe8e79e57d828635b3e17e38bb28f
Reviewed-on: https://revie... -
12:28 Revision 48cece75: [BUGFIX] Prevent undefined index in ContentObjectRenderer
- A straight sanitation in COR->splitObj(). A
test needs adaptions since the method no longer
throws an exception with ... -
- Due to the removal of move placeholders in TYPO3 v11,
moved records on translated pages could not be resolved
anymore... -
- Checking relations to tables that don't exist in the
database for whatever reason crashes MissingRelationsCommand.
C... -
12:08 Revision 5e922e54: [TASK] Have correct return types in BackendUtility
- BU::getRecord() and BU::getRecordWSOL() actually
return an array or NULL. This is now reflected in
@param annotations... -
- The extension has been removed from core a
while ago. There is no point in mentioning
it in the Admin Panel docs.
Re... -
- The patch adds proper typehints for 'andX()' and 'orX()'
of core 'ExpressionBuilder()' facade implementation.
This el... -
12:03 Revision 5044d470: [BUGFIX] Update invalid link to the TYPO3 documentation
- This patch updates the link and points users to the new
documentation as the previous link became invalid. In
additio... -
- This patch updates the link and points users to the new
documentation as the previous link became invalid. In
additio... -
11:46 Revision bddfcc60: [TASK] Remove PHP 8.0 and PHP 8.1 polyfills
- As the minimum requirement for TYPO3 v12 is PHP 8.1 these polyfills are
not needed anymore by TYPO3 itself. However, ... -
- BU::getRecord() and BU::getRecordWSOL() actually
return an array or NULL. This is now reflected in
@param annotations... -
- The extension has been removed from core a
while ago. There is no point in mentioning
it in the Admin Panel docs.
Re... - 11:35 Revision f600ccff: [TASK] Improve PHP code examples in a ReST file
- Releases: main, 11.5
Resolves: #96680
Change-Id: I555b68ccaaebe8e79e57d828635b3e17e38bb28f
Reviewed-on: https://revie... -
- 'ElementInformationController::getPropertiesForTable()'
checks two properties in an if condition with interface
check... -
- A straight sanitation in COR->splitObj(). A
test needs adaptions since the method no longer
throws an exception with ... - 11:25 Revision 140e1e5d: [BUGFIX] Avoid PHP 8.0/8.1 error in RecordHistory
- When passing null as $value parameter, an exception is
thrown as the return value must be of type string. We
avoid th... -
10:38 Revision 910cee5c: [BUGFIX] Catch exception during unserializing task
- If the class can't be unserialized, an exception should
be caught to avoid having a state which is not solvable
via b... -
10:04 Revision 4342033c: [BUGFIX] Stabilize unserialization of scheduler tasks
- The unserialization of scheduler tasks was very
error-prone, due to a lack of exception handling.
To stabilize and u... -
- Fixing an issue with package informations to list extensions for
the cli command 'extension:list' code has been moved... -
- phpstan complained about a superfluous 'elseif()' condition
in 'TcaPreparation::configureCategoryRelations()'.
This ... -
- phpstan complained about a superfluous 'elseif()' condition
in 'TcaPreparation::configureCategoryRelations()'.
This ...
2022-02-04
-
- This adapts a series of controllers and view
templates to use the ModuleTemplate as view.
The strategy is similar: $... -
- Resolves: #96750
Related: #95310
Releases: main, 11.5
Change-Id: I1167b20cd2fdce44ed23f6cb714ae4d56bcd917a
Reviewed-o... -
- Resolves: #96750
Related: #95310
Releases: main, 11.5
Change-Id: I1167b20cd2fdce44ed23f6cb714ae4d56bcd917a
Reviewed-o... - 17:11 Revision 682858a1: [TASK] Improve TCA title, to make it more specific
- This should improve search results when people look for "TCA"
see https://github.com/TYPO3-Documentation/t3docs-searc... -
- This brings a couple of fixes for false positives
that shrink the baseline by around 90 errors.
> composer req --dev... -
16:22 Revision 5e47529b: [TASK] Move GuzzleClientFactory into the container
- This is just a small clean up to make more things injectable.
Enables further work.
Resolves: #96742
Releases: main
... -
- This brings a couple of fixes for false positives
that shrink the baseline by around 90 errors.
> composer req --dev... -
15:09 Revision 2f61d6c4: [BUGFIX] Fix PHPStan warnings in StagesService
- Resolves: #96734
Releases: main, 11.5
Change-Id: I5dfe1c853d65c6798bcadd1d2624bbcb81616bd6
Reviewed-on: https://revie... -
- Resolves: #96734
Releases: main, 11.5
Change-Id: I5dfe1c853d65c6798bcadd1d2624bbcb81616bd6
Reviewed-on: https://revie... -
14:19 Revision bef7e4fd: [TASK] styleguide: Apply new module registration API
- https://github.com/TYPO3-CMS/styleguide/pull/286
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/73058
The old r... -
- See https://forge.typo3.org/issues/96730
-
- Resolves: #96735
Releases: main, 11.5
Change-Id: Idc5343bbc42a01138b82df27f39ff1893c9d1469
Reviewed-on: https://revie... -
- Resolves: #96735
Releases: main, 11.5
Change-Id: Idc5343bbc42a01138b82df27f39ff1893c9d1469
Reviewed-on: https://revie...
2022-02-03
-
- Resolves: #96740
Releases: main, 11.5
Change-Id: I25247317f375bef1130560b5164224fb609cbe81
Reviewed-on: https://revie... -
- Resolves: #96740
Releases: main, 11.5
Change-Id: I25247317f375bef1130560b5164224fb609cbe81
Reviewed-on: https://revie... -
- This change introduces new functionality to revamp
the way the core works with views, especially in
backend context t... -
10:40 Revision b421bb80: [BUGFIX] Fix typos in description of languages in site configuration
- Resolves: #96736
Releases: main, 11.5
Change-Id: I74ba6a0eab2827d8faf136e32212c084e152fac1
Reviewed-on: https://revie... -
- Resolves: #96736
Releases: main, 11.5
Change-Id: I74ba6a0eab2827d8faf136e32212c084e152fac1
Reviewed-on: https://revie... -
08:10 Revision 1f0ec495: [TASK] Use generics for ObjectProphecy class properties
- With #96713 all type annotations on class properties
in tests have been reduced to ObjectProphecy only,
removing the ... -
- With #96713 all type annotations on class properties
in tests have been reduced to ObjectProphecy only,
removing the ...
2022-02-02
-
- Many classes in TYPO3 have a function called
getLanguageService(). The function definition
is not always equal and so...
2022-02-01
-
- This change removes the RequestHandler concept from
Extbase, which means removing one level of abstraction
within Ext... -
- This change removes the discouraged usage of '%currentWorkingDirectory%'
throughout the phpstan configuration.
See: ... -
- With the following changes, we can get rid of a whole bunch
of warnings from the PHPStan baseline:
1. Now that we ar... -
- With the following changes, we can get rid of a whole bunch
of warnings from the PHPStan baseline:
1. Now that we ar...
2022-01-31
-
- 'EditDocumentController::parseAdditionalGetParameters()'
was implemented to remove dots from key identifiers in
TypoS... -
- Event.target identifies the element on which the event
occurred and may a descendant of the element to which
the even... -
- Event.target identifies the element on which the event
occurred and may a descendant of the element to which
the even... -
- The HTML standard "accesskey" is built into TYPO3's
HMENU functionality, with only limited support:
* No cross-platf... -
- PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not contain a proper test
setup, ... - 12:31 Revision fcbdad65: [!!!][FEATURE] Register extbase type converters as services
- Extbase Type Converters are now registered as container
services. Corresponding configuration, such as the source
and... -
- PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not contain a proper test
setup, ... -
- Do only auto-resolve the event name if the reflection type
of the first parameter is a ReflectionNamedType [1] as
onl... -
- Releases: main, 11.5
Resolves: #96707
Change-Id: I0d5808a48d8ed56d5688235feeb465499dd74c5b
Reviewed-on: https://revie... -
- This change registers all possible cObjects for frontend rendering
via Services.yaml and allows for ContentObjects to... -
- Do only auto-resolve the event name if the reflection type
of the first parameter is a ReflectionNamedType [1] as
onl... -
- Releases: main, 11.5
Resolves: #96707
Change-Id: I0d5808a48d8ed56d5688235feeb465499dd74c5b
Reviewed-on: https://revie... -
- findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an ... -
- By adding a couple of dedicated type hints here
and there, phpstan and phpstorm understand _call()
and _set() much be... -
- findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an ... -
- By adding a couple of dedicated type hints here
and there, phpstan and phpstorm understand _call()
and _set() much be... -
07:30 Revision b1d8b75c: [BUGFIX] Fix "undefined array key" issues in LiveSearch's page jump
- This patch adds a few null-coalesce conditions in the LiveSearch in case
a field not defined in TCA (in most cases ui... -
- This patch adds a few null-coalesce conditions in the LiveSearch in case
a field not defined in TCA (in most cases ui... -
- The testing-framework got a change to declare
_call() of getAccessibleMock() and
getAccessibleMockForAbstractClass() ...
2022-01-30
-
- Increase level from 3 to 5 and generate baseline.
Level 5 is a nice goal to fix around on for a while,
since it find... -
- Annotations are sometimes:
/** @param $foo */
/** @param $foo MyType */
But should be (at least):
/** @param MyType ... -
- Increase level from 3 to 5 and generate baseline.
Level 5 is a nice goal to fix around on for a while,
since it find... -
- Various tests add subjects or mocks as class
property without declaring the property.
Resolves: #96695
Releases: mai... -
- The global config "wait" is a max timout for
various "implicit wait" operations WebDriver
performs.
Depending on loa... -
- The global config "wait" is a max timout for
various "implicit wait" operations WebDriver
performs.
Depending on loa... -
- Various tests add subjects or mocks as class
property without declaring the property.
Resolves: #96695
Releases: mai... -
- The function getErrorFlashMessage() in ActionController can either
return a string or a boolean. This patch adds bool... -
- Annotations are sometimes:
/** @param $foo */
/** @param $foo MyType */
But should be (at least):
/** @param MyType ... -
- The function getErrorFlashMessage() in ActionController can either
return a string or a boolean. This patch adds bool... -
- Fixes the doc comment for processRequest in BlogController by
removing annotations that are already explained by the
... -
- Fixes the doc comment for processRequest in BlogController by
removing annotations that are already explained by the
... -
- Remove a superfluous null coalescing operator in
AbstractConfigurationManager since the $conf variable
is always an a... -
- Remove a superfluous null coalescing operator in
AbstractConfigurationManager since the $conf variable
is always an a... -
- Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */
The patch fixes this in al... -
- Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */
The patch fixes this in al... -
- The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in ... -
- The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in ... -
- Adding phpstan/phpstan-phpunit makes phpstan
"understand" mocking and a couple of related things.
Loading the extens... -
- Adding phpstan/phpstan-phpunit makes phpstan
"understand" mocking and a couple of related things.
Loading the extens... -
- This patch fixes a typo in the label for the dropdown box
"scheduler_ipAnonymization_table" where backend users can s... -
- This patch fixes a typo in the label for the dropdown box
"scheduler_ipAnonymization_table" where backend users can s... -
- There is often no point in having test class state
which may lead to undefined class properties and
more complex test... -
- There is often no point in having test class state
which may lead to undefined class properties and
more complex test... -
- This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock ... -
- This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock ...
2022-01-29
-
- Having jangregor/phpstan-prophecy and including it
in the phpstan config cuts the baseline by ~half.
Details can now ... -
- Having jangregor/phpstan-prophecy and including it
in the phpstan config cuts the baseline by ~half.
Details can now ... -
- Resolves: #96681
Releases: main, 11.5
Change-Id: I71ff411cd4cd639ad8d68dfcf02e46ac8818705d
Reviewed-on: https://revie... -
- Resolves: #96681
Releases: main, 11.5
Change-Id: I71ff411cd4cd639ad8d68dfcf02e46ac8818705d
Reviewed-on: https://revie... -
- * Too many arguments to __construct()
* Inconsistent naming
* Undeclared properties
Change-Id: I16ac778db7afdeaa9348... -
- * Too many arguments to __construct()
* Inconsistent naming
* Undeclared properties
Change-Id: I16ac778db7afdeaa9348... -
- Constant LANGUAGE_PRESETS must be defined in tests
using SiteBasedTestTrait and needs to be accessible.
> Build/Scri... -
- Constant LANGUAGE_PRESETS must be defined in tests
using SiteBasedTestTrait and needs to be accessible.
> Build/Scri... -
- The index.php entry point handling and package
handling core scripts are composer plugins. As
such, they rely on comp... -
- The index.php entry point handling and package
handling core scripts are composer plugins. As
such, they rely on comp... -
- $relativeToCurrentScript has been removed from
'ProcessedFile::getPublicUrl()' with #9620.
However one call to this ... -
- We currently have the situation that phpstan is
hard to update and maintain due to the phpstan
config file that sets ... -
- We currently have the situation that phpstan is
hard to update and maintain due to the phpstan
config file that sets ... -
-
- composer and phpstan caches in .Build/.cache
-
- Have latest phpstan in composer.json:
> composer req --dev phpstan/phpstan:^1.4.3 -
- Instead of manually handling exceptions for phpstan,
baseline handling has been implemented.
Whenever dealing with p... -
2022-01-28
-
14:57 Revision 5ef67fcf: [BUGFIX] Fix undefined key warning in ElementInformationController
- Since the element information window can also be opened from
an IRRE within a Flexform element, the table name might ... -
- 'LanguageService->sL()' could be called with an empty
input string, thus reading language files and caching
the resul... -
14:26 Revision 4ffde6f4: [BUGFIX] Correctly calculate bit-masks in JavaScriptModuleInstruction
- Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding fl... -
- Since the element information window can also be opened from
an IRRE within a Flexform element, the table name might ... -
- Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding fl... -
- 'LanguageService->sL()' could be called with an empty
input string, thus reading language files and caching
the resul... -
- TYPO3 should never expose its EventDispatcher
implementation but only work with the PSR-14 interface
(SOLID principle... -
- TYPO3 should never expose its EventDispatcher
implementation but only work with the PSR-14 interface
(SOLID principle... -
08:42 Revision e05192c8: [TASK] Remove @internal from configuration exceptions
- This change removes the `@internal` declaration from two exceptions
thrown by `ExtensionConfiguration->get()` which i...
2022-01-27
-
- This change removes the `@internal` declaration from two exceptions
thrown by `ExtensionConfiguration->get()` which i...
2022-01-26
-
- Adapt to a patch in typo3/testing-framework,
adding strict typing to functional test case.
Releases: main
2022-01-25
-
- There are a couple of login related controllers:
* LoginController - handles user+password login
* ResetPasswordContr... -
18:46 Revision 73fbce5a: [TASK] Adapt to strict FunctionalTestCase
- Adapt to a patch in typo3/testing-framework, thus
update of typo3/testing-framework in composer.lock
is mantandory in... -
- The form tag in 'User Settings' is never closed
since that tag is added too late to $this->content.
Resolves: #96645... -
- The form tag in 'User Settings' is never closed
since that tag is added too late to $this->content.
Resolves: #96645... -
- The link handler, used when e.g. selecting things in
tt_content header_link and when editing links in RTE,
are modals... -
- Resolves: #96643
Releases: main, 11.5
Change-Id: I561b4ccfc3722778c102460d4e79732be020a41a
Reviewed-on: https://revie... -
- Resolves: #96643
Releases: main, 11.5
Change-Id: I561b4ccfc3722778c102460d4e79732be020a41a
Reviewed-on: https://revie... -
- There have been reports that DOM elements that were assigned in the
constructor of NavigationContainer actually were ... -
- There have been reports that DOM elements that were assigned in the
constructor of NavigationContainer actually were ... -
- Resolves: #96642
Releases: main, 11.5
Change-Id: I2be1ae3fc90ab72e86c534b5f3e7406ae39e960f
Reviewed-on: https://revie... -
- Extend PHPStorm meta file with further definitions for autocompletion
support and avoid unnecessary php docblocks in ... -
- The element browser - selecting records for type="group"
and "Add image" in FAL - are modals without doc header
and s... -
- Resolves: #96642
Releases: main, 11.5
Change-Id: I2be1ae3fc90ab72e86c534b5f3e7406ae39e960f
Reviewed-on: https://revie... -
- The module syntax is moved from AMD to ES6.
To avoid reindenting every javasscript line (>10000 LOC),
the existings f... -
- The element browser 'file_reference' can't be reached
anymore since the removal of type="group"
internal_type="file_r... -
- Extend PHPStorm meta file with further definitions for autocompletion
support and avoid unnecessary php docblocks in ... -
- Fixing an issue with package informations to list extensions for
the cli command 'extension:list' code has been moved... -
- This change also sets a "userGroups" record for a
simulated user group, and also the user, in order
to build a proper... -
06:37 Revision 4efb8278: [BUGFIX] Add missing boolean case to admin panel
- When dumping table data, the admin panel formats values
dependent on their type. The boolean type was missing
resulti... -
- This change also sets a "userGroups" record for a
simulated user group, and also the user, in order
to build a proper... -
- When dumping table data, the admin panel formats values
dependent on their type. The boolean type was missing
resulti... - 06:02 Revision bdc0a6c0: [TASK] Add acceptance test reports to Gitlab
- Gitlab is able to give a nice overview of tests
and how often a test failed recently which
makes it easier to investi...
2022-01-24
-
- This fixes the sorting of backend layout rows
and cols in the page module, depending on TSconfig.
1. The rows are no... -
- This fixes the sorting of backend layout rows
and cols in the page module, depending on TSconfig.
1. The rows are no... -
22:15 Revision 3ab78ae8: [DOCS] Document the new LinkValidator module
- The LinkValidator is an own module called "Check Links". Replaced affected screenshots and texts.
Resolves: #96633
R... -
- Check if the decoded menu is iterable,
before passing it to "foreach".
Note: No early return is used, since
this wou... -
- Check if the decoded menu is iterable,
before passing it to "foreach".
Note: No early return is used, since
this wou... - 17:42 Revision b9754f67: [TASK] Add acceptance test reports to Gitlab
- Gitlab is able to give a nice overview of tests
and how often a test failed recently which
makes it easier to investi... -
- This is a partial revert for #96354.
In order to prevent PHP 8.1 warnings when using
built-in functions like "trim" ... -
- It seems a nested variable access in Fluid `{{var}}` instead of
`{var}` has been used - which leads to a fatal error ... -
- This is a partial revert for #96354.
In order to prevent PHP 8.1 warnings when using
built-in functions like "trim" ... -
- Resolves: #96630
Releases: main, 11.5
Change-Id: Id40930d70250b93c871917160de9173cdc59d750
Reviewed-on: https://revie... -
- Resolves: #96630
Releases: main, 11.5
Change-Id: Id40930d70250b93c871917160de9173cdc59d750
Reviewed-on: https://revie... -
- Matching method name render() with more than zero
arguments is so generic that it gives tons of false
positives in th... -
- Matching method name render() with more than zero
arguments is so generic that it gives tons of false
positives in th... -
- The current version of PHP Parser we're using doesn't support
all the new PHP 8.1 syntax yet. So update it.
Used co... -
- We missed an f:translate transition to full
LLL: syntax in ext:workspaces with #96548.
Resolves: #96625
Related: #96... -
- The current version of PHP Parser we're using doesn't support
all the new PHP 8.1 syntax yet. So update it.
Used co... -
- With the deprecation and removal of DocumentTemplate
the backend controllers have been transitioned to use
ModuleTemp...
2022-01-22
-
- ExtensionConfiguration uses inline JavaScript for the ColorPicker
initialization. Move the ColorPicker initialization... -
- Since #96511 RequireJS is no longer loaded in the InstallTool.
This revealed that the ExtensionConfiguration uses inl... -
- Implement top-frame-module loading for ES6 modules.
With RequireJS we could simply invoke top.require(), but
for nati... -
- Using null coalescing operator with fallback to 'false'
to avoid undefined array key access warnings when key
'casese... -
- Using null coalescing operator with fallback to 'false'
to avoid undefined array key access warnings when key
'casese... -
- Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu... -
- Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu... -
- Due to the fact that PageRepository->getRawRecord()
can return an array OR 0 (int) Typo3DbBackend must check
for an a... -
- Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu... -
- Due to the fact that PageRepository->getRawRecord()
can return an array OR 0 (int) Typo3DbBackend must check
for an a...
2022-01-21
-
- The pages.fe_login_mode field was initially introduced
to allow reducing the amount of possible cache variants.
Sinc... -
- This is a pre-patch for multi-level language fallback
Resolves: #96611
Releases: main
Change-Id: I82e2063a7d17d29bf9... -
- This change adds a new way to load globally defined
PageTsConfig which was previously handled
via "ExtensionManagemen... -
- This change properly fetches a record, even if the
record was deleted in a workspace, so the TSconfig
is still fetche... -
- This change properly fetches a record, even if the
record was deleted in a workspace, so the TSconfig
is still fetche... -
- TBE_EDITOR is only needed for the legacy, inline-javascript based,
TBE_EDITOR.customEvalFunctions registry, therefore... -
- The DragUploader module initializes itself by calling
initialize() as last execution step, therefore the
function doe... -
- The DragUploader module initializes itself by calling
initialize() as last execution step, therefore the
function doe... -
- Resolves: #96604
Related: #96107
Related: #91786
Change-Id: I208e320d6c7c2895bb70fc299317541d60c84131
Reviewed-on: ht... -
- To demonstrate it's possible to use the native
TYPO3 "standalone" Fluid TemplateView in the frontend,
the patch chang... -
- To workaround the issue that a focus area cannot get dragged anymore,
the cropper now gets disabled if interaction wi... -
- To workaround the issue that a focus area cannot get dragged anymore,
the cropper now gets disabled if interaction wi... -
- Invoking ContentObjectRenderer::parseFunc without configuration
or TypoScript reference is not possible anymore and i... -
- Usages have been converted with:
git grep -l includeRequireJsModules= | \
grep -v /Documentation/Changelog/ | ... -
- Do no longer add the .js suffix in the javascript module, but
supply it via the templates and use a new data-import a... -
- Change the default DBMS for functional tests in
runTests.sh from mariadb to sqlite: sqlite is
sigificantly quicker wi... -
- Change the default DBMS for functional tests in
runTests.sh from mariadb to sqlite: sqlite is
sigificantly quicker wi... -
- This goes through a series of relatively simple
controllers, switching them to BackendTemplateView.
Change-Id: Icde1... -
- Use the JavaScript module and importmap Feature introduced
in #96510 to import JavaScript as native browser modules
(... -
- If compression of JavaScript files is disabled, we need to add cache
busting parameters to any backend JavaScript res... -
- Core has raised requirements of MySQL to 8.0 which we
adopt now and raise testing to MySQL 8.0 now to align
with this... -
-
- Typo3 core has dropped MSSQL support for v12, this we
remove this from v12 styleguide also.
* removed mssql dbms and... -
- To align with raised core and testing-framework minimum php version
requirement, we remove PHP7.4 and PHP8.0 from git... -
- Added fixed code files after running php-cs-fixer with updated
ruleset from typo3/coding-standards.
used commands:
... -
- Ensure that cgl runs with PHP8.1, which is a pre-patch
for switching to PHP8.1 only on main branch, and enable
cgl te...
2022-01-20
-
- If the special menu type 'list' is used, the order
must be kept as provided within the list configuration.
Resolves:... -
- If the special menu type 'list' is used, the order
must be kept as provided within the list configuration.
Resolves:... -
- The "View webpage" button in the docheader of the
page module allows to view the page in the currently
selected langu... -
- The "View webpage" button in the docheader of the
page module allows to view the page in the currently
selected langu... -
20:32 Revision ff98f405: [BUGFIX] Revert behaviour of stdWrap ifEmpty
- The stdWrap function ifEmpty must return true if a
PHP falsy value is given. That means e.g. an empty
string or a "0"... -
- The stdWrap function ifEmpty must return true if a
PHP falsy value is given. That means e.g. an empty
string or a "0"... -
- Under some circumstances, e.g. in a translations
only page module, a given $languageId (in this case
the default `0`)... -
- This affects the list module and the link
browser. A heavy-mocking unit test without
much benefit is removed along th... -
- Switching from StandaloneView to BackendTemplateView
in ext:info, minor template adaptions.
Resolves: #96598
Related... -
- When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ... -
- Long story short, through multiple refactorings along the road, from
the inital introduction of the 'mod.newContentEl... -
- Long story short, through multiple refactorings along the road, from
the inital introduction of the 'mod.newContentEl...
2022-01-19
-
- Resolves: #96565
Releases: main, 11.5
Change-Id: Iace92f424acf20fa9329dc5380facd30abe87b00
Reviewed-on: https://revie... -
- Resolves: #96565
Releases: main, 11.5
Change-Id: Iace92f424acf20fa9329dc5380facd30abe87b00
Reviewed-on: https://revie... -
- When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ... -
- This is a rather straight implementation of
BackendTemplateView in favor of StandaloneView
in ext:tstemplate - refact... -
- When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ... -
- ShortcutController has recieved an modernization overhaul
and shifted data changing actions from 'GET' and 'POST'
han... -
- Show columns selection functionality has been improved
for issue #94474, but during refactoring some code it
falsly t... -
- Show columns selection functionality has been improved
for issue #94474, but during refactoring some code it
falsly t... -
- We're not actively testing Microsoft SQL Server
anymore. The functional test related group annotation
not-mssql can b... -
- Resolves: #96587
Releases: main
Change-Id: I2c44ce44a667f246c25eaab4c87cb57a3a21c6cb
Reviewed-on: https://review.typo... -
- A couple of 'ignoreFiles' don't exist anymore.
Change-Id: I11200265f71035e70023fa396df44c336ab0649b
Resolves: #96586... -
- This is a careful rewrite of the scheduler backend
module controller and its view. It reaches a
significantly better ... -
- StandaloneView() initalizes an ExtbaseRequest in
__construct() and adds it to the rendering context.
This is unfortu... -
- Obsolete with TYPO3 v12 core being PHP >= 8.1.
Resolves: #96584
Releases: main
Change-Id: Idbe713b4b45f0e7f870bdeb60... - 14:17 Revision 34edd496: [BUGFIX] Avoid calling trim(null) in ContentObjectRenderer
- 'ContentObjectRenderer->stdWrap()' calls subfunction starting
with 'stdWrap_' which may not only return strings, but ... -
- libxml bundled in PHP before 8.0 was suspectible
to XXE. The core mitigated this by setting
libxml_disable_entity_loa... - 13:57 Revision b09c4e5c: [BUGFIX] Avoid calling trim(null) in ContentObjectRenderer
- 'ContentObjectRenderer->stdWrap()' calls subfunction starting
with 'stdWrap_' which may not only return strings, but ... -
- Resolves: #96582
Releases: main, 11.5
Change-Id: I3a9ebbf55230d526a7e0f92118cb04f1fa19254c
Reviewed-on: https://revie... -
- When creating the module template, also default CSS
and JS is added (using PageRenderer).
In the PreviewController, ... -
- Resolves: #96582
Releases: main, 11.5
Change-Id: I3a9ebbf55230d526a7e0f92118cb04f1fa19254c
Reviewed-on: https://revie... -
- Additionally, the versions in the Settings.cfg are
fixed.
Resolves: #91739
Releases: main, 11.5
Change-Id: If2128ad3... -
- The default dashboard for new users adds the
"TYPO3 news" widget which fetches an RSS feed
from typo3.org.
This migh... -
- Additionally, the versions in the Settings.cfg are
fixed.
Resolves: #91739
Releases: main, 11.5
Change-Id: If2128ad3... -
- The default dashboard for new users adds the
"TYPO3 news" widget which fetches an RSS feed
from typo3.org.
This migh... -
- Resolves: #96572
Releases: main, 11.5
Change-Id: I162a8e98abe6e4d975d0d972f395484b47808f30
Reviewed-on: https://revie... - 10:02 Revision 98f40489: [BUGFIX] Add PHP 8.0/8.1 compatibility for Import
- Importer fails to process soft references (e.g. phone numbers, email,
links etc.) in PHP 8.0/8.1 with "Undefined arra... -
- Resolves: #96572
Releases: main, 11.5
Change-Id: I162a8e98abe6e4d975d0d972f395484b47808f30
Reviewed-on: https://revie... - 09:33 Revision 7bcbd80e: [BUGFIX] Add PHP 8.0/8.1 compatibility for Import
- Importer fails to process soft references (e.g. phone numbers, email,
links etc.) in PHP 8.0/8.1 with "Undefined arra... -
- Trait 'CompileWithContentArgumentAndRenderStatic' provides
magic handling trying to retrieve the first optional
regis...
2022-01-18
-
- Resolves: #95835
Releases: main, 11.5
Change-Id: Iaa79aa4daa763c66c073d407168a7494cc11e938
Reviewed-on: https://revie... -
- System Requirements have been announced for TYPO3
v12 [1]: PHP 8.1 and higher, raised minimum DBMS
versions and remov... -
- doctrine/dbal implemented single purpose method to replace the
compound 'execute()' in QueryBuilder to avoid the inco... -
- doctrine/dbal implemented single purpose method to replace the
compound 'execute()' in QueryBuilder to avoid the inco... -
- Resolves: #95835
Releases: main, 11.5
Change-Id: Iaa79aa4daa763c66c073d407168a7494cc11e938
Reviewed-on: https://revie... -
- JavaScript ES6 modules may now be used instead of AMD modules, both in
backend and frontend context. JavaScript node-...
2022-01-17
-
- The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w... -
- The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w... -
- The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w... -
- A bigger but careful refactoring of the
ImportController and ExportController together
with a view adaption. The modu... -
- With composer >=2.2.0, allowed composer plugins have
to be added to composer.json as config/allowed_plugins.
This ha... -
- With composer >=2.2.0, allowed composer plugins have
to be added to composer.json as config/allowed_plugins.
This ha... -
- Since the file property of an IMG_RESOURCE cObj might have
no direct value set, trying to access it must be protected... -
- Since the file property of an IMG_RESOURCE cObj might have
no direct value set, trying to access it must be protected...
2022-01-16
-
- $GLOBALS['TYPO3_CONF_VARS']['SYS']['USdateFormat'] = true/false
has been added in TYPO3 4.0 with a happy "Go US!" mes... -
- PHPStan configuration option 'excludes_analyse' is deprecated and
should be replaced with the new option 'excludePath... -
- composer 2.2.x checks if plugins are allowed, and if not asks for
confirmation to execute (and add) it.
This change ... -
-
-
- * Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Less class state
* Declare s... -
- * Simplified routing without browser redirects
* Hide main drop-down if there is only one report
* Show main report b...
2022-01-15
-
- This one nagged me since "ever": The reports module
provides a sub-view to show registered services.
The old "servic...
2022-01-14
-
- Since TYPO3 v8.7 the new `.typoscript` syntax is used. See #78161 - Since then, we had
ext_typoscript_constants.typo... -
- Our Modal implementation already provides a couple
of actions, executed when the modal is confirmed.
However, previo... -
- This change adds a new centralized place
in TYPO3\CMS\Core\Configuration\PageTsConfig to
load and parse (and match) P... -
- The page module provides ModifyPageLayoutContentEvent
to add content before and/or after the main module content.
Ext... -
- This happens when "transOrigPointerField" is not defined in TCA configuration.
Additionally, a PHP 8.1 deprecation i... -
- This happens when "transOrigPointerField" is not defined in TCA configuration.
Additionally, a PHP 8.1 deprecation i... -
- A series of ext:backend related controllers and
views are cleaned up. Some of them need more work,
especially LoginCo... -
- ext:redirects middleware collected all possible redirects,
thus evaluating all regexp redirects to find possible matc... -
- When setting "HMENU.1.NO.ATagParams" then "ATagParams"
called in cObj->ATagParams is now processed once by
setting th... -
- When a page is hit in TYPO3 v12.0, the page translation
is automatically applied nowadays. Before, this
was only poss... -
- ExtendedTemplateService->ext_getObjTree() has
unused properties. Since "ExtendedTemplateService"
is marked as interna... -
- ext:redirects middleware collected all possible redirects,
thus evaluating all regexp redirects to find possible matc... -
- * Rename mainAction() to handleRequest()
* Use BackendTemplateView
* Hand over template to render as view->render('My... -
- A new PSR-14 event is added, where the old hook is removed
to modify links to generated Page Links.
Resolves: #87616... -
- While the ManagementController does only feature
one action - overviewAction - the handleRequest()
made a couple of u... -
- While the RecyclerModuleController does only
feature one action - indexAction - the handleRequest()
method still cont... -
12:21 Revision 29adbd32: [BUGFIX] styleguide: Remove unneeded phpstan ignore configuration
- PHP DocBlock for QueryBuilder::orWhere() was adjusted in core with
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72... -
- This fix updates the php docblock of method 'render()' in 'TYPO3\CMS\Styleguide\Form\Element\User1Element'
to be comp...
2022-01-13
-
- The option "config.disablePageExternalUrl", which allowed
to bypass the External URL linking (used for special
jumpur... -
- * Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Move shortcut templates to T... -
- This is a partial refactoring of ext:lowlevel. There
are some loose ends like HTML in the searchAction()
and some oth... - 18:55 Revision 4ae6c5d7: [BUGFIX] Streamline typehints of variadic arguments in QueryBuilder
- Doctrine uses mixed type for most of their method arguments in
QueryBuilder. Since TYPO3 core uses variadic arguments... - 18:55 Revision 253e7dc1: [BUGFIX] Streamline typehints of variadic arguments in QueryBuilder
- Doctrine uses mixed type for most of their method arguments in
QueryBuilder. Since TYPO3 core uses variadic arguments... - 18:55 Revision 73e8bed8: [BUGFIX] Streamline typehints of variadic arguments in QueryBuilder
- Doctrine uses mixed type for most of their method arguments in
QueryBuilder. Since TYPO3 core uses variadic arguments... -
- * Use BackendTemplateView and ->render('MyTemplate')
* f:translate with full LLL: keys
* No extbase-only f:form VH us... -
- Resolves: #91077
Releases: main
Change-Id: Iac0b8433a77ef4d6f6f0d1734e84c6a35f6addb4
Reviewed-on: https://review.typo... -
- Configure classes in Services.yaml towards dependency injection.
Also rename NoteController to NoteRenderer as it's ... -
- This introduces a new PSR-14 event, enabling extension
authors to modify the header and footer content of the
page mo... -
- The option prefixLocalAnchors in HtmlParser was not used
anymore since the removal of its main functionality
in #6593... -
- To improve the workflow for editors while selecting records
or folders in TCA type "group" fields, a new field config... -
- This change introduces a new PSR-14 event for manipulating
menu items in a menu.
The hook
$GLOBALS['TYPO3_CONF_VARS'...
2022-01-12
-
- Using inline JavaScript when initializing RequireJS modules in
individual dashboard widgets has been deprecated. Widg... -
- Global constants TYPO3_version and TYPO3_branch have
been deprecated with introduction of class
\TYPO3\CMS\Core\Infor... -
- Custom FormEngine components loading additional RequireJS modules
must use corresponding JavaScriptModuleInstruction ... -
- When the "collapse" option in the HMENU ContentObject
is activated, any active page links to its actual parent
page. ... -
- Instead of using multiple "fake" <option> elements with
the same value `--div--`, the SelectMultipleSideBySideElement... - 11:22 Revision 69acbc3a: [TASK] ClickEnlargeViewhelper PHP 8.0/8.1 compatibility
- Fixes 'Undefined array key "crop"' exception in PHP 8.0/8.1
when rendering an image with enabled clickenlarge and def... -
- This patch introduces a new EXT:fluid view class
"BackendTemplateView" to be used as main view for
backend-related no... -
- Previously, the tstemplate Object Browser would wrongly show hidden
typoscript templates, if they were the first one ... - 10:33 Revision 3c76b9e0: [TASK] ClickEnlargeViewhelper PHP 8.0/8.1 compatibility
- Fixes 'Undefined array key "crop"' exception in PHP 8.0/8.1
when rendering an image with enabled clickenlarge and def... -
- Instead of using multiple "fake" <option> elements with
the same value `--div--`, the SelectMultipleSideBySideElement... -
- Previously, the tstemplate Object Browser would wrongly show hidden
typoscript templates, if they were the first one ...
2022-01-11
-
- With #95387 the menu generation of the page module
was moved to the end of the request handling method.
However, the... -
- The path gets htmlspecialchared with linkPageATagWrap()
and before that it gets treated within getPathFromPageId()
al... -
- With #95387 the menu generation of the page module
was moved to the end of the request handling method.
However, the... -
- The change for issue #94357 introduced handling for `event/` URLs,
and accidentally modified handling for `video/` UR... -
- The change for issue #94357 introduced handling for `event/` URLs,
and accidentally modified handling for `video/` UR... -
- The path gets htmlspecialchared with linkPageATagWrap()
and before that it gets treated within getPathFromPageId()
al... -
- This change keeps the anchor when clicking on a page
in the link browser.
Resolves: #93893
Related: #89033
Releases:... -
- This change keeps the anchor when clicking on a page
in the link browser.
Resolves: #93893
Related: #89033
Releases:... -
- The method cObj->getMailTo() is only used in EmailLinkBuilder
and its functionality is now moved into this class,
as ... -
- When having an extension loaded that specifies a cache
without a specific backend like ext:adminpanel, the caching
fr... -
- NewRecordController (+ icon in doc header of list
module) renders "Create a new page" on top. This
is not a link and ... -
- When having an extension loaded that specifies a cache
without a specific backend like ext:adminpanel, the caching
fr... -
- NewRecordController (+ icon in doc header of list
module) renders "Create a new page" on top. This
is not a link and ... -
- The change for issue #94357 introduced handling for `event/` URLs,
and accidentally modified handling for `video/` UR... -
- Scheduler backend module -> Add button -> add some valid
information that makes the form save correctly -> "Save
and ... -
- Scheduler backend module -> Add button -> add some valid
information that makes the form save correctly -> "Save
and ... -
- Since modern browsers already decode this "security"
measure, the option config.spamProtectEmailAddresses = ascii
is ... -
- Change-Id: I7acf728adcceb640d21918dcabe77f5cacfa66f1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/729... -
- Change-Id: I9afad25a88555d3a89610b63ab0afd21e1284304
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/729... -
- Change-Id: Ia82e7fc67597b331ddb8f7eb35afb0598899a397
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/729... -
- Change-Id: I52bd2fc97d0e1a24ad393bc6b2fb4597fb5f73be
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/729...
2022-01-10
-
- When using a composer-based installation, public frontend assets
such as JavaScript of stylesheet files are exposed i... -
- When using a composer-based installation, public frontend assets
such as JavaScript of stylesheet files are exposed i... -
- The maintainer of the `colors` package decided to rampage and released
a bonkers version, see [1] and [2], causing an... -
- The maintainer of the `colors` package decided to rampage and released
a bonkers version, see [1] and [2], causing an... -
- The maintainer of the `colors` package decided to rampage and released
a bonkers version, see [1] and [2], causing an... -
- This restores the sort link for columns with
"special" label, such as "tstamp" or "crdate".
Resolves: #96489
Release... -
- Update to CKEditor v4.17.1 which addressed browser compatibility
issues and known security vulnerabilities:
https://... -
- Update to CKEditor v4.17.1 which addressed browser compatibility
issues and known security vulnerabilities:
https://... -
- Update to CKEditor v4.17.1 which addressed browser compatibility
issues and known security vulnerabilities:
https://... -
- Some code in HMENU stems back from TYPO3 v3.x days,
and this code aims to streamline the functionality
given current ... -
- Some browsers (reported were Safari and Firefox) are not able to
load the file tree when invoking the module the firs... -
- Some code in HMENU stems back from TYPO3 v3.x days,
and this code aims to streamline the functionality
given current ... -
- This change is preparatory refactoring in order to support
native JavaScript modules (ESM) where a module can't be us... -
- This restores the sort link for columns with
"special" label, such as "tstamp" or "crdate".
Resolves: #96489
Release... -
- Update to @claviska/jquery-minicolors v2.3.6 which addressed
known security vulnerabilities:
https://security.snyk.i... -
- Update to @claviska/jquery-minicolors v2.3.6 which addressed
known security vulnerabilities:
https://security.snyk.i... -
- The linkvalidator module shows the path to the page,
a broken link is on. Since editors might only have access
to a s... -
- Resolves: #96490
Releases: main
Change-Id: I43218e8f99f062fc43f14e1b26d7b68d8ca5414d
Reviewed-on: https://review.typo... -
- Update to @claviska/jquery-minicolors v2.3.6 which addressed
known security vulnerabilities:
https://security.snyk.i... -
- Resolves: #96481
Releases: main, 11.5
Change-Id: I41eeb4ecf0b90e998875701131b2c8a35bfa3225
Reviewed-on: https://revie... -
- The linkvalidator module shows the path to the page,
a broken link is on. Since editors might only have access
to a s... -
- Resolves: #96481
Releases: main, 11.5
Change-Id: I41eeb4ecf0b90e998875701131b2c8a35bfa3225
Reviewed-on: https://revie... -
- This change uses typolink in EmailViewHelper,
allowing to also use typolink hooks or custom
Email Link Builder to be ... -
- This change uses typolink in EmailViewHelper,
allowing to also use typolink hooks or custom
Email Link Builder to be ... -
- During the main work of TYPO3 v9 when Site Handling
was introduced, the Page Link Builder turned into
a single monste... -
- During the main work of TYPO3 v9 when Site Handling
was introduced, the Page Link Builder turned into
a single monste...
2022-01-08
- 13:44 Revision 33b6e0a9: [TASK] Switch description of partialRootPaths and layoutRootPaths
- Releases: main, 11.5
Resolves: #96488
Change-Id: I0ced03e4d551048414022214b832b3ceeb51400d
Reviewed-on: https://revie... - 11:49 Revision f6d73fea: [TASK] Switch description of partialRootPaths and layoutRootPaths
- Releases: main, 11.5
Resolves: #96488
Change-Id: I0ced03e4d551048414022214b832b3ceeb51400d
Reviewed-on: https://revie... -
- The type can already be inferred from the source
code.
The cleanup was run automatically with a
PHPStorm plugin.
Re...
2022-01-07
-
22:13 Revision 36edcee3: [TASK] Extract inline mn attribute scenario from ext:irre_tutorial
- The scenario provided by tables tx_irretutorial_mnasym_* gets
its own test extension and gets loaded where needed.
R... -
- The scenario provided by tables tx_irretutorial_mnasym_* gets
its own test extension and gets loaded where needed.
R... -
21:40 Revision c8f77004: [BUGFIX] Prevent redirects causing infinite redirect loops
- This patch adds a check to detect self referencing
redirects, thus avoiding them and instead log an error
in the corr... -
15:00 Revision 89050f92: [FEATURE] Introduce PSR-14 ModifyQueryForLiveSearchEvent
- In order to be able to influence the query of the
LiveSearch, a new PSR-14 event ModifyQueryForLiveSearchEvent
is add... -
- User supplied strings must not be concatenated into the format
parameter of sprintf() as sequences like %s, or (more ... -
- This patch adds a check to detect self referencing
redirects, thus avoiding them and instead log an error
in the corr... -
- Resolves: #96479
Releases: main, 11.5
Change-Id: I8f054a9dd38e8b25ac606c002f95cb673e4e280c
Reviewed-on: https://revie... -
- User supplied strings must not be concatenated into the format
parameter of sprintf() as sequences like %s, or (more ... -
- User supplied strings must not be concatenated into the format
parameter of sprintf() as sequences like %s, or (more ... -
- Resolves: #96479
Releases: main, 11.5
Change-Id: I8f054a9dd38e8b25ac606c002f95cb673e4e280c
Reviewed-on: https://revie... -
- This patch adds a check to detect self referencing
redirects, thus avoiding them and instead log an error
in the corr... -
12:27 Revision d673b7f6: [TASK] Use ORDER BY uid DESC in LiveSearch
- Sorting query results by text columns may require
a filesort on harddisk which is slow. To boost up
the search result... -
- Sorting query results by text columns may require
a filesort on harddisk which is slow. To boost up
the search result... -
- In #87992 an early return was added to have <a> tags
with just an "id" or "name" attribute. This is all nice,
but whe...
Also available in: Atom