Project

General

Profile

Activity

From 2022-01-16 to 2022-02-14

2022-02-14

22:29 Revision 006e05e6: [TASK] Simplify Controller in Info module
This change is a pre-patch for introducing
https://review.typo3.org/c/Packages/TYPO3.CMS/+/73339
to allow to reduce ...
Benni Mack
22:16 Revision eed9a0af: [TASK] Give final touch to main v12 breaking removal ReST
With all casual deprecation removals being done,
the ReST file can receive some final touch.
Resolves: #96107
Releas...
Christian Kuhn
21:58 Revision 6e4eae50: [TASK] Move functionality if a page is hidden from TSFE to PageRepository
TSFE contains a lot of functionality which
is rather related to other places.
One of them is the protected method
"d...
Benni Mack
21:55 Revision 95e580e2: [BUGFIX] Anonymize encoded tokens
Tokens in an encoded URL (where '=' is '%3D') now get anonymized.
Resolves: #96858
Releases: main, 11.5
Change-Id: I...
Imko Schumacher
21:55 Revision 3704e200: [BUGFIX] Anonymize encoded tokens
Tokens in an encoded URL (where '=' is '%3D') now get anonymized.
Resolves: #96858
Releases: main, 11.5
Change-Id: I...
Imko Schumacher
21:18 Revision 85d0b4af: [TASK] Harden TSFE->id related code
This change cleans up some functionality
regarding TSFE when SiteHandling was introduced
in TYPO3 v9:
* TSFE->id is ...
Benni Mack
21:02 Revision e8495034: [TASK] Move a deprecated functional test around
With #96831 being done, a last deprecated set
of functional tests can be merged into the
default functional test suit...
Christian Kuhn
20:59 Revision 484cf015: [!!!][TASK] Require PHP mbstring and intl extensions
* mbstring: This is one of the most common extensions,
often compiled directly into default packages, or
availabl...
Christian Kuhn
20:58 Revision 7a4f3f48: [BUGFIX] Render workspace selection again in log module
During the rework of #96745 the fluid variable `showWorkspaceSelector`
was set too late to be used in the view.
Reso...
Georg Ringer
19:16 Revision b7a69853: [BUGFIX] Fix page position selector on root page
Ensure the "new record" page position selector works
on the root page (pid 0).
Resolves: #96883
Releases: main, 11.5...
Markus Klein
18:59 Revision 9745a9de: [!!!][TASK] Enforce HTML sanitizer during frontend rendering
This change drops the fall-back behavior of `parseFunc.htmlSanitize` and
drops the feature flag `security.frontend.ht...
Oliver Hader
18:55 Revision 977bdcca: [BUGFIX] Fix page position selector on root page
Ensure the "new record" page position selector works
on the root page (pid 0).
Resolves: #96883
Releases: main, 11.5...
Markus Klein
18:23 Revision 00535a22: [TASK] Migrate more test fixtures to CSV
* Migrate most test fixtures from .xml to .csv.
Some special cases are left out, those will
receive dedicated pat...
Susanne Moog
18:23 Revision bb313361: [TASK] Migrate more test fixtures to CSV
* Migrate most test fixtures from .xml to .csv.
Some special cases are left out, those will
receive dedicated pat...
Susanne Moog
17:13 Revision e8dfff24: [TASK] Use PSR-7 Request for fetching login status
This change enables UserAuthentication objects
to use the PSR-7 Request Payload instead of
the superglobals $_GET/$_P...
Benni Mack
15:07 Revision 3324deec: [BUGFIX] Catch non-okayish responses in Modal requests
If the modal component starts an AJAX request that results in a
non-okayish response (>= 400), the underlying fetch()...
Andreas Fernandez
14:56 Revision f145d7e3: [BUGFIX] Catch non-okayish responses in Modal requests
If the modal component starts an AJAX request that results in a
non-okayish response (>= 400), the underlying fetch()...
Andreas Fernandez
14:09 Revision 52db75db: [BUGFIX] Make custom table styles more explicit
To overwrite the bootstrap styles of the striped
table in the extension manager list, our custom
styles must be defin...
Oliver Bartsch
13:49 Revision 43106cad: [BUGFIX] Make custom table styles more explicit
To overwrite the bootstrap styles of the striped
table in the extension manager list, our custom
styles must be defin...
Oliver Bartsch
12:26 Revision 75764b0b: [TASK] Streamline EXT:tstemplate controllers
This change is a pre-patch for introducing
https://review.typo3.org/c/Packages/TYPO3.CMS/+/73339
to allow to reduce ...
Benni Mack
12:10 Revision 62decf09: [TASK] Cleanup code in PSR-14 events
* Use constructor property promotion where appropriate
* Use typed properties
* Remove doc comments for functions wit...
Torben Hansen
10:50 Revision 608eca8f: [BUGFIX] Load Tabs.js in SetupModuleController
We missed adding 'tabs JS' to 'User Settings'
module with #96776, tab position is no longer
stored. Add it.
Resolves...
Christian Kuhn
10:47 Revision 78d442e8: [BUGFIX] Fix notice in GridColumnItem
Fix a notice which happens if the exclude configuration of
the field `hidden` of tt_content is removed.
Resolves: #9...
Georg Ringer
10:40 Revision a7339e57: [BUGFIX] Prevent adding invalid LinkButton in edit document
Prior to #96777, the preview url for tor "view" button was
created using BackendUtility::getPreviewUrl), which threw
...
Oliver Bartsch
10:19 Revision 76bef356: [BUGFIX] Fix notice in GridColumnItem
Fix a notice which happens if the exclude configuration of
the field `hidden` of tt_content is removed.
Resolves: #9...
Georg Ringer
10:03 Revision 3ea317de: [BUGFIX] Ensure PageRenderer utility scripts are cache invalidatable
Cache busting parameters need to be added to any JavaScript
resource to force browsers to re-download these files aft...
Benjamin Franzke
10:01 Revision 9ea8f5af: [BUGFIX] Ensure PageRenderer utility scripts are cache invalidatable
Cache busting parameters need to be added to any JavaScript
resource to force browsers to re-download these files aft...
Benjamin Franzke
09:58 Revision f21741d1: [TASK] Migrate Backend/Tabs module to native JS
The module Backend/Tabs used for advanced tab handling now doesn't use
jQuery anymore.
Additionally, the following c...
Andreas Fernandez
09:09 Revision ae7de752: [TASK] Revert "[TASK] Ensure requirejs-loader.js and JavaScriptItemHandler.js are cache invalidatable"
This reverts commit 425f94f553b14fa63668beaa82489316f0f3ea4a.
Reason for revert:
It would have been better to use ge...
Benjamin Franzke
09:03 Revision 02cf564c: [BUGFIX] Consider spamProtectEmailAddresses markup in <f:link.email>
Email processing in <f:link.email> view helper has been changed to
be based on typolink recently. In order to allow (...
Oliver Hader
09:03 Revision 77a715ec: [BUGFIX] Consider spamProtectEmailAddresses markup in <f:link.email>
Email processing in <f:link.email> view helper has been changed to
be based on typolink recently. In order to allow (...
Oliver Hader
08:55 Revision 730bcd42: [BUGFIX] Fix typo in file download
Resolves: #96872
Releases: main, 11.5
Change-Id: I5fdfca4bcf0b01d6d0103e8e4e8b1c6c011edc3e
Reviewed-on: https://revie...
Peter Kraume
08:22 Revision 696b6080: [BUGFIX] Fix typo in file download
Resolves: #96872
Releases: main, 11.5
Change-Id: I5fdfca4bcf0b01d6d0103e8e4e8b1c6c011edc3e
Reviewed-on: https://revie...
Peter Kraume
07:28 Revision b9509825: [DOCS] Fix syntax of PHP snippets in Changelog entry
Resolves: #96864
Releases: main
Change-Id: If904301349efb7e3308cea787b6fb798a7932d80
Reviewed-on: https://review.typo...
Lina Wolf

2022-02-13

10:47 Revision a80d2079: [TASK] Tag importmaps to include configuration for dynamic imports
Dynamic JavaScript imports require their respective importmap
configurations to be loaded, therefore it is now allowe...
Benjamin Franzke

2022-02-12

15:08 Revision 900a91ef: [BUGFIX] Avoid always enabled clipboard in RecordListController
Streamlining RecordListController with #96784 simplified
determiniation, if clipboard should be displayed or not.
Thi...
Stefan Bürk
13:58 Revision 1a215aa7: [!!!][TASK] Remove handling core caches with 'cache_' prefix
The core related caches have been renamed from
'cache_foo' to 'foo' in v10 already, together with
a deprecation fallb...
Christian Kuhn
13:48 Revision f3324616: [TASK] Remove confusing doc comments in extbase
Some extbase classes related to FAL have been added
back in 2012 with the doc comment, that classes are
experimental ...
Torben Hansen
13:46 Revision b6cafe3d: [TASK] gitlab-ci: Merge 'early' state into 'main'
Casual "pre-merge" patches (pushing a patch) to CI
gives us two stages: An "early" stage checking CGL
and composer ba...
Christian Kuhn
13:41 Revision d4190819: [TASK] Remove markTestIncomplete() functional tests
There are a couple of functional tests marked
"incomplete" since 2019. Tests that have been
skipped for so long are p...
Christian Kuhn
13:19 Revision b99ca645: [TASK] gitlab-ci: Merge 'early' state into 'main'
Casual "pre-merge" patches (pushing a patch) to CI
gives us two stages: An "early" stage checking CGL
and composer ba...
Christian Kuhn
13:16 Revision 6361a1ca: [TASK] Replace GeneralUtility::_GP in database and file browser
Use the PSR-7 request instead of Superglobals.
Resolves: #96840
Releases: main
Change-Id: Iec2e1299584b09aa1967a93c3...
Oliver Bartsch
12:50 Revision b9577d1e: [TASK] Remove markTestIncomplete() functional tests
There are a couple of functional tests marked
"incomplete" since 2019. Tests that have been
skipped for so long are p...
Christian Kuhn
12:32 Revision 7638cd3e: [TASK] Declare all controllers of ext:recycler as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96847
Releases: main
Change-Id: Ic4ba42f904702357b4b52c...
Anja Leichsenring
12:26 Revision ae47d83a: [TASK] Declare all controllers of ext:extensionmanager as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96842
Releases: main
Change-Id: Ia7ec9ed049fd875481bcf2...
Anja Leichsenring
12:20 Revision 160f7681: [TASK] Declare all controllers of ext:t3editor as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96849
Releases: main
Change-Id: I1eef4d9abcfbf3a6fa8b44...
Anja Leichsenring
12:02 Revision 6468f820: [TASK] Declare all controllers of ext:setup as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96848
Releases: main
Change-Id: I1257e664f9e70b375fc6d2...
Anja Leichsenring
11:57 Revision fae6899a: [TASK] Declare all controllers of ext:recordlist as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96846
Releases: main
Change-Id: I6a9ba07d25c6c8b795ffaa...
Anja Leichsenring
11:43 Revision 696ffc66: [TASK] Declare all controllers of ext:info as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96845
Releases: main
Change-Id: Iaba999b1dbb7a949f6a919...
Anja Leichsenring
11:40 Revision 52df7fe1: [TASK] Declare all controllers of ext:workspaces as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96851
Releases: main
Change-Id: I844c2136f8a43c95b8b2ad...
Anja Leichsenring
11:28 Revision b3685d05: [TASK] Declare all controllers of ext:tstemplate as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96850
Releases: main
Change-Id: I03d9ba6ea000be9195e0cb...
Anja Leichsenring
09:44 Revision 77eb9cb7: [TASK] Use default GPLv2 LICENSE.txt file
Our LICENSE.txt files contain a custom header
mentioning details of a 3rd party library.
The patch resets LICENSE.tx...
Christian Kuhn
09:41 Revision 142ed986: [TASK] Use default GPLv2 LICENSE.txt file
Our LICENSE.txt files contain a custom header
mentioning details of a 3rd party library.
The patch resets LICENSE.tx...
Christian Kuhn
09:26 Revision 6e9199a6: [TASK] Use default GPLv2 LICENSE.txt file
Our LICENSE.txt files contain a custom header
mentioning details of a 3rd party library.
The patch resets LICENSE.tx...
Christian Kuhn

2022-02-11

17:39 Revision dba7bbed: [BUGFIX] Reduce issues when linking to pages
This issue solves a few phpstan related errors.
Resolves: #96834
Releases: main, 11.5
Change-Id: I4b6c9d6ef618c5a791...
Benni Mack
16:47 Revision 8836bc19: [BUGFIX] Reduce issues when linking to pages
This issue solves a few phpstan related errors.
Resolves: #96834
Releases: main, 11.5
Change-Id: I4b6c9d6ef618c5a791...
Benni Mack
15:30 Revision 766139d1: [TASK] Avoid some phpstan warnings in EXT:scheduler
Resolves: #96833
Releases: main, 11.5
Change-Id: I69a3a15e9ca694456fcaf24abeef84318d9e5d6c
Reviewed-on: https://revie...
Chris Müller
14:40 Revision 5f598506: [TASK] Avoid some phpstan warnings in EXT:scheduler
Resolves: #96833
Releases: main, 11.5
Change-Id: I69a3a15e9ca694456fcaf24abeef84318d9e5d6c
Reviewed-on: https://revie...
Chris Müller
14:13 Revision df140e4c: [BUGFIX] Prevent application type exception in ViewHelper
In case the "f:format.html" ViewHelper is called
in the install tool or via CLI, the request might
miss the applicati...
Oliver Bartsch
13:32 Revision 9e0e316e: [BUGFIX] Prevent application type exception in ViewHelper
In case the "f:format.html" ViewHelper is called
in the install tool or via CLI, there might be either
no request obj...
Oliver Bartsch
13:19 Revision ab6a4571: [!!!][FEATURE] Override any backend template with TsConfig
This patch finishes the migration to the new backend
templating strategy. Affected are the backend page
module and th...
Christian Kuhn
13:09 Revision 3bf84fbd: [!!!][TASK] Remove CSP violating BU::getFuncInput()
BackendUtility::getFuncInput() is a (core) unused
utility method that violates Content-Security-Policy
headers due to...
Christian Kuhn
13:09 Revision c05e5a52: [TASK] Simplify NewContentElementController view rendering
The NewContentElementController (+content button in page
or list) view handling is odd: The single items are
rendered...
Christian Kuhn
13:08 Revision 4727f38d: [TASK] Clean up various options in UserAuthentication
This change adapts some comments
and makes the usage of "uc" clearer in various
places.
In addition, one change is r...
Benni Mack
12:58 Revision a0542d13: [TASK] Remove obsolete FormInlineAjaxController method
Protected controller method getErrorMessageForAJAX() is
unused since v7 and can be safely removed.
Resolves: #96828
...
Christian Kuhn
10:53 Revision dcdec71e: [DOCS] Streamline new module registration docs
Fix some typos and visual glitches.
Additionally, correct the headings in Index.rst.
Resolves: #96827
Related: #9673...
Chris Müller
10:34 Revision c32fcc68: [BUGFIX] Remove superfluous characters in user setup
Resolves: #96826
Related: #96776
Releases: main
Change-Id: I8f4f0cd2efdf815c6f0d9d2ab146ce4859d1ecad
Reviewed-on: htt...
Oliver Bartsch
09:26 Revision 7fb2d2f0: [TASK] Extend test cases for shortcut redirects
Test cases for shortcut redirects are extended to
make the actual behavior more explicit there.
Resolves: #96821
Rel...
Oliver Hader
00:35 Revision 310d0f22: [BUGFIX] Add hidden fields when opening collapsed IRRE elements
A record is rendered that has an inline record. That
record is rendered collapsed (only header rendered).
If such a c...
Maik no-lastname-given

2022-02-10

23:08 Revision 092a83b2: [BUGFIX] Add hidden fields when opening collapsed IRRE elements
A record is rendered that has an inline record. That
record is rendered collapsed (only header rendered).
If such a c...
Maik no-lastname-given
20:36 Revision a8d41606: [TASK] Migrate FilesContentObjectTest to functional test
This UnitTest makes some heavy usage of mocking and
way too smart logic for a test. By migrating it to
a functional t...
Nikita Hovratov
20:23 Revision 3634cd03: [TASK] Migrate FilesContentObjectTest to functional test
This UnitTest makes some heavy usage of mocking and
way too smart logic for a test. By migrating it to
a functional t...
Nikita Hovratov
20:11 Revision fb8aa5d3: [BUGFIX] Fix custom FormEngineValidation registrations
With #96597 custom evaluations registered via
FormEngineValidation.registerCustomEvaluation()
have no longer been eva...
Benjamin Franzke
20:07 Revision 860ddccf: [TASK] Streamline request handling in frontend functional tests
see https://github.com/TYPO3/testing-framework/pull/328
composer req --dev typo3/testing-framework:^6.15.3
Besides ...
Oliver Hader
19:51 Revision 6a6ead85: [TASK] Use PSR-7 Request information in cObj
Since TYPO3 v11, the PSR-7 Request Object
is always available in ContentObjectRenderer,
so it can be used to access G...
Benni Mack
17:41 Revision 7f84e62b: [BUGFIX] Avoid undefined array key in UserInformationService
With empty permissions in a user to be compared, this
error does not appear anymore.
Resolves: #96793
Releases: main...
Anja Leichsenring
17:03 Revision 3957a154: [BUGFIX] Avoid undefined array key in UserInformationService
With empty permissions in a user to be compared, this
error does not appear anymore.
Resolves: #96793
Releases: main...
Anja Leichsenring
16:57 Revision aaf5cb3e: [TASK] Avoid default type param in shortcut redirects
Avoid repeating the `type` query parameter when redirecting shortcuts
in the frontend rendering process - the page ty...
Oliver Hader
16:57 Revision 4b8d84af: [TASK] Avoid default type param in shortcut redirects
Avoid repeating the `type` query parameter when redirecting shortcuts
in the frontend rendering process - the page ty...
Oliver Hader
13:34 Revision 49ec623a: [TASK] styleguide: Keep development-only files out of composer packages
Adds a .gitattributes file.
Releases: main, 11
Christian Kuhn
13:08 Revision b58d6f78: [TASK] styleguide: Avoid ModuleTemplate->getDynamicTabMenu()
That method will be deprecated in core soon, consumers
should inline required HTML directly.
Christian Kuhn
11:38 Revision 3cc6c354: [TASK] Remove superfluous extraHidden variable from login template
Variable `extraHidden` was used in legacy pi-based plugins (which
have been removed in TYPO3 v11). Actually this vari...
Oliver Hader
11:20 Revision 5b7e2d2d: [TASK] Remove superfluous extraHidden variable from login template
Variable `extraHidden` was used in legacy pi-based plugins (which
have been removed in TYPO3 v11). Actually this vari...
Oliver Hader
11:16 Revision 665fde7c: [BUGFIX] Prevent undefined array key in EXT:frontend classes
Resolves: #96816
Releases: main, 11.5
Change-Id: Id869a55136c6985e3fa609428099e5682c0eee12
Reviewed-on: https://revie...
Oliver Bartsch
11:16 Revision 8403364b: [BUGFIX] Prevent undefined array key in EXT:frontend classes
Resolves: #96816
Releases: main, 11.5
Change-Id: Id869a55136c6985e3fa609428099e5682c0eee12
Reviewed-on: https://revie...
Oliver Bartsch
11:16 Revision f279ceb4: [!!!][FEATURE] Add PSR-14 ModifyButtonBarEvent
The new PSR-14 event ModifyButtonBarEvent is added
as a direct replacement for the now removed hook
$TYPO3_CONF_VARS[...
Oliver Bartsch
09:52 Revision e5e2896a: [DOCS] Mention "PackageArtifact.php" in Changelog entry
This enables developers to search for "PackageArtifact" in the changelog and documentation search.
References: https...
Lina Wolf
09:41 Revision 38166db7: [DOCS] Mention "PackageArtifact.php" in Changelog entry
This enables developers to search for "PackageArtifact" in the changelog and documentation search.
References: https...
Lina Wolf
07:36 Revision ea7cca56: [FEATURE] Mark current page in fluid_styled_content menu content elements
This adds an aria-current="page" attribute to link tag of current menu-item in fluid_styled_content menu content elem... Annett Jähnichen
05:32 Revision 7e89b839: [TASK] Increase test coverage of GeneralUtility::intExplode()
Just a tiny test change to sort out more details
regarding GeneralUtility::intExplode().
Change-Id: I9df58610ff5b5c7...
Christian Kuhn

2022-02-09

16:48 Revision 09d4ab00: [TASK] Migrate functionality from ExtendedTemplateService into tstemplate
ExtendedTemplateService functionality is moved
into the actual controllers in EXT:tstemplate
that use the functionali...
Benni Mack
13:08 Revision 31a44a88: [FEATURE] Provide SiteLanguageProcessor
The SiteLanguageProcessor retrieves the current siteLanguage entity as
it can be useful to have this information avai...
Georg Ringer
12:57 Revision 41ed07ec: [BUGFIX] Avoid 'Undefined array key' warning in LinkValidator
Resolves: #96786
Releases: main, 11.5
Change-Id: I69742ee10a6704cd43f8c68733bf13302200b975
Reviewed-on: https://revie...
Stefan Bürk
11:01 Revision 630e8cd3: [TASK] Streamline RecordListController
Apply a basic cleanup to the RecordListController
(list module) and apply new backend templating
strategy.
Resolves:...
Christian Kuhn
10:50 Revision 93e414b7: [TASK] Use factory method for generating preview urls
This is a followup for #96777, which uses the
factory method instead of instantiating the
PreviewUriBuilder via makeI...
Oliver Bartsch
10:30 Revision a6efe0ac: [TASK] Declare all controllers of ext:backend as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96790
Releases: main
Change-Id: I347263bf182200c304c5f4...
Anja Leichsenring
10:08 Revision ce778b08: [BUGFIX] Avoid 'Undefined array key' warning in LinkValidator
Resolves: #96786
Releases: main, 11.5
Change-Id: I69742ee10a6704cd43f8c68733bf13302200b975
Reviewed-on: https://revie...
Stefan Bürk
10:07 Revision 69ce66c2: [TASK] Declare all controllers of ext:belog as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96791
Releases: main
Change-Id: I7bec6ced5e284232cba0e5...
Anja Leichsenring
10:05 Revision d28a41a0: [TASK] Consistently use PreviewUriBuilder
This change uses the fluent API for generating
preview URLs. This way, we can replace
BackendUtility::getPreviewUri()...
Benni Mack
09:52 Revision 56298fe5: [BUGFIX] Use integer instead of strings as default for new Mail config
Default values should be integer for the newly
introduced MAIL options in
https://review.typo3.org/c/Packages/TYPO3.C...
Benni Mack
09:52 Revision 9a5dd902: [TASK] Simpify SiteProcessor
Remove usage of TSFE and access the site entity via
`cObj->getRequest()`.
Resolves: #96801
Releases: main
Change-Id:...
Georg Ringer
08:43 Revision 3abc6362: [FEATURE] Allow to define backend module labels individually
Instead of referencing a language file, which has to
contain three labels with predefined names, such as
"mlang_labe...
Oliver Bartsch
08:25 Revision e9f64f5c: [TASK] Use new templating strategy in EditDocumentController
Apply the new templating strategy to EditDocumentController
(FormEngine record editing) by adding a first template an...
Christian Kuhn
08:14 Revision 8568d785: [TASK] Add BackendModuleValidator PSR-15 middleware
Since introduction of the new module registration API (#96733),
the TYPO3 backend route object might contain a Module...
Oliver Bartsch
08:14 Revision 863fe203: [TASK] Declare all controllers of ext:beuser as strict typed
Set all missing files to declare(strict_types=1);
Resolves: #96792
Releases: main
Change-Id: I65946055f720830d2a4317...
Anja Leichsenring
08:10 Revision 7e36ca5b: [BUGFIX] Prevent overwriting of view variable
The InfoModuleController previously added the form
action url as "moduleName" to the view. Since #96730,
this variabl...
Oliver Bartsch

2022-02-08

19:00 Revision 70216616: [TASK] Add test case for markup in spamProtectEmailAddresses_atSubst
Resolves: #96723
Releases: main, 11.5
Change-Id: Idb880e7a45ed91f472adfbfc5b9093c14d074a7e
Reviewed-on: https://revie...
Oliver Hader
18:53 Revision d164d3e7: [BUGFIX] Wrong 'default' in match expression
The match expression in PHP needs default as
keyword, not as string literal.
Change-Id: I8f242b47c74920034e046ce957c...
Christian Kuhn
18:29 Revision f2e25454: [TASK] Add test case for markup in spamProtectEmailAddresses_atSubst
Resolves: #96723
Releases: main, 11.5
Change-Id: Idb880e7a45ed91f472adfbfc5b9093c14d074a7e
Reviewed-on: https://revie...
Oliver Hader
17:01 Revision e3e24d70: [FEATURE] Introduce Attributes for Extbase Annotations
Since PHP 8, native attributes are supported. In comparison to
annotations, attributes have auto-completion, are bett...
Susanne Moog
14:54 Revision 46829938: [TASK] Streamline LinkValidatorController
Refactoring of ext:linkvalidator backend controller
towards new backend templating strategy together
with a series of...
Christian Kuhn
14:49 Revision fc94e4e7: [TASK] Drop unneeded ModuleStateStorage JavaScript include
The ModuleStateStorage introduced in #94762
as replacement for fsMod is only used via an
<typo3-immediate-action> cus...
Benjamin Franzke
13:00 Revision c0cc9c17: [DOCS] Fix the code block in the changelog
Releases: main
Resolves: #96783
Change-Id: Ic4a36692a7dfffacca062e3c54e0ade1d8cda5ab
Reviewed-on: https://review.typo...
Lina Wolf
08:41 Revision 124be5be: [TASK] Set TYPO3 version to 10.4.25-dev
Change-Id: I46b6ad09eacc8e7da38743607d3537323108d36d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/733...
Oliver Hader
08:41 Revision 46e6481c: [TASK] Set TYPO3 version to 11.5.7-dev
Change-Id: I1e189d7ca6196d4850a8625b980e0a895b043a10
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/733...
Oliver Hader
08:27 Revision 7c2c4b33: [RELEASE] Release of TYPO3 10.4.24
Change-Id: I63603e8a8511b2599b20ee1d1065e7cca730e6b9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/733...
Oliver Hader
08:20 Revision 2e41482b: [RELEASE] Release of TYPO3 11.5.6
Change-Id: I7e525f9534256a45f68226fc7c9d2db0ff9911cc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/733...
Oliver Hader
08:14 Revision f9f720d4: [BUGFIX] Also consider new placeholders in WorkspaceService
The WorkspaceService->fetchPagesWithVersionsInTable()
method is used to fetch all pages, which contain versioned
reco...
Oliver Bartsch
08:09 Revision 3d600e4e: [BUGFIX] Also consider new placeholders in WorkspaceService
The WorkspaceService->fetchPagesWithVersionsInTable()
method is used to fetch all pages, which contain versioned
reco...
Oliver Bartsch

2022-02-07

22:05 Revision d97cc27d: [TASK] styleguide: Remove ExtensionUtility::registerModule()
It's a no-op in master. Christian Kuhn
22:00 Revision f8d19965: [TASK] Streamline LinkBrowser controller
- Use native typehints instead of doctype
- Add return types
- Use strict types
- Use DI: abstract class uses inject*...
Nikita Hovratov
21:50 Revision b7762eca: [BUGFIX] Format search word operator
To dynamically use the search word operator
as part of a locallang key, it has to be formatted
(lowercase and no whit...
Oliver Bartsch
21:41 Revision 8114a5ed: [TASK] Modernize code in the Mail system
This is just a general cleanup and tidying to use constructor
promotion, typed properties, and other modern language ...
Larry Garfield
21:34 Revision 51d167ef: [BUGFIX] Format search word operator
To dynamically use the search word operator
as part of a locallang key, it has to be formatted
(lowercase and no whit...
Oliver Bartsch
20:51 Revision f48ea30e: [TASK] Streamline SetupModuleController
The patch gives SetupModuleController some love by
adding a first template for the outer module HTML,
cleanup up vari...
Christian Kuhn
20:50 Revision 18b6ad3d: [TASK] Migrate test fixtures from XML to CSV
The following extensions now only use CSV files for test fixtures:
* felogin
* recordlist
* seo
Resolves: #96770
Rel...
Benni Mack
20:34 Revision 68c14897: [TASK] Migrate test fixtures from XML to CSV
The following extensions now only use CSV files for test fixtures:
* felogin
* recordlist
* seo
Resolves: #96770
Rel...
Benni Mack
20:13 Revision c338bd7d: [TASK] Use new templating strategy in ext:form
We need to move the main templates around a bit
to apply new backend templating strategy to the
ext:form backend cont...
Christian Kuhn
18:57 Revision ef97d5e7: [TASK] Use new templating strategy in ext:indexed_search
Rather straight refactoring of the indexed_search
AdministrationController towards new backend
templating strategy.
...
Christian Kuhn
18:07 Revision fe5c4409: [TASK] Use new templating strategy in ext:impexp
Straight implementation of the new backend
templating strategy in ext:impexp.
Resolves: #96773
Related: #96730
Relea...
Christian Kuhn
15:08 Revision 83d36733: [TASK] Streamline ElementInformationController
Basic refactoring of ElementInformationController (the
"info" modal on records). The entry method is more
clean, the ...
Christian Kuhn
14:26 Revision edaf575e: [TASK] Provide parent page information for references
Having the parent page information available for
references can be helpful for editors.
Resolves: #94601
Releases: m...
Georg Ringer
14:25 Revision 5cc97754: [TASK] Use new backend templating in ext:tstemplate
A rather straight refactoring of the ext:tstemplate
"entry" controller to use the new backend templating
strategy.
R...
Christian Kuhn
14:14 Revision 42c33d4f: [TASK] Use new backend templating in ext:info
This is a straight inclusion of new backend templating
strategy for main "info" dispatcher controller
"InfoModuleCont...
Christian Kuhn
14:01 Revision cb0b1b2e: [BUGFIX] Add label information to record history module
Improve the accessibility of the record history module by
binding the label to the related field.
Resolves: #96769
R...
Georg Ringer
13:54 Revision ac17db6c: [TASK] Provide parent page information for references
Having the parent page information available for
references can be helpful for editors.
Resolves: #94601
Releases: m...
Georg Ringer
13:48 Revision 086f39f9: [BUGFIX] Add label information to record history module
Improve the accessibility of the record history module by
binding the label to the related field.
Resolves: #96769
R...
Georg Ringer
09:54 Revision c68d43e7: [TASK] Tighten composer integration validation script
The script "Build/Scripts/checkIntegrityComposer.php"
verifies composer.json dependencies of each system
extension to...
Stefan Bürk
09:40 Revision f9a2cbd8: [TASK] Serialize PageRenderer state instead of the entire class
As prepared in #91316, PageRenderer state is now
serialized instead of serializing the entire object,
this means that...
Benjamin Franzke
09:40 Revision 822d93be: [TASK] Tighten composer integration validation script
The script "Build/Scripts/checkIntegrityComposer.php"
verifies composer.json dependencies of each system
extension to...
Stefan Bürk
09:36 Revision 46be08e1: [TASK] styleguide: Remove obsolete fullScreenRichtext fieldControl
https://github.com/TYPO3-CMS/styleguide/pull/288
Since the introduction of ckeditor, this fieldControl
is not availa...
Nikita Hovratov
09:29 Revision 29db88c3: [!!!][FEATURE] New Module Registration API
This change introduces a new way to register
TYPO3 Backend Modules.
Each module is now registered during build-time
...
Oliver Bartsch
09:25 Revision e3a0c302: [TASK] Avoid phpstan warnings "Unsafe access to private property through static"
Resolves: #96762
Releases: main, 11.5
Change-Id: I3f8300389fae0b6f30a7dc826afb8b2260ea41df
Reviewed-on: https://revie...
Chris Müller
09:08 Revision d7c5cb24: [TASK] Avoid phpstan warnings "Unsafe access to private property through static"
Resolves: #96762
Releases: main, 11.5
Change-Id: I3f8300389fae0b6f30a7dc826afb8b2260ea41df
Reviewed-on: https://revie...
Chris Müller
09:04 Revision 8a17ee1b: [BUGFIX] Fix undefined key warning in cObj->imageLinkWrap
The default configuration for JSWindow in
lib.contentElement doesn't contain the params
property, so after stdWrappin...
Robert Kärner
08:54 Revision 792c53be: [BUGFIX] Load essential JavaScript in permission edit view
During backend view refactoring with #96605 it was overseen
that essential JavaScript on permission edit view is no l...
Stefan Bürk
08:52 Revision 385e2246: [TASK] Convert IconFactoryTest to functional test
This reduces the amount of mocking drastically.
Resolves: #96758
Releases: main, 11.5
Change-Id: Ia6d5e6086c23de4fe8...
Nikita Hovratov
08:47 Revision f7e9a4a9: [TASK] Avoid phpstan warnings "Unsafe access to private constant through static"
Resolves: #96761
Releases: main, 11.5
Change-Id: Ie3591fa68e2ae5a7a0d8075b6c992452bb48750e
Reviewed-on: https://revie...
Chris Müller
08:47 Revision 18023659: [TASK] Avoid phpstan warnings LinkButton::setHref() expects string
Resolves: #96760
Releases: main, 11.5
Change-Id: I7007c579fd3677e09229b0941f905dce8014cdfa
Reviewed-on: https://revie...
Chris Müller
08:44 Revision c3fa86f9: [BUGFIX] Fix undefined key warning in cObj->imageLinkWrap
The default configuration for JSWindow in
lib.contentElement doesn't contain the params
property, so after stdWrappin...
Robert Kärner
08:35 Revision 191002bb: [TASK] Convert IconFactoryTest to functional test
This reduces the amount of mocking drastically.
Resolves: #96758
Releases: main, 11.5
Change-Id: Ia6d5e6086c23de4fe8...
Nikita Hovratov
08:29 Revision 6ed73e56: [TASK] Avoid phpstan warnings "Unsafe access to private constant through static"
Resolves: #96761
Releases: main, 11.5
Change-Id: Ie3591fa68e2ae5a7a0d8075b6c992452bb48750e
Reviewed-on: https://revie...
Chris Müller
08:19 Revision 61d637a3: [TASK] Avoid phpstan warnings LinkButton::setHref() expects string
Resolves: #96760
Releases: main, 11.5
Change-Id: I7007c579fd3677e09229b0941f905dce8014cdfa
Reviewed-on: https://revie...
Chris Müller
08:16 Revision b8d04909: [TASK] Remove PHP 8.0 and PHP 8.1 polyfills from ext:core
With #96749 superflous polyfills has been removed from root
composer.json. This patch removes missed occurrences in t...
Stefan Bürk
08:15 Revision 0e4d8a0f: [TASK] Use new backend templating in ext:install
The ext:install BackendModuleController which renders
the install tool login modal now bows to the general
backend te...
Christian Kuhn
08:06 Revision b4a98862: [TASK] Improve wording shown at the top of the Install Tool
The paragraph that provides some basic details about how global
configuration options are stored and how these can be...
Michael Schams
07:33 Revision 77077847: [TASK] Streamline FileUploadController
General refactoring of this controller with various
simplifications like less state and transition to
new backend tem...
Christian Kuhn
07:32 Revision a032dc46: [TASK] Streamline EditFileController
General refactoring of this controller with various
simplifications like less state and transition to
new backend tem...
Christian Kuhn

2022-02-05

21:43 Revision bc15ad4b: [TASK] Streamline functions returning $GLOBALS['BE_USER']
Many classes in TYPO3 have a function called
getBackendUser() or getBackendUserAuthentication(). The
function definit...
Torben Hansen
12:33 Revision 4655d1e7: [TASK] Avoid a 'Result of || is always true' phpstan error
'ElementInformationController::getPropertiesForTable()'
checks two properties in an if condition with interface
check...
Stefan Bürk
12:33 Revision 252b1db6: [BUGFIX] Handle non-existing table in MissingRelationsCommand
Checking relations to tables that don't exist in the
database for whatever reason crashes MissingRelationsCommand.
C...
Stefan Bürk
12:32 Revision 3a53a45f: [BUGFIX] Render translated records in workspace frontends
Due to the removal of move placeholders in TYPO3 v11,
moved records on translated pages could not be resolved
anymore...
Benni Mack
12:29 Revision cef21151: [BUGFIX] Avoid PHP 8.0/8.1 error in RecordHistory
When passing null as $value parameter, an exception is
thrown as the return value must be of type string. We
avoid th...
dev-rke
12:28 Revision 4d8f097c: [TASK] Improve PHP code examples in a ReST file
Releases: main, 11.5
Resolves: #96680
Change-Id: I555b68ccaaebe8e79e57d828635b3e17e38bb28f
Reviewed-on: https://revie...
Franz Holzinger
12:28 Revision 48cece75: [BUGFIX] Prevent undefined index in ContentObjectRenderer
A straight sanitation in COR->splitObj(). A
test needs adaptions since the method no longer
throws an exception with ...
Daniel Hinderink
12:16 Revision eba3779e: [BUGFIX] Render translated records in workspace frontends
Due to the removal of move placeholders in TYPO3 v11,
moved records on translated pages could not be resolved
anymore...
Benni Mack
12:13 Revision 81403a60: [BUGFIX] Handle non-existing table in MissingRelationsCommand
Checking relations to tables that don't exist in the
database for whatever reason crashes MissingRelationsCommand.
C...
Stefan Bürk
12:08 Revision 5e922e54: [TASK] Have correct return types in BackendUtility
BU::getRecord() and BU::getRecordWSOL() actually
return an array or NULL. This is now reflected in
@param annotations...
Christian Kuhn
12:07 Revision 24cefbc9: [TASK] Remove cryptic reference to EXT:feedit
The extension has been removed from core a
while ago. There is no point in mentioning
it in the Admin Panel docs.
Re...
Christian Kuhn
12:04 Revision edef7bff: [TASK] Have variadic typehints in ExpressionBuilder
The patch adds proper typehints for 'andX()' and 'orX()'
of core 'ExpressionBuilder()' facade implementation.
This el...
Stefan Bürk
12:03 Revision 5044d470: [BUGFIX] Update invalid link to the TYPO3 documentation
This patch updates the link and points users to the new
documentation as the previous link became invalid. In
additio...
Michael Schams
11:47 Revision 69fa4552: [BUGFIX] Update invalid link to the TYPO3 documentation
This patch updates the link and points users to the new
documentation as the previous link became invalid. In
additio...
Michael Schams
11:46 Revision bddfcc60: [TASK] Remove PHP 8.0 and PHP 8.1 polyfills
As the minimum requirement for TYPO3 v12 is PHP 8.1 these polyfills are
not needed anymore by TYPO3 itself. However, ...
Chris Müller
11:38 Revision 659c2b0a: [TASK] Have correct return types in BackendUtility
BU::getRecord() and BU::getRecordWSOL() actually
return an array or NULL. This is now reflected in
@param annotations...
Christian Kuhn
11:38 Revision 21276a88: [TASK] Remove cryptic reference to EXT:feedit
The extension has been removed from core a
while ago. There is no point in mentioning
it in the Admin Panel docs.
Re...
Christian Kuhn
11:35 Revision f600ccff: [TASK] Improve PHP code examples in a ReST file
Releases: main, 11.5
Resolves: #96680
Change-Id: I555b68ccaaebe8e79e57d828635b3e17e38bb28f
Reviewed-on: https://revie...
Franz Holzinger
11:32 Revision 5e3e430f: [TASK] Avoid a 'Result of || is always true' phpstan error
'ElementInformationController::getPropertiesForTable()'
checks two properties in an if condition with interface
check...
Stefan Bürk
11:30 Revision 6b186157: [BUGFIX] Prevent undefined index in ContentObjectRenderer
A straight sanitation in COR->splitObj(). A
test needs adaptions since the method no longer
throws an exception with ...
Daniel Hinderink
11:25 Revision 140e1e5d: [BUGFIX] Avoid PHP 8.0/8.1 error in RecordHistory
When passing null as $value parameter, an exception is
thrown as the return value must be of type string. We
avoid th...
dev-rke
10:38 Revision 910cee5c: [BUGFIX] Catch exception during unserializing task
If the class can't be unserialized, an exception should
be caught to avoid having a state which is not solvable
via b...
Georg Ringer
10:04 Revision 4342033c: [BUGFIX] Stabilize unserialization of scheduler tasks
The unserialization of scheduler tasks was very
error-prone, due to a lack of exception handling.
To stabilize and u...
Nikita Hovratov
09:44 Revision 66da58ac: [BUGFIX] Remove undefined variable in extensionmanager ListUtility
Fixing an issue with package informations to list extensions for
the cli command 'extension:list' code has been moved...
Stefan Bürk
08:57 Revision 0563c420: [TASK] Remove superfluous elseif condition check in TcaPreparation
phpstan complained about a superfluous 'elseif()' condition
in 'TcaPreparation::configureCategoryRelations()'.
This ...
Stefan Bürk
08:16 Revision 8e299b6f: [TASK] Remove superfluous elseif condition check in TcaPreparation
phpstan complained about a superfluous 'elseif()' condition
in 'TcaPreparation::configureCategoryRelations()'.
This ...
Stefan Bürk

2022-02-04

21:08 Revision eb025bfc: [TASK] Use new backend templating in various controllers
This adapts a series of controllers and view
templates to use the ModuleTemplate as view.
The strategy is similar: $...
Christian Kuhn
20:32 Revision 7c790e6e: [BUGFIX] Update occurrences of changed icon name from extbase extension
Resolves: #96750
Related: #95310
Releases: main, 11.5
Change-Id: I1167b20cd2fdce44ed23f6cb714ae4d56bcd917a
Reviewed-o...
Nikita Hovratov
20:31 Revision f61acfce: [BUGFIX] Update occurrences of changed icon name from extbase extension
Resolves: #96750
Related: #95310
Releases: main, 11.5
Change-Id: I1167b20cd2fdce44ed23f6cb714ae4d56bcd917a
Reviewed-o...
Nikita Hovratov
17:11 Revision 682858a1: [TASK] Improve TCA title, to make it more specific
This should improve search results when people look for "TCA"
see https://github.com/TYPO3-Documentation/t3docs-searc...
Tymoteusz Motylewski
16:47 Revision 74bf1c0c: [TASK] Update to phpstan/phpstan:^1.4.5
This brings a couple of fixes for false positives
that shrink the baseline by around 90 errors.
> composer req --dev...
Christian Kuhn
16:22 Revision 5e47529b: [TASK] Move GuzzleClientFactory into the container
This is just a small clean up to make more things injectable.
Enables further work.
Resolves: #96742
Releases: main
...
Larry Garfield
16:06 Revision 02ffdb9c: [TASK] Update to phpstan/phpstan:^1.4.5
This brings a couple of fixes for false positives
that shrink the baseline by around 90 errors.
> composer req --dev...
Christian Kuhn
15:09 Revision 2f61d6c4: [BUGFIX] Fix PHPStan warnings in StagesService
Resolves: #96734
Releases: main, 11.5
Change-Id: I5dfe1c853d65c6798bcadd1d2624bbcb81616bd6
Reviewed-on: https://revie...
Oliver Klee
14:42 Revision 6e745f5b: [BUGFIX] Fix PHPStan warnings in StagesService
Resolves: #96734
Releases: main, 11.5
Change-Id: I5dfe1c853d65c6798bcadd1d2624bbcb81616bd6
Reviewed-on: https://revie...
Oliver Klee
14:19 Revision bef7e4fd: [TASK] styleguide: Apply new module registration API
https://github.com/TYPO3-CMS/styleguide/pull/286
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/73058
The old r...
Oliver Bartsch
14:12 Revision 81ff2aaf: [TASK] styleguide: Use new v12 backend templating strategy
See https://forge.typo3.org/issues/96730 Christian Kuhn
08:53 Revision 4ed5327a: [BUGFIX] Fix undefined key warnings in language handling of extbase
Resolves: #96735
Releases: main, 11.5
Change-Id: Idc5343bbc42a01138b82df27f39ff1893c9d1469
Reviewed-on: https://revie...
Georg Ringer
07:20 Revision 28bedc54: [BUGFIX] Fix undefined key warnings in language handling of extbase
Resolves: #96735
Releases: main, 11.5
Change-Id: Idc5343bbc42a01138b82df27f39ff1893c9d1469
Reviewed-on: https://revie...
Georg Ringer

2022-02-03

21:21 Revision ee282a87: [TASK] Removed unused iconFactory from BackendController
Resolves: #96740
Releases: main, 11.5
Change-Id: I25247317f375bef1130560b5164224fb609cbe81
Reviewed-on: https://revie...
Oliver Bartsch
16:38 Revision 89223295: [TASK] Removed unused iconFactory from BackendController
Resolves: #96740
Releases: main, 11.5
Change-Id: I25247317f375bef1130560b5164224fb609cbe81
Reviewed-on: https://revie...
Oliver Bartsch
16:35 Revision 12a533bf: [FEATURE] Introduce unified and flexible templating for TYPO3 Backend
This change introduces new functionality to revamp
the way the core works with views, especially in
backend context t...
Christian Kuhn
10:40 Revision b421bb80: [BUGFIX] Fix typos in description of languages in site configuration
Resolves: #96736
Releases: main, 11.5
Change-Id: I74ba6a0eab2827d8faf136e32212c084e152fac1
Reviewed-on: https://revie...
Peter Kraume
10:40 Revision da4f0c9d: [BUGFIX] Fix typos in description of languages in site configuration
Resolves: #96736
Releases: main, 11.5
Change-Id: I74ba6a0eab2827d8faf136e32212c084e152fac1
Reviewed-on: https://revie...
Peter Kraume
08:10 Revision 1f0ec495: [TASK] Use generics for ObjectProphecy class properties
With #96713 all type annotations on class properties
in tests have been reduced to ObjectProphecy only,
removing the ...
Benjamin Franzke
08:07 Revision 2738ce5e: [TASK] Use generics for ObjectProphecy class properties
With #96713 all type annotations on class properties
in tests have been reduced to ObjectProphecy only,
removing the ...
Benjamin Franzke

2022-02-02

18:49 Revision 6c3a03da: [TASK] Streamline getLanguageService function
Many classes in TYPO3 have a function called
getLanguageService(). The function definition
is not always equal and so...
Torben Hansen

2022-02-01

18:04 Revision 595ab93d: [!!!][TASK] Remove Extbase's RequestHandler functionality
This change removes the RequestHandler concept from
Extbase, which means removing one level of abstraction
within Ext...
Benni Mack
11:16 Revision 37463863: [TASK] styleguide: Avoid '%currentWorkingDirectory%' in phpstan configuration
This change removes the discouraged usage of '%currentWorkingDirectory%'
throughout the phpstan configuration.
See: ...
Stefan Bürk
10:59 Revision 090f1874: [BUGFIX] Fix some incorrect usages of Prophecy
With the following changes, we can get rid of a whole bunch
of warnings from the PHPStan baseline:
1. Now that we ar...
Oliver Klee
00:51 Revision f32fdb16: [BUGFIX] Fix some incorrect usages of Prophecy
With the following changes, we can get rid of a whole bunch
of warnings from the PHPStan baseline:
1. Now that we ar...
Oliver Klee

2022-01-31

23:27 Revision 079ce829: [TASK] Replace method clone with 'GeneralUtility::removeDotsFromTS()'
'EditDocumentController::parseAdditionalGetParameters()'
was implemented to remove dots from key identifiers in
TypoS...
Stefan Bürk
14:07 Revision 409a2463: [BUGFIX] Use Event.currentTarget in default_frontend.js
Event.target identifies the element on which the event
occurred and may a descendant of the element to which
the even...
Nikita Hovratov
13:49 Revision 62c60508: [BUGFIX] Use Event.currentTarget in default_frontend.js
Event.target identifies the element on which the event
occurred and may a descendant of the element to which
the even...
Nikita Hovratov
13:06 Revision d2b6a19a: [!!!][TASK] Remove built-in support for accesskeys in HMENU
The HTML standard "accesskey" is built into TYPO3's
HMENU functionality, with only limited support:
* No cross-platf...
Benni Mack
12:31 Revision 9cc5d830: [TASK] Remove broken test from ServiceProviderCompilationPassTest
PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not contain a proper test
setup, ...
Benjamin Franzke
12:31 Revision fcbdad65: [!!!][FEATURE] Register extbase type converters as services
Extbase Type Converters are now registered as container
services. Corresponding configuration, such as the source
and...
Alexander Schnitzler
12:07 Revision 1831bc51: [TASK] Remove broken test from ServiceProviderCompilationPassTest
PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not contain a proper test
setup, ...
Benjamin Franzke
11:42 Revision ae8010bf: [TASK] Harden event listener automagic parameter type resolution
Do only auto-resolve the event name if the reflection type
of the first parameter is a ReflectionNamedType [1] as
onl...
Benjamin Franzke
11:23 Revision 1dafc1e7: [TASK] Fix PHPStan errors in JavaScript module classes
Releases: main, 11.5
Resolves: #96707
Change-Id: I0d5808a48d8ed56d5688235feeb465499dd74c5b
Reviewed-on: https://revie...
Benjamin Franzke
11:12 Revision 3cc9e6a6: [!!!][FEATURE] Register cObjects via service configuration
This change registers all possible cObjects for frontend rendering
via Services.yaml and allows for ContentObjects to...
Benni Mack
11:00 Revision e4c43666: [TASK] Harden event listener automagic parameter type resolution
Do only auto-resolve the event name if the reflection type
of the first parameter is a ReflectionNamedType [1] as
onl...
Benjamin Franzke
10:58 Revision 88b91742: [TASK] Fix PHPStan errors in JavaScript module classes
Releases: main, 11.5
Resolves: #96707
Change-Id: I0d5808a48d8ed56d5688235feeb465499dd74c5b
Reviewed-on: https://revie...
Benjamin Franzke
09:29 Revision 3e7372c2: [TASK] Fix definition availability checks in DI compiler passes
findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an ...
Benjamin Franzke
09:16 Revision 195e1a6d: [TASK] Properly type hint accessible mocks in tests
By adding a couple of dedicated type hints here
and there, phpstan and phpstorm understand _call()
and _set() much be...
Christian Kuhn
09:08 Revision 1cd63e30: [TASK] Fix definition availability checks in DI compiler passes
findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an ...
Benjamin Franzke
08:51 Revision 07529e73: [TASK] Properly type hint accessible mocks in tests
By adding a couple of dedicated type hints here
and there, phpstan and phpstorm understand _call()
and _set() much be...
Christian Kuhn
07:30 Revision b1d8b75c: [BUGFIX] Fix "undefined array key" issues in LiveSearch's page jump
This patch adds a few null-coalesce conditions in the LiveSearch in case
a field not defined in TCA (in most cases ui...
Andreas Fernandez
06:51 Revision b88a2ae7: [BUGFIX] Fix "undefined array key" issues in LiveSearch's page jump
This patch adds a few null-coalesce conditions in the LiveSearch in case
a field not defined in TCA (in most cases ui...
Andreas Fernandez
00:38 Revision 9310fb07: [TASK] Accessible mocks understand _call() arguments
The testing-framework got a change to declare
_call() of getAccessibleMock() and
getAccessibleMockForAbstractClass() ...
Christian Kuhn

2022-01-30

23:03 Revision 71872faf: [TASK] Raise phpstan to level 5
Increase level from 3 to 5 and generate baseline.
Level 5 is a nice goal to fix around on for a while,
since it find...
Christian Kuhn
22:58 Revision 1d0cfb93: [TASK] Avoid phpstan 'PHPDoc tag @param has invalid value' errors
Annotations are sometimes:
/** @param $foo */
/** @param $foo MyType */
But should be (at least):
/** @param MyType ...
Stefan Bürk
22:31 Revision 64a8bfb9: [TASK] Raise phpstan to level 5
Increase level from 3 to 5 and generate baseline.
Level 5 is a nice goal to fix around on for a while,
since it find...
Christian Kuhn
22:26 Revision 5c28e926: [TASK] Resolve some 'access to undefined property' in tests
Various tests add subjects or mocks as class
property without declaring the property.
Resolves: #96695
Releases: mai...
Christian Kuhn
22:21 Revision afcc9a4d: [TASK] Increase ac test implicit wait timeouts
The global config "wait" is a max timout for
various "implicit wait" operations WebDriver
performs.
Depending on loa...
Christian Kuhn
22:03 Revision 8fe9d394: [TASK] Increase ac test implicit wait timeouts
The global config "wait" is a max timout for
various "implicit wait" operations WebDriver
performs.
Depending on loa...
Christian Kuhn
21:56 Revision f25fb7fb: [TASK] Resolve some 'access to undefined property' in tests
Various tests add subjects or mocks as class
property without declaring the property.
Resolves: #96695
Releases: mai...
Christian Kuhn
21:35 Revision 689f1dd3: [TASK] Update doc comment for ActionController::getErrorFlashMessage
The function getErrorFlashMessage() in ActionController can either
return a string or a boolean. This patch adds bool...
Torben Hansen
21:25 Revision 470f844f: [TASK] Avoid phpstan 'PHPDoc tag @param has invalid value' errors
Annotations are sometimes:
/** @param $foo */
/** @param $foo MyType */
But should be (at least):
/** @param MyType ...
Stefan Bürk
21:17 Revision 1d3aed4e: [TASK] Update doc comment for ActionController::getErrorFlashMessage
The function getErrorFlashMessage() in ActionController can either
return a string or a boolean. This patch adds bool...
Torben Hansen
21:13 Revision f60bd415: [TASK] Fix doc comment in fixture BlogController::processRequest
Fixes the doc comment for processRequest in BlogController by
removing annotations that are already explained by the
...
Torben Hansen
20:57 Revision 92a340f5: [TASK] Fix doc comment in fixture BlogController::processRequest
Fixes the doc comment for processRequest in BlogController by
removing annotations that are already explained by the
...
Torben Hansen
19:01 Revision 9caf6351: [TASK] Remove superfluous null coalescing operator
Remove a superfluous null coalescing operator in
AbstractConfigurationManager since the $conf variable
is always an a...
Torben Hansen
18:04 Revision 0b677511: [TASK] Remove superfluous null coalescing operator
Remove a superfluous null coalescing operator in
AbstractConfigurationManager since the $conf variable
is always an a...
Torben Hansen
18:03 Revision 41e8f282: [TASK] Avoid phpstan 'PHPDoc tag @var has invalid value' errors
Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */
The patch fixes this in al...
Christian Kuhn
18:03 Revision abbee995: [TASK] Avoid phpstan 'PHPDoc tag @var has invalid value' errors
Annotations are sometimes:
/** @var $foo MyType */
But should be:
/** @var MyType $foo */
The patch fixes this in al...
Christian Kuhn
17:25 Revision 2c359feb: [TASK] Add PHPStan plugin for psr/container
The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in ...
Benjamin Franzke
16:04 Revision 6e7627a8: [TASK] Add PHPStan plugin for psr/container
The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in ...
Benjamin Franzke
15:44 Revision edbcda8d: [TASK] Add PHPStan plugin for PHPUnit
Adding phpstan/phpstan-phpunit makes phpstan
"understand" mocking and a couple of related things.
Loading the extens...
Oliver Klee
15:44 Revision 4d5f2b94: [TASK] Add PHPStan plugin for PHPUnit
Adding phpstan/phpstan-phpunit makes phpstan
"understand" mocking and a couple of related things.
Loading the extens...
Oliver Klee
13:25 Revision 1e25b63a: [BUGFIX] Fix typo in field label of Scheduler task
This patch fixes a typo in the label for the dropdown box
"scheduler_ipAnonymization_table" where backend users can s...
Michael Schams
08:08 Revision 6b0e2204: [BUGFIX] Fix typo in field label of Scheduler task
This patch fixes a typo in the label for the dropdown box
"scheduler_ipAnonymization_table" where backend users can s...
Michael Schams
00:06 Revision 4e188faf: [TASK] Avoid state and undefined properties in tests
There is often no point in having test class state
which may lead to undefined class properties and
more complex test...
Christian Kuhn
00:06 Revision 0469106f: [TASK] Avoid state and undefined properties in tests
There is often no point in having test class state
which may lead to undefined class properties and
more complex test...
Christian Kuhn
00:05 Revision 898ea73d: [TASK] Avoid typehint docblocks for FunctionalTestCase properties
This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock ...
Stefan Bürk
00:05 Revision adecc47a: [TASK] Avoid typehint docblocks for FunctionalTestCase properties
This patch removes docblock typehints for FunctionalTestCase
properties in functional tests, thus using the docblock ...
Stefan Bürk

2022-01-29

23:05 Revision 6aa30ab6: [TASK] Tests: Have jangregor/phpstan-prophecy:^1.0
Having jangregor/phpstan-prophecy and including it
in the phpstan config cuts the baseline by ~half.
Details can now ...
Christian Kuhn
23:04 Revision fc9804fc: [TASK] Tests: Have jangregor/phpstan-prophecy:^1.0
Having jangregor/phpstan-prophecy and including it
in the phpstan config cuts the baseline by ~half.
Details can now ...
Christian Kuhn
22:25 Revision ce091f77: [BUGFIX] Resolve duplicate array key in ext:impexp test fixture
Resolves: #96681
Releases: main, 11.5
Change-Id: I71ff411cd4cd639ad8d68dfcf02e46ac8818705d
Reviewed-on: https://revie...
Christian Kuhn
22:24 Revision 5dd599b1: [BUGFIX] Resolve duplicate array key in ext:impexp test fixture
Resolves: #96681
Releases: main, 11.5
Change-Id: I71ff411cd4cd639ad8d68dfcf02e46ac8818705d
Reviewed-on: https://revie...
Christian Kuhn
21:52 Revision de20a602: [TASK] Tests: Avoid a couple of obvious code inconsistencies
* Too many arguments to __construct()
* Inconsistent naming
* Undeclared properties
Change-Id: I16ac778db7afdeaa9348...
Christian Kuhn
21:51 Revision d7ec4080: [TASK] Tests: Avoid a couple of obvious code inconsistencies
* Too many arguments to __construct()
* Inconsistent naming
* Undeclared properties
Change-Id: I16ac778db7afdeaa9348...
Christian Kuhn
21:30 Revision 9e176bb7: [TASK] Tests: Have defined LANGUAGE_PRESETS
Constant LANGUAGE_PRESETS must be defined in tests
using SiteBasedTestTrait and needs to be accessible.
> Build/Scri...
Christian Kuhn
21:29 Revision ac7abd64: [TASK] Tests: Have defined LANGUAGE_PRESETS
Constant LANGUAGE_PRESETS must be defined in tests
using SiteBasedTestTrait and needs to be accessible.
> Build/Scri...
Christian Kuhn
19:41 Revision 6fdb966b: [TASK] Have composer/composer:^2.2 as dev dependency
The index.php entry point handling and package
handling core scripts are composer plugins. As
such, they rely on comp...
Christian Kuhn
19:40 Revision a46103ec: [TASK] Have composer/composer:^2.2 as dev dependency
The index.php entry point handling and package
handling core scripts are composer plugins. As
such, they rely on comp...
Christian Kuhn
19:37 Revision bd68ba8d: [BUGFIX] Avoid calling ProcessedFile::getPublicUrl(true)
$relativeToCurrentScript has been removed from
'ProcessedFile::getPublicUrl()' with #9620.
However one call to this ...
Stefan Bürk
18:46 Revision 9404b4a0: [TASK] Revamp phpstan config and handling
We currently have the situation that phpstan is
hard to update and maintain due to the phpstan
config file that sets ...
Stefan Bürk
18:46 Revision 997722b8: [TASK] Revamp phpstan config and handling
We currently have the situation that phpstan is
hard to update and maintain due to the phpstan
config file that sets ...
Stefan Bürk
14:11 Revision ba460e59: [TASK] styleguide: Remove superflous passwd and group volume mapping
Stefan Bürk
13:42 Revision 7bef8471: [TASK] styleguide: runTests.sh: HOME, passwd, group mapping is obsolete
composer and phpstan caches in .Build/.cache Christian Kuhn
13:26 Revision 8ac174fe: [TASK] styleguide: Update phpstan:^1.4.3
Have latest phpstan in composer.json:
> composer req --dev phpstan/phpstan:^1.4.3
Christian Kuhn
13:04 Revision 5cf82df7: [TASK] styleguide: Add phpstan baseline handling
Instead of manually handling exceptions for phpstan,
baseline handling has been implemented.
Whenever dealing with p...
Christian Kuhn
12:47 Revision 0486ffa0: [TASK] styleguide: Remove mssql left-over code
Christian Kuhn

2022-01-28

14:57 Revision 5ef67fcf: [BUGFIX] Fix undefined key warning in ElementInformationController
Since the element information window can also be opened from
an IRRE within a Flexform element, the table name might ...
Robert Kärner
14:26 Revision a26e0ad5: [TASK] Avoid reading languagefiles if argument is empty
'LanguageService->sL()' could be called with an empty
input string, thus reading language files and caching
the resul...
Stefan Bürk
14:26 Revision 4ffde6f4: [BUGFIX] Correctly calculate bit-masks in JavaScriptModuleInstruction
Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding fl...
Oliver Hader
13:41 Revision 3f89c5a3: [BUGFIX] Fix undefined key warning in ElementInformationController
Since the element information window can also be opened from
an IRRE within a Flexform element, the table name might ...
Robert Kärner
13:12 Revision 60a7d991: [BUGFIX] Correctly calculate bit-masks in JavaScriptModuleInstruction
Method JavaScriptModuleInstruction::addFlags used plain arithmetic
calculation on bit-masks. In case corresponding fl...
Oliver Hader
13:10 Revision 8d6ff3ec: [TASK] Avoid reading languagefiles if argument is empty
'LanguageService->sL()' could be called with an empty
input string, thus reading language files and caching
the resul...
Stefan Bürk
13:05 Revision e8120972: [BUGFIX] Consistently use EventDispatcherInterface
TYPO3 should never expose its EventDispatcher
implementation but only work with the PSR-14 interface
(SOLID principle...
Benni Mack
10:46 Revision 53c16dcb: [BUGFIX] Consistently use EventDispatcherInterface
TYPO3 should never expose its EventDispatcher
implementation but only work with the PSR-14 interface
(SOLID principle...
Benni Mack
08:42 Revision e05192c8: [TASK] Remove @internal from configuration exceptions
This change removes the `@internal` declaration from two exceptions
thrown by `ExtensionConfiguration->get()` which i...
Stephan Großberndt

2022-01-27

19:36 Revision d3d92168: [TASK] Remove @internal from configuration exceptions
This change removes the `@internal` declaration from two exceptions
thrown by `ExtensionConfiguration->get()` which i...
Stephan Großberndt

2022-01-26

09:17 Revision ce9d22b6: [TASK] styleguide: Adapt to strict FunctionalTestCase
Adapt to a patch in typo3/testing-framework,
adding strict typing to functional test case.
Releases: main
Stefan Bürk

2022-01-25

22:27 Revision 22f64585: [TASK] Avoid misusing ModuleTemplate in login
There are a couple of login related controllers:
* LoginController - handles user+password login
* ResetPasswordContr...
Christian Kuhn
18:46 Revision 73fbce5a: [TASK] Adapt to strict FunctionalTestCase
Adapt to a patch in typo3/testing-framework, thus
update of typo3/testing-framework in composer.lock
is mantandory in...
Wouter Wolters
16:36 Revision 9677f470: [BUGFIX] Avoid not closing form in SetupModuleController
The form tag in 'User Settings' is never closed
since that tag is added too late to $this->content.
Resolves: #96645...
Christian Kuhn
16:13 Revision e92e1947: [BUGFIX] Avoid not closing form in SetupModuleController
The form tag in 'User Settings' is never closed
since that tag is added too late to $this->content.
Resolves: #96645...
Christian Kuhn
14:39 Revision c5659eb4: [TASK] Avoid misusing ModuleTemplate in link handler
The link handler, used when e.g. selecting things in
tt_content header_link and when editing links in RTE,
are modals...
Christian Kuhn
14:00 Revision 26570603: [TASK] Migrate Workspace Test Fixtures from XML to CSV
Resolves: #96643
Releases: main, 11.5
Change-Id: I561b4ccfc3722778c102460d4e79732be020a41a
Reviewed-on: https://revie...
Benni Mack
13:38 Revision 9783d559: [TASK] Migrate Workspace Test Fixtures from XML to CSV
Resolves: #96643
Releases: main, 11.5
Change-Id: I561b4ccfc3722778c102460d4e79732be020a41a
Reviewed-on: https://revie...
Benni Mack
12:55 Revision 2d21c593: [BUGFIX] Resolve DOM elements in NavigationContainer on usage
There have been reports that DOM elements that were assigned in the
constructor of NavigationContainer actually were ...
Oliver Hader
12:55 Revision 3ed117bb: [BUGFIX] Resolve DOM elements in NavigationContainer on usage
There have been reports that DOM elements that were assigned in the
constructor of NavigationContainer actually were ...
Oliver Hader
12:16 Revision 0fe332e0: [BUGFIX] Fix undefined array key warning in FormPagePreviewRenderer
Resolves: #96642
Releases: main, 11.5
Change-Id: I2be1ae3fc90ab72e86c534b5f3e7406ae39e960f
Reviewed-on: https://revie...
Oliver Bartsch
11:50 Revision 1b5a6b79: [TASK] Extend .phpstorm.meta.php for further autocompletion support
Extend PHPStorm meta file with further definitions for autocompletion
support and avoid unnecessary php docblocks in ...
Stefan Bürk
11:02 Revision 6b393602: [TASK] Avoid misusing ModuleTemplate in element browser
The element browser - selecting records for type="group"
and "Add image" in FAL - are modals without doc header
and s...
Christian Kuhn
10:55 Revision b3d79135: [BUGFIX] Fix undefined array key warning in FormPagePreviewRenderer
Resolves: #96642
Releases: main, 11.5
Change-Id: I2be1ae3fc90ab72e86c534b5f3e7406ae39e960f
Reviewed-on: https://revie...
Oliver Bartsch
10:30 Revision f7cda053: [TASK] Migrate Form Framework JavaScript and documentation to ES6
The module syntax is moved from AMD to ES6.
To avoid reindenting every javasscript line (>10000 LOC),
the existings f...
Benjamin Franzke
09:59 Revision f57c8cd5: [BUGFIX] Remove element browser registration for 'file_reference'
The element browser 'file_reference' can't be reached
anymore since the removal of type="group"
internal_type="file_r...
Christian Kuhn
09:41 Revision 98ed8f29: [TASK] Extend .phpstorm.meta.php for further autocompletion support
Extend PHPStorm meta file with further definitions for autocompletion
support and avoid unnecessary php docblocks in ...
Stefan Bürk
09:23 Revision d3881305: [BUGFIX] Remove undefined variable in extensionmanager ListUtility
Fixing an issue with package informations to list extensions for
the cli command 'extension:list' code has been moved...
Stefan Bürk
07:53 Revision 6fb8c7b8: [BUGFIX] Simulate usergroup in FE previews for restricted pages
This change also sets a "userGroups" record for a
simulated user group, and also the user, in order
to build a proper...
Benni Mack
06:37 Revision 4efb8278: [BUGFIX] Add missing boolean case to admin panel
When dumping table data, the admin panel formats values
dependent on their type. The boolean type was missing
resulti...
Susanne Moog
06:21 Revision d585717e: [BUGFIX] Simulate usergroup in FE previews for restricted pages
This change also sets a "userGroups" record for a
simulated user group, and also the user, in order
to build a proper...
Benni Mack
06:14 Revision 141425ab: [BUGFIX] Add missing boolean case to admin panel
When dumping table data, the admin panel formats values
dependent on their type. The boolean type was missing
resulti...
Susanne Moog
06:02 Revision bdc0a6c0: [TASK] Add acceptance test reports to Gitlab
Gitlab is able to give a nice overview of tests
and how often a test failed recently which
makes it easier to investi...
Jochen Roth

2022-01-24

23:07 Revision b677a917: [BUGFIX] Properly sort backend layout rows and cols
This fixes the sorting of backend layout rows
and cols in the page module, depending on TSconfig.
1. The rows are no...
Georg Ringer
22:53 Revision ed28a28a: [BUGFIX] Properly sort backend layout rows and cols
This fixes the sorting of backend layout rows
and cols in the page module, depending on TSconfig.
1. The rows are no...
Georg Ringer
22:15 Revision 3ab78ae8: [DOCS] Document the new LinkValidator module
The LinkValidator is an own module called "Check Links". Replaced affected screenshots and texts.
Resolves: #96633
R...
Lina Wolf
19:40 Revision 69274946: [BUGFIX] Prevent PHP warning in menu data processors
Check if the decoded menu is iterable,
before passing it to "foreach".
Note: No early return is used, since
this wou...
Oliver Bartsch
19:18 Revision b7f2ddb8: [BUGFIX] Prevent PHP warning in menu data processors
Check if the decoded menu is iterable,
before passing it to "foreach".
Note: No early return is used, since
this wou...
Oliver Bartsch
17:42 Revision b9754f67: [TASK] Add acceptance test reports to Gitlab
Gitlab is able to give a nice overview of tests
and how often a test failed recently which
makes it easier to investi...
Jochen Roth
17:06 Revision 0b9d7915: [BUGFIX] Let stdWrap return null again
This is a partial revert for #96354.
In order to prevent PHP 8.1 warnings when using
built-in functions like "trim" ...
Nikita Hovratov
17:04 Revision 883f3a3b: [BUGFIX] Use regular variable access in import/export backend module
It seems a nested variable access in Fluid `{{var}}` instead of
`{var}` has been used - which leads to a fatal error ...
Oliver Hader
16:39 Revision 82820afe: [BUGFIX] Let stdWrap return null again
This is a partial revert for #96354.
In order to prevent PHP 8.1 warnings when using
built-in functions like "trim" ...
Nikita Hovratov
16:17 Revision 7055e874: [BUGFIX] Avoid undefined array key "_MOUNT_OL" in PageLinkBuilder
Resolves: #96630
Releases: main, 11.5
Change-Id: Id40930d70250b93c871917160de9173cdc59d750
Reviewed-on: https://revie...
Chris Müller
15:59 Revision 31ba4ca4: [BUGFIX] Avoid undefined array key "_MOUNT_OL" in PageLinkBuilder
Resolves: #96630
Releases: main, 11.5
Change-Id: Id40930d70250b93c871917160de9173cdc59d750
Reviewed-on: https://revie...
Chris Müller
15:17 Revision 798f94a4: [TASK] Don't match generic render() in extension scanner
Matching method name render() with more than zero
arguments is so generic that it gives tons of false
positives in th...
Christian Kuhn
14:45 Revision 50d4e2c3: [TASK] Don't match generic render() in extension scanner
Matching method name render() with more than zero
arguments is so generic that it gives tons of false
positives in th...
Christian Kuhn
11:21 Revision 959d5c89: [TASK] Update PHP Parser to the latest release.
The current version of PHP Parser we're using doesn't support
all the new PHP 8.1 syntax yet. So update it.
Used co...
Larry Garfield
10:49 Revision 9abf027f: [BUGFIX] Have full LLL f:translate key in ext:workspaces
We missed an f:translate transition to full
LLL: syntax in ext:workspaces with #96548.
Resolves: #96625
Related: #96...
Christian Kuhn
09:49 Revision 008db57e: [TASK] Update PHP Parser to the latest release.
The current version of PHP Parser we're using doesn't support
all the new PHP 8.1 syntax yet. So update it.
Used co...
Larry Garfield
09:38 Revision 3403c7af: [TASK] Avoid misusing ModuleTemplate in BackendController
With the deprecation and removal of DocumentTemplate
the backend controllers have been transitioned to use
ModuleTemp...
Christian Kuhn

2022-01-22

19:31 Revision 1541892b: [TASK] Avoid inline-javascript in InstallTool ExtensionConfiguration
ExtensionConfiguration uses inline JavaScript for the ColorPicker
initialization. Move the ColorPicker initialization...
Benjamin Franzke
19:26 Revision ac3916bd: [BUGFIX] Avoid inline-javascript in InstallTool ExtensionConfiguration
Since #96511 RequireJS is no longer loaded in the InstallTool.
This revealed that the ExtensionConfiguration uses inl...
Benjamin Franzke
19:23 Revision dca901b7: [TASK] Support FLAG_USE_TOP_WINDOW for ESM instructions
Implement top-frame-module loading for ES6 modules.
With RequireJS we could simply invoke top.require(), but
for nati...
Benjamin Franzke
13:12 Revision 8f16710b: [BUGFIX] Avoid undefined array key 'casesensitiveComp'
Using null coalescing operator with fallback to 'false'
to avoid undefined array key access warnings when key
'casese...
Stefan Bürk
12:34 Revision 9cce67d9: [BUGFIX] Avoid undefined array key 'casesensitiveComp'
Using null coalescing operator with fallback to 'false'
to avoid undefined array key access warnings when key
'casese...
Stefan Bürk
12:14 Revision 8c626122: [BUGFIX] Replace properties correctly in Extbase Persistence Class overrides
Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu...
Benni Mack
12:13 Revision af23996c: [BUGFIX] Replace properties correctly in Extbase Persistence Class overrides
Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu...
Benni Mack
12:02 Revision 06aca1a2: [BUGFIX] Avoid PHP warning in Extbase Workspace Overlays
Due to the fact that PageRepository->getRawRecord()
can return an array OR 0 (int) Typo3DbBackend must check
for an a...
Benni Mack
12:00 Revision ea5e2def: [BUGFIX] Replace properties correctly in Extbase Persistence Class overrides
Due to a bug, the class properties did not override
properly using alternative names as the TYPO3-internal
"mergeRecu...
Benni Mack
11:50 Revision 2394359d: [BUGFIX] Avoid PHP warning in Extbase Workspace Overlays
Due to the fact that PageRepository->getRawRecord()
can return an array OR 0 (int) Typo3DbBackend must check
for an a...
Benni Mack

2022-01-21

23:50 Revision b09b5e52: [!!!][TASK] Move pages.fe_login_mode into custom extension
The pages.fe_login_mode field was initially introduced
to allow reducing the amount of possible cache variants.
Sinc...
Oliver Bartsch
23:33 Revision 68d41aa6: [TASK] Use shorthand version for various getLanguageOverlay occurrences
This is a pre-patch for multi-level language fallback
Resolves: #96611
Releases: main
Change-Id: I82e2063a7d17d29bf9...
Benni Mack
21:33 Revision 8afbb74f: [FEATURE] Add centralized way to load PageTsConfig
This change adds a new way to load globally defined
PageTsConfig which was previously handled
via "ExtensionManagemen...
Benni Mack
20:07 Revision fb4252d0: [BUGFIX] Resolve deleted records in workspace notifications
This change properly fetches a record, even if the
record was deleted in a workspace, so the TSconfig
is still fetche...
Benni Mack
18:59 Revision 2ebb7d53: [BUGFIX] Resolve deleted records in workspace notifications
This change properly fetches a record, even if the
record was deleted in a workspace, so the TSconfig
is still fetche...
Benni Mack
15:58 Revision ba2cae54: [TASK] Avoid TBE_EDITOR declaration via synchronous script tag
TBE_EDITOR is only needed for the legacy, inline-javascript based,
TBE_EDITOR.customEvalFunctions registry, therefore...
Benjamin Franzke
15:33 Revision cf7e4f22: [TASK] Avoid duplicate DragUploader initialization
The DragUploader module initializes itself by calling
initialize() as last execution step, therefore the
function doe...
Benjamin Franzke
15:19 Revision 8fdd96d7: [TASK] Avoid duplicate DragUploader initialization
The DragUploader module initializes itself by calling
initialize() as last execution step, therefore the
function doe...
Benjamin Franzke
13:24 Revision 4fb032c9: [!!!][TASK] Remove deprecated ModuleTemplate->addJavaScriptCode()
Resolves: #96604
Related: #96107
Related: #91786
Change-Id: I208e320d6c7c2895bb70fc299317541d60c84131
Reviewed-on: ht...
Christian Kuhn
13:07 Revision c56d2ae8: [TASK] Use native TYPO3Fluid view in ext:seo frontend
To demonstrate it's possible to use the native
TYPO3 "standalone" Fluid TemplateView in the frontend,
the patch chang...
Christian Kuhn
12:47 Revision c17950e1: [BUGFIX] Toggle cropper on focus area interaction
To workaround the issue that a focus area cannot get dragged anymore,
the cropper now gets disabled if interaction wi...
Andreas Fernandez
12:34 Revision fc95fe87: [BUGFIX] Toggle cropper on focus area interaction
To workaround the issue that a focus area cannot get dragged anymore,
the cropper now gets disabled if interaction wi...
Andreas Fernandez
12:29 Revision 49c55de9: [!!!][TASK] Enforce non-empty configuration in cObj::parseFunc
Invoking ContentObjectRenderer::parseFunc without configuration
or TypoScript reference is not possible anymore and i...
Oliver Hader
12:28 Revision a679bbb5: [TASK] Add and use includeJavaScriptModules in <f:be.pageRenderer>
Usages have been converted with:
git grep -l includeRequireJsModules= | \
grep -v /Documentation/Changelog/ | ...
Benjamin Franzke
12:20 Revision 6a34e0ad: [TASK] Use ES6 JavaScript module specifiers in InstallTool
Do no longer add the .js suffix in the javascript module, but
supply it via the templates and use a new data-import a...
Benjamin Franzke
11:57 Revision 09a6247e: [TASK] runTests.sh: Use sqlite by default for functionals
Change the default DBMS for functional tests in
runTests.sh from mariadb to sqlite: sqlite is
sigificantly quicker wi...
Christian Kuhn
11:02 Revision 57648d3f: [TASK] runTests.sh: Use sqlite by default for functionals
Change the default DBMS for functional tests in
runTests.sh from mariadb to sqlite: sqlite is
sigificantly quicker wi...
Christian Kuhn
10:27 Revision c9634a4f: [TASK] Use BackendTemplateView in various controllers
This goes through a series of relatively simple
controllers, switching them to BackendTemplateView.
Change-Id: Icde1...
Christian Kuhn
09:22 Revision 47481cbd: [TASK] Migrate backend TypeScript to ECMAScript modules (ESM)
Use the JavaScript module and importmap Feature introduced
in #96510 to import JavaScript as native browser modules
(...
Benjamin Franzke
09:22 Revision 425f94f5: [TASK] Ensure requirejs-loader.js and JavaScriptItemHandler.js are cache invalidatable
If compression of JavaScript files is disabled, we need to add cache
busting parameters to any backend JavaScript res...
Benjamin Franzke
01:14 Revision 8af0e5e4: [TASK] styleguide: Raise MySQL server version to 8.0
Core has raised requirements of MySQL to 8.0 which we
adopt now and raise testing to MySQL 8.0 now to align
with this...
Stefan Bürk
01:14 Revision ed2f71bf: [TASK] styleguide: Set version to 12.x.x and require core v12 in ext_emconf.php
Stefan Bürk
01:14 Revision a551849b: [TASK] styleguide: Remove MSSQL support
Typo3 core has dropped MSSQL support for v12, this we
remove this from v12 styleguide also.
* removed mssql dbms and...
Stefan Bürk
01:14 Revision 11d4563b: [TASK] styleguide: Remove PHP7.4 and PHP8.0 from github test workflow matrix
To align with raised core and testing-framework minimum php version
requirement, we remove PHP7.4 and PHP8.0 from git...
Stefan Bürk
01:14 Revision c3943c50: [TASK] styleguide: Applied php-cs-fixer changes after typo3/coding-standards update
Added fixed code files after running php-cs-fixer with updated
ruleset from typo3/coding-standards.
used commands:
...
Stefan Bürk
01:14 Revision d38bc4b6: [TASK] styleguide: Ensure cgl (php-cs-fixer) runs with PHP8.1
Ensure that cgl runs with PHP8.1, which is a pre-patch
for switching to PHP8.1 only on main branch, and enable
cgl te...
Stefan Bürk

2022-01-20

22:07 Revision 312e50c4: [BUGFIX] Keep defined order for menus of type list
If the special menu type 'list' is used, the order
must be kept as provided within the list configuration.
Resolves:...
Georg Ringer
21:19 Revision 2dfb90c0: [BUGFIX] Keep defined order for menus of type list
If the special menu type 'list' is used, the order
must be kept as provided within the list configuration.
Resolves:...
Georg Ringer
21:19 Revision 983b2192: [BUGFIX] Hide view page button in special all languages view
The "View webpage" button in the docheader of the
page module allows to view the page in the currently
selected langu...
Oliver Bartsch
21:00 Revision 2cb00f74: [BUGFIX] Hide view page button in special all languages view
The "View webpage" button in the docheader of the
page module allows to view the page in the currently
selected langu...
Oliver Bartsch
20:32 Revision ff98f405: [BUGFIX] Revert behaviour of stdWrap ifEmpty
The stdWrap function ifEmpty must return true if a
PHP falsy value is given. That means e.g. an empty
string or a "0"...
Sascha Egerer
19:16 Revision 654eaf76: [BUGFIX] Revert behaviour of stdWrap ifEmpty
The stdWrap function ifEmpty must return true if a
PHP falsy value is given. That means e.g. an empty
string or a "0"...
Sascha Egerer
16:25 Revision 8a69f688: [BUGFIX] Prevent null pointer in PageLayoutView
Under some circumstances, e.g. in a translations
only page module, a given $languageId (in this case
the default `0`)...
Oliver Bartsch
15:21 Revision d84b0641: [TASK] Use BackendTemplateView in ext:recordlist
This affects the list module and the link
browser. A heavy-mocking unit test without
much benefit is removed along th...
Christian Kuhn
13:12 Revision bb90a1c3: [TASK] Use BackendTemplateView in ext:info
Switching from StandaloneView to BackendTemplateView
in ext:info, minor template adaptions.
Resolves: #96598
Related...
Christian Kuhn
12:26 Revision f4729c20: [BUGFIX] Use LanguageServiceFactory in FE RequestHandler
When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ...
Oliver Bartsch
11:50 Revision 401068f6: [BUGFIX] Replace undefined variable with reading PageTSConfig option
Long story short, through multiple refactorings along the road, from
the inital introduction of the 'mod.newContentEl...
Stefan Bürk
11:01 Revision f032df4e: [BUGFIX] Replace undefined variable with reading PageTSConfig option
Long story short, through multiple refactorings along the road, from
the inital introduction of the 'mod.newContentEl...
Stefan Bürk

2022-01-19

22:47 Revision c8a9859c: [TASK] Avoid inline JavaScript for clipboard paste in page layout
Resolves: #96565
Releases: main, 11.5
Change-Id: Iace92f424acf20fa9329dc5380facd30abe87b00
Reviewed-on: https://revie...
Benjamin Franzke
22:12 Revision a4bf3c34: [TASK] Avoid inline JavaScript for clipboard paste in page layout
Resolves: #96565
Releases: main, 11.5
Change-Id: Iace92f424acf20fa9329dc5380facd30abe87b00
Reviewed-on: https://revie...
Benjamin Franzke
21:58 Revision 6590c5f9: [BUGFIX] Use LanguageServiceFactory in FE RequestHandler
When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ...
Oliver Bartsch
21:01 Revision ec199ff4: [TASK] Use BackendTemplateView in ext:tstemplate
This is a rather straight implementation of
BackendTemplateView in favor of StandaloneView
in ext:tstemplate - refact...
Christian Kuhn
20:31 Revision bd20ccd9: [BUGFIX] Use LanguageServiceFactory in FE RequestHandler
When previewing pages a null pointer exception
is triggered in the frontend RequestHandler, in
case $GLOBALS['LANG'] ...
Oliver Bartsch
19:24 Revision a8f31f6f: [BUGFIX] Cleanup missed removal of unused variable in ShortcutController
ShortcutController has recieved an modernization overhaul
and shifted data changing actions from 'GET' and 'POST'
han...
Stefan Bürk
19:24 Revision 954a07fb: [BUGFIX] Avoid reading value from undefined variable
Show columns selection functionality has been improved
for issue #94474, but during refactoring some code it
falsly t...
Stefan Bürk
19:11 Revision 024043d1: [BUGFIX] Avoid reading value from undefined variable
Show columns selection functionality has been improved
for issue #94474, but during refactoring some code it
falsly t...
Stefan Bürk
18:08 Revision 2e92b1d0: [TASK] Remove SqlSrv related test code
We're not actively testing Microsoft SQL Server
anymore. The functional test related group annotation
not-mssql can b...
Christian Kuhn
16:31 Revision 4a5e6a1b: [TASK] Remove some PHP < 8.1 specific code switches
Resolves: #96587
Releases: main
Change-Id: I2c44ce44a667f246c25eaab4c87cb57a3a21c6cb
Reviewed-on: https://review.typo...
Christian Kuhn
16:31 Revision 9b6b4bc2: [TASK] Clean up Build/Scripts/duplicateExceptionCodeCheck.sh
A couple of 'ignoreFiles' don't exist anymore.
Change-Id: I11200265f71035e70023fa396df44c336ab0649b
Resolves: #96586...
Christian Kuhn
14:38 Revision 8c2a54bd: [TASK] Refactor ext:scheduler controller and view
This is a careful rewrite of the scheduler backend
module controller and its view. It reaches a
significantly better ...
Christian Kuhn
14:35 Revision 229fa6fa: [TASK] Avoid StandaloneView() in functional tests
StandaloneView() initalizes an ExtbaseRequest in
__construct() and adds it to the rendering context.
This is unfortu...
Stefan Bürk
14:19 Revision 297e7379: [TASK] Remove PHP 7 specific phpstan config
Obsolete with TYPO3 v12 core being PHP >= 8.1.
Resolves: #96584
Releases: main
Change-Id: Idbe713b4b45f0e7f870bdeb60...
Christian Kuhn
14:17 Revision 34edd496: [BUGFIX] Avoid calling trim(null) in ContentObjectRenderer
'ContentObjectRenderer->stdWrap()' calls subfunction starting
with 'stdWrap_' which may not only return strings, but ...
dev-rke
14:09 Revision 83086527: [TASK] Remove PHP < 8 specific libxml_disable_entity_loader()
libxml bundled in PHP before 8.0 was suspectible
to XXE. The core mitigated this by setting
libxml_disable_entity_loa...
Christian Kuhn
13:57 Revision b09c4e5c: [BUGFIX] Avoid calling trim(null) in ContentObjectRenderer
'ContentObjectRenderer->stdWrap()' calls subfunction starting
with 'stdWrap_' which may not only return strings, but ...
dev-rke
12:35 Revision 98184da7: [BUGFIX] Fix undefined array key in StagesService
Resolves: #96582
Releases: main, 11.5
Change-Id: I3a9ebbf55230d526a7e0f92118cb04f1fa19254c
Reviewed-on: https://revie...
Oliver Bartsch
12:19 Revision d214ac54: [BUGFIX] Create module template early in PreviewController
When creating the module template, also default CSS
and JS is added (using PageRenderer).
In the PreviewController, ...
Oliver Bartsch
12:18 Revision 0fbad597: [BUGFIX] Fix undefined array key in StagesService
Resolves: #96582
Releases: main, 11.5
Change-Id: I3a9ebbf55230d526a7e0f92118cb04f1fa19254c
Reviewed-on: https://revie...
Oliver Bartsch
11:35 Revision 54a3f2a1: [DOCS] Resolve todos in the rte_ckeditor Documentation
Additionally, the versions in the Settings.cfg are
fixed.
Resolves: #91739
Releases: main, 11.5
Change-Id: If2128ad3...
Lina Wolf
11:27 Revision 33c5f3d9: [TASK] Avoid dashboard "phones home" by default
The default dashboard for new users adds the
"TYPO3 news" widget which fetches an RSS feed
from typo3.org.
This migh...
Christian Kuhn
11:03 Revision 075ad83f: [DOCS] Resolve todos in the rte_ckeditor Documentation
Additionally, the versions in the Settings.cfg are
fixed.
Resolves: #91739
Releases: main, 11.5
Change-Id: If2128ad3...
Lina Wolf
10:58 Revision 77903d4c: [TASK] Avoid dashboard "phones home" by default
The default dashboard for new users adds the
"TYPO3 news" widget which fetches an RSS feed
from typo3.org.
This migh...
Christian Kuhn
10:47 Revision 88ec94fa: [BUGFIX] Avoid undefined global variable sending email on multiple wrong logins
Resolves: #96572
Releases: main, 11.5
Change-Id: I162a8e98abe6e4d975d0d972f395484b47808f30
Reviewed-on: https://revie...
Chris Müller
10:02 Revision 98f40489: [BUGFIX] Add PHP 8.0/8.1 compatibility for Import
Importer fails to process soft references (e.g. phone numbers, email,
links etc.) in PHP 8.0/8.1 with "Undefined arra...
dev-rke
09:51 Revision 61c6002e: [BUGFIX] Avoid undefined global variable sending email on multiple wrong logins
Resolves: #96572
Releases: main, 11.5
Change-Id: I162a8e98abe6e4d975d0d972f395484b47808f30
Reviewed-on: https://revie...
Chris Müller
09:33 Revision 7bcbd80e: [BUGFIX] Add PHP 8.0/8.1 compatibility for Import
Importer fails to process soft references (e.g. phone numbers, email,
links etc.) in PHP 8.0/8.1 with "Undefined arra...
dev-rke
07:04 Revision 1436fe89: [TASK] Avoid resolving first optional argument as content overrule
Trait 'CompileWithContentArgumentAndRenderStatic' provides
magic handling trying to retrieve the first optional
regis...
Stefan Bürk

2022-01-18

14:12 Revision e4c5e150: [DOCS] Update outdated manual of EXT:fluid_styled_content
Resolves: #95835
Releases: main, 11.5
Change-Id: Iaa79aa4daa763c66c073d407168a7494cc11e938
Reviewed-on: https://revie...
Lina Wolf
12:45 Revision 4c04c847: [!!!][TASK] Prepare for new minimum system requirements
System Requirements have been announced for TYPO3
v12 [1]: PHP 8.1 and higher, raised minimum DBMS
versions and remov...
Stefan Bürk
12:44 Revision 0d4fff93: [TASK] Use proper QueryBuilder execute() replacement methods
doctrine/dbal implemented single purpose method to replace the
compound 'execute()' in QueryBuilder to avoid the inco...
Stefan Bürk
12:43 Revision 597a92fd: [TASK] Use proper QueryBuilder execute() replacement methods
doctrine/dbal implemented single purpose method to replace the
compound 'execute()' in QueryBuilder to avoid the inco...
Stefan Bürk
12:07 Revision 4343860f: [DOCS] Update outdated manual of EXT:fluid_styled_content
Resolves: #95835
Releases: main, 11.5
Change-Id: Iaa79aa4daa763c66c073d407168a7494cc11e938
Reviewed-on: https://revie...
Lina Wolf
10:12 Revision a3e28bd1: [FEATURE] Add infrastructure for ES6 modules and importmaps
JavaScript ES6 modules may now be used instead of AMD modules, both in
backend and frontend context. JavaScript node-...
Benjamin Franzke

2022-01-17

22:13 Revision 82c295f6: [TASK] runTests.sh: Skip reports.xml in acceptance tests
The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w...
Christian Kuhn
22:13 Revision 74b2dc42: [TASK] runTests.sh: Skip reports.xml in acceptance tests
The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w...
Christian Kuhn
21:54 Revision ad87f3ed: [TASK] runTests.sh: Skip reports.xml in acceptance tests
The created reports.xml when running acceptance tests
is used for nothing in CI and just uploaded as artifact
along w...
Christian Kuhn
21:11 Revision 90f518bd: [TASK] Refactor ext:impexp controller and view
A bigger but careful refactoring of the
ImportController and ExportController together
with a view adaption. The modu...
Christian Kuhn
18:33 Revision 71b67916: [TASK] Set allowed composer plugins in test distribution
With composer >=2.2.0, allowed composer plugins have
to be added to composer.json as config/allowed_plugins.
This ha...
Stefan Bürk
07:32 Revision a571aa9e: [TASK] Set allowed composer plugins in test distribution
With composer >=2.2.0, allowed composer plugins have
to be added to composer.json as config/allowed_plugins.
This ha...
Stefan Bürk
04:16 Revision 860ccf53: [BUGFIX] Prevent undefined key warning in IMG_RESOURCE cObj
Since the file property of an IMG_RESOURCE cObj might have
no direct value set, trying to access it must be protected...
Robert Kärner
03:59 Revision e133ea9c: [BUGFIX] Prevent undefined key warning in IMG_RESOURCE cObj
Since the file property of an IMG_RESOURCE cObj might have
no direct value set, trying to access it must be protected...
Robert Kärner

2022-01-16

19:54 Revision 72640460: [!!!][TASK] Remove TYPO3_CONF_VARS['SYS']['USdateFormat']
$GLOBALS['TYPO3_CONF_VARS']['SYS']['USdateFormat'] = true/false
has been added in TYPO3 4.0 with a happy "Go US!" mes...
Christian Kuhn
10:27 Revision 9b93bab2: [TASK] styleguide: Avoid deprecated phpstan configuration 'excludes_analyse'
PHPStan configuration option 'excludes_analyse' is deprecated and
should be replaced with the new option 'excludePath...
Stefan Bürk
10:10 Revision 69abf6f8: [TASK] styleguide: Add allowed plugins to composer.json
composer 2.2.x checks if plugins are allowed, and if not asks for
confirmation to execute (and add) it.
This change ...
Stefan Bürk
08:00 Revision dc015be3: [BUGFIX] styleguide: Resolve duplicated item value in tx_styleguide_elements_select
Oliver Bartsch
07:59 Revision 75e10675: [TASK] styleguide: Avoid $GLOBALS['TYPO3_CONF_VARS']['SYS']['USdateFormat']
Christian Kuhn
07:13 Revision 58702154: [TASK] Clean up workspace module views
* Use BackendTemplateView
* Hand over template to render as view->render('MyTemplate')
* Less class state
* Declare s...
Christian Kuhn
07:13 Revision c5f87edc: [TASK] Modernize ext:reports view
* Simplified routing without browser redirects
* Hide main drop-down if there is only one report
* Show main report b...
Christian Kuhn
 

Also available in: Atom