Activity
From 2022-05-13 to 2022-06-11
2022-06-11
- 17:12 Revision 979ce508: [BUGFIX] Wait for element in page tree to disappear
- Currently the clearFilterReloadsPageTreeWithoutFilterApplied
randomly fails due to a still existing element.
This see... - 16:50 Revision edad6900: [BUGFIX] Wait for element in page tree to disappear
- Currently the clearFilterReloadsPageTreeWithoutFilterApplied
randomly fails due to a still existing element.
This see... -
14:39 Revision 351d751a: [BUGFIX] Enable login refresh form submit via ENTER key
- By making the modal's primary button a submit button
and binding it to the form, the user can now use the ENTER key t... -
12:53 Revision 9de6d9e2: [TASK] Extend 'runTests.sh' to clean rendered documentation
- This change adds the ability to clean rendered documentation
folder and files in all system extension folders in one ... -
- This change adds the ability to clean rendered documentation
folder and files in all system extension folders in one ... -
- This change adds the ability to clean rendered documentation
folder and files in all system extension folders in one ...
2022-06-10
-
- This patch adds the ability to run commands with PHP8.2 using
`Build/Scripts/runTests.sh`. Support is added early to ... -
- This patch adds the ability to run commands with PHP8.2 using
`Build/Scripts/runTests.sh`. Support is added early to ... -
19:11 Revision 56c8c01e: [TASK] Avoid failing test value for PHP 8.1.7 strtotime bug
- PHP 8.1.7 introduced a bug that it considers the month number 100
to be valid, which breaks one of our tests.
As it ... -
- PHP 8.1.7 introduced a bug that it considers the month number 100
to be valid, which breaks one of our tests.
As it ... -
12:26 Revision d41679a4: [BUGFIX] Use moment.unix for visualizing regular unix timestamps
- A dialog trying to prevent overriding existing files in the filelist
module shows an incorrect modification date of f... -
- A dialog trying to prevent overriding existing files in the filelist
module shows an incorrect modification date of f... -
- A dialog trying to prevent overriding existing files in the filelist
module shows an incorrect modification date of f... -
12:18 Revision 73637a4d: [BUGFIX] Throw 404 error when XML sitemap is not available
- Resolves: #97612
Releases: main, 11.5
Change-Id: Ia23a15f0beb864a8b53c568ed27642ec7ac8c7b2
Reviewed-on: https://revie... -
- Resolves: #97612
Releases: main, 11.5
Change-Id: Ia23a15f0beb864a8b53c568ed27642ec7ac8c7b2
Reviewed-on: https://revie... -
- By making the modal's primary button a submit button
and binding it to the form, the user can now use the ENTER key t... -
08:48 Revision 6999202a: [BUGFIX] Tighten a conditional check in LinkService
- Resolves: #97741
Releases: main
Change-Id: Ic346680b2f3fcaf8ffef5f9b9bd1cb903da61e0b
Reviewed-on: https://review.typo...
2022-06-09
- 14:37 Revision 1708cda8: [BUGFIX] Apply empty values in language-overlay
- Some default fields (e.g. tt_content.bodytext) can contain null values.
TYPO3 first fetches the data in the default l... -
08:46 Revision 6f84ff52: [!!!][TASK] Remove unused MailerAdapterInterface
- The MailerAdapterInterface, related to SwiftMailer
is removed, since it is unused in core since v7.
Resolves: #97752... -
- More code paths identified as dead by PHPStan, or
that PHPStan isn't understanding correctly.
Used command:
> Build... -
- More code paths identified as dead by PHPStan, or
that PHPStan isn't understanding correctly.
Used command:
> Build...
2022-06-08
-
- Resolves: #97745
Releases: main
Change-Id: I903f04c8eba97e7e4fb148041288da843ea1647d
Reviewed-on: https://review.typo... - 11:38 Revision 12da9f62: [BUGFIX] Apply empty values in language-overlay
- Some default fields (e.g. tt_content.bodytext) can contain null values.
TYPO3 first fetches the data in the default l... -
- This helps avoid breakage when GeneralUtility will switch to
strict mode.
This change also prevents a whole bunch of...
2022-06-07
- 16:04 Revision 3cd23569: [TASK] Remove type annotations where possible
- Searched for "/** @var " and went through all results manually.
Skipped results where GeneralUtility::makeInstance is... - 16:04 Revision 7d1bc443: [TASK] Remove type annotations where possible
- Searched for "/** @var " and went through all results manually.
Skipped results where GeneralUtility::makeInstance is... -
14:52 Revision e995c4f0: [TASK] Update TypeScript to 4.7
- Executed commands:
cd Build
yarn add --dev typescript@~4.7.0
Resolves: #97698
Releases: main, 11.5
Change-I... -
14:50 Revision 3a25c94b: [!!!][FEATURE] Introduce PSR-14 events in TSFE page resolving
- This change introduces three new PSR-14 Events in favor
of the following hooks:
* $GLOBALS['TYPO3_CONF_VARS']['SC_OP... -
- The "page" and "pages" translation keys are backwards.
This patch makes them forwards.
Resolves: #96795
Releases: ma... - 08:44 Revision 3d1b0a08: [DOCS] Make example more general to not confuse
- Releases: main
Resolves: #97735
Change-Id: I703595777f4bb7727cc72b7ab92cb2446f3cf30e
Reviewed-on: https://review.typo... -
07:30 Revision dd3d8e38: [BUGFIX] Avoid invalid type exception in FinisherVariableProvider
- Guard invalid argument type exception by using null coalescing operator
in `\TYPO3\CMS\Form\Domain\Finishers\Finisher... -
- Guard invalid argument type exception by using null coalescing operator
in `\TYPO3\CMS\Form\Domain\Finishers\Finisher...
2022-06-06
- 20:10 Revision 0fc75be1: [TASK] Solve several phpstan issues in GifBuilder
- Also add some (indirect) basic tests for
GifBuilder::calculateValue.
Used command:
> Build/Scripts/runTests.sh -s p... - 19:46 Revision f9c1ed54: [TASK] Solve several phpstan issues in GifBuilder
- Also add some (indirect) basic tests for
GifBuilder::calculateValue.
Used command:
> Build/Scripts/runTests.sh -s p... - 19:23 Revision 9a493fd1: [BUGFIX] Fix randomly failing PageTreeFilterCest
- Sometimes it happens that the page tree is not updated
within a certain amount of time resulting in failing tests.
Th... - 19:03 Revision 520ecd36: [BUGFIX] Fix randomly failing PageTreeFilterCest
- Sometimes it happens that the page tree is not updated
within a certain amount of time resulting in failing tests.
Th... -
- Resolves: #97658
Releases: main, 11.5
Change-Id: Ic4e18d64849e64404dca0eef240060d882476526
Reviewed-on: https://revie... -
- Resolves: #97658
Releases: main, 11.5
Change-Id: Ic4e18d64849e64404dca0eef240060d882476526
Reviewed-on: https://revie... -
- This is now covered by the annotations using generics in the testing
framework base class, and hence not needed anymo... -
- This is now covered by the annotations using generics in the testing
framework base class, and hence not needed anymo... - 18:02 Revision 7a3202cb: [BUGFIX] Make file paths absolute in GIFBUILDER
- In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inc... -
- This is now covered by the annotations using generics in the testing
framework base class, and hence not needed anymo...
2022-06-04
-
- For translating / synchronizing (inline) records, the DataHandler
dispatches the data map to the DataMapProcessor. Th... -
- For translating / synchronizing (inline) records, the DataHandler
dispatches the data map to the DataMapProcessor. Th... -
21:16 Revision d198c60a: [BUGFIX] Respect ordering in pagination of redirect module
- The pagination links of the redirects module must respect a given
ordering.
Resolves: #97645
Releases: main, 11.5
Ch... -
- The pagination links of the redirects module must respect a given
ordering.
Resolves: #97645
Releases: main, 11.5
Ch... -
- For empty storages, we need to avoid accessing inexistent array elements.
Resolves: #97417
Relates: #97554
Releases:... -
- For empty storages, we need to avoid accessing inexistent array elements.
Resolves: #97417
Relates: #97554
Releases:...
2022-06-03
-
20:28 Revision 7a637e81: [BUGFIX] Use configuration context for placeholders in YAML import
- The placeholder replacement in the yaml import method must receive
the current configuration context to be able to re... -
- The placeholder replacement in the yaml import method must receive
the current configuration context to be able to re... -
17:21 Revision 73ed5173: [TASK] Add functional tests to test the caching behavior of ext:form
- In preparation for patchset
https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/,
functional tests are introduced t... -
16:59 Revision a082c364: [BUGFIX] Ensure proper value when accessing array
- Even if the property 'crop' is not explicit set in the
TypoScript code provide expected values to the stdWrap
method ... -
- Even if the property 'crop' is not explicit set in the
TypoScript code provide expected values to the stdWrap
method ... -
- Instead of checking for the array key `enablecolumns` the check must be
done on the field `disabled` itself.
Resolve... -
- Instead of checking for the array key `enablecolumns` the check must be
done on the field `disabled` itself.
Resolve... -
- Also drop type annotations that already are present in the
corresponding field in the superclass, and drop some type ... -
- In #87380, it was recommended to use the `SiteLanguageAwareInterface`
instead of the `SiteLanguageAwareTrait` for mar... -
- If TCA with a file upload is used within IRRE (e.g. as done by
EXT:news), creating a new record or opening an existin... -
- + npm package moment up to v2.29.2 contained a vulnerability
(https://github.com/advisories/GHSA-8hfj-j24r-96c4) wh... -
- + npm package moment up to v2.29.2 contained a vulnerability
(https://github.com/advisories/GHSA-8hfj-j24r-96c4) wh... -
- Resolves: #97730
Releases: main
Change-Id: I78aa8d10dfdd045405316c25d8ce39d353b9e9d6
Reviewed-on: https://review.typo... -
- + npm package moment up to v2.29.2 contained a vulnerability
(https://github.com/advisories/GHSA-8hfj-j24r-96c4) wh... -
- If TCA with a file upload is used within IRRE (e.g. as done by
EXT:news), creating a new record or opening an existin...
2022-06-02
-
- Also add a missing type cast.
Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline
Resolves: #974... - 11:29 Revision 78d81a90: [TASK] Add URL to PHP documentation for datetime.format
- Resolves: #97726
Releases: main
Change-Id: I7139dc9431aa5bf117d2aa3d4cf4586e5bf74b8b
Reviewed-on: https://review.typo... -
- Also add a missing type cast.
Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline
Resolves: #974... -
- composer req --dev composer/composer:^2.2.12
Resolves: #97722
Releases: main, 11.5
Change-Id: I526de4c62b5f9bc03230a... -
- composer req --dev composer/composer:^2.2.12
Resolves: #97722
Releases: main, 11.5
Change-Id: I526de4c62b5f9bc03230a...
2022-05-31
-
- The scheduler module contains a special task,
which allows to select schedulable symfony
commands.
The corresponding... -
- The scheduler module contains a special task,
which allows to select schedulable symfony
commands.
The corresponding... -
- Based on the code, these parameters are nullable. The doc
comments should reflect that. Doing so eliminates several
P... -
- Based on the code, these parameters are nullable. The doc
comments should reflect that. Doing so eliminates several
P...
2022-05-30
-
10:44 Revision a368cde8: [TASK] Fix wrong indentation in Context class
- The switch structures in `Context` class are indented
wrong. This patch corrects the indentation.
Resolves: #97708
R... -
- The switch structures in `Context` class are indented
wrong. This patch corrects the indentation.
Resolves: #97708
R... -
- Used commands:
> composer req --dev phpstan/phpstan:^1.7.3
> ./Build/Scripts/runTests.sh -s clean
> ./Build/Scripts/... -
- Used commands:
> composer req --dev phpstan/phpstan:^1.7.3
> ./Build/Scripts/runTests.sh -s clean
> ./Build/Scripts/... -
- Also adapt the callers accordingly. This resolves a few PHPStan warnings
and allows simplifying some code.
Used comm... -
- Also adapt the callers accordingly. This resolves a few PHPStan warnings
and allows simplifying some code.
Used comm...
2022-05-29
-
- This gets rids of some PHPStan warnings triggered by the latest
testing framework raise.
Used command:
> ./Build/Scr...
2022-05-28
-
- This conversion got past the big conversion patch
before, probably due to the negation.
Resolves: #97640
Releases: m... -
- This conversion got past the big conversion patch
before, probably due to the negation.
Resolves: #97640
Releases: m... -
- Resolves: #97630
Releases: main, 11.5
Change-Id: Id31d1b28929eb85dd2adaa8a263e5d84a2a842b5
Reviewed-on: https://revie... -
- Resolves: #97630
Releases: main, 11.5
Change-Id: Id31d1b28929eb85dd2adaa8a263e5d84a2a842b5
Reviewed-on: https://revie... -
- According to PHPStan, these checks are all unnecessary.
Most of them appear to be type checks that have been
rendered... -
- Update copyright year to 2022
Resolves: #97704
Releases: main, 11.5, 10.4
Change-Id: I15e6c0674ac293eecad88f95379ec3... -
- Update copyright year to 2022
Resolves: #97704
Releases: main, 11.5, 10.4
Change-Id: I15e6c0674ac293eecad88f95379ec3... -
- According to PHPStan, these checks are all unnecessary.
Most of them appear to be type checks that have been
rendered... -
- Update copyright year to 2022
Resolves: #97704
Releases: main, 11.5, 10.4
Change-Id: I15e6c0674ac293eecad88f95379ec3...
2022-05-27
-
- The patch provides the following changes:
- Use consistent header levels
- Format code examples with the correct lang... -
- The patch provides the following changes:
- Use consistent header levels
- Format code examples with the correct lang... -
- php-cs-fixer has the fixer `function_to_constant` which replaces PHP
functions to their equivalent constants, which i... -
- The package guzzlehttp/guzzle has been updated to 7.4.3 and 6.5.6
respectively, both fixing a security vulnerability ... -
- The package guzzlehttp/guzzle has been updated to 7.4.3 and 6.5.6
respectively, both fixing a security vulnerability ... -
- The package guzzlehttp/guzzle has been updated to 7.4.3 and 6.5.6
respectively, both fixing a security vulnerability ...
2022-05-25
-
21:15 Revision e16fd7cb: [BUGFIX] Fix typolink parameter stdWrap when using additional info
- When using stdWrap for setting the actual parameter value, all
additional information (like target, class and title) ... -
- If a table in recordlist only contains records
which do not provide a checkbox, the "toggle
all" action should be dis... -
- If a table in recordlist only contains records
which do not provide a checkbox, the "toggle
all" action should be dis... -
- Ensure to properly typecast optional
parameters of throwStatus() before
passing them to type hinted methods.
Resolve... -
- When creating bookmarks to the "new" view in FormEngine,
those bookmark previously did not show up in the toolbar lis... -
- Occurred on accessing the record history
for records on pid=0.
Resolves: #97682
Releases: main, 11.5
Change-Id: I041... -
- Occurred on accessing the record history
for records on pid=0.
Resolves: #97682
Releases: main, 11.5
Change-Id: I041... -
- Ensure to properly typecast optional
parameters of throwStatus() before
passing them to type hinted methods.
Resolve... -
- Also drop type annotations that already are present in the
corresponding field in the superclass, and drop some type ... -
- The code in ConjunctionValidator can be greatly
simplified by taking advantage of the fact that
an empty result objec... -
- When creating bookmarks to the "new" view in FormEngine,
those bookmark previously did not show up in the toolbar lis... -
- The code in ConjunctionValidator can be greatly
simplified by taking advantage of the fact that
an empty result objec... -
11:11 Revision e5616696: [BUGFIX] Take dev mode into account for package hash
- When generating the identifier for the package artifact,
not only the hash from the composer.lock must be taken
into ... - 11:10 Revision 233b80cd: [BUGFIX] Avoid undefined array key warnings in GifBuilder
- GIFBUILDER processing doesn't return a processedFile
Resolves: #97651
Releases: main, 11.5
Change-Id: I24964ec640636... -
- When generating the identifier for the package artifact,
not only the hash from the composer.lock must be taken
into ... - 10:37 Revision 82046e63: [BUGFIX] Avoid undefined array key warnings in GifBuilder
- GIFBUILDER processing doesn't return a processedFile
Resolves: #97651
Releases: main, 11.5
Change-Id: I24964ec640636... - 07:47 Revision 8a79fd8f: [BUGFIX] styleguide: Make a type annotation in a test more specific
- https://github.com/TYPO3-CMS/styleguide/pull/326
This gets the type annotation in line with the latest testing
frame...
2022-05-24
-
19:48 Revision 75041196: [BUGFIX] Prevent undefined array key warning when fetching session data
- Resolves: #97686
Releases: master, 11.5
Change-Id: I0228126e4b7dd091b6eddc70bbbd8aade6142dcc
Reviewed-on: https://rev... -
- Resolves: #97686
Releases: master, 11.5
Change-Id: I0228126e4b7dd091b6eddc70bbbd8aade6142dcc
Reviewed-on: https://rev... -
- This patch fixes a typo in the description for BE.compressionLevel.
A single `s` is missing in `_.htacces`
Resolves:... -
- This patch fixes a typo in the description for BE.compressionLevel.
A single `s` is missing in `_.htacces`
Resolves:...
2022-05-23
-
20:44 Revision e78645bc: [TASK] Avoid method_exists() for phpunit 8 compat
- A couple of left overs from a phpunit 8 compat
layer. They can be safely removed since v12 and
v11 require phpunit 9.... -
- A couple of left overs from a phpunit 8 compat
layer. They can be safely removed since v12 and
v11 require phpunit 9.... - 20:31 Revision 36ebecb9: [TASK] Drop info deprecated about RealURL/CoolUri @ root-htaccess
- Releases: main
Resolves: #97675
Change-Id: Id92fd0bc9b9fe5dfdb4a771d165527debc832fc5
Reviewed-on: https://review.typo... -
- Update testing-framework to incorporate latest changes.
Some phpstan-baseline ignore-patterns are added and will
be ... -
- The new version finds some new possible bugs and
removes some incorrect ones.
Used commands:
> composer req --dev p... -
- The new version finds some new possible bugs and
removes some incorrect ones.
Used commands:
> composer req --dev p... -
14:56 Revision 361ddcef: [FEATURE] Add option to influence display of the website title
- Adds a new TypoScript option config.showWebsiteTitle.
The option controls whether the website title (as defined
in th... -
- This update also reveals some instances where our type
annotations in the tests are not specific enough.
This will be... -
- Raise phpstan to include latest phpstan bugfixes.
See: https://github.com/phpstan/phpstan/releases/tag/1.6.9
Used co... -
- Raise phpstan to include latest phpstan bugfixes.
See: https://github.com/phpstan/phpstan/releases/tag/1.6.9
Used co...
2022-05-22
-
- Resolves: #97674
Releases: main
Change-Id: Ib4340b50576f0b506fec5c5b16ec8ec17fe73373
Reviewed-on: https://review.typo... - 12:01 Revision 84d30b90: [DOCS] correct text-role
- The text role `:ts:` may only be used for typescript, not typoscript. It
does therefore not render.
Releases: main
R... -
- Resolves: #97672
Releases: main
Change-Id: Id23321312212e6ce331d898d588149dbf1ff1703
Reviewed-on: https://review.typo...
2022-05-20
-
- When using stdWrap for setting the actual parameter value, all
additional information (like target, class and title) ... -
- This change reduces specialities within DataHandler:
* DataHandler->username is not used, and can be removed.
* Init... -
- These values are already nullable according to the code,
so document that.
Resolves: #97656
Releases: main, 11.5
Cha... - 11:30 Revision 01420307: [BUGFIX] Use correct time format in from and to filter
- H needs to be used because the datepicker is in 24h mode and
i stands for minutes with leading zero
Resolves: #97650... -
- These values are already nullable according to the code,
so document that.
Resolves: #97656
Releases: main, 11.5
Cha... - 11:17 Revision bba0e26c: [BUGFIX] Use correct time format in from and to filter
- H needs to be used because the datepicker is in 24h mode and
i stands for minutes with leading zero
Resolves: #97650... -
- It is possible to register a dedicated icon for a plugin in
ExtensionUtility::registerPlugin(). This icon is used in ... -
- ftok() doesn't return false, but -1 on error.
The $resource property may be null to indicate no lock
is active, so a... -
08:30 Revision 0fa97aac: [BUGFIX] Show missing total amount and time of sql queries
- This displays the total time spend for sql queries and the
total amount of sql queries in the Admin Panel.
Resolves:... -
- This displays the total time spend for sql queries and the
total amount of sql queries in the Admin Panel.
Resolves:... -
- It is possible to register a dedicated icon for a plugin in
ExtensionUtility::registerPlugin(). This icon is used in ... -
- ftok() doesn't return false, but -1 on error.
The $resource property may be null to indicate no lock
is active, so a...
2022-05-19
-
15:30 Revision 077c8c50: [DOCS] Remove outdated note in fluid_styled_content
- The note about jumping to a previous version of the
page is obsolete, because you can switch no further
than version ... -
- The note about jumping to a previous version of the
page is obsolete, because you can switch no further
than version ... -
- The note about jumping to a previous version of the
page is obsolete, because you can switch no further
than version ... -
10:37 Revision bb5809c5: [DOCS] Use correct middleware name 'typo3/cms-frontend/authentication'
- Use the correct middleware name 'typo3/cms-frontend/authentication' in
the changelog instead of referring to a non-ex... -
- Use the correct middleware name 'typo3/cms-frontend/authentication' in
the changelog instead of referring to a non-ex... -
- Use the correct middleware name 'typo3/cms-frontend/authentication' in
the changelog instead of referring to a non-ex...
2022-05-18
- 09:37 Revision f18c257d: [BUGFIX] styleguide: Allow custom forms
- https://github.com/TYPO3-CMS/styleguide/pull/325
Even if styleguide is installed it must be possible to generate cus...
2022-05-17
-
- This helps static analysis.
Resolves: #97631
Releases: main, 11.5
Change-Id: If06aea0d310fa56333d93c99f1400db8d74706... -
- This helps static analysis.
Resolves: #97631
Releases: main, 11.5
Change-Id: If06aea0d310fa56333d93c99f1400db8d74706...
2022-05-16
-
- Mostly these are due to SimpleXML not casting cleanly to strings,
so making the casts explicit resolves them.
Resolv... -
- Mostly these are due to SimpleXML not casting cleanly to strings,
so making the casts explicit resolves them.
Resolv... -
- This is only possible with PHPUnit, not with Prophecy, and it is bad
practice as there is no way to do type analysis ... -
- This is only possible with PHPUnit, not with Prophecy, and it is bad
practice as there is no way to do type analysis ...
2022-05-13
-
- There are several PHPStan Baseline exceptions for misuse of
the ?? operator. Many of them are no longer necessary tha... -
- There are several PHPStan Baseline exceptions for misuse of
the ?? operator. Many of them are no longer necessary tha... -
- Resolves: #97425
Releases: main, 11.5
Change-Id: Ie3679f8a0f51ee2000ce45dfab1ea82bdc67c0ff
Reviewed-on: https://revie... -
- Resolves: #97425
Releases: main, 11.5
Change-Id: Ie3679f8a0f51ee2000ce45dfab1ea82bdc67c0ff
Reviewed-on: https://revie... -
- Resolves: #97619
Releases: main, 11.5
Change-Id: Ib1812d04264cab9bf867891f8cc06d7dafeace99
Reviewed-on: https://revie... -
- Resolves: #97619
Releases: main, 11.5
Change-Id: Ib1812d04264cab9bf867891f8cc06d7dafeace99
Reviewed-on: https://revie... - 01:28 Revision 5090ac55: [BUGFIX] Exclude doktypes in SiteConfiguration
- Currently, only SysFolders are excluded in
the SiteConfiguration overview which allows
to add a SiteConfiguration to ... - 01:10 Revision 9e937b46: [BUGFIX] Exclude doktypes in SiteConfiguration
- Currently, only SysFolders are excluded in
the SiteConfiguration overview which allows
to add a SiteConfiguration to ...
Also available in: Atom