TYPO3 Core

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53275

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53275

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53275

What should be the expected behavior if i have the following link within the RTE:

<a class="btn special" title="Testtitle" href="t3://record?identifier=tx_news&uid=1">convallis</a>

I think this behavior is not covered by the given patch in gerrit, isn't it?

This is not a bug. Just a configuration issue.

Working example configuration:

config.recordLinks {
    pressRelease {
        forceLink = 0
        typolink {
            parameter = {$themes.pages.news.pressReleaseSingle}
            additionalParams = &tx_news_pi1[news]={field:uid}
            additionalParams.insertData = 1
            useCacheHash = 1

            ATagParams.data = parameters:allParams
            target.data = parameters:target
            title.data = parameters:title

            extTarget = _blank
            extTarget.override.data = parameters:target
        }
    }
}

The above is true for a link inside the RTE, but when coming from a TS configuration or a Fluid view helper, the ContentObjectRenderer class does not load the link parameters into the parameters member variable.

1. the additional parameters of the link itself
2. the ViewHelper or the TS configuration driving the rendering with its own parameters
3. the "base" linkhandler TS configuration

The difficulty lies in defining how each "level" overrides the other. The "parameter" and "additionalParams" properties should be carefully preserved because they are calculated in \TYPO3\CMS\Frontend\Typolink\DatabaseRecordLinkBuilder::build().

I do not have a good answer for now...

The Fluid Typolinkviewhelper adds a parameter string like

parameter = t3://record?identifier=tx_news&uid=1 _blank "btn special" Testtitle google=bad

The sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php creates a parameter string like the following, if 15 is the page uid of the detail page

parameter = 15

So all other settings will be ignored. Usefull would be a merge of the settings in the DatabaseRecordLinkBuilder

$typoScriptConfiguration = $configuration[$configurationKey]['typolink.'];

        /** @var TypoLinkCodecService $typoLinkCodecService */
        $typoLinkCodecService = GeneralUtility::makeInstance(TypoLinkCodecService::class);
        $typoScriptConfiguration['parameter'] = $typoLinkCodecService->encode(
            array_merge(
                array_filter($typoLinkCodecService->decode($conf['parameter']), 'strlen'),
                array_filter($typoLinkCodecService->decode($typoScriptConfiguration['parameter']), 'strlen')
            )
        );

A fix in the core would be great.

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57370

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57883

Is this fixed for TYPO3 9.5?
I can find the same wrong behaviour described.