Project

General

Profile

Activity

From 2023-03-31 to 2023-04-29

2023-04-29

19:42 Revision f98773ec: [DOCS] Update SECURITY.md
Further improvements, most of them as proposed by Michael Schams
Releases: main
Resolves: #100755
Related: #100747
R...
Stephan Großberndt

2023-04-28

18:21 Revision dd0b6e72: [TASK] Show configured transport per webhook
The "Webhooks" view in the "Configuration" module now shows the
Symfony Messenger transport configured per webhook.
...
Andreas Fernandez
17:08 Revision a2d6d8b4: [BUGFIX] Allow locallang labels for tt_content_defValues
Resolves: #100776
Releases: main
Change-Id: I1c602d05fb36d147a484755f4107f68c554c7ba1
Reviewed-on: https://review.typ...
Oliver Bartsch
16:31 Revision ebec8ae0: [BUGFIX] Use `importShim()` to load init modules
With #100688, the module `es-module-shims` was updated. Unfortunately,
with 1.5.3 an incompatibility with Firefox < 1...
Andreas Fernandez
10:31 Revision 07757e67: [TASK] Provide composer.json to fixture extensions in ext:extbase
In preparation of composer based test setups, all fixture extensions
require fully functional `composer.json` files.
...
Anja Leichsenring

2023-04-27

15:55 Revision d66a3b9d: [DOCS] Adjust ViewHelper name
Resolves: #100770
Releases: main, 11.5
Change-Id: I549371e78de399195d6810858d337528f39ce0ad
Reviewed-on: https://revi...
Oliver Bartsch
14:27 Revision 1ac5a8f5: [DOCS] Adjust ViewHelper name
Resolves: #100770
Releases: main, 11.5
Change-Id: I549371e78de399195d6810858d337528f39ce0ad
Reviewed-on: https://revi...
Oliver Bartsch
13:56 Revision ab838fb7: [BUGFIX] Harmonize page ids in Record List search
The list of ids generated by `getSearchableWebmounts()` may contain
duplicated values being passed into an `IN()` cri...
Andreas Fernandez
13:56 Revision 0fd1cfac: [BUGFIX] Harmonize page ids in Record List search
The list of ids generated by `getSearchableWebmounts()` may contain
duplicated values being passed into an `IN()` cri...
Andreas Fernandez
12:56 Revision 60becc56: [TASK] Clean up avatar class
In a list of backend users, using the avatar viewhelper, the
instantiated Avatar class would always be the same insta...
Christian Eßl
09:38 Revision 75387f45: [TASK] Provide composer.json to fixture extensions in ext:backend
In preparation of composer based test setups, all fixture extensions
require fully functional `composer.json` files.
...
Anja Leichsenring

2023-04-26

13:40 Revision 0bae8154: [BUGFIX] Fix visual glitches in tile view affecting Firefox
`text-overflow: ellipsis` only works in Firefox if the parent element
has an explicit width. Therefore, `button` and ...
Andreas Fernandez
12:17 Revision e864e328: [DOCS] Revise changelogs for v12.4
Resolves: #100753
Releases: main
Change-Id: Ia3d98fad1be54ad3056b746c436556f33d2a7818
Reviewed-on: https://review.typ...
Chris Müller
07:51 Revision 97dd6662: [BUGFIX] Correct clearable implementation in scheduler
The clearable javascript was never included or initialized.
Wrappers handled by the clearable implementation have
bee...
Benjamin Kott
07:40 Revision f9660910: [BUGFIX] Add missing CSS label classes and fix markup
Resolves: #100726
Releases: main
Change-Id: I49384e7bbf3f199504ee7a978a816df1285474ad
Reviewed-on: https://review.typ...
Frank Nägler

2023-04-25

14:21 Revision 2cf35072: [TASK] Update testing-framework and styleguide
Used command(s):
> composer u typo3/testing-framework
> composer u typo3/cms-styleguide
Resolves: #100751
Releases:...
Stefan Bürk
14:11 Revision fa88b4c5: [RELEASE] styleguide: 12.0.0 Core v12 compatibility
Christian Kuhn
14:06 Revision 000aee0e: [TASK] styleguide: Use typo3/testing-framework 8.x.x
This change raises to testing-framework ^8.0.0. The now obsolete
"sbuerk/typo3-cmscomposerinstallers-testingframework...
Stefan Bürk
13:57 Revision e496fddb: [BUGFIX] Avoid exceptions while loading presets
This patch avoids undefined key warning and properly casts the haystack
argument of the `InArrayViewHelper` to an arr...
Simon Gilli
12:59 Revision 3ae6c8a9: [BUGFIX] Use correct configuration example for message routing
The docs for configuration message routing mention the non-existent
array `$GLOBALS['TYPO3_CONF_VARS']['SYS']['queue'...
Andreas Fernandez
11:57 Revision 2f60ee3b: [DOCS] Update SECURITY.md
Releases: main
Resolves: #100747
Change-Id: Ifd39f0813996674620fe1b89aef29ca87351e5b9
Reviewed-on: https://review.typ...
Stephan Großberndt
10:40 Revision 18aaf13a: [BUGFIX] Prevent undefined array key in UserIntInformation
Resolves: #100742
Releases: main, 11.5
Change-Id: Ibff1f2da48192a23d3fe6e5404c95f3b7e6c8ae8
Reviewed-on: https://revi...
Daniel Siepmann
10:13 Revision d88b6df8: [TASK] styleguide: Use friendsofphp/php-cs-fixer directly
Use php-cs-fixer with own ruleset directly.
Use ruleset from current TYPO3 core.
Update codebase.
Activate cgl check ...
Christian Kuhn
10:05 Revision 3a83be5d: [BUGFIX] Prevent undefined array key in UserIntInformation
Resolves: #100742
Releases: main, 11.5
Change-Id: Ibff1f2da48192a23d3fe6e5404c95f3b7e6c8ae8
Reviewed-on: https://revi...
Daniel Siepmann
09:50 Revision b2cd488c: [TASK] styleguide: sbuerk/typo3-cmscomposerinstallers-testingframework-bridge:^0.1.3
Christian Kuhn
09:33 Revision 88ca6531: [TASK] styleguide: Update README.md
Christian Kuhn
09:29 Revision 99d7c86c: [TASK] styleguide: Req --dev codeception/module-webdriver:^4.0 -w
Brings phpunit 10 as well
> composer req --dev codeception/module-webdriver:^4.0 -w
Christian Kuhn
09:05 Revision 5ccd2b2b: [TASK] styleguide: Require --dev phpstan/phpstan:^1.10.14
Christian Kuhn
08:17 Revision d92dfe0f: [DOCS] Add 12.4.x directory to changelogs
Resolves: #100741
Releases: main
Change-Id: I0f65275282c85ce005eac85a081da7139606ceda
Reviewed-on: https://review.typ...
Andreas Fernandez
06:29 Revision 4a624227: [TASK] Update SECURITY.md for TYPO3 v12.4 LTS
* TYPO3 v12.4.x LTS is supported
* TYPO3 v11.5.x LTS is supported
* previous sprint releases of TYPO3 v12 are not cov...
Oliver Hader
06:09 Revision d8829aec: [TASK] Set TYPO3 version to 12.4.1-dev
Change-Id: If17fbd8d45edd9c7685217342ad330de84ae471d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/788...
Benni Mack
05:58 Revision 06b83a9c: [RELEASE] Release of TYPO3 12.4.0
Change-Id: I158409abb3555504ae6fa1a619794a44ab307c25
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/788...
Benni Mack

2023-04-24

19:33 Revision 354693f9: [BUGFIX] Ensure AbstractExceptionHandler::IGNORED_EXCEPTION_CODES is protected
With #100720 the AbstractExceptionHandlers
const IGNORED_EXCEPTION_CODES was set from private
to public in order to a...
Benni Mack
19:32 Revision abe2053e: [BUGFIX] Transparently add Link Browser classes to ckeditor
There are currently two ways to configure link classes in ckeditor:
* `config.stylesSet`
* `buttons.link.properties....
Andreas Fernandez
19:00 Revision c92a5b99: [BUGFIX] Ensure AbstractExceptionHandler::IGNORED_EXCEPTION_CODES is protected
With #100720 the AbstractExceptionHandlers
const IGNORED_EXCEPTION_CODES was set from private
to public in order to a...
Benni Mack
18:44 Revision 60702bc3: [TASK] Optimize the spacing in scheduler list
With #100663 the overall spacings were adjusted. With this patch we
align the spacing between scheduler group panels ...
Jasmina Ließmann
18:20 Revision bf09aeaf: [BUGFIX] Avoid repeated e-mail content generation in FluidEmail
Body content generation may be triggered by calling some getter or
indirectly when the mail is sent (via `ensureValid...
Markus Klein
18:18 Revision 05fbf35d: [BUGFIX] Avoid repeated e-mail content generation in FluidEmail
Body content generation may be triggered by calling some getter or
indirectly when the mail is sent (via `ensureValid...
Markus Klein
18:15 Revision 81799416: [TASK] Update display and markup of user settings form
Previously, the form fields in user settings form were displayed in
their entirety, filling the screen.
With this pa...
Jasmina Ließmann
17:13 Revision 2e26e907: [TASK] Align scheduler add/edit form of a task with FormEngine markup
With #100042 the markup of the form fields in the add/edit form of a
task has been updated. With this patch the marku...
Jasmina Ließmann
16:32 Revision 1a7fecd1: [BUGFIX] Allow untrusted query arguments in ViewHelpers
With #98488, the typolink option "addQueryString" changed
the behaviour to only add mapped query arguments by default...
Oliver Bartsch
16:27 Revision 9d8d296e: [BUGFIX] Fix PHP 8 warning in LinkValidatorController
The variable $row['url_response']['errorParams'] should always contain
a value. Either the actual error message array...
Thomas Hohn
16:08 Revision b7193f23: [BUGFIX] Fix PHP 8 warning in LinkValidatorController
The variable $row['url_response']['errorParams'] should always contain
a value. Either the actual error message array...
Thomas Hohn
15:58 Revision 74c72268: [TASK] Make IGNORED_EXCEPTION_CODES accessible
This makes AbstractExceptionHandler::IGNORED_EXCEPTION_CODES public accessible in order to re-use it in custom error ... Christoph Lehmann
15:52 Revision 965aa5ba: [TASK] Allow f:asset.css and f:asset.script to use CSP nonce
Adds new boolean `useNonce` attribute to asset view helpers, e.g.
`<f:asset.css useNonce="1">` or `<f:asset.script us...
Oliver Hader
15:15 Revision f25c7e2a: [TASK] Correct deprecation notice in LocalizationUtility
Resolves: #100731
Related: #100721
Releases: main
Change-Id: Id8ffc819a9ec908fc8f11750821efa2a484e6d49
Reviewed-on: h...
Chris Müller
14:53 Revision 3f23c28a: [TASK] Fetch RTE yaml configuration only once
Avoid a lot of superfluous yaml reading and parsing by fetching
the richtext configuration only once per request, sav...
Christian Eßl
14:37 Revision c607d319: [TASK] Deprecate various language-related methods and properties
The following methods and properties have been
deprecated:
* Argument $alternativeLanguageKeys in LocalizationUtilit...
Benni Mack
13:22 Revision 9fdafe3f: [BUGFIX] Handle dynamic CSP nonce values during frontend rendering
The CSP nonce value was not assigned in frontend rendering process.
Besides that, the value would have been cached st...
Oliver Hader
13:22 Revision 814d7bf8: [BUGFIX] Do not log requests with unsupported HTTP method
Illegal requests should not fill log files.
The Exception is thrown in \TYPO3\CMS\Core\Http\Request::validateMethod(...
Christoph Lehmann
12:51 Revision 56623019: [TASK] Streamline several CSP aspects
This is a collection of some smaller adjustments of CSP aspects:
* move `ScopeRepository` to `ext:core` (it will be ...
Oliver Hader
12:40 Revision 797f2cf7: [BUGFIX] Recover accidentally removed label in EXT:indexed_search
The language label `indexedsearch.config.disableFrontendIndexing` was
accidentally removed in EXT:indexed_search with...
Andreas Fernandez
12:11 Revision 0eb81b57: [BUGFIX] Allow "default" next to "extensionName" in f:translate
It's now possible again to provide a "short key",
an extension name and also a default value for
the f:translate View...
Oliver Bartsch
11:34 Revision 05cff69f: [TASK] Fix exception message in PageViewHelper
PageViewHelper no longer exclusively supports extbase context
request objects. Adjust the exception message according...
Christian Eßl
10:59 Revision d56f6add: [TASK] Make IGNORED_EXCEPTION_CODES accessible
This makes AbstractExceptionHandler::IGNORED_EXCEPTION_CODES public accessible in order to re-use it in custom error ... Christoph Lehmann
10:59 Revision aef038c3: [TASK] Remove MissingPackageManifestException
The exception has been marked as internal and is not in
use anymore.
Resolves: #100724
Releases: main
Change-Id: Ica...
Christian Eßl
10:58 Revision 5c7278d7: [BUGFIX] Do not log requests with unsupported HTTP method
Illegal requests should not fill log files.
The Exception is thrown in \TYPO3\CMS\Core\Http\Request::validateMethod(...
Christoph Lehmann
10:37 Revision fc0c0bec: [DOCS] Fix AccessLifetime cases
The cases of \TYPO3\CMS\Backend\Security\SudoMode\Access\AccessLifetime
are not correctly documented, e.g. `XS` becam...
Oliver Hader
08:22 Revision 6bc58eba: [TASK] Concurrently fetch URLs in HashProxy
Avoid too much I/O blocking when compiling URLs in
`HashProxy` by doing concurrent asynchronous fetch
requests with t...
Christian Eßl
07:34 Revision 65b7196a: [BUGFIX] Change distribution download message from notice to info
Resolves: #100717
Releases: main
Change-Id: I0641cb3c82119441727853f5580c3b98db43d6ff
Reviewed-on: https://review.ty...
Benjamin Kott
06:56 Revision 199dee74: [TASK] Reorganize & streamline sudo mode handling
Issue #92836 introduced the "sudo mode" to all admin tool modules,
but with using the session storage of the install ...
Oliver Hader
06:52 Revision 7c1486bd: [BUGFIX] Break long words on line-end in notifications
Resolves: #100716
Releases: main
Change-Id: Ia71d27a017472529e63317de2cb900a8773f7192
Reviewed-on: https://review.typ...
Benjamin Kott
06:40 Revision 8d52092a: [TASK] Optimize referer evaluation in ext:felogin
The redirect evaluation is currently always processed no matter if
a `redirectMode` based on the referer is configure...
Torben Hansen
06:09 Revision d1c28051: [TASK] Move Cookie logic out of userAuth
This change moves some logic out of AbstractUserAuth
classes related to setting a cookie, and only
adds a Instruction...
Benni Mack
06:09 Revision f6c3b141: [BUGFIX] Use col-checkbox instead of col-selector
Resolves: #100705
Releases: main
Change-Id: I4f8acda15136563fe6341f5f1174895a244bcc79
Reviewed-on: https://review.typ...
Benjamin Kott
06:08 Revision 36ca8aed: [BUGFIX] Correctly invoke delete and mute actions of CSP module
The `deleteAction` and `muteAction` of the CSP module endpoint
expected to receive multiple `summaries` as identifier...
Oliver Hader

2023-04-22

11:36 Revision 628e335c: [BUGFIX] Apply previous site identifier as fallback for URL resolving
Prior to #93240 URL routes were reverse sorted using the corresponding
site identifier (which did not contain any URL...
Oliver Hader
11:13 Revision fa129f1e: [BUGFIX] Apply previous site identifier as fallback for URL resolving
Prior to #93240 URL routes were reverse sorted using the corresponding
site identifier (which did not contain any URL...
Oliver Hader
08:13 Revision d13e6f86: [TASK] Let CSP Policy tests be functional only
The test subject got more and more dependencies to other
concepts and cannot be tested as standalone unit anymore.
R...
Oliver Hader

2023-04-21

22:44 Revision fea5e0bf: [TASK] Track CSP nonce consumption
The new `ConsumableValue` class has been added, which is capable
of tracking how often a value has been used for any ...
Oliver Hader
17:04 Revision cc457e55: [TASK] Verify current iso data in nightly
We established a language and country database
with related issues provided by core in v12.
Data is fetched from a d...
Christian Kuhn
16:41 Revision 1c530c51: [BUGFIX] Restore correct context after redirect evaluation
Remove any modification done to Context by the
RedirectHandler/RedirectService in order to have a
proper rendering of...
Markus Klein
16:36 Revision f5665e62: [BUGFIX] Restore correct context after redirect evaluation
Remove any modification done to Context by the
RedirectHandler/RedirectService in order to have a
proper rendering of...
Markus Klein
14:50 Revision b83b7827: [TASK] Replace the deprecated "braces" php-cs-fixer rule
Current php-cs-fixer notifies:
Rule "braces" is deprecated. Use "single_space_around_construct",
"control_structure_...
Christian Kuhn
13:04 Revision 989d34be: [BUGFIX] Assign the title attribute directly to icons or the parent
Resolves: #100555
Releases: main
Change-Id: I9e66eb02d5e4a5a4fdd66fd751cd04f2262218d4
Reviewed-on: https://review.typ...
Benjamin Kott
12:37 Revision 4f30ffed: [BUGFIX] Render execution context in separate line
The execution context ("Manual" or "Cron") rendered in the scheduler
task table per task is now separated into a new ...
Andreas Fernandez
12:36 Revision 4eed743e: [TASK] Use less memory in BE::getPagesTSconfig()
When BackendUtility::getPagesTSconfig() is called
with many different page uids, it can be a huge
memory hog: The pid...
Christian Kuhn
11:57 Revision 9925c0be: [BUGFIX] Streamline position of headlines and callouts in "Page" module
The templates used in the "Page" module now always render the page's
headline before any callout.
Resolves: #100703
...
Andreas Fernandez
10:45 Revision 96ce5325: [BUGFIX] Prevent TypeError in TargetPageIdViewHelper
Since #100329, the "pageuid" value of a
resolved page link is casted to an integer.
Since the "renderStatic()" metho...
Oliver Bartsch
10:09 Revision 489820bf: [BUGFIX] Correct alert message fade animation
Resolves: #100699
Releases: main
Change-Id: Iace44dbe9eae094455356ea771315e1ae2317221
Reviewed-on: https://review.typ...
Benjamin Kott
09:46 Revision df97f469: [TASK] npm: update dependencies
This commit updates most "user facing" dependencies to their recent
version respecting the semver constraints.
The l...
Andreas Fernandez
07:51 Revision 3c54a7f9: [TASK] Allow doctrine/instantiator ^1.5 || ^2.0
v11 has "^1.4". For v12, we first removed it entirely,
and brought doctrine/instantiator back as "^2.0"
in #100207.
...
Christian Kuhn
06:43 Revision 50c5bdb8: [BUGFIX] Output errors to CLI in scheduler:run command
Whenever a scheduler task fails during execution
via CLI `scheduler:run`, the error message is
now always written to ...
Markus Klein
06:42 Revision 65428ad3: [BUGFIX] Output errors to CLI in scheduler:run command
Whenever a scheduler task fails during execution
via CLI `scheduler:run`, the error message is
now always written to ...
Markus Klein
05:01 Revision f49ee3f6: [BUGFIX] Fix type in BackendUserAuthentication->check
Resolves: #100183
Releases: main
Change-Id: I4aa8d6f35046cbd77ad67a6c44a6f6f38f7b4ea5
Reviewed-on: https://review.typ...
Benni Mack

2023-04-20

19:29 Revision ee579670: [BUGFIX] Re-introduce SQL query per page during menu generation
With the Bugfix #100188 an integer is compared type-safe with a string:
$page['uid'] ?? false) !== $linkDetails['pag...
Christoph Lehmann
17:21 Revision e2116489: [BUGFIX] Consider EqualityInterface in SourceCollection
The behavior of `EqualityInterface` has to be applied when
comparing instances that implement this interface to find
...
Oliver Hader
17:10 Revision 391acb55: [TASK] Raise various dependencies
Last round of dependency bumps raise min
versions. There is little reason to allow
lower verisons for those not-too-c...
Christian Kuhn
16:04 Revision 23e9dd7f: [TASK] Bump direct and indirect dev dependencies
> composer req --dev composer/composer:^2.5.5
> composer u codeception/lib-web
> composer req --dev phpunit/phpunit:^...
Christian Kuhn
15:38 Revision 5294705c: [TASK] Add type declarations for GU::fixWindowsFilePath
Also add casts to callers that are not type-safe (yet).
Also convert one call to use a first-class callable to impro...
Oliver Klee
15:38 Revision 5e588dfe: [TASK] Mark SystemEnvironmentBuilder as @internal
This class has a human-readable comment marking it internal.
Now it also has the corresponding PHPDoc annotation so I...
Oliver Klee
15:19 Revision 868f0b8a: [BUGFIX] Properly check file is missing to prevent exception
In case a file is still indexed but missing on
the driver, searching for the file in the filelist
module previously l...
Oliver Bartsch
15:18 Revision e9fe4ea4: [BUGFIX] Handle Exceptions on CLI
With this Exceptions on CLI are not caught
by \Symfony\Component\Console\Application anymore
and handled by TYPO3's S...
Christoph Lehmann
15:18 Revision 8f13fc77: [TASK] Rearrange search field of file list
The arrangement of the input field and button in the search field of
the file list now corresponds to the display in ...
Jasmina Ließmann
15:09 Revision 0e84cbef: [TASK] Bump symfony dependencies
Casual raise of all symfony dependencies in
composer.lock, relevant for legacy packaging.
> composer u symfony/conso...
Christian Kuhn
14:37 Revision cf95055c: [BUGFIX] Add missing notice color for alerts
Resolves: #100684
Releases: main
Change-Id: I209e45f3a486f4d42c8ce8b781d5d5e56ac51350
Reviewed-on: https://review.typ...
Benjamin Kott
14:26 Revision 450e8a00: [TASK] Use psr/http-message:"^1.1 || ^2.0"
We should strive for current dependency versions
with upcoming 12.4.0 LTS.
psr/http-message has recently been releas...
Christian Kuhn
14:22 Revision 84c25bdc: [TASK] npm: update dev dependencies
This patch updates most development dependencies to the most recent
semver version, leaving out `@types/*` for now. D...
Andreas Fernandez
14:13 Revision 2ccdcaa9: [BUGFIX] `ceil()` dimensions in CropperEvent
The dimensions available in `CropperEvent` are fractions in some cases,
that probably happens when an image gets upsc...
Andreas Fernandez
13:55 Revision 78c28885: [BUGFIX] `ceil()` dimensions in CropperEvent
The dimensions available in `CropperEvent` are fractions in some cases,
that probably happens when an image gets upsc...
Andreas Fernandez
13:23 Revision 29171183: [TASK] Reduce includeLLFile usages
After removal of getLL usages, no globally loaded label files
are necessary anymore and therefor removed.
The remain...
Anja Leichsenring
13:09 Revision 5dc83cce: [BUGFIX] Correct alignment multi record selection toggle
Resolves: #100681
Releases: main
Change-Id: I73d44e804866f07ee97dca0cf69fcb9d5888e85f
Reviewed-on: https://review.typ...
Benjamin Kott
12:19 Revision f7751e8b: [TASK] Update ckeditor5 to v37.1
ckeditor5 was released in version 37.1 lately, being fully written in
TypeScript. Thanks to this, several `@types/*` ...
Andreas Fernandez
12:17 Revision ba5a3855: [TASK] Apply nonce hint (window.litNonce) on demand only
Resolves: #100667
Related: #100140
Releases: main
Change-Id: I1152d404322b060947eedffaf19b449613956a51
Reviewed-on: h...
Oliver Hader
11:50 Revision 72616872: [BUGFIX] Restore display of thumbnails in tile view
Resolves: #100680
Releases: main
Change-Id: Ie50a15a6025e37f2b938d1157d8865df1af54e7f
Reviewed-on: https://review.typ...
Benjamin Kott
11:39 Revision d644dbc1: [TASK] Streamline spacings
General spacings have been streamlined that are most relevant for
CSS declarations that add `margin-bottom` to ensure...
Benjamin Kott
10:27 Revision 84dc20bb: [TASK] Deprecate PageRenderer::$inlineJavascriptWrap and $inlineCssWrap
The protected properties `$inlineJavascriptWrap` and `$inlineCssWrap`
of the class `\TYPO3\CMS\Core\Page\PageRenderer...
Oliver Hader
10:12 Revision 9d10e1ac: [TASK] Avoid getLL() usages in remaining system extensions
Using sL() instead of getLL() shows direct dependencies
on labels and their label files within the code.
This change...
Anja Leichsenring
08:38 Revision ec81f07f: [TASK] Prepare FormEngine towards DI
It is possible to prepare FormEngine
towards proper dependency injection with
a relatively small patch, including goo...
Christian Kuhn
08:27 Revision 52cfe6ac: [DOCS] Correct examples around getTSFE() in changelogs
Resolves: #100672
Related: #100563
Related: #100586
Releases: main
Change-Id: Ifda318b1e86232b040d8d84d58dcc7ea47fcd7...
Chris Müller
07:42 Revision 1e5ea2d3: [TASK] Bump friendsofphp/php-cs-fixer:^3.16.0
Let's raise some dependencies to start green
with LTS. Minor bump for this --dev dep:
> composer req --dev friendsof...
Christian Kuhn
06:02 Revision f4a6ab4b: [TASK] Remove several unused imports
This change removes several unused imports, which are not
detected by php-cs-fixer, since the NoUnusedImportsFixer
do...
Torben Hansen
05:47 Revision bed64c65: [TASK] Avoid getLL() usages in various system extensions
Using sL() instead of getLL() shows direct dependencies
on labels and their label files within the code.
This change...
Benni Mack

2023-04-19

14:30 Revision 3fbc6cce: [TASK] Deprecate ConfigurationManager->getContentObject()
The extbase ConfigurationManager logic is still
painful. It is a stateful singleton, which
we can not dissolve at the...
Christian Kuhn
11:10 Revision 0e3e665c: [TASK] Use official translations for ISO 639-1/2 languages
Previously, TYPO3 manually had lists of
labels for languages (primarily used to
select a user's language for the TYPO...
Benni Mack
08:10 Revision 8fc82075: [BUGFIX] Use ModuleProvider to check module access
Since modules can have aliases it's necessary
to always use the ModuleProvider API for checking
the module access per...
Oliver Bartsch

2023-04-18

20:39 Revision febd2ae0: [BUGFIX] Harmonize site configurations "flag" setting
In the site configuration, the value is called "flag",
whereas in TypoScript or in the SiteLanguage object,
it is cal...
Benni Mack
16:33 Revision 4a72d52f: [TASK] Optimize referer evaluation in ext:felogin
The redirect evaluation is currently always processed no matter if
a `redirectMode` based on the referer is configure...
Torben Hansen
14:20 Revision b193d256: [TASK] Provide current content object as request attribute
Extbase ConfigurationManager as stateful singleton
object is updated within extbase bootstrap for
each plugin call. T...
Helmut Hummel
14:15 Revision cc8faadf: [TASK] Respect usePasswordPolicyForFrontendUsers in TCA type=password
The feature toggle `security.usePasswordPolicyForFrontendUsers`
introduced in #97390 was added to allow TYPO3 adminis...
Torben Hansen
14:06 Revision f3a4e459: [TASK] Drop UserTS options `createFoldersInEB` and `folderTree.hideCreateFolder`
The UserTS options `createFoldersInEB` and `folderTree.hideCreateFolder`
were used in the past to control the existen...
Andreas Fernandez
13:43 Revision e2313165: [TASK] Remove option for enabling RTE per user
Because RTE was not always possible in all browsers
in TYPO3 v3.x, a flag to deactivate the RTE
(for Netsacpe users) ...
Benni Mack
13:39 Revision d62d56ba: [BUGFIX] Pass markup as fragment in `debugInPopUpWindow()`
The method `DebugUtility::debugInPopUpWindow()` renders a modal with
a debug dump, if applicable. The content will al...
Andreas Fernandez
12:58 Revision b6378d2f: [BUGFIX] Prevent type errors in ExportController
In case an export is created based on e.g.
an invalid preset, no PHP TypeError should
occur.
This is now fixed by pr...
Oliver Bartsch
12:55 Revision fc67d101: [TASK] Deprecate BE/languageDebug
As feedback from translators: Setting
BE/languageDebug=true clutters the
backend so heavily, that the feature
is of l...
Christian Kuhn
12:41 Revision 7b7f2959: [BUGFIX] Handle uploaded files in EXT:form
With the migration to native ServerRequestInterface, EXT:form isn't
able to detect uploaded files anymore. The `argum...
Andreas Fernandez
12:33 Revision e2eaa02e: [BUGFIX] Prevent type errors in ExportController
In case an export is created based on e.g.
an invalid preset, no PHP TypeError should
be occure.
This is now fixed b...
Oliver Bartsch
12:26 Revision beb6ba83: [BUGFIX] Properly compare file extensions in ResourceFileExtensionMatcher
It's now ensured that ResourceFileExtensionMatcher
properly compares the file extensions using only
lowercase chars....
Oliver Bartsch
11:56 Revision 949c9aa6: [TASK] Deprecate some methods in `DebugUtility`
This commit deprecates some methods in `DebugUtility`. `debugRows()`
and :php:`printArray()` both have a duplicated m...
Andreas Fernandez
11:21 Revision e2715c59: [BUGFIX] Handle objects as key in DebuggerUtility
Due to the TYPO3\CMS\Core\Type\Map implementation,
the key of a collection entry can also be an object.
This is now ...
Oliver Bartsch
08:53 Revision 285a4cb4: [TASK] Avoid usage of includeLLFile in ext:backend NewRecordController
All usage of globally loaded labels has been replaced,
so the usage of the function to load the labels globally
can s...
Anja Leichsenring
08:53 Revision 1b3ba2b8: [BUGFIX] Wait for document being ready before booting form editor
In some scenarios, it may happen that the DOM isn't ready while the
form editor is already booted, leading to JavaScr...
Andreas Fernandez
08:40 Revision b10285e7: [BUGFIX] Do not query database for non-existent records
Extbase does not ask the database anymore for relations, where the uid
in the database field is zero.
This prevents ...
Markus Klein
07:32 Revision a7a13856: [TASK] Avoid usage of LanguageService->includeLLFile in ext:backend elementBrowser
All usage of globally loaded labels has been replaced,
so the usage of the function to load the labels globally
can s...
Anja Leichsenring
06:46 Revision 79b7c700: [BUGFIX] Streamline "collapse" icon in form editor tree
The icon used to collapse / expand a node in the form editor tree is now
streamlined with the other trees (SVG tree, ...
Andreas Fernandez

2023-04-17

21:18 Revision 41fd0a0d: [TASK] Simplify class abstraction of EXT:felogin controllers
Both EXT:felogin controller extended the
AbstractLoginFormController class, which
however only contained one single m...
Oliver Bartsch
20:46 Revision 04e7c949: [BUGFIX] Prevent undefined array key warning in LinkService
Used command(s):
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline
Resolves: #100565
Releases: 11.5
Change-Id:...
Oliver Bartsch
20:44 Revision ea4bf16e: [TASK] Remove warnings in form documentation rendering
Additionally, remove outdated manuals from list in Settings.cfg.
Resolves: #100641
Releases: main, 11.5
Change-Id: I...
Chris Müller
20:43 Revision 82bd0d72: [TASK] Remove warnings in form documentation rendering
Additionally, remove outdated manuals from list in Settings.cfg.
Resolves: #100641
Releases: main, 11.5
Change-Id: I...
Chris Müller
20:14 Revision 296ec818: [BUGFIX] Fix display of "Overwrite existing files" checkbox in file selector
Resolves: #100606
Releases: main
Change-Id: Ia53ba43a4668f2f6e06c02fb6be0137d510fcf56
Reviewed-on: https://review.typ...
Oliver Bartsch
19:45 Revision 4d78130d: [BUGFIX] Prevent unecessary usage of inline javascript in href attributes
Replace all `<a> ` tags having `href=“javascript:;“` as target
with `<button>` tags of type `button` and appropriate ...
Frank Nägler
16:36 Revision bcdc124f: [TASK] Document deprecation of legacy form templates
Resolves: #97916
Related: #95456
Releases: main
Change-Id: I5bf875d11fc91b687b9fba36c2d8c23f5eae1756
Reviewed-on: htt...
Chris Müller
16:33 Revision 66b58b05: [TASK] Streamline card rendering
We are dropping the `.card-table` styling and adjusting `table-fit`
to also work in cards the same way they work in p...
Benjamin Kott
15:11 Revision a1cfc5f5: [TASK] Deprecate ext_icon.* as extension icons
To simplify extension configuration and
to fully follow the current conventions
is the ext_icon.* file location now
d...
Oliver Bartsch
15:08 Revision 326c5bd9: [TASK] Deprecate AbstractPlugin
In addition to #98281 in TYPO3 v12.0, "pibase"
AbstractPlugin now actively logs a deprecation
message.
Resolves: #10...
Christian Kuhn
14:52 Revision 4d97fc7d: [TASK] Use setRequest() in ContentObjectRenderer
There are two ways of handing over the current
request to ContentObjectRenderer after instantiation:
By calling setRe...
Christian Kuhn
14:40 Revision 45ab6c92: [TASK] Avoid unused labels in locallang_wizards.xlf
EXT:core/Resources/Private/Language/locallang_wizards.xlf
contains a series of labels that are not used anymore.
Let'...
Christian Kuhn
14:13 Revision a88e0027: [BUGFIX] Adjust secondary color for components that respect prefers-color-scheme
With the migration from `text-muted` to `text-body-secondary`
the descriptive text for clearing cache actions became ...
Benjamin Kott
13:57 Revision 141d185e: [BUGFIX] Extbase BackendConfigurationManager fakes sys_template
The TypoScript parser has to load TypoScript from globals
($GLOBALS['TYPO3_CONF_VARS']['FE']['defaultTypoScript_')
an...
Christian Kuhn
12:04 Revision af03b154: [DOCS] Update documentation for NewRecordViewHelper
Resolves: #99394
Releases: main
Change-Id: Ie1fabd4e86bd20dbcfb2bbce6e3431397614c119
Reviewed-on: https://review.typo...
Lina Wolf
10:16 Revision d0baa71e: [TASK] Deprecate unused class MagicImageService
The class MagicImageService is deprecated, since
it's unused since version 10, due to removal of
EXT:rtehtmlarea.
Re...
Frank Nägler
09:59 Revision 0d725ff8: [TASK] Remove AbstractWizardController
The last business method of the abstract became
unused when the table wizard has been moved
to an element with #95036...
Christian Kuhn
09:29 Revision bc615d9c: [BUGFIX] Set table name even if record could not be found
Set the variable `$linkParts['tableName']` even if the currently linked
record could not be found. The variable is re...
Albrecht Köhnlein
08:47 Revision 4ea5e528: [BUGFIX] Allow to render figure tags in RTE elements
With CKeditor table elements are in RTE fields now
for tables, however, they need to be added to parseFunc
as well.
...
Benni Mack
08:45 Revision 8babd248: [TASK] Avoid usage of includeLLFile() in ext:backend Tree View
All usage of globally loaded labels has been replaced,
so the usage of the function to load the labels globally
can s...
Anja Leichsenring
08:37 Revision c5917788: [BUGFIX] Set table name even if record could not be found
Set the variable `$linkParts['tableName']` even if the currently linked
record could not be found. The variable is re...
Albrecht Köhnlein
08:31 Revision c31e1547: [BUGFIX] Add cache property to MenuProcessor
Resolves: #98985
Releases: main, 11.5
Change-Id: Id886584f8fa57b30f54257d79a6eca4465906a86
Reviewed-on: https://revie...
Benni Mack
08:10 Revision 6945939b: [TASK] Avoid usage of LanguageService->includeLLFile in ext:adminpanel
The extension does not use any globally loaded labels, so the usage
of the function to load the labels globally can s...
Anja Leichsenring
08:02 Revision c96e7540: [BUGFIX] Add cache property to MenuProcessor
Resolves: #98985
Releases: main, 11.5
Change-Id: Id886584f8fa57b30f54257d79a6eca4465906a86
Reviewed-on: https://revie...
Benni Mack
07:47 Revision db7d3348: [TASK] Avoid includeLLFile() in ext:backend wizards
The wizards don't use any globally loaded labels,
so the usage of the function to load the labels
globally can safely...
Anja Leichsenring

2023-04-16

20:09 Revision 32308c19: [BUGFIX] Recognize correct tag name
The HTML parser failed to correctly detect single tags with closing `/`
and without white space, e.g. `<br/>`. The ol...
Albrecht Köhnlein
20:00 Revision 3af65be1: [BUGFIX] Recognize correct tag name
The HTML parser failed to correctly detect single tags with closing `/`
and without white space, e.g. `<br/>`. The ol...
Albrecht Köhnlein
19:49 Revision 6017a0ef: [BUGFIX] Set 'typoLinkParameter' array index for error handling
Set the array index `$linkDetails['typoLinkParameter']` in
`\TYPO3\CMS\Redirects\Service\RedirectService` to pass it
...
Albrecht Köhnlein
19:19 Revision 86830895: [BUGFIX] Set 'typoLinkParameter' array index for error handling
Set the array index `$linkDetails['typoLinkParameter']` in
`\TYPO3\CMS\Redirects\Service\RedirectService` to pass it
...
Albrecht Köhnlein
18:35 Revision 3ec50080: [TASK] Deprecate extbase feature toggles
Extbase has an own feature toggle system. This
is based on TypoScript configuration and the
awful ConfigurationManage...
Christian Kuhn
16:09 Revision 5aeacc78: [TASK] Remove useless ext:em ext_typoscript_setup
extensionmanager/ext_typoscript_setup.typoscript file
is obsolete since it only sets an extbase feature
toggle to the...
Christian Kuhn
15:36 Revision 808ef61a: [TASK] Use `ghcr.io` core-testing images in non-ci context
The docker container image hub is slowly becoming more
and more problematic for open source organisations, it's
time ...
Stefan Bürk
15:35 Revision 61579079: [TASK] Use `ghcr.io` core-testing images in non-ci context
The docker container image hub is slowly becoming more
and more problematic for open source organisations, it's
time ...
Stefan Bürk
15:09 Revision 1dc46765: [TASK] Respect REDIRECT_* env variables
When using TYPO3_PATH_ROOT and TYPO3_PATH_APP from
apache/modules, the prefix is usually "REDIRECT_",
so this also ne...
Benni Mack
14:47 Revision 139c5b0c: [TASK] Use `ghcr.io` core-testing images in non-ci context
The docker container image hub is slowly becoming more
and more problematic for open source organisations, it's
time ...
Stefan Bürk
14:44 Revision e49bcdb7: [TASK] styleguide: Use core-testing-* images from `ghcr.io`
This change adjusts `Build/Scripts/runTests.sh` and
`Build/testing-docker/docker-compose.yml` to add a
docker image p...
Stefan Bürk
14:18 Revision 2ddc47c6: [TASK] Use non-namepaced arguments in ext:form
Feature #97096 introduced a toggle to skip
namespaces in extbase backend modules to
beautify backend links.
The defa...
Christian Kuhn
08:06 Revision ce51f286: [TASK] Return early in ContentObjectRenderer::cObjGet()
In case an empty array is passed to ContentObjectRenderer::cObjGet(),
the process returns early, without invoking any...
Oliver Hader

2023-04-15

20:18 Revision 0b7b531e: [TASK] Update table of submodule "Pages containing page TSconfig"
The naming of the table headers has been updated, as well as label
'Page title' in the pages TCA itself.
The spacing...
Jasmina Ließmann
19:58 Revision 1425e911: [TASK] Align form fields in modules 'TypoScript' and 'Page TSconfig'
With this patch we now stricly use .form-label as class for form field
labels in both modules.
The width of the opti...
Jasmina Ließmann
19:48 Revision 2ecfca1c: [TASK] Update display of 'Create multiple pages' wizard
The markup of the form to create multiple pages was updated to match
the regular markup.
After creation, the new and...
Jasmina Ließmann
18:49 Revision ca27a7d3: [TASK] Mitigate extbase crash in non TS context
People tend to run extbase in context it is not
designed to be run in. TYPO3 v11 and before
has been forgiving in suc...
Christian Kuhn
09:41 Revision 320b7c5d: [DOCS] Add missing single quote in example code
Releases: main
Resolves: #100609
Change-Id: Idc1acf2e4cfd776d89517227c1c9e32d2bdf1830
Reviewed-on: https://review.typ...
Česlav Przywara
01:34 Revision de1cd532: [TASK] Use phpunit 10.1
Switch to phpunit:^10.1.0 as minimum version,
removing phpunit:^9 in core main.
Clean up a test case, clean up tempo...
Christian Kuhn

2023-04-14

23:50 Revision d69f4a18: [TASK] Ensure working phpunit 10.1 for unit- and functional tests
PhpUnit 10.1 changed again some things from 10.0 -> 10.1,
like removing `RiskyTestError` exception and moving the
Php...
Stefan Bürk
23:00 Revision 93accbd5: [BUGFIX] Mitigate incorrect libxml usage of "enshrined/svg-sanitize"
External "enshrined/svg-sanitize" package uses
`libxml_use_internal_errors()`, but fails to
clear errors using libxml...
Stefan Bürk
22:59 Revision ab1f47ac: [BUGFIX] Mitigate incorrect libxml usage of "enshrined/svg-sanitize"
External "enshrined/svg-sanitize" package uses
`libxml_use_internal_errors()`, but fails to
clear errors using libxml...
Stefan Bürk
22:38 Revision 5da2d61b: [TASK] styleguide: Remove depcreated docker version note from runTests.sh
`Build/Scripts/runTests.sh` containted a message to state the
needed minimum docker version. Most likely, there shoul...
Stefan Bürk
22:38 Revision 4a2006af: [TASK] styleguide: Remove ignore-platform workaround in composerUpdate
phpspec/phrophecy added php 8.2 support in the meantime,
albeit we do not longer use that package in testing.
Theref...
Stefan Bürk
19:59 Revision fff1abc9: [TASK] Update Doctrine DBAL
This update fixes some PHPStan warnings for us.
> composer req doctrine/dbal:^3.6.2
> composer req doctrine/dbal:^3....
Oliver Klee
19:49 Revision be38ba03: [BUGFIX] Adjust return value in DeprecatingRequestWrapper
With #100567, the return type of the getPageArguments()
method in RequestWrapper and DeprecatingRequestWrapper
was ch...
Oliver Bartsch
18:06 Revision 5183224a: [TASK] Simplify code in LazyObjectStorage
Simplify `initialize` using a guard clause.
Resolves: #100598
Releases: main, 11.5
Change-Id: Ic53d190a139bc4c74517f...
Oliver Klee
17:52 Revision 1a82095a: [TASK] Simplify code in LazyObjectStorage
Simplify `initialize` using a guard clause.
Resolves: #100598
Releases: main, 11.5
Change-Id: Ic53d190a139bc4c74517f...
Oliver Klee
17:49 Revision ae7a934d: [TASK] Deprecate two BackendUtility methods
The BackendUtility methods getThumbnailUrl()
and getLinkToDataHandlerAction() are deprecated as
they are just wrapper...
Benni Mack
16:35 Revision 62b11958: [TASK] Update bootstrap to 5.3.0-alpha3
- Drop default override styling for <hr> without classes
- Drop unused/obsolete scss variables
- Drop variable `$text...
Benjamin Kott
14:30 Revision b977e837: [TASK] Deprecate GeneralUtility::_GET()
This deprecates GeneralUtility::_GET() as last
member of the get/post related family, next to
GU::_POST(), GU::_GP() ...
Christian Kuhn
14:19 Revision 67e70a01: [TASK] Do not set &nbsp; as label for checkboxes in debug mode
There is no need to add a non-breaking space as a fallback if the label
is empty for checkboxes. This results in unne...
Benjamin Kott
14:16 Revision bb4b3f34: [TASK] Deprecate form engine result property additionalJavaScriptPost
Deprecates form engine result property `additionalJavaScriptPost`,
which was used by custom evaluation that provided ...
Oliver Hader
13:07 Revision abf2c8d8: [TASK] Avoid GU::_GET() in ServerRequestFactory
ServerRequestFactory is essentially the only
place with a legit access to $_GET super global.
Avoid using GeneralUtil...
Christian Kuhn
12:28 Revision 91f34f04: [TASK] Drop a.disabled styling
The special handling for a.disabled is obsolete, is was introduced
to prevent the default link handling for the new c...
Benjamin Kott
12:05 Revision f3416f01: [TASK] Drop unused and unnessesary text-* css classes
The class .text-normal is not used at all and can be dropped.
The class .text-pre-wrap was only used on .alert-messa...
Benjamin Kott
12:02 Revision 9ca34fce: [TASK] Avoid ext:install uri.action VH
The ext:install uri.action ViewHelper is - after
various previous refactorings - only used within
standalone install ...
Christian Kuhn
11:54 Revision 10467a0c: [TASK] Replace text-monospace with font-monospace
This patch cleans up the a workaround for the Bootstrap
CSS Framework 5.1 update where `.text-monospace` was
dropped ...
Benjamin Kott
11:46 Revision dc548fdb: [TASK] Streamline media queries and breakpoints
The Bootstrap CSS Framework changed the handling of media queries
with version 4.6 but the core never adapted to this...
Benjamin Kott
11:40 Revision d9132922: [TASK] Cleanup impexp templates
- Migrate checkboxes to form-check
- Rebuild indention of rows
- Add icons to buttons
- Add sections to tabs
- Add mi...
Benjamin Kott
10:38 Revision e04594ba: [BUGFIX] Add action wrapper around file list actions
The multi selection actions available in the file list are wrapped by
`.multi-record-selection-actions-wrapper` now t...
Andreas Fernandez
10:21 Revision c4c639bf: [DOCS] Null-safe Operator in TypoScript conditions
With the upgrade of symfony/expression-language 6.2 in
TYPO3 v12.1, a new user-facing feature for TypoScript
conditio...
Oliver Bartsch
10:10 Revision 0151c777: [TASK] Avoid last GU::linkThisScript() and deprecate
GeneralUtility::linkThisScript() is one of the
last usages that access $_GET() from globals.
The patch removes a las...
Christian Kuhn
08:42 Revision 09036ffe: [TASK] Prepare FormDataCompiler towards DI
FormDataCompiler pollutes __construct(), making
it impossible to be injected.
The patch changes compile() to receive...
Christian Kuhn
08:09 Revision 6a31302c: [BUGFIX] Allow digit only strings in EmailFinisher
Since it's valid to use a digit-only subject or title, those
options are now properly cast to a string, preventing
Ty...
Oliver Bartsch
08:08 Revision 0e4caa2c: [BUGFIX] Allow {__currentTimestamp} as form property
Resolves: #100580
Releases: main, 11.5
Change-Id: I10e4b21908a1b4649d7ab4b02c467af381017b2b
Reviewed-on: https://revi...
André Buchmann
08:08 Revision ba352691: [BUGFIX] Allow {__currentTimestamp} as form property
Resolves: #100580
Releases: main, 11.5
Change-Id: I10e4b21908a1b4649d7ab4b02c467af381017b2b
Reviewed-on: https://revi...
André Buchmann
07:56 Revision 490d53d0: [BUGFIX] Prevent exception using getTSFE() in backend context
In case the "getTSFE()" expression function is called
in backend context - having no TSFE available-, the
function re...
Oliver Bartsch
07:40 Revision 7f686a8f: [BUGFIX] Allow digit only strings in EmailFinisher
Since it's valid to use a digit-only subject or title, those
options are now properly cast to a string, preventing
Ty...
Oliver Bartsch
07:27 Revision 8ef3e2ea: [TASK] Avoid phpunit 10.1 in CI for now
The CI currently runs phpunit ^10 parallel
to default ^9. phpunit 10.1 has just been
released, bringing further clean...
Christian Kuhn

2023-04-13

13:00 Revision 34384607: [TASK] Improve beuser templates
Templates were streamlined to provide the same experience
across the available modules. That means, record counter
he...
Benjamin Kott
12:39 Revision 6524ba81: [TASK] Have request in FormEngine
Some details of FormEngine still directly or
indirectly access request data from globals.
To change this, controller...
Christian Kuhn
12:28 Revision ac253223: [TASK] Harden willReturnCallback calls in some extension tests
- add parameter and return type declarations
- use the same parameter names as in the mocked methods
- use first-clas...
Oliver Klee
12:20 Revision 9a1c2c52: [TASK] Remove a useless FAL related test
The method is already indirectly tested
with a class instance by other tests based
on LocalDriverFilenameFilter fixtu...
Christian Kuhn
12:16 Revision 60c1ccac: [BUGFIX] Remove vertical spacing of page layout grid
In order to streamline the spacing it is necessary that
all modules in the TYPO3 backend share the same base
stylings...
Benjamin Kott
12:14 Revision fa2d35c3: [TASK] Add close confirmation modal to scheduler
Currently, if a task was changed in the edit/add view
the close button goes back to list view without
letting the use...
Jochen Roth
12:06 Revision b2609cc6: [BUGFIX] Allow different navigation component for sub modules
To set a different navigation component for a sub module,
"inheritNavigationComponentFromMainModule" must
be disabled...
Oliver Bartsch
10:45 Revision bb439dd3: [BUGFIX] Pre-define `cropBox` in Image Manipulation
This patch pre-defines `cropBox` with an empty jQuery object to avoid
errors when starting the image cropper. A simil...
Andreas Fernandez
09:37 Revision 271b5a51: [BUGFIX] Use correct icon key in UserInformationService.php
Resolves: #100574
Related: #99739
Releases: main
Change-Id: Ide714744621f9298d7d37d52421fb690ba2387c1
Reviewed-on: ht...
Andreas Fernandez
09:11 Revision d14ac266: [BUGFIX] Fix PHP warning in FormFieldViewHelper
When using a formField with a property name
that only consists of a number (e.g. a UID),
Fluid will now allow this.
...
Benni Mack
08:06 Revision 9a6fc9a6: [BUGFIX] Fix PHP warning in FormFieldViewHelper
When using a formField with a property name
that only consists of a number (e.g. a UID),
Fluid will now allow this.
...
Benni Mack
07:56 Revision 787b3960: [TASK] Drop special styling for popover, tooltips, h1, h2 and h3
There is not need for a special styling here, the components
are fine as is. We are now preferring the defaults over ...
Benjamin Kott
06:13 Revision efd412eb: [BUGFIX] Allow multiple CSS files in CKEditor 5
With the migration to CKEditor 5, `config.contentsCss` was degraded to
allow a single file only in CKEditor itself. T...
Andreas Fernandez
05:23 Revision 036957d5: [TASK] Raise 'phpstan/phpstan' and regenerate baseline
A new patch level forces us to regenerate
baseline.
> composer req --dev phpstan/phpstan:^1.10.13
> Build/Scripts/ru...
Christian Kuhn
05:23 Revision 4eb8a2d8: [TASK] Raise 'phpstan/phpstan' and regenerate baseline
A new patch level forces us to regenerate
baseline.
> composer req --dev phpstan/phpstan:^1.10.13
> Build/Scripts/ru...
Christian Kuhn

2023-04-12

19:27 Revision e1b83591: [BUGFIX] Ensure email links do not throw an exception
When upgrading a project to TYPO3 v12,
the new email link validator now
checks for other properties than the
email ad...
Benni Mack
19:24 Revision c4d7c4d6: [BUGFIX] Fix return type in RequestWrapper
In case TypoScript conditions are evaluated in
the backend, e.g. in extbase modules, usage
of `getPageArguments()` mi...
Oliver Bartsch
18:49 Revision 7357c911: [TASK] Clean up FormDataCompiler
Protected property $removeKeysFromFinalResultArray
is unused and can be removed. Also use constructor
property promot...
Christian Kuhn
17:38 Revision 4a528fd0: [TASK] Separate move page + move content element
This change splits up moving of a page into a
"move_page" route / controller, and the
"move_element" for tt_content e...
Benni Mack
17:02 Revision ca03f88a: [BUGFIX] Allow ws: and wss: source scheme for CSP
Resolves: #100558
Releases: main
Change-Id: Icd5beb7c31e473494d8d91f76d7440a1c1724e09
Reviewed-on: https://review.typ...
Oliver Hader
15:19 Revision 4a36f6d3: [BUGFIX] Correct link in PageMovingPagePositionMap
Repositioning a content element to a different page
using the list module "Re-position content element"
view fails wi...
Christian Kuhn
14:55 Revision e207344c: [BUGFIX] Prevent TypeError in DatabaseIntegrityController
Adding necessary typecast to prevent TypeError
in DatabaseIntegrityController.
Resolves: #100562
Related: #100521
Re...
Oliver Bartsch
14:51 Revision 44531974: [BUGFIX] Broken returnUrl in db check search
The "DB check" -> "Full search" module allows to show
soft-deleted records. Such result rows have a button
to "undele...
Christian Kuhn
14:25 Revision 7c8ece47: [BUGFIX] ckeditor: Do not update source element on document change
The change in #99669 introduced an update of the source element bound to
the ckeditor instance. Unfortunately, this l...
Andreas Fernandez
13:53 Revision db04d584: [TASK] Deprecate TSFE->type
This information can now be retrieved
from the page arguments object, as
it is encouraged to not rely on the global
T...
Benni Mack
12:34 Revision 1df2ac1c: [TASK] Mark several internal methods and properties protected in UserAuthentication
To enable further refactorings and decoupling work,
several internal methods and properties in the
user authenticatio...
Benni Mack
11:24 Revision 920e6a38: [BUGFIX] Use associative keys in AbstractContentPagePositionMap
The controller called when moving (content) elements in
list module triggers an undefined array key warning.
The code...
Christian Kuhn
07:30 Revision 11e8c162: [BUGFIX] Recursive INCLUDE_TYPOSCRIPT directory includes
With yet another happy little recursive method,
recursive directory includes should work again.
Resolves: #100166
Re...
Christian Kuhn
07:27 Revision 03837e6e: [TASK] Drop help-block and optimize spacing in form engine
The spacing for formengine elements have been improved.
The legacy .help-block was replaced with .form-text in
boots...
Benjamin Kott
07:24 Revision fadf6fad: [TASK] Avoid superfluous SQL queries in HrefLangGenerator
Page records for default language and the current exist in TSFE->page,
so they don't need to be fetched again.
Resol...
Christoph Lehmann
06:22 Revision 67b2545e: [BUGFIX] Fix page reloading on click on preview button (again)
The changes introduced in #93706 broke the preview button functionality
in multidomain setups. When first previewing ...
Christian Eßl
05:43 Revision abeed7ab: [BUGFIX] Apply no-cookie for vimeo when setting is missing
Improve the privacy of users by using the no-cookie setting
by default as fallback and set the do not track parameter...
Ayke Halder
04:45 Revision 39a44bfc: [BUGFIX] Apply no-cookie for vimeo when setting is missing
Improve the privacy of users by using the no-cookie setting
by default as fallback and set the do not track parameter...
Ayke Halder
04:41 Revision c335f633: [TASK] Speed up page tree
Further speed up the page tree for large sites by initially preparing
the quoted fields instead of newly quoting them...
Christian Eßl

2023-04-11

18:11 Revision 52faa679: [BUGFIX] Fix page reloading on click on preview button (again)
The changes introduced in #93706 broke the preview button functionality
in multidomain setups. When first previewing ...
Christian Eßl
18:10 Revision bcf7a4e6: [TASK] Streamline checkbox and radio rendering
We still carry around a lot of legacy checkbox
and radio styling, this patch reduces the
the complexity of existing o...
Benjamin Kott
17:22 Revision 2cc63340: [DOCS] Correct method call in CountryProvider example
Resolves: #100556
Related: #99618
Releases: main
Change-Id: I2db084cd73292f56ffb856941229a201e8a06cca
Reviewed-on: ht...
Chris Müller
13:56 Revision cce2b609: [DOCS] Fix indentation in EXT:form documentation
Resolves: #100553
Releases: main
Change-Id: I6ad18346beccd7c0efdf1b148421c44cf095c788
Reviewed-on: https://review.typ...
Oliver Bartsch
13:32 Revision d7cde63f: [TASK] Set TYPO3 version to 11.5.27-dev
Change-Id: Ifb6baec06e9a7be3e891b6e3e7b314d52886b87c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/785...
Benni Mack
13:31 Revision f4d39873: [TASK] Set TYPO3 version to 10.4.38-dev
Change-Id: I1dad023b97567144be9e7f43f49911b7cfa076fb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/785...
Benni Mack
13:20 Revision 0a2e9d71: [RELEASE] Release of TYPO3 11.5.26
Change-Id: Iedc984e71a0cd1d82d1f7f0f28ddf8c9712b9575
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/785...
Benni Mack
13:10 Revision e4ce9ab4: [RELEASE] Release of TYPO3 10.4.37
Change-Id: Ic71fc76b6e9fdb9d9f9f7ad5aa8ec34c39305073
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/785...
Benni Mack
13:05 Revision f4d67420: [BUGFIX] Make `PolicyProviderTest` final
Resolves: #100554
Releases: main
Change-Id: Ib1bad402fea3c36cac8f45a4ec9291fb8ea9c415
Reviewed-on: https://review.typ...
Andreas Fernandez
12:24 Revision 53cdc6e9: [BUGFIX] Make grid selection available for Number form element
This fixes the YAML configuration of the "Number"
form element, making the gird selection available.
Resolves: #9893...
Oliver Bartsch
12:18 Revision 9087229f: [BUGFIX] Skip webhook message when page has no site
When a new page on rootlevel is created (via import)
and webhooks is installed, a webhook is not triggered
now, becau...
Benni Mack
11:56 Revision 9fd39e37: [TASK] Raise typo3/cms-styleguide
styleguide icons now avoid svg inline styles.
> composer u typo3/cms-styleguide
Change-Id: I5e6598ca5e125c4be079d66...
Christian Kuhn
11:56 Revision ff15d87e: [BUGFIX] Make grid selection available for Number form element
This fixes the YAML configuration of the "Number"
form element, making the gird selection available.
Resolves: #9893...
Oliver Bartsch
11:50 Revision fcca2422: [BUGFIX] Use frontend site-language specific CSP reporting endpoint
When having a site-language base URI like `/en/` the CSP reporting
endpoint was listening on `/@http-reporting`, but ...
Oliver Hader
11:42 Revision 051cf207: [BUGFIX] Backport null checks to Core QueryGenerator
This file was removed in v12 and only the version in
TYPO3\CMS\Lowlevel\Database\QueryGenerator
was updated with fixe...
JAKOTA Design Group GmbH
11:03 Revision 4bc48b70: [BUGFIX] Avoid invalid array key accesses in ext:linkvalidator
Ensure that invalid array key accesses are properly guarded.
Resolves: #99863
Releases: main, 11.5
Change-Id: I1900e...
Stefan Bürk
11:03 Revision fa7d6a73: [BUGFIX] Avoid invalid array key accesses in ext:linkvalidator
Ensure that invalid array key accesses are properly guarded.
Additionally, fix the id of a language label, which was...
Stefan Bürk
11:03 Revision ccadcb34: [BUGFIX] Improve performance of TreeController
The recursive function pagesToFlatArray make use of
the page tree repository on two places, which always
instantiates...
Alexander Grein
10:46 Revision 696c632c: [TASK] styleguide: Avoid inline styles in .svg
Resolves: https://github.com/TYPO3-CMS/styleguide/issues/377 Christian Kuhn
10:05 Revision e259036b: [BUGFIX] Sanitize BackendUtility::titleAttribForPages()
When the "Access" module is called without a selected
page, the root page icon rendering triggers a PHP 8.0
array acc...
Christian Kuhn
09:56 Revision a01aa6f3: [BUGFIX] Sanitize BackendUtility::titleAttribForPages()
When the "Access" module is called without a selected
page, the root page icon rendering triggers a PHP 8.0
array acc...
Christian Kuhn
09:52 Revision 32b24f07: [TASK] Rework display of submodule "Database Relations"
Display description to improve understanding of this submodule.
Usage of card module to split the sections into two ...
Jasmina Ließmann
09:47 Revision dd6175ae: [TASK] Drop usage of text(-*)-right and .text(-*)-left
To better support RTL languages we start dropping the
legacy bootstrap directional class names for text alignment
and...
Benjamin Kott
09:46 Revision 2c1352b3: [TASK] Superfluous SQL query in language menu
TSFE->page now holds a copy of the page in default language, so it
can be re-used.
Resolves: #100371
Releases: main
...
Christoph Lehmann
09:44 Revision cd8751d3: [TASK] Enable strict typing for Icon::class and add title
This patch enables strict types for the Icon:class.
We are also introducing a fluent setter object pattern
for and i...
Benjamin Kott
09:43 Revision 89df2d8f: [TASK] Rework command line usage section in "Manage Reference Index"
In submodule "Manage Reference Index" the instructions for command
line usage have been moved into an infobox.
Resol...
Jasmina Ließmann
09:42 Revision 54dac6c2: [TASK] Declare all test classes final
Test classes should never extend each other.
phpunit 10 is also a bit more picky about naming
of abstract test cases....
Wouter Wolters
09:29 Revision 23b58c3f: [BUGFIX] Flatten nesting of formengine-field-item in web components
Resolves: #100540
Releases: main
Change-Id: I4acdefdf455bff6e855ce130c8165a398f271a6f
Reviewed-on: https://review.typ...
Benjamin Kott
08:48 Revision b5ba9563: [BUGFIX] Correct nesting of typo3-copy-to-clipboard in UuidElement
Resolves: #100542
Releases: main
Change-Id: I0de8551dfa466ea2d4db7cee86c3003e1620f430
Reviewed-on: https://review.typ...
Benjamin Kott
08:07 Revision 2d088697: [BUGFIX] Use IntersectionObserver to determine if a tree is visible
The problem with the current implementation is that it does not
consider that a tab may already be active but not vis...
Benjamin Kott
07:36 Revision b020dac1: [BUGFIX] Use IntersectionObserver to determine if a tree is visible
The problem with the current implementation is that it does not
consider that a tab may already be active but not vis...
Benjamin Kott
07:30 Revision 88df1d11: [BUGFIX] Apply inline icon styles with nonce attribute
Since issue #100270 some icons are not rendered anymore in the
backend when having a strict `style-src` CSP directive...
Oliver Hader
07:27 Revision 83f2d8e7: [BUGFIX] Finetune table-fit border removals
To avoid double borders at the bottom for tables in
a .table-fit wrapper the default border-bottom, for
the last row ...
Benjamin Kott

2023-04-10

14:12 Revision f7ec230a: [TASK] Improve PathUtility tests
Add more test cases found when running mutation tests.
Resolves: #100532
Releases: master, 11.5
Change-Id: I3dc61e3...
Tymoteusz Motylewski
14:12 Revision 991fba3f: [TASK] Improve PathUtility tests
Add more test cases found when running mutation tests.
Resolves: #100532
Releases: master, 11.5
Change-Id: I3dc61e3...
Tymoteusz Motylewski
13:55 Revision b62f9f76: [TASK] Use dice icon instead of refresh for generating password actions
Resolves: #100541
Releases: master
Change-Id: I77acf7bfa17432103fc198acc1d9c8900934a363
Reviewed-on: https://review.t...
Benjamin Kott

2023-04-09

20:11 Revision 858f8657: [TASK] Streamline icon related web components
Resolves: #100270
Releases: main
Change-Id: Iab72c6ac0952d740f283cbe1860554b10a96abb1
Reviewed-on: https://review.typ...
Benjamin Kott
20:08 Revision 348ee331: [TASK] Update display of add/edit scheduler task form
Previously, the form fields in the add/edit form of a task were
displayed in their entirety, filling the screen. Addi...
Jasmina Ließmann
14:15 Revision f6e2ee01: [TASK] Avoid PHP 8.2 deprecation messages in CSP backend module
Replace "self" in callables by their first class callable syntax.
Resolves: #100534
Related: #99499
Releases: main
C...
Chris Müller

2023-04-08

06:47 Revision dedba26f: [TASK] Update @typo3/icons to 3.6.0
Executed commands:
npm install @typo3/icons@^3.6.0
npm run build
Resolves: #100530
Releases: main
Change-Id: Ib4007e...
Benjamin Kott
06:46 Revision 07184bbf: [BUGFIX] Ensure TypoScript creation cards share same height
Resolves: #100531
Releases: main
Change-Id: I7bed93133978fd15e6e1efb36205b6e116f75461
Reviewed-on: https://review.typ...
Benjamin Kott

2023-04-07

13:54 Revision 8f335d72: [TASK] Adjust CSS compiling to keep breaks in results
Today we are dropping the removal of breaks in compiled CSS.
This will hopefully make the need for rebasing of CSS p...
Benjamin Kott
13:40 Revision 87627c9c: [BUGFIX] Correct treelist-renderings
This is the first step to correct the CSS list-tree. Even it is
documented in the style guide extension it was manage...
Benjamin Kott
13:24 Revision a3744be4: [BUGFIX] Correct rendering of radios in formengine
Resolves: #100528
Releases: main
Change-Id: I1d15e3d74de7fbb9bec4c8e99e2e0af90f996ce7
Reviewed-on: https://review.typ...
Benjamin Kott
12:58 Revision 39f58c13: [TASK] Slightly improve belog rendering
We are introducing new table columns for avatar, time and datetime
in preparation for more adoptions. The avatar colu...
Benjamin Kott
11:48 Revision 927db384: [TASK] Update Browserslist DB
We are updating the browserlist to ensure we are
not shipping unnecessary polyfills.
npx update-browserslist-db@late...
Benjamin Kott
11:48 Revision fe8e7cda: [BUGFIX] Fix undefined array key warnings in DatabaseIntegrityController
Since #99739 the TCA types select, radio and check use associative
array keys for their items.
In ext:lowlevel Datab...
Torben Hansen
11:44 Revision 9040901c: [BUGFIX] Migrate select items in NewMultiplePagesController
Resolves: #100489
Related: #99739
Releases: main
Change-Id: I83b9632156d8f061ab3f0b710eb3639c95fb03b3
Reviewed-on: ht...
Nikita Hovratov
11:42 Revision 237bda89: [TASK] Slightly improve database reference index error rendering
Reference index errors are now rendered as a list.
Resolves: #100509
Releases: main
Change-Id: I8e46ea6e480172891a64...
Oliver Bartsch
11:40 Revision 87312215: [TASK] Improve some type annotations in DB-upgrade-related classes
This is a pre-patch to a bugfix.
Resolves: #100491
Related: #100428
Releases: main
Change-Id: I981f4f465ebacacdceaed...
Oliver Klee
11:25 Revision 111c7a31: [TASK] Avoid extending other test classes
Test classes (*.Test.php) should not extend
each other. If really needed, they can rely
on abstracts (Abstract*TestCa...
Christian Kuhn

2023-04-06

20:20 Revision 216607be: [BUGFIX] Avoid unnecessary nesting in typo3-backend-switch-user
The web component should behave like a button, there is no need
to have another button nested inside.
Resolves: #100...
Benjamin Kott
20:09 Revision 918d0b41: [TASK] Adjust attributes of ColumnSelectorButton
This replaces usage of native attributes for
custom properties to avoid unintended side
effects.
Resolves: #100474
R...
Oliver Bartsch
19:01 Revision 4c8950f7: [BUGFIX] Fix PagesWithoutDescriptionDataProvider
Add the fields "perms_user" and "perms_group"
to the custom database query, since they are
required by calcPerms() to...
Oliver Bartsch
18:47 Revision 81b808ec: [TASK] Clean up fixCopyAfterDuplFields
Rarely used fixCopyAfterDuplFields method in
DataHandler is cleaned up, since a couple of
arguments and options do no...
Oliver Bartsch
18:01 Revision 4c6f1abc: [BUGFIX] Prevent undefined array key in TypolinkSoftReferenceParser
Due to an invalid page link, e.g. "t3://page?type=123",
the "pageuid" key might not be set by PageLinkHandler.
This ...
Oliver Bartsch
18:01 Revision b1c5c8b0: [BUGFIX] Prevent undefined array key in TypolinkSoftReferenceParser
Due to an invalid page link, e.g. "t3://page?type=123",
the "pageuid" key might not be set by PageLinkHandler.
This ...
Oliver Bartsch
17:56 Revision 1086dd8b: [DOCS] Correct example for LoginAttemptFailedEvent in changelog
Resolves: #100522
Related: #100278
Releases: main
Change-Id: I81fd92941ca87935f8a8c273a32692bf820fc63c
Reviewed-on: h...
Chris Müller
13:52 Revision 1c03ee12: [BUGFIX] Correct spacing in CSP configuration status callout
Resolves: #100501
Releases: main
Change-Id: I70f8de84b5caa7ca733b34fc25d9a65f29dba389
Reviewed-on: https://review.typ...
Benjamin Kott
13:39 Revision 0e7c1f35: [BUGFIX] Fix `fileFolderPermissions` section for backend user comparison
With #99739, associated array keys for TCA items were introduced.
Unfortunately this introduced a regression in the "...
Andreas Fernandez
12:16 Revision 3dd59ee5: [TASK] Raise typo3/testing-framework
typo3/testing-framework:dev-main now got
the most important patches for phpunit 10
compatibility. This needs to be ra...
Christian Kuhn
11:49 Revision 15e19a17: [BUGFIX] Add missing table-fit wrapper around table in upgrade wizards
Resolves: #100497
Releases: main
Change-Id: I378c7bfa1964993dd4a8a9d09caf9c3b2bf70412
Reviewed-on: https://review.typ...
Benjamin Kott
11:46 Revision 1c34a1e2: [TASK] Migrate `typo3-extensionmanager-distribution-image` to Lit
To get rid of much boilerplate code, the custom component
`typo3-extensionmanager-distribution-image` used to render ...
Andreas Fernandez
11:46 Revision d311af34: [TASK] Drop unused .typo3-app-icon
Resolves: #100498
Releases: main
Change-Id: I954beb5d1e026bc0abbb54acbf46c05fbc8f65bb
Reviewed-on: https://review.typ...
Benjamin Kott
11:38 Revision f288ef9b: [TASK] Mark all Qom classes and interfaces internal
Some of these classes have been marked @internal
already. Extending / changing this area of the
extbase framework sho...
Alexander Schnitzler
11:07 Revision f6b4c28b: [BUGFIX] Fix CSP violation in extension manager
The Extension Manager module for distributions attempts to load
resources from a 3rd party resource (extensions.typo3...
Andreas Fernandez
11:06 Revision e3296d14: [TASK] Slightly improve database relation check rendering
We are now rendering the result as a list instead of a single
text blob divided by line breaks and adding a highlight...
Benjamin Kott
10:45 Revision 579d89e4: [TASK] Run deprecated functional tests with phpunit 10
Functional deprecated tests are quite easy to fix
for phpunit 10: Just some static data providers.
We do the same as...
Christian Kuhn
10:09 Revision a56ff07c: [BUGFIX] Cast site identifier to string in MigrateSiteSettingsConfigUpdate
Using typecast, we now properly ensure, the site
identifier is always a string, even if it only consists
of digits.
...
Oliver Bartsch
09:50 Revision e25d6b46: [TASK] Run deprecated unit tests with phpunit 10
Unit deprecated tests are quite easy to fix
for phpunit 10: Just static data providers
and a single broken test case ...
Christian Kuhn
09:28 Revision 697abc5e: [TASK] Update outdated xdebug info in runTests.sh
Casual local systems should have young enough
docker and docker-compose versions meanwhile,
and PHP 8.2 runs with xde...
Christian Kuhn
08:15 Revision d869e957: [TASK] Adjust possible dbms versions in `Build/Scripts/runTests.sh`
This changed adjusts the `Build/Scripts/runTests.sh` support for the
different database types and versions. That mean...
Stefan Bürk
08:15 Revision a6a1e8bd: [TASK] Adjust possible dbms versions in `Build/Scripts/runTests.sh`
This changed adjusts the `Build/Scripts/runTests.sh` support for the
different database types and versions. That mean...
Stefan Bürk
08:14 Revision 3ae3bcac: [TASK] Adjust possible dbms versions in `Build/Scripts/runTests.sh`
This changed adjusts the `Build/Scripts/runTests.sh` support for the
different database types and versions. That mean...
Stefan Bürk
07:53 Revision 5743c855: [BUGFIX] Add external media CSP declarations to frontend scope
Previously external media CSP declarations (e.g. to embed YouTube
or Vimeo assets in an iframe) was only applied to t...
Oliver Hader
07:51 Revision fa4da12b: [BUGFIX] Add frontend preview URL to CSP frame-src directive
Add the URL of the page to be shown in web > view backend module to
the `frame-src` directive of the Content-Security...
Oliver Hader
07:44 Revision 86c06d3f: [BUGFIX] Do not use native attributes in typo3-notification-message
The title attribute is a native global attribute.
Using it as a property could have unintended side-effects.
Resolve...
Benjamin Kott
07:40 Revision adfafabd: [BUGFIX] Drop input-group-btn usages if possible
The class input-group-btn was removed in bootstrap 4.6, we are now
dropping leftover usages. There is still a leftove...
Benjamin Kott
07:07 Revision ff06c7f6: [TASK] Deprecate various functionality in legacy tree implementations
This patch deprecates all old-style tree views
that have been in use for over 15 years now without
larger refactoring...
Benni Mack

2023-04-05

21:47 Revision 63c3e5f7: [TASK] Enable functionals with phpunit 10 in parallel to 9
This is a temporary, a bit hacky solution to
run the functional tests with phpunit 10 next
to phpunit 9 for now. Goal...
Christian Kuhn
21:14 Revision 986bbc73: [TASK] Make internal Fluid classes strict
Resolves: #100373
Releases: main
Change-Id: I26b0a7a888d99a4bba6d9cc77184bff6589edab8
Reviewed-on: https://review.typ...
Oliver Klee
20:41 Revision 91e7b274: [TASK] Build response in tests using factories
Some tests created response objects the wrong way
by hand. This change now uses the known factories
to build them cor...
Stefan Bürk
19:28 Revision d92756aa: [TASK] Improve WebhookExecutionTest
This test case of ext:webhooks is a bit weird.
The patch relaxes this a bit: Extending a
ext:core abstract is avoide...
Christian Kuhn
18:48 Revision 4b8502dd: [TASK] Rename AbstractEnhancerSiteRequestTest
phpunit 10 expects classes that end with "Test"
to not be abstract.
Resolves: #100484
Related: #100249
Releases: mai...
Christian Kuhn
18:47 Revision c1765283: [TASK] Rename AbstractCommandTest
phpunit 10 expects classes that end with "Test"
to not be abstract.
Resolves: #100486
Related: #100249
Releases: mai...
Christian Kuhn
18:47 Revision d65766bd: [TASK] Rename FolderStructureTestCase
Should be AbstractFolderStructureTestCase.
Resolves: #100485
Related: #100249
Releases: main
Change-Id: I09b59fdf6a1...
Christian Kuhn
18:47 Revision 8f2f3b5c: [TASK] Rename AbstractXmlSitemapPagesTest
phpunit 10 expects classes that end with "Test"
to not be abstract.
Resolves: #100483
Related: #100249
Releases: mai...
Christian Kuhn
18:46 Revision bab9b8cd: [TASK] Avoid invalid method ValidatorResolverTest
"dummy" is not a valid method in the mocked class.
Resolves: #100482
Related: #100249
Releases: main
Change-Id: Ic0c...
Christian Kuhn
17:05 Revision c9017160: [TASK] Avoid invalid methods in ImportExportUtilityTest
Method "dummy" can not be mocked since it does
not exist. Change to "don't mock anything" by
using 'null' as argument...
Christian Kuhn
17:05 Revision 7f44d966: [TASK] Extract callbacks from TypoScriptFrontendControllerTest
TypoScriptFrontendControllerTest uses itself as
callback for USER and USER_INT functions. This
does not work anymore ...
Christian Kuhn
17:04 Revision a6497590: [TASK] Avoid withConsecutive() in FlexFormToolsTest
The tests should be refactored towards proper
database fixtures, but for now, we get rid of
withConsecutive().
Resol...
Christian Kuhn
17:04 Revision 741daac4: [TASK] Avoid withConsecutive() in FileBackendTest
Resolves: #100480
Related: #100249
Releases: main
Change-Id: I256b6f6a8eae577033207df980c1b607d4226dae
Reviewed-on: h...
Christian Kuhn
16:37 Revision aea4ac86: [TASK] Avoid invalid methods in TranslationServiceTest
TranslationServiceTest tries to mock some methods
that don't exist. Solving this reveals the test
subject contains in...
Christian Kuhn
15:23 Revision 190b946f: [TASK] Remove BackendModuleControllerTest
This test is tricky since the subject triggers
session_save_path() which is limited to one
call per php process and e...
Christian Kuhn
15:10 Revision 6daa9da7: [TASK] Deprecate TypoScript config.xhtmlDoctype
The "new" property config.doctype has been introduced in TYPO3 v6
and should be used now.
It's time to unify all of ...
Benni Mack
15:10 Revision 734f9402: [TASK] Drop pointless checks in GridDataService
This change fixes most of the remaining PHPStan warnings
in this class.
Resolves: #97409
Releases: main
Change-Id: I...
Oliver Klee
14:40 Revision 786d99c7: [TASK] Have static DP in ExpressionBuilderTest
Resolves: #100470
Related: #100249
Releases: main
Change-Id: Ia42e379ea1b29408e6bec4820a62190605660c42
Reviewed-on: h...
Christian Kuhn
14:39 Revision bcc75f01: [TASK] Have static DP in RequestHandlingTest
Avoid a useless abstract with an invalid
class name, and make the data providers
in this test case static.
Resolves:...
Christian Kuhn
14:30 Revision 0b3e9d6a: [BUGFIX] Avoid unnecessary nesting in typo3-mfa-totp-url-info-button
The web component should behave like a button, there is no need
to have another button nested inside. In addition we ...
Benjamin Kott
13:34 Revision 069b5a38: [BUGFIX] Remove invalid attributes on icon component usages
The css classes icon and icon-size-small are unnessesary since the
size property already sets and uses the correct in...
Benjamin Kott
13:32 Revision 9f49f87d: [TASK] Avoid DP with arguments
phpunit 10 mumbles when test data provider
methods have arguments. This is used in
SiteHandling functional tests vari...
Christian Kuhn
12:38 Revision 8bb9bed9: [BUGFIX] Correct drag/drop preview position in firefox
Firefox does not update the cursor position on the drag event.
To workaround this issue we are moving the preview upd...
Benjamin Kott
12:17 Revision 5fe67e8b: [TASK] Deprecate BackendUtility::getRecordToolTip()
This method is just a wrapper for a title=""
attribute and is very inflexible. Thus, it is marked
as deprecated.
Res...
Benni Mack
12:14 Revision 6bf5158d: [DOCS] Link to online manual for beuser,extensionmanager,setup
Resolves: #100457
Releases: main
Change-Id: Ifa947d33af06b92486220b20afb57354870f0393
Reviewed-on: https://review.typ...
Christian Weiske
08:36 Revision 1dc7be61: [TASK] Have more static DP in SiteHandling tests
Solves simple cases: Make some helper methods
static, call them statically, and declace
consuming data providers stat...
Christian Kuhn
08:24 Revision f8d77257: [TASK] Have static DP in BrokenLinkRepositoryTest
Clean up and simplify a bit along the way.
Resolves: #100450
Related: #100249
Releases: main
Change-Id: I0f808487226...
Christian Kuhn
07:24 Revision 81ba4155: [TASK] Update Codemirror and streamline colors
npm i --save \
@codemirror/autocomplete@^6.4.2 \
@codemirror/commands@^6.2.2 \
@codemirror/lang-css@^6.1....
Benjamin Kott
07:17 Revision d3b3c062: [TASK] Deprecate methods in PasswordChangeEvent in ext:felogin
The `PasswordChangeEvent` used in `notifyPasswordChange´ should
not be used to validate user passwords, since it is n...
Torben Hansen
05:56 Revision 7a6d1ecb: [TASK] Raise 'phpstan/phpstan' and regenerate baseline file
PHPStan recenently released a new patchlevel version,
fixing the one or other bug and changing the reported
issue mes...
Stefan Bürk
05:55 Revision e64a1d1f: [TASK] Raise 'phpstan/phpstan' and regenerate baseline file
PHPStan recenently released a new patchlevel version,
fixing the one or other bug and changing the reported
issue mes...
Stefan Bürk
02:20 Revision 54fa1607: [TASK] Have static DP in RedirectRepositoryTest
Make a helper method static to allow
a static data provider.
Resolves: #100449
Related: #100249
Releases: main
Chang...
Christian Kuhn
02:18 Revision 51389c0a: [TASK] Have static DP in ReactionsRepositoryTest
Avoid a useless helper method by having
object creation within data provider
directly.
Resolves: #100448
Related: #1...
Christian Kuhn
02:15 Revision 5ade650b: [TASK] Have static DP in DatabaseIntegrityControllerTest
Use reflection instead of a mock in this
functional test data provider to create
data sets.
Resolves: #100447
Relate...
Christian Kuhn

2023-04-04

19:43 Revision 3806ee52: [TASK] Temporarily add phpunit 10 unit tests
Unit tests with phpunit 10 are green for now.
We temporarily add them to the CI test suite
to ensure they don't break...
Christian Kuhn
18:31 Revision 6da592d2: [TASK] Add initiator to <f:sanitize.html> view helper invocation
With this update, whenever the `<f:sanitize.html>` view helper is
invoked, the initiator reference will be included i...
Oliver Hader
18:31 Revision bb160bed: [TASK] Add initiator to <f:sanitize.html> view helper invocation
With this update, whenever the `<f:sanitize.html>` view helper is
invoked, the initiator reference will be included i...
Oliver Hader
18:22 Revision f0e2c3f5: [TASK] Avoid setAccessible()
setAccessible() in reflection is a no-op
since PHP 8.1. It can be removed.
Resolves: #100444
Releases: main
Change-I...
Christian Kuhn
17:23 Revision b2aa4c26: [TASK] Avoid withConsecutive() in SlugHelperTest
Resolves: #100442
Related: #100249
Releases: main
Change-Id: I5b9c5f90d2a7688f5808513df618219b4eb14bf4
Reviewed-on: h...
Christian Kuhn
17:22 Revision 2b2951b9: [TASK] Avoid withConsecutive() in Typo3DatabaseBackendTest
Resolves: #100443
Related: #100249
Releases: main
Change-Id: Iedc841419942629dc9261f190f221b6575285254
Reviewed-on: h...
Christian Kuhn
17:22 Revision a03263b6: [TASK] Avoid withConsecutive() in ExpressionBuilderTest
Pretty straight substitution as done with
similar phpunit 10 compatibility patches.
Resolves: #100441
Related: #1002...
Christian Kuhn
16:01 Revision 962eeb24: [BUGFIX] Fix invalid array access in ImageManipulation/Ratio
This also allows automated testing with a minimal data.
Resolves: #100430
Related: #100249
Releases: main, 11.5
Chan...
Oliver Klee
16:01 Revision aad44d89: [BUGFIX] Fix invalid array access in ImageManipulation/Ratio
This also allows automated testing with a minimal data.
Resolves: #100430
Related: #100249
Releases: main, 11.5
Chan...
Oliver Klee
16:00 Revision be6d0869: [BUGFIX] Fix invalid array access in Mail\TransportFactory
Even for a broken/imcomplete configuration, we want to have the
exception that complains about the incomplete configu...
Oliver Klee
16:00 Revision eae684fe: [BUGFIX] Fix invalid array access in Mail\TransportFactory
Even for a broken/imcomplete configuration, we want to have the
exception that complains about the incomplete configu...
Oliver Klee
15:57 Revision a6d7dfb2: [TASK] Remove unused property in DeleteRecords model in ext:recycler
This change removes an unused property in `DeleteRecords` domain model
in ext:recycler
Resolves: #100440
Releases: m...
Torben Hansen
14:47 Revision 4b100f0c: [TASK] Avoid withConsecutive() in QueryBuilderTest
Resolves: #100436
Related: #100249
Releases: main
Change-Id: Id3c6d93080cffd2652013b1a4f2d5bbcf0f34346
Reviewed-on: h...
Christian Kuhn
13:39 Revision 4518a1f4: [BUGFIX] Ensure translate ViewHelper uses site language locale
When using the `<f:translate>` ViewHelper out of Extbase
context (e.g., in `FLUIDTEMPLATE` or `StandaloneView`),
TYPO...
Benni Mack
13:31 Revision 572e6df5: [TASK] Centralize reactions and webhooks management
To centralize workflows, reaction and webhook
records should only be managed in their dedicated
backend module.
Reso...
Oliver Bartsch
11:29 Revision b2307e60: [TASK] Drop superfluous codeMirror label from FormEngine elements
The classes `T3editorElement` and `JsonElement` boot a CodeMirror
instance and provides a hard-coded label to be rend...
Andreas Fernandez
10:46 Revision 167abe0b: [TASK] Improve type annotations for ImageManipulation\Ratio
Resolves: #100432
Releases: main
Change-Id: I1c037a5b177dbd1f0124e493b26e4ad6f3dc04d8
Reviewed-on: https://review.typ...
Oliver Klee
09:29 Revision de679a7e: [TASK] Avoid withConsecutive() in ServiceProviderRegistryTest
The two mocked methods are not called by the
test subject - probably due to an earlier
refactoring regarding package ...
Christian Kuhn
09:29 Revision 970f9177: [TASK] Avoid withConsecutive() in ConsoleCommandPassTest
The two mocked methods are not called by the
test subject - probably due to an earlier
refactoring regarding package ...
Christian Kuhn
09:10 Revision 573ffbfd: [BUGFIX] Fix "undefined" item title in paste/cut confirmation
The options passed to the Paste module through
PageLayoutController are all present in the first
argument, not three ...
Andreas Nedbal
09:03 Revision dde27dcc: [BUGFIX] Migrate Site TCA Configuration
Until now, the TCA for Site Configuration was never migrated by the
TcaMigrator. With the massive amount of TCA depre...
Nikita Hovratov
08:12 Revision 91b0b433: [TASK] Drop handling for non existent contentNavigationSwitcher
The handling was introduced in [1] to have a resizable navigation area.
With the introduction of a generalized Lit co...
Benjamin Kott
08:06 Revision 0dbce7fd: [TASK] Update CKEditor packages to 36.0.1
Used command:
cd Build/
npm i --save-dev \
@types/ckeditor__ckeditor5-utils@^28.0.15
npm i --save \
@ckedit...
Benjamin Kott
07:38 Revision 63896b1d: [TASK] Bind CodeMirror theme to prefers-color-scheme
With the upgrade to CodeMirror 6, the dark theme is enforced, which may
have a negative impact on UX as this stresses...
Andreas Fernandez
07:27 Revision aff27c25: [TASK] Avoid withConsecutive() in FrontendConfigurationManagerTest
Straight refactoring avoiding withConsecutive().
Resolves: #100421
Related: #100249
Releases: main
Change-Id: Iabd2d...
Christian Kuhn
07:26 Revision 9ad7aeba: [TASK] Avoid invalid methods in DependencyUtilityTest
Method getLowestAndHighestIntegerVersions() does not
exist and should not be mocked.
Resolves: #100418
Related: #100...
Christian Kuhn
07:26 Revision c412b768: [TASK] Avoid withConsecutive() in FloatConverterTest
Resolves: #100419
Related: #100249
Releases: main
Change-Id: Ic969120244be3b4ee53c873d788ce9c07d3a8f72
Reviewed-on: h...
Christian Kuhn
07:25 Revision e8a8ea9e: [TASK] Avoid invalid argument in FolderLinkHandlerTest
Resolves: #100423
Related: #100249
Releases: main
Change-Id: Iffffb0d01e96c01e40ac8c4955a4ffa09f1199d8
Reviewed-on: h...
Christian Kuhn
07:25 Revision cf96bb08: [TASK] Avoid setMethods() in ExtractorServiceTest
Use onlyMethods() instead. Also, setAccessible()
is obsolete since PHP 8.1.
Resolves: #100422
Related: #100249
Relea...
Christian Kuhn
07:24 Revision d23770f9: [TASK] Streamline InstallUtilityTest
Avoid mocking not existing methods in one
test. Remove two other tests that mock so
much that it's very hard to under...
Christian Kuhn
07:23 Revision 93d12a18: [TASK] Avoid invalid method in DataMapFactoryTest
Resolves: #100420
Related: #100249
Releases: main
Change-Id: Ib5b3fc4bbf9f8e9f13fddfabdce3cba7a2df7591
Reviewed-on: h...
Christian Kuhn
07:23 Revision 9d5c76db: [TASK] Avoid withConsecutive() in ContentObjectRendererTest
Rewriting the tests to mock less makes them
better readable and far easier to grasp.
Resolves: #100414
Related: #100...
Christian Kuhn
07:19 Revision 903212c6: [TASK] Avoid withConsecutive() in SaveToDatabaseFinisherTest
Testing for the input keys is rather useless, it's
enough to verify the sub method is called twice.
Resolves: #10041...
Christian Kuhn
07:18 Revision 90d02c7c: [TASK] Avoid invalid methods in FormDefinitionValidationServiceTest
The tests try to configure method mocks that don't
exist. The patch adapts the tests accordingly. They
should receive...
Christian Kuhn
05:41 Revision 95927dff: [BUGFIX] Fix resolving of page record titles in Clipboard
This caused page titles in copy/cut functionality to not
be resolved and instead display the site title as a fallback...
Andreas Nedbal

2023-04-03

23:05 Revision 74a4698b: [BUGFIX] Fix resolving of page record titles in Clipboard
This caused page titles in copy/cut functionality to not
be resolved and instead display the site title as a fallback...
Andreas Nedbal
15:30 Revision 515052d9: [TASK] Remove some superfluous is_object()- and null-checks
Remove some superfluous checks for is_object(), null and
similar in conditions, where subsequent conditions already
c...
Christian Eßl
14:46 Revision 29319fd2: [TASK] Avoid withConsecutive() in RequestHandlerTest
Even though the RequestHandlerTest unit tests
are an aweful mocking party, we can't simply
throw them away since the ...
Christian Kuhn
14:45 Revision 9fff0613: [TASK] Remove AbstractPluginTest
AbstractPlugin ("Pi1" FE plugins) has been
marked as "not maintained anymore" a while
ago.
The unit tests are a heav...
Christian Kuhn
14:45 Revision 00a811b5: [TASK] Avoid using GeneralUtility::makeInstance in tests
Replace `GeneralUtility::makeInstance` with `new` statement.
Resolves: #100411
Releases: main
Change-Id: I340212fb7b...
Oliver Hader
14:43 Revision 60c0f4c3: [BUGFIX] Fix copying folders in filelist
Internally, the clipboard class only knows of the identifier
"_FILE", which is used for copying both files and folder...
Christian Eßl
13:26 Revision 53e2e8e0: [TASK] Have SilentConfigurationUpgradeServiceTest functionals
Turns existing unit tests into functionals, making
them more concise, avoids mocking parties, and
makes them better m...
Christian Kuhn
13:19 Revision d4bd9def: [TASK] Avoid superfluous SQL query in ContentObjectRenderer
Don't check accessibility to current page and if its
content should be rendered twice. This is already done
in the Ty...
Christoph Lehmann
10:33 Revision fe579e23: [BUGFIX] Remove visual gap from hidden CEs on page module
Hidden content elements are still present in the document flow
but just have a height of 0 causing the uniform spacin...
Andreas Nedbal
10:02 Revision d963c5ca: [TASK] Turn ActionControllerTest into functionals
Avoids phpunit 10 deprecation and failures
and allows minor modifications of ActionController.
Resolves: #100400
Rel...
Christian Kuhn
09:46 Revision 3c2ebf11: [TASK] Avoid withConsecutive() in OpenDocumentServiceTest
Resolves: #100403
Related: #100249
Releases: main
Change-Id: Iaec3d23b6fdfb70698f3715f7724915d8e7152d1
Reviewed-on: h...
Christian Kuhn
09:42 Revision 70fdcf13: [TASK] Make EvaluateDisplayConditionsTest phpunit 10 compatible
Using the test class as fixture is problematic
since the constructor changes in phpunit 10.
Resolves: #100402
Relate...
Christian Kuhn
09:11 Revision 46957ac3: [TASK] Make GeneralUtilityTest phpunit 10 compatible
Using the test class as fixture is problematic
since the constructor changes in phpunit 10.
Refactor this and clean u...
Christian Kuhn
08:54 Revision ad4ffca6: [BUGFIX] Avoid error for orphaned ts templates
When a page containing a typoscript template has been
deleted, there won't be a valid rootline for the template.
Add ...
Christian Eßl
07:55 Revision 0f5ecfc6: [TASK] Have static DP in PlatformInformationTest
Resolves: #100397
Related: #100249
Releases: main
Change-Id: I5578b8fbd76e198d91c2aad5421e715957981f94
Reviewed-on: h...
Christian Kuhn

2023-04-02

15:20 Revision f2eaaa9d: [DOCS] Revise changelogs for v12.3
Resolves: #100333
Releases: main
Change-Id: I6b9a36758b66748d4c2e092e5390d5bcc3ead8b6
Reviewed-on: https://review.typ...
Chris Müller
13:47 Revision 66e6210e: [TASK] Have static DP in StreamTest
Clean up and simplify a bit along the way.
Resolves: #100396
Related: #100249
Releases: main
Change-Id: I821c2c8e19a...
Christian Kuhn
13:44 Revision 18428fd5: [TASK] Public DP in DateFormatterTest
Resolves: #100395
Related: #100249
Releases: main
Change-Id: Ida96df615efdeab4f735057a1ff597f7d7a280fe
Reviewed-on: h...
Christian Kuhn
13:43 Revision d6e34508: [TASK] Have static DP in VimeoHelperTest
Clean up a bit along the way.
Resolves: #100394
Related: #100249
Releases: main
Change-Id: I4a9395f5f96f129b3673dfbf...
Christian Kuhn
13:41 Revision a8c4c699: [TASK] Have static DP in VariableProcessorTest
Resolves: #100393
Related: #100249
Releases: main
Change-Id: I039a5cc5e8473c7c9a4e6f2bced053a76358eb05
Reviewed-on: h...
Christian Kuhn
13:39 Revision f07ae827: [TASK] Have static DP in RouteSorterTest
Resolves: #100391
Related: #100249
Releases: main
Change-Id: I1a211e4ef2de29dcae78e1f3bed843875afd7378
Reviewed-on: h...
Christian Kuhn
13:38 Revision 6709cdaf: [TASK] Have static DP in MathUtilityTest
Resolves: #100390
Related: #100249
Releases: main
Change-Id: Ibb5d43f161b00069b0dbf30219e993e472e62951
Reviewed-on: h...
Christian Kuhn
13:37 Revision fb0ea106: [TASK] Have static DP in CacheHashConfigurationTest
Resolves: #100386
Related: #100249
Releases: main
Change-Id: Ieacbbba12fb6da2ce4a1d150ea1022689fa10294
Reviewed-on: h...
Christian Kuhn
13:35 Revision dae4f2e4: [TASK] Turn CleanerFieldProviderTest into funcional test
Avoid a mocking party, static data providers,
move another test to proper namespace.
Resolves: #100385
Related: #100...
Christian Kuhn
13:33 Revision 3a6fade5: [TASK] Have static DP in ArrayConverterTest
Clean up a bit along the way.
Resolves: #100388
Related: #100249
Releases: main
Change-Id: I0867d9f77df2a3dcd505291a...
Christian Kuhn
13:30 Revision a96af51f: [TASK] Have static DP in PropertyMappingConfigurationTest
Split the offending data provider to avoid
creating mocks within it. Clean up along
the way a bit.
Resolves: #100389...
Christian Kuhn
13:27 Revision afc0034c: [TASK] Have static DP in ContentObjectRendererTest
Clean up a bit along the way and avoid
a useless trait.
Resolves: #100387
Related: #100249
Releases: main
Change-Id:...
Christian Kuhn
13:24 Revision 802504d6: [TASK] Split a non-static data provider
Splitting the data provider that uses $this
to create mocks into single tests is the
easiest solution, even though it...
Christian Kuhn
08:40 Revision 952c6482: [BUGFIX] Prevent undefined array key in BackendUtility
Resolves: #100379
Releases: main, 11.5
Change-Id: If772e0ba8d2d10a9aeb86af519c1c4f05c0ef3b4
Reviewed-on: https://revi...
Andreas Nedbal
08:40 Revision 4f418d96: [BUGFIX] Prevent undefined array key in BackendUtility
Resolves: #100379
Releases: main, 11.5
Change-Id: If772e0ba8d2d10a9aeb86af519c1c4f05c0ef3b4
Reviewed-on: https://revi...
Andreas Nedbal
 

Also available in: Atom