Activity
From 2021-10-02 to 2021-10-31
2021-10-29
-
13:17 Revision 96e0e384: [BUGFIX] Ensure regexp capture group works with relative target
- RedirectService has been using LinkHandler to retrieve
the targeturl, thus supporting all TYPO3 has to offer,
like t3... -
- RedirectService has been using LinkHandler to retrieve
the targeturl, thus supporting all TYPO3 has to offer,
like t3...
2021-10-28
-
10:26 Revision 80ddf137: [TASK] Add missing whitespace after assign operator
- Resolves: #95809
Releases: master
Change-Id: I7e5e9edc404ed8131461d112abee4c1cedb2ab1b
Reviewed-on: https://review.ty...
2021-10-27
-
19:00 Revision a11869c0: [BUGFIX] Fix warning in BackendUserAuthentication
- Check if filemounts are available before accessing those.
Resolves: #95780
Releases: master
Change-Id: I0f475a7add63... -
19:00 Revision 0770646d: [DOCS] Fix typo in deprecation note
- Resolves: #95803
Releases: master
Change-Id: I3c69e40bac77c46a5c2bd0d5bf68a20f36a037a0
Reviewed-on: https://review.ty... -
18:59 Revision 12ae143f: [BUGFIX] Prepare doctrine facades towards PHP 8.1
- \PDO::quote() is picky about the type argument
in PHP 8.1. doctrine/dbal partially works around
that and will improve... -
- Protected method linkWrap() should only be called
with string arguments - they are for instance fed
to explode(). Ins...
2021-10-26
-
21:44 Revision f6544df9: [BUGFIX] Fix warning when query result is written to csv file
- The function fputcsv gets an enclosure as third parameter. Providing an
empty string as enclosure leads to following ... -
21:36 Revision e00c3173: [BUGFIX] Catch and log Exception in image size detection
- When the mime type of a file can not be correctly determined
by ImageMagick when detecting image sizes, fail silently... -
21:32 Revision 46554c1e: [BUGFIX] Avoid warning in ContentObjectRenderer
- getData() may emit E_WARNING accessing $tsfe->page and
$config. Sanitize that by null coalescing to empty
string.
Re... -
21:31 Revision 7e8ea60b: [BUGFIX] Fix PHP warnings in ext:lowlevel DB Check
- This prevents exceptions for missing array keys when using
the query generator for the DB Check backend module.
Reso... -
- PHP 8.1 in non strict_types context emits E_DEPRECATED
with various functions that expect strings but are
called givi... -
- ActionControllerTest mocks a view to test things. The subject
calls renderSection() on that mock. renderSection() mus... - 21:29 Revision 1a30b82b: [TASK] Add " around ignore in .stylelintrc
- .stylelintrc is a json-like config and needs
to quote keys.
Releases: master
Resolves: #95785
Change-Id: I626e956af5... -
- The function fputcsv gets an enclosure as third parameter. Providing an
empty string as enclosure leads to following ... -
- Table sys_file_processedfile field configuration is a
blob. It usually contains a serialized array with
processing in... -
- That's a seldom gem.
Method convNumEntityToByteValue() in DataHandler
is *seriously* strange. It exists since very e... -
- PageRender sanitizes array values in two methods, using
array walk with trim(). These values can be other
types then ... -
- Various functions expect string arguments and emit
E_DEPRECATED with PHP 8.1 in non strict_types=1
calls. The patch a... -
11:51 Revision 4a87bd2e: [BUGFIX] Properly return path relative to public dir in FilePathSanitizer
- The assumption for FilePathSanitizer::sanitize is to return file names
relative to the public directory of TYPO3.
Th... -
- Resolves: #95778
Releases: master
Change-Id: I764dc299cb192e4ebbcb00b21553f474355c55cb
Reviewed-on: https://review.ty... -
- Calling LanguageService->sL() should *always* return
a string, even if it's empty. The patch enforces this.
This rev...
2021-10-25
-
- Calling trim() with something else than a string
emits a E_DEPRECATED error with PHP 8.1.
Some ContentObjectRenderer-... -
- Calling str_replace() with second argument non-string is
deprecated as of PHP 8.1. Sanitize stdWrap_brTag() in
Conten... -
- PHP 8.1 emits E_DEPRECATED if second argument to
str_replace() is null. Adapt a null coalescence
and add a cast to st... -
- The filter_var() filter FILTER_SANITIZE_STRING is
deprecated as of PHP 8.1.
Extbase TextValidator uses it. Goal of t... -
- We unfortunately still didn't manage to drop remaining
usages of GeneralUtility::getIndpEnv() and deprecate
the metho... -
- FluidTemplateContentObject calls:
$headerAssets = $this->view->renderSection(...);
if (!empty(trim($headerAssets))) {... -
- StringUtility::multibyteStringPad() does a happy division
feeding str_repeat() to evenly pad on left and right side.
... -
- GeneralUtility::_POST($this->formfield_permanent) returns
null if that field is not set in $_POST. Feeding null
to st... -
14:54 Revision c22da2db: [BUGFIX] Avoid error when loading title of TCA table in New Record Controller
- This change uses the PackageManager API to fetch the
extension key title, and also solves a small issue when
the TCA ... -
- With #94996 the behavior for composer based installations changed:
- All extensions are always active
- PackageState... -
- phpunit released new versions for 8.5.x and 9.5.x, which
no longer automatically throw exception for user deprecation... -
12:30 Revision 2db46283: [TASK] Improve error messages for linkvalidator
- - Error code 500 used to be displayed as the generic "Network error
/ invalid domain" which was misleading
- Libcur...
2021-10-24
-
- Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in FinisherVariabl... -
- Set int return type for @internal class FileCollector
to satisfy PHP 8.1 strict return on SPL classes.
Resolves: #95... -
- Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in ext:form FormRu... -
- Since PHP 8.1 The Countable interface has tentative
return types. This means mismatching return types
trigger depreca... -
- Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in ext:frontend Li... -
- Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in AbstractComposi... -
- Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in ext:extbase Arr... -
15:58 Revision 6c7eabdd: [BUGFIX] Use correct return type annotations in validation results
- Three methods in Extbase's Result are now
annotated with the correct return type to
make PHPStan happy when they are ... -
- Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in ext:extbase Que... -
- Three methods in Extbase's Result are now
annotated with the correct return type to
make PHPStan happy when they are ... -
- This change now uses allowed_classes=false on all
calls of unserialize() for sys_log.log_data which
we did not have b...
2021-10-23
-
- Let getLL() return string in tests to avoid a
"sprintf(): Passing null to parameter #1" from
Typo3Status test. Saniti... -
- PHP 8.1 added concrete return types to internal
interfaces, classes and methods which triggers
deprecation messages, ... -
- ext:extbase Controller/Arguments extends ArrayObject
which implements several interfaces. Since PHP 8.1
added concret... -
- To make units test notice free in #85092 a wrong
fallback for array access has been used.
Fallback to null and passi... -
- finediff is used in various core places to render
a HTML "diff" view of two strings. The library didn't
see changes s... -
- To make units test notice free in #85092 a wrong
fallback for array access has been used.
Fallback to null and passi... -
- PageArguments and SiteRouteResult implementing the
\ArrayAccess interface indirectly through implementing
RouteResult... -
- MetaDataAspect implements multiple interfaces and has return type hints
that match the interfaces. Except for the off... -
- WebProcessorTests uses GeneralUtillity::getIndpEnv()
directly or indirectly, thus triggering deprecation
message on P... -
- SchemaColumnDefinitionListener instantiates a new Column class and
passes the column name retrieved from an array. If... -
- Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for for... -
- Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for for... -
- Classes TreeeNodeCollection and SortedTreeNodeCollection
extends ArrayObject and override some methods.
PHP 8.1 adde... - 18:26 Revision d41488cd: [BUGFIX] Avoid passing null to str_contains in TypoScript Parser
- Releases: master
Resolves: #95646
Change-Id: I86d4f73ed49d46a20d20af4f5d10075c86b633dc
Reviewed-on: https://review.ty... -
- Since PHP 8.1, most internal classes are updated
with tentative return types. This will be enforced
with 9.0.
It mea... -
18:16 Revision 6c074475: [BUGFIX] Better redirects from sys_domain in redirects upgrade wizard
- Feeding a sys_domain url to parse_url('example.com/bar')
gives ['path' => 'example.com/bar'], but we need something
l... -
- Classes TreeNode and TreeNodeCollection implement
deprecated \Serializable either directly, or indirectly
via \ArrayO... - 14:55 Revision ade5f9a9: [BUGFIX] Update EXT:blog_example TCA and ext_tables.php
- * Adapted the TCA to work with v11.5.
* Cleaned up ext_tables.php
Resolves: #95724
Releases: master
Change-Id: Icd2c...
2021-10-22
-
- The select list in the module "Info > Page TSconfig" contained
"Module Web>Modules" in the select list. This refers t... - 06:39 Revision 7bfe6f76: [BUGFIX] Make file paths absolute in GIFBUILDER
- In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inc...
2021-10-21
-
15:44 Revision ad7227df: [BUGFIX] Properly encode JSON when forwarding to RequireJS
- When forwarding configuration as JSON encoded data when loading
RequireJS modules in form engine, escape sequences ne... - 15:12 Revision 48e4e495: [BUGFIX] Make file paths absolute in GIFBUILDER
- In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inc... -
- The ext:redirects integrity check was implemented
without considering site language host and prefix for
the integrity... -
12:27 Revision 30984658: [TASK] Add extension title to meta data and use it
- Instead of reading the composer.json / ext_emconf.php
of extensions at runtime just to retrieve the extension title,
... -
- Reports generated by custom data providers might contain
specific HTML markup (including JavaScript, SVG and styles).... -
- $GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['dependencies']
keeps a list of language fallbacks for ... -
- The ext:redirects integrity check was implemented
without considering site language host and prefix for
the integrity... -
- $GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['dependencies']
keeps a list of language fallbacks for ... -
- To avoid confusion for inexperienced TYPO3 Composer users
and for the time being, Composer packages that are not
of t...
2021-10-20
-
- Recently adding quote syntax to typoscript
definitions has been added through #94715,
which fails in nightly on mssql... -
- This reverts commit c7c47956c054ef68e2847b06f15cf69b4025bc2c.
The patch did not make sense: A class that has methods... -
- Instead of reading the composer.json of packages on runtime,
use the existing meta data API to store and retrieve thi...
2021-10-19
-
- extbase ObjectStorage always had a serialize() and
unserialize(), even though they always just threw
exceptions. This... -
- Extbase DebuggerUtility uses reflection to determine
information that should be rendered as debug output
in 'renderCo... -
- \Serializable interface has been deprecated with
PHP 7.4 and the introduction of __serialize() and
__unserialize().
... -
- Changing the exception message can help developers to find the issue
faster. The previous message "The page 123 had n... -
- Having more than one class per file is discouraged
and leads to issues with class-alias-loader
if non-namespaced clas... -
- Disables the possibility to export extension sources as archive
via extension manager when using Composer-based setup... -
- phpunit has a default-enabled feature to write test
result to a cache file. phpunit however has no option
to only run... - 16:24 Revision 0221f472: [BUGFIX] Use correct selector for caret animation in EXT:form
- Currently the expanded tree does not reflect the state
(collapsed/expanded).
This has been fixed by using the correc... -
- Good practice.
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/71890 -
15:17 Revision f2a3f4e0: [BUGFIX] Consider table name on retrieving extension key
- The NewRecordController previously relied on a record
title being a locallang reference. This was used to
determine t... -
- The current implementation makes it possible to have different wizard
identifiers defined in the class and in the con... - 14:31 Revision 9f902c21: [BUGFIX] Ensure cyrilic work as regexp redirects capture group
- Requests with special characters like for ex.
cyrilic characters in it would be rawurlencoded
by the used Uri() compo... -
14:30 Revision de911ccc: [BUGFIX] Ensure slug pieces are strings
- Pieces assembled into slugs must be strings.
The pieces may stem from any database field.
Depending on the database d... -
- Pieces assembled into slugs must be strings.
The pieces may stem from any database field.
Depending on the database d... -
- 'Accept-Language' may not be sent by clients, the patch sanitizes access
to $request HTTP_ACCEPT_LANGUAGE using null ... -
- Resolves: #95687
Releases: master
Change-Id: If4fde4dcac49e043b60686141a5b412c88fc9ade
Reviewed-on: https://review.ty... - 14:00 Revision 07394796: [BUGFIX] Ensure cyrilic work as regexp redirects capture group
- Requests with special characters like for ex.
cyrilic characters in it would be rawurlencoded
by the used Uri() compo... -
13:53 Revision 0db7497b: [TASK] Spell LinkValidator consistently
- "LinkValidator" as a proper noun is always spelled in CamelCase with these exceptions:
The namespace is spelled "Lin... - 13:24 Revision 6e3ec7eb: [BUGFIX] Enforce setCopyMode in clipboard
- The clipboard component features helper methods,
which generate a URL to update the clipboard
state with new elements... - 13:21 Revision 2e1d68b9: [TASK] Add acceptance test for sitemap
- To make sure the sitemap works as expected
a acceptance test has been added for
the sitemap overview and detail view.... - 13:20 Revision 3277c45e: [TASK] Quote database identifier in TCA
- Add quoting for 'foreign_table_where'
in TCA.
Resolves: #94717
Related: #94697
Releases: master
Change-Id: I9abcf5f6... - 13:14 Revision 13ee7664: [BUGFIX] Use correct selector for caret animation in EXT:form
- Currently the expanded tree does not reflect the state
(collapsed/expanded).
This has been fixed by using the correc... - 13:07 Revision 3452bdca: [TASK] Quote field names in typoscript
- Some TS snippets miss proper DB field name quoting.
This is important to get right to be as DBMS compatible
as possib... -
- The CLI command extension:list already uses package information
for listing extensions, whereas Extension Manager sti... -
- Build/Scripts/splitFunctionalTests.php is used in
gitlab-ci via runTests.sh to split functional tests
into smaller an... -
- Since PHP 8.1, most internal classes are updated with
tentative return types. This will be enforced with 9.0.
It mea...
2021-10-18
-
- Property $expectedErrorLogEntries can be set to an
integer when tests expect that DataHandler operations
log errors o... -
- This patch adds correct return types where possible,
otherwise add the #[\ReturnTypeWillChange] attribute
to temporar... -
- Constant TYPO3_MODE has been deprecated in v11.
It should not be defined for tests anymore.
Resolves: #95685
Related...
2021-10-17
-
-
- This change reduces the amount of invalid PHP code
for PHP 8.0 and removes some unused functionality,
also uses prope... -
20:39 Revision eb06531b: [BUGFIX] Prevent PHP 8 warning exception due to missing array keys
- This prevents an exception for missing array keys when using an
extbase repository in the "render-preProcess" hook.
... -
- PHP SPL class ArrayAccess requires return values in
PHP 8.1. We can not change those since that would be
breaking in ... -
20:00 Revision 2e8de1e8: [BUGFIX] Use proper driver for FAL isWithin() check
- When checking if an identifier is within the processing folder,
the processing folders driver is used instead of curr... -
- When checking if an identifier is within the processing folder,
the processing folders driver is used instead of curr... -
- Brings a series of core v11 alignments and PHP 8.1 preparation.
Resolves: #95682
Releases: master
Change-Id: Ib291cc... -
- Redis backend tests has been using native Redis
to verify test results. 'Redis::getKeys()' method
has been deprecated... -
-
- This patch avoid call_user_func() from phpunit
bootstrap corresponding to merged change in the
testing framework.
Re... -
- Resolves: #95663
Releases: master
Change-Id: Iaf10ab1c6e3ab4ee33d755f5f3bd6b82f9fba13a
Reviewed-on: https://review.ty... -
- Prevent PHP 8 undefined array key warning when resolving
a FLUIDTEMPLATE variable value from a TypoScript reference:
... -
- Change-Id: I51c915e552f9278104a2b6a8dca779e563d167bb
Resolves: #95677
Releases: master
Reviewed-on: https://review.ty... -
- Same as for the other PHP versions, 8.1 is added now.
Resolves: #95675
Releases: master
Change-Id: I3deb1784a15a6a44... -
11:07 Revision 96cf24e9: [DOCS] Document usage of FluidEmail
- Feature #90728 added the FluidEmail option to EXT:form
EmailFinishers. The patch adds this very useful feature
to the... -
- As the value is optional, null is given to
StringUtility::multibyteStringPad() which throwed a type error.
Also an in... -
- Feature #90728 added the FluidEmail option to EXT:form
EmailFinishers. The patch adds this very useful feature
to the... -
- As the value is optional, null is given to
StringUtility::multibyteStringPad() which throwed a type error.
Also an in...
2021-10-16
-
- Mixes PHP 8.1 into the various PHP / DMBS functional
test setup combinations for pre-merge and nightly runs.
Change-... -
- PHP8.1 added return types for some internal php
functions, class methods and interfaces, like it
has been added in ph...
2021-10-15
-
- * Switches from PHP 8.0 to PHP 8.1 for pre-merge
unit tests. pre-merge now tests 'lower bound' 7.4
and 'upper bou... -
- It does not make sense to log page access failures
to the logging framework. Pages are inaccessible
for a reason, no ... -
- It does not make sense to log page access failures
to the logging framework. Pages are inaccessible
for a reason, no ... -
- With functional tests now failing on warnings and notices
and *showing* deprecations, the next step is to make sure
t... -
- Let tests fail that are considered 'risky' by phpunit.
We recently had a case during development where this
would hav... -
- This change adds the symfony/polyfill-php81
package as dependency.
Used composer commands:
> composer req symfony/p... -
- This change adds the symfony/polyfill-php81
package as dependency.
In addition, EXT:form does not explicitly
depend ... -
- This gitlab-runner flag invokes a 'git clean' command
at the end of each job run, after uploading caches, to
remove a... -
- This gitlab-runner flag invokes a 'git clean' command
at the end of each job run, after uploading caches, to
remove a... -
- A new flag adds more "timing bubbles" in job runs.
It helps finding slow commands more easily and
is useful with jobs... -
- A new flag adds more "timing bubbles" in job runs.
It helps finding slow commands more easily and
is useful with jobs... -
- This new testing-framework version brings a feature
to let functional test fail if warnings or notices
or deprecation...
2021-10-14
-
-
-
-
-
- composer req --dev typo3/testing-framework:^6.12.0
- 20:44 Revision 836f4dae: [BUGFIX] Add fallback values for backend group wizard
- When editing a backend usergroup from within a user
a undefined key warning in PHP8 is thrown.
This is now fixed by ... -
- Resolves: #95618
Releases: master
Change-Id: I56521464bfca2237f1d9c0a52a628df249a4c9a1
Reviewed-on: https://review.ty... -
- The ExportPageTreeViewTest is broken in various
scenarios. It is skipped for now to give us some
time fixing this fun... -
- The subtitle can be considered optional, and if not set a PHP8
warning is raised. Additionally, the other two options... -
- The hard coded install tool session handling forces a
hack to suppress warnings in a ext:install functional
test.
Re... -
- The StorageRepositoryTest tests createLocalStorage() which
calls testCaseSensitivity() to find out if a local filesys... -
- * Editing an orphan metadata record that is no longer
connected to a file can result in a warning. This is
found ... -
- And another set of warning fixes in ContentObjectRenderer
found by functional tests, this time in encaps_lineSplit().... -
- The functional ErrorHandlerTest uses set_error_handler()
to register test subjects. These need to be dropped
afterwar... -
- The label file locallang_pi.xlf is only used for 2 labels
for newContentElement wizard.
These can be unified, as thi... - 12:02 Revision afd50f53: [BUGFIX] Fix ExportNoPagetree issue
- Imported from GitHub Pull Request
Releases: 10.4
Resolves: #95377
Resolves: #95592
Change-Id: I7525d785e2b98e9fbdd82... -
- Some MFA controller tests trigger backendUser->logOff() which
destroys the backend user session. This backend user is... -
- Controller tests for ext:backend setup server requests
to simulate frontend calls, thus omitting the default
frontend... -
- A page link may not contain the query parameter uid.
Make sure that the event listener is robust and handles
unfilled... -
- Due to a regression introduced in PHP8 bugfixes
(see https://review.typo3.org/c/Packages/TYPO3.CMS/+/69819)
this chan... -
- A page link may not contain the query parameter uid.
Make sure that the event listener is robust and handles
unfilled... -
06:16 Revision aaf23f87: [BUGFIX] Fix dashboard drag and drop handler
- Migrate the muuri.js option `dragStartPredicate.handle`
to `dragHandle`, preventing the draggable area to be on
the w... -
- Routing for requests with chinese letters failed. As the used
symfony components internally uses rawlurldecode() on s...
2021-10-13
-
- This change addresses a regression of
https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829
where access-restricted p... -
- Routing for requests with chinese letters failed. As the used
symfony components internally uses rawlurldecode() on s... -
- In case new user accounts are not properly set up
and the user tries to login, some toolbar related
components led to... -
- ResourceStorage->getUniqueName() is used to return a
unique and sanitized file or folder name. It uses
pathinfo() on ... -
- CategoryCollectionTest needs to set up 'field_name' for
a collection record to satisfy CategoryCollection::create()
n... -
- LanguageService->sL('LLL:') leads to a warning. Even
though this is of course a broken call, the code should
sanitize... -
- Some PageRepositoryTest tests call getMenu() with a
restricted set of select fields as second argument.
Running this... -
18:56 Revision bcd9bb4d: [TASK] Avoid deprecated code in cache:flush TCA loading
- With the deprecation of CacheManager usage during TCA/ext_tables
loading in #94979, the console command cache:flush n... -
- LanguageService must be initialized after backend
user has been set up.
Resolves: #95633
Releases: master
Change-Id:... -
- A set of fixes for partially incomplete test setup in
functional tests and a series of undefined array index
warnings... -
- AuthenticationService relies on 'userid_column' being
set. The functional test setup is incomplete and
adapted with t... -
- The testing framework will soon disable error suppression
by unsetting the default errorHandler for functional tests.... -
16:35 Revision 3f5c0fe2: [DOCS] Improve description of EXT:form label translations
- In case EXT:form labels are translated, using a custom
language file and the labels contain HTML markup, the
labels h... -
14:53 Revision 57a16fca: [BUGFIX] Fix page link in redirects module pagination
- With this patch, the page link (requesting a
dedicated paginated page) in the redirects module
pagination is now work... -
- Resolves: #95613
Releases: master
Change-Id: I3360ed2177c9b34e8c4633d5555c62a8dfa4e274
Reviewed-on: https://review.ty... -
- With this patch, the page link (requesting a
dedicated paginated page) in the redirects module
pagination is now work... -
12:57 Revision f7fb61fc: [DOCS] Add more details to the manual of EXT:impexp
- Explanation of almost all configuration parameters.
Automatic creation of almost all screenshots. The file
`Document... - 12:56 Revision 2274afb7: [BUGFIX] Avoid warning when eID is given as array
- Calling https://www.example.com/?eID[]= results in $eID being an array
which triggers an 'illegal offset' warning and... -
- A new function StringUtility::multibyteStringPad() is
introduced to handle multibyte strings instead of
str_pad() whi... -
- The on-the-fly type converters need to be registered
in container to avoid deprecated ObjectManager fallbacks.
Resol... -
- Some details in (deprecated) ShortcutRepository should
be sanitized to avoid warnings.
Resolves: #95627
Releases: ma... - 12:31 Revision 7847fc48: [BUGFIX] Fix "View" button on pages with doktype > 200
- When editing a content element on a page with doktype > 200
the view button will not render this page
in the frontend... -
- Resolves: #95622
Releases: master
Change-Id: If8c7ddef423df9b8071f563f24fbd773a6c8bd8f
Reviewed-on: https://review.ty... - 12:27 Revision 40cc3603: [BUGFIX] Avoid warning when eID is given as array
- Calling https://www.example.com/?eID[]= results in $eID being an array
which triggers an 'illegal offset' warning and... -
- htmlSanatize configuration has been marked as mandatory for v12 with
corresponding deprecation message with #94786 if... - 12:13 Revision c53565e9: [BUGFIX] Fix "View" button on pages with doktype > 200
- When editing a content element on a page with doktype > 200
the view button will not render this page
in the frontend... -
- HTTP header 'Accept-Language' may not be sent by clients,
the patch sanitizes access to $request HTTP_ACCEPT_LANGUAGE... -
- In case a files' metadata were translated in a L>0 language,
whenever the file is references in a record with this L>... -
- The array in question may not exist, sanitize using
null coalescence operator.
Resolves: #95624
Releases: master
Cha... -
- When a client sends a backend reset password request
without providing new password fields, a warning is
raised.
Res... -
- TypoScriptFrontendController has not been injected to a
ContentObjectRenderer instance in a test, thus failing
with d... -
- Using null coalescing operator in type map access to avoid
undefined array key warning if check value is not defined
... -
- Use null coalescing operator to fix undefined array key warning
in ImageContentObject
Resolves: #95615
Releases: mas... -
- The forms to add a new media asset and to create a new textfile require
a value. Using the attribute `required` impro... - 10:55 Revision 21111fe7: [BUGFIX] Fix log level in html sanitizer config docs
- Updating Logger configuration as the code gives the following error
otherwise:
The given severity level "debug" for ... - 10:32 Revision 939f9db0: [BUGFIX] Fix log level in html sanitizer config docs
- Updating Logger configuration as the code gives the following error
otherwise:
The given severity level "debug" for ... -
- With the introduction of dependency injection a workaround
was added that substitutes `new ClassName(…)` with
`Genera... -
- Test data array had not been consistent, thus throwing undefined
array access warnings.
This patch use null coalesci... -
- Cache Clearing via Install Tool does a lot more than clearing the caches
in the toolbar.
Additionally the informatio... -
- Resolves: #95612
Releases: master
Change-Id: Idbbdb2e69874d51db7bb617a07d3151abe40369a
Reviewed-on: https://review.ty... -
- Cache Clearing via Install Tool does a lot more than clearing the caches
in the toolbar.
Additionally the informatio... -
- While migrating the viewpage JavaScript module
to TypeScript in #87704, an id was falsely renamed.
This is now fixed... -
- While fixing an issue with sticky icons, the borders
below th elements with "position: relative" got
removed. This is... - 07:31 Revision bc560349: [TASK] Add example for wildcard redirect
- Resolves: #94923
Releases: master, 10.4
Change-Id: I59220d1483303adfa09e4d1e1bb57a29378663a9
Reviewed-on: https://rev... - 07:11 Revision 835ec9e0: [TASK] Add example for wildcard redirect
- Resolves: #94923
Releases: master, 10.4
Change-Id: I59220d1483303adfa09e4d1e1bb57a29378663a9
Reviewed-on: https://rev... -
- Since #95466 str_contains() is used with `null`
instead of strings in a lot of cases throughout the core.
This causes... -
- $GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS'] stores extensions
specific settings - settings created from definitions in
...
2021-10-12
-
- Some assertions in extbase functional tests access
not existing array keys, which raises PHP 8.0 warnings.
Sanitize t... -
- Supported versions by the community has been changed
after v11 LTS has been released, Furthermore v9 has
shifted into... -
17:30 Revision c4e08f80: [BUGFIX] Transfer minimum password length to the template
- Resolves: #95599
Related: #94328
Releases: master
Change-Id: If4fc48d4b279298d4bde9cd338322e5e4598a237
Reviewed-on: h... -
- Resolves: #95602
Releases: master
Change-Id: Ic91531aa6d5a95006b99bbf2d8b29db9a41516fa
Reviewed-on: https://review.ty... -
- Resolves: #95586
Related: #94402
Releases: master
Change-Id: I2b6094032523e8bcbbc67edb32b2a2c8f3abcb9f
Reviewed-on: h... -
- The Format/HtmlViewHelper is designed to run in backend
without TSFE. The HtmlViewHelperTest with disabled error
supp... -
- As found by ext:fluid TypolinkViewHelperTest with
disabled error suppression, ContentObjectRenderer
does not properly... -
- The persistence tests use ext:blog_example repositories
and miss to properly setup ConfigurationManager for this
exte... -
- Extbase functional tests with disabled error suppression
reveal there are still some tests with fixture classes
that ... -
- Change-Id: I601a246dc057e469876326c7f1d163bbfdf19cad
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/715... -
- Change-Id: I9a38139470a45db0f2f0062165b69180a1b58bc1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/715... -
11:24 Revision f217488e: [TASK] Improve PHPDoc of ResourceStorage::sanitizeFileName
- Adapt description and remove hints on exceptions which are not thrown here.
Resolves: #95149
Releases: master, 10.4
... -
- Resolves: #95450
Releases: master
Change-Id: Ifc008b06c3db26a835d50fa7f07caa23600c9795
Reviewed-on: https://review.ty... -
- Adapt description and remove hints on exceptions which are not thrown here.
Resolves: #95149
Releases: master, 10.4
... - 10:00 Revision 694bdc51: [BUGFIX] Add fallback for undefined key warning in PHP8
- These warnings have been fixed by adding a proper
fallback where needed.
Resolves: #95563
Releases: master
Change-Id... -
- To make it easier for developers and integrators,
the table name is now shown in the backend when
debugging is active... -
- The (ugly) statement strpos($haystack, 'needle') !== false can be safely
replaced with str_contains($haystack, 'needl... - 08:55 Revision 679ca065: [TASK] Update documentation links
- Releases: master
Resolves: #95574
Change-Id: I2587d67c09b317a6a14681fdf2c77a702d0be734
Reviewed-on: https://review.ty... -
- The WorkspaceMenu JavaScript module is used to
update the topbar elements, related to workspaces.
The required state... -
- Allow a list of HTML tags in the help content just as for
the configuration details.
Resolves: #95152
Releases: mast... -
07:01 Revision 2a5c83e1: [TASK] Update composer dev dependencies
- composer req --dev composer/package-versions-deprecated:^1.11.99.4
composer req --dev friendsofphp/php-cs-fixer:^3.2
...
2021-10-11
-
- Resolves: #95573
Releases: master, 10.4
Change-Id: I13742f80588d8d1d566d08e7b51c165a5139fe50
Reviewed-on: https://rev... -
- Resolves: #95573
Releases: master, 10.4
Change-Id: I13742f80588d8d1d566d08e7b51c165a5139fe50
Reviewed-on: https://rev... -
- The install tool has a special standing due to the
FailSafeContainer. The default functional test set up
however crea... - 18:15 Revision 61d760e7: [BUGFIX] Undefined array keys related to workspaces
- Fixes some undefined array key errors which happen in some specific
scenarios related to workspaces usage.
Resolves:... -
- enableRuntimeCache() has been deprecated with #93038, with
all calls being removed. #94772 re-introduced one case,
pr... -
- This resolves a todo in Tooltip.ts, where we've waited
for an updated types definition for bootstrap. Now
some new me... -
- Yet another series of PHP 8 stabilizations for
ext:lowlevel QueryGenerator. This time found by
functional tests when ... -
- If no allowed languages are defined for a BE user / group
([allowed_languages] is not set), only broken links in reco... - 15:02 Revision e256d2e6: [BUGFIX] Return empty stages list in LIVE workspace
- When accessing the Workspaces module in the LIVE workspaces, the
underlying code tries to access the list of stages a... -
- If no allowed languages are defined for a BE user / group
([allowed_languages] is not set), only broken links in reco... -
- There are few cases where the resulting path from FilePathSanitizer
is needed and used as absolute path to a private ... -
- One of the functional test related extensions still sets
'exclude' TCA property for a transOrigPointerField, which
is... -
- This fixes a couple of undefined array key accesses
in BackendUserAuthentication->modAccess().
Besides, the code is ... - 11:50 Revision eef89fac: [BUGFIX] Fix undefined array key errors for PHP 8.0
- Releases: master
Resolves: #95490
Change-Id: I8c7f055182e9a4da8ea5a7a4bd946cc69ce26e0f
Reviewed-on: https://review.ty... -
- In PageSlugCandidateProvider the pageCandidate MPVar has
been build conditional based on of original MPVar was set.
T... -
- RedirectsServiceTests simulate frontend requests
without executing them really, which prevents from
running through t... -
- Tests in SlugServiceTest from ext:redirects depend on
an initialized LanguageService, which has not been done
as ther... -
- Initializing LanguageService in $GLOBALS['LANG'] with
Bootstrap::initalizeLanguageObject() needs a proper setup
$GLOB... -
- BrokenLinkRepositoryTest of ext:linkvalidator initalizes
beuser dynamicly for tests and testdatasets. LanguageService... -
- Install tool has been trying to connect to the database before
checking if a bare minimum of configuration is given t... -
- It was a conceptual mistake to move storage 0 base path
outside the document root (public path), because this complet... -
- Public property $cObj for plugins has been deprecated in
v11 with #94956 and setContentObjectRenderer() method has
be... -
- This resolves a todo, where a test was blocking a
method of Clipboard to be protected. The test is
now adjusted as su... -
- * Use config API instead of env vars when building package artifact
* Don't try to scan for extensions in Composer mo...
2021-10-10
-
- This change addresses a regression of
https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829
where access-restricted p... -
- CleanerTasks build a query checking if tstamp tca
config is checked. Using null coalescing operator
to sanatize acces... -
- This patch fixes undefined index/offset warnings in ext:lowlevel
QueryGenerator using null coalescing operator.
Reso...
2021-10-09
-
11:05 Revision e8392985: [BUGFIX] Fix the generics annotations for ObjectManager(Interface)
- To avoid PHPStan warnings in projects that use ObjectManagerInterface
as a type annotation, the ObjectManager(Interfa... -
- This correctly sets "subst" as a value of the
softRefParams array. Previously "subst" was
set as key, which only work... - 07:32 Revision 3f844357: [BUGFIX] Add correct value for $itemsCriteriaField
- Adding a file collection to the file links
content element leads to undefined array
key warning.
This is fixed by se... -
- The "displayThumbs" module setting is
fetched two times in the FileBrowser. One
time to determine whether thumbnails
...
2021-10-08
-
- The coalesce operator has a relatively low precedence over other
operators. If used as part of other expressions, it ... -
- When showing required dependencies (= extensions) in
Extension Manager, e.g. for distributions - downloading
the Intr... -
- Access to $GLOBALS['BE_USER'] must be protected by the
neccessary fallbacks, as no backend user might be logged
in wh... -
- The confirmation password, required for accessing
the install tool through the backend, now uses the
autocomplete att... - 16:31 Revision 8d3e14ed: [TASK] Ensure record_commit parameters are not reused
- When using the "saveAndClose" option for a newContentElementWizard
item, the target link forwards directly to the rec... - 16:27 Revision a3ec0dfd: [BUGFIX] Do not prefix source set path with absRefPrefix
- The paths for source set images is currently prefixed
with a slash which causes duplicated slashes at the
beginng of ... - 16:17 Revision 0f0b4b9f: [TASK] Apply ParamTypeDeclarationRector on private methods
- Releases: master
Resolves: #95258
Change-Id: Idddbd4c449e2dc891c91f466614f04a8770d5815
Reviewed-on: https://review.ty... -
- This fixes some undefined array key warnings,
that appear on frontend requests.
Resolves: #95542
Releases: master
Ch... -
- Prevent access to undefined array keys in content renderer
and menu objects.
Resolves: #95489
Releases: master
Chang... -
- Several undefined array key warnings prevented the
TCA suggestion wizard from showing results.
These have been fixed.... -
- Some item providers (context menu) access
clipboard information. Since the clipboard was
previously not properly init... -
- In #86291 the scheduler task list was refactored. A
part of this refactoring was aligning the list with the
one, know... -
- EXT:redirect is using the TargetPageIdViewHelper to
get the page ID from a "t3://page?uid=" link. If this link
is how... -
- This reverts commit d04a65b5a731fe67af06e0507627b198e8a96a7f.
Reason for revert: Breaks checkboxes in flexform, usin... -
- EXT:redirect is using the TargetPageIdViewHelper to
get the page ID from a "t3://page?uid=" link. If this link
is how... -
- The values of tx_testdatahandler_group for the second content element
in the default language now match with ImportDe... -
- This unifies the approach of calculating the size attribute value when
having autoSizeMax set.
Resolves: #94476
Rele... -
- The page module displays a flash message for page
translations with inconsistent ("mixed mode") content
elements. The... -
- This fixes the ExtendedTemplateService->ext_getSetup()
method, which now properly handles array key accesses.
A new ... -
- If a slug is changed, the redirect cache must be rebuilt to make
the redirect actually work.
Resolves: #94808
Releas... -
- TypoScript options config.spamProtectEmailAddresses_atSubst
and config.spamProtectEmailAddresses_lastDotSubst may not... -
- EXT:felogin uses checkbox items in their FlexForm
configuration. Since the item key does not start
with 0 but with 1,...
2021-10-07
- 21:17 Revision dd0c8301: [BUGFIX] Set fe_user email field to eval "email"
- Currently the fe_user field email has a eval value
of "trim". So it does not verify the given email.
This has been f... -
- The extbase UriBuilder can be used in backend context,
ActionMenuItemViewHelper does that for instance. The
code acce... - 19:35 Revision 2bd19657: [BUGFIX] Add fallback for link details
- A link to a folder created in RTE leads to undefined
array key warning in frontend.
This has been fixed by using nul... -
- The links at the error page can be improved:
- link to the official donation page
- show typo3.org without protocol
... -
- * Arguments with default values are registered with their
default values in fluid by default. Tests that circumvent... -
- Fix a regression introduced in #91834 to be able to use stdWrap for
text.
Resolves: #95497
Related: #91834
Releases:... -
- The FileViewHelperTest runs in backend scope, a valid
backend user needs to be initialized to satisfy
StoragePermissi... -
- Argument 'priority' is accessed in ScriptViewHelper
without fallback. This is fine, since fluid sets
arguments to def... -
- Fluid Viewhelper class name resolution is case sensitive.
The patch fixes a cases where f:format.htmlentitiesdecode
i... -
- Give the actual method the name "generateMessagesForCurrentPage"
as no flash messages are generated.
Resolves: #9342... -
- Avoids a deprecation level log error since of this
functional test related extbase test controller action.
Resolves:... -
- Some functional tests using SiteBasedTestTrait create
a broken site config, example:
base: 'https://website.local/'
... -
- Viewhelpers need to be registered in Services.yaml.
Add this for a functional test related fixture extension.
Resolv... -
- If a slug is changed, the redirect cache must be rebuilt to make
the redirect actually work.
Resolves: #94808
Releas... -
- If the creation date of a system news is cleared by an editor, the
rendered news must skip the date.
Resolves: #9457... -
13:37 Revision 4d00b228: [BUGFIX] Use proper bootstrap styles for "Make Query" in DB check
- This refactores the "Make Query" block in the DB check module
to use proper bootstrap styles. This makes the whole bl... -
- Resolves: #95075
Releases: master
Change-Id: I6c2c9981aac3ccf892767c4205032e8aa2a465e6
Reviewed-on: https://review.ty... -
- Functional test ext:felogin
ContentVisibleFieldsTest::loginFormContainsExpectedFields
indirectly calls $GLOBALS['TYPO... -
- ExtensionManagementUtility() usage in Services.php has never been an
intended usage, but was technically possible in ... -
- The 2nd argument for the method `renderSingleCheckboxElement` must be
the number of the element of the given list.
R... -
- Some remarks regarding the overrideConfiguration parameter
have been documented.
Resolves: #89933
Releases: master, ... -
- This fixes a couple of array key related PHP warnings,
triggered in the TypoScript object browser while searching.
T... -
- Log messages generally use double-quotes. This patch fixes the
few stragglers that do not.
This also fixes an issue... -
10:39 Revision 363b6b4f: [TASK] Add missing breaking.rst about service injection in validators
- With #92238 the objectManager usage has been removed in Extbase
validationResolver. In the same patch it is also ment... -
- Brings fix for changed sqlite driver behaviour for php8.1,
which would fix a schemamigrator issue for php8.1.
compo... -
- Resolves: #95516
Releases: master
Change-Id: Ic8ff8cb3e10d6ba32c78c7ddf84d81027bde4924
Reviewed-on: https://review.ty... -
- JsonResponse class constructor needs to encode empty
arrays for [] to be returned as response, instead of an
empty st...
2021-10-06
-
- PHP 8.1 has changed default flags for several methods like
'htmlspecialchars()' for example. That makes sense from a
... -
- Not explicitely loading ext:beuser in the functional
test triggers a deprecated fallback to ObjectManager
when ext:be... -
- PHP8.1.0 changed internally from gethostbyaddr() to gethostinfo() from
standard c library for the php gethostbyaddr()... -
- The functional test related SiteBasedTestTrait is used
to set up site files for testing. Some options are
optional an... -
- $GLOBALS['LANG'] needs to be initialized in all
tests, not only for the first one of the test case.
This fixes a curr... -
- Some tests trigger access to $result['rootline'] and
$result['site']. In normal usages, those are set up by
the FormE... -
-
- Fixed in testing-framework since 6.11.3
-
-
- 17:02 Revision 38592f04: [BUGFIX] Replace duplicated id in Scheduler edit task template
- Resolves: #95475
Releases: master, 10.4
Change-Id: I843e657f00c3894fa934505e6fde7c7269170fb6
Reviewed-on: https://rev... - 16:43 Revision 99ddda51: [BUGFIX] Replace duplicated id in Scheduler edit task template
- Resolves: #95475
Releases: master, 10.4
Change-Id: I843e657f00c3894fa934505e6fde7c7269170fb6
Reviewed-on: https://rev... -
- Brings a couple of path related fixes to properly
initialize Environment in functional tests.
composer req --dev... -
- Brings a couple of path related fixes to properly
initialize Environment in functional tests.
composer req --dev... -
- This fixes some visual errors of the chosen component,
when used inside a bootstrap input-group. This was due
to boot... -
- * for (missing) plugin namespace in `PluginEnhancer`
* for (optional) `X-Forwarded-*` HTTP headers in `GeneralUtility... -
- Newly introduced UpdateValueOnFieldChange
has type hinted constructor arguments. Therefore,
we have to properly cast ... -
- PublicUrlPrefixer must also generate absolute FAL URLs
if a page is cached but has uncached content.
Resolves: #9547... -
- Check table select/modify options before rendering the action/button.
Resolves: #89240
Related: #90178
Releases: mas... -
- The correct module name is `help_cshmanual` to show editors additional
help information.
Resolves: #95431
Releases: ... -
- The correct module name is `help_cshmanual` to show editors additional
help information.
Resolves: #95431
Releases: ...
2021-10-05
-
- The DI configuration should be in EXT:core not EXT:backend.
Resolves: #95478
Releases: master
Change-Id: I39ea5a8ddb... -
15:56 Revision 619e94eb: [BUGFIX] Resolve site configuration in FlexForm
- Within `flexFormSegment`, the missing `SiteResolving` configuration is
included to gain access to the resolved site c... -
- In order to be able to properly resolve package ordering,
the package manager resolves the dependencies of packages.
... -
- Change-Id: I93f86f6f4203c64dc47f99d9ba6ad1070ae0dfad
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/714... -
- Change-Id: I4b33bb7be90a8fb9339918a3ea356bef1662175f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/714... -
- Avoid a dependency cycle between HTTP_HOST generation
and verification.
As $GLOBALS['TYPO3_REQUEST'] is not available... -
- This change adds a "redirect" section to disable
backend deeplinking for non-module routes by default,
and only allow... -
- With #93048 url rewrites for backend links have been introduced,
which required additional rewrite rules in the root ... -
- A neccessary check is added to prevent
the undefined array key warning on PHP 8.0
Resolves: #95472
Releases: master
... -
- With #95287 there was a bit of uncertainty whether a successful
return value of MfaProviderInterface::activate() indi... -
- For historical reasons, HMENU created links to external URLs
by calling typolink() twice.
This is because HMENU did n...
2021-10-04
-
- Logic was introduced to ignore dependencies to composer
packages that TYPO3 extensions depend on during
calculation o... -
21:02 Revision ea3935ce: [TASK] Improve default error page
- This change removes the information about "no liability"
and uses modern CSS to improve the output and rendering
of t... -
- Resolves: #95455
Releases: master
Change-Id: I0d5c99a93ce95e9c552440983369f6702cfbd772
Reviewed-on: https://review.ty... -
- The "new record" view uses the bootstrap list-group
component. Except for the first group item, all items
get their b... -
- This reverts commit 84a5e8679384e276200c04f52b6ea84d7762aa67.
Reason for revert:
The proposed and merged solution o... -
- Resolves: #95135
Releases: master
Change-Id: I3a77f9b330d3eff556d6263963fa235bcd00253b
Reviewed-on: https://review.ty... -
- Backend redirect record edit form was not clear about the
fact that regular expression do not respect query parameter... -
- Backend redirect record edit form was not clear about the
fact that regular expression do not respect query parameter... -
16:37 Revision 6c10d601: [BUGFIX] Fix unknown keys in arrays
- Fixes PHP 8-related array access errors in ContentContentObject
and AbstractMenuContentObject.
Resolves: #95453
Rele... -
- Resolves: #95423
Releases: master
Change-Id: I73257684e786245237206396391fc9f7d63baf07
Reviewed-on: https://review.ty... -
- Due to the logic of not using QueryParams[route]
anymore, but having deeplinks, more TYPO3-core
code now uses UriBuil... -
- Composer packages are installed into vendor folder by
Composer and per definition this folder is not inside
the web r... -
- The secondary options in list modules (recordlist,
filelist) are displayed in a dropdown with an icon and
the corresp... -
- Previously, the "pagesOnly" argument was used
to link to the PagePositionMap for new pages.
This is now resolved by ... -
- PreviewUriBuilder->serializeDispatcherAttributes() returns
null|string. Since the return type declaration of getPrevi... -
- Due to the bootstrap migration, the spacing
of the login forms (username+password and
MFA), was lost.
This is now fi... -
- Instead of relying on either hard coded values
or using API, which implicitly calculates URIs
from absolute paths, th... -
- To avoid PHPStan warnings in projects that use ObjectManagerInterface
as a type annotation, the ObjectManager(Interfa... -
- The Core previously contained two classes for content
position maps. One of them was already decoupled from
the PageP... -
- Resolves: #95439
Related: #95403
Releases: master
Change-Id: I262ec5e349d77ce17a571dcdc77355c97693c8de
Reviewed-on: h... -
- With #94439 the "action" attribute of the belog Constraint model has
changed to "channel" and "level". The "-1" meant...
2021-10-03
-
14:44 Revision cb8abae9: [BUGFIX] Ensure auto redirect respects language host
- When creating an automatic redirect, the language
must also be used in the source.
Resolves: #89328
Releases: master... -
- The PackageManager has all information on which
packages are installed and how they are named,
thus it should serve a... -
- When creating an automatic redirect, the language
must also be used in the source.
Resolves: #89328
Releases: master...
2021-10-02
-
- Static closures can not be used in ServerResponseCheck,
since they break the call to the closure in FileDeclaration.
... -
- In favor of allowing content-security-policy headers (some day), inline
JavaScript invocation via PHP in `AbstractCon... -
- Core cache is used in many places throughout the core,
mostly to cache resources gathered from installed
extensions. ... -
00:33 Revision cb702fdd: [TASK] Remove superflous method initializeBasicErrorReporting
- The function used to be called way earlier than initializing
final error handling, but ended up being called only one...
Also available in: Atom