Bug #25135
closed
Pagetree - Drag and drop only works for BE-Users with delete-permissions
Added by Torben Hansen over 13 years ago. Updated about 6 years ago.
100%
Description
All drag and drop functions with pages in the pagetree only works, when the backend-user has assigned delete-permissions to pages in the access-module.
How to reproduce:
1. Create some pages in the pagetree
2. Create a BE usergroup
3. Create a BE user
4. Assign the BE user to the BE usergroup
5. Assign BE usergroup access permissions to all pages (with default setting - "Delete page" not checked!)
6. Switch user to BE user
7. Try to use drap and drop in pagetree
It´s hard to say for me if this is a bug or a feature. In TYPO3 4.4.x, a BE user could use drag and drop in the pagetree without delete-permissions on pages.
If this is not a bug, maybe it would be a good idea to set "Delete page" checked in TYPO3´s default settings in the access-module.
(issue imported from #M17711)
Updated by Stefan Galinski over 13 years ago
There was a reason for this behaviour. Unfortunatly I don't know it anymore... ;-)
Updated by Torben Hansen over 13 years ago
Nice one ;-)
I had a look at the code and found the function, which disables the drag and drop feature. In "class.t3lib_tree_pagetree_commands.php" the function "getNewNode" is responsible for the setting. At the end of the function you´ll see the following:
if (!$subNode->canBeEdited() || !$subNode->canBeRemoved() || intval($record['t3ver_state']) === 2) {
$subNode->setDraggable(FALSE);
}
I have tried to remove "!$subNode->canBeRemoved()" and now all drag and drop functions seem to work fine for a BE usergroup. So the question is, why is it necessary that a page can be removed to use drap and drop functionality? My first thought was the new "Drop here to delete"-field. Maybe no access-checking is done there. So I tested to drag and drop a page (with no delete-permission for the usergroup) to the "Drop here to delete"-field, and an error message appears which says, that I don´t have the right permissions to delete the page. So everything fine there and access-checking is correct.
Maybe this helps you remembering, what the reason was for this behaviour.
Updated by Susanne Moog over 13 years ago
- Category set to Pagetree
- Target version deleted (
0)
Updated by Andreas Wolf about 13 years ago
- Assignee set to Stefan Galinski
- Target version set to 4.6.0-beta3
Stefan, any news on that? Does Torbens comment help you fix this issue?
Updated by Oliver Hader about 13 years ago
- Target version changed from 4.6.0-beta3 to 4.6.0-RC1
Updated by Xavier Perseguers about 13 years ago
- Target version changed from 4.6.0-RC1 to 4.6.0
Updated by Chris topher about 13 years ago
- Target version changed from 4.6.0 to 4.6.1
Updated by Chris topher almost 13 years ago
- Target version changed from 4.6.1 to 4.6.2
Updated by Xavier Perseguers almost 13 years ago
- Assignee deleted (
Stefan Galinski) - Target version deleted (
4.6.2)
Updated by 
Updated by
Updated by Robert Vock over 10 years ago
push
Still a problem in 6.1.
I can't see a reason why the editor needs the delete permission to move pages. It's possible to move the page in list view, so it should be possible to move in the pagetree.
Updated by Mathias Brodala almost 10 years ago
- Target version set to next-patchlevel
Still valid with 6.2 LTS, please have a look at this.
Updated by Mathias Schreiber almost 10 years ago
- Status changed from New to Accepted
- TYPO3 Version changed from 4.5 to 7
- Is Regression set to No
Updated by Mathias Schreiber about 9 years ago
- Target version deleted (
next-patchlevel)
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46445
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46445
Updated by Johannes C. Schulz over 8 years ago
I run into that problem using 7.6.6.
I hope this problem will be fixed soon?!
best regards
Johannes
Updated by Sebastian Michaelsen about 8 years ago
Bump. Ran into this with 7.6.11
Updated by Markus Klein almost 8 years ago
- Status changed from Under Review to Accepted
- TYPO3 Version changed from 7 to 6.2
- Complexity set to hard
Updated by Stig Nørgaard Færch almost 7 years ago
- TYPO3 Version changed from 6.2 to 8
Bump. Now ran into this in 8.7.8.
Updated by Gerrit Code Review almost 7 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54965
Updated by Gerrit Code Review almost 7 years ago
Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54965
Updated by Tymoteusz Motylewski almost 7 years ago
- Related to Bug #83694: Do not show delete option when user has no delete permissions added
Updated by Gerrit Code Review almost 7 years ago
Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54965
Updated by Gerrit Code Review almost 7 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55535
Updated by Tymoteusz Motylewski almost 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7cd09eb3c177957c0d148733fd09f29233c341c6.
Updated by Robert Vock over 6 years ago
- Related to Bug #84513: Pagetree - Drag and Drop does not work without delete-permissions added
Updated by Helmut Hummel over 6 years ago
There was a reason for this behaviour.
The reason obviously is, that data handler disallows moving pages without delete access and (imho) rightfully does so. See followup https://forge.typo3.org/issues/84513#note-3
Updated by