Project

General

Profile

Actions
Copy link

Bug #70812

closed

edit user or usergroup > cannot remove every permission on file/directories

Added by Riccardo De Contardi about 9 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend User Interface
Target version:
Candidate for patchlevel
Start date:
2015-10-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Steps to reproduce:

1) System > backend user module (or root > list)
2) click + to create a new user
3) remove EVERY permission
4) on the tab "Mounts and workspaces" > "Fileoperation permissions:" uncheck everything both on "directory" and "files" list.
5) save
Result: "directory" and "files" lists still have checked options (the one you unchecked before) that is:

Directory: Read
Directory: Write
Directory: Add
Directory: Rename
Directory: Move
Directory: Delete

Files: Read
Files: Write
Files: Add
Files: Rename
Files: Replace
Files: Move
Files: Delete

(see attached file)

- you have to remove EVERYTHING from both to have this situation: if you keep at least one setting in one of the lists, the result is saved and not reverted
- this issue does not seem present on 6.2.15

Files

Schermata 2015-10-17 alle 17.12.39.png (52.7 KB) Schermata 2015-10-17 alle 17.12.39.png Riccardo De Contardi, 2015-10-17 17:18

Related issues 10 (0 open — 10 closed)

Related to TYPO3 Core - Bug #71020: Backendgroups / Rights for fileoperationsClosed2015-10-26

Actions
Related to TYPO3 Core - Bug #76033: Invalid default value for be group/user file permissionsClosedMarkus Klein2016-05-03

Actions
Related to TYPO3 Core - Bug #77705: No observance for the permissions for fileoperationsClosed2016-08-31

Actions
Related to TYPO3 Core - Bug #77704: Permissions for fileoperationsClosed2016-08-31

Actions
Related to TYPO3 Core - Bug #80279: Default language can't be selected/storedClosed2017-03-14

Actions
Related to TYPO3 Core - Bug #65573: File operation permissions are not correctly inherited from group when field in user is NULLClosed2015-03-06

Actions
Related to TYPO3 Core - Bug #88312: User group definitions not saved properlyClosedAndreas Kienast2019-05-09

Actions
Related to TYPO3 Core - Bug #89643: file permissions cannot not both be emptyClosed2019-11-11

Actions
Has duplicate TYPO3 Core - Bug #76035: Unable to remove all directory and file permissions for be users or groupsClosed2016-05-03

Actions
Has duplicate TYPO3 Core - Bug #81506: formEngine: fileoperation permissions not possible to persist if no permission ist selectedClosed2017-06-07

Actions
Actions
Copy link
 #1

Updated by Riccardo De Contardi about 9 years ago

  • Subject changed from create a new user > cannot remove every permission on file/directories to edit user or usergroup > cannot remove every permission on file/directories

the issue affects also usergroups, not only users. See also #71020

Actions
Copy link
 #2

Updated by Riccardo De Contardi almost 9 years ago

This issue is still valid for the latest 8.0-dev master

Actions
Copy link
 #3

Updated by Markus Klein over 8 years ago

  • Status changed from New to Accepted
  • Priority changed from Should have to Must have
  • Target version set to Candidate for patchlevel
  • Sprint Focus set to Stabilization Sprint
Actions
Copy link
 #4

Updated by Daniel Windloff about 8 years ago

I had the same problem on an own TCA configuration.
I think this bug has the following reason:

In 

typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php
line 114 the default value for an empty list is defined as "".
$html[] = '<input type="hidden" class="select-checkbox" name="' . htmlspecialchars($parameterArray['itemFormElName']) . '" value="">';

In 

DataHandler::castReferenceValue
the value "" would be replaced by the default value defined in TCA.

Changing the return of castReferenceValue or the default value could be breaking change in some scenarios.

Actions
Copy link
 #5

Updated by Frans Saris about 8 years ago

  • Is Regression changed from No to Yes
Actions
Copy link
 #6

Updated by Riccardo De Contardi almost 8 years ago

Still affects both 7.6.15 and the latest master.

Actions
Copy link
 #7

Updated by Josef Glatz over 7 years ago

  • Has duplicate Bug #81506: formEngine: fileoperation permissions not possible to persist if no permission ist selected added
Actions
Copy link
 #8

Updated by Josef Glatz over 7 years ago

  • TYPO3 Version changed from 7 to 8
  • Sprint Focus deleted (Stabilization Sprint)

8LTS and 9-dev (master) still affected

Actions
Copy link
 #9

Updated by M S about 7 years ago

Thats a really hard bug since a few years. Would be nice if somebody could fix this.

Actions
Copy link
 #10

Updated by Markus Klein about 7 years ago

I took a look already some time ago. It is also super hard to fix this!
I wasn't yet able to figure out if this would result in a major breaking change of DataHandler.

Actions
Copy link
 #11

Updated by M S about 7 years ago

Markus Klein wrote:

I took a look already some time ago. It is also super hard to fix this!
I wasn't yet able to figure out if this would result in a major breaking change of DataHandler.

Would it be able to add a temoporary checkbox like "no permissions"?

Actions
Copy link
 #12

Updated by Riccardo De Contardi almost 6 years ago

  • Related to Bug #80279: Default language can't be selected/stored added
Actions
Copy link
 #13

Updated by Susanne Moog over 5 years ago

  • Related to Bug #65573: File operation permissions are not correctly inherited from group when field in user is NULL added
Actions
Copy link
 #14

Updated by Gone With the Wind over 5 years ago

  • Related to Bug #88312: User group definitions not saved properly added
Actions
Copy link
 #15

Updated by Riccardo De Contardi almost 5 years ago

  • Related to Bug #89643: file permissions cannot not both be empty added
Actions
Copy link
 #16

Updated by Riccardo De Contardi almost 5 years ago

As reported by on #89643 from Robert Wildling, this issue still affects TYPO3 9.5.x

Actions
Copy link
 #17

Updated by Riccardo De Contardi over 4 years ago

Still present on latest master (10.4.0-dev)

Actions
Copy link
 #18

Updated by Riccardo De Contardi over 4 years ago

I was thinking: the issue is still present, but... does it make sense to remove every permission from the file or directory operations? If I don't want let a group do anything on a filemount - not even read it - I should not give it to the group, am I right? I hope I explained myself.

Or is there some scenario that I am not considering?

My suggestions

1) Make the "Read" always checked and readonly - later we can even remove it from the view maybe.
I think that this would even prevent some "odd" config like Read: deny; Write: allow

or

2) print out an error or warning message if I try to remove everything and save (It could even be something like "you can't remove every permission from the directory / file; permissions reverted to the previous selection"

Actions
Copy link
 #19

Updated by Jonas Eberle over 4 years ago

I think 1) is a very practical choice.

Actions
Copy link
 #20

Updated by Felix Rauch over 4 years ago

Riccardo De Contardi wrote:

I was thinking: the issue is still present, but... does it make sense to remove every permission from the file or directory operations? If I don't want let a group do anything on a filemount - not even read it - I should not give it to the group, am I right? I hope I explained myself.

Or is there some scenario that I am not considering?

Well not technically in this case, but doesn't the underlying Form Engine issue still exist?

I remember wrangling this issue for a while with a project because the requirements stated some form should have a multi-checkbox list with default selection and possibility to select nothing.

I think if this issue would be closed with a workaround, the TCA documentation should be adjusted to give some indication that the behaviour I described is out of spec for that field type (which I could understand, the underlying issue is a nightmare to fix, at least it was when I attempted some years back)

Actions
Copy link
 #21

Updated by Riccardo De Contardi over 4 years ago

@Felix Rauch I got your point, you are right;

I feel that multiple checkboxes on FormEngine are a bit misfortunate; there is another issue: it is not possible to mark them as required ;)

Anyway, so there are two separate issues here

- the technical one about FormEngine and multiple checkboxes
- the conceptual one about permissions on files and folder

Actions
Copy link
 #22

Updated by Gerrit Code Review about 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #23

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #24

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76512

Actions
Copy link
 #25

Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #26

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76512

Actions
Copy link
 #27

Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #28

Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76512

Actions
Copy link
 #29

Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #30

Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #31

Updated by Gerrit Code Review about 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #32

Updated by Gerrit Code Review about 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #33

Updated by Gerrit Code Review about 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #34

Updated by Gerrit Code Review about 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #35

Updated by Gerrit Code Review about 2 years ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76491

Actions
Copy link
 #36

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76523

Actions
Copy link
 #37

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76523

Actions
Copy link
 #38

Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76523

Actions
Copy link
 #39

Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76523

Actions
Copy link
 #40

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76497

Actions
Copy link
 #41

Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #42

Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76497

Actions
Copy link
 #43

Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #44

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF