Project

General

Profile

Activity

From 2023-03-17 to 2023-04-15

2023-04-15

20:18 Revision 0b7b531e: [TASK] Update table of submodule "Pages containing page TSconfig"
The naming of the table headers has been updated, as well as label
'Page title' in the pages TCA itself.
The spacing...
Jasmina Ließmann
19:58 Revision 1425e911: [TASK] Align form fields in modules 'TypoScript' and 'Page TSconfig'
With this patch we now stricly use .form-label as class for form field
labels in both modules.
The width of the opti...
Jasmina Ließmann
19:48 Revision 2ecfca1c: [TASK] Update display of 'Create multiple pages' wizard
The markup of the form to create multiple pages was updated to match
the regular markup.
After creation, the new and...
Jasmina Ließmann
18:49 Revision ca27a7d3: [TASK] Mitigate extbase crash in non TS context
People tend to run extbase in context it is not
designed to be run in. TYPO3 v11 and before
has been forgiving in suc...
Christian Kuhn
09:41 Revision 320b7c5d: [DOCS] Add missing single quote in example code
Releases: main
Resolves: #100609
Change-Id: Idc1acf2e4cfd776d89517227c1c9e32d2bdf1830
Reviewed-on: https://review.typ...
Česlav Przywara
01:34 Revision de1cd532: [TASK] Use phpunit 10.1
Switch to phpunit:^10.1.0 as minimum version,
removing phpunit:^9 in core main.
Clean up a test case, clean up tempo...
Christian Kuhn

2023-04-14

23:50 Revision d69f4a18: [TASK] Ensure working phpunit 10.1 for unit- and functional tests
PhpUnit 10.1 changed again some things from 10.0 -> 10.1,
like removing `RiskyTestError` exception and moving the
Php...
Stefan Bürk
23:00 Revision 93accbd5: [BUGFIX] Mitigate incorrect libxml usage of "enshrined/svg-sanitize"
External "enshrined/svg-sanitize" package uses
`libxml_use_internal_errors()`, but fails to
clear errors using libxml...
Stefan Bürk
22:59 Revision ab1f47ac: [BUGFIX] Mitigate incorrect libxml usage of "enshrined/svg-sanitize"
External "enshrined/svg-sanitize" package uses
`libxml_use_internal_errors()`, but fails to
clear errors using libxml...
Stefan Bürk
22:38 Revision 5da2d61b: [TASK] styleguide: Remove depcreated docker version note from runTests.sh
`Build/Scripts/runTests.sh` containted a message to state the
needed minimum docker version. Most likely, there shoul...
Stefan Bürk
22:38 Revision 4a2006af: [TASK] styleguide: Remove ignore-platform workaround in composerUpdate
phpspec/phrophecy added php 8.2 support in the meantime,
albeit we do not longer use that package in testing.
Theref...
Stefan Bürk
19:59 Revision fff1abc9: [TASK] Update Doctrine DBAL
This update fixes some PHPStan warnings for us.
> composer req doctrine/dbal:^3.6.2
> composer req doctrine/dbal:^3....
Oliver Klee
19:49 Revision be38ba03: [BUGFIX] Adjust return value in DeprecatingRequestWrapper
With #100567, the return type of the getPageArguments()
method in RequestWrapper and DeprecatingRequestWrapper
was ch...
Oliver Bartsch
18:06 Revision 5183224a: [TASK] Simplify code in LazyObjectStorage
Simplify `initialize` using a guard clause.
Resolves: #100598
Releases: main, 11.5
Change-Id: Ic53d190a139bc4c74517f...
Oliver Klee
17:52 Revision 1a82095a: [TASK] Simplify code in LazyObjectStorage
Simplify `initialize` using a guard clause.
Resolves: #100598
Releases: main, 11.5
Change-Id: Ic53d190a139bc4c74517f...
Oliver Klee
17:49 Revision ae7a934d: [TASK] Deprecate two BackendUtility methods
The BackendUtility methods getThumbnailUrl()
and getLinkToDataHandlerAction() are deprecated as
they are just wrapper...
Benni Mack
16:35 Revision 62b11958: [TASK] Update bootstrap to 5.3.0-alpha3
- Drop default override styling for <hr> without classes
- Drop unused/obsolete scss variables
- Drop variable `$text...
Benjamin Kott
14:30 Revision b977e837: [TASK] Deprecate GeneralUtility::_GET()
This deprecates GeneralUtility::_GET() as last
member of the get/post related family, next to
GU::_POST(), GU::_GP() ...
Christian Kuhn
14:19 Revision 67e70a01: [TASK] Do not set &nbsp; as label for checkboxes in debug mode
There is no need to add a non-breaking space as a fallback if the label
is empty for checkboxes. This results in unne...
Benjamin Kott
14:16 Revision bb4b3f34: [TASK] Deprecate form engine result property additionalJavaScriptPost
Deprecates form engine result property `additionalJavaScriptPost`,
which was used by custom evaluation that provided ...
Oliver Hader
13:07 Revision abf2c8d8: [TASK] Avoid GU::_GET() in ServerRequestFactory
ServerRequestFactory is essentially the only
place with a legit access to $_GET super global.
Avoid using GeneralUtil...
Christian Kuhn
12:28 Revision 91f34f04: [TASK] Drop a.disabled styling
The special handling for a.disabled is obsolete, is was introduced
to prevent the default link handling for the new c...
Benjamin Kott
12:05 Revision f3416f01: [TASK] Drop unused and unnessesary text-* css classes
The class .text-normal is not used at all and can be dropped.
The class .text-pre-wrap was only used on .alert-messa...
Benjamin Kott
12:02 Revision 9ca34fce: [TASK] Avoid ext:install uri.action VH
The ext:install uri.action ViewHelper is - after
various previous refactorings - only used within
standalone install ...
Christian Kuhn
11:54 Revision 10467a0c: [TASK] Replace text-monospace with font-monospace
This patch cleans up the a workaround for the Bootstrap
CSS Framework 5.1 update where `.text-monospace` was
dropped ...
Benjamin Kott
11:46 Revision dc548fdb: [TASK] Streamline media queries and breakpoints
The Bootstrap CSS Framework changed the handling of media queries
with version 4.6 but the core never adapted to this...
Benjamin Kott
11:40 Revision d9132922: [TASK] Cleanup impexp templates
- Migrate checkboxes to form-check
- Rebuild indention of rows
- Add icons to buttons
- Add sections to tabs
- Add mi...
Benjamin Kott
10:38 Revision e04594ba: [BUGFIX] Add action wrapper around file list actions
The multi selection actions available in the file list are wrapped by
`.multi-record-selection-actions-wrapper` now t...
Andreas Fernandez
10:21 Revision c4c639bf: [DOCS] Null-safe Operator in TypoScript conditions
With the upgrade of symfony/expression-language 6.2 in
TYPO3 v12.1, a new user-facing feature for TypoScript
conditio...
Oliver Bartsch
10:10 Revision 0151c777: [TASK] Avoid last GU::linkThisScript() and deprecate
GeneralUtility::linkThisScript() is one of the
last usages that access $_GET() from globals.
The patch removes a las...
Christian Kuhn
08:42 Revision 09036ffe: [TASK] Prepare FormDataCompiler towards DI
FormDataCompiler pollutes __construct(), making
it impossible to be injected.
The patch changes compile() to receive...
Christian Kuhn
08:09 Revision 6a31302c: [BUGFIX] Allow digit only strings in EmailFinisher
Since it's valid to use a digit-only subject or title, those
options are now properly cast to a string, preventing
Ty...
Oliver Bartsch
08:08 Revision 0e4caa2c: [BUGFIX] Allow {__currentTimestamp} as form property
Resolves: #100580
Releases: main, 11.5
Change-Id: I10e4b21908a1b4649d7ab4b02c467af381017b2b
Reviewed-on: https://revi...
André Buchmann
08:08 Revision ba352691: [BUGFIX] Allow {__currentTimestamp} as form property
Resolves: #100580
Releases: main, 11.5
Change-Id: I10e4b21908a1b4649d7ab4b02c467af381017b2b
Reviewed-on: https://revi...
André Buchmann
07:56 Revision 490d53d0: [BUGFIX] Prevent exception using getTSFE() in backend context
In case the "getTSFE()" expression function is called
in backend context - having no TSFE available-, the
function re...
Oliver Bartsch
07:40 Revision 7f686a8f: [BUGFIX] Allow digit only strings in EmailFinisher
Since it's valid to use a digit-only subject or title, those
options are now properly cast to a string, preventing
Ty...
Oliver Bartsch
07:27 Revision 8ef3e2ea: [TASK] Avoid phpunit 10.1 in CI for now
The CI currently runs phpunit ^10 parallel
to default ^9. phpunit 10.1 has just been
released, bringing further clean...
Christian Kuhn

2023-04-13

13:00 Revision 34384607: [TASK] Improve beuser templates
Templates were streamlined to provide the same experience
across the available modules. That means, record counter
he...
Benjamin Kott
12:39 Revision 6524ba81: [TASK] Have request in FormEngine
Some details of FormEngine still directly or
indirectly access request data from globals.
To change this, controller...
Christian Kuhn
12:28 Revision ac253223: [TASK] Harden willReturnCallback calls in some extension tests
- add parameter and return type declarations
- use the same parameter names as in the mocked methods
- use first-clas...
Oliver Klee
12:20 Revision 9a1c2c52: [TASK] Remove a useless FAL related test
The method is already indirectly tested
with a class instance by other tests based
on LocalDriverFilenameFilter fixtu...
Christian Kuhn
12:16 Revision 60c1ccac: [BUGFIX] Remove vertical spacing of page layout grid
In order to streamline the spacing it is necessary that
all modules in the TYPO3 backend share the same base
stylings...
Benjamin Kott
12:14 Revision fa2d35c3: [TASK] Add close confirmation modal to scheduler
Currently, if a task was changed in the edit/add view
the close button goes back to list view without
letting the use...
Jochen Roth
12:06 Revision b2609cc6: [BUGFIX] Allow different navigation component for sub modules
To set a different navigation component for a sub module,
"inheritNavigationComponentFromMainModule" must
be disabled...
Oliver Bartsch
10:45 Revision bb439dd3: [BUGFIX] Pre-define `cropBox` in Image Manipulation
This patch pre-defines `cropBox` with an empty jQuery object to avoid
errors when starting the image cropper. A simil...
Andreas Fernandez
09:37 Revision 271b5a51: [BUGFIX] Use correct icon key in UserInformationService.php
Resolves: #100574
Related: #99739
Releases: main
Change-Id: Ide714744621f9298d7d37d52421fb690ba2387c1
Reviewed-on: ht...
Andreas Fernandez
09:11 Revision d14ac266: [BUGFIX] Fix PHP warning in FormFieldViewHelper
When using a formField with a property name
that only consists of a number (e.g. a UID),
Fluid will now allow this.
...
Benni Mack
08:06 Revision 9a6fc9a6: [BUGFIX] Fix PHP warning in FormFieldViewHelper
When using a formField with a property name
that only consists of a number (e.g. a UID),
Fluid will now allow this.
...
Benni Mack
07:56 Revision 787b3960: [TASK] Drop special styling for popover, tooltips, h1, h2 and h3
There is not need for a special styling here, the components
are fine as is. We are now preferring the defaults over ...
Benjamin Kott
06:13 Revision efd412eb: [BUGFIX] Allow multiple CSS files in CKEditor 5
With the migration to CKEditor 5, `config.contentsCss` was degraded to
allow a single file only in CKEditor itself. T...
Andreas Fernandez
05:23 Revision 036957d5: [TASK] Raise 'phpstan/phpstan' and regenerate baseline
A new patch level forces us to regenerate
baseline.
> composer req --dev phpstan/phpstan:^1.10.13
> Build/Scripts/ru...
Christian Kuhn
05:23 Revision 4eb8a2d8: [TASK] Raise 'phpstan/phpstan' and regenerate baseline
A new patch level forces us to regenerate
baseline.
> composer req --dev phpstan/phpstan:^1.10.13
> Build/Scripts/ru...
Christian Kuhn

2023-04-12

19:27 Revision e1b83591: [BUGFIX] Ensure email links do not throw an exception
When upgrading a project to TYPO3 v12,
the new email link validator now
checks for other properties than the
email ad...
Benni Mack
19:24 Revision c4d7c4d6: [BUGFIX] Fix return type in RequestWrapper
In case TypoScript conditions are evaluated in
the backend, e.g. in extbase modules, usage
of `getPageArguments()` mi...
Oliver Bartsch
18:49 Revision 7357c911: [TASK] Clean up FormDataCompiler
Protected property $removeKeysFromFinalResultArray
is unused and can be removed. Also use constructor
property promot...
Christian Kuhn
17:38 Revision 4a528fd0: [TASK] Separate move page + move content element
This change splits up moving of a page into a
"move_page" route / controller, and the
"move_element" for tt_content e...
Benni Mack
17:02 Revision ca03f88a: [BUGFIX] Allow ws: and wss: source scheme for CSP
Resolves: #100558
Releases: main
Change-Id: Icd5beb7c31e473494d8d91f76d7440a1c1724e09
Reviewed-on: https://review.typ...
Oliver Hader
15:19 Revision 4a36f6d3: [BUGFIX] Correct link in PageMovingPagePositionMap
Repositioning a content element to a different page
using the list module "Re-position content element"
view fails wi...
Christian Kuhn
14:55 Revision e207344c: [BUGFIX] Prevent TypeError in DatabaseIntegrityController
Adding necessary typecast to prevent TypeError
in DatabaseIntegrityController.
Resolves: #100562
Related: #100521
Re...
Oliver Bartsch
14:51 Revision 44531974: [BUGFIX] Broken returnUrl in db check search
The "DB check" -> "Full search" module allows to show
soft-deleted records. Such result rows have a button
to "undele...
Christian Kuhn
14:25 Revision 7c8ece47: [BUGFIX] ckeditor: Do not update source element on document change
The change in #99669 introduced an update of the source element bound to
the ckeditor instance. Unfortunately, this l...
Andreas Fernandez
13:53 Revision db04d584: [TASK] Deprecate TSFE->type
This information can now be retrieved
from the page arguments object, as
it is encouraged to not rely on the global
T...
Benni Mack
12:34 Revision 1df2ac1c: [TASK] Mark several internal methods and properties protected in UserAuthentication
To enable further refactorings and decoupling work,
several internal methods and properties in the
user authenticatio...
Benni Mack
11:24 Revision 920e6a38: [BUGFIX] Use associative keys in AbstractContentPagePositionMap
The controller called when moving (content) elements in
list module triggers an undefined array key warning.
The code...
Christian Kuhn
07:30 Revision 11e8c162: [BUGFIX] Recursive INCLUDE_TYPOSCRIPT directory includes
With yet another happy little recursive method,
recursive directory includes should work again.
Resolves: #100166
Re...
Christian Kuhn
07:27 Revision 03837e6e: [TASK] Drop help-block and optimize spacing in form engine
The spacing for formengine elements have been improved.
The legacy .help-block was replaced with .form-text in
boots...
Benjamin Kott
07:24 Revision fadf6fad: [TASK] Avoid superfluous SQL queries in HrefLangGenerator
Page records for default language and the current exist in TSFE->page,
so they don't need to be fetched again.
Resol...
Christoph Lehmann
06:22 Revision 67b2545e: [BUGFIX] Fix page reloading on click on preview button (again)
The changes introduced in #93706 broke the preview button functionality
in multidomain setups. When first previewing ...
Christian Eßl
05:43 Revision abeed7ab: [BUGFIX] Apply no-cookie for vimeo when setting is missing
Improve the privacy of users by using the no-cookie setting
by default as fallback and set the do not track parameter...
Ayke Halder
04:45 Revision 39a44bfc: [BUGFIX] Apply no-cookie for vimeo when setting is missing
Improve the privacy of users by using the no-cookie setting
by default as fallback and set the do not track parameter...
Ayke Halder
04:41 Revision c335f633: [TASK] Speed up page tree
Further speed up the page tree for large sites by initially preparing
the quoted fields instead of newly quoting them...
Christian Eßl

2023-04-11

18:11 Revision 52faa679: [BUGFIX] Fix page reloading on click on preview button (again)
The changes introduced in #93706 broke the preview button functionality
in multidomain setups. When first previewing ...
Christian Eßl
18:10 Revision bcf7a4e6: [TASK] Streamline checkbox and radio rendering
We still carry around a lot of legacy checkbox
and radio styling, this patch reduces the
the complexity of existing o...
Benjamin Kott
17:22 Revision 2cc63340: [DOCS] Correct method call in CountryProvider example
Resolves: #100556
Related: #99618
Releases: main
Change-Id: I2db084cd73292f56ffb856941229a201e8a06cca
Reviewed-on: ht...
Chris Müller
13:56 Revision cce2b609: [DOCS] Fix indentation in EXT:form documentation
Resolves: #100553
Releases: main
Change-Id: I6ad18346beccd7c0efdf1b148421c44cf095c788
Reviewed-on: https://review.typ...
Oliver Bartsch
13:32 Revision d7cde63f: [TASK] Set TYPO3 version to 11.5.27-dev
Change-Id: Ifb6baec06e9a7be3e891b6e3e7b314d52886b87c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/785...
Benni Mack
13:31 Revision f4d39873: [TASK] Set TYPO3 version to 10.4.38-dev
Change-Id: I1dad023b97567144be9e7f43f49911b7cfa076fb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/785...
Benni Mack
13:20 Revision 0a2e9d71: [RELEASE] Release of TYPO3 11.5.26
Change-Id: Iedc984e71a0cd1d82d1f7f0f28ddf8c9712b9575
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/785...
Benni Mack
13:10 Revision e4ce9ab4: [RELEASE] Release of TYPO3 10.4.37
Change-Id: Ic71fc76b6e9fdb9d9f9f7ad5aa8ec34c39305073
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/785...
Benni Mack
13:05 Revision f4d67420: [BUGFIX] Make `PolicyProviderTest` final
Resolves: #100554
Releases: main
Change-Id: Ib1bad402fea3c36cac8f45a4ec9291fb8ea9c415
Reviewed-on: https://review.typ...
Andreas Fernandez
12:24 Revision 53cdc6e9: [BUGFIX] Make grid selection available for Number form element
This fixes the YAML configuration of the "Number"
form element, making the gird selection available.
Resolves: #9893...
Oliver Bartsch
12:18 Revision 9087229f: [BUGFIX] Skip webhook message when page has no site
When a new page on rootlevel is created (via import)
and webhooks is installed, a webhook is not triggered
now, becau...
Benni Mack
11:56 Revision 9fd39e37: [TASK] Raise typo3/cms-styleguide
styleguide icons now avoid svg inline styles.
> composer u typo3/cms-styleguide
Change-Id: I5e6598ca5e125c4be079d66...
Christian Kuhn
11:56 Revision ff15d87e: [BUGFIX] Make grid selection available for Number form element
This fixes the YAML configuration of the "Number"
form element, making the gird selection available.
Resolves: #9893...
Oliver Bartsch
11:50 Revision fcca2422: [BUGFIX] Use frontend site-language specific CSP reporting endpoint
When having a site-language base URI like `/en/` the CSP reporting
endpoint was listening on `/@http-reporting`, but ...
Oliver Hader
11:42 Revision 051cf207: [BUGFIX] Backport null checks to Core QueryGenerator
This file was removed in v12 and only the version in
TYPO3\CMS\Lowlevel\Database\QueryGenerator
was updated with fixe...
JAKOTA Design Group GmbH
11:03 Revision 4bc48b70: [BUGFIX] Avoid invalid array key accesses in ext:linkvalidator
Ensure that invalid array key accesses are properly guarded.
Resolves: #99863
Releases: main, 11.5
Change-Id: I1900e...
Stefan Bürk
11:03 Revision fa7d6a73: [BUGFIX] Avoid invalid array key accesses in ext:linkvalidator
Ensure that invalid array key accesses are properly guarded.
Additionally, fix the id of a language label, which was...
Stefan Bürk
11:03 Revision ccadcb34: [BUGFIX] Improve performance of TreeController
The recursive function pagesToFlatArray make use of
the page tree repository on two places, which always
instantiates...
Alexander Grein
10:46 Revision 696c632c: [TASK] styleguide: Avoid inline styles in .svg
Resolves: https://github.com/TYPO3-CMS/styleguide/issues/377 Christian Kuhn
10:05 Revision e259036b: [BUGFIX] Sanitize BackendUtility::titleAttribForPages()
When the "Access" module is called without a selected
page, the root page icon rendering triggers a PHP 8.0
array acc...
Christian Kuhn
09:56 Revision a01aa6f3: [BUGFIX] Sanitize BackendUtility::titleAttribForPages()
When the "Access" module is called without a selected
page, the root page icon rendering triggers a PHP 8.0
array acc...
Christian Kuhn
09:52 Revision 32b24f07: [TASK] Rework display of submodule "Database Relations"
Display description to improve understanding of this submodule.
Usage of card module to split the sections into two ...
Jasmina Ließmann
09:47 Revision dd6175ae: [TASK] Drop usage of text(-*)-right and .text(-*)-left
To better support RTL languages we start dropping the
legacy bootstrap directional class names for text alignment
and...
Benjamin Kott
09:46 Revision 2c1352b3: [TASK] Superfluous SQL query in language menu
TSFE->page now holds a copy of the page in default language, so it
can be re-used.
Resolves: #100371
Releases: main
...
Christoph Lehmann
09:44 Revision cd8751d3: [TASK] Enable strict typing for Icon::class and add title
This patch enables strict types for the Icon:class.
We are also introducing a fluent setter object pattern
for and i...
Benjamin Kott
09:43 Revision 89df2d8f: [TASK] Rework command line usage section in "Manage Reference Index"
In submodule "Manage Reference Index" the instructions for command
line usage have been moved into an infobox.
Resol...
Jasmina Ließmann
09:42 Revision 54dac6c2: [TASK] Declare all test classes final
Test classes should never extend each other.
phpunit 10 is also a bit more picky about naming
of abstract test cases....
Wouter Wolters
09:29 Revision 23b58c3f: [BUGFIX] Flatten nesting of formengine-field-item in web components
Resolves: #100540
Releases: main
Change-Id: I4acdefdf455bff6e855ce130c8165a398f271a6f
Reviewed-on: https://review.typ...
Benjamin Kott
08:48 Revision b5ba9563: [BUGFIX] Correct nesting of typo3-copy-to-clipboard in UuidElement
Resolves: #100542
Releases: main
Change-Id: I0de8551dfa466ea2d4db7cee86c3003e1620f430
Reviewed-on: https://review.typ...
Benjamin Kott
08:07 Revision 2d088697: [BUGFIX] Use IntersectionObserver to determine if a tree is visible
The problem with the current implementation is that it does not
consider that a tab may already be active but not vis...
Benjamin Kott
07:36 Revision b020dac1: [BUGFIX] Use IntersectionObserver to determine if a tree is visible
The problem with the current implementation is that it does not
consider that a tab may already be active but not vis...
Benjamin Kott
07:30 Revision 88df1d11: [BUGFIX] Apply inline icon styles with nonce attribute
Since issue #100270 some icons are not rendered anymore in the
backend when having a strict `style-src` CSP directive...
Oliver Hader
07:27 Revision 83f2d8e7: [BUGFIX] Finetune table-fit border removals
To avoid double borders at the bottom for tables in
a .table-fit wrapper the default border-bottom, for
the last row ...
Benjamin Kott

2023-04-10

14:12 Revision f7ec230a: [TASK] Improve PathUtility tests
Add more test cases found when running mutation tests.
Resolves: #100532
Releases: master, 11.5
Change-Id: I3dc61e3...
Tymoteusz Motylewski
14:12 Revision 991fba3f: [TASK] Improve PathUtility tests
Add more test cases found when running mutation tests.
Resolves: #100532
Releases: master, 11.5
Change-Id: I3dc61e3...
Tymoteusz Motylewski
13:55 Revision b62f9f76: [TASK] Use dice icon instead of refresh for generating password actions
Resolves: #100541
Releases: master
Change-Id: I77acf7bfa17432103fc198acc1d9c8900934a363
Reviewed-on: https://review.t...
Benjamin Kott

2023-04-09

20:11 Revision 858f8657: [TASK] Streamline icon related web components
Resolves: #100270
Releases: main
Change-Id: Iab72c6ac0952d740f283cbe1860554b10a96abb1
Reviewed-on: https://review.typ...
Benjamin Kott
20:08 Revision 348ee331: [TASK] Update display of add/edit scheduler task form
Previously, the form fields in the add/edit form of a task were
displayed in their entirety, filling the screen. Addi...
Jasmina Ließmann
14:15 Revision f6e2ee01: [TASK] Avoid PHP 8.2 deprecation messages in CSP backend module
Replace "self" in callables by their first class callable syntax.
Resolves: #100534
Related: #99499
Releases: main
C...
Chris Müller

2023-04-08

06:47 Revision dedba26f: [TASK] Update @typo3/icons to 3.6.0
Executed commands:
npm install @typo3/icons@^3.6.0
npm run build
Resolves: #100530
Releases: main
Change-Id: Ib4007e...
Benjamin Kott
06:46 Revision 07184bbf: [BUGFIX] Ensure TypoScript creation cards share same height
Resolves: #100531
Releases: main
Change-Id: I7bed93133978fd15e6e1efb36205b6e116f75461
Reviewed-on: https://review.typ...
Benjamin Kott

2023-04-07

13:54 Revision 8f335d72: [TASK] Adjust CSS compiling to keep breaks in results
Today we are dropping the removal of breaks in compiled CSS.
This will hopefully make the need for rebasing of CSS p...
Benjamin Kott
13:40 Revision 87627c9c: [BUGFIX] Correct treelist-renderings
This is the first step to correct the CSS list-tree. Even it is
documented in the style guide extension it was manage...
Benjamin Kott
13:24 Revision a3744be4: [BUGFIX] Correct rendering of radios in formengine
Resolves: #100528
Releases: main
Change-Id: I1d15e3d74de7fbb9bec4c8e99e2e0af90f996ce7
Reviewed-on: https://review.typ...
Benjamin Kott
12:58 Revision 39f58c13: [TASK] Slightly improve belog rendering
We are introducing new table columns for avatar, time and datetime
in preparation for more adoptions. The avatar colu...
Benjamin Kott
11:48 Revision 927db384: [TASK] Update Browserslist DB
We are updating the browserlist to ensure we are
not shipping unnecessary polyfills.
npx update-browserslist-db@late...
Benjamin Kott
11:48 Revision fe8e7cda: [BUGFIX] Fix undefined array key warnings in DatabaseIntegrityController
Since #99739 the TCA types select, radio and check use associative
array keys for their items.
In ext:lowlevel Datab...
Torben Hansen
11:44 Revision 9040901c: [BUGFIX] Migrate select items in NewMultiplePagesController
Resolves: #100489
Related: #99739
Releases: main
Change-Id: I83b9632156d8f061ab3f0b710eb3639c95fb03b3
Reviewed-on: ht...
Nikita Hovratov
11:42 Revision 237bda89: [TASK] Slightly improve database reference index error rendering
Reference index errors are now rendered as a list.
Resolves: #100509
Releases: main
Change-Id: I8e46ea6e480172891a64...
Oliver Bartsch
11:40 Revision 87312215: [TASK] Improve some type annotations in DB-upgrade-related classes
This is a pre-patch to a bugfix.
Resolves: #100491
Related: #100428
Releases: main
Change-Id: I981f4f465ebacacdceaed...
Oliver Klee
11:25 Revision 111c7a31: [TASK] Avoid extending other test classes
Test classes (*.Test.php) should not extend
each other. If really needed, they can rely
on abstracts (Abstract*TestCa...
Christian Kuhn

2023-04-06

20:20 Revision 216607be: [BUGFIX] Avoid unnecessary nesting in typo3-backend-switch-user
The web component should behave like a button, there is no need
to have another button nested inside.
Resolves: #100...
Benjamin Kott
20:09 Revision 918d0b41: [TASK] Adjust attributes of ColumnSelectorButton
This replaces usage of native attributes for
custom properties to avoid unintended side
effects.
Resolves: #100474
R...
Oliver Bartsch
19:01 Revision 4c8950f7: [BUGFIX] Fix PagesWithoutDescriptionDataProvider
Add the fields "perms_user" and "perms_group"
to the custom database query, since they are
required by calcPerms() to...
Oliver Bartsch
18:47 Revision 81b808ec: [TASK] Clean up fixCopyAfterDuplFields
Rarely used fixCopyAfterDuplFields method in
DataHandler is cleaned up, since a couple of
arguments and options do no...
Oliver Bartsch
18:01 Revision 4c6f1abc: [BUGFIX] Prevent undefined array key in TypolinkSoftReferenceParser
Due to an invalid page link, e.g. "t3://page?type=123",
the "pageuid" key might not be set by PageLinkHandler.
This ...
Oliver Bartsch
18:01 Revision b1c5c8b0: [BUGFIX] Prevent undefined array key in TypolinkSoftReferenceParser
Due to an invalid page link, e.g. "t3://page?type=123",
the "pageuid" key might not be set by PageLinkHandler.
This ...
Oliver Bartsch
17:56 Revision 1086dd8b: [DOCS] Correct example for LoginAttemptFailedEvent in changelog
Resolves: #100522
Related: #100278
Releases: main
Change-Id: I81fd92941ca87935f8a8c273a32692bf820fc63c
Reviewed-on: h...
Chris Müller
13:52 Revision 1c03ee12: [BUGFIX] Correct spacing in CSP configuration status callout
Resolves: #100501
Releases: main
Change-Id: I70f8de84b5caa7ca733b34fc25d9a65f29dba389
Reviewed-on: https://review.typ...
Benjamin Kott
13:39 Revision 0e7c1f35: [BUGFIX] Fix `fileFolderPermissions` section for backend user comparison
With #99739, associated array keys for TCA items were introduced.
Unfortunately this introduced a regression in the "...
Andreas Fernandez
12:16 Revision 3dd59ee5: [TASK] Raise typo3/testing-framework
typo3/testing-framework:dev-main now got
the most important patches for phpunit 10
compatibility. This needs to be ra...
Christian Kuhn
11:49 Revision 15e19a17: [BUGFIX] Add missing table-fit wrapper around table in upgrade wizards
Resolves: #100497
Releases: main
Change-Id: I378c7bfa1964993dd4a8a9d09caf9c3b2bf70412
Reviewed-on: https://review.typ...
Benjamin Kott
11:46 Revision 1c34a1e2: [TASK] Migrate `typo3-extensionmanager-distribution-image` to Lit
To get rid of much boilerplate code, the custom component
`typo3-extensionmanager-distribution-image` used to render ...
Andreas Fernandez
11:46 Revision d311af34: [TASK] Drop unused .typo3-app-icon
Resolves: #100498
Releases: main
Change-Id: I954beb5d1e026bc0abbb54acbf46c05fbc8f65bb
Reviewed-on: https://review.typ...
Benjamin Kott
11:38 Revision f288ef9b: [TASK] Mark all Qom classes and interfaces internal
Some of these classes have been marked @internal
already. Extending / changing this area of the
extbase framework sho...
Alexander Schnitzler
11:07 Revision f6b4c28b: [BUGFIX] Fix CSP violation in extension manager
The Extension Manager module for distributions attempts to load
resources from a 3rd party resource (extensions.typo3...
Andreas Fernandez
11:06 Revision e3296d14: [TASK] Slightly improve database relation check rendering
We are now rendering the result as a list instead of a single
text blob divided by line breaks and adding a highlight...
Benjamin Kott
10:45 Revision 579d89e4: [TASK] Run deprecated functional tests with phpunit 10
Functional deprecated tests are quite easy to fix
for phpunit 10: Just some static data providers.
We do the same as...
Christian Kuhn
10:09 Revision a56ff07c: [BUGFIX] Cast site identifier to string in MigrateSiteSettingsConfigUpdate
Using typecast, we now properly ensure, the site
identifier is always a string, even if it only consists
of digits.
...
Oliver Bartsch
09:50 Revision e25d6b46: [TASK] Run deprecated unit tests with phpunit 10
Unit deprecated tests are quite easy to fix
for phpunit 10: Just static data providers
and a single broken test case ...
Christian Kuhn
09:28 Revision 697abc5e: [TASK] Update outdated xdebug info in runTests.sh
Casual local systems should have young enough
docker and docker-compose versions meanwhile,
and PHP 8.2 runs with xde...
Christian Kuhn
08:15 Revision d869e957: [TASK] Adjust possible dbms versions in `Build/Scripts/runTests.sh`
This changed adjusts the `Build/Scripts/runTests.sh` support for the
different database types and versions. That mean...
Stefan Bürk
08:15 Revision a6a1e8bd: [TASK] Adjust possible dbms versions in `Build/Scripts/runTests.sh`
This changed adjusts the `Build/Scripts/runTests.sh` support for the
different database types and versions. That mean...
Stefan Bürk
08:14 Revision 3ae3bcac: [TASK] Adjust possible dbms versions in `Build/Scripts/runTests.sh`
This changed adjusts the `Build/Scripts/runTests.sh` support for the
different database types and versions. That mean...
Stefan Bürk
07:53 Revision 5743c855: [BUGFIX] Add external media CSP declarations to frontend scope
Previously external media CSP declarations (e.g. to embed YouTube
or Vimeo assets in an iframe) was only applied to t...
Oliver Hader
07:51 Revision fa4da12b: [BUGFIX] Add frontend preview URL to CSP frame-src directive
Add the URL of the page to be shown in web > view backend module to
the `frame-src` directive of the Content-Security...
Oliver Hader
07:44 Revision 86c06d3f: [BUGFIX] Do not use native attributes in typo3-notification-message
The title attribute is a native global attribute.
Using it as a property could have unintended side-effects.
Resolve...
Benjamin Kott
07:40 Revision adfafabd: [BUGFIX] Drop input-group-btn usages if possible
The class input-group-btn was removed in bootstrap 4.6, we are now
dropping leftover usages. There is still a leftove...
Benjamin Kott
07:07 Revision ff06c7f6: [TASK] Deprecate various functionality in legacy tree implementations
This patch deprecates all old-style tree views
that have been in use for over 15 years now without
larger refactoring...
Benni Mack

2023-04-05

21:47 Revision 63c3e5f7: [TASK] Enable functionals with phpunit 10 in parallel to 9
This is a temporary, a bit hacky solution to
run the functional tests with phpunit 10 next
to phpunit 9 for now. Goal...
Christian Kuhn
21:14 Revision 986bbc73: [TASK] Make internal Fluid classes strict
Resolves: #100373
Releases: main
Change-Id: I26b0a7a888d99a4bba6d9cc77184bff6589edab8
Reviewed-on: https://review.typ...
Oliver Klee
20:41 Revision 91e7b274: [TASK] Build response in tests using factories
Some tests created response objects the wrong way
by hand. This change now uses the known factories
to build them cor...
Stefan Bürk
19:28 Revision d92756aa: [TASK] Improve WebhookExecutionTest
This test case of ext:webhooks is a bit weird.
The patch relaxes this a bit: Extending a
ext:core abstract is avoide...
Christian Kuhn
18:48 Revision 4b8502dd: [TASK] Rename AbstractEnhancerSiteRequestTest
phpunit 10 expects classes that end with "Test"
to not be abstract.
Resolves: #100484
Related: #100249
Releases: mai...
Christian Kuhn
18:47 Revision c1765283: [TASK] Rename AbstractCommandTest
phpunit 10 expects classes that end with "Test"
to not be abstract.
Resolves: #100486
Related: #100249
Releases: mai...
Christian Kuhn
18:47 Revision d65766bd: [TASK] Rename FolderStructureTestCase
Should be AbstractFolderStructureTestCase.
Resolves: #100485
Related: #100249
Releases: main
Change-Id: I09b59fdf6a1...
Christian Kuhn
18:47 Revision 8f2f3b5c: [TASK] Rename AbstractXmlSitemapPagesTest
phpunit 10 expects classes that end with "Test"
to not be abstract.
Resolves: #100483
Related: #100249
Releases: mai...
Christian Kuhn
18:46 Revision bab9b8cd: [TASK] Avoid invalid method ValidatorResolverTest
"dummy" is not a valid method in the mocked class.
Resolves: #100482
Related: #100249
Releases: main
Change-Id: Ic0c...
Christian Kuhn
17:05 Revision c9017160: [TASK] Avoid invalid methods in ImportExportUtilityTest
Method "dummy" can not be mocked since it does
not exist. Change to "don't mock anything" by
using 'null' as argument...
Christian Kuhn
17:05 Revision 7f44d966: [TASK] Extract callbacks from TypoScriptFrontendControllerTest
TypoScriptFrontendControllerTest uses itself as
callback for USER and USER_INT functions. This
does not work anymore ...
Christian Kuhn
17:04 Revision a6497590: [TASK] Avoid withConsecutive() in FlexFormToolsTest
The tests should be refactored towards proper
database fixtures, but for now, we get rid of
withConsecutive().
Resol...
Christian Kuhn
17:04 Revision 741daac4: [TASK] Avoid withConsecutive() in FileBackendTest
Resolves: #100480
Related: #100249
Releases: main
Change-Id: I256b6f6a8eae577033207df980c1b607d4226dae
Reviewed-on: h...
Christian Kuhn
16:37 Revision aea4ac86: [TASK] Avoid invalid methods in TranslationServiceTest
TranslationServiceTest tries to mock some methods
that don't exist. Solving this reveals the test
subject contains in...
Christian Kuhn
15:23 Revision 190b946f: [TASK] Remove BackendModuleControllerTest
This test is tricky since the subject triggers
session_save_path() which is limited to one
call per php process and e...
Christian Kuhn
15:10 Revision 6daa9da7: [TASK] Deprecate TypoScript config.xhtmlDoctype
The "new" property config.doctype has been introduced in TYPO3 v6
and should be used now.
It's time to unify all of ...
Benni Mack
15:10 Revision 734f9402: [TASK] Drop pointless checks in GridDataService
This change fixes most of the remaining PHPStan warnings
in this class.
Resolves: #97409
Releases: main
Change-Id: I...
Oliver Klee
14:40 Revision 786d99c7: [TASK] Have static DP in ExpressionBuilderTest
Resolves: #100470
Related: #100249
Releases: main
Change-Id: Ia42e379ea1b29408e6bec4820a62190605660c42
Reviewed-on: h...
Christian Kuhn
14:39 Revision bcc75f01: [TASK] Have static DP in RequestHandlingTest
Avoid a useless abstract with an invalid
class name, and make the data providers
in this test case static.
Resolves:...
Christian Kuhn
14:30 Revision 0b3e9d6a: [BUGFIX] Avoid unnecessary nesting in typo3-mfa-totp-url-info-button
The web component should behave like a button, there is no need
to have another button nested inside. In addition we ...
Benjamin Kott
13:34 Revision 069b5a38: [BUGFIX] Remove invalid attributes on icon component usages
The css classes icon and icon-size-small are unnessesary since the
size property already sets and uses the correct in...
Benjamin Kott
13:32 Revision 9f49f87d: [TASK] Avoid DP with arguments
phpunit 10 mumbles when test data provider
methods have arguments. This is used in
SiteHandling functional tests vari...
Christian Kuhn
12:38 Revision 8bb9bed9: [BUGFIX] Correct drag/drop preview position in firefox
Firefox does not update the cursor position on the drag event.
To workaround this issue we are moving the preview upd...
Benjamin Kott
12:17 Revision 5fe67e8b: [TASK] Deprecate BackendUtility::getRecordToolTip()
This method is just a wrapper for a title=""
attribute and is very inflexible. Thus, it is marked
as deprecated.
Res...
Benni Mack
12:14 Revision 6bf5158d: [DOCS] Link to online manual for beuser,extensionmanager,setup
Resolves: #100457
Releases: main
Change-Id: Ifa947d33af06b92486220b20afb57354870f0393
Reviewed-on: https://review.typ...
Christian Weiske
08:36 Revision 1dc7be61: [TASK] Have more static DP in SiteHandling tests
Solves simple cases: Make some helper methods
static, call them statically, and declace
consuming data providers stat...
Christian Kuhn
08:24 Revision f8d77257: [TASK] Have static DP in BrokenLinkRepositoryTest
Clean up and simplify a bit along the way.
Resolves: #100450
Related: #100249
Releases: main
Change-Id: I0f808487226...
Christian Kuhn
07:24 Revision 81ba4155: [TASK] Update Codemirror and streamline colors
npm i --save \
@codemirror/autocomplete@^6.4.2 \
@codemirror/commands@^6.2.2 \
@codemirror/lang-css@^6.1....
Benjamin Kott
07:17 Revision d3b3c062: [TASK] Deprecate methods in PasswordChangeEvent in ext:felogin
The `PasswordChangeEvent` used in `notifyPasswordChange´ should
not be used to validate user passwords, since it is n...
Torben Hansen
05:56 Revision 7a6d1ecb: [TASK] Raise 'phpstan/phpstan' and regenerate baseline file
PHPStan recenently released a new patchlevel version,
fixing the one or other bug and changing the reported
issue mes...
Stefan Bürk
05:55 Revision e64a1d1f: [TASK] Raise 'phpstan/phpstan' and regenerate baseline file
PHPStan recenently released a new patchlevel version,
fixing the one or other bug and changing the reported
issue mes...
Stefan Bürk
02:20 Revision 54fa1607: [TASK] Have static DP in RedirectRepositoryTest
Make a helper method static to allow
a static data provider.
Resolves: #100449
Related: #100249
Releases: main
Chang...
Christian Kuhn
02:18 Revision 51389c0a: [TASK] Have static DP in ReactionsRepositoryTest
Avoid a useless helper method by having
object creation within data provider
directly.
Resolves: #100448
Related: #1...
Christian Kuhn
02:15 Revision 5ade650b: [TASK] Have static DP in DatabaseIntegrityControllerTest
Use reflection instead of a mock in this
functional test data provider to create
data sets.
Resolves: #100447
Relate...
Christian Kuhn

2023-04-04

19:43 Revision 3806ee52: [TASK] Temporarily add phpunit 10 unit tests
Unit tests with phpunit 10 are green for now.
We temporarily add them to the CI test suite
to ensure they don't break...
Christian Kuhn
18:31 Revision 6da592d2: [TASK] Add initiator to <f:sanitize.html> view helper invocation
With this update, whenever the `<f:sanitize.html>` view helper is
invoked, the initiator reference will be included i...
Oliver Hader
18:31 Revision bb160bed: [TASK] Add initiator to <f:sanitize.html> view helper invocation
With this update, whenever the `<f:sanitize.html>` view helper is
invoked, the initiator reference will be included i...
Oliver Hader
18:22 Revision f0e2c3f5: [TASK] Avoid setAccessible()
setAccessible() in reflection is a no-op
since PHP 8.1. It can be removed.
Resolves: #100444
Releases: main
Change-I...
Christian Kuhn
17:23 Revision b2aa4c26: [TASK] Avoid withConsecutive() in SlugHelperTest
Resolves: #100442
Related: #100249
Releases: main
Change-Id: I5b9c5f90d2a7688f5808513df618219b4eb14bf4
Reviewed-on: h...
Christian Kuhn
17:22 Revision 2b2951b9: [TASK] Avoid withConsecutive() in Typo3DatabaseBackendTest
Resolves: #100443
Related: #100249
Releases: main
Change-Id: Iedc841419942629dc9261f190f221b6575285254
Reviewed-on: h...
Christian Kuhn
17:22 Revision a03263b6: [TASK] Avoid withConsecutive() in ExpressionBuilderTest
Pretty straight substitution as done with
similar phpunit 10 compatibility patches.
Resolves: #100441
Related: #1002...
Christian Kuhn
16:01 Revision 962eeb24: [BUGFIX] Fix invalid array access in ImageManipulation/Ratio
This also allows automated testing with a minimal data.
Resolves: #100430
Related: #100249
Releases: main, 11.5
Chan...
Oliver Klee
16:01 Revision aad44d89: [BUGFIX] Fix invalid array access in ImageManipulation/Ratio
This also allows automated testing with a minimal data.
Resolves: #100430
Related: #100249
Releases: main, 11.5
Chan...
Oliver Klee
16:00 Revision be6d0869: [BUGFIX] Fix invalid array access in Mail\TransportFactory
Even for a broken/imcomplete configuration, we want to have the
exception that complains about the incomplete configu...
Oliver Klee
16:00 Revision eae684fe: [BUGFIX] Fix invalid array access in Mail\TransportFactory
Even for a broken/imcomplete configuration, we want to have the
exception that complains about the incomplete configu...
Oliver Klee
15:57 Revision a6d7dfb2: [TASK] Remove unused property in DeleteRecords model in ext:recycler
This change removes an unused property in `DeleteRecords` domain model
in ext:recycler
Resolves: #100440
Releases: m...
Torben Hansen
14:47 Revision 4b100f0c: [TASK] Avoid withConsecutive() in QueryBuilderTest
Resolves: #100436
Related: #100249
Releases: main
Change-Id: Id3c6d93080cffd2652013b1a4f2d5bbcf0f34346
Reviewed-on: h...
Christian Kuhn
13:39 Revision 4518a1f4: [BUGFIX] Ensure translate ViewHelper uses site language locale
When using the `<f:translate>` ViewHelper out of Extbase
context (e.g., in `FLUIDTEMPLATE` or `StandaloneView`),
TYPO...
Benni Mack
13:31 Revision 572e6df5: [TASK] Centralize reactions and webhooks management
To centralize workflows, reaction and webhook
records should only be managed in their dedicated
backend module.
Reso...
Oliver Bartsch
11:29 Revision b2307e60: [TASK] Drop superfluous codeMirror label from FormEngine elements
The classes `T3editorElement` and `JsonElement` boot a CodeMirror
instance and provides a hard-coded label to be rend...
Andreas Fernandez
10:46 Revision 167abe0b: [TASK] Improve type annotations for ImageManipulation\Ratio
Resolves: #100432
Releases: main
Change-Id: I1c037a5b177dbd1f0124e493b26e4ad6f3dc04d8
Reviewed-on: https://review.typ...
Oliver Klee
09:29 Revision de679a7e: [TASK] Avoid withConsecutive() in ServiceProviderRegistryTest
The two mocked methods are not called by the
test subject - probably due to an earlier
refactoring regarding package ...
Christian Kuhn
09:29 Revision 970f9177: [TASK] Avoid withConsecutive() in ConsoleCommandPassTest
The two mocked methods are not called by the
test subject - probably due to an earlier
refactoring regarding package ...
Christian Kuhn
09:10 Revision 573ffbfd: [BUGFIX] Fix "undefined" item title in paste/cut confirmation
The options passed to the Paste module through
PageLayoutController are all present in the first
argument, not three ...
Andreas Nedbal
09:03 Revision dde27dcc: [BUGFIX] Migrate Site TCA Configuration
Until now, the TCA for Site Configuration was never migrated by the
TcaMigrator. With the massive amount of TCA depre...
Nikita Hovratov
08:12 Revision 91b0b433: [TASK] Drop handling for non existent contentNavigationSwitcher
The handling was introduced in [1] to have a resizable navigation area.
With the introduction of a generalized Lit co...
Benjamin Kott
08:06 Revision 0dbce7fd: [TASK] Update CKEditor packages to 36.0.1
Used command:
cd Build/
npm i --save-dev \
@types/ckeditor__ckeditor5-utils@^28.0.15
npm i --save \
@ckedit...
Benjamin Kott
07:38 Revision 63896b1d: [TASK] Bind CodeMirror theme to prefers-color-scheme
With the upgrade to CodeMirror 6, the dark theme is enforced, which may
have a negative impact on UX as this stresses...
Andreas Fernandez
07:27 Revision aff27c25: [TASK] Avoid withConsecutive() in FrontendConfigurationManagerTest
Straight refactoring avoiding withConsecutive().
Resolves: #100421
Related: #100249
Releases: main
Change-Id: Iabd2d...
Christian Kuhn
07:26 Revision 9ad7aeba: [TASK] Avoid invalid methods in DependencyUtilityTest
Method getLowestAndHighestIntegerVersions() does not
exist and should not be mocked.
Resolves: #100418
Related: #100...
Christian Kuhn
07:26 Revision c412b768: [TASK] Avoid withConsecutive() in FloatConverterTest
Resolves: #100419
Related: #100249
Releases: main
Change-Id: Ic969120244be3b4ee53c873d788ce9c07d3a8f72
Reviewed-on: h...
Christian Kuhn
07:25 Revision e8a8ea9e: [TASK] Avoid invalid argument in FolderLinkHandlerTest
Resolves: #100423
Related: #100249
Releases: main
Change-Id: Iffffb0d01e96c01e40ac8c4955a4ffa09f1199d8
Reviewed-on: h...
Christian Kuhn
07:25 Revision cf96bb08: [TASK] Avoid setMethods() in ExtractorServiceTest
Use onlyMethods() instead. Also, setAccessible()
is obsolete since PHP 8.1.
Resolves: #100422
Related: #100249
Relea...
Christian Kuhn
07:24 Revision d23770f9: [TASK] Streamline InstallUtilityTest
Avoid mocking not existing methods in one
test. Remove two other tests that mock so
much that it's very hard to under...
Christian Kuhn
07:23 Revision 93d12a18: [TASK] Avoid invalid method in DataMapFactoryTest
Resolves: #100420
Related: #100249
Releases: main
Change-Id: Ib5b3fc4bbf9f8e9f13fddfabdce3cba7a2df7591
Reviewed-on: h...
Christian Kuhn
07:23 Revision 9d5c76db: [TASK] Avoid withConsecutive() in ContentObjectRendererTest
Rewriting the tests to mock less makes them
better readable and far easier to grasp.
Resolves: #100414
Related: #100...
Christian Kuhn
07:19 Revision 903212c6: [TASK] Avoid withConsecutive() in SaveToDatabaseFinisherTest
Testing for the input keys is rather useless, it's
enough to verify the sub method is called twice.
Resolves: #10041...
Christian Kuhn
07:18 Revision 90d02c7c: [TASK] Avoid invalid methods in FormDefinitionValidationServiceTest
The tests try to configure method mocks that don't
exist. The patch adapts the tests accordingly. They
should receive...
Christian Kuhn
05:41 Revision 95927dff: [BUGFIX] Fix resolving of page record titles in Clipboard
This caused page titles in copy/cut functionality to not
be resolved and instead display the site title as a fallback...
Andreas Nedbal

2023-04-03

23:05 Revision 74a4698b: [BUGFIX] Fix resolving of page record titles in Clipboard
This caused page titles in copy/cut functionality to not
be resolved and instead display the site title as a fallback...
Andreas Nedbal
15:30 Revision 515052d9: [TASK] Remove some superfluous is_object()- and null-checks
Remove some superfluous checks for is_object(), null and
similar in conditions, where subsequent conditions already
c...
Christian Eßl
14:46 Revision 29319fd2: [TASK] Avoid withConsecutive() in RequestHandlerTest
Even though the RequestHandlerTest unit tests
are an aweful mocking party, we can't simply
throw them away since the ...
Christian Kuhn
14:45 Revision 9fff0613: [TASK] Remove AbstractPluginTest
AbstractPlugin ("Pi1" FE plugins) has been
marked as "not maintained anymore" a while
ago.
The unit tests are a heav...
Christian Kuhn
14:45 Revision 00a811b5: [TASK] Avoid using GeneralUtility::makeInstance in tests
Replace `GeneralUtility::makeInstance` with `new` statement.
Resolves: #100411
Releases: main
Change-Id: I340212fb7b...
Oliver Hader
14:43 Revision 60c0f4c3: [BUGFIX] Fix copying folders in filelist
Internally, the clipboard class only knows of the identifier
"_FILE", which is used for copying both files and folder...
Christian Eßl
13:26 Revision 53e2e8e0: [TASK] Have SilentConfigurationUpgradeServiceTest functionals
Turns existing unit tests into functionals, making
them more concise, avoids mocking parties, and
makes them better m...
Christian Kuhn
13:19 Revision d4bd9def: [TASK] Avoid superfluous SQL query in ContentObjectRenderer
Don't check accessibility to current page and if its
content should be rendered twice. This is already done
in the Ty...
Christoph Lehmann
10:33 Revision fe579e23: [BUGFIX] Remove visual gap from hidden CEs on page module
Hidden content elements are still present in the document flow
but just have a height of 0 causing the uniform spacin...
Andreas Nedbal
10:02 Revision d963c5ca: [TASK] Turn ActionControllerTest into functionals
Avoids phpunit 10 deprecation and failures
and allows minor modifications of ActionController.
Resolves: #100400
Rel...
Christian Kuhn
09:46 Revision 3c2ebf11: [TASK] Avoid withConsecutive() in OpenDocumentServiceTest
Resolves: #100403
Related: #100249
Releases: main
Change-Id: Iaec3d23b6fdfb70698f3715f7724915d8e7152d1
Reviewed-on: h...
Christian Kuhn
09:42 Revision 70fdcf13: [TASK] Make EvaluateDisplayConditionsTest phpunit 10 compatible
Using the test class as fixture is problematic
since the constructor changes in phpunit 10.
Resolves: #100402
Relate...
Christian Kuhn
09:11 Revision 46957ac3: [TASK] Make GeneralUtilityTest phpunit 10 compatible
Using the test class as fixture is problematic
since the constructor changes in phpunit 10.
Refactor this and clean u...
Christian Kuhn
08:54 Revision ad4ffca6: [BUGFIX] Avoid error for orphaned ts templates
When a page containing a typoscript template has been
deleted, there won't be a valid rootline for the template.
Add ...
Christian Eßl
07:55 Revision 0f5ecfc6: [TASK] Have static DP in PlatformInformationTest
Resolves: #100397
Related: #100249
Releases: main
Change-Id: I5578b8fbd76e198d91c2aad5421e715957981f94
Reviewed-on: h...
Christian Kuhn

2023-04-02

15:20 Revision f2eaaa9d: [DOCS] Revise changelogs for v12.3
Resolves: #100333
Releases: main
Change-Id: I6b9a36758b66748d4c2e092e5390d5bcc3ead8b6
Reviewed-on: https://review.typ...
Chris Müller
13:47 Revision 66e6210e: [TASK] Have static DP in StreamTest
Clean up and simplify a bit along the way.
Resolves: #100396
Related: #100249
Releases: main
Change-Id: I821c2c8e19a...
Christian Kuhn
13:44 Revision 18428fd5: [TASK] Public DP in DateFormatterTest
Resolves: #100395
Related: #100249
Releases: main
Change-Id: Ida96df615efdeab4f735057a1ff597f7d7a280fe
Reviewed-on: h...
Christian Kuhn
13:43 Revision d6e34508: [TASK] Have static DP in VimeoHelperTest
Clean up a bit along the way.
Resolves: #100394
Related: #100249
Releases: main
Change-Id: I4a9395f5f96f129b3673dfbf...
Christian Kuhn
13:41 Revision a8c4c699: [TASK] Have static DP in VariableProcessorTest
Resolves: #100393
Related: #100249
Releases: main
Change-Id: I039a5cc5e8473c7c9a4e6f2bced053a76358eb05
Reviewed-on: h...
Christian Kuhn
13:39 Revision f07ae827: [TASK] Have static DP in RouteSorterTest
Resolves: #100391
Related: #100249
Releases: main
Change-Id: I1a211e4ef2de29dcae78e1f3bed843875afd7378
Reviewed-on: h...
Christian Kuhn
13:38 Revision 6709cdaf: [TASK] Have static DP in MathUtilityTest
Resolves: #100390
Related: #100249
Releases: main
Change-Id: Ibb5d43f161b00069b0dbf30219e993e472e62951
Reviewed-on: h...
Christian Kuhn
13:37 Revision fb0ea106: [TASK] Have static DP in CacheHashConfigurationTest
Resolves: #100386
Related: #100249
Releases: main
Change-Id: Ieacbbba12fb6da2ce4a1d150ea1022689fa10294
Reviewed-on: h...
Christian Kuhn
13:35 Revision dae4f2e4: [TASK] Turn CleanerFieldProviderTest into funcional test
Avoid a mocking party, static data providers,
move another test to proper namespace.
Resolves: #100385
Related: #100...
Christian Kuhn
13:33 Revision 3a6fade5: [TASK] Have static DP in ArrayConverterTest
Clean up a bit along the way.
Resolves: #100388
Related: #100249
Releases: main
Change-Id: I0867d9f77df2a3dcd505291a...
Christian Kuhn
13:30 Revision a96af51f: [TASK] Have static DP in PropertyMappingConfigurationTest
Split the offending data provider to avoid
creating mocks within it. Clean up along
the way a bit.
Resolves: #100389...
Christian Kuhn
13:27 Revision afc0034c: [TASK] Have static DP in ContentObjectRendererTest
Clean up a bit along the way and avoid
a useless trait.
Resolves: #100387
Related: #100249
Releases: main
Change-Id:...
Christian Kuhn
13:24 Revision 802504d6: [TASK] Split a non-static data provider
Splitting the data provider that uses $this
to create mocks into single tests is the
easiest solution, even though it...
Christian Kuhn
08:40 Revision 952c6482: [BUGFIX] Prevent undefined array key in BackendUtility
Resolves: #100379
Releases: main, 11.5
Change-Id: If772e0ba8d2d10a9aeb86af519c1c4f05c0ef3b4
Reviewed-on: https://revi...
Andreas Nedbal
08:40 Revision 4f418d96: [BUGFIX] Prevent undefined array key in BackendUtility
Resolves: #100379
Releases: main, 11.5
Change-Id: If772e0ba8d2d10a9aeb86af519c1c4f05c0ef3b4
Reviewed-on: https://revi...
Andreas Nedbal

2023-03-30

19:33 Revision 62231ce8: [BUGFIX] Allow DI for OnlineMediaController
Currently an error is thrown when trying to create
a online media resource.
This has been fixed by adding the contro...
Jochen Roth
15:10 Revision 409a6ae5: [BUGFIX] Support @import 'EXT:.../TypoScript/*.setup.typoscript'
While a pattern like "@import 'EXT:.../TypoScript/*.typoscript'"
works already, "@import 'EXT:.../TypoScript/*.setup....
Christian Kuhn
08:32 Revision 2a05c32c: [BUGFIX] Drop obsolete `table-wizard` module
The FormEngine JavaScript module `table-wizard` became obsolete with
ticket #95036 and was forgotten to be removed, w...
Andreas Fernandez
08:21 Revision 38696af7: [BUGFIX] Drop obsolete `table-wizard` module
The FormEngine JavaScript module `table-wizard` became obsolete with
ticket #95036 and was forgotten to be removed, w...
Andreas Fernandez

2023-03-29

18:41 Revision d344bc25: [TASK] Update PHP dependencies
This change updates the main TYPO3 code base
vendor/ directory to lock to latest packages
from our main dependencies,...
Wouter Wolters
18:41 Revision faba93a7: [TASK] Update PHP dependencies
This change updates the main TYPO3 code base
vendor/ directory to lock to latest packages
from our main dependencies,...
Wouter Wolters
18:19 Revision 96a6d694: [BUGFIX] ckeditor: propagate changes in editor document
If the document model in a ckeditor instance is changed, the changes are
now immediately written back to the related ...
Andreas Fernandez
18:12 Revision 5d0be3fe: [TASK] Make internal Extbase classes strict
Resolves: #100346
Releases: main
Change-Id: Ib9f9113400bb69aee6e36f58596a98e1c7d0ac9f
Reviewed-on: https://review.typ...
Oliver Klee
18:11 Revision 1ee7cda2: [TASK] Do not accept empty password in backend password reset
If the global password policy has been disabled and the backend
password function is used, it is possible to submit a...
Torben Hansen
18:09 Revision 82f258e4: [BUGFIX] Check if requested start module is registered before resolution
The change in #100342 was not complete and might lead to exceptions
when a regular route name not matching a module i...
Andreas Fernandez
17:52 Revision 6648d881: [BUGFIX] Use document language for flatpickr
FormEngine's date picker now uses the document's HTML `lang`
attribute to determine its language to use.
Resolves: #...
Andreas Fernandez
17:12 Revision 68c48ef4: [BUGFIX] Fix some incorrect types in Extbase
Add some type casts that are necessary in order to make the internal
Extbase classes strict.
Also complete some inco...
Oliver Klee
16:30 Revision ad298045: [BUGFIX] Handle potentially aliased start module
If BE_USER->uc['startModule'] is a "legacy" alias value, resolving the
start module in the BackendController fails, l...
Andreas Fernandez
15:33 Revision 3eddc810: [TASK] Deprecate loginUser() and usergroup() conditions
The two TypoScript related condition functions
"loginUser()" and "usergroup()" are rather old
school and suffer from ...
Christian Kuhn
15:15 Revision 17fde56d: [BUGFIX] Date ViewHelper should use strftime() method
When having a % in the format,
the strftime() method should be used
from the DateFormatter.
Resolves: #100350
Relate...
Benni Mack
14:34 Revision 47cfbaa0: [TASK] Improve performance of FileStorageTreeProvider
Improve the performance of FileStorageTreeProvider significantly by
avoiding fetching the parent and children folders...
Christian Eßl
11:08 Revision 4ff01734: [BUGFIX] Apply overflow to not cut off FormEngine wizards
Within `.form-group`, the elements `.panel` and `.panel-group` get a
visible overflow applied to not cut off FormEngi...
Andreas Fernandez
10:55 Revision eafa0dd9: [BUGFIX] Apply overflow to not cut off FormEngine wizards
Within `.form-group`, the elements `.panel` and `.panel-group` get a
visible overflow applied to not cut off FormEngi...
Andreas Fernandez
09:32 Revision 6bb5af7e: [TASK] Let DataMapper::createEmptyObject() use doctrine/instantiator
During the removal of the ObjectManager (Extbase), the way the
DataMapper instantiates entities when thawing objects,...
Alexander Schnitzler
09:31 Revision 2ac40774: [TASK] Remove duplicate label for "Language"
Only the table "tt_content" overrides the label for the sys_language_uid
field on palette level with
"EXT:frontend/.....
Nikita Hovratov
07:45 Revision 4e36a500: [TASK] Change order of backend modules in Site Management
The redirects backend module should have precedence before the
Page TSConfig and the TypoScript module.
Resolves: #1...
Peter Kraume
07:09 Revision 65e771eb: [BUGFIX] Only set Content-Type charset if no charset is given
When using TYPO3 as a response for multipart
result or application/binary responses,
TSFE should not append "charset=...
Benni Mack

2023-03-28

15:24 Revision 9de94565: [TASK] Fix typo in the EXT:seo documentation
Releases: main, 11.5
Resolves: #100339
Change-Id: I4b24fdced525703367da88981d8d9996e14fda9f
Reviewed-on: https://revi...
Josef Glatz
15:24 Revision 47ea7d4e: [TASK] Fix typo in the EXT:seo documentation
Releases: main, 11.5
Resolves: #100339
Change-Id: I4b24fdced525703367da88981d8d9996e14fda9f
Reviewed-on: https://revi...
Josef Glatz
13:02 Revision e78f1e74: [BUGFIX] Prevent undefined array key in ext lowlevel
There are several checks related to array key
'_CURRENT_VERSION' on versioned records. Since
PHP 8 those checks are n...
Tobias Gaertner
12:57 Revision 5b2918e0: [TASK] Harden array callbacks in EXT:adminpanel
Add type declarations to help static code analysis and to improve
code readability.
Resolves: #100328
Releases: main...
Oliver Klee
12:45 Revision cf6d4185: [BUGFIX] Prevent undefined array key in ext lowlevel
There are several checks related to array key
'_CURRENT_VERSION' on versioned records. Since
PHP 8 those checks are n...
Tobias Gaertner
12:38 Revision 1cc57b1b: [TASK] Harden array callbacks in Build/
- use first-class callables
- add type declarations
Resolves: #100326
Releases: main
Change-Id: I258fb22ea32fe7fe6de...
Oliver Klee
12:37 Revision 4451f6dc: [DOCS] Add PSR-14 events to redirects documentation
Resolves: #100331
Related: #96147
Related: #99746
Related: #99802
Related: #99803
Related: #99834
Releases: main
Chan...
Chris Müller
12:22 Revision bac90eee: [TASK] Deprecate TCA config MM_insert_fields
"True" MM relations (intermediata table with uid_local
and uid_foreign columns, and no TCA for this table) are
still ...
Christian Kuhn
10:48 Revision 83ff9d32: [BUGFIX] Respect "sectionIndex" setting in section menus
The content element "Section index of subpages from selected pages"
now also respects the setting "Show in Section Me...
Sebastian Klein
10:47 Revision 4a2c4745: [BUGFIX] Respect "sectionIndex" setting in section menus
The content element "Section index of subpages from selected pages"
now also respects the setting "Show in Section Me...
Sebastian Klein
10:25 Revision 5f1ff6bc: [TASK] Create changelog for v12.4
Resolves: #100332
Releases: main
Change-Id: I10bf6b31ff0eba3bdce69b0c512836c77a269baf
Reviewed-on: https://review.typ...
Chris Müller
09:33 Revision f78a1c2f: [TASK] styleguide: styleguide uses core dev-main for --dev
Raise from 12.3@dev to 12.4@dev forces dev-main. Christian Kuhn
07:16 Revision dd021d27: [TASK] Set TYPO3 version to 12.4.0-dev
Change-Id: I890274b2574c6af78b9406df0f89557ba7998425
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/782...
Benni Mack
07:06 Revision 6db135f0: [RELEASE] Release of TYPO3 12.3.0
Change-Id: I4ee75d7c8f3c5a24f43fa0c0b04ce0762dfc77c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/782...
Benni Mack
06:02 Revision dc583bbc: [FEATURE] Add CKEditor Inspector for backend RTE forms
This feature adds the CKEditor Inspector to backend RTE forms in
Development context with $GLOBALS['TYPO3_CONF_VARS']...
Andreas Nedbal

2023-03-27

21:44 Revision a0e286a3: [TASK] Static data providers in Tests/Functional
phpunit ^10 expects test data providers to be static.
Using rector rule StaticDataProviderClassMethodRector,
this bu...
Christian Kuhn
20:31 Revision 87ffe14b: [TASK] Change return type of TextDescriptor::describeApplication
To prevent issues when upgrading to Symfony 6.3.x-dev the return type
of TextDescriptor::describeApplication is chang...
Wouter Wolters
20:10 Revision 07491961: [TASK] Provide PSR-14 `RedirectWasHitEvent` as webhook message
With #99629 outgoing webhooks has been implemented. This also
provide a simple way to create custom webhook messages ...
Stefan Bürk
19:43 Revision 6523fd6e: [TASK] Avoid setMethodsExcept() for phpunit 10
setMethodsExcept() on mocks has been removed
with phpunit 10.
There are three usages in one test case, those
can be ...
Christian Kuhn
19:40 Revision c6a1b180: [TASK] Unify spelling of page TSconfig
Some specific TYPO3 terms have a special spelling. Therefore
update the spelling from "PageTsConfig" to "page TSconfi...
Jasmina Ließmann
19:13 Revision 388e66b8: [FEATURE] Add PSR-14 event to enrich password validation ContextData
A new PSR-14 event `EnrichPasswordValidationContextDataEvent` is
introduced to allow extension authors to enrich the ...
Torben Hansen
18:42 Revision 4f94e4f0: [TASK] Use first-class callables in EXT:extensionmanager unit tests
see https://www.php.net/manual/en/functions.first_class_callable_syntax.php
Resolves: #100315
Releases: main
Change-...
Oliver Klee
18:42 Revision e73800f3: [TASK] Use explicit types for `willReturnCallback` in EXT:backend tests
This improves both code readability as well as type safety in the tests.
Resolves: #100313
Releases: main
Change-Id:...
Oliver Klee
18:42 Revision 4475027b: [TASK] Use the proper interface with willReturnCallback in EXT:core tests
- use parameter and return type declarations
- use the same parameter names as in the mocked method
- drop useless `s...
Oliver Klee
18:36 Revision 09ed3ccd: [BUGFIX] Keep rendering of newLanguageSelector with Page+List module in sync
The list module shows the dropdown of possible
translations now in the same automatic width (instead
of the full widt...
Benni Mack
18:35 Revision 30717be4: [TASK] Make ImageDimensionTest phpunit 10 ready
* Static DP
* Avoid withConsecutive() - kinda useless in
this case anyways
* Don't use $this in DP
Resolves: #1003...
Christian Kuhn
18:35 Revision 71e6bb47: [TASK] Rename two test fixture files
phpunit 10 expects files that end with Test.php
to contain tests. Two fixture files are renamed
since phpunit detects...
Christian Kuhn
18:32 Revision 79671ff5: [TASK] Split single ColumnMapFactoryTest test into multiple tests
Releases: main
Resolves: #100283
Change-Id: I9281b4d8b276fda9628a4fbac085ca7b82ebf95f
Reviewed-on: https://review.typ...
Alexander Schnitzler
18:27 Revision f7df5aa3: [FEATURE] Introduce cObject for Extbase plugins
A new TypoScript cObject "EXTBASEPLUGIN" is
added for Extbase plugins to allow
Extbase authors to not reference the E...
Benni Mack
16:45 Revision a4fb013f: [FEATURE] Replace AbstractUserAuth hooks with PSR-14 Events
Two new Events are added
* TYPO3\CMS\Core\Authentication\Event\BeforeUserLogoutEvent
* TYPO3\CMS\Core\Authentication\...
Benni Mack
15:56 Revision 5315e5a7: [FEATURE] AdminPanel: Add SQL and memory metrics to toolbar
This extends the AdminPanel toolbar with more important metrics:
* Peak memory usage
* Amount of SQL queries
* Time ...
Christoph Lehmann
15:56 Revision 23cf13e8: [TASK] Add pagination to LiveSearch
The `SearchRepository` class used in the LiveSearch is now able to
handle pagination, allowing to render a pagination...
Andreas Fernandez
14:53 Revision 238478f5: [FEATURE] Add new redirect `PageTypeSource` source type implementation
It's possible that project instances are configured to use
RouteEnhancers and RouteDecorators, e.g. PageTypeSuffix
Ro...
Stefan Bürk
14:40 Revision 0208c740: [TASK] Rename an abstract test case
Rename AbstractSoftReferenceParserTest to
AbstractSoftReferenceParserTestCase to prevent a
phpunit 10 warning that cl...
Christian Kuhn
14:20 Revision 775073d6: [TASK] Add Content-Security-Policy hash declarations
Add the possibility to extend the Content-Security-Policy model by
cryptographic hashes - which can either be static ...
Oliver Hader
11:56 Revision 3d1a55ba: [BUGFIX] Prevent including tsconfig absolute @import twice
Due to a missing file suffix check, @import for tsconfig was included
twice, while it was looping through the possibl...
Nikita Hovratov
11:40 Revision 67327761: [TASK] Have minor Page TSconfig module improvements
* Submodule drop-down is shown on page 0 as well since
page TSconfig is typically available on page 0 as
well
* R...
Christian Kuhn
10:57 Revision afeaaf45: [FEATURE] Enable password view at the backend login
A user who's about to log in into the backend is now able to reveal the
typed password. Once the password field is cl...
Max Frerichs
10:50 Revision ba49e4ed: [TASK] Introduce ColumnMap\Relation enum
This patch introduces ColumnMap\Relation enum as a
replacement for the former ColumnMap::RELATION_*
class constants.
...
Alexander Schnitzler
10:47 Revision 219b5970: [BUGFIX] Add correct id to "Not assigned to any task group"
The group of "Not assigned to any task group" can not be
collapsed anymore.
This has been fixed by adding the correc...
Jochen Roth
10:38 Revision 187208e3: [BUGFIX] Respect default value for confirmation in ext:install
The default value for a confirmation is currently not respected
in the install tool on UI level and a confirmation di...
Torben Hansen
10:38 Revision 3c2cbbf7: [BUGFIX] Respect default value for confirmation in ext:install
The default value for a confirmation is currently not respected
in the install tool on UI level and a confirmation di...
Torben Hansen
10:30 Revision 37def0d8: [TASK] Modernize array function callbacks in Extbase
- use arrow functions
- make anonymous functions static if possible
- add type declarations
- use first class callabl...
Oliver Klee
09:34 Revision 94bcbf0f: [FEATURE] Introduce Content Security Policy reporting & inspection
An internal csp-violation reporting endpoint is integrated, which
keeps track of potential violations in frontend and...
Oliver Hader
09:33 Revision 631157bf: [TASK] Change wording of "PageTsConfig Records"
As there are no records regarding PageTsConfig,
the wording should be adopted.
Resolves: #100179
Releases: main
Chan...
Georg Ringer
07:34 Revision aced807c: [BUGFIX] Page TSconfig module: Do not list pages twice
Given a page has TSconfig and it is translated, then the translation
is also listed which blow ups the overview unnec...
Christoph Lehmann
05:29 Revision 0166802d: [TASK] Shorten language text for webhooks description
This is a change to ease translation of the existing
texts.
The phrase "for your internal reference" adds little val...
Sybille Peters
05:28 Revision 3773510b: [BUGFIX] Correct signature in ArrayUtility::isValidPath
In #97202 types for the class ArrayUtility were added.
Unfortunately the second parameter ($path) for the method
isVa...
Thomas Hohn

2023-03-26

20:16 Revision 6d7e506c: [BUGFIX] Fix PHP 8 warning in AbstractXmlSitemapDataProvider
Added a null coalescing operator around the access $item['lastMod'].
Resolves: #100280
Releases: main, 11.5
Change-I...
Thomas Hohn
20:15 Revision 73fd3a6c: [TASK] Streamline AssetCollector ViewHelper tests
Just like other ViewHelper tests, the AssetCollector ViewHelper tests
now utilize the RenderingContext and TemplateVi...
Nikita Hovratov
20:04 Revision 77367467: [BUGFIX] Fix PHP 8 warning in AbstractXmlSitemapDataProvider
Added a null coalescing operator around the access $item['lastMod'].
Resolves: #100280
Releases: main, 11.5
Change-I...
Thomas Hohn
20:00 Revision e42b1584: [TASK] Add index to be_dashboard
Add an index to TYPO3 table be_dashboard
to prevent FTS.
Resolves: #100298
Releases: main
Change-Id: I7da4f23047c610...
Stefan Froemken
08:27 Revision 61e4c181: [TASK] Use COUNT(*) in SchedulerTaskRepository
Counting by column name has to check against null
before. To speed up performance a little bit
we switch to COUNT(*)....
Stefan Froemken

2023-03-24

21:36 Revision c19c5f07: [FEATURE] Add commands list/execute for EXT:scheduler
Currently, it is not possible to get the uid of a given
task via cli.
For ease of use, the command 'scheduler:list' ...
Jochen Roth
21:28 Revision 26229cba: [FEATURE] Outgoing Webhooks for TYPO3
A webhook is an automated message sent from one application
to another via HTTP. Most modern web applications have th...
Frank Nägler
21:27 Revision 0930a80f: [FEATURE] Add additional parameters to email links
It is now possible to define additional
fields (subject, cc, bcc, body) to links to emails
by default.
This means, t...
Muhammad Suleman
19:20 Revision b59986fc: [BUGFIX] Support parsing of XML files larger than 10 MB
EXT:impexp may run into memory limits when converting XML to PHP
arrays, even before all PHP memory is used up, becau...
Alexander Nitsche
16:41 Revision 6b43d7ef: [BUGFIX] Make data providers static in Typo3Xml* tests
Resolves: #100292
Related: #83580
Releases: main
Change-Id: Ie3cf10bcb17645445ecc695912322ee1c76f5fef
Reviewed-on: ht...
Andreas Fernandez
14:41 Revision c1d158a7: [TASK] Fix spelling error in ext:workspaces
Fix spelling error.
Resolves: #100287
Relates: #95769
Releases: main
Change-Id: I5dfa77780409208cce30db09b33d441a85f...
Thomas Hohn
14:28 Revision 3d1e3afc: [BUGFIX] Support parsing of XML files larger than 10 MB
EXT:impexp may run into memory limits when converting XML to PHP
arrays, even before all PHP memory is used up, becau...
Alexander Nitsche
14:26 Revision dfa794f5: [TASK] Add CSP nonce helper for inline styles in lit-element templates
When using Content-Security-Policy for `style-src` with a `nonce-...`
value, it requires that inline styles (those us...
Oliver Hader
13:51 Revision b5991998: [DOCS] Improve asset ViewHelper description
The class name is removed since it is not customary for ViewHelpers and
can easily be derived from the ViewHelper nam...
Sybille Peters
13:34 Revision c859ab30: [FEATURE] Use password policy for password reset in ext:felogin
The password reset feature for TYPO3 frontend users does now consider
the configurable password policy introduced in ...
Torben Hansen
12:52 Revision 5d03fe3d: [TASK] Re-add last-changed information to workspace module
Due to the removal of ExtJS in TYPO3 v8,
the "last changed" column in the workspaces
administration module was remove...
Benni Mack
12:05 Revision db7083e6: [TASK] Use better identifiers for several backend modules
Historically, some backend modules have complex
namings.
Since TYPO3 v12, we can define aliases, and
use the new nam...
Benni Mack
11:39 Revision d710c66c: [FEATURE] Display available commands in scheduler
The scheduler submodule "Available scheduler commands"
lists all registered scheduler commands.
This list is now gro...
Georg Ringer
09:38 Revision 33e5123d: [FEATURE] Username in password recovery mail
Many users forget their login username and try to login with their email address.
The username of the backend user is...
Mario Lubenka
09:11 Revision b370f44c: [FEATURE] Add PSR-14 event for login failures
This change adds a new PSR-14 Event "LoginAttemptFailedEvent" instead
of the legacy hook "$GLOBALS['TYPO3_CONF_VARS']...
Benni Mack
08:03 Revision fffa37b4: [FEATURE] Add keyboard support for Multiselect
This patch adds keyboard support for selecting and deselecting options in
Multiselect. This should lead into a more a...
Lukas Niestroj
06:38 Revision e0a7897a: [BUGFIX] Cast invertStateDisplay to bool in SelectItem
Oftentimes bool values are provided as integer in TCA. Therefore, a cast
to bool is needed for invertStateDisplay.
N...
Nikita Hovratov

2023-03-23

22:27 Revision d801d3f1: [TASK] Get rid of ColumnMap::$propertyName
The ColumnMap only carried the propertyName to be
queried by the DataMap (of a class) to have a key
for its internal ...
Alexander Schnitzler
22:01 Revision 098a75b5: [TASK] Fix typo in FeLoginModeExtractionUpdate
This change fixes a typo in `FeLoginModeExtractionUpdate`
Resolves: #100276
Releases: main
Signed-off-by: Torben Han...
Torben Hansen
15:01 Revision 6d10f13b: [TASK] Avoid mocking methods that don't exist
phpunit 10 removed ->setMethods() on mocks.
This is especially problematic with
typo3/testing-framework, which provi...
Christian Kuhn
13:12 Revision 258fc1c1: [TASK] Allow FileListActionDetail to contain a list of resources
Releases: main
Resolves: #100269
Change-Id: I396c78d8ee699457c9b000da895eef7b4bbe3424
Reviewed-on: https://review.typ...
Benjamin Kott
11:07 Revision b3a50503: [TASK] Get rid of ColumnMap::$relationTablePageIdColumnName
That property always held string "pid" if TCA for the
defined foreign_table exists. This field is only
evaluated at o...
Alexander Schnitzler
10:50 Revision 1290a1db: [TASK] Static data providers in Tests/Unit
phpunit ^10 expects test data providers to be static.
Using rector rule StaticDataProviderClassMethodRector,
this bu...
Christian Kuhn
10:12 Revision cfafb46f: [TASK] Migrate ColumnMapFactory unit to functional tests
Releases: main
Resolves: #100261
Change-Id: I3d88b19b5965ef0ce6f9594d9d0c59a241eb0151
Reviewed-on: https://review.typ...
Alexander Schnitzler
10:09 Revision d577c3a2: [TASK] Improve error message in testMethodPrefixChecker
Resolves: #100266
Releases: main
Change-Id: I46ecde712133e57b79989a8a841f05039ddcc9ea
Reviewed-on: https://review.typ...
Tymoteusz Motylewski
10:08 Revision 22c861f8: [TASK] Add test for Filelist sorting function
The change https://review.typo3.org/c/Packages/TYPO3.CMS/+/78187
provided locale aware sorting for files.
This patch...
Tymoteusz Motylewski
09:49 Revision bbdf7180: [TASK] Declare web component HTML element tag names
Resolves: #100267
Releases: main
Change-Id: I9830fc4eb861c7967e21ef023c676197ea950994
Reviewed-on: https://review.typ...
Benjamin Kott
09:29 Revision aaa8099c: [BUGFIX] Resolve some `Function`-related eslint warnings
eslint became stricter lately and warns about possible bugs in
TypeScript code. This patch tackles some warnings rega...
Andreas Fernandez
08:34 Revision 08157212: [FEATURE] Add new possibilities to modify DefaultUploadFolder settings
Before this change the resolving of the default upload folder
was done in BackendUserAuthentication. As new users wis...
Andreas Nedbal
05:29 Revision 980f2ba3: [FEATURE] Add password policy validation for TCA type=password
It is now possible to assign a password policy to TCA fields of the
type `password`. For configured fields, the passw...
Torben Hansen

2023-03-22

23:23 Revision aa0c7cb5: [FEATURE] Add presets when adding new languages for a site
Presets with default configurations for a site
can be used to create new site languages with one click.
In the langu...
Christoph Lehmann
21:22 Revision 90d26842: [FEATURE] Add password policy action to exclude validators in SU mode
The new password policy action `UPDATE_USER_PASSWORD_SWITCH_USER_MODE`
has been added in order to allow exclusion of ...
Torben Hansen
20:38 Revision 2e769df1: [FEATURE] Introduce command to clean up processed files
This adds a new symfony command to `EXT:lowlevel`. The
command deletes processed files which are not referenced
anymo...
Eike Starkmann
19:21 Revision a53a3c7d: [FEATURE] Allow overriding button text for TCA type=file
With TCA, it is possible for type=file to change
the label to a different label depending on the field.
This is usef...
Benni Mack
19:21 Revision fd2091af: [TASK] Raise codeception to unlock phpunit:^10
> composer req --dev \
codeception/codeception:^5.0.10 \
codeception/lib-asserts:^2.1.0 \
codeception/mod...
Christian Kuhn
16:36 Revision 7e14c05f: [TASK] Separate MM_match_fields from MM_insert_fields handling
RelationHandler property $this->MM_insert_fields state
falls back to MM_match_fields in start(). This is ugly
and can...
Christian Kuhn
16:21 Revision 256f9af4: [TASK] Raise typo3/testing-framework
Raised TF allows phpunit 10. We fetch this
to reduce developer headaches working on
phpunit 10 support.
> composer u...
Christian Kuhn
16:00 Revision 7087ed5c: [TASK] Separate concerns in EXT:scheduler
This change finally cleans up logic within
the scheduler extension, namely to separate
concerns regarding reading fro...
Benni Mack
15:31 Revision a9308454: [TASK] LiveSearch: Extract handling into repository
To make the LiveSearch API usable in different contexts (e.g. the
record list), the common search handling is extract...
Andreas Fernandez
14:36 Revision 00ff2911: [BUGFIX] Use appropriate icon for "New group" button
Resolves: #100253
Related: #99874
Releases: main
Change-Id: Ib01e654e3f1e36a1168aab36fb4429f1c324e9d8
Reviewed-on: ht...
Nikita Hovratov
13:31 Revision 4ea278a0: [BUGFIX] Properly soft-delete scheduler task groups
Use update() over delete() to set hidden
field to 1 to soft-delete instead of
completely removing the row from DB
Re...
Christian Kuhn
13:27 Revision 0a301168: [TASK] Replace withConsecutive() call in ext:adminpanel test
This change replaces a `withConsecutive()` call in a test
by using a callback function to check for expected
argument...
Torben Hansen
12:32 Revision 06340959: [TASK] Improve Filelist sorting
Speed up the sorting of files and folders significantly
by simply using uksort instead of usort to save many
unnecess...
Christian Eßl
12:16 Revision 75238554: [BUGFIX] Avoid PHP 8 warnings when processing the INTinclude-scripts
Avoid PHP warnings when calling the method to process INTinclude
scripts when jsInline or jsFooterInline was set.
Pr...
Albrecht Köhnlein
11:57 Revision 43179ad5: [TASK] Avoid protected & private data providers
phpunit test data providers had to be public ever
since [1]. phpunit calls them using reflection.
With PHP 8.1, setA...
Christian Kuhn
11:51 Revision 4f141428: [TASK] Update lit JavaScript dependencies
In addition to the update we are dropping the version number
in the directory structure. This behavior was unique to ...
Benjamin Kott
10:18 Revision fb4849b2: [TASK] Split ColumnMapFactory off of DataMapFactory
This change splits off the creation of column maps in the
DataFactory class into its own ColumnMapFactory class.
Ben...
Alexander Schnitzler
10:13 Revision 9786199c: [TASK] Use the term "Page TSconfig" consistently in the BE
Following the TYPO3 documentation and the TYPO3 content style guide (in
particular the section "Spelling, terms and g...
Michael Schams

2023-03-21

21:55 Revision 75a180df: [TASK] Raise typo3fluid/fluid:^2.7.3
This patch level release comes with a set
of minor bug fixes and should be the minimum
version for TYPO3 v12 from now...
Christian Kuhn
21:17 Revision 95a182a7: [BUGFIX] Avoid PHP 8 warnings when processing the INTinclude-scripts
Avoid PHP warnings when calling the method to process INTinclude
scripts when jsInline or jsFooterInline was set.
Pr...
Albrecht Köhnlein
20:47 Revision b9f12bff: [FEATURE] Load additional CSS files via TYPO3_CONF_VARS
This change deprecates the global array $TBE_STYLES
and with that the registration of CSS files for backend
styling, ...
Benni Mack
20:45 Revision 062e850f: [BUGFIX] Prevent TypeError in CreateRecordReactionTable
The `items` array in an itemsProcFunc does no
longer contain item arrays but SelectItem objects.
Therefore, the corre...
Oliver Bartsch
18:22 Revision 78cb4e2b: [TASK] Improve type annotations for AbstractValueObject
Resolves: #100142
Releases: main
Change-Id: I3981c16020eb2b210a40bedce89d8050bd2a851c
Reviewed-on: https://review.typ...
Oliver Klee
17:36 Revision 0e17f9a4: [BUGFIX] Use Locale dependencies in Extbase LocalizationUtiltiy
Extbase uses the $alternativeLanguageKeys,
which previously omitted the actual language
chain for XLF files, because ...
Benni Mack
16:43 Revision 71d33988: [TASK] Remove relationTableWhereStatement from ColumnMap
Private property ColumnMap->relationTableWhereStatement
is unused and can be removed from the codebase without
furthe...
Christian Kuhn
15:11 Revision ab836d16: [TASK] Add default value for method in FormViewHelper
The default value for argument "method" is effectively
"post", so this is added as default value in registerArgument
...
Sybille Peters
11:42 Revision 9bf03d8f: [TASK] Update ext:styleguide dependency
Update `ext:styleguide` to ensure it contains the changes
to avoid automatic TCA migration deprecation, because of
re...
Stefan Bürk
11:38 Revision e83de626: [TASK] Deprecate two TypoScript related exceptions
MissingTsfeException: This one is useless, we can
simply return false in the expression function
instead of throwing ...
Christian Kuhn
11:21 Revision 3f5e3dcc: [FEATURE] Allow editing of task groups within the scheduler module
Currently, users have to use the list module and click
on the root page to add/edit/remove a task group.
This has be...
Jochen Roth
10:43 Revision 21425351: Remove fallback to indexed key
Nikita Hovratov
10:43 Revision c01311e9: Fix incorrect migration from index 1 to value
Nikita Hovratov
10:43 Revision d190cdbc: [TASK] styleguide: Use associated array keys for TCA items
Related patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77626
Releases: main
Nikita Hovratov
09:52 Revision 336fd6c1: [TASK] Simplify ValidatorResolver::buildBaseValidatorConjunction()
Prior to this change, buildBaseValidatorConjunction() was responsible
for initializing $this->baseValidatorConjunctio...
Alexander Schnitzler
08:47 Revision 6a07b918: [FEATURE] Introduce associative array keys for TCA items
The TCA types select, radio and check now have associative array keys
for their items array.
The mapping is as follo...
Nikita Hovratov
08:31 Revision 39eb6ac7: [TASK] Use filelist in create folder context
We are now introducing the modern filelist rendering
to the folder create browser. This patch also includes
removes s...
Benjamin Kott
01:42 Revision be772c32: [FEATURE] Introduce new PSR-14 BeforeRedirectMatchDomainEvent
A new PSR-14 event `BeforeRedirectMatchDomainEvent` is introduced
to the RedirectService, allowing extension authors ...
Stefan Bürk
01:41 Revision ea667fb0: [FEATURE] Introduce ModifyRedirectManagementControllerViewDataEvent
A new PSR-14 event "ModifyRedirectManagementControllerViewDataEvent"
is introduced, allowing extension authors to mod...
Stefan Bürk

2023-03-20

23:03 Revision 6147e306: [TASK] Modernize array function callbacks in Fluid
Function callbacks are declared using the new PHP 8.1 feature
"first class callable", which e.g. uses the named `trim...
Oliver Klee
21:54 Revision 56a166b5: [TASK] Make RequestBuilder stateless
Releases: main
Resolves: #100200
Change-Id: Ic4837e21e477b4b1d26665428e282eab729ab927
Reviewed-on: https://review.typ...
Alexander Schnitzler
21:52 Revision a8e0f47a: [BUGFIX] Prevent type error in TypoLinkViewHelper
Resolves: #100210
Releases: main
Change-Id: I3a011cf4b964bdb580015ee3719ada9a8f03a62c
Reviewed-on: https://review.typ...
Benjamin Serfhos
20:25 Revision 4971be0c: [TASK] Outsource common multi record actions
The common multi record selection actions
"edit multiple" and "delete multiple" are now
available as separate modules...
Oliver Bartsch
19:55 Revision 6d6c0bd3: [TASK] Move file module after web module
As editing content is the most used task, the file module should be
moved right after the web module instead of havin...
Georg Ringer
18:05 Revision 5a1e80cb: [BUGFIX] Unify MetaTagApi removal methods
Add strtolower calls at `GenericMetaTagManager::removeProperty` to be in
sync with `PageRenderer::removeMetaTag`.
Re...
Georg Ringer
17:24 Revision 2ca1e35e: [TASK] Raise php-cs-fixer dev dependency to 3.15
PHP-CS-Fixer 3.15 is now officially PHP 8.2
compatible, so we raise this dependency.
See https://github.com/PHP-CS-F...
Benni Mack
16:56 Revision 3ac9b03b: [TASK] Replace withConsecutive() calls in ext:backend tests
This change replaces all `withConsecutive()` calls in tests
by using a callback function to check for consecutive arg...
Torben Hansen
16:31 Revision d68dd01d: [BUGFIX] Replace EAB with Board in readme
Updates to the Final notes section:
* The Expert Advisory Board (EAB), which no longer exists, has been
replaced w...
Mathias Bolt Lesniak
16:10 Revision 4b3f0d61: [BUGFIX] Unify MetaTagApi removal methods
Add strtolower calls at `GenericMetaTagManager::removeProperty` to be in
sync with `PageRenderer::removeMetaTag`.
Re...
Georg Ringer
15:40 Revision 6a08e93a: [BUGFIX] Replace EAB with Board in readme
Updates to the Final notes section:
* The Expert Advisory Board (EAB), which no longer exists, has been
replaced w...
Mathias Bolt Lesniak
15:37 Revision 9e3781ac: [FEATURE] Basic TypoScript syntax scanner
This patch adds a last feature to the PageTsConfig and
TypoScript UI in TYPO3 v12. A simple syntax scanner:
* Detect ...
Christian Kuhn
15:23 Revision e1becb0b: [BUGFIX] Replace EAB with Board in readme
Updates to the Final notes section:
* The Expert Advisory Board (EAB), which no longer exists, has been
replaced w...
Mathias Bolt Lesniak
15:23 Revision abf1e23a: [TASK] Use userland strftime() implementation for deprecated PHP function
This change finally removes all usages to strftime(),
as this function was deprecated in PHP 8.1.
It is recommended t...
Benni Mack
15:11 Revision 7061a344: [FEATURE] Introduce ignoreFlexFormSettingsIfEmpty extbase configuration
Extbase extension settings defined in FlexForm always override settings
defined globally in TypoScript. This is a pro...
Alexander Schnitzler
14:56 Revision 41e71277: [FEATURE] Enable list/tile view for resources in link browser
With this change, we are rolling out the universal file-list
rendering for files and folders to the link browser. The...
Benjamin Kott
13:42 Revision 012bf6f3: [TASK] Convert TableColumnType to backed enum
This change converts class TableColumnType to a native,
backed enum.
Releases: main
Resolves: #100220
Change-Id: Ic2...
Alexander Schnitzler
11:28 Revision 307bd4d9: [FEATURE] Add ATagParams option to links of restricted pages
A new TypoScript option is introduced to allow to set
additional tag attributes to links of pages which are
access re...
Benni Mack
10:02 Revision 85641582: [TASK] Simplify DataMapFactory::setRelations()
In order to have this method more readable, elseif statements
are broken apart and replaced with early returns.
Rele...
Alexander Schnitzler
09:03 Revision 08ea8345: [BUGFIX] Avoid clipped dropdowns in panels
Resolves: #100164
Releases: main
Change-Id: Ie9ec6d5aa098ba29893f0b425291c0339996a644
Reviewed-on: https://review.typ...
Benjamin Kott
08:11 Revision 292694ab: [BUGFIX] Correct position of node actions in svg tree
Releases: main
Resolves: #100201
Change-Id: If123a7cb0b6892fac35eb4ceaeef5b18bd980103
Reviewed-on: https://review.typ...
Benjamin Kott

2023-03-19

14:19 Revision fbcc3675: [BUGFIX] Only set Content-Type charset for text/html or JSON
When using TYPO3 as a response for multipart
result or application/binary responses,
TSFE should not append "charset=...
Benni Mack

2023-03-18

11:47 Revision bec22852: [DOCS] Correct examples in redirect event examples
Resolves: #100212
Related: #99834
Releases: main
Change-Id: I95c051ee295bf762f632d7a30c65a083f5aab46d
Reviewed-on: ht...
Chris Müller
11:39 Revision e52782b5: [TASK] Use BackedEnum for LikeWildcard
PHP 8 introduced native Enumerations,
which can now be used instead of our own
implementation from TYPO3 v7.
Enums a...
Benni Mack
11:16 Revision 46d78c77: [BUFGIX] Instanciate individual objects of StandaloneView
If StandaloneView was instanciated as constructor argument
you will now get a non shared object.
Resolves: #99172
Re...
Stefan Froemken
10:35 Revision 815ded3f: [BUGFIX] Prevent endless loop in PageLinkBuilder
By re-using an already resolved page #99612 introduced an endless loop
during HMENU/Sitemap rendering: An external pa...
Christoph Lehmann
09:21 Revision cf545210: [DOCS] Add links to more details for PSR-14 events in EXT:felogin
Resolves: #100214
Releases: main, 11.5
Change-Id: Ibf89953203e55e425de533a34a123ab2401fd086
Reviewed-on: https://revi...
Chris Müller
09:12 Revision ce947d5b: [DOCS] Add links to more details for PSR-14 events in EXT:felogin
Resolves: #100214
Releases: main, 11.5
Change-Id: Ibf89953203e55e425de533a34a123ab2401fd086
Reviewed-on: https://revi...
Chris Müller

2023-03-17

23:26 Revision 30a93ac8: [BUGFIX] Respect TCA field foreign_default_sortby by extbase
Inside the extbase context child relations are always ordered
by the foreign_sortby field if set or by order of creat...
Alexander Schnitzler
22:51 Revision b0210f06: [TASK] Upgrade TypeScript to 5.0
TypeScript 5.0 has been release a few days ago and brings promising
features, see [1]. This patch therefore updates T...
Andreas Fernandez
22:50 Revision 78a5a4f2: [TASK] Upgrade TypeScript to 5.0
TypeScript 5.0 has been release a few days ago and brings promising
features, see [1]. This patch therefore updates T...
Andreas Fernandez
20:10 Revision 69456b6d: [TASK] Add multi record selection to reactions module
For consistency and usability reasons is the multi
record selection now added to the newly introduced
reactions overv...
Oliver Bartsch
19:53 Revision cbee78d1: [BUGFIX] Correct word in locallang_resource.xlf
Forge Ticket: https://forge.typo3.org/issues/100203
Resolves: #100203
Resolves: #100204
Releases: main
Change-Id: If...
Abdulhamid Kwieder
14:23 Revision 4085461c: [TASK] Update TypeScript to 4.9
TypeScript is updated to the current version 4.9, while TS 5.0 is around
the corner. In the same run, eslint and its ...
Andreas Fernandez
14:18 Revision bb0fc4d3: [FEATURE] Introduce php-intl based date&time formatting
A new stdWrap "formattedDate" feature is added,
which uses the ICU-based pattern formatting
see https://unicode-org.g...
Benni Mack
11:12 Revision 6df61f76: [TASK] Fix casing of DropDownDivider class name
Use `DropDownDivider::class` instead of `DropdownDivider`.
Resolves: #100192
Releases: main
Change-Id: I5521fd87b3df...
Georg Ringer
07:50 Revision 2164f485: [TASK] Use correct external link RST syntax
Resolves: #100190
Related: #99499
Releases: main
Change-Id: I1148d368a1f961a34311a0d931999eedbbb0317e
Reviewed-on: ht...
Oliver Hader
05:36 Revision d3f424a2: [BUGFIX] Avoid notices while retrieving the cookie domain
Resolves: #99337
Releases: main, 11.5
Change-Id: Ia51d0328fc4abc19686375fd47770ead31eac53c
Reviewed-on: https://revie...
Georg Ringer
05:26 Revision 2784f1e3: [BUGFIX] Avoid notices while retrieving the cookie domain
Resolves: #99337
Releases: main, 11.5
Change-Id: Ia51d0328fc4abc19686375fd47770ead31eac53c
Reviewed-on: https://revie...
Georg Ringer
 

Also available in: Atom