Project

General

Profile

Activity

From 2021-10-18 to 2021-11-16

2021-11-16

21:30 Revision 3d1c9e25: [BUGFIX] Fix undefined key warning in ContentObjectRenderer
Resolves: #95993
Releases: master
Change-Id: I8eb6e779ae1d0f02bf8ef0fe3fb5dd02b751cb47
Reviewed-on: https://review.ty...
Florian Rival
18:53 Revision 3f02811b: [BUGFIX] Add missing class to form wizard items
In #94688, the table layout of form fields
had been replaced by a grid layout. However,
some places did not receive t...
Oliver Bartsch
18:38 Revision fb32aa28: [BUGFIX] Fix undefined array key warnings in field providers
Resolves: #95995
Releases: master
Change-Id: I6faea581aba0ca9171a6b79c94c1371c56b60387
Reviewed-on: https://review.ty...
Oliver Bartsch
18:12 Revision ada2975a: [TASK] styleguide: Avoid inline JavaScript in custom eval at basic.input_20
see https://review.typo3.org/c/Packages/TYPO3.CMS/+/72154 Oliver Hader
17:54 Revision 00104609: [TASK] styleguide: Remove custom JavaScript eval handling from basic.text_8
see https://forge.typo3.org/issues/66688 Oliver Hader
17:36 Revision 6a882fff: [TASK] Avoid inline JavaScript in Scheduler
Schedule task "Table Garbage Collection" uses inline JavaScript
to declare default values for different database tabl...
Oliver Hader
13:43 Revision 16daefbe: [TASK] Remove leftover language labels
The browser notification API has been introduced
in #90666. Due to various reason it had been
removed again in #92988...
Oliver Bartsch
10:54 Revision f5e48b3e: [BUGFIX] Define foreign_match_field definition for test setup
ext:irre_tutorial has two relations to tx_irretutorial_1nff_hotel
from tt_content: One from native field tx_irretutor...
Anja Leichsenring
10:42 Revision 6ecdebc0: [TASK] Remove unused trait from install tool SessionService
The functionality the trait provides is never used for the
SessionService, so usage declaration is removed.
Resolves...
Anja Leichsenring
09:53 Revision 71d240bf: [TASK] styleguide: Add additional autoSizeMax examples for type group and inline
The option autoSizeMax is a common property between select, group and
inline fields. This patch adds examples for gro...
Nikita Hovratov
09:51 Revision 7f4aff8f: [TASK] styleguide: Simplify items TCA of type=check
This patch follows up this core patch:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72056
The items array is redu...
Nikita Hovratov
09:32 Revision b619ba2f: [TASK] Set TYPO3 version to 11.5.4-dev
Change-Id: I5796168cca0ddfd134da596d016a784bb9ab55b9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/721...
Oliver Hader
09:15 Revision 03124e93: [RELEASE] Release of TYPO3 11.5.3
Change-Id: I963971774750267bde8c1f4816ec9f07f2dad9f1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/721...
Oliver Hader
09:06 Revision 88122436: [BUGFIX] Make external page error handling work again
In recent TYPO3 v11.5.x versions, the error handling for Frontend
pages did cache the external PSR-7 Response (by guz...
Benni Mack

2021-11-15

20:22 Revision 08669c3f: [TASK] Reduce inline JavaScript in FormEngine AJAX responses
Reduces amount of `requireJsModules` and `scriptCall` invocations
in AJAX response handling and migrates to new `scri...
Oliver Hader
20:05 Revision 7306506e: [TASK] Raise typo3/testing-framework:^6.14.0
Brings a patch for extension testing, so they
don't inherit the composer flag for test instances
anymore.
composer r...
Christian Kuhn
19:59 Revision 4fd30373: [BUGFIX] Consider hideAtCopy and disableHideAtCopy for page translation
In TYPO3 v8, new page translations within pages_language_overlay
were visible by default when using plain DataHandler...
André Buchmann
19:52 Revision 8ae4e473: [BUGFIX] Resolve page id correctly in ConditionMatcher
The ConditionMatcher tries to resolve the
current page id from global variables. One of this possibilities uses the c...
Nicole Cordes
19:44 Revision 935b834d: [BUGFIX] Fix PHP 8 warning in TcaFlexProcess
Resolves: #95987
Releases: master
Change-Id: Icd868d64e0414fa295f1d03c7cbe102b388ff978
Reviewed-on: https://review.ty...
Nikita Hovratov
19:29 Revision d87cc4f5: [TASK] Move Composer package artifact to vendor folder
Storing the package artifact in the var/build folder raised
questions how this folder shall be treated in general and...
Simon Gilli
19:27 Revision 00fe04fa: [BUGFIX] Resolve page id correctly in ConditionMatcher
The ConditionMatcher tries to resolve the
current page id from global variables. One of this possibilities uses the c...
Nicole Cordes
19:05 Revision d52dd96f: [BUGFIX] Fix loose type check in BackendUserAuthentication
empty() returns true if a record contains 0 as value.
Therefore isset() needs to be used instead.
The corresponding ...
Benjamin Franzke
18:18 Revision 61c307d1: [BUGFIX] Use text-end instead of text-right
Bootstrap 5 ships with "text-end" which is semantically
more correct than "text-right".
This change adapts the neede...
Benni Mack
17:33 Revision 51d6d877: [BUGFIX] Show translated reference in shortcut preview of page module
Previously, when creating a translated content element of
type `shortcut`, the preview in the page module would
alway...
Christian Eßl
16:45 Revision 81e901ca: [BUGFIX] Fix loose type check in BackendUserAuthentication
empty() returns true if a record contains 0 as value.
Therefore isset() needs to be used instead.
The corresponding ...
Benjamin Franzke
14:52 Revision 736d7d30: [TASK] Tighten tests and extend PHP 8.1 testing
The big win with this patch: All core now run tests with E_ALL
error handling (unit, functional, acceptance). This me...
Stefan Bürk
14:39 Revision 3c16bc4d: [TASK] Extract relevant parts of JsonRenderer into ext:test_irre_csv
To further separate concerns from ext:irre_tutorial, the configuration
of JsonRenderer looses all parts that only con...
Anja Leichsenring
14:27 Revision d0362c7b: [BUGFIX] Fix PHP 8.0 warnings in Workspace preview
Resolves: #95973
Releases: master
Change-Id: I6f0358cfdc38aff55ce8e0ef4343cd50104d93c3
Reviewed-on: https://review.ty...
Benni Mack
14:20 Revision 9e152812: [TASK] Apply current recommendations for BASH scripts
This patch applies the current recommendations for BASH scripts see
https://github.com/koalaman/shellcheck#readme.
R...
Simon Gilli
14:02 Revision 896dab63: [TASK] Apply current recommendations for BASH scripts
This patch applies the current recommendations for BASH scripts see
https://github.com/koalaman/shellcheck#readme.
R...
Simon Gilli
13:41 Revision a5d32c79: [TASK] Raise typo3fluid/fluid:^2.7.1
Brings especially a series of core v11 relevant
PHP 8.1 bug fixes.
composer req typo3fluid/fluid:^2.7.1
composer req...
Christian Kuhn
13:20 Revision 4fb1e061: [TASK] Raise typo3/testing-framework:^6.13.0
Brings a series of core v11 relevant PHP 8.1 E_ALL
preparations and a couple of minor details.
composer req --dev ty...
Christian Kuhn
13:20 Revision 60a63058: [TASK] Raise typo3/testing-framework:^6.13.0
Brings a series of core v11 relevant PHP 8.1 E_ALL
preparations and a couple of minor details.
composer req --dev ty...
Christian Kuhn
13:17 Revision 73422129: [BUGFIX] Fix PHP 8 warning in ConstantConfigurationParser
If extension authors don't provide a type for their
extension configuration options, they will now fall
back to "stri...
Nikita Hovratov
13:10 Revision 98af8fbb: [TASK] Activate a unit test with PHP 8.1
There was a skipped unit test due to a PHP 8.1 bug.
Latest rc6 fixed the issue, the test can be activated
again.
Res...
Christian Kuhn
12:43 Revision ef698031: [TASK] Update Bootstrap to 5.1.3 and PopperJS library
Used commands:
> yarn add "bootstrap@^5.1.3"
> yarn add "@popperjs/core"
> grunt build
Resolves: #95975
Releases: m...
Benni Mack
12:26 Revision 1c0d4d6f: [TASK] Extract ext:test_irre_csv from ext:irre_tutorial
For easier testing, ext:irre_tutorial "csv" setup
is extracted to a dedicated extension.
Tests concerning these table...
Anja Leichsenring
11:31 Revision bce2a155: [BUGFIX] Raise 3rd party composer packages to composer.lock version
During testing to activate E_ALL and PHP 8.1 testing with activated
E_ALL, nightly 'composerMin' tests for PHP8.1 are...
Stefan Bürk
09:17 Revision 01e867b0: [BUGFIX] Fix typo in description of LostFilesCommand
Resolves: #95971
Releases: master
Change-Id: I73f4d694d3a641c07c10b31c7e508f20836a955c
Reviewed-on: https://review.ty...
Peter Kraume
09:05 Revision ab479dd5: [BUGFIX] Correctly double and single quotes in page tree tooltips
There were several problems with tooltips in the page tree:
- htmlspecialchars was applied twice to the tooltip stri...
Christian Eßl

2021-11-13

17:44 Revision 5e791a00: [BUGFIX] Add configuration to set SMTP mail domain
If you use some mail relay servers for sending emails via
SMTP, it is necessary to specify the domain name under whic...
Axel Seemann
10:06 Revision 3a186741: [BUGFIX] Keep original request language for shortcuts
In #89871 (65dc060) a fix was introduced, that
forces the link generation to use the requested
language of shortcuts ...
Nikita Hovratov

2021-11-12

22:54 Revision f12e9d29: [TASK] Add correct test for shortcut issue in language menu
The added tests for #89871 do not prove the
correctness of the patch. They go green, without the
fix being applied. T...
Nikita Hovratov
20:00 Revision 5fe876e5: [BUGFIX] Raise doctrine/dbal:^2.13.5
doctrine/dbal driver for postgres has been feeding null to
preg_match() in some constellations, which emits E_DEPRECA...
Stefan Bürk
16:45 Revision 68aa03bd: [BUGFIX] Ensure TranslateViewHelper does not fail on invalid extension
Change #95839 introduced a regression that causes TranslateViewHelper
to fail when an invalid extension key is specif...
Simon Gilli
07:47 Revision 771bbc3b: [BUGFIX] Fix PHP 8 warning in LinkAnalyzer
Resolves: #95960
Releases: master
Change-Id: I5853d135ce20b1e9b53806a16fb734ab87c41b2b
Reviewed-on: https://review.ty...
Nikita Hovratov

2021-11-11

15:16 Revision dbcd908b: [BUGFIX] Input and save date properly when USdateFormat is set
Currently, the value of `USdateFormat` is disregarded because the
corresponding property, `FormEngineValidation.USmod...
Gabe Troyan
15:01 Revision d021fbca: [BUGFIX] Input and save date properly when USdateFormat is set
Currently, the value of `USdateFormat` is disregarded because the
corresponding property, `FormEngineValidation.USmod...
Gabe Troyan
14:22 Revision c5b8e7a9: [TASK] Transform JavaScriptHandler.js to be hybrid IIFE and AMD
With this change JavaScriptHandler.js is not only an immediately
invoked function expression (IIFE) like before but i...
Oliver Hader
13:59 Revision f76e1a6c: [BUGFIX] Revert "Make file paths absolute in GIFBUILDER"
This reverts commit 7bfe6f7608959e6607079e884b052aaa24a136cb
as this has some side-effects with absolute paths.
Reve...
Benni Mack
13:30 Revision 6501c328: [BUGFIX] Avoid PHP warnings in AbstractUserAuthentication
When dealing with 3rd-party authentication services,
which might return other values than arrays or
without UIDs.
Th...
Benni Mack
13:12 Revision 9ec2f2d7: [BUGFIX] Revert "Make file paths absolute in GIFBUILDER"
This reverts commit 48e4e495e2f5a85204e4f81bffd2164f095876f7
as this has some side-effects with absolute paths.
Chan...
Benni Mack
12:20 Revision 3d35dfd8: [BUGFIX] Allow service aliases in ContentDataProcessor
Fetch services from the DI container and perform post-creations
checks instead of checking class_exists and therefore...
Benjamin Franzke
11:13 Revision 9a7da081: [BUGFIX] Fix undefined key warnings in MagicImageService
Two undefined array key warnings are fixed, which
occurred on PHP 8 when accessing the MagicImageService.
Resolves: ...
Robert Kärner
08:41 Revision 2c1a8ac6: [BUGFIX] Fix timezone of native time records in list
Native time fields (dbtype) in the record list are now displayed
independent from the server timezone.
Resolves: #92...
Imko Schumacher
08:39 Revision ccb7a8e4: [TASK] Explicitly use JavaScript module instructions in dashboard
Introduces new `\TYPO3\CMS\Dashboard\Widgets\JavaScriptInterface`,
based on explicit `\TYPO3\CMS\Core\Page\JavaScript...
Oliver Hader

2021-11-10

22:40 Revision 7b6502f3: [BUGFIX] Handle localizeReferencesAtParentLocalization for group/db
TCA config property 'localizeReferencesAtParentLocalization'
for database relations is only handled with type=select
...
Andreas Wolf
22:23 Revision 4709cc59: [BUGFIX] Remove leftover service registration for TableController
TableController was removed in #95036.
The corresponding service registration is
now removed, too.
Resolves: #95955
...
Oliver Bartsch
21:18 Revision 3d61bfb7: [BUGFIX] Fix timezone of native time records in list
Native time fields (dbtype) in the record list are now displayed
independent from the server timezone.
Resolves: #92...
Imko Schumacher
20:10 Revision f2537b75: [TASK] Push DataHandling functional test extension down one level
All functional tests in DataHandling category (both workspaces and core)
used to load the ext:irre_tutorial test exte...
Anja Leichsenring
19:23 Revision e87e0a4c: [BUGFIX] Avoid InvalidTypoScriptConditionException in RedirectHandler
Redirects to target with LinkHandler uri 't3://' need a bootstrapped
'TypoScriptFrontendController' and parsed and ex...
Stefan Bürk
19:23 Revision 19b3b414: [BUGFIX] Fix too long regular expression error in ContentObjectRenderer
Text cropping on texts with way more than 1000 characters
triggers regular expression compilation errors.
The sweet s...
Stefan Bürk
19:23 Revision 76f7f362: [DOCS] Replace links with intersphinx refs
Using references instead of absolute URLs has the following
advantages:
- If a target section is moved, the URL in a...
Sybille Peters
18:57 Revision c869c8ba: [BUGFIX] Fix too long regular expression error in ContentObjectRenderer
Text cropping on texts with way more than 1000 characters
triggers regular expression compilation errors.
The sweet s...
Stefan Bürk
18:52 Revision 3c4cef7e: [BUGFIX] Load FlexForm Sections on new before save
FlexForm Section can be added before content element is saved.
This is done by ensuring that processedTca have a valu...
Tomas Norre Mikkelsen
18:51 Revision 6359edb1: [DOCS] Replace links with intersphinx refs
Using references instead of absolute URLs has the following
advantages:
- If a target section is moved, the URL in a...
Sybille Peters
18:15 Revision 1d1712bf: [BUGFIX] Load FlexForm Sections on new before save
FlexForm Section can be added before content element is saved.
This is done by ensuring that processedTca have a valu...
Tomas Norre Mikkelsen
18:14 Revision 91413062: [BUGFIX] Fix method signature of Query::logicalOr()
The method signature of Query::locicalOr() is very misleading
because it only states there is one method argument $co...
Alexander Schnitzler
18:14 Revision e4d5450a: [BUGFIX] Fix method signature of Query::logicalOr()
The method signature of Query::locicalOr() is very misleading
because it only states there is one method argument $co...
Alexander Schnitzler
18:12 Revision 0dec9bab: [DOCS] Update section on redirects in seo docs
- Remove information about bug which no longer exists
- Link to redirects documentation
- Remove example for redirect...
Sybille Peters
17:57 Revision 065be835: [DOCS] Update section on redirects in seo docs
- Remove information about bug which no longer exists
- Link to redirects documentation
- Remove example for redirect...
Sybille Peters
17:37 Revision b71167e1: [BUGFIX] Make toolbar dropdown menu scrollable
The contents of the toolbar dropdown menus
for bookmarks and open documents are dynamic.
Having e.g. a lot bookmarks ...
Oliver Bartsch
17:28 Revision bf538d60: [BUGFIX] Prevent undefined array key warning in QueryGenerator
Resolves: #95943
Releases: master
Change-Id: Ibf5c2c9fe776ab3111c172085335541970a41de7
Reviewed-on: https://review.ty...
Oliver Bartsch
17:24 Revision f37a7fbc: [TASK] Fix phpstan errors from ReturnTypeRule in various exts
* EXT:belog
* EXT:beuser
* EXT:dashboard
* EXT:extensionmanager
Resolves: #94256
Releases: master
Change-Id: Iee778a...
Benni Mack
17:12 Revision c1a6410d: [BUGFIX] Fix undefined array key warnings in ExtendedTemplateService
Additionally, a change in behaviour from #95519
is fixed, while keeping the fallbacks in place.
Resolves: #95945
Rel...
Oliver Bartsch
16:49 Revision b174ff05: [BUGFIX] Fix undefined array key warning in GroupResolver
Resolves: #95946
Releases: master
Change-Id: Ide10cf2722af3f7cc7b8e4e8830159f7de3510be
Reviewed-on: https://review.ty...
Andreas Fernandez
12:27 Revision 920e1ef4: [BUGFIX] Fix various undefined array key errors in PHP8
Resolves: #95925
Releases: master
Change-Id: I125fcb5e60561646ee8398b0536106a2d5c828ed
Reviewed-on: https://review.ty...
Chris Müller
12:25 Revision 6ab1b1cd: [BUGFIX] Fix undefined array key errors in ContentObjectRenderer
Resolves: #95926
Releases: master
Change-Id: I67de7575d4c6b75062cb21e558402f15dfeb70a7
Reviewed-on: https://review.ty...
Chris Müller
10:10 Revision 9f916274: [BUGFIX] Fix saving command line scheduler tasks in PHP 8
Prevent undefined array key access in saveAdditionalFields()
method in ExecuteSchedulableCommandAdditionalFieldProvid...
Alexander Stehlik
09:55 Revision f9322a10: [BUGFIX] Avoid calling htmlspecialchars(null) in GeneralUtility
GeneralUtility::implodeAttributes() calls htmlspecialchars() on the
array values to sanitize them. The values may be ...
Stefan Bürk
09:55 Revision 93f2e05c: [BUGFIX] Avoid calling preg_split(null) in ContentObjectRenderer
CropViewHelper::renderStatic() calls ContentObjectRenderer::cropHTML()
with result from children closure, which may b...
Stefan Bürk
09:55 Revision 5f69e379: [BUGFIX] Avoid E_DEPRECATED error calling trim(null) and explode(null)
TypoScriptTemplateInformationModuleFunctionController::main() calls
trim() and explode() with array values which may ...
Stefan Bürk
09:55 Revision 59d1fe6e: [BUGFIX] Avoid calling explode(null) in ExtendedTemplateService
ExtendedTemplateService::ext_regObjectPositions() calls explode() with
$constants parameter which may be null. Feedin...
Stefan Bürk
09:13 Revision 1394a4cf: [TASK] Simplify checkbox items TCA
TCA shares same keys across different types,
and so does "items" with type check, radio
and select. The value is usua...
Nikita Hovratov
09:06 Revision 47ba4aea: [BUGFIX] Avoid calling htmlspecialchars(null) in InputTextElement
InputTextElement::render() calls htmlspecialchars() to output the
itemValue. $itemValue can be null null instead of a...
Stefan Bürk
08:57 Revision 361cd30c: [BUGFIX] Avoid calling parse_url(null) in DatabaseRecordList
DatabaseRecordList::renderListRow() calls linkUrlMail() with
eventually null as second argument, thus invoking parse_...
Stefan Bürk
08:49 Revision a77817e4: [TASK] Reduce directly invoked inline JavaScript
To decrease the amount of inline JavaScript that has been
generated by some PHP process assignments and invocations
a...
Oliver Hader
08:26 Revision 48d783b2: [BUGFIX] Avoid calling substr_count(null) in TemplateService
TemplateService::render() calls substr_count() on a array field
retrieved from the database, which may be null instea...
Stefan Bürk
08:25 Revision 62a22b5b: [BUGFIX] Avoid calling strlen(null) in TextElement
TextElement::render() calls strlen() to determine length of form
elemet item value. It may be that item value is null...
Stefan Bürk
08:24 Revision a3c67422: [BUGFIX] Avoid calling htmlspecialchars(null) in TextElement
TextElement::render() calls htmlspecialchars() to output the
item value. It may be that $itemValue is null instead of...
Stefan Bürk

2021-11-09

21:22 Revision 4252e85d: [BUGFIX] Provide arguments in correct order to DataHandler log method
The first array entry for "$data" is the replacement for "%s" in
vsprintf. The order has been swapped, so the wrong e...
Davide Alghi
21:01 Revision c933e6f5: [TASK] Testing type=group localizeReferencesAtParentLocalization
Add core and workspace functional test for TCA option
'localizeReferencesAtParentLocalization' with type=group
to nai...
Nikita Hovratov
18:47 Revision 8ff90ffd: [BUGFIX] Fix undefined key warning in EXT:frontend with PHP8
When using a text content element with a table inside bodytext,
you will have a PHP warning: Undefined array key "1."...
Florian Rival
18:16 Revision bcdfb9e8: [BUGFIX] Streamline arguments for logicalAnd() query in Extbase
The method signature of Query::locicalAnd() is very misleading
because it only states there is one method argument $c...
Alexander Schnitzler
18:09 Revision b94e462f: [DOCS] Fix typos in changelog
Resolves: #95924
Releases: master
Change-Id: Id341014507623e1f1aa07721d81d0667b7cdef04
Reviewed-on: https://review.ty...
Chris Müller
17:37 Revision 379bfc87: [BUGFIX] Cast tokenValue to string in ext:impexp
Cast 'tokenValue' to string as it can happen to be an integer.
Releases: master
Resolves: #95887
Change-Id: I2c05392...
Marcel Schüßler
17:22 Revision 538e4c2b: [BUGFIX] Fix several doc block types in extbase persistence
To ease the work with phpstan and IDE's, some types in
persistence related classes of extbase are now either
fixed or...
Alexander Schnitzler
17:04 Revision 12f84c73: [BUGFIX] Fix several doc block types in extbase persistence
To ease the work with phpstan and IDE's, some types in
persistence related classes of extbase are now either
fixed or...
Alexander Schnitzler
17:04 Revision c99dfecb: [BUGFIX] Replace non existing icon in DB Check
It's possible to query for deleted records in DB Check
"Full search". Such records can then be restored only
or addit...
Oliver Bartsch
16:45 Revision a572e67d: [BUGFIX] Replace non existing icon in DB Check
It's possible to query for deleted records in DB Check
"Full search". Such records can then be restored only
or addit...
Oliver Bartsch
16:33 Revision 6e319afb: [BUGFIX] Restore new pages behavior in context menu
In prior versions, creating a new page via the context
menu inserted the new page "inside". This however
changed to "...
Oliver Bartsch
16:13 Revision 842e9659: [TASK] Skip localization mode selection in localization wizard
In case only one localization mode is available, e.g.
because a localization mode was already defined for
the transla...
Oliver Bartsch
16:09 Revision 03cc0ab9: [BUGFIX] Streamline arguments for logicalAnd() query in Extbase
The method signature of Query::locicalAnd() is very misleading
because it only states there is one method argument $c...
Alexander Schnitzler
16:07 Revision fef1fa97: [BUGFIX] Properly respect offset in QueryGenerator
The pagination feature in DB Check "Full search" did
not work, since the defined offset was not added to
the query.
...
Oliver Bartsch
16:06 Revision ae11be46: [BUGFIX] Restore new pages behavior in context menu
In prior versions, creating a new page via the context
menu inserted the new page "inside". This however
changed to "...
Oliver Bartsch
16:04 Revision 77e62e2a: [BUGFIX] Save correct table name as ref_table in refindex
The identifier from the linkHandler page TSconfig was formerly used as
the reference table name "ref_table". This ide...
Nikita Hovratov
15:56 Revision 97dd051a: [BUGFIX] Fix warning in InputLinkElement
Resolves: #95917
Releases: master
Change-Id: I0a02c5f9ac49b4523fe754d5a0a1e86b6a57eb34
Reviewed-on: https://review.ty...
Nikita Hovratov
15:55 Revision 9d3e4924: [BUGFIX] Avoid call mb_strlen(null) in GeneralUtility::fixed_lgd_cs
GeneralUtility::fixed_lgd_cs() may be called with null instead of a
string as first argument, which is passed to mb_s...
Stefan Bürk
15:54 Revision b6ee2a25: [BUGFIX] Properly respect offset in QueryGenerator
The pagination feature in DB Check "Full search" did
not work, since the defined offset was not added to
the query.
...
Oliver Bartsch
12:58 Revision 2eb2eae7: [BUGFIX] Avoid calling htmlspecialchars(null) in DatabaseRecordList
DatabaseRecordList::renderListRow() used the return value of
called BackendUtility::getProcessedValueExtra() to feed ...
Stefan Bürk
12:51 Revision 358d21e5: [TASK] selenium/standalone-chrome:4.0.0-20211102
Latest 3.141 again leads to trouble with timeout
exceptions. 4.0 seems to behave better ... let's
raise again to see ...
Christian Kuhn
10:17 Revision 9f1c636d: [BUGFIX] Deprecation free SplObjectStorage in ModuleDataStorageCollection
Add PHP 8.1 attribute #[\ReturnTypeWillChange] with todo to set
correct return type as breaking change in v12 to sati...
Stefan Bürk
07:40 Revision 04a13580: [BUGFIX] Use correct selector for progress bar in workspaces
Since #91085, sending a remote request in workspaces,
e.g. sending records to another stage, is visualized by
a progr...
Oliver Bartsch
07:20 Revision ff68c3ec: [BUGFIX] Fix translation handling in vendor packages
When installing TYPO3 and Extensions into the vendor folder, no language
files can be loaded anymore because of an im...
Simon Gilli
00:20 Revision e0f48938: [BUGFIX] Deprecation free \SplSubject in ExtensionXmlParser
Set void return type for @internal class ExtensionXmlParser
to satisfy PHP 8.1 strict return on SPL classes.
Resolve...
Stefan Bürk
00:10 Revision 25ef8a70: [BUGFIX] Avoid calling nl2br(null) in Nl2brViewHelper
Nl2brViewHelper::renderStatic() calls nl2br with the return
of the called $renderChildrenClosure which may return nul...
Stefan Bürk

2021-11-08

18:36 Revision 0215c4ef: [TASK] Use icon identifier in module configurations
In most module configurations icons with a distinct path are
used. This is not necessary, as the module icons are alr...
Chris Müller
18:07 Revision c6cebd76: [BUGFIX] Properly handle deleted placeholders in TCA group and select
The TCA types "group" and "select" are both using the
relation handler to resolve items from foreign tables.
Previous...
Robert Vock
17:42 Revision 81f6cb1c: [BUGFIX] Properly handle deleted placeholders in TCA group and select
The TCA types "group" and "select" are both using the
relation handler to resolve items from foreign tables.
Previous...
Robert Vock
15:55 Revision 61e6912f: [TASK] Remove inline JavaScript in view module
This patch removes inline JavaScript usage for the
refresh button in ViewModuleController.
Resolves: #95896
Releases...
Torben Hansen
14:26 Revision 22b73bf0: [TASK] Fix return type declaration for slug provider
PHPDoc block for method PageSlugCandidateProvider::getCandidatesForPath()
had incorrect return type of string[].
Thi...
Sybille Peters
13:49 Revision 9f23ccc8: [TASK] Fix return type declaration for slug provider
PHPDoc block for method PageSlugCandidateProvider::getCandidatesForPath()
had incorrect return type of string[].
Thi...
Sybille Peters
12:11 Revision eff105bc: [TASK] Update selenium/standalone-chrome
Resolves: #95883
Releases: master
Change-Id: I54cf7f2e0c8e968d8f29151b1621b54357681ab2
Reviewed-on: https://review.ty...
Jochen Roth
12:02 Revision 48a65a91: [BUGFIX] Use forced scheme only if set and not empty
The forced scheme needs to be checked if not empty and not
only if existing. The regression has been introduced with ...
Georg Ringer
11:40 Revision 907e65ec: [BUGFIX] Add missing cookie option on install tool logout
Add the missing samesite cookie option after the logout from the
install tool which leads to an error in the browser ...
Simon Gilli
11:35 Revision 4be84438: [BUGFIX] Use forced scheme only if set and not empty
The forced scheme needs to be checked if not empty and not
only if existing. The regression has been introduced with ...
Georg Ringer
11:29 Revision 6c43cba2: [BUGFIX] Stabilize recycler AC test
Currently the acceptance test for the
recycler module uses "see" to check
if a text appears in the flashmessage
which...
Jochen Roth
11:01 Revision e8b2f248: [TASK] Change requirement for finediff
Change requirement from cogpowered/finediff to lolli42/finediff.
This was already done for v11 - due to problems with...
Sybille Peters
10:52 Revision e357856d: [TASK] Simplify finder initialization in php-cs-fixer.php
Use ignoreVCSIgnored for the Symfony finder initialization
in php-cs-fixer.php to automatically ignore all files
from...
Torben Hansen

2021-11-05

15:53 Revision 0206b833: [TASK] Improve readability of ext:redirects documentation
This commit improves the overall readability of the
ext:redirects documentation.
Releases: master, 10.4
Resolves: #9...
Tom Warwick
15:23 Revision 8d6ae5a4: [TASK] Improve readability of ext:redirects documentation
This commit improves the overall readability of the
ext:redirects documentation.
Releases: master, 10.4
Resolves: #9...
Tom Warwick
12:34 Revision 22702bd6: [TASK] Make HtmlParser PHP8 compatible
Class \TYPO3\CMS\Core\Html\HtmlParser generates a lot of undefined
key warnings when running with PHP 8. It needs to ...
Francois Suter
12:31 Revision 04cd3f0a: [BUGFIX] Translate image dimensions on file replace
Width and height of an image is stored in translatable metadata
records. These properties are extracted by FAL API wh...
André Buchmann
11:54 Revision bdc1bc40: [BUGFIX] Do not HTML encode attributes in Script and Asset VH
ScriptViewHelper and AssetViewHelper do not directly output any tag,
but only pass the arguments to AssetCollector.
...
Helmut Hummel
11:53 Revision 759565d4: [TASK] Streamline composer.json deficit detector
Code for scanning extension folders and populating
information from that, is removed to use already
available API in ...
Helmut Hummel
11:31 Revision d8c9d5ab: [BUGFIX] Do not HTML encode attributes in Script and Asset VH
ScriptViewHelper and AssetViewHelper do not directly output any tag,
but only pass the arguments to AssetCollector.
...
Helmut Hummel
11:22 Revision 685b64b3: [BUGFIX] Translate image dimensions on file replace
Width and height of an image is stored in translatable metadata
records. These properties are extracted by FAL API wh...
André Buchmann
11:04 Revision 9636932c: [BUGFIX] Add missing cookie option on install tool logout
Add the missing samesite cookie option after the logout from the
install tool which leads to an error in the browser ...
Simon Gilli
10:20 Revision a1074fbe: [BUGFIX] Fix EditableRestriction for linkvalidator
EditableRestriction in linkvalidator checks which fields are editable
Doing so, it also considers the allow / deny ty...
Sybille Peters
10:11 Revision 70ce8871: [BUGFIX] Initialize selected crop variant on modal open
In the cropper modal the initial aspect ratio
is not respected.
This has been fixed by triggering the update method
...
Jochen Roth
10:04 Revision 0c292e8f: [BUGFIX] Fix EditableRestriction for linkvalidator
EditableRestriction in linkvalidator checks which fields are editable
Doing so, it also considers the allow / deny ty...
Sybille Peters
09:34 Revision a15953b4: [BUGFIX] Suppress E_DEPRECATED for strftime() and gmstrftime()
PHP functions strftime() and gmstrftime() have been deprecated in
PHP 8.1 and will be removed in PHP 9.0. Currently, ...
Stefan Bürk
08:38 Revision 7b94fb38: [DOCS] Minor fixes in redirects docs
Resolves: #95865
Related: #95816
Releases: master, 10.4
Change-Id: Ic9fecfbe07abf98af8d9b8f73d54f3482643c372
Reviewed...
Sybille Peters
08:04 Revision 6c15f2c5: [DOCS] Minor fixes in redirects docs
Resolves: #95865
Related: #95816
Releases: master, 10.4
Change-Id: Ic9fecfbe07abf98af8d9b8f73d54f3482643c372
Reviewed...
Sybille Peters
05:35 Revision 7c0dac58: [BUGFIX] Ensure form finisher dependencies can get injected
With #94317 the instantiation of form finishers has been changed by
replacing `ObjectManager::get()` in favor of
`Gen...
Elias Häußler

2021-11-04

16:31 Revision bf13e4ef: [BUGFIX] Restore SummaryPage path for form single value access
Resolves: #95868
Releases: master, 10.4
Change-Id: Iffc8ed042f4990b132c28a0ff7b4d80ffca530ac
Reviewed-on: https://rev...
Mathias Brodala
16:31 Revision d2d8ee23: [TASK] Remove unnecessary assertions from tests
Resolves: #95197
Releases: master
Change-Id: I39683431de4cfbc3f6f84b8f096c079e978e5d8f
Reviewed-on: https://review.ty...
Wouter Wolters
16:22 Revision 1b6f7545: [BUGFIX] Fix #modulemenu collapsed state on Firefox
This fixes cut modulemenu icons on Firefox when scrollbars are shown.
It has been fixed before, but since then seemin...
Jonas Eberle
16:15 Revision 29104e35: [BUGFIX] Restore SummaryPage path for form single value access
Resolves: #95868
Releases: master, 10.4
Change-Id: Iffc8ed042f4990b132c28a0ff7b4d80ffca530ac
Reviewed-on: https://rev...
Mathias Brodala
16:13 Revision 448d081c: [TASK] Fix warning in GridColumnClassAutoConfigurationViewHelper
Resolves: #95871
Related: #95859
Releases: master
Change-Id: I0982c2289e00c7eaecfaa0dab89d184e09148f0f
Reviewed-on: h...
Nikita Hovratov
16:11 Revision 5d7593b4: [TASK] Use direct method invocation instead of calling it static
In the process, some tests calling tests (which is bad style) have
been disentangled by calling the code explicit, ra...
Wouter Wolters
15:05 Revision b3ee53cd: [BUGFIX] Enriched relation values in rootline do not consider overlays
The overlay handling (localization and workspaces) of relation values
resolved in the RootlineUtility do only conside...
Oliver Hader
14:20 Revision f6c3f6ce: [TASK] Set actions to protected in Dashboard
Currently all "*Action" are set to public which isn't
neccessary because the handleRequest() dispatches
these actions...
Jochen Roth
14:18 Revision 00c7a5ea: [BUGFIX] Ensure view initialisation in FluidEmail
FluidEmail view object is null after deserialisation
causing an error when flushing the file spool queue.
Ensure the ...
Anja Leichsenring
14:18 Revision c47cd42a: [BUGFIX] Update feature toggles state at once
When updating feature toggles, the corresponding method
iterates over all feature toggles and checks if those
state c...
Davide Alghi
13:55 Revision 7c238eea: [BUGFIX] Ensure view initialisation in FluidEmail
FluidEmail view object is null after deserialisation
causing an error when flushing the file spool queue.
Ensure the ...
Anja Leichsenring
13:38 Revision 7523178b: [BUGFIX] Do not show empty colPos message for special unused column
Columns, not having a colPos defined, are considered as
inaccessible. A event listener therefore enriches such
column...
Oliver Bartsch
13:35 Revision 9758a7a0: [BUGFIX] Document proper paths for form single value access
Resolves: #95868
Releases: master, 10.4
Change-Id: I443ba87dd97e1efacbaf441a1263dd47ec1e1aa2
Reviewed-on: https://rev...
Mathias Brodala
13:23 Revision d0d568a6: [BUGFIX] Document proper paths for form single value access
Resolves: #95868
Releases: master, 10.4
Change-Id: I443ba87dd97e1efacbaf441a1263dd47ec1e1aa2
Reviewed-on: https://rev...
Mathias Brodala
13:11 Revision 1cfc588b: [BUGFIX] Use search_field value from session again
search_field value from session is never used again anymore, fixed that regression
Resolves: #94898
Releases: 10.4
C...
Martin Neumann
13:05 Revision 5f4142b8: [BUGFIX] Fix redirect on failed login when redirectMode is unset
This commit adds the missing additional check that a redirect happens
only on a successful login or logout, even if p...
Volker Diels-Grabsch
12:20 Revision 7cf2035c: [BUGFIX] Fix overlapping FormEngine fields
Because of normal selectSingle fields having the css property
"width: auto", very long text forces those fields to sp...
Nikita Hovratov
11:29 Revision 36e8427f: [TASK] Remove default values in TCA of core fields
This removes the default values for:
- minitems = 0 in general
- size = 1 with renderType = selectSingle
minitems =...
Nikita Hovratov
11:18 Revision 283c5b73: [TASK] Optimize AC tests to use dataProvider
Currently some acceptance tests do not use a
data provider as intended.
These tests have been optimized to use the
d...
Jochen Roth
11:03 Revision 46318d9a: [TASK] Enhance deprecation message for table pages_language_overlay
Regardless of existance of table pages_langugage_overlay in database,
a deprecation message for TCA migration is logg...
Anja Leichsenring
10:59 Revision fb65ea08: [BUGFIX] Ensure indexed search stats are only written when not empty
This change fixes a regression introduced with #92993 when
removing personalized search statistics.
A simple search ...
Benni Mack
10:57 Revision 16839fac: [BUGFIX] Replace filter_var(FILTER_SANITIZE_STRING) in RequestBuilder
Sanitize filter 'FILTER_SANITIZE_STRING' has been deprecated
since PHP 8.1 and will be removed in PHP 9.
ext:extbase...
Stefan Bürk
09:56 Revision 072a7c49: [TASK] Set word-wrap to avoid a horizontal scrollbar in modal
A long database name currently causes the
modal to show scroll bars.
This has been fixed by setting word-wrap
for li...
Jochen Roth
07:51 Revision ef62556d: [BUGFIX] Show errors when failing to write site configuration
This patch adds an error if the site configuration file cannot be
written or deleted.
Exceptions thrown while failin...
Stephan Großberndt
07:21 Revision 636b3d83: [BUGFIX] Fix cache clearing when publishing from workspace
With #89555 cache clearing has been disabled
if the user is currently in a workspace.
This is fine in most cases, bu...
Benjamin Franzke
06:43 Revision e9dae46a: [BUGFIX] Fix cache clearing when publishing from workspace
With #89555 cache clearing has been disabled
if the user is currently in a workspace.
This is fine in most cases, bu...
Benjamin Franzke

2021-11-03

21:24 Revision c3c3da21: [BUGFIX] Fix problem of disabled buttons in pagination
Due to improvements for accessibility, the contrast between
color and background color was increased for disabled but...
Sybille Peters
21:22 Revision ff70e5e9: [BUGFIX] Keep pagination in redirect module if editing record
Remember the current page in the redirects module if the pagination
is used - just as filter values.
Resolves: #9578...
Georg Ringer
21:11 Revision 5bd58ebf: [BUGFIX] Use callout component on install tool login page
The Install Tool Login page shows informational boxes like the one
that by default the Install Tool password is the o...
Marcin Sągol
21:04 Revision ff10a66f: [BUGFIX] Avoid accessing FAL compatibility layer
When accessing static files via FAL API,
the compatibility layer (storage 0) kicks in.
This compatibility layer has m...
Helmut Hummel
20:37 Revision 276f73e5: [BUGFIX] Avoid calling quote with non-string value in QueryGenerator
ext:lowlevel QueryGenerator calls quote(...) with non string value as
first parameter which ends in a E_DEPRECATED as...
Stefan Bürk
20:26 Revision 22fe7f95: [BUGFIX] Sanitize calling htmlspecialchars(...) in FormViewHelper
htmlspecialchars(...) expects that first argument is a string,
otherwise triggering E_DEPRECATED.
This patch adds a ...
Stefan Bürk
20:18 Revision 22eef509: [TASK] AC test Environment -> Image Processing cards and its modals
Added acceptance test for all missing cards in
"Environment -> Image Processing".
to see headline, buttons and expect...
Jochen Roth
19:45 Revision c100b68a: [BUGFIX] Use CodeMirror auto sizing feature correctly
To use CodeMirror's auto sizing feature, we need
to set the style attribute of the wrapper element
to "auto", instead...
Nikita Hovratov
19:02 Revision 71e54dec: [BUGFIX] Extend condition for isOnSymmetricSide
Instead of holding only the uid as a plain value the given databaseRow
array of the symmetric_field can hold an array...
Tim Karliczek
17:32 Revision ac2e3264: [BUGFIX] Fix Environment overview with using SQLite
This change allows for the db connection parameters 'user',
'host' and 'port' to be empty, as it happens when using S...
Maik Beckmann
17:15 Revision ed782614: [BUGFIX] Restore inconsistent language highlighting
The page module displays a flash message for page
translations with inconsistent ("mixed mode") content
elements. The...
Oliver Bartsch
17:14 Revision 05bf4c86: [BUGFIX] Delete orphans that are deleted or hidden
All restrictions are removed from the query builder that
fetches the orphan records.
A seperate query builder instan...
Alexander Stehlik
17:01 Revision 914d8165: [BUGFIX] Fix various context menu visibility issues
The context menu skeleton is partially visible for a very short time,
before its items are rendered and event listene...
Andreas Fernandez
16:50 Revision 0ccee3fe: [DOCS] Create extension manual for t3editor
Resolves: #95836
Releases: master
Change-Id: Id7667dcfc5b6e16662a1087c7d5591be32510c64
Reviewed-on: https://review.ty...
Lina Wolf
16:31 Revision 3ac8d245: [TASK] Streamline page tree delete modal
The page tree delete modal labels have been
changed to align with all other delete modals.
Resolves: #95817
Related:...
Jochen Roth
16:10 Revision 4d971a54: [BUGFIX] Fix undefined key warning in EXT:form with PHP8
When using a form witch contains a fieldset element,
you will have a PHP warning:
Undefined array key "xs" in GridCol...
Florian Rival
15:41 Revision 129c8e89: [DOCS] Documentation for EXT:redirects
Resolves: #88570
Releases: master, 10.4
Change-Id: Iaf39f5d2b3d8509f405162d25b1de73d71e27c5d
Reviewed-on: https://rev...
Sybille Peters
15:32 Revision 3e9c656f: [BUGFIX] Show relational indices issues in EXT:lowlevel again
This change re-adds the output on "DB Relations"
of the "DB Check" module by having proper (PHP 8) related
checks on ...
Benni Mack
15:25 Revision 58b9d00b: [BUGFIX] Delete orphans that are deleted or hidden
All restrictions are removed from the query builder that
fetches the orphan records.
A seperate query builder instan...
Alexander Stehlik
15:19 Revision 4f5bd63c: [TASK] Use dedicated JavaScript LoginRefresh.initialize(options)
Instead overriding class member variables externally, existing
initialize() method has been extended to support optio...
Oliver Hader
15:17 Revision ca065026: [TASK] Normalize JavaScript initialization of workspaces preview
Ensures workspaces PreviewController uses dedicated method to declare
client-side settings PageRenderer::addInlineSet...
Oliver Hader
15:03 Revision e407449a: [TASK] Use dedicated JavaScript initialization for form manager
To avoid having nested require.js inline JavaScript, initialization
of the form manager uses a dedicated helper modul...
Oliver Hader
14:11 Revision 530eef76: [DOCS] Add README.rst as "about" file to system extensions
Fix links to system extension in composer.json documentation where it
was still missing. Remove reference to docs_ind...
Lina Wolf
13:53 Revision d03867a4: [TASK] Add acceptance test for recycler module
An acceptance test for recycler has been added to
ensure the modules works as expected.
This acceptance test covers ...
Jochen Roth
13:04 Revision 75b261dc: [TASK] Avoid using public property ModuleLoader::$modules
Changes read-access to modules from `ModuleLoader::$modules`
to `ModuleLoader::getModules()`.
Resolves: #95851
Relea...
Oliver Hader
12:40 Revision 288e88db: [DOCS] Documentation for EXT:redirects
Resolves: #88570
Releases: master, 10.4
Change-Id: Iaf39f5d2b3d8509f405162d25b1de73d71e27c5d
Reviewed-on: https://rev...
Sybille Peters
12:25 Revision 1dd425df: [BUGFIX] Prevent array to string conversion in IconFactory
When mapping a 'pages' row to an icon, the 'module' field
might be both an array or a string. Reloading the page tree...
Robert Kärner
11:59 Revision 147b9272: [BUGFIX] Fix IRRE related undefined key warnings
Two occurrences in the DataHandler and another in
InlineRecordContainer needed fallbacks for array access.
Resolves:...
Robert Kärner
11:55 Revision 695c6ad1: [BUGFIX] Fix rendering of specific format body in FluidEmail
Previously it was not possible to trigger the email
body generation for a specific format, since FluidEmail
only impl...
Oliver Bartsch
11:28 Revision fb19a0cc: [TASK] Expose all properties of JavaScriptModuleInstruction as JSON
Resolves: #95847
Releases: master
Change-Id: Ia4bbb85c473fb5c6a9ca0461765756a014cc3492
Reviewed-on: https://review.ty...
Oliver Hader
11:15 Revision fbbdfe7b: [TASK] Upgrade PHPStan to latest version 0.12.99
This is the latest version before 1.0.0 release.
PHPStan 1.0 is going to be PHPStan 0.12.99 + bleeding edge + BC brea...
Wouter Wolters

2021-11-02

13:05 Revision 94682589: [BUGFIX] Avoid calling str_contains(null) in DataHandler
Method convNumEntityToByteValue() has been removed through #95789,
thus the one place it was called was removed also....
Stefan Bürk
13:05 Revision 854669bd: [BUGFIX] Sanitize calling htmlspecialchars(...) in TextareaViewHelper
htmlspecialchars(...) expects that first argument is a string,
otherwise triggering E_DEPRECATED.
This patch adds a ...
Stefan Bürk
13:05 Revision 55c5f66b: [BUGFIX] Sanitize calling htmlspecialchars(...) in SelectViewHelper
htmlspecialchars(...) expects that first argument is a string,
otherwise triggering E_DEPRECATED.
This patch adds a ...
Stefan Bürk
08:59 Revision 586d475b: [BUGFIX] Clean up clipboard before using it in ContextMenu
Some item providers (context menu) access
clipboard information. Since the clipboard was
previously not properly init...
Oliver Bartsch
08:51 Revision 87283af3: [TASK] Set TYPO3 version to 11.5.3-dev
Change-Id: I4572a09db3db194a31ff3c1fd40a08e0b6c7ca23
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/720...
Benni Mack
08:24 Revision 96a71bec: [RELEASE] Release of TYPO3 11.5.2
Change-Id: Ia1abfc52ec70cb81d005d41158c715a585061554
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/720...
Benni Mack
08:10 Revision e7427f83: [BUGFIX] Add missing file extensions of language files
In some places the file extensions of language files are missing and
properly added with this patch.
Resolves: #9584...
Simon Gilli
08:00 Revision 47c4a2f0: [BUGFIX] Keep pagination in redirect module if editing record
Remember the current page in the redirects module if the pagination
is used - just as filter values.
Resolves: #9578...
Georg Ringer

2021-11-01

17:58 Revision 1fabd9a8: [TASK] Update jQuery
Albeit we're removing jQuery step by step, we shall provide updated libs,
which takes effect for jquery.
Executed co...
Andreas Fernandez
12:07 Revision 4362e632: [DOCS] Add link to 11.5.x changelog
Resolves: #95837
Releases: master
Change-Id: I0b7169ec25a7f17ded6735b612ee51c25aa39d4d
Reviewed-on: https://review.ty...
Chris Müller
12:05 Revision 7485a170: [TASK] Refactor localization tests
The XliffParserTest are refactored using a DataProvider which also
eliminates duplicate test code.
The override test...
Simon Gilli
10:56 Revision 29693b8d: [BUGFIX] Don't throw exceptions for private paths
Instead of throwing an exception when resolving
the path to private resources, a deprecation message
is now shown.
R...
Helmut Hummel
10:29 Revision f8927810: [BUGFIX] Fix PHP 8 warnings in FlexFormElementContainer
Resolves: #95804
Releases: master
Change-Id: I884741a4ecb7fdbc0cabd96f4975ea6629726d31
Reviewed-on: https://review.ty...
Nikita Hovratov
10:19 Revision c1cb0ced: [BUGFIX] Undefined array key in install tool
Fixes two undefined array keys in the install system extension's
UpgradeWizardsService.php that cause errors in PHP 8...
Mathias Bolt Lesniak

2021-10-29

13:17 Revision 96e0e384: [BUGFIX] Ensure regexp capture group works with relative target
RedirectService has been using LinkHandler to retrieve
the targeturl, thus supporting all TYPO3 has to offer,
like t3...
Stefan Bürk
08:10 Revision 392edf84: [BUGFIX] Ensure regexp capture group works with relative target
RedirectService has been using LinkHandler to retrieve
the targeturl, thus supporting all TYPO3 has to offer,
like t3...
Stefan Bürk

2021-10-28

10:26 Revision 80ddf137: [TASK] Add missing whitespace after assign operator
Resolves: #95809
Releases: master
Change-Id: I7e5e9edc404ed8131461d112abee4c1cedb2ab1b
Reviewed-on: https://review.ty...
Nikita Hovratov

2021-10-27

19:00 Revision a11869c0: [BUGFIX] Fix warning in BackendUserAuthentication
Check if filemounts are available before accessing those.
Resolves: #95780
Releases: master
Change-Id: I0f475a7add63...
Georg Ringer
19:00 Revision 0770646d: [DOCS] Fix typo in deprecation note
Resolves: #95803
Releases: master
Change-Id: I3c69e40bac77c46a5c2bd0d5bf68a20f36a037a0
Reviewed-on: https://review.ty...
Chris Müller
18:59 Revision 12ae143f: [BUGFIX] Prepare doctrine facades towards PHP 8.1
\PDO::quote() is picky about the type argument
in PHP 8.1. doctrine/dbal partially works around
that and will improve...
Christian Kuhn
09:57 Revision 29651da7: [BUGFIX] Harden types in ImageContentObject linkWrap()
Protected method linkWrap() should only be called
with string arguments - they are for instance fed
to explode(). Ins...
Christian Kuhn

2021-10-26

21:44 Revision f6544df9: [BUGFIX] Fix warning when query result is written to csv file
The function fputcsv gets an enclosure as third parameter. Providing an
empty string as enclosure leads to following ...
Florian Sommer
21:36 Revision e00c3173: [BUGFIX] Catch and log Exception in image size detection
When the mime type of a file can not be correctly determined
by ImageMagick when detecting image sizes, fail silently...
Alexander Stehlik
21:32 Revision 46554c1e: [BUGFIX] Avoid warning in ContentObjectRenderer
getData() may emit E_WARNING accessing $tsfe->page and
$config. Sanitize that by null coalescing to empty
string.
Re...
Christoph Lehmann
21:31 Revision 7e8ea60b: [BUGFIX] Fix PHP warnings in ext:lowlevel DB Check
This prevents exceptions for missing array keys when using
the query generator for the DB Check backend module.
Reso...
Guido Schmechel
21:30 Revision 90e8e66d: [BUGFIX] Explicit string cast for string expecting functions
PHP 8.1 in non strict_types context emits E_DEPRECATED
with various functions that expect strings but are
called givi...
Christian Kuhn
21:30 Revision 7ad00012: [BUGFIX] Avoid broken mock return in ActionControllerTest
ActionControllerTest mocks a view to test things. The subject
calls renderSection() on that mock. renderSection() mus...
Stefan Bürk
21:29 Revision 1a30b82b: [TASK] Add " around ignore in .stylelintrc
.stylelintrc is a json-like config and needs
to quote keys.
Releases: master
Resolves: #95785
Change-Id: I626e956af5...
Kim Christiansen
21:28 Revision 63a387ca: [BUGFIX] Fix warning when query result is written to csv file
The function fputcsv gets an enclosure as third parameter. Providing an
empty string as enclosure leads to following ...
Florian Sommer
21:18 Revision 13990500: [BUGFIX] Sanitize unserialize() in ProcessedFile
Table sys_file_processedfile field configuration is a
blob. It usually contains a serialized array with
processing in...
Christian Kuhn
20:31 Revision 972d623d: [BUGFIX] Drop a strange internal DataHandler method
That's a seldom gem.
Method convNumEntityToByteValue() in DataHandler
is *seriously* strange. It exists since very e...
Christian Kuhn
18:46 Revision 177b087f: [BUGFIX] Avoid calling trim(null) in PageRenderer
PageRender sanitizes array values in two methods, using
array walk with trim(). These values can be other
types then ...
Stefan Bürk
18:42 Revision 8e48aff7: [BUGFIX] Avoid coalescence to null for string expecting functions
Various functions expect string arguments and emit
E_DEPRECATED with PHP 8.1 in non strict_types=1
calls. The patch a...
Christian Kuhn
11:51 Revision 4a87bd2e: [BUGFIX] Properly return path relative to public dir in FilePathSanitizer
The assumption for FilePathSanitizer::sanitize is to return file names
relative to the public directory of TYPO3.
Th...
Florian Rival
11:29 Revision 3b7a862f: [BUGFIX] Fix warning in NewContentElementController
Resolves: #95778
Releases: master
Change-Id: I764dc299cb192e4ebbcb00b21553f474355c55cb
Reviewed-on: https://review.ty...
Nikita Hovratov
08:09 Revision 336a91ef: [BUGFIX] Enforce $GLOBALS['LANG']->sL() returns string
Calling LanguageService->sL() should *always* return
a string, even if it's empty. The patch enforces this.
This rev...
Christian Kuhn

2021-10-25

20:19 Revision 497f313e: [BUGFIX] Avoid trim(null) in ContentObjectRenderer->stdWrap_*()
Calling trim() with something else than a string
emits a E_DEPRECATED error with PHP 8.1.
Some ContentObjectRenderer-...
Christian Kuhn
20:19 Revision 41af981c: [BUGFIX] Avoid str_replace(..., null) in ContentObjectRenderer
Calling str_replace() with second argument non-string is
deprecated as of PHP 8.1. Sanitize stdWrap_brTag() in
Conten...
Christian Kuhn
20:18 Revision 9d559bd5: [BUGFIX] Avoid str_replace(..., null) in AbstractMenuContentObject
PHP 8.1 emits E_DEPRECATED if second argument to
str_replace() is null. Adapt a null coalescence
and add a cast to st...
Christian Kuhn
18:12 Revision 8cc1e210: [BUGFIX] Avoid deprecated FILTER_SANITIZE_STRING in TextValidator
The filter_var() filter FILTER_SANITIZE_STRING is
deprecated as of PHP 8.1.
Extbase TextValidator uses it. Goal of t...
Christian Kuhn
18:03 Revision 3e27e566: [BUGFIX] Let GeneralUtility::getIndpEnv() return string more often
We unfortunately still didn't manage to drop remaining
usages of GeneralUtility::getIndpEnv() and deprecate
the metho...
Christian Kuhn
18:00 Revision cf1a8900: [BUGFIX] Avoid incomplete mock in FluidTemplateContentObjectTest
FluidTemplateContentObject calls:
$headerAssets = $this->view->renderSection(...);
if (!empty(trim($headerAssets))) {...
Christian Kuhn
17:53 Revision c2f7e056: [BUGFIX] Avoid implicit conversion to int in StringUtility
StringUtility::multibyteStringPad() does a happy division
feeding str_repeat() to evenly pad on left and right side.
...
Christian Kuhn
17:50 Revision cbc0b420: [BUGFIX] Avoid calling strlen(null) in FrontendUserAuthentication
GeneralUtility::_POST($this->formfield_permanent) returns
null if that field is not set in $_POST. Feeding null
to st...
Christian Kuhn
14:54 Revision c22da2db: [BUGFIX] Avoid error when loading title of TCA table in New Record Controller
This change uses the PackageManager API to fetch the
extension key title, and also solves a small issue when
the TCA ...
Benni Mack
13:57 Revision 8e2dd7c9: [DOCS] Document changed behavior with Composer and extensions
With #94996 the behavior for composer based installations changed:
- All extensions are always active
- PackageState...
Georg Ringer
13:05 Revision 7cea7737: [BUGFIX] Update composer dev dependencies to min required versions
phpunit released new versions for 8.5.x and 9.5.x, which
no longer automatically throw exception for user deprecation...
Stefan Bürk
12:30 Revision 2db46283: [TASK] Improve error messages for linkvalidator
- Error code 500 used to be displayed as the generic "Network error
/ invalid domain" which was misleading
- Libcur...
Sybille Peters

2021-10-24

17:42 Revision 4ce01c53: [BUGFIX] Deprecation free interfaces in FinisherVariableProvider
Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in FinisherVariabl...
Stefan Bürk
17:22 Revision afac6ed0: [BUGFIX] Deprecation free \Countable in FileCollector
Set int return type for @internal class FileCollector
to satisfy PHP 8.1 strict return on SPL classes.
Resolves: #95...
Stefan Bürk
17:16 Revision a2bf18f5: [BUGFIX] Deprecation free \ArrayAccess in FormRuntime
Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in ext:form FormRu...
Stefan Bürk
17:11 Revision 97623be2: [BUGFIX] Suppress deprecation in EmptyFileSearchResult
Since PHP 8.1 The Countable interface has tentative
return types. This means mismatching return types
trigger depreca...
Nikita Hovratov
17:04 Revision 0c537280: [BUGFIX] Deprecation free \ArrayAccess in LinkResult
Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in ext:frontend Li...
Stefan Bürk
16:46 Revision 2e0ba1b9: [BUGFIX] Deprecation free \Countable in AbstractCompositeValidator
Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in AbstractComposi...
Stefan Bürk
16:45 Revision 7100961d: [BUGFIX] Deprecation free \ArrayAccess in ArrayAccessClass
Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in ext:extbase Arr...
Stefan Bürk
15:58 Revision 6c7eabdd: [BUGFIX] Use correct return type annotations in validation results
Three methods in Extbase's Result are now
annotated with the correct return type to
make PHPStan happy when they are ...
Robert Kärner
15:46 Revision fcf33351: [BUGFIX] Deprecation free \ArrayAccess and \Iterator in QueryResult
Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in ext:extbase Que...
Stefan Bürk
15:40 Revision 5db9be7a: [BUGFIX] Use correct return type annotations in validation results
Three methods in Extbase's Result are now
annotated with the correct return type to
make PHPStan happy when they are ...
Robert Kärner
15:37 Revision edd2ef46: [TASK] Streamline log_data fetching
This change now uses allowed_classes=false on all
calls of unserialize() for sys_log.log_data which
we did not have b...
Benni Mack

2021-10-23

22:41 Revision bf903bb6: [BUGFIX] Avoid invalid setup in Typo3StatusTest
Let getLL() return string in tests to avoid a
"sprintf(): Passing null to parameter #1" from
Typo3Status test. Saniti...
Christian Kuhn
22:40 Revision 7d63602e: [BUGFIX] Deprecation free \Iterator in LazyLoadingProxy
PHP 8.1 added concrete return types to internal
interfaces, classes and methods which triggers
deprecation messages, ...
Stefan Bürk
22:10 Revision 9b1849ba: [BUGFIX] Deprecation free ArrayObject in extbase Controller/Arguments
ext:extbase Controller/Arguments extends ArrayObject
which implements several interfaces. Since PHP 8.1
added concret...
Stefan Bürk
22:00 Revision 28c3cacf: [BUGFIX] Avoid passing null as parameter to trim()
To make units test notice free in #85092 a wrong
fallback for array access has been used.
Fallback to null and passi...
Stefan Bürk
21:30 Revision 2baa62ab: [BUGFIX] Use lolli42/finediff over cogpowered/finediff
finediff is used in various core places to render
a HTML "diff" view of two strings. The library didn't
see changes s...
Christian Kuhn
21:29 Revision 526f8a9f: [BUGFIX] Avoid passing null as parameter to trim()
To make units test notice free in #85092 a wrong
fallback for array access has been used.
Fallback to null and passi...
Stefan Bürk
21:29 Revision ead6a2ba: [BUGFIX] Ensure type inheritance compatibility for RouteResultInterface
PageArguments and SiteRouteResult implementing the
\ArrayAccess interface indirectly through implementing
RouteResult...
Stefan Bürk
20:44 Revision 2d60bff0: [BUGFIX] Avoid deprecation message in MetaDataAspect
MetaDataAspect implements multiple interfaces and has return type hints
that match the interfaces. Except for the off...
Stefan Bürk
20:42 Revision ed26bba2: [BUGFIX] Avoid incomplete setup for WebProcessorTest
WebProcessorTests uses GeneralUtillity::getIndpEnv()
directly or indirectly, thus triggering deprecation
message on P...
Stefan Bürk
20:17 Revision 3d0776f2: [BUGFIX] Avoid passing null parameter in SchemaColumnDefinitionListener
SchemaColumnDefinitionListener instantiates a new Column class and
passes the column name retrieved from an array. If...
Stefan Bürk
18:50 Revision a255ae77: [BUGFIX] Avoid incomplete setup in FileHandlingUtilityTest
Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for for...
Stefan Bürk
18:38 Revision 057d9f81: [BUGFIX] Avoid incomplete setup in ExtensionStatusTest
Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for for...
Stefan Bürk
18:36 Revision 19488f74: [BUGFIX] Deprecation free ArrayObject usage in backend tree
Classes TreeeNodeCollection and SortedTreeNodeCollection
extends ArrayObject and override some methods.
PHP 8.1 adde...
Stefan Bürk
18:26 Revision d41488cd: [BUGFIX] Avoid passing null to str_contains in TypoScript Parser
Releases: master
Resolves: #95646
Change-Id: I86d4f73ed49d46a20d20af4f5d10075c86b633dc
Reviewed-on: https://review.ty...
Stephan Sellner
18:21 Revision d64dce23: [BUGFIX] Add PHP 8.1 compatibility in AbstractRecordCollection
Since PHP 8.1, most internal classes are updated
with tentative return types. This will be enforced
with 9.0.
It mea...
Stefan Bürk
18:16 Revision 6c074475: [BUGFIX] Better redirects from sys_domain in redirects upgrade wizard
Feeding a sys_domain url to parse_url('example.com/bar')
gives ['path' => 'example.com/bar'], but we need something
l...
Mohsin Khan
14:56 Revision 5e33da68: [BUGFIX] Deprecation free Serializable usage in backend Tree
Classes TreeNode and TreeNodeCollection implement
deprecated \Serializable either directly, or indirectly
via \ArrayO...
Christian Kuhn
14:55 Revision ade5f9a9: [BUGFIX] Update EXT:blog_example TCA and ext_tables.php
* Adapted the TCA to work with v11.5.
* Cleaned up ext_tables.php
Resolves: #95724
Releases: master
Change-Id: Icd2c...
Jochen Roth

2021-10-22

14:49 Revision c18b9860: [TASK] Remove Web>Modules from TSconfig list
The select list in the module "Info > Page TSconfig" contained
"Module Web>Modules" in the select list. This refers t...
Sybille Peters
06:39 Revision 7bfe6f76: [BUGFIX] Make file paths absolute in GIFBUILDER
In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inc...
Simon Schaufelberger

2021-10-21

15:44 Revision ad7227df: [BUGFIX] Properly encode JSON when forwarding to RequireJS
When forwarding configuration as JSON encoded data when loading
RequireJS modules in form engine, escape sequences ne...
Oliver Hader
15:12 Revision 48e4e495: [BUGFIX] Make file paths absolute in GIFBUILDER
In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inc...
Simon Schaufelberger
13:44 Revision 40e974a1: [BUGFIX] Consider language in redirects:checkintegrity
The ext:redirects integrity check was implemented
without considering site language host and prefix for
the integrity...
Sybille Peters
12:27 Revision 30984658: [TASK] Add extension title to meta data and use it
Instead of reading the composer.json / ext_emconf.php
of extensions at runtime just to retrieve the extension title,
...
Helmut Hummel
11:45 Revision a167909c: [BUGFIX] Avoid using HTML sanitizer in reports module
Reports generated by custom data providers might contain
specific HTML markup (including JavaScript, SVG and styles)....
Oliver Hader
10:35 Revision 476e011e: [BUGFIX] Consider language dependencies in stdwrap.lang
$GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['dependencies']
keeps a list of language fallbacks for ...
Christoph Lehmann
10:26 Revision 1f4ab125: [BUGFIX] Consider language in redirects:checkintegrity
The ext:redirects integrity check was implemented
without considering site language host and prefix for
the integrity...
Sybille Peters
10:14 Revision 60b59034: [BUGFIX] Consider language dependencies in stdwrap.lang
$GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['dependencies']
keeps a list of language fallbacks for ...
Christoph Lehmann
05:44 Revision d4660f89: [BUGFIX] Hide non extension types from Extension lists
To avoid confusion for inexperienced TYPO3 Composer users
and for the time being, Composer packages that are not
of t...
Helmut Hummel

2021-10-20

17:39 Revision 4c36a1a0: [BUGFIX] Remove mssql quotes in QueryHelper::parseJoin()
Recently adding quote syntax to typoscript
definitions has been added through #94715,
which fails in nightly on mssql...
Stefan Bürk
14:11 Revision b671caf4: Revert "[TASK] Deprecation free Serializable usage in ObjectStorage"
This reverts commit c7c47956c054ef68e2847b06f15cf69b4025bc2c.
The patch did not make sense: A class that has methods...
Christian Kuhn
08:00 Revision 1217cea8: [TASK] Add package type to meta data and use that to resolve type
Instead of reading the composer.json of packages on runtime,
use the existing meta data API to store and retrieve thi...
Helmut Hummel

2021-10-19

23:50 Revision c7c47956: [TASK] Deprecation free Serializable usage in ObjectStorage
extbase ObjectStorage always had a serialize() and
unserialize(), even though they always just threw
exceptions. This...
Christian Kuhn
21:40 Revision 358be77b: [BUGFIX] Avoid deprecated methods in DebuggerUtility
Extbase DebuggerUtility uses reflection to determine
information that should be rendered as debug output
in 'renderCo...
Stefan Bürk
21:38 Revision de88d16d: [BUGFIX] Avoid Serializable interface deprecation in extbase tests
\Serializable interface has been deprecated with
PHP 7.4 and the introduction of __serialize() and
__unserialize().
...
Christian Kuhn
20:24 Revision 338910cc: [TASK] Improve exception message for failed url generation
Changing the exception message can help developers to find the issue
faster. The previous message "The page 123 had n...
Georg Ringer
20:02 Revision 94c32400: [BUGFIX] Split ContainerTest fixtures per class
Having more than one class per file is discouraged
and leads to issues with class-alias-loader
if non-namespaced clas...
Christian Kuhn
18:25 Revision 0636d9ae: [TASK] Disable downloading extension archive in composer mode
Disables the possibility to export extension sources as archive
via extension manager when using Composer-based setup...
Oliver Hader
16:28 Revision 589df09c: [TASK] Do not cache phpunit results
phpunit has a default-enabled feature to write test
result to a cache file. phpunit however has no option
to only run...
Christian Kuhn
16:24 Revision 0221f472: [BUGFIX] Use correct selector for caret animation in EXT:form
Currently the expanded tree does not reflect the state
(collapsed/expanded).
This has been fixed by using the correc...
Jochen Roth
16:15 Revision 271de6f6: [TASK] styleguide: Have cacheResult="false" in phpunit xml boilerplate files
Good practice.
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/71890
Christian Kuhn
15:17 Revision f2a3f4e0: [BUGFIX] Consider table name on retrieving extension key
The NewRecordController previously relied on a record
title being a locallang reference. This was used to
determine t...
Oliver Bartsch
14:40 Revision 95bd2ab6: [BUGFIX] Use the same identifier in configuration and wizard class
The current implementation makes it possible to have different wizard
identifiers defined in the class and in the con...
Helmut Hummel
14:31 Revision 9f902c21: [BUGFIX] Ensure cyrilic work as regexp redirects capture group
Requests with special characters like for ex.
cyrilic characters in it would be rawurlencoded
by the used Uri() compo...
neusta infomantis
14:30 Revision de911ccc: [BUGFIX] Ensure slug pieces are strings
Pieces assembled into slugs must be strings.
The pieces may stem from any database field.
Depending on the database d...
Markus Klein
14:13 Revision 4db1b806: [BUGFIX] Ensure slug pieces are strings
Pieces assembled into slugs must be strings.
The pieces may stem from any database field.
Depending on the database d...
Markus Klein
14:10 Revision d438dd70: [BUGFIX] Avoid warning from optional HTTP_ACCEPT_LANGUAGE HTTP header
'Accept-Language' may not be sent by clients, the patch sanitizes access
to $request HTTP_ACCEPT_LANGUAGE using null ...
Georg Ringer
14:08 Revision 346cd70a: [BUGFIX] Fix warning in BackendUtility->getRecordTitle
Resolves: #95687
Releases: master
Change-Id: If4fde4dcac49e043b60686141a5b412c88fc9ade
Reviewed-on: https://review.ty...
Nikita Hovratov
14:00 Revision 07394796: [BUGFIX] Ensure cyrilic work as regexp redirects capture group
Requests with special characters like for ex.
cyrilic characters in it would be rawurlencoded
by the used Uri() compo...
neusta infomantis
13:53 Revision 0db7497b: [TASK] Spell LinkValidator consistently
"LinkValidator" as a proper noun is always spelled in CamelCase with these exceptions:
The namespace is spelled "Lin...
Lina Wolf
13:24 Revision 6e3ec7eb: [BUGFIX] Enforce setCopyMode in clipboard
The clipboard component features helper methods,
which generate a URL to update the clipboard
state with new elements...
Jochen Roth
13:21 Revision 2e1d68b9: [TASK] Add acceptance test for sitemap
To make sure the sitemap works as expected
a acceptance test has been added for
the sitemap overview and detail view....
Jochen Roth
13:20 Revision 3277c45e: [TASK] Quote database identifier in TCA
Add quoting for 'foreign_table_where'
in TCA.
Resolves: #94717
Related: #94697
Releases: master
Change-Id: I9abcf5f6...
Jochen Roth
13:14 Revision 13ee7664: [BUGFIX] Use correct selector for caret animation in EXT:form
Currently the expanded tree does not reflect the state
(collapsed/expanded).
This has been fixed by using the correc...
Jochen Roth
13:07 Revision 3452bdca: [TASK] Quote field names in typoscript
Some TS snippets miss proper DB field name quoting.
This is important to get right to be as DBMS compatible
as possib...
Jochen Roth
12:41 Revision 3ad3ff86: [BUGFIX] Use package information to list extensions in Extension Manager
The CLI command extension:list already uses package information
for listing extensions, whereas Extension Manager sti...
Helmut Hummel
12:04 Revision 989bfcc5: [TASK] Avoid code duplication in splitFunctionalTests.php
Build/Scripts/splitFunctionalTests.php is used in
gitlab-ci via runTests.sh to split functional tests
into smaller an...
Christian Kuhn
12:01 Revision 65d88c93: [BUGFIX] Add PHP 8.1 compatibility in FlashMessageQueue
Since PHP 8.1, most internal classes are updated with
tentative return types. This will be enforced with 9.0.
It mea...
Christian Kuhn

2021-10-18

11:49 Revision 7addc309: [TASK] Simplify error assertion in two functional tests
Property $expectedErrorLogEntries can be set to an
integer when tests expect that DataHandler operations
log errors o...
Christian Kuhn
11:39 Revision 0a90cd3e: [BUGFIX] Avoid php8.1 return type deprecation for (Lazy)ObjectStorage
This patch adds correct return types where possible,
otherwise add the #[\ReturnTypeWillChange] attribute
to temporar...
Stefan Bürk
11:38 Revision 44c8a030: [TASK] Avoid TYPO3_MODE definition in tests
Constant TYPO3_MODE has been deprecated in v11.
It should not be defined for tests anymore.
Resolves: #95685
Related...
Christian Kuhn
 

Also available in: Atom