Feature #46017

Language switcher for pagetree in Backend

Added by Frank Frewer over 6 years ago. Updated almost 2 years ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2013-03-04
Due date:
% Done:

0%

PHP Version:
Tags:
Complexity:
hard
Sprint Focus:

Description

For multi language sites it is not really convenient that the pagetree shows the page titles only in the default system language.

The attached patch (against TYPO3 4.5.23 - because I needed it for a site runing with this version) implements a language switcher (dropdown box) in the toppanel. That are the feature:
- Automatically refresh the pagetree after changing with page titles from pages_language_overlay (or with default title, if "Standard" is selected).
- Show the title in default language inside the tooltip while hovering over the title.
- With a alternative language selected, editing the page title will override the title field in pages_language_overlay.
- If there is no alternative page title in the selected language, show the page title in default language wrapped with square brackets. That provides a nice overview of page titles which have to be translated.
- In this case, editing the title between the square brackets will override the title field in pages.
- Editing the title while deleting the square brackets will create a new record in pages_language_overlay with the selected language. (Show a hint to this possibility inside the tooltip).
- Filtering with a search word will search in pages_language_overlay, not in pages.
- Switching the selected language while filtering will refresh the filtering tree in the new selected language.
- If there is only the default system language defined, the language switcher will not be shown.
- Setting options.pageTree.hideLanguageSelection = 1 in user TSConfig will hide the language switcher for thie user.

This issue is related to Feature #28441 (http://forge.typo3.org/issues/28441). The old issue is for TYPO3 4.6. So I opened a new one.

patch_4.5.23_4.5.23_changed.diff View (31.6 KB) Frank Frewer, 2013-03-04 14:32

pagetree-is.png View (274 KB) Felix Kopp, 2013-03-18 17:20

pagetree-should.png View (208 KB) Felix Kopp, 2013-03-18 17:20

pagetree-flyout.png View (210 KB) Felix Kopp, 2013-03-18 17:57

01-english-selected.png View (28.4 KB) Ingo Renner, 2013-03-21 05:39

02-language-switcher-open.png View (27.6 KB) Ingo Renner, 2013-03-21 05:39

03-german-hovered.png View (27.8 KB) Ingo Renner, 2013-03-21 05:39

tree_language_switcher.psd View (400 KB) Ingo Renner, 2013-03-21 05:39

new_language_selector.png View (119 KB) Alexander Opitz, 2015-09-21 08:50


Related issues

Related to TYPO3 Core - Bug #47123: Searching in a temporary mounted pagetree shows some pages as subpages of themselves Closed 2013-04-11
Related to TYPO3 Core - Bug #47126: Disable users which are restricted to only non default languages to handle page records Closed 2013-04-11
Related to TYPO3 Core - Bug #47127: Show page overlays instead of default page title in right frame if a non default language is selected Closed 2013-04-11
Related to TYPO3 Core - Feature #66869: change language in page tree if certain language is selected Closed 2015-05-09
Related to TYPO3 Core - Feature #28441: Backend should (easily) allow to switch language used in page-tree Closed 2011-07-25
Related to TYPO3 Core - Feature #73665: Backend page tree: show localized page title New 2016-02-25
Related to TYPO3 Core - Feature #89524: Allow searching for localized pages in the page tree live search New 2019-10-28
Related to TYPO3 Core - Feature #89582: Introduce translated page tree New 2019-11-05

History

#1 Updated by Frank Frewer over 6 years ago

Here the patch...

#2 Updated by Michael Stucki over 6 years ago

Thanks for your patch, Frank!

This is a new feature and for policy reasons, it won't be added to 4.5 anymore.
Would you mind porting the patch against TYPO3's master branch?

Let me know if you need any help with this.

#3 Updated by Michael Stucki over 6 years ago

  • Status changed from New to Needs Feedback

#4 Updated by Frank Frewer over 6 years ago

I will send a new change request on gerrit - my first time, so I hope everything will be okay.

In my patch for 4.5 were some issues with dragging pages which I fixed for the master branch.

In general I know about the "policy reasons" not to add new feature to older versions. But somewhere I read that exceptions to this have to be discussed on a case-to-case basis with the corresponding release managers.

Maybe that is a case to discuss??? The main development is done. And for multi language sites in my opinion its a really missing feature. 4.5 is LTS-Version, so a lot of sites will run for several reasons under this version until the end of maintenance.

#5 Updated by Gerrit Code Review over 6 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#6 Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#7 Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#8 Updated by Michael Stucki over 6 years ago

Hi Frank,

thanks for your patch! I didn't test it yet but fixed a few (tiny) issues.

I will send a new change request on gerrit - my first time, so I hope everything will be okay.

It looks good!

In my patch for 4.5 were some issues with dragging pages which I fixed for the master branch.

In general I know about the "policy reasons" not to add new feature to older versions. But somewhere I read that exceptions to this have to be discussed on a case-to-case basis with the corresponding release managers.

I don't think that this qualifies as such a case. In fact we don't do it unless there is a really good reason (like security issues). But ...

Maybe that is a case to discuss??? The main development is done. And for multi language sites in my opinion its a really missing feature. 4.5 is LTS-Version, so a lot of sites will run for several reasons under this version until the end of maintenance.

... feel free to bring it up for discussion on the core mailing list.

Greetings, Michael

#9 Updated by Felix Kopp over 6 years ago

This is the current implementation:

Following the setup, this should be the structure:

#10 Updated by Felix Kopp over 6 years ago

#11 Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#12 Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#13 Updated by Ingo Renner over 6 years ago

Hey, I hope I'm not too late to the discussion. I think the idea is great! However, I'd like to propose an improved version to the selector of which I think it would fit better with the existing "New page" and "Filter" menus...

English is the currently selected language:

Switching the language, listing all system languages available:

Selecting german (hovered state). After clicking the menu entry, the german flag would replace the english flag (and reload the tree in german of course).

#14 Updated by Lars Zimmermann over 6 years ago

I generally like the idea and think it's a very useful feature.
I also like the simple integration of Ingo's proposal, because it offers the best usability and graphics experience.

So +1 from me for the idea and +1 for Ingo Renner's proposal.

cheers
lars

#15 Updated by Jens Hoffmann over 6 years ago

+1 for Ingo's suggestion.

Greez Jens

#16 Updated by Frank Frewer over 6 years ago

Thinking about how to implement Ingo's suggestion I found a (little?) problem. Per default there is no flag icon defined for the default system language. Which icon could I take in case that mod.SHARED.defaultLanguageFlag is not set in user TSConfig?

#17 Updated by Henrik Ziegenhain over 6 years ago

Good point - I would suggest to use the Union Jack (standard language used in translation files is also english) or the "mixed" one for all languages

#18 Updated by Ingo Renner over 6 years ago

I would also go for the mixed one, I think there was also one with less saturation...

#19 Updated by Andreas Kiessling over 6 years ago

While i really like the look with the flags: what about setups with like 20 and more languages? Will the list just expand forever?
I have a projekt with around that number of languages/workspaces and the menu for the workspaces isn't really nice to use for admins. E.g: sorting is not alphabetic, the height is fixed to the amount of entries. A regular editor of course only sees a limited amount of workspaces.

#20 Updated by Ingo Renner over 6 years ago

Patches are welcome. (not a joke or meant bad in any way!)

#21 Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#22 Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#23 Updated by Steffen Ritter over 6 years ago

What about the following case:
- multi-tree setup with different languages (user might have a db-mount to only one tree and would see other languages)
- user is restricted to some languages (and should not be allowed to see others)

#24 Updated by Jigal van Hemert over 6 years ago

It looked nice at first, but further testing revealed a list of problems which don't seem to be solvable very quickly:

  • after switching languages the Filter Tree feature doesn't search in the translated tree
  • if you switch languages with a temporary mountpoint active the option to remove the mountpoint again will be removed (only empty area left)
  • if after the previous action you use the Filter Tree feature the mountpoint message is displayed again, but after clearing the search field the message + area are gone completely. You need to re-login to get it back
  • if you use the Filter Tree feature with a different language some pages will be shown as subpages of themselves.

With feature freeze around the corner it doesn't seem likely that the issues can be solved (keeping the complexity of the pagetree code in mind).

#25 Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#26 Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#27 Updated by Gerrit Code Review over 6 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#28 Updated by Gerrit Code Review over 6 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#29 Updated by Gerrit Code Review over 6 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#30 Updated by Gerrit Code Review over 6 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#31 Updated by Claus Harup over 6 years ago

Hi all

This is exactly what I am looking for, but I cant figure out, if it is in the core of TYPO3 6.1.x, or is it in the roadmap of becoming a feature in TYPO3 6.2.x?

Greatings

Claus

#32 Updated by Frank Frewer over 6 years ago

Hi Claus,

no, it is not in 6.1. - see Jigal's comments above.

He didn't review his vote (on Gerrit) until now. I'll ask him if there is a special reason.

#33 Updated by Philipp Gampe over 6 years ago

  • Category set to Backend User Interface
  • TYPO3 Version changed from 4.5 to 6.2
  • Complexity set to hard

Jigal removed his vote.

#34 Updated by Gerrit Code Review about 6 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#35 Updated by Gerrit Code Review about 6 years ago

Patch set 15 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#36 Updated by Gerrit Code Review about 6 years ago

Patch set 16 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#37 Updated by Gerrit Code Review about 6 years ago

Patch set 17 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#38 Updated by Gerrit Code Review about 6 years ago

Patch set 18 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18751

#39 Updated by Markus Klein almost 6 years ago

  • Target version set to 7.0

#40 Updated by Gerrit Code Review over 5 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/18751

#41 Updated by Gerrit Code Review over 5 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/18751

#42 Updated by Gerrit Code Review over 5 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/18751

#43 Updated by Gerrit Code Review about 5 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#44 Updated by Gerrit Code Review almost 5 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#45 Updated by Mathias Schreiber almost 5 years ago

  • Target version changed from 7.0 to 7.1 (Cleanup)

#46 Updated by Christian Baer over 4 years ago

Has this feature already found its way into 7.1?

I'd like to implement it for 6.2, has anyone done this?

#47 Updated by Benni Mack over 4 years ago

  • Target version changed from 7.1 (Cleanup) to 7.4 (Backend)

#48 Updated by Susanne Moog over 4 years ago

  • Target version changed from 7.4 (Backend) to 7.5

#49 Updated by Gerrit Code Review about 4 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#50 Updated by Gerrit Code Review about 4 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#51 Updated by Gerrit Code Review about 4 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#52 Updated by Gerrit Code Review about 4 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#53 Updated by Gerrit Code Review about 4 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#54 Updated by Gerrit Code Review about 4 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#55 Updated by Gerrit Code Review about 4 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#56 Updated by Alexander Opitz about 4 years ago

With Patch Set 30

#57 Updated by Frank Frewer about 4 years ago

At the moment I only can reproduce the space below the language listing.

I didn't found the Icon you used for South East Europe / Central asia in the icon list.
Is that a custom icon?
If so, please try to add !important to the background-position like I did for all flags in
typo3/sysext/core/Resources/Public/Css/flags.css

Which Browser did you use?

#58 Updated by Gerrit Code Review about 4 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#59 Updated by Gerrit Code Review about 4 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#60 Updated by Gerrit Code Review about 4 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#61 Updated by Gerrit Code Review about 4 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#62 Updated by Gerrit Code Review about 4 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#63 Updated by Benni Mack about 4 years ago

  • Target version changed from 7.5 to 7 LTS

#64 Updated by Gerrit Code Review about 4 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#65 Updated by Gerrit Code Review about 4 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#66 Updated by Gerrit Code Review about 4 years ago

Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#67 Updated by Benni Mack about 4 years ago

  • Target version changed from 7 LTS to 8 LTS

#68 Updated by Gerrit Code Review about 4 years ago

Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18751

#69 Updated by Christian Kuhn almost 3 years ago

  • Status changed from Under Review to New

#70 Updated by Riccardo De Contardi over 2 years ago

  • Target version changed from 8 LTS to 9.0

#71 Updated by Susanne Moog almost 2 years ago

  • Target version deleted (9.0)

#72 Updated by Chris Müller 22 days ago

  • Related to Feature #89524: Allow searching for localized pages in the page tree live search added

#73 Updated by Oliver Bartsch 14 days ago

Also available in: Atom PDF