Project

General

Profile

Activity

From 2014-10-12 to 2014-11-10

2014-11-10

23:19 Revision 09d6d41b: [CLEANUP Fix some typos
Resolves: #62841
Releases: master
Change-Id: I5476fc51e7244ac1752b1c927f57fdcf8a6b7a38
Reviewed-on: http://review.typ... Georg Ringer
21:51 Revision 2eb3cca7: [BUGFIX] Add label for the description of scheduler group record
Add the description also to the xlf file.
Resolves: #62839
Releases: master, 6.2
Change-Id: I238616eb0e8d8720dba1934... Georg Ringer
21:49 Revision acdeaa16: [BUGFIX] Bring datetime picker time fields back in IE10+
Change-Id: If6245a85a819ece6ab6125e65c6d3ee7d11b693f
Resolves: #61173
Releases: master, 6.2
Reviewed-on: http://revie... Nikola Stojiljković
21:41 Revision fecf0854: [BUGFIX] Add label for the description of scheduler group record
Add the description also to the xlf file.
Resolves: #62839
Releases: master, 6.2
Change-Id: I238616eb0e8d8720dba1934... Georg Ringer
21:30 Revision bbc65899: [BUGFIX] Fix filename of documentation file FileTypeSoftwareRemoved
Resolves: #62840
Releases: master
Change-Id: Icc5f76d3ced8351ac64f5f5ef7cc06c655293968
Reviewed-on: http://review.typ... Wouter Wolters
21:21 Revision 5643bb4b: [CLEANUP] Reomve calls to ExtensionManagementUtility::isLoaded(cms)
The sysext cms is always loaded, no need for extra checks
Resolves: #62838
Releases: master
Change-Id: I7812b015516d... Georg Ringer
19:27 Revision 0551d35c: [BUGFIX] Wrong hint in deprecation log for usage of feInterface
Any extension may set parameter $addTofeInterface to 1 in the
corresponding ext_tables.php file.
Assumption that onl... Xavier Perseguers
19:25 Revision 3d9e04d6: [BUGFIX] Wrong hint in deprecation log for usage of feInterface
Any extension may set parameter $addTofeInterface to 1 in the
corresponding ext_tables.php file.
Assumption that onl... Xavier Perseguers
19:16 Revision 5d6c9811: [CLEANUP] Remove dividers2tabs functionality
The default for any installation and the whole
core is to use dividers2tabs enabled by default.
Disabling "dividers2... Benni Mack
18:43 Revision a7a068d8: [CLEANUP] Cleanup EXT:info
Just a few simple cleanups
Resolves: #62796
Releases: master
Change-Id: I291de0badc614399f29b3599976ff869f868197d
Re... Frederic Gaus
18:34 Revision 5d4cfef9: [BUGFIX] Make element browser work again
Due to the cleanup of the DocumentTemplate
html variants, the Element Browser did not
work as a <body> tag is now ren... Benni Mack
18:32 Revision 5482f3ba: [TASK] Revoke deprecation of makeRedirectUrl()
Method GeneralUtility::makeRedirectUrl() was deprecated with #62794.
The patch intended to deprecate some old mail ha... Christian Kuhn
18:14 Revision 310e750e: [TASK] Optimize Reports-Module
* Remove icons from header
Resolves: #62668
Releases: master
Change-Id: I762a7b827720bc596737decfef2e6fa789592a84
Re... Frank Nägler
15:22 Revision 6d6418f5: Revert "[TASK] Add verbose output to report mail for failed tests"
This introduces a new feature, so it cannot go into a released version
This reverts commit 58621d4f2ae14404b24276354... Helmut Hummel
14:46 Revision 842af649: [TASK] Render Core changelog as a standard manual
Releases: master
Resolves: #62822
Change-Id: I786d0e5eaa04aa986417721dd0265b7633fb0ca1
Reviewed-on: http://review.typ... Xavier Perseguers
14:46 Revision 47010b08: [TASK] Remove locallang.php handling from Configuration
The locallang.php handling was deprecated
with the introduction of xlf files in TYPO3 CMS 4.6.
However, it is still ... Benni Mack
11:30 Revision d2429a8b: [TASK] Correct @deprecation of isLastPartOfString()
The @deprecation annotation of StringUtility::isLastPartOfString says:
@deprecated since 7.0, use beginsWith() inste... Frederic Gaus
05:41 Revision 3dd40e69: [TASK] RTE: Remove unused template file
File templates/rtehtmlarea_pageheader_frontend.html is not used since
this change: https://review.typo3.org/#/c/15413... Stanislas Rolland
04:34 Revision 2f323a9c: [BUGFIX] RTE: Multi-line lists in default PageTS configs cause problems
Problem: For the sake of clarity, some of the RTE default PageTS
configurations specify lists as multi-line values. I... Stanislas Rolland
04:05 Revision a5087cf6: [BUGFIX] RTE: Multi-line lists in default PageTS configs cause problems
Problem: For the sake of clarity, some of the RTE default PageTS
configurations specify lists as multi-line values. I... Stanislas Rolland
00:25 Revision 8f818519: [TASK] RTE: Move JS method getNodeByPosition
Move JavaScript method getNodeByPosition from HTMLArea.Editor to
HTMLArea.DOM.Node where it belongs.
Releases: maste... Stanislas Rolland

2014-11-09

20:08 Revision 6fbbf736: [TASK] Remove StyleGenerationHook in t3skin
This hook is called inside t3skin and not used anymore because
styling is now done in a better way.
Also classes like... Georg Ringer
16:52 Revision 8b8bd2ec: [TASK] Simplify rendering in EXT:scheduler
Don't use the DocumentTemplate class to render a simple table.
Changes are:
* Simplify the rendering of the availab... Georg Ringer
16:26 Revision c5af4994: [BUGFIX] Bring back missing expand/collapse icons
Resolves: #62681
Releases: master
Change-Id: Id077a00a83f11e2693c7a3da8bc284662dabc436
Reviewed-on: http://review.typ... Frank Nägler
15:34 Revision 146142c5: [TASK] Deprecate old mail related methods in GeneralUtility
Some mail related methods in GeneralUtility are obsolete and
unused in core and can be deprecated now.
Change-Id: Ie... Christian Kuhn
15:25 Revision 54558a96: [CLEANUP] Remove unused JS for pinging loginrefreshed
There are still some leftover calls to save information
when the page was loaded at the latest. The whole
top.busy ob... Benni Mack
14:47 Revision 515a6880: [TASK] Remove last bits of config.notification_*
Some TypoScript parameter were used in the old mail
handling and are now obsolete after latest deprecation
removals. ... Christian Kuhn
14:31 Revision 5445e25f: [FEATURE] Typolink ViewHelper
Add a view helper that parses the good old typolink string
syntax created by link wizards and rte.
Change-Id: Ie220b... Anja Leichsenring
14:22 Revision 0ff01a9c: [TASK] Remove "no RDCT"-workaround in fe_users Forgot-Password mail
As the used method sendNotifyEmail doesnt substitute URLs
with \TYPO3\CMS\Core\Utility\GeneralUtility::substUrlsInPla... Patrick Kroog
09:34 Revision fd2d7673: [FEATURE] Restyle and reorder lowlevel>Configuration
Restructure search form. Implement Styles.css and remove
inline CSS. Remove cropping of lines. Equalize array tree.
... Felix Kopp
05:46 Revision ba3a2676: [BUGFIX] RTE: JS exception regarding property disableStyleOnOptionLabel
Problem: BlockStyle plugin checks for property
this.pageTSconfiguration.disableStyleOnOptionLabel without checking
fi... Stanislas Rolland
05:40 Revision a78edef6: [BUGFIX] RTE: JS exception regarding property disableStyleOnOptionLabel
Problem: BlockStyle plugin checks for property
this.pageTSconfiguration.disableStyleOnOptionLabel without checking
fi... Stanislas Rolland
04:52 Revision 725f7a03: [BUGFIX] RTE.default.buttons.blockstyle not configurable
Problem: Data from the TextStyle combobox,derived from the textstyle
configuration, appears in the BlockStyle combobo... Stanislas Rolland
01:43 Revision 28148d93: [BUGFIX] RTE.default.buttons.blockstyle not configurable
Problem: Data from the TextStyle combobox,derived form the textstyle
configuration, appears in the BlockStyle combobo... Stanislas Rolland
01:28 Revision 2ec47a87: [CLEANUP] Streamline code in UpgradeWizard
* Correct naming of Updates (old name UpgradeWizards) and variables
* Use makeInstance instead of getUserObj
* Correc... Markus Klein
01:20 Revision 87f7d420: [BUGFIX] Reports status listing table
Follow-up for Reports module test listing. Listing is a table.
Related: #62668
Related: #62614
Releases: master
Chan... Felix Kopp
01:15 Revision 6c1e6e60: [BUGFIX] Linkvalidator: Improve tolerance on HEAD-request error
Force second URL-request if first response had an HTTP-status-code
which indicates a client-error (4xx) or a server-e... Stefan Weißwange
00:24 Revision e166f6fa: [CLEANUP] Add phpDoc to properties in ext:filelist
Resolves: #62758
Releases: master
Change-Id: I7ce07e74d8e65f77d535a0505c2175ee249cff81
Reviewed-on: http://review.typ... Wouter Wolters

2014-11-08

23:43 Revision 05513375: [BUGFIX] Follow-up to #62705: Fix fatal and unit test fail
Regressions from merge 627b30f3be8b9fde5ca72ccfa7bfdb2e285a0dd1
* A missing adaption after use flag change leads to ... Christian Kuhn
22:55 Revision 88b5e80a: [CLEANUP] Cleanup EXT:recycler
This patch solves normal cleanup tasks:
* Correcting phpDoc
* Adding missing phpDocs
* Using short classnames
* Remo... Wouter Wolters
22:39 Revision 627b30f3: [CLEANUP] Cleanup ext:core/Configuration
* Use one use-statement per class
* Format phpDoc correctly
Resolves: #62705
Releases: master
Change-Id: If199c6962e... Wouter Wolters
22:38 Revision f958159d: [CLEANUP] Cleanup ext:core/Database
* Add phpDoc to properties
* Add phpDoc to functions
Resolves: #62706
Releases: master
Change-Id: Id836e7a6e61105027... Wouter Wolters
22:36 Revision cd9a6e9d: [CLEANUP] Cleanup ext:core
* Add phpDoc to properties
* Add phpDoc to functions
* Shorten class names where possible
Resolves: #62707
Releases:... Wouter Wolters
19:34 Revision dbde3aa8: [BUG] RTE: backend layout of dialogues is broken
Releases: master
Resolves: #62789
Change-Id: I80b519ab85b7f18befdc451ce9558fccf68656cc
Reviewed-on: http://review.typ... Stanislas Rolland
19:22 Revision 55d1a652: [BUGFIX] Page module Quickedit: wizards are broken
When using Quickedit mode of Page module, the header link and the RTE
wizards are broken.
Backpath is added twice to ... Stanislas Rolland
19:08 Revision d9fbb178: [BUG] RTE: Default skin is broken
The default skin is broken in various ways.
Releases: master
Resolves: #62787
Change-Id: Ia13af7babf09de68a27e804334... Stanislas Rolland
19:03 Revision 4325dcdb: [TASK] Cleanup Lowlevel DatabaseIntegrityView
The function menu is calculated twice, one occurence is
removed. Furthermore, the two userTS options disableTopMenu
a... Wouter Wolters
18:43 Revision fa1b9c2a: [TASK] Move Perm next to BeUsers
As a first step to merge User and Access modules move
Perm down to "System" next to backend user admin.
Resolves: #6... Felix Kopp
17:26 Revision 57c9ba91: [TASK] RTE: Cleanup configuration of acronym table
Releases: master
Resolves: #62785
Change-Id: If85ac80d6ef210313555caf5674a1a5fe8439b38
Reviewed-on: http://review.typ... Stanislas Rolland
17:19 Revision 35686bdf: [BUGFIX] Bring datetime picker time fields back in IE10+
Change-Id: If6245a85a819ece6ab6125e65c6d3ee7d11b693f
Resolves: #61173
Releases: master, 6.2
Reviewed-on: http://revie... Nikola Stojiljković
17:03 Revision f025dac3: [CLEANUP] Cleanup phpDoc and namespace usage in ext:frontend/ContentObject
Resolves: #62769
Releases: master
Change-Id: If5b0cde8d9d393b498230d3ee87a0f0bddaf9bb2
Reviewed-on: http://review.typ... Wouter Wolters
16:41 Revision ff36a94b: [CLEANUP] Cleanup backend toolbar item registration
* Remove side effects from class file
* Move registration script to Resources/PHP folder
Resolves: #62775
Related: #... Wouter Wolters
16:20 Revision 6b29f6cc: [TASK] Exclude unsupported Bootstrap from t3skin
Exlude CSS that is not supported yet. Not supported because
not styled and customized.
No support yet for
Breadcrumb... Felix Kopp
16:00 Revision e43d0a17: [CLEANUP] Add phpDoc to properties in several extensions
* func
* func_wizards
* lang
* lowlevel
* opendocs
* openid
* recordlist
Resolves: #62772
Releases: master
Change-Id... Wouter Wolters
15:50 Revision 5527cc7b: [CLEANUP] Cleanup phpDoc in ext:frontend
Resolves: #62771
Releases: master
Change-Id: I6f79bd66765dc5fef0ac331d79855cb9ea3d8a39
Reviewed-on: http://review.typ... Wouter Wolters
15:46 Revision ecf9cf5e: [CLEANUP] Add phpDoc to properties in several extensions
* recycler
* reports
* rsaauth
* saltedpasswords
* sv
* taskcenter
* tstemplate
Resolves: #62774
Releases: master
Ch... Wouter Wolters
15:37 Revision 627fec32: [TASK] Move css and JavaScript files in sys_action
Resolves: #62776
Releases: master
Change-Id: I4b21314c15953fa3c4f2a819cdb06fe771211f29
Reviewed-on: http://review.typ... Wouter Wolters
15:34 Revision 36560611: [TASK] Add hhvm to travis
Running the test suite with hhvm shows some code smells and
actual issues the core with this interpreter. While unit ... Christian Kuhn

2014-11-07

18:33 Revision 67e9d19f: [TASK] RTE: Move style sheets and images to Resources directory
Releases: master
Resolves: #62768
Change-Id: I6948bb97d156e47ab16f130a54785f55e7e6daac
Reviewed-on: http://review.typ... Stanislas Rolland

2014-11-06

23:49 Revision 9b9bd944: [TASK] RTE: Move hooks and softref config to Configuration directory
Releases: master
Resolves: #62759
Change-Id: I198a7ad5a131dc96c0dc4d669125061097867f5d
Reviewed-on: http://review.typ... Stanislas Rolland
21:28 Revision 0126a7cc: [TASK] RTE: Move default MicroData schema to Resources directory
Releases: master
Resolves: #62753
Change-Id: Iaa9bfc48a571d0fc6a0974981703c75fc3976620
Reviewed-on: http://review.typ... Stanislas Rolland
20:52 Revision 27c70de3: [TASK] RTE: Move default content css to Resources directory
Releases: master
Resolves: #62751
Change-Id: Ic363948a411ba8a0bf4a63391b97909b237229e3
Reviewed-on: http://review.typ... Stanislas Rolland
19:19 Revision 93e600e1: [TASK] RTE: Move page/user TSconfig files to Configuration directory
Releases: master
Resolves: #62748
Change-Id: I35cc1e76a92a7ae863e017e1d7877385be9ee7e6
Reviewed-on: http://review.typ... Stanislas Rolland
17:24 Revision 20d861f8: [TASK] RTE: Move JavaScript files to Resources directory
Releases: master
Resolves: #62733
Change-Id: I2387e316f110312488c32045d0f3e92e0f9cb7a5
Reviewed-on: http://review.typ... Stanislas Rolland
13:22 Revision 9a8c9bf5: [BUGFIX] Extension installer: Handle multiple blanks
The parser of the ext_tables.sql file removes double blanks
from the input line - but only once. So if there are mult... Stefan Froemken
12:21 Revision a15f39f3: [BUGFIX] Extension installer: Handle multiple blanks
The parser of the ext_tables.sql file removes double blanks
from the input line - but only once. So if there are mult... Stefan Froemken
10:28 Revision c66b70d7: [!!!][CLEANUP] Remove deprecated code in multiple sysexts
Does not touch extbase and fluid.
Resolves: #62670
Releases: master
Change-Id: I853fd1814b7ea5853cdf75abf16be238a27a... Markus Klein
09:33 Revision f30b4dde: [!!!][TASK] Remove alternateBgColors option
Resolves: #53658
Releases: master
Change-Id: If36c17741d8f3a9a07f7cc8ad2f3289164b8b195
Reviewed-on: http://review.typ... Wouter Wolters
07:28 Revision b8d2eed9: [TASK] RTE: Move modules to Modules directory
Move the RTE wizards to Modules directory and cleanup configuration and
class structure.
Releases: master
Resolves: ... Stanislas Rolland

2014-11-05

22:50 Revision aa82d458: [TASK] Remove usage of the keyword global
Resolves: #47207
Releases: master
Change-Id: I953d05d478ae03626c235553ce8fe56ec13eb4f9
Reviewed-on: http://review.typ... Wouter Wolters
22:47 Revision 9882c09d: [CLEANUP] CharsetConverter code cleanup
* Correct phpDoc
* Use strict comparison where possible
Resolves: #62703
Releases: master
Change-Id: Iea29cdb9593a17... Wouter Wolters
22:08 Revision 2411be28: [CLEANUP] Code cleanup in ext:core/Collection
* Use short class name where possible
* Correct curly bracket at end of defining the interface
* Create getDatabaseCo... Wouter Wolters
21:10 Revision 36900f71: Remove attribute data-htmlarea-file-table from RTE
Images in RTE are now Processed Files. As a result
it makes little sense to store the table name of a File
since "sys... Fabien Udriot
19:48 Revision d321fefe: [FEATURE] Add dependencies between classes in RTE
To comply with complex CSS frameworks like Twitter Bootstrap, we need
to add multiple classes on the same element. Th... Stanislas Rolland
19:47 Revision 3d741a78: [BUGFIX] RTE: Inconsistent delete behaviour
In Firefox, depending on how we delete something in RTE, we get
different results.
This change makes the results cons... Stanislas Rolland
19:47 Revision a68d66e7: [BUGFIX] RTE: Inconsistent delete behaviour
In Firefox, depending on how we delete something in RTE, we get
different results.
This change makes the results cons... Stanislas Rolland
16:24 Revision ea485fbe: [BUGFIX] Quickedit mode: RTE has no user CSS
A similar issue arises with configured microdata schema.
This is a follow-up to change https://review.typo3.org/#/c/3... Stanislas Rolland
15:43 Revision 9cb2ca22: [BUGFIX] Quickedit mode: RTE has no user CSS
A similar issue arises with configured microdata schema.
This is a follow-up to change https://review.typo3.org/#/c/3... Stanislas Rolland
13:08 Revision 1c721244: [TASK] Replace clearcache spinner with FA icon
Currently, the spinning wheel displayed after clearing the cache is a
graphic larger than the used font. This caused ... Andreas Fernandez
05:09 Revision 173eef23: [BUGFIX] RTE toolbar layout broken
Toolbar elements do not wrap correctly.
Releases: master
Resolves: #62710
Change-Id: Iefba035219c46baf3b481547d990c8... Stanislas Rolland
01:30 Revision b0357fc9: [BUGFIX] ADOdb: Set charset properly
Using ADOdb, the charset might not be set properly, since every
database driver needs to define their own "SetCharSet... Andreas Kienast
01:29 Revision f02a7625: [BUGFIX] ADOdb: Set charset properly
Using ADOdb, the charset might not be set properly, since every
database driver needs to define their own "SetCharSet... Andreas Kienast

2014-11-04

19:05 Revision 6c31734e: [TASK] Use a new icon for sorting inline records
Adopt the order icon to fit the others.
The changed icon can e.g. be found in content element type "media",
section ... Georg Ringer
18:49 Revision a43630bf: [!!!][CLEANUP] Remove deprecated code in sysext backend
This patch does not touch the $include_once magic of BE modules.
Resolves: #59659
Releases: master
Change-Id: I8721b... Markus Klein
18:35 Revision db2edcc7: [CLEANUP] Code Cleanup EXT:aboutmodules
Refactor the code to go green in PHPStorm.
Main tasks:
* Initialize variables
* Centralize objects in $GLOBALS
Resol... Mathias Schreiber
15:32 Revision a64eb7cb: [CLEANUP] Remove wrapBorder table in FormEngine
Remove hard-coded additional wrapper table
around FormEngine elements.
Styling will be handled differently in the fu... Benni Mack
05:16 Revision df600c69: [BUGFIX] RTE wraps p tags around ol/ul in chrome and opera
This is a follow-up to change https://review.typo3.org/#/c/33655/
Resolves: #62559
Resolves: #59559
Resolves: #52470... Stanislas Rolland
04:57 Revision b65517bf: [BUGFIX] RTE wraps p tags around ol/ul in chrome and opera
This mis a follow-up to change https://review.typo3.org/#/c/33655/
Resolves: #62559
Resolves: #59559
Resolves: #5247... Stanislas Rolland
00:56 Revision 9489eef6: [CLEANUP] Code Cleanup of AbstractPlugin
AbstractPlugin serves as a base for non-extbase plugins.
In order to allow for a notice free environment and no code ... Mathias Schreiber

2014-11-03

23:56 Revision 8b944786: [TASK] Message usage in reports module and extensionmanager
Refactoring the reports module a bit to no longer use status
message HTML for rendering since this is a misuse.
Simi... Frank Nägler
23:56 Revision 9f1a302c: [CLEANUP] Add phpDoc to properties in ext:backend
Fixes some minor things on the go.
Resolves: #62669
Releases: master
Change-Id: Ida96d56d5f81ac3f1050958aa8ed821613a... Wouter Wolters
23:48 Revision 83bfcdcb: [TASK] Use a new icon for sorting inline records
Adopt the order icon to fit the others.
Resolves: #62661
Releases: master
Change-Id: I1f34fb7eb808e9da0d9c5ba8177da9... Georg Ringer
23:16 Revision 3252a22c: [CLEANUP] Use correct casting syntax
Resolves: #62664
Releases: master
Change-Id: Ib8e0695fc234ab67a2f73a65737e07cf9a2d19c6
Reviewed-on: http://review.typ... Wouter Wolters
23:02 Revision fdcabab3: [CLEANUP] Remove scheduler option for extended description
There is an always activated option
to show a description for tasks on hover.
This option is removed, the feature is... Benni Mack
22:36 Revision 2f5251ad: [TASK] Use ajax.php for clickmenu
The clickmenu still used its own alt_clickmenu.php
entry point until now which is not needed anymore
with ajax.php.
... Benni Mack
19:03 Revision 2772c881: [BUGFIX] RTE: In IE, the pasting pad sometimes shows an error page
In IE, the pasting pad for plain text pasting sometimes shows an
error page.
Apparently, a timing issue.
Releases: m... Stanislas Rolland
19:02 Revision c51733a6: [BUGFIX] RTE: In IE, the pasting pad sometimes shows an error page
In IE, the pasting pad for plain text pasting sometimes shows an
error page.
Apparently, a timing issue.
Releases: m... Stanislas Rolland
18:59 Revision 622926a2: [BUGFIX] Additional Identity Properties not set on mapping error
When binding Fluid forms to nested objects, Fluid automatically adds
hidden fields with the identifiers of all affect... Anja Leichsenring
17:59 Revision f8bc9be9: [TASK] RTE: Cleanup references to AllowClipboardHelper for Mozilla
Support for allowClipboard policy has been removed from Firefox since
version 29. This is a follow-up to change
https... Stanislas Rolland
17:48 Revision afbad533: [TASK] RTE: Cleanup references to AllowClipboardHelper for Mozilla
Support for allowClipboard policy has been removed from Firefox
since version 29.
This is a follow-up to change https... Stanislas Rolland
16:46 Revision 5bfdbadc: [CLEANUP] Cleanup EXT:rsaauth
EXT:rsaauth has several minor flaws codewise that make
PHPStorms inspection go wild:
* Clean up direct usage of $GLOB... Mathias Schreiber
16:03 Revision 921ef485: [TASK] RTE: Use own user agent identification
Replace ExjJs outdated user agent identification.
Releases: master
Resolves: #62630
Change-Id: Ib057fd1ea2c2fc78b0bf... Stanislas Rolland
16:00 Revision 58621d4f: [TASK] Add verbose output to report mail for failed tests
Adds the failed tests messages to the mail.
Change-Id: I104b7ad98b2ce1ab8014a0751f7adc8c72ad6ca2
Resolves: #58786
Re... Benedict Burckhart
16:00 Revision 6e969de7: [TASK] Add verbose output to report mail for failed tests
Adds the failed tests messages to the mail.
Change-Id: I104b7ad98b2ce1ab8014a0751f7adc8c72ad6ca2
Resolves: #58786
Re... Benedict Burckhart
15:59 Revision 2dd84dd2: [!!!][TASK] Do not clear caches after extension config change
This change removes the cache flush after extension configuration changes.
Furthermore we avoid duplicate cache flush... Markus Klein
14:25 Revision b3419b68: [TASK] RTE: Remove directories pi1, pi2 and pi3
Remove directories pi1, pi2 and pi3 and adapt configuration of spell
checker, frontend RTE and click enlarge features... Stanislas Rolland
14:00 Revision 79ba8820: [BUGFIX] Ensure PHP 5.2 compatibility in php-openid
The backport #62357 introduced a regression with PHP 5.2,
which still is officially supported by TYPO3 CMS 4.5
Adapt... Michael Stucki
10:38 Revision af1c6b5a: [CLEANUP] Correct phpDoc of FrontendLoginController->getDisplayText Function
The parameter $stdWrapArray is definied as string in the phpDoc
annotation @param. Corrected this to array
Resolves:... Frederic Gaus
10:38 Revision 81e3c007: [CLEANUP] Correct phpDoc of FrontendLoginController->getDisplayText Function
The parameter $stdWrapArray is definied as string in the phpDoc
annotation @param. Corrected this to array
Resolves:... Frederic Gaus
10:23 Revision fac9754c: [TASK] Remove unused variable from FeatureManager->getBestMatchingConfigurationForAllFeatures
Removed the variable $featureName as it is never used.
Resolves: #62637
Releases: master
Change-Id: I5125d59d4acdf5a... Frederic Gaus
03:53 Revision 4b97eddf: [CLEANUP] Add phpDoc to properties in ext:backend/Controller classes
Resolves: #62634
Releases: master
Change-Id: Iece95781c1c0b1d50364f308d1aabb1ac0f0ec85
Reviewed-on: http://review.typ... Wouter Wolters

2014-11-02

22:38 Revision be5dce41: [CLEANUP] Rename IconUtility slot class
Additionally clean some things up:
* remove unnecessary static property
* make property private
* avoid notices
Rel... Helmut Hummel
22:04 Revision 18d8e1d0: [!!!][TASK] Remove deprecated code from sysext core
This patch does not touch:
* UpgradeWizard things => #62402
* curl proxy options in DefaultConfiguration
* Backend... Markus Klein
20:48 Revision b8edc674: [BUGFIX] Fix links of shortcuts to restricted pages in menus
Fix missing links in menus when shortcuts point to access restricted
pages or shortcuts themselves are restricted.
T... Helmut Hummel
20:42 Revision 1fc8ffbf: [BUGFIX] Fix links of shortcuts to restricted pages in menus
Fix missing links in menus when shortcuts point to access restricted
pages or shortcuts themselves are restricted.
T... Helmut Hummel
20:27 Revision a120ba4b: [TASK] Move classAliasMaps into compatibility6 extension part 2
This is the sysext:core class alias part
Resolves: #62611
Related: #62013
Releases: master
Change-Id: Iaa38059249423... Anja Leichsenring
19:43 Revision 807615ae: [TASK] Change flashmessages.js for new FlashMessage styling
Resolves: #62605
Releases: master
Change-Id: I896bb14d39ac5f0fd32c511084b23fc3e2ba71af
Reviewed-on: http://review.typ... Frank Nägler
18:28 Revision 2149bd51: [CLEANUP] Add phpDoc to properties in BackendController
Removes a unused property as well.
Resolves: #62627
Releases: master
Change-Id: I6ba4e7345b83dbf2aa66361f08dd27ad871... Wouter Wolters
17:21 Revision 9a58ba1d: [CLEANUP] Add phpDoc to properties in SetupModuleController
Resolves: #62626
Releases: master
Change-Id: Ieead09b3f3fd9e3437d84a47f55176d2199e9b69
Reviewed-on: http://review.typ... Wouter Wolters
14:19 Revision 1019c8d6: [TASK] RTE: Avoid use of Ext.isEmpty
Streamline code.
Releases: master
Resolves: #62619
Change-Id: I4218c0ae03289d71cba2c40547d0bc4f7a71868b
Reviewed-on:... Stanislas Rolland
11:37 Revision d995e87b: [!!!][TASK] Remove SU mode "change to" in EXT:beuser
This patch removes the ability to switch to a user permanently.
The user now always gets an "exit" button offered to ... Andreas Fernandez
11:28 Revision 4d96664f: [TASK] Use "int" or "bool" in @var notation
Use "int" or "bool" in @var notation instead of
"interger" or "boolean".
Resolves: #62571
Releases: master
Change-Id... Wouter Wolters

2014-11-01

22:49 Revision b66ff8c0: [TASK] Remove old updates for upgrade wizard
This patch removes all upgrade wizard updates before version 7.
The old [wizardDone] LocalConfiguration entries are r... Markus Klein
22:09 Revision 7c3b83f8: [BUGFIX] Fix script URLs for traditional modules
The introduction of CSRF protection for backend modules
introduced a regression for traditional modules.
Previously ... Helmut Hummel
21:50 Revision b79cccd4: [TASK] RTE: Avoid use of Ext.isString and Ext.isFunction
Avoid useless overhead.
Releases: master
Resolves:#62617
Change-Id: Ibb722b405d8c95335f655c78faa05fe3be8a4ea6
Review... Stanislas Rolland
21:48 Revision 737613db: [BUGFIX] Fix script URLs for traditional modules
The introduction of CSRF protection for backend modules
introduced a regression for traditional modules.
Previously ... Helmut Hummel
21:35 Revision 83a23e34: [BUGFIX] Bring back select field button's functionality
Fix the missing CSS classes for the up/down/remove buttons of select
fields in FormEngine.
Resolves: #62591
Releases... Helmut Hummel
19:50 Revision ea531a0b: [BUGFIX] Register the exception handler early in bootstrap
Currently registering the exception handler is done
after extensions are loaded to allow extensions to
modify configu... Helmut Hummel
18:14 Revision b3cb7984: [TASK] Avoid use of Ext.isDefined
Avoid useless overhead.
Releases: master
Resolves: #62609
Change-Id: I6b2f2805945d0e6a04b3617807f952cd30d8ede8
Revie... Stanislas Rolland
16:04 Revision 8653ca5a: [BUGFIX] RTE: In Chrome RTE inserts weird span tags
Remove the span tags inserted by Chrome or Opera on execution of native
execCommand. The attributes of these span tag... Stanislas Rolland
16:04 Revision f8dab631: [BUGFIX] RTE: In Chrome RTE inserts weird span tags
Remove the span tags inserted by Chrome or Opera on execution of native
execCommand. The attributes of these span tag... Stanislas Rolland
16:03 Revision fa86241d: [BUGFIX] RTE wraps p tags around ol/ul in chrome and opera
Releases: master, 6.2
Resolves: #62559
Change-Id: Ib9c0576e82424065e875a73edfa91795c71e841e
Reviewed-on: http://revie... Stanislas Rolland
16:03 Revision cc502d6a: [BUGFIX] RTE wraps p tags around ol/ul in chrome and opera
Releases: master, 6.2
Resolves: #62559
Change-Id: Ib9c0576e82424065e875a73edfa91795c71e841e
Reviewed-on: http://revie... Stanislas Rolland
16:02 Revision 4fb4e691: [BUGFIX] RTE: Quickedit mode - RTE has no user CSS
Fix wrong absolute path calculation.
Releases: master, 6.2
Resolves: #56408
Change-Id: Ia96197f0dcf81bb8b52b511c75ae... Stanislas Rolland
16:02 Revision 1ae80948: [BUGFIX] RTE: Quickedit mode - RTE has no user CSS
Fix wrong absolute path calculation.
Releases: master, 6.2
Resolves: #56408
Change-Id: Ia96197f0dcf81bb8b52b511c75ae... Stanislas Rolland
15:35 Revision 109329ec: [TASK] Change docComment of FlashMessageViewHelper
Change the docComment of FlashMessageViewHelper to match the new output
Resolves: #62603
Releases: master
Change-Id:... Frank Nägler
15:00 Revision 5e681e8c: [BUGFIX] DBAL message for EM uses old flasmessage styling classes
Resolves: #62600
Releases: master
Change-Id: I494232aa223de15df076699af8af6dfcfe66f5a8
Reviewed-on: http://review.typ... Wouter Wolters
14:56 Revision 961c2c7a: [BUGFIX] Unresolved dependencies uses old flashmessage styling
The message when there are unresolved dependencies uses the old
flashmessage styling classes. Use the new classes.
R... Wouter Wolters
14:17 Revision 4ecdc890: [BUGFIX] Security status for saltedpasswords broken
Due to the new flashmessage styling the checks done for
saltedpasswords don't work anymore. Change the checks to the
... Wouter Wolters
11:37 Revision 2f925954: [TASK] Make code PHP 5.3 compatible again for now
The content exception handler change introduced PHP 5.5 only
code parts. Revert these parts until we have a final
dec... Helmut Hummel
11:09 Revision 5a622f3f: [FEATURE] Rebrush FlashMessage / state colors
Rebrushes the FlashMessage layout and output. Better
contrast of box and text. Prominent links. Lighter boxes.
Resol... Felix Kopp
11:06 Revision e787e43b: [FEATURE] Allow row highlight in table.t3-table
<table class="t3-table"> is the TYPO3 standard class. Allows
success / danger / warning / info and active on table ro... Felix Kopp
00:38 Revision 12d24f22: [FEATURE] styleguide: Table .t3-table cell markup
Felix Kopp
00:33 Revision af95e6cb: [TASK] styleguide: FlashMessage status row
Felix Kopp

2014-10-31

10:02 Revision 6bbb0d98: [BUGFIX] Fix PHP warning with date function in FormEngine
The timestamp handed to the date function must be of type int
otherwise a warning is issued. Cast the value to int be... Wouter Wolters
10:00 Revision 16e2f1d1: [BUGFIX] Fix PHP warning with date function in FormEngine
The timestamp handed to the date function must be of type int
otherwise a warning is issued. Cast the value to int be... Wouter Wolters
09:10 Revision f56c52f1: [BUGFIX] Too many tags by identifier in CacheBackends
This patch is a backport of 3d93017022a8ef03842d75f2d7bd3912365c95be.
Applies to Apc/Memcached backends.
After an a... Michael Stucki
00:03 Revision c43f0029: [BUGFIX] Fix column layout for New Content Element wizard
If adding new content elements in Web>List with the CE wizard,
you get the old column layout & titles even if you hav... Martin Kästner

2014-10-30

23:44 Revision 9cd9cb04: [BUGFIX] Add proper URL check to TemplateService::getFileName()
This fixes the broken test introduced with #51781
Resolves: #62575
Releases: 6.2
Change-Id: I92541fbf2744399a1385ccc... Markus Klein
22:08 Revision f452e91e: [BUGFIX] Fix column layout for New Content Element wizard
If adding new content elements in Web>List with the CE wizard,
you get the old column layout & titles even if you hav... Martin Kästner
21:30 Revision 140ae243: [BUGFIX] IMAGE content object accepts directories
Adds checks for file existence to avoid returning directory
paths instead of path to file.
Resolves: #51781
Releases... Tomita Militaru
21:25 Revision c6eb7676: [TASK] Add unit test for short data type support in ReflectionService
Resolves: #62547
Releases: master
Change-Id: Idada794755d8e40f702d0d9ada5a8b8b5719bf4c
Reviewed-on: http://review.typ... Markus Klein
21:25 Revision f6ebab8b: [TASK] Use Bootstrap 3.3.x in t3skin
Use twbs Bootstrap 3.3 release for t3skin.
Notes: https://github.com/twbs/bootstrap/releases/tag/v3.3.0
Resolves: #6... Felix Kopp
21:20 Revision 27a224bb: [BUGFIX] IMAGE content object accepts directories
Adds checks for file existence to avoid returning directory
paths instead of path to file.
Resolves: #51781
Releases... Tomita Militaru
00:42 Revision de7dbde7: [BUGFIX] Add check if $fileObject is a correct instance
In some cases the $fileObject is null and getName() is called on
a null object which results in a fatal error.
This ... Frank Nägler
00:41 Revision a7b0e383: [BUGFIX] Add check if $fileObject is a correct instance
In some cases the $fileObject is null and getName() is called on
a null object which results in a fatal error.
This ... Frank Nägler
00:29 Revision 1fb57fc0: [BUGFIX] ReflectionService must recognize short data types
Since the Core uses and embraces the usage of short data type names
like "bool" or "int", internal type checks must e... Markus Klein

2014-10-29

19:35 Revision e1ef2c63: [FEATURE] Add possibility to catch exception during rendering
Currently exceptions throw when rendering single
content objects bubble up to the default exception
handler and break... Helmut Hummel
13:53 Revision ea22cdf1: [BUGFIX] Fix active page calculation in indexed_search
Because of introducing a strict comparion in #60346, the active page is
not highlighted anymore as a float and an int... Georg Ringer
13:35 Revision 62cff46f: [BUGFIX] Fix active page calculation in indexed_search
Because of introducing a strict comparion in #60346, the active page is
not highlighted anymore as a float and an int... Georg Ringer
01:03 Revision 87078d5b: [BUGFIX] Fix suggest wizard for new CE in flexforms
When having a suggest wizard inside a flexform on a
new content element edit form, we have the problem that
we can't ... Markus Klein
00:59 Revision 7f0c6c30: [BUGFIX] Remove wrong escaping of email sender
Remove a wrong escaping method from sysext form which causes email
problems.
Resolves: #60437
Releases: master, 6.2
... Markus Klein
00:58 Revision 80adb509: [BUGFIX] Remove wrong escaping of email sender
Remove a wrong escaping method from sysext form which causes email
problems.
Resolves: #60437
Releases: master, 6.2
... Markus Klein
00:47 Revision 212e7b4a: [CLEANUP] BackendUtility
Fix various code issues like missing return values, wrong phpdoc, unused
variables, etc.
Resolves: #62414
Releases: ... Markus Klein

2014-10-28

16:43 Revision 2204ebd2: [TASK] Cleanup phpDoc to match CGL
* Use bool in @return
* Use int in @return
* Use bool in @param
* Use int in @param
* Remove extra tabs and spaces in... Wouter Wolters
16:40 Revision e981c9b2: [CLEANUP] Remove unnecessary fully qualified names
Remove unnecessary fully qualified names from Utility classes.
Resolves: #62505
Releases: master
Change-Id: I3d4af98... Frank Nägler
00:40 Revision bce1b68e: [BUGFIX] Broken icon on lowlevel > DB Check
Resolves: #61443
Releases: master
Change-Id: I2a524b3b066712a614534acb14eaef28c4fce86e
Reviewed-on: http://review.typ... Felix Kopp
00:11 Revision 3cd222a2: [BUGFIX] Let save and preview button behave as user initiated
Browsers started to distinguish how opening a new window
from JavaScript happens. They track "user initiated"
opening... Helmut Hummel
00:10 Revision ae1bdc3f: [BUGFIX] Let save and preview button behave as user initiated
Browsers started to distinguish how opening a new window
from JavaScript happens. They track "user initiated"
opening... Helmut Hummel

2014-10-27

22:41 Revision fe5fd613: [TASK] Use HTML5 input type "email" in user settings
The field "email" should use the input type "email".
Resolves: #62504
Releases: master
Change-Id: I1f443eac86508dd91... Georg Ringer
21:06 Revision 126e2672: [TASK] Add icon for collapsed table in list module
The icon for collapsed table must be also styled with a
font awesome icon as the expand icon.
Resolves: #62439
Relea... Georg Ringer
20:53 Revision 2ce44f27: [BUGFIX] Fix suggest wizard for new CE in flexforms
When having a suggest wizard inside a flexform on a
new content element edit form, we have the problem that
we can't ... Markus Klein
20:32 Revision 02c85f5c: [BUGFIX] Declare statically called method static
InlineElement::updateInlineView() is only used once throughout the core
and called statically, although the method is... Helmut Hummel
20:27 Revision fc9666b2: [BUGFIX] Declare statically called method static
InlineElement::updateInlineView() is only used once throughout the core
and called statically, although the method is... Helmut Hummel
20:00 Revision 3c744026: [BUGFIX] Only reload pagetree if pages are changed
When using the click menu to hide, unhide or delete
a record, previously the page tree was refreshed,
although those ... Helmut Hummel
19:50 Revision 4fac3bf5: [BUGFIX] Only reload pagetree if pages are changed
When using the click menu to hide, unhide or delete
a record, previously the page tree was refreshed,
although those ... Helmut Hummel
16:08 Revision eea2facc: [BUGFIX] RTE: Documentation of enableWordClean is wrong
The HTMLparser properties must be defined under subproperty HTMLparser
of enableWordClean and not directly under prop... Stanislas Rolland
16:07 Revision 14cea0f3: [BUGFIX] RTE: Documentation of enableWordClean is wrong
The HTMLparser properties must be defined under subproperty HTMLparser
of enableWordClean and not directly under prop... Stanislas Rolland
15:30 Revision cbeb3392: [BUGFIX] FormEngine paddings, margins, colors, borders
Fixes several layout issues with the FormEngine form:
Adds space between checkbox+label.
Forms element browser link ... Felix Kopp
15:06 Revision 298f0cc0: [FEATURE] Video player in backend (i) window
Allow video and audio playback in the backend (i) element
information window.
Uses the new introduced RenderingRegis... Felix Kopp
14:46 Revision f058cf74: [FEATURE] Refactor toolbar / topbar HTML5 & layout
First step for Toolbar/Topbar refactoring. This is a first step
to refactor HTML5 output - the path to gain HTML5 vie... Felix Kopp
14:12 Revision 5dfa45b4: [TASK] Use "int" in @param notation
This is a follow-up patch for
https://review.typo3.org/33522/
Resolves: #62467
Releases: master
Change-Id: I19333d6e... Frank Nägler
13:36 Revision 6d4fdb16: [CLEANUP] Introduce getters for globals in BackendUtility
Resolves: #62414
Releases: master
Change-Id: I5f77e85e59a014eeb86fd9ee4db839679c0eac98
Reviewed-on: http://review.typ... Markus Klein
12:38 Revision 63268748: [TASK] Use "bool" in @param notation
This patch is a follow-up patch for
https://review.typo3.org/33523/
Resolves: #62468
Releases: master
Change-Id: Ib1... Frank Nägler

2014-10-26

20:19 Revision cdefaadc: [FEATURE] Put up (badge) in top bar toolbar-items
Makes the (badge) elemente a tiny bubble in the top right
corner of the toolbar-item links.
Revoles: #62479
Releases... Felix Kopp
20:12 Revision 5ad7485b: [TASK] Remove table usage in "User settings" + base on Twbs
The module "User settings" currently uses tables to style the form.
This must be changed to use a proper markup.
Add... Georg Ringer
19:59 Revision 86c7a58f: [BUGFIX] Fix suggest wizard for new CE in flexforms
When having a suggest wizard inside a flexform on a
new content element edit form, we have the problem that
we can't ... Markus Klein
19:48 Revision be671f76: [TASK] Sys_note: Bring headline & delete action icon
To finalze the rebrush of sys notes a section headline is added:
The delete action can be accessed right from the not... Felix Kopp
18:14 Revision eafcde18: [FEATURE] Add methods to get class tag values via reflection
This patch adds ReflectionService::getClassTagsValues($className) and
ReflectionService::getClassTagValues($className... Frank Nägler
17:25 Revision a4574349: [TASK] Replace old fe_users icon with new one
Change path of fe_users icon in TCA to same as in page tree.
See Edit page > Behaviour > Contains plugin
Resolves: #... Felix Kopp
17:14 Revision c2951669: [TASK] Replace old fe_users icon with new one
Change path of fe_users icon in TCA to same as in page tree.
See Edit page > Behaviour > Contains plugin
Resolves: #... Felix Kopp
15:43 Revision 9515f6ee: [BUGFIX] Link to ext:perm in clickmenu not working
The link refers directly to index.php instead of mod.php.
Use BackendUtility::getModuleUrl() for the link to fix the ... Wouter Wolters
15:42 Revision b98e6450: [BUGFIX] Link to ext:perm in clickmenu not working
The link refers directly to index.php instead of mod.php.
Use BackendUtility::getModuleUrl() for the link to fix the ... Wouter Wolters
00:13 Revision fba8a5a3: [!!!][TASK] Move flash message output to alerts
Since bootstrap is available it would make sense to
use the alert classes instead of the custom implementation.
Reso... Georg Ringer

2014-10-25

21:51 Revision b72815a9: [TASK] Add phpDoc in ClickMenu
* Make real booleans
* Adds strict comparison where possible
Resolves: #62460
Releases: master
Change-Id: I5dd88eb23... Wouter Wolters
21:48 Revision 626c3afd: [TASK] Use "int" in @param notation
Resolves: #62467
Releases: master
Change-Id: I927a16b0fa89c5b859b56a7549548102ac04037f
Reviewed-on: http://review.typ... Wouter Wolters
21:32 Revision e0d328aa: [TASK] Use "bool" in @param notation
Resolves: #62468
Releases: master
Change-Id: I2790ca5817e16cfe0dc1c43151d2587ca796294a
Reviewed-on: http://review.typ... Wouter Wolters
11:56 Revision 90fcd4a2: [BUGFIX] Fix JS error in SuggestWizard
This is regression fix for #59701.
The ID of new Content Elements now contain a dot character.
Fix the generated JS ... Markus Klein
11:55 Revision 85bfe391: [BUGFIX] Fix JS error in SuggestWizard
This is regression fix for #59701.
The ID of new Content Elements now contain a dot character.
Fix the generated JS ... Markus Klein

2014-10-24

23:16 Revision 33aaf53c: [FEATURE] Add multiple parameter in f:form.checkbox
This patch introduce the multiple parameter
for f:form.checkbox ViewHelper of fluid.
Resolves: #61529
Releases: mast... Stefan Froemken
23:15 Revision ad2cfb7d: [FEATURE] Add multiple parameter in f:form.checkbox
This patch introduce the multiple parameter
for f:form.checkbox ViewHelper of fluid.
Resolves: #61529
Releases: mast... Stefan Froemken
22:43 Revision 81259449: [BUGFIX] Extra click menu options on second level not rendered
The merge extra_page_cm_options was not correct. The second level
is never rendered again. Fix this by moving it into... Wouter Wolters
22:22 Revision aea236c2: [FEATURE] Configure CSS class as non-selectable in RTE
To filter some useless classes for authors, we can configure classes as
non-selectable in block or text style selecto... Stanislas Rolland
16:37 Revision d435d0ca: [BUGFIX] RTE: In Chrome RTE inserts weird span tags
Remove the span tags inserted by Chrome or Opera on execution of
native execCommand. The attributes of these span tag... Stanislas Rolland
16:36 Revision d7fd9458: [BUGFIX] RTE: Multilingual classesAnchor titleText not possible
Content language is not correctly set by RTE controller.
Releases: master, 6.2
Resolves: #62399
Change-Id: I85eb570d... Stanislas Rolland
16:35 Revision 07fb3d8a: [BUGFIX] RTE: Multilingual classesAnchor titleText not possible
Content language is not correctly set by RTE controller.
Releases: master, 6.2
Resolves: #62399
Change-Id: I85eb570d... Stanislas Rolland
09:41 Revision 23a2a7cb: [TASK] Remove table for icons in TCA type "select"
The TCA type "select" uses a table to render the belonging icons.
Use divs instead for the markup.
Change-Id: I9bd8f... Georg Ringer
00:36 Revision 0a517b0a: [BUGFIX] Fix unit tests for TaskExecutor
Resolves: #60296
Releases: 6.1
Change-Id: Ic4b237a3589a82ef9f870221ef930e0a182e1c85
Reviewed-on: http://review.typo3.... Wouter Wolters
00:11 Revision 75f21f06: [BUGFIX] Misaligned radio buttons
In the TYPO3 CMS BE, radio buttons are not well aligned
with their labels. Fix it with a top margin definition.
See ... Francois Suter
00:10 Revision b0eb2878: [BUGFIX] Missing and invalid warnings on referenced files
The file list module in the backend offers the possibility to
delete files. An interesting use case is the deletion o... Oliver Hader
00:09 Revision a79bb23c: [BUGFIX] Missing and invalid warnings on referenced files
The file list module in the backend offers the possibility to
delete files. An interesting use case is the deletion o... Oliver Hader

2014-10-23

23:48 Revision e26961c8: [BUGFIX] Missing and invalid warnings on referenced files
The file list module in the backend offers the possibility to
delete files. An interesting use case is the deletion o... Oliver Hader
23:30 Revision 618c458b: [CLEANUP] TSFE: Deprecate JSfuncCalls for body tag
For old systems without proper JS libraries or usages like GMENU_LAYERS
TSFE provides an array to register handlers d... Benni Mack
23:02 Revision 89006b65: [BUGFIX] Respect different object mapping for scheduler tasks
Resolves: #60296
Releases: master, 6.2, 6.1
Change-Id: I7bff792b33ffecbe53ac4aee848e6ad16318a538
Reviewed-on: http://... Mathias Brodala
23:01 Revision 92f9daf3: [BUGFIX] Respect different object mapping for scheduler tasks
Resolves: #60296
Releases: master, 6.2, 6.1
Change-Id: I7bff792b33ffecbe53ac4aee848e6ad16318a538
Reviewed-on: http://... Mathias Brodala
22:58 Revision e24ffe5c: [BUGFIX] Respect different object mapping for scheduler tasks
Resolves: #60296
Releases: master, 6.2, 6.1
Change-Id: I7bff792b33ffecbe53ac4aee848e6ad16318a538
Reviewed-on: http://... Mathias Brodala
22:47 Revision 528429b9: [BUGFIX] softrefproc typolink lacks support for separation by line feed
Since #24121 the field content in "image_link" is separated by line
feeds instead of commas. Since then the soft refe... Marc Bastian Heinrichs
22:46 Revision 83a4e3f5: [BUGFIX] softrefproc typolink lacks support for separation by line feed
Since #24121 the field content in "image_link" is separated by line
feeds instead of commas. Since then the soft refe... Marc Bastian Heinrichs
22:46 Revision 9de3c3a2: [TASK] Rename "Extensions" backend module
Renames backend module Extension manager to "Extensions".
Also lowers language barriere in "Manage Extensions".
Reso... Felix Kopp
22:42 Revision e44019ad: [BUGFIX] ErrorHandler: Stop execution if E_RECOVERABLE_ERROR occurs
Ensure the ErrorHandler stops script execution if an error occurs.
Resolves: #61213
Releases: master, 6.2, 6.1
Chang... Markus Klein
22:39 Revision 432be3b0: [BUGFIX] ErrorHandler: Stop execution if E_RECOVERABLE_ERROR occurs
Ensure the ErrorHandler stops script execution if an error occurs.
Resolves: #61213
Releases: master, 6.2, 6.1
Chang... Markus Klein
22:34 Revision 166439a7: [BUGFIX] ErrorHandler: Stop execution if E_RECOVERABLE_ERROR occurs
Ensure the ErrorHandler stops script execution if an error occurs.
Resolves: #61213
Releases: master, 6.2, 6.1
Chang... Markus Klein
21:59 Revision d99fb24a: [BUGFIX] ClassLoader also needs to check for interfaces
An interface might already be defined, check for existence before trying
to require it, which will cause PHP errors i... Markus Klein
21:57 Revision 707a069b: [BUGFIX] ClassLoader also needs to check for interfaces
An interface might already be defined, check for existence before trying
to require it, which will cause PHP errors i... Markus Klein
21:39 Revision ebddb548: [TASK] Remove TCA definitions for pre FAL fields
There are some overrides in the CMS extension that provide the old
TCA for the image and media fields of tt_content a... Thomas Maroschik
21:32 Revision 1c1381b6: [FEATURE] Base Buttons on Bootstrap - with compat layer
Bring default button style and base CSS definitions on Bootstrap
buttons. Brings backward compatibility for all butto... Felix Kopp
18:51 Revision 13cb0de8: [TASK] Follow-up: Action icon mapping - more icons
Map further icons from t3skin / sprite icons to FontAwesome.
Unify actions.
Resolves: #62393
Releases: master
Change... Felix Kopp
18:46 Revision 94fae896: [TASK] Base Web>List on new .table style
Base Web>List on common fresh table style in CSS
class "t3-table". Can be styled centrally now.
Resolves: #62384
Rel... Felix Kopp
18:38 Revision 078179dc: [TASK] Remove horizontal scrollers / secondary info
Solves problems with horizontal scrolling on small (SM)
and extra small (XS) screen within the backend.
Secondary in... Felix Kopp
14:48 Revision 9647bb9e: [FEATURE] Allow adding multiple CSS files in RTE
Allow to add more than one CSS file in the RTE header.
The new syntax is like this:
RTE.default.contentCSS {
... Stanislas Rolland
02:42 Revision ded8651c: [BUGFIX] Make ContentSlide work correctly if last element is empty
When using ContentSlide and the last content element in a column returns
an empty string, the slide continues up in t... Robert Vock
02:42 Revision cf618ed3: [BUGFIX] Make ContentSlide work correctly if last element is empty
When using ContentSlide and the last content element in a column returns
an empty string, the slide continues up in t... Robert Vock
00:50 Revision 9ac03e38: [FEATURE] RTE: Deprecated JavaScript methods removed
This change adds documentation of breaking change #62291 which
removed some deprecated JavaScript methods of the RTE.... Stanislas Rolland
00:39 Revision 28577969: [BUGFIX] RTE: In Chrome RTE inserts weird span tags
Remove the span tags inserted by Chrome or Opera on execution of
native execCommand. The attributes of these span tag... Stanislas Rolland

2014-10-22

23:53 Revision ef51d09c: [FEATURE] Make RTE overlay popups maximizable
This will make the link and image popus maximizable, and the spell
checker popup as well.
Resolves: #57875
Releases:... Stanislas Rolland
21:52 Revision 6139bc0e: [TASK] RTE: Split main JS script into components
Split the main script one class per file.
Releases: master
Resolves: #62404
Change-Id: Ide50dcae24339f7af4fbe4128b79... Stanislas Rolland
19:00 Revision a62c19e5: [BUGFIX] Ensure PHP 5.2 compatibility in makeInstance
The backport #53682 introduced a regression with PHP 5.2,
which still is officially supported by TYPO3 CMS 4.5
Adapt... Helmut Hummel
10:45 Revision a947db52: [TASK] Set TYPO3 version to 6.2.7-dev
Change-Id: If7d07a856f639be00c5e15f5fbdee3096fc178dc
Reviewed-on: http://review.typo3.org/33468
Reviewed-by: TYPO3 Re... TYPO3 Release Team
10:45 Revision a34edf6b: [RELEASE] Release of TYPO3 6.2.6
Change-Id: I39f6cbca69717cc894fbd9145fb1456c8ed79ef4
Reviewed-on: http://review.typo3.org/33467
Reviewed-by: TYPO3 Re... TYPO3 Release Team
10:36 Revision 70af67e1: [TASK] Set TYPO3 version to 6.1.13-dev
Change-Id: If07dc024f313c5c276cb5cc5d3cfabc3fea61c68
Reviewed-on: http://review.typo3.org/33466
Reviewed-by: TYPO3 Re... TYPO3 Release Team
10:36 Revision fc113eeb: [RELEASE] Release of TYPO3 6.1.12
Change-Id: If1ce879e763b18ef0124317ff63b3afbeb2073a8
Reviewed-on: http://review.typo3.org/33465
Reviewed-by: TYPO3 Re... TYPO3 Release Team
10:28 Revision ba522a87: [TASK] Set TYPO3 version to 4.7.21-dev
Change-Id: I129536ec1c665f0446f5d910e00fe941d2d63236
Reviewed-on: http://review.typo3.org/33464
Reviewed-by: TYPO3 Re... TYPO3 Release Team
10:28 Revision 3821b49c: [RELEASE] Release of TYPO3 4.7.20
Change-Id: Ie1c239fcb723c4ecaa1743f6601a4f739f972bd8
Reviewed-on: http://review.typo3.org/33463
Reviewed-by: TYPO3 Re... TYPO3 Release Team
10:18 Revision 4534943a: [TASK] Set TYPO3 version to 4.5.38-dev
Change-Id: Ie90485ebcb8da9859020a18cabc19a17e504737c
Reviewed-on: http://review.typo3.org/33462
Reviewed-by: TYPO3 Re... TYPO3 Release Team
10:17 Revision f4324212: [RELEASE] Release of TYPO3 4.5.37
Change-Id: I2156d74111b5594f5bf18d8cd274877b563b73c7
Reviewed-on: http://review.typo3.org/33461
Reviewed-by: TYPO3 Re... TYPO3 Release Team
10:14 Revision 9268147b: [SECURITY] Fix DoS in openid
Upgrade openid to latest upstream version.
This includes the sec fix already.
Change-Id: I71efa194dc75846e6b2e118781... Markus Klein
10:14 Revision 19fb2c51: [SECURITY] Fix DoS in openid
Upgrade openid to latest upstream version.
This includes the sec fix already.
Change-Id: I2e31f9d15863a13ab34e4c4472... Markus Klein
10:14 Revision ead183c5: [SECURITY] Fix RCE in swiftmailer
A remote code execution vulnerability was fixed upstream
which is now also fixed in the code we deliver with TYPO3.
... Helmut Hummel
10:14 Revision e92c1d69: [SECURITY] Fix DoS in openid
Upgrade openid to latest upstream version.
This includes the sec fix already.
Change-Id: I861046863479d8b32067dbc3cc... Markus Klein
10:14 Revision 6af37574: [SECURITY] Fix RCE in swiftmailer
A remote code execution vulnerability was fixed upstream
which is now also fixed in the code we deliver with TYPO3.
... Helmut Hummel
10:14 Revision ef6f5186: [SECURITY] Fix DoS in openid
Upgrade openid to latest upstream version.
This includes the sec fix already.
Change-Id: Iff7ebf2d8ff8e6a3776af66e3e... Markus Klein
10:14 Revision fb9f89d2: [SECURITY] Fix RCE in swiftmailer
A remote code execution vulnerability was fixed upstream
which is now also fixed in the code we deliver with TYPO3.
... Helmut Hummel
10:14 Revision 727258f2: [SECURITY] Fix DoS in openid
Upgrade openid to latest upstream version.
This includes the sec fix already.
Change-Id: I627b56683477651db7b3bc305f... Markus Klein
10:14 Revision 313c4bba: [SECURITY] Fix RCE in swiftmailer
A remote code execution vulnerability was fixed upstream
which is now also fixed in the code we deliver with TYPO3.
... Helmut Hummel
10:14 Revision d3222e5f: [SECURITY] Fix DoS in openid
Upgrade openid to latest upstream version.
This includes the sec fix already.
Change-Id: I00c77ed8ab31ed21dd21914d92... Markus Klein
10:14 Revision 4079e1a4: [SECURITY] Fix RCE in swiftmailer
A remote code execution vulnerability was fixed upstream
which is now also fixed in the code we deliver with TYPO3.
... Helmut Hummel
10:13 Revision da32b500: [SECURITY] Fix DoS in openid
Upgrade openid to latest upstream version.
This includes the sec fix already.
Change-Id: I5bf8375ee1a71c34363d265db3... Markus Klein
10:13 Revision dbdd9f22: [SECURITY] Fix RCE in swiftmailer
A remote code execution vulnerability was fixed upstream
which is now also fixed in the code we deliver with TYPO3.
... Helmut Hummel
09:50 Revision 75158863: [TASK] styleguide: Raise version requirement to TYPO3 7
Felix Kopp
09:49 Revision bd526a9e: [TASK] styleguide: Headline small inset
Felix Kopp
09:49 Revision 7781706f: [TASK] styleguide: Show twbs Bootstrap buttons
Felix Kopp
00:35 Revision 3c541b50: [BUGFIX] EM: Upload icon -> inline form
Fixes inline loading upload form for extensions in EM.
Resolves: #62342
Releases: master
Change-Id: I6fd61b15b3aadce... Felix Kopp

2014-10-21

22:33 Revision 68fb73a3: [FEATURE] Registry for adding file rendering classes
To be able to render all kinds of media files a file renderingRegistry
is needed where you can register a "renderer" ... Frans Saris
21:16 Revision e4c89f9d: [FEATURE] Refactor & recolor Modul-Menu (Bootstrap)
Base module menu on Bootstrap less variables navbar-inverse.
First step on roadmap to a backend scaffold without ExtJ... Felix Kopp

2014-10-20

22:50 Revision dec07e3c: [BUGFIX] jsfunc.inline is not fully jQuery compatible
When working with TYPO3.jQuery you don't get the object itself,
it returns a jQuery object which contains the mention... Stefan Froemken
21:51 Revision 42e5a3c5: [BUGFIX] DocumentTemplate TabMenu output fixed
Output Bootstrap compatible HTML5 output for
DocumentTemplate TabMenuRaw.
Resolves: #62317
Releases: master
Change-I... Felix Kopp
12:07 Revision c0dd8d59: [TASK] Update version number for master to 7
Update version number of all sysext and dependency definitions.
Resolves: #62341
Releases: master
Change-Id: Ic8b1b8... Markus Klein

2014-10-19

16:33 Revision 0c9a2560: [FEATURE] RTE: Avoid overhead of Ext.each and Ext.iterate
Improve performance by replacing Ext.each and Ext.iterate with
standard JS for statements.
Releases: master
Resolves... Stanislas Rolland
16:05 Revision 1f540151: [TASK] styleguide: Icon 2.0
Felix Kopp

2014-10-18

23:31 Revision a1f4bfc9: [BUGFIX] Use correct font awesome icon for text file type
Use the correct class "fa-file-text".
Resolves: #62322
Releases: master
Change-Id: I2ebc743aad88b3fcb91152f27f20d48c... Georg Ringer
01:23 Revision fae0f82f: [BUGFIX] RTE: Insert Tag dialogue may raise security error in Firefox
Problem: If a style sheet from another domain is imported by the style
sheet configured for the RTE, a security error... Stanislas Rolland
01:23 Revision f3987391: [BUGFIX] RTE: Insert Tag dialogue may raise security error in Firefox
Problem: If a style sheet from another domain is imported by the style
sheet configured for the RTE, a security error... Stanislas Rolland

2014-10-17

23:01 Revision ee7f2842: [TASK] Use a new icon for sys_action toolbar
The sysaction icon in the toolbar must also be changed to an icon
of font awesome.
Resolves: #62315
Releases: master... Georg Ringer
22:12 Revision 8f084617: [FEATURE] RTE: remove deprecated JavaScript methods
Some JavaScript methods are deprecated since TYPO3 4.7.
Releases: master
Resolves: #62291
Change-Id: Ie427dc8e898233... Stanislas Rolland
22:08 Revision d9b80a62: [BUGFIX] RTE: Edit element dialogue may raise JavaScript error
When clicking ok, some tabs may have not been rendered. Check for
presence of elements and values.
Releases: master,... Stanislas Rolland
22:07 Revision bb0cfc60: [BUGFIX] RTE: Edit element dialogue may raise JavaScript error
When clicking ok, some tabs may have not been rendered. Check for
presence of elements and values.
Releases: master,... Stanislas Rolland
18:47 Revision 4e2d3c2a: [BUGFIX] Visual regressions and unifications in Backend
Unifies tables in documentation, web>info page info + language,
scheduler edit and typoscript object browser.
Also d... Felix Kopp
18:02 Revision 87f60fbe: [BUGFIX] RTE: Remove cut, copy and paste buttons in Firefox
Support for allowClipboard policy has been dropped by Firefox 29.
Therefore, remove cut, copy and paste buttons from ... Stanislas Rolland
18:02 Revision c0d63536: [BUGFIX] RTE: Remove cut, copy and paste buttons in Firefox
Support for allowClipboard policy has been dropped by Firefox 29.
Therefore, remove cut, copy and paste buttons from ... Stanislas Rolland
15:12 Revision f7d84a14: [TASK] Base backend login on Twitter Bootstrap
* Change HTML & CSS by using twb
* Cleanup the Controller, e.g remove backend_old setting
Gorgeous brand new login s... Ingo Pfennigstorf

2014-10-16

22:44 Revision 41382dfd: [BUGFIX] Handle utf8 strings in TitleCaseFilter
Use proper charset aware string conversion API to handle
the value given to the TitleCaseFilter.
Resolves: #62279
Re... Graeme Worthy
22:43 Revision a56a0b64: [BUGFIX] Handle utf8 strings in TitleCaseFilter
Use proper charset aware string conversion API to handle
the value given to the TitleCaseFilter.
Resolves: #62279
Re... Graeme Worthy
12:40 Revision a07d6043: [TASK] Adjust Travis to new requirements for version 7
Drop the testing for PHP versions below 5.5
Resolves: #61969
Releases: master
Change-Id: I393a463e0ed1648b58c05c1691... Markus Klein
11:58 Revision e6daad92: [TASK] Refactor t3skin / re-work HTML / move to extension
Specific CSS styles that are only needed is a single place should
be held in that specific place also. Moves CSS styl... Felix Kopp
10:28 Revision 1b9dc380: [TASK] Move classAliasMaps into compatibility6 extension part 1
Change-Id: I5845baff737e739599cf29847981f56f5cf866e3
Resolves: #62026
Relates: #62013
Releases: master
Reviewed-on: h... Anja Leichsenring
10:26 Revision 38e34cf3: [BUGFIX] Fix unit tests for TypeConverter classes
The patch Ia4ec3a6c6f5bc6c07717a4956ab12e3e779c3c5a didn't adjust the
unit tests. This fix adds the missing mocks.
R... Markus Klein
10:25 Revision 03cb9701: [BUGFIX] Fix unit tests for TypeConverter classes
The patch Ia4ec3a6c6f5bc6c07717a4956ab12e3e779c3c5a didn't adjust the
unit tests. This fix adds the missing mocks.
R... Markus Klein

2014-10-15

23:24 Revision c566d953: [FEATURE] Monochrome action icons (FontAwesome)
Slot for IconUtility to hook into sprite icon generation.
Delivers monochrome action icons.
"Action icons start acti... Felix Kopp
23:19 Revision 2d0eb56b: [BUGFIX] Property of alternative model implementation not found
The PersistentObjectConverter is mapping submitted data to a
given target domain model. If a class gets overloaded wi... Oliver Hader
23:19 Revision 094cc0c1: [BUGFIX] Property of alternative model implementation not found
The PersistentObjectConverter is mapping submitted data to a
given target domain model. If a class gets overloaded wi... Oliver Hader
23:17 Revision fa817a7e: [BUGFIX] Add more entropy to uniqid
uniqid() generates values based on current time,
subsequent calls may return the same value on a fast machine.
On Wi... Tymoteusz Motylewski
22:40 Revision 4ebc5a4b: [TASK] styleguide: Supported icons / IconUtility
Felix Kopp
22:15 Revision 53ba0801: [BUGFIX] Fix Web>Page language view CE header
Fixed Content Element height for Content Element records
in Language view.
Resolves: #62260
Releases: master
Change-... Felix Kopp
21:39 Revision 15c77eaf: [TASK] Rework Module-Menu CSS/Less
Overwork Module-Menu CSS without visual changes.
Resolves: #62161
Releases: master
Change-Id: I8670548c7192d33755058... Felix Kopp
19:36 Revision 87eaea0b: [BUGFIX] Show correct number of inline records defined in flexform
getRelatedRecordsArray() is expecting comma separated list of record ids
Before this patch the full flexform xml was ... Daniel Alder
19:24 Revision 5ee67bca: [BUGFIX] Show correct number of inline records defined in flexform
getRelatedRecordsArray() is expecting comma separated list of record ids
Before this patch the full flexform xml was ... Daniel Alder
12:27 Revision fb5445ec: [BUGFIX] Allow lower case for drive letters on Windows in CLI scripts
Resolves: #61749
Releases: master, 6.2, 6.1
Change-Id: I88a3489311e8f94669876ddbe59589f68cd5708e
Reviewed-on: http://... Alexander Bohndorf
12:26 Revision 38921060: [BUGFIX] Allow lower case for drive letters on Windows in CLI scripts
Resolves: #61749
Releases: master, 6.2, 6.1
Change-Id: I88a3489311e8f94669876ddbe59589f68cd5708e
Reviewed-on: http://... Alexander Bohndorf
12:25 Revision 2b9bd407: [BUGFIX] Allow lower case for drive letters on Windows in CLI scripts
Resolves: #61749
Releases: master, 6.2, 6.1
Change-Id: I88a3489311e8f94669876ddbe59589f68cd5708e
Reviewed-on: http://... Alexander Bohndorf
12:24 Revision e350e867: [FEATURE] A new eval option in TCA: email
Add a new eval option called 'email' to validate e-mail addresses.
If validation fails, a flash error message will be... Olle Haerstedt

2014-10-14

23:15 Revision 5c8081ad: [TASK] Optimize speed for instantiating class with arguments
PHP reflection has quite an overhead in performance.
Use a switch construct like in Flow instead to
instantiate class... Helmut Hummel
01:07 Revision e2a52253: [TASK] Improve readability of TextElement code
FormEngine type="text" in class TextElements gets some
code beautification to improve readability.
Resolves: #62040
... Wouter Wolters

2014-10-13

23:54 Revision 01712231: [BUGFIX] Add trim to modificators in TS-Parser
It is documented that modificators are trimmed in
TypoScriptParser. But since #54856 they aren't trimmed anymore.
Tha... Stefan Froemken
23:53 Revision 2773fdaf: [BUGFIX] Add trim to modificators in TS-Parser
It is documented that modificators are trimmed in
TypoScriptParser. But since #54856 they aren't trimmed anymore.
Tha... Stefan Froemken
23:30 Revision e74260e2: [TASK] Move MysqlFulltextIndexHook to EXT:indexed_search_mysql
The hook MysqlFulltextIndexHook should be moved from indexed_search to
indexed_search_mysql because it is only used i... Georg Ringer
22:19 Revision df25f582: [TASK] Sort BE usergroup records in module "Backend Users"
Add a default ordering for the backend usergroup records
which makes it easier to find a specific group.
Change-Id: ... Georg Ringer
22:17 Revision c3029365: [TASK] Sort BE usergroup records in module "Backend Users"
Add a default ordering for the backend usergroup records
which makes it easier to find a specific group.
Resolves: #... Georg Ringer
19:49 Revision e0919fc9: [TASK] styleguide: Forms: Added TODO for broken JS to inline_3
Christian Kuhn
19:47 Revision 037c7ba6: [TASK] styleguide: Forms: Add inline_3 "useCombination" scenario
Christian Kuhn
16:53 Revision 3ed43b07: [TASK] styleguide: Forms: Change some namings and add some user functions
Christian Kuhn
16:26 Revision 069825e0: [TASK] Remove the "@todo define visibility" in ext:core
The "@todo Define visibility" is not very helpful because:
* Nobody knows what breaks if changing the visibility
*... Wouter Wolters
16:25 Revision c47215ff: [TASK] Remove the "@todo define visibility" in ext:rtehtmlarea
The "@todo Define visibility" is not very helpful because:
* Nobody knows what breaks if changing the visibility
*... Wouter Wolters
16:21 Revision e802a980: [TASK] styleguide: Forms: Add inline to tt_content in flex_3
Christian Kuhn
16:19 Revision 0d37d5b6: [TASK] Remove the "@todo define visibility" in various extensions
The "@todo Define visibility" is not very helpful because:
* Nobody knows what breaks if changing the visibility
*... Wouter Wolters
16:03 Revision a5de5e73: [TASK] styleguide: Forms: Add FAL field to inline_2 child
Christian Kuhn
15:53 Revision 78c9926f: [TASK] styleguide: Forms: Add inline 1:n foreign field
Christian Kuhn
14:51 Revision eb1dfd6f: [TASK] styleguide: Forms: Add typical FAL inline field
Christian Kuhn
12:48 Revision 13da155d: [BUGFIX] Fix missing new record button with enabled useCombination
Also add it if a record selector is shown.
Resolves: #60370
Related: #57488
Releases: master, 6.2
Change-Id: If4f345... Marc Bastian Heinrichs
12:47 Revision 50cff6c9: [BUGFIX] Fix missing new record button with enabled useCombination
Also add it if a record selector is shown.
Resolves: #60370
Related: #57488
Releases: master, 6.2
Change-Id: If4f345... Marc Bastian Heinrichs
11:37 Revision 7024ca84: [TASK] styleguide: Forms: Add RTE sheet, add section sheet
Christian Kuhn
09:13 Revision 4ad396da: [TASK] Label "Online Users" label in EXT: beusers label
Change label from "Active Sessions" to "Online Users"
in backend user administration module.
Also fixes bug in HTML ... Felix Kopp
07:53 Revision acf681f7: [TASK] Remove the "@todo define visibility" in ext:indexed_search
The "@todo Define visibility" is not very helpful because:
* Nobody knows what breaks if changing the visibility
*... Wouter Wolters
07:52 Revision da4f6807: [FEATURE] Backend skin: Fresh table style
Ease the table layout and embrace striped zebra style.
Remove borders - soften the header.
Resolves: #62159
Releases... Felix Kopp

2014-10-12

21:24 Revision 9731aa94: [TASK] Improve options for "Simulate backend user"
The option uses the syntax "username (real name)",
however the () are even added if no full name is available.
As a ... Georg Ringer
20:46 Revision 3c67ea97: [TASK] Remove the "@todo define visibility" in ext:backend
The "@todo Define visibility" is not very helpful because:
* Nobody knows what breaks if changing the visibility
*... Wouter Wolters
12:36 Revision 543c7109: Update README.md
TOC updated Felix Kopp
01:47 Revision 94f3b556: [TASK] Remove the "@todo define visibility" in ext:frontend
The "@todo Define visibility" is not very helpful because:
* Nobody knows what breaks if changing the visibility
*... Wouter Wolters
 

Also available in: Atom