Activity
From 2017-01-12 to 2017-02-10
2017-02-10
- 20:19 Revision a5c513a3: [TASK] Update CKEDITOR to 4.6.2
- New features:
* Added a new pastel color palette for the Color Button plugin and a
new config.colorButton_colorsPerRo... - 20:14 Revision 861cb240: [BUGFIX] Show record title for inline element
- Currently no record titles for nested inline elements are shown. Due to
the current method to resolve a record title ... - 20:05 Revision 214d2667: [BUGFIX] Copying a record with translation and IRRE relation fails
- The data-map processing for "allowLanguageSynchronization" tries to
resolve language dependencies for IRRE child reco... - 20:04 Revision b477adeb: [CLEANUP] Use correct type hint for messages in install tool updates
- The data type of customMessage has been changed to string a while ago
but the method signatures still have a mixed-ty... - 17:20 Revision 6258447e: [BUGFIX] PageTree: Re-introduce queueing
- With the removal of the ExtJS state providers, the polyfill
`TYPO3ExtJSStateProviderBridge` with a limited functional... - 12:51 Revision e606f802: [BUGFIX] Show record title for inline element
- Currently no record titles for nested inline elements are shown. Due to
the current method to resolve a record title ... - 11:47 Revision cf7a0ca4: [BUGFIX] Reintroduce context menu on page title in the page tree
- Since context menu refactoring https://review.typo3.org/#/c/50124/
the context was not showing when right clicking on... - 11:00 Revision 277b97ef: [TASK] Upgrade to version 4.5.0 of D3.js
- New features/fixes:
4.4.4:
* Fix calculation of clock skew when page is backgrounded
before timers are scheduled.... - 10:46 Revision d6748dbf: [BUGFIX] Do not use array assignment for string variable
- In PHP 7.1 it is not possible anymore to assign a value to
a variable of type string with `[]` appended. In older PHP... - 01:50 Revision c8d94612: [TASK] Make LinkPopup popup larger
- Especially if setting links to records, the default size
of the popup is just too small. Change it to 1000 px width.
... - 01:47 Revision c084eb33: [FOLLOWUP][FEATURE] Streamline Fluid Styled Content and CSS Styled Content
- Removed use of undefined variable.
Resolves: #79622
Related: #79622
Releases: master
Change-Id: I91935ec80e2ff2963dc... - 01:34 Revision 57651ae6: [TASK] Implement group "mysql" in functional tests
- Add group "mysql" to select functional tests that require a MySQL
Server as a database backend due to testing functio... - 01:19 Revision eaa69dc5: [TASK] Allow risky fixers
- php-cs-fixer added "no_alias_functions" to its ruleset of risky fixers.
This patch allows risky fixers to be run.
Ch... - 00:51 Revision 5365d875: [BUGFIX] Flaky unit tests FrontendUserAuthentication
- Unit testing user authentication is still a mess since the class
does way too much to be well testable.
The patch ref...
2017-02-09
- 22:31 Revision ecfc3fe8: [TASK] Add value picker for target field in page record
- Make life of editors easier by providing a value picker for
the field 'target' of the page. An editor can now choose
... - 22:11 Revision d9bc5bed: [BUGFIX] Add returnUrl to clickmenu option
- Add the return url to the clickmenu option "'Create new' wizard".
Resolves: #79683
Releases: master
Change-Id: Ib38a... - 21:19 Revision fdec247f: [TASK] Update TYPO3 Icons to v1.1.0
- Update bower dependency. Add 22 new icons via bower
copy task and register them in the IconRegistry.
Resolves: #7971... - 12:39 Revision 1e85fe49: [BUGFIX] Fix JS errors in context menu
- Fixes two issues: syntax error (missing semicolon),
and "Uncaught TypeError: Cannot read property 'refresh' of undefi... - 11:16 Revision 6a7a25d6: [TASK] Usability improvements for scheduler module
- This patch add another icon for the „run on next cron“ button and add
tooltips for a better and faster understanding ... - 09:21 Revision 4ba68112: [BUGFIX] Use mb_strlen in StringLengthValidator
- By using mb_strlen for checking the length, the
check counts multibyte values now correctly.
Resolves: #79684
Releas... - 08:40 Revision d4f2a832: [TASK] Add common image ratio 3:2 to cropVariants
- In addition to 16:9, 4:3, 1:1 and free another common
image ratio "3:2" (DSLR default format) is introduced.
Resolve... - 03:52 Revision 3b6d0a14: [BUGFIX] Add cropVariant support for broken GalleryProcessor
- Since the ImageManipulation wizard supports multiple crop variants, the
GalleryProcessor is broken. This patch add su... - 02:58 Revision e4968c46: [BUGFIX] UpgradeAnalysis fails on symlinked core
- Class DocumentationFile compared a real path with
a symlinked path resulting in an exception, even
though both paths ... - 01:19 Revision cb2d5249: [BUGFIX] Page module: fix bottom margin of language header
- Add missing `bottom-margin` by only overriding `margin-top`
of generic `h2` style.
Resolves: #79699
Releases: master...
2017-02-08
- 15:39 Revision d9a43710: [BUGFIX] Exclude honeypot field in EXT:form from tabbing
- When tabbing trough a form in frontend the honeypot textfield was
reachable. Add a tabindex -1 which prevents the cur... - 15:14 Revision 5f621d95: [FOLLOWUP][FEATURE] Streamline Fluid Styled Content and CSS Styled Content
- The database field `section_frame` is only available if CSS Styled
Content was installed previously, that needs to be... - 13:47 Revision cdd6dca4: [BUGFIX] Avoid overwriting configured Fluid template paths
- Due to change https://review.typo3.org/51283/ the defaultPaths in
Fluid overwrite the configuration paths for the fir... - 12:07 Revision 2464bbe0: [BUGFIX] Do not cache fallback View paths
- This patch fixes an issue with TemplatePaths, where paths
for a given extension key get used at two execution points:...
2017-02-07
- 22:34 Revision 9215c1cd: [FEATURE] Integration of a generic record link handler
- Enable linking to any record by migrating the code of
EXT:linkhandler into the core.
Resolves: #66373
Resolves: #663... - 22:31 Revision 61a0ef65: [TASK] Fix PSR-2 violations with php-cs-fixer
- Resolves: #79668
Releases: master
Change-Id: I78b9b85a5af2170ddb725dee969f090be1d444e3
Reviewed-on: https://review.ty... - 22:20 Revision 609e0a36: [FEATURE] Option to disable validation of stored records
- Adds two new configuration options to Install Tool which are used when
saving records using the DataHandler:
* disab... - 22:03 Revision c2b02f4d: [BUGFIX] Fix CGL script to new return status strategy of php-cs-fixer
- Status codes are only returned when running in dry-run mode.
Resolves: #79641
Releases: master,7.6
Change-Id: I3ca77... - 21:55 Revision 30085820: [BUGFIX] Fix CGL script to new return status strategy of php-cs-fixer
- Status codes are only returned when running in dry-run mode.
Resolves: #79641
Releases: master,7.6
Change-Id: I3ca77... - 21:26 Revision 06393839: [FEATURE] Add new imageManipulation supporting multiple crop variants
- This feature extends the image cropping tool in the backend
so that editors can now not only select one crop area,
bu... - 21:26 Revision 6b5e34df: [FEATURE] Add TypeScript and CSS for new imageManipulation
- This adds the necessary TypeScript and CSS changes
for the new imageManipulation element.
Resolves: #75880
Releases:... - 21:14 Revision 88182c3d: [FEATURE] Allow to set a custom id for fluid widgets
- With this patch you can set a customWidgetId parameter in the
widget viewhelper. This id is used in the widget identi... - 20:23 Revision e9fd5d0c: [FEATURE] EXT:Scheduler: Add link browser to choose a start page
- Resolves: #12211
Releases: master
Change-Id: I382945cd92dd8ca6c99ea200f93ea3ca2dfdef41
Reviewed-on: https://review.ty... - 20:20 Revision 2cb41db2: [FEATURE] Page module: Show notice "Content is also shown on:"
- If a page is selected in page module which content is also shown on
other pages, now a notice is shown with the title... - 19:52 Revision f9d17958: [FEATURE] Add useCacheHash to typolink viewhelpers
- Resolves: #79337
Releases: master
Change-Id: Ib93ac38f944d6ca74f6162e705f6bfa4fa3214a9
Reviewed-on: https://review.ty... - 18:32 Revision 7b0c27c8: [!!!][FEATURE] Refactor and streamline click menu / context menu
- This change unifies the ClickMenu functionality of the pagetree (ExtJS)
with the ClickMenu code given in other areas ... - 18:27 Revision 42e986bf: [FEATURE] Paste icons available at pasting position and use modal now
- Resolves: #13749
Releases: master
Change-Id: Iba428acf25875479aa703ad4a93832331ed0b0be
Reviewed-on: https://review.ty... - 17:54 Revision a3eae5a3: [TASK] Allow generated BE user avatars to be cached
- Given the assumption that this particular resource is not
one that changes very often one can benefit from storing
th... - 17:09 Revision 2fd70c83: [FEATURE] Introduce allowLanguageSynchronization
- This feature introduces a new functionality called
"allowLanguageSynchronization" which can be set on a field
configu... - 15:33 Revision 1dd78c74: [BUGFIX] Skip non existing DatabaseRowsUpdateWizard classes
- Resolves: #79661
Releases: master
Change-Id: I9639ad35764090aa38128671084e239b53639850
Reviewed-on: https://review.ty... - 14:45 Revision 1582ef11: [BUGFIX] Remove checked items from Upgrade Analysis
- Ignored files require the full path to a file for resurrection,
not just the headline.
Resolves: #79659
Releaes: mas... - 09:37 Revision 53fd04d1: [TASK] Update “typescript” package and recompile code
- TypeScript is updated to at least version 2.2.0. Existing code is
recompiled due do changes of defaults in TypeScript...
2017-02-06
- 23:06 Revision 80fec593: [!!!][FEATURE] Streamline Fluid Styled Content and CSS Styled Content
- CSS Styled Content has been a long time the preferred way of rendering
content in the frontend. Fluid Styled Content ... - 21:12 Revision 28ee049e: [FEATURE] Show list of failed input fields in FormEngine
- When validating input fields of the FormEngine fails, a button is now
rendered into the least possible button bar in ... - 21:05 Revision 2ce4d508: [BUGFIX] Show warning label for linkhandler if no label is defined
- If the configuration for a linkhandler has an empty label
put a warning label there instead to give the integrator a ... - 21:02 Revision ccdb2245: [BUGFIX] Typos and wording issues in master documentation
- Fixes: #79639
Releases: master
Change-Id: Ib1a963a4110114de4e2db533e610635a3a47cb6b
Reviewed-on: https://review.typo3... - 20:58 Revision ecbdc27b: [FEATURE] Auto-render and attach HeaderAssets and FooterAssets
- This patch adds a new method on ActionController,
initializeAssetsForRequest($request) which comes
with a default imp... - 20:50 Revision 51abba58: [BUGFIX] Show warning label for linkhandler if no label is defined
- If the configuration for a linkhandler has an empty label
put a warning label there instead to give the integrator a ... - 20:47 Revision 5e2310d5: [FEATURE] Show link information below input field
- Render link information below a link field to help editors.
Instead of 't3://page?uid=92 _top "a class" "a title"' th... - 20:21 Revision 955f4beb: [!!!][FEATURE] Introduce Session Framework
- A new session framework is introduced.
The goal is to provide interoperability between different
session storages (ca... - 15:34 Revision 12fd6b6a: [FEATURE] EXT:form - Extend SaveToDatabase finisher
- This feature extends the SaveToDatabase finisher with
the following functions:
* Perform multiple database operation... - 14:15 Revision 3ba114ff: [FOLLOWUP][FEATURE] Implement configuration for CKEditor
- Use correct field to determine page uid
Resolves: #78917
Releases: master
Change-Id: I01101640ff8ac1d801ef1619f8bc3c... - 09:10 Revision de6c3fa9: [TASK] Update outdated TYPO3 dependencies
- - Updating doctrine/collections (v1.3.0) to doctrine/collections (v1.4.0)
- Updating doctrine/annotations (v1.3.0) ... - 08:00 Revision 19cd33ee: [BUGFIX] Wrong position of init
- As storeIncomingData depends on some data,
which is generated in init, the init method
has to be called before.
Reso... - 07:59 Revision 2ecaa776: [BUGFIX] Wrong position of init
- As storeIncomingData depends on some data,
which is generated in init, the init method
has to be called before.
Reso... - 07:24 Revision e67a5366: [FEATURE] Auto-render HeaderAssets and FooterAssets in FLUIDTEMPLATE
- This patch adds a new feature for FLUIDTEMPLATE
content objects, allowing two new sections named
`HeaderAsstes` and `...
2017-02-05
- 23:23 Revision 28c19cc0: [TASK] EXT:form - optimize DatePicker element
- * add more configuration options to the DatePicker element
within the form editor
* render the frontend JavaScript ... - 23:04 Revision fcfbc6b7: [FEATURE] EXT:Scheduler: Implemented folding of scheduler task groups
- Resolves: #67243
Releases: master
Change-Id: Ic3d1bc45b9db9ae3eb6fd8f13a03fcf9125d7422
Reviewed-on: https://review.ty... - 22:53 Revision 35ee9682: [FEATURE] Storable Filters for Upgrade Analysis
- User can mark each file as 'hide from my view'. This
selection is stored in registry and applies for every user alike... - 22:33 Revision fd1be0ca: [BUGFIX] Null placeholder initialization in inline expand
- Opening a collapsed inline relation containing null placeholders
does not correctly initialize and both the value fie... - 22:30 Revision 3781ab49: [BUGFIX] Suggest wizard in flex forms
- A broken variable access is fixed to hand over correct data
to the type=group suggest wizard.
Change-Id: I0c6dbf3d7d... - 15:05 Revision f5c4ece1: [BUGFIX] Handle invalid link strings gracefully in LinkHandler
- Resolves: #79623
Releases: master
Change-Id: Iefef14b968d4edfbfbe221ee5b58e3947d5f0d9c
Reviewed-on: https://review.ty... - 12:32 Revision ec71cf95: [BUGFIX] Acceptance test paths
- Change-Id: I0660bddb5411c8b02fe2cf2e285343f90f49e4d9
Resolves: #79631
Related: #79518
Releases: master
Reviewed-on: h...
2017-02-04
- 17:38 Revision aa12bf38: [BUGFIX] Limit primary key length on be_session and fe_session table
- Patch for issue #79566 increased the field length of ses_name in
fe_session and be_session table from 32 to 255.
This... - 17:38 Revision bf399d1e: [BUGFIX] Limit primary key length on be_session and fe_session table
- Patch for issue #79566 increased the field length of ses_name in
fe_session and be_session table from 32 to 255.
This... - 16:29 Revision 2d9e345d: [BUGFIX] Add missing namespace parts
- As the main test case files are now
in subfolders, we need to correct the
namespaces.
Change-Id: Ie06edc099c5d3e42ff... - 02:05 Revision 2fd488d7: [TASK] Fix missing variable initialization in AbstractTreeView
- https://review.typo3.org/49750 introduced code that lacks
proper variable initialization.
Get this straight.
Resolve...
2017-02-03
- 21:45 Revision 90e832cd: [TASK] Fix missing variable initialization in AbstractTreeView
- https://review.typo3.org/49750 introduced code that lacks proper
variable initialization.
Get this straight.
Resolve... - 17:19 Revision 8e67fda0: [FOLLOWUP][TASK] Testing Framework Extraction - Next Steps
- Fix travis
Change-Id: Ib28fdfdfd87c3643e06fee4a67b9332b17227e48
Resolves: #79518
Releases: master
Reviewed-on: https... - 16:33 Revision 58bc34aa: [TASK] Testing Framework Extraction - Next Steps
- - Removal of the CMS part from the namespace
- Distinguish Classes / Resources
For background information see
https...
2017-02-02
- 21:31 Revision 77665609: [TASK] EXT:form - add unit tests for the translation service
- This patch adds unit tests and fixes a small bug.
Resolves: #79562
Releases: master
Change-Id: If71015177c4a36acde0b... - 21:30 Revision 5351ba2e: [FEATURE] EXT:form - Add multiselect inspector editor
- A new inspector editor, i.e. a new field type of the form editor,
has been added.
Additionally, this patch fixes the... - 19:37 Revision e05c6c82: [BUGFIX] PHP requirements: improve PHP setting value
- Streamline PHP environment setting values. The PHP
environment setting `max_execution_time` is an integer
according t... - 16:54 Revision a27347ab: [TASK] EXT:form - remove email validator for Textarea form elements
- Remove the email validator from the validators select list for
Textarea form elements within the form editor.
Resolv... - 16:29 Revision 4a8c1140: [BUGFIX] Move end tag of label in info module
- To make the click on the label work, move the end tag
after the text.
Resolves: #79603
Releases: master
Change-Id: I... - 15:55 Revision 4ae81593: [TASK] Show remaining characters in BE user settings module
- The fields name & email are saved in the database and therefore
the length of its value should be checked client side... - 15:49 Revision f66e421a: [FEATURE] Preview of plugins in the backend
- It is now possible to render the preview of plugins
just like of regular content elements.
Resolves: #79225
Releases... - 15:40 Revision bb37ec08: [BUGFIX] EXT:form load yaml configurations in defined order
- Changes configuration loading of yaml configurations. Orders the yaml configuration
by the numeric keys defined in Ty... - 15:19 Revision 4485151f: [TASK] Deprecate ClientUtility::getDeviceType
- The method ClientUtility::getDeviceType is not used
and completely outdated.
Resolves: #79560
Releases: master
Chang... - 15:11 Revision d47c3327: [BUGFIX] Hide password hash for RsaInputField
- If rsauth is used, the eval configuration does not
contain the setting 'password' and the password can always
be hidd... - 13:48 Revision 605b0c8d: [!!!][TASK] EXT:form - Refactor fluid rendering
- This patch is a followup of issue #79439.
EXT:form uses "fluid" as the default rendering strategy.
Therefore, EXT:fo... - 13:36 Revision 33adb38a: [BUGFIX] Set TYPO3_DLOG constant in testing framework
- The constant is undefined currently and hence leads to useless calls
to the devLog facility.
Set this constant to fal... - 13:31 Revision 094f6efa: [BUGFIX] Fix dom path to select items and buttons
- Resolves: #79600
Releases: master
Change-Id: Ife6221668159ea02e8980ab449d394c1a8fb3df3
Reviewed-on: https://review.ty... - 07:31 Revision 04f73977: [BUGFIX] Allow long cookie names
- With this patch cookie names longer than 32 chars are possible.
Resolves: #79566
Releases: master, 7.6
Change-Id: I5... - 07:31 Revision 0cc134ca: [BUGFIX] Allow long cookie names
- With this patch cookie names longer than 32 chars are possible.
Resolves: #79566
Releases: master, 7.6
Change-Id: I5... - 01:30 Revision 4289f163: [BUGFIX] Fix CSH on Info -> Pagetree overview
- Fixes undefined variable.
Releases: master
Resolves: #79586
Change-Id: I9873775cabfd274c03353b1022f325ee2636269f
Rev...
2017-02-01
- 19:35 Revision 6e18fe9e: [BUGFIX] Remove empty option tag in fluid select viewhelper
- Currently the select viewhelper produces an empty option tag, if no
argument "option" is provided. This is not needed... - 09:09 Revision bb177195: [FEATURE] Implement configuration for CKEditor
- The main problem with the current RTE configuration relies in the fact
that it is *only* configurable via pageTS.
CK... - 07:20 Revision a483d7a2: [TASK] Use strict comparison for strings
- Change string comparison for string checks. Checks which could lead
to false positives like comparing with '0' or '' ...
2017-01-31
- 21:07 Revision 120f7ea3: [BUGFIX] Remove additional lines in textareas of formengine
- Remove additional lines around the actual content of a
textarea.
Resolves: #79573
Releases: master
Change-Id: I636af... - 13:27 Revision 4714a9b1: [TASK] Clear search field in Install Tool with ESC
- As the search in the Install Tool > All configuration can be
triggered by using CTRL + f, it should also listen on th... - 12:40 Revision 9e020329: [BUGFIX] Temporarily skip repeatedly failing tests
- Resolves: #79552
Releases: master
Change-Id: I3da3eafd095a00062e01e4ab24d6c9ebf41c3a2e
Reviewed-on: https://review.ty... - 12:19 Revision 9076ee46: [TASK] Clear search field in Install Tool with ESC
- As the search in the Install Tool > All configuration can be
triggered by using CTRL + f, it should also listen on th...
2017-01-30
- 22:41 Revision 84cffd31: [TASK] Show description of tests in Install Tool at start
- The description of the following tests should be shown right away
instead after the test:
- Combining images
- Conve... - 20:28 Revision dca4d5d7: [TASK] Use normalized jpg_quality in GraphicalFunctions
- If the setting 'processor_effects' is set the already normalized
value of jpg_quality should be used.
Change-Id: Idc... - 16:05 Revision 47453763: [TASK] Add Index.rst to master folder
- Resolves: #79555
Releases: master
Change-Id: I1a7523dbc87907cba754c405cc4bbf9050a51255
Reviewed-on: https://review.ty... - 14:27 Revision f59b3ad7: [BUGFIX] Temporaryly skip tests repeatedly failing
- Change-Id: I7d2492782ff1a7203beafc37a1b4457bf65735a2
Resolves: #79552
Releases: master
Reviewed-on: https://review.ty... - 13:46 Revision 222ef599: [TASK] Link to crawler extension docs
- Change-Id: Ie1e780af0b15c9785225bd8a147b08458b6a3b06
Resolves: #79541
Releases: master
Reviewed-on: https://review.ty... - 13:36 Revision 31f751d3: [TASK] Use “error” icon for validation failures in FormEngine
- Currently, a warning sign is rendered next to field labels whose
validation failed. Failed validations are errors and... - 13:26 Revision 686c70ed: [BUGFIX] Fix wrong condition in method checkValueForText
- This makes "eval" processing working again for text fields.
Resolves: #79545
Related: #79341
Releases: master
Change... - 12:43 Revision 403a5b71: [FOLLOWUP][TASK] Code cleanup for RteHtmlParser
- Resolves: #79280
Releases: master
Change-Id: I1d3815cef36d624c910d40eb6d63a3eba4f3f53d
Reviewed-on: https://review.ty... - 11:52 Revision 8093cb00: [TASK] Improve LogEntries partial performance
- This patch avoids `f:switch` in the partial template,
since this ViewHelper is not compilable in the
version provided... - 07:05 Revision ed293f91: [BUGFIX] Remove ses_hashlock from acceptance test fixtures
- With the merge of #79513 the fields `ses_hashlock` were removed from
be_users and fe_users. The usages within the acc...
2017-01-29
- 13:09 Revision cbb4e482: [BUGFIX] Do not strip sub-paths from emulated controller name
- This patch solves a special case in the integration with
Fluid. Fluid itself allows an emulated controller action
to ... - 12:16 Revision 60229e00: [CLEANUP] Simplify updating of timestamp in writeForeignField
- There is no need to check the record we are updating -
since we update it anyway, update timestamp too and
save both ... - 12:15 Revision a7e2c7e7: [CLEANUP] Simplify updating of timestamp in writeForeignField
- There is no need to check the record we are updating -
since we update it anyway, update timestamp too and
save both ...
2017-01-28
- 19:39 Revision 77cd9436: [BUGFIX] EXT:linkvalidator Keep field content when saving new task
- When saving a new linkvalidator task in the scheduler and the validation
failed, now the previous input is kept in th... - 19:30 Revision c95fea47: [TASK] Remove alerts of locked records
- Use tooltips instead of ancient JavaScript alerts for locked
records.
Resolves: #79422
Releases: master
Change-Id: I... - 12:15 Revision 09f903d0: [BUGFIX] Change EM composer mode message to info level
- As https://review.typo3.org/#/c/44025/ enabled extensionmanager
offline mode for composer installations, the composer... - 12:14 Revision a47765a1: [BUGFIX] Change EM composer mode message to info level
- As https://review.typo3.org/#/c/44025/ enabled extensionmanager
offline mode for composer installations, the composer...
2017-01-27
- 17:13 Revision 06a50423: [BUGFIX] Avoid version overlay if EXT:version is not loaded
- PlainDataResolver will do semi-expensive operations for
workspaces-enabled tables even if EXT:version (and
therefore ... - 14:47 Revision f37a28db: [TASK] Consolidate code duplications in form data groups
- Introduce a new class `OrderedProviderList` which calls providers
with dependencies given by setter.
Resolves: #7951... - 13:11 Revision 728afa52: [BUGFIX] Extbase: Fix counting objects on joined tables
- While it's normally fine to replace DISTINCT with GROUP BY when counting
objects this results in a different resultse... - 12:39 Revision 69daabbf: [!!!][TASK] Move page module function QuickEdit to EXT:compatibility7
- To follow the concept of backend apps and provide a lean core by
removing a rarely used feature, which benefit is pre... - 12:17 Revision c54d442d: [FEATURE] EXT:Scheduler: Run manually executed tasks on next cron-run
- Added a feature to the scheduler to mark tasks to be run by
next cron job.
Resolves: #45537
Releases: master
Change-... - 12:10 Revision 9b1bcbf8: [!!!][TASK] Deprecate the field select_key of tt_content
- The field `select_key` is not used by the core and
is moved to the EXT:compatibility7.
Resolves: #77934
Releases: ma... - 12:02 Revision 4d3ded20: [BUGFIX] Persist traversable domain objects via identifier
- Objects implementing the DomainObjectInterface must always be
persisted using their identifier, even if they implemen... - 12:01 Revision 77fbd851: [!!!][TASK] Remove lockHashKeyWords functionality
- The TYPO3 Core used the "useragent" to create a hashbase
by default to harden the session hijacking functionality.
T... - 11:37 Revision c0d87152: [FEATURE] Add signal to exclude tables from ReferenceIndex
- A new signal is introduced to allow the exclusion of tables from the
ReferenceIndex. The checks whether tables or col... - 11:36 Revision 35cbc15f: [BUGFIX] Only perform reindex if data has indeed changed
- Change-Id: I889264f34599be556e16b3d37825a3761b681e70
Resolves: #79068
Releases: master, 7.6
Reviewed-on: https://revi... - 11:26 Revision cc7b4ad5: [BUGFIX] Only perform reindex if data has indeed changed
- Change-Id: I889264f34599be556e16b3d37825a3761b681e70
Resolves: #79068
Releases: master, 7.6
Reviewed-on: https://revi... - 11:17 Revision 9378ce8b: [BUGFIX] Persist traversable domain objects via identifier
- Objects implementing the DomainObjectInterface must always be
persisted using their identifier, even if they implemen... - 07:49 Revision 85ed5ef6: [TASK] Add .php_cs.cache to .gitignore
- The php-cs fixer creates a cache file which
should not be commited. Add it to the .gitgnore to avoid
any mistakes.
R... - 07:48 Revision ee644663: [TASK] Add .php_cs.cache to .gitignore
- The php-cs fixer creates a cache file which
should not be commited. Add it to the .gitgnore to avoid
any mistakes.
R...
2017-01-26
- 17:52 Revision 84be5e61: [!!!][FEATURE] FormEngine element level refactoring
- The patch introduces a new API on FormEngine element level
that substitutes the old "wizards" / renderWizard() API
wi... - 17:05 Revision 6752a362: [TASK] Functional test for VariableFrontend cache type
- Add a functional test to verify that serialized PHP objects
can be successfully stored in the database without having... - 16:53 Revision 87b78a63: [TASK] EXT:form - Add CE preview for form plugins
- Render the form label or a placeholder text (if no form is selected)
within the page module.
Resolves: #78834
Releas... - 16:48 Revision 973ffb7a: [TASK] EXT:form - Optimize frontend templates
- * add attribute role="alert" to error hints
* streamline bootstrap 3 error classes
* add attribute formnovalidate to ... - 16:25 Revision a62dbd10: [FEATURE] EXT:form - Add form settings button to module header
- Adds a new button into the form editor module header.
Clicking on this buttons shows the form settings within the ins... - 16:21 Revision 5b145511: [BUGFIX] EXT:form - parse finisher values only if string
- Parse finisher option values only if the referenced formelement value
is a string.
Resolves: #79412
Releases: master... - 16:17 Revision 2e872f48: [TASK] Improve constant editor
- - Skip length check of header
- Use type "number" for integer types
- Apply min & max attributes if available
Resolv... - 14:41 Revision e85dfe90: [BUGFIX] Fix SQL error in createEntryData
- The database field definition for ref_string is limited to varchar(200)
and can cause an SQL error when bigger string... - 13:09 Revision fdd4e302: [BUGFIX] Access check for delete pages expects array of integers
- An error occurs in the createNamedParameter function
which expects an array but gets a string instead.
Change-Id: I3... - 08:58 Revision 0b8c8fed: [TASK] Cleanup code of LocalizationController::process
- Change-Id: I6db726bfff61c092309a971eb71e074c30cad046
Releases: master, 7.6
Resolves: #79378
Reviewed-on: https://revi... - 08:57 Revision 4405c888: [TASK] Cleanup code of LocalizationController::process
- Change-Id: I6db726bfff61c092309a971eb71e074c30cad046
Releases: master, 7.6
Resolves: #79378
Reviewed-on: https://revi... - 03:06 Revision d20cd6cd: [TASK] Deprecate visibility for internal variables in Datahandler class
- This patch marks some internal cache variables in the
Datahandler as deprecated since their visibility should be
chan... - 01:30 Revision 40299330: [BUGFIX] Use subselect to update reference index
- Switch updateIndex method to use a subselect based approach
to avoid errors due to huge parameter lists for manually
... - 01:14 Revision 5ce457f0: [TASK] Adjust Cs-Fixer 2.0 hits
- With the update of cs-fixer to version 2.0, some checks
got minor changes in behaviour. The core follows now in
apply... - 01:01 Revision 8699a00e: [TASK] Update php-cs-fixer to version 2.0
- Change-Id: Ia32a61238bdf46c01a3856376c0a94d9d09339ee
Resolves: #79361
Releases: master, 7.6
Reviewed-on: https://revi... - 00:56 Revision f9c7157f: [BUGFIX] Debugger output: split lines before escaping them
- This fixes the issue that lines are wrapped within a HTML entity.
Resolves: #79398
Releases: master, 7.6
Change-Id: ... - 00:50 Revision de678f23: [BUGFIX] Debugger output: split lines before escaping them
- This fixes the issue that lines are wrapped within a HTML entity.
Resolves: #79398
Releases: master, 7.6
Change-Id: ... - 00:41 Revision 8703d364: [TASK] Cleanup ActionService::getVersionedId
- Within the refactoring process the optional parameter $useDeleteClause was missed
to remove from the parameter list o... - 00:39 Revision a70787f1: [BUGFIX] Add parameter types to database writes in functional tests
- When writing to database tables with BLOB type columns declare the field
type for the query parameters in functional ...
2017-01-25
- 22:34 Revision bbbf4c78: [BUGFIX] Fix title for expand button in workspace module
- Change-Id: I6a17811dd5dbc5ed285b6040fcbe97e94b416b8b
Releases: master
Resolves: #79321
Reviewed-on: https://review.ty... - 21:28 Revision d3371f04: [FEATURE] Add new ViewHelper f:variable via Fluid 2.2.0
- A new Fluid ViewHelper, `f:variable`, has become available
in TYPO3 after raising the minimum required version of the... - 20:15 Revision 37b7f532: [TASK] Adjust Cs-Fixer 2.0 hits
- With the update of cs-fixer to version 2.0, some checks
got minor changes in behaviour. The core follows now in
apply... - 19:49 Revision 2c23ecdf: [BUGFIX] Fix broken TypeScript compiler setting
- This patch adds a missing compilerOption to generate subfolder in the
build directory, which fix the copy to final de... - 18:46 Revision e6df53f7: [FEATURE] EXT:form - Add element selector for text editors
- Adds a new button to the text editors.
This splitbutton opens a list with available form elements.
If a form element ... - 18:17 Revision 1a318ec3: [TASK] Update php-cs-fixer to version 2.0
- Change-Id: Ia32a61238bdf46c01a3856376c0a94d9d09339ee
Resolves: #79361
Releases: master
Reviewed-on: https://review.ty... - 17:28 Revision 606d1841: [TASK] Update phpunit to version 5.7.5
- Change-Id: I118f4d6b9fd94fcaa0da3cef4e0f290b60c57fc8
Resolves: #79460
Releases: master
Reviewed-on: https://review.ty... - 17:27 Revision 868fd81f: [TASK] Update codeception to version 2.2.8
- We want to use the latest version.
Change-Id: I9f41f2b6e58020e01615569350b80afb34a3a067
Resolves: #79459
Releases: m... - 13:46 Revision 8bdbf0c1: [TASK] EXT:form - add onSubmit callback for pages
- Add onSubmit callback for toplevel composit elements aka. pages.
The ticket provides an example extension for testing... - 13:45 Revision 193d9b4e: [TASK] Ext:form - Add update option to saveToDatabase finisher
- This patch adds an option to the saveToDatabase finisher which makes it
possible to update an existing database recor... - 12:33 Revision 6861870f: [TASK] styleguide: TCA: Minor bugfix
- 11:10 Revision fadaaccf: [BUGFIX] EXT:form - editor error on mixed option key types
- Let the JavaScript 'Inspector-PropertyGridEditor' deal with mixed
option value types (string / int)
Resolves: #79457... - 10:39 Revision d918102b: [BUGFIX] EXT:form - fluid 2.2.0 compatibility
- With the update of fluid to 2.2.0 (e004145) the backend and frontend
break. This patch fixes these problems.
Change-... - 09:59 Revision 2e495439: [BUGFIX] Correctly show sub item indicator in svg tree
- Changes the way the svg tree nodes are checked for "indeterminate" state
after the data is loaded, so the initial sta... - 09:27 Revision 9e0e42a3: [BUGFIX] Use BLOB type column for uc in be_users table
- The unified handling for frontend and backend users requires
identical SQL column types to properly escape the input ... - 08:42 Revision ee1086c0: [BUGFIX] Don't query database with non-numeric uids in RelationHandler
- Check that a uid is numeric to prevent errors when querying an integer
database field with a string value like NEW123... - 08:18 Revision b51fdede: [BUGFIX][DBAL] Fix ExtensionManager repository insertion
- Resolves: #79143
Releases: master
Change-Id: I3cc6f0cff6980439f8f967f8ea627e074444f28c
Reviewed-on: https://review.ty... - 06:46 Revision 27fcf170: [BUGFIX] Convert fe_group in sys_collection to VARCHAR
- The core methods dealing with frontend group restrictions expect this
field to be of a character based datatype. Comp... - 05:15 Revision a522617e: [BUGFIX] Fix early return in addUnionStatement method
- Set $propertyPath, $tableName and $className to avoid
unnecessary joins and wrong repository results.
This is a regr...
2017-01-24
- 17:55 Revision c4999413: [TASK] styleguide: Remove last mention of tx_styleguide_elements_forms
- 17:54 Revision e607aa0e: Merge pull request https://github.com/TYPO3-CMS/styleguide/issues/80 from MonaMuzaffar/master
- removed broken element forms
- 15:26 Revision 5a80a615: removed broken element forms
- 11:49 Revision 1e1a129f: [TASK] styleguide: Rename fieldWizards to fieldWizard and fieldControls to fieldControl
- 09:12 Revision 1e038315: [BUGFIX] Render metatags on uncached pages
- Adding metatags on uncached pages using the pagerenderer didn't work
because the metatag array was rendered prior to ... - 09:12 Revision 41222e82: [BUGFIX] Render metatags on uncached pages
- Adding metatags on uncached pages using the pagerenderer didn't work
because the metatag array was rendered prior to ...
2017-01-23
- 21:47 Revision 0d8aa073: [TASK] Improve "Create multiple pages" wizard
- - Use xs instead of sm to support smaller screens
- Add an id to the select field
Resolves: #79418
Releases: master
... - 20:52 Revision 131586ad: [BUGFIX] Fix broken links to permission module
- This patch fix broken links in ClickMenu and DatabaseRecordList which
exists since the permissions module refactoring... - 20:44 Revision 81799a43: [BUGFIX] Fix broken links to permission module
- This patch fix broken links in ClickMenu and DatabaseRecordList which
exists since the permissions module refactoring... - 20:38 Revision 6e73c8c0: [TASK] Disable escaping pidRecordTitle in clickmenu move element
- Prevent the escaping of pidRecordTitle in click menu move element. The
escaping is already done in the MoveElementCon... - 19:51 Revision f5f1a59f: [TASK] Style select field of BackendUtility::getFuncMenu
- The select field of BackendUtility::getFuncMenu must be styled by
the class "form-control".
One example can be found... - 19:27 Revision db02db11: [BUGFIX] Remove double escaping in template module
- The information of a template (title, site title, description) is
already escaped by using fluid. Therefore the htmls... - 18:40 Revision 183d7a4b: [TASK] styleguide: TCA: New syntax in select
- 10:39 Revision 255651db: [TASK] Render information msg in TS module with a callout
- If a template record does not contain any constants, the information
should be rendered by a nice callout.
Resolves:... - 10:22 Revision 73b06f2b: [TASK] Allow new lines for description field
- As the description is a textarea, the rendering should support
lines as well.
Resolves: #79406
Releases: master, 7.6... - 10:19 Revision 3706b48d: [BUGFIX] Fix invalid button group markup in scheduler
- An element with the class `btn-group` must not also have the class `btn`.
Such occurences are fixed in this patch.
R... - 07:58 Revision d7143c10: [BUGFIX] FormEngine: Do not add <br> to readonly textarea content
- Multiline content is displayed in a textarea "as is" by the browser.
There is no need to add <br> tags.
Resolves: #7... - 07:58 Revision 1fd407d0: [BUGFIX] FormEngine: Do not add <br> to readonly textarea content
- Multiline content is displayed in a textarea "as is" by the browser.
There is no need to add <br> tags.
Resolves: #7... - 06:40 Revision e0041459: [TASK] Update Fluid engine dependency to 2.2.0
- This raises the required and locked version of Fluid
to 2.2.0. The dependency is also bumped in the
composer manifest...
2017-01-21
- 19:52 Revision fdae8494: [TASK] styleguide: TCA: Migrate to new group options
- 15:17 Revision 710350ce: [TASK] Use official TYPO3.Icon repository
- The backend icon set has been moved and is now under maintenance of the
TYPO3 GitHub Department. https://github.com/T... - 14:59 Revision e48e4c08: [TASK] Use official TYPO3.Icon repository
- The backend icon set has been moved and is now under maintenance of the
TYPO3 GitHub Department. https://github.com/T...
2017-01-20
- 13:05 Revision dad72d3f: [BUGFIX] Initialize TSFE->config with correct type in PHP 7.1
- The TypoScriptFrontendController->config variable must be of type
array but is initialized with an empty string. Sinc... - 12:49 Revision f39c2f1c: [BUGFIX] Initialize TSFE->config with correct type in PHP 7.1
- The TypoScriptFrontendController->config variable must be of type
array but is initialized with an empty string. Sinc... - 10:08 Revision d827be67: [BUGFIX] Use proper type in LinkAnalyzer to avoid exceptions
- To avoid exceptions, the proper type must be used.
Resolves: #79166
Releases: master
Change-Id: I00a6d65bee8b8807853...
2017-01-19
- 21:26 Revision 2920ac91: [BUGFIX] Restrict l10n fallback to cms extension
- The check for the l10n fallback for the cms extension was too wide, also
covering arbitrary extension names starting ... - 16:59 Revision a26923c9: [TASK] Adjust namespaces of test classes in dynamicReturnTypesMeta.json
- Resolves: #79393
Releases: master
Change-Id: Ic8c0ec41b7421873c4dcbaaa89e483b09ad5608a
Reviewed-on: https://review.ty... - 16:05 Revision 05670e4a: [FOLLOWUP][BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty
- Remove a typo from phpdoc.
Change-Id: If5b45a1124294c80fe3b36f8f1c829f293c9d621
Resolves: #79388
Releases: master
Re... - 14:58 Revision 7efc0924: [BUGFIX] Use reflection information in getGettablePropertyNames
- In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get
all available property names of an object. Cur... - 14:38 Revision 56c20415: [BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty
- The query parser now throws an exception if the given value for an
IN or CONTAINS expression is invalid, instead of s... - 13:30 Revision 7adb722a: [BUGFIX] Use reflection information in getGettablePropertyNames
- In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get
all available property names of an object. Cur... - 11:53 Revision 038e754a: [TASK] styleguide: TCA: Prepare elements_group tabel for multi language handling
- 10:59 Revision 026e2d1c: [TASK] styleguide: TCA: Cleanups and further wizard migrations
- 02:35 Revision b6338046: [BUGFIX] Use BLOB type column for ses_data in be_sessions table
- The unified session handling for frontend and backend requires
identical SQL column types to properly escape the inpu...
2017-01-18
- 18:42 Revision a3ced22a: [BUGFIX] Avoid stripping tags for generating diffs
- Tags must not be stripped away for creating diffs as
those are essential for editors. Otherwise it is not
possible to... - 18:28 Revision a95d491e: [TASK] styleguide: TCA: rtehtmlarea full screen wizard new style
- 16:31 Revision aa17d026: [BUGFIX] Fix minor typo in DateTimePicker.js
- Heven't replaced with haven't
Resolves: #79376
Releases: master,7.6
Change-Id: I85b252514378eb4db1eb63f93d9b746ca332... - 16:31 Revision 4450ae4d: [BUGFIX] Fix minor typo in DateTimePicker.js
- Heven't replaced with haven't
Resolves: #79376
Releases: master,7.6
Change-Id: I85b252514378eb4db1eb63f93d9b746ca332... - 15:44 Revision a1330375: [TASK] styleguide: TCA: Migrate table wizard to new syntax
- 14:26 Revision f5103823: [TASK] styleguide: TCA: Migrate type=text select wizard to valuePicker
- 13:17 Revision 11ff4842: [FEATURE] CLI support for T3D import
- A new CLI command allows to imoprt t3d/xml files for EXT:impexp.
Resolves: #72749
Releases: master
Change-Id: I8775b... - 13:00 Revision 6a788c66: [TASK] Reorder & Rename entries in CType list
- To improve usability the naming and sorting of content element
types for the content element wizard and the select bo... - 12:58 Revision b422a874: [TASK] Use runtime cache for BackendUtility::isRecordLocked
- Instead of using $GLOBALS a runtime cache is used.
Resolves: #79345
Releases: master
Change-Id: I2273051c2d52efff5fa...
2017-01-17
- 21:27 Revision c1d0133e: [TASK] styleguide: TCA: Migrate enable-tab and fixed-font to new settings
- 19:18 Revision d43ebcc7: [TASK] styleguide: TCA: Migrate wizard_add, wizard_list, wizard_add to new syntax
- 19:03 Revision b35b012f: [TASK] styleguide: TCA: Migrate to new 'enableRichtext'
- 17:46 Revision d375170b: Merge pull request https://github.com/TYPO3-CMS/styleguide/issues/79 from MonaMuzaffar/master
- [TASK] styleguide: TCA: remove old none_5 with field fixedRows
- 16:33 Revision b8a1c9c0: [TASK] Deprecate ArrayUtility::inArray()
- Resolves: #79316
Releases: master
Change-Id: Ieb54d51a6d6f15325fc4c1c88ad29c845200c68b
Reviewed-on: https://review.ty... - 15:20 Revision 672c77b7: [TASK] Add linkDetails to the parameters sent in typoLink_PostProc hook
- This can be useful when using the unified referencing syntax.
Resolves: #79349
Releases: master
Change-Id: If822da7... - 14:58 Revision 68cd4342: [TASK] styleguide: TCA: remove old none_5 with field fixedRows and set old none_6 to new none_5
- 14:19 Revision 6f70fe46: [TASK] styleguide: TCA: Old and new style "list wizard" in group_db_1
- 13:12 Revision f13780a1: [TASK] styleguide: TCA: wizard_add new style in group_db_1
- 12:28 Revision bbfa00ee: [TASK] styleguide: TCA: Group add wizard example
- 11:37 Revision c66ced51: [BUGFIX] Fix typo in CacheManager
- By fixing a typo in the CacheManager empty tag arrays
are detected and intercepted.
Resolves: #79236
Releases: maste... - 10:49 Revision 686ef962: [TASK] Cleanup RTE HTMLArea TSconfig processing options
- Some obsolete options are found in the documentation, additionally
the RTE.default.proc.exitHTMLparser_db is not enab... - 09:48 Revision 00677ce4: [!!!][TASK] Prepare richtext configuration
- Configuring a richtext field in TCA with the "defaultExtras"
setting (which was formerly the 5th showitem parameter) ...
2017-01-16
- 21:03 Revision 7e90dbcb: [!!!][TASK] Remove vC checks and deprecate veriCode() method
- Since now all Backend urls have module token in place,
the veriCode is not needed any more.
Thus AbstractUserAuthenti... - 17:42 Revision 02b97c45: [TASK] Streamline assignment of current workspace in DataHandler
- The processing of data structures in DataHandler and RelationHandler
are bound to each other. DataHandler allows to b... - 09:13 Revision e817efa5: [TASK] Include constants in TypoScript cache
- In order to work with available constants in TypoScript in Frontend
the parsed TypoScript constants are included in t...
2017-01-15
- 22:24 Revision 72f81086: [BUGFIX] Extbase: Don't use ORDER BY with COUNT(*) SQL statements
- Databases that adhere to the SQL92 standard and enforce having all
columns that are using in any part of the query be... - 13:05 Revision feba2122: [BUGFIX] Return all packages with PackageManager::getAvailablePackages
- Currently the PackageManager loads installed package information by
default only. This patch adds a new flag to ensur...
2017-01-14
- 23:25 Revision 11d21225: [BUGFIX] Make persistent connections available for Redis cache backend
- The Redis cache backend allows configuration of all connection
setting, except setting persistent connections. This o... - 23:24 Revision 7d0c8bef: [BUGFIX] Make persistent connections available for Redis cache backend
- The Redis cache backend allows configuration of all connection
setting, except setting persistent connections. This o...
2017-01-13
- 20:32 Revision 3135fdc1: [BUGFIX] Prepend, don't append, configured View paths
- Avoids an issue where default View paths would
be added LAST instead of FIRST as is intended.
Change-Id: I00413b40e2... - 20:28 Revision 1c09924f: [BUGFIX] Remove outdated PHPDoc comment
- The described behavior has been removed with TYPO3 7.6;
the variable is treated as a boolean now.
Resolves: #79314
R... - 15:35 Revision 7f0bd2ae: [TASK] List Module: Hide hidden fields in single table rendering
- If a field is hidden by using TsConfig, it should also not be
shown in the single table rendering in the record list.... - 10:50 Revision 389021fa: [BUGFIX] Ext:form - remove class attribute from flashMessages viewhelper
- https://review.typo3.org/#/c/50285/ breaks the ext:form backend modul.
Remove "class" tag attributes from flashMessag... - 09:47 Revision 6c0ae1c0: [!!!][TASK] Move pages.url_scheme to compatibility7
- Adding SSL support on a per-page basis is something that
does not happen very much in 2017 anymore, rather doing this... - 00:50 Revision b236079f: [BUGFIX] Remove range from sorting field
- The range configuration for a sorting field doesn't make any sense
and can lead to unexpected bugs as sorting can be ...
2017-01-12
- 18:49 Revision 2fc9d58b: [!!!][TASK] Remove RTE proc.transformBoldAndItalicTags option
- The option transformBoldAndItalicTags is there to convert
<i> and <b> tags from the DB to <strong> and <em> for the R... - 18:43 Revision 23870ae1: [TASK] Move DatabaseL10nModeUpdate to a row updater
- The new DatabaseL10nModeUpdate install tool upgrade wizard that
migrates row content for old "mergeIfNotBlank" fields... - 16:54 Revision 0f9205d2: [FEATURE] Introduce l10n_source field for tt_content
- A new field which is a ctrl-based field for any TCA table
called "translationSource" set to a DB field name
(used for... - 15:40 Revision aa62a51f: [BUGFIX] Move legacy indexed_search plugin registration
- When moved to EXT:compatibility7 the pi-based Indexed Search
plugin registration was moved to "Configuration/TCA" but... - 15:22 Revision ef447510: Revert "[BUGFIX] Skip main extension repository check in Composer mode"
- This reverts commit e538ed3f154f447ddbaf78785a31c9ab2ee72a17.
We do need the information about the main repository s... - 15:13 Revision 0f1ba66a: [TASK] Always keep <a> instead of <link> tags in RTE transformations
- The RTE uses <a> tags for handling links, a transformation
that replaces <link> tags to <a> tags is updated to use th... - 13:00 Revision bf704f7f: [TASK] styleguide: TCA: group_db_1 edit popup example
- 12:45 Revision a4ab8a89: Revert "[BUGFIX] Skip main extension repository check in Composer mode"
- This reverts commit e538ed3f154f447ddbaf78785a31c9ab2ee72a17.
We do need the information about the main repository s... - 07:48 Revision 437d8978: [BUGFIX] Skip main extension repository check in Composer mode
- Extensions are not installed and updated from the main extension
repository in Composer mode, thus skip this check co... - 07:47 Revision e538ed3f: [BUGFIX] Skip main extension repository check in Composer mode
- Extensions are not installed and updated from the main extension
repository in Composer mode, thus skip this check co...
Also available in: Atom