Project

General

Profile

Activity

From 2021-10-07 to 2021-11-05

2021-11-05

15:53 Revision 0206b833: [TASK] Improve readability of ext:redirects documentation
This commit improves the overall readability of the
ext:redirects documentation.
Releases: master, 10.4
Resolves: #9...
Tom Warwick
15:23 Revision 8d6ae5a4: [TASK] Improve readability of ext:redirects documentation
This commit improves the overall readability of the
ext:redirects documentation.
Releases: master, 10.4
Resolves: #9...
Tom Warwick
12:34 Revision 22702bd6: [TASK] Make HtmlParser PHP8 compatible
Class \TYPO3\CMS\Core\Html\HtmlParser generates a lot of undefined
key warnings when running with PHP 8. It needs to ...
Francois Suter
12:31 Revision 04cd3f0a: [BUGFIX] Translate image dimensions on file replace
Width and height of an image is stored in translatable metadata
records. These properties are extracted by FAL API wh...
André Buchmann
11:54 Revision bdc1bc40: [BUGFIX] Do not HTML encode attributes in Script and Asset VH
ScriptViewHelper and AssetViewHelper do not directly output any tag,
but only pass the arguments to AssetCollector.
...
Helmut Hummel
11:53 Revision 759565d4: [TASK] Streamline composer.json deficit detector
Code for scanning extension folders and populating
information from that, is removed to use already
available API in ...
Helmut Hummel
11:31 Revision d8c9d5ab: [BUGFIX] Do not HTML encode attributes in Script and Asset VH
ScriptViewHelper and AssetViewHelper do not directly output any tag,
but only pass the arguments to AssetCollector.
...
Helmut Hummel
11:22 Revision 685b64b3: [BUGFIX] Translate image dimensions on file replace
Width and height of an image is stored in translatable metadata
records. These properties are extracted by FAL API wh...
André Buchmann
11:04 Revision 9636932c: [BUGFIX] Add missing cookie option on install tool logout
Add the missing samesite cookie option after the logout from the
install tool which leads to an error in the browser ...
Simon Gilli
10:20 Revision a1074fbe: [BUGFIX] Fix EditableRestriction for linkvalidator
EditableRestriction in linkvalidator checks which fields are editable
Doing so, it also considers the allow / deny ty...
Sybille Peters
10:11 Revision 70ce8871: [BUGFIX] Initialize selected crop variant on modal open
In the cropper modal the initial aspect ratio
is not respected.
This has been fixed by triggering the update method
...
Jochen Roth
10:04 Revision 0c292e8f: [BUGFIX] Fix EditableRestriction for linkvalidator
EditableRestriction in linkvalidator checks which fields are editable
Doing so, it also considers the allow / deny ty...
Sybille Peters
09:34 Revision a15953b4: [BUGFIX] Suppress E_DEPRECATED for strftime() and gmstrftime()
PHP functions strftime() and gmstrftime() have been deprecated in
PHP 8.1 and will be removed in PHP 9.0. Currently, ...
Stefan Bürk
08:38 Revision 7b94fb38: [DOCS] Minor fixes in redirects docs
Resolves: #95865
Related: #95816
Releases: master, 10.4
Change-Id: Ic9fecfbe07abf98af8d9b8f73d54f3482643c372
Reviewed...
Sybille Peters
08:04 Revision 6c15f2c5: [DOCS] Minor fixes in redirects docs
Resolves: #95865
Related: #95816
Releases: master, 10.4
Change-Id: Ic9fecfbe07abf98af8d9b8f73d54f3482643c372
Reviewed...
Sybille Peters
05:35 Revision 7c0dac58: [BUGFIX] Ensure form finisher dependencies can get injected
With #94317 the instantiation of form finishers has been changed by
replacing `ObjectManager::get()` in favor of
`Gen...
Elias Häußler

2021-11-04

16:31 Revision bf13e4ef: [BUGFIX] Restore SummaryPage path for form single value access
Resolves: #95868
Releases: master, 10.4
Change-Id: Iffc8ed042f4990b132c28a0ff7b4d80ffca530ac
Reviewed-on: https://rev...
Mathias Brodala
16:31 Revision d2d8ee23: [TASK] Remove unnecessary assertions from tests
Resolves: #95197
Releases: master
Change-Id: I39683431de4cfbc3f6f84b8f096c079e978e5d8f
Reviewed-on: https://review.ty...
Wouter Wolters
16:22 Revision 1b6f7545: [BUGFIX] Fix #modulemenu collapsed state on Firefox
This fixes cut modulemenu icons on Firefox when scrollbars are shown.
It has been fixed before, but since then seemin...
Jonas Eberle
16:15 Revision 29104e35: [BUGFIX] Restore SummaryPage path for form single value access
Resolves: #95868
Releases: master, 10.4
Change-Id: Iffc8ed042f4990b132c28a0ff7b4d80ffca530ac
Reviewed-on: https://rev...
Mathias Brodala
16:13 Revision 448d081c: [TASK] Fix warning in GridColumnClassAutoConfigurationViewHelper
Resolves: #95871
Related: #95859
Releases: master
Change-Id: I0982c2289e00c7eaecfaa0dab89d184e09148f0f
Reviewed-on: h...
Nikita Hovratov
16:11 Revision 5d7593b4: [TASK] Use direct method invocation instead of calling it static
In the process, some tests calling tests (which is bad style) have
been disentangled by calling the code explicit, ra...
Wouter Wolters
15:05 Revision b3ee53cd: [BUGFIX] Enriched relation values in rootline do not consider overlays
The overlay handling (localization and workspaces) of relation values
resolved in the RootlineUtility do only conside...
Oliver Hader
14:20 Revision f6c3f6ce: [TASK] Set actions to protected in Dashboard
Currently all "*Action" are set to public which isn't
neccessary because the handleRequest() dispatches
these actions...
Jochen Roth
14:18 Revision 00c7a5ea: [BUGFIX] Ensure view initialisation in FluidEmail
FluidEmail view object is null after deserialisation
causing an error when flushing the file spool queue.
Ensure the ...
Anja Leichsenring
14:18 Revision c47cd42a: [BUGFIX] Update feature toggles state at once
When updating feature toggles, the corresponding method
iterates over all feature toggles and checks if those
state c...
Davide Alghi
13:55 Revision 7c238eea: [BUGFIX] Ensure view initialisation in FluidEmail
FluidEmail view object is null after deserialisation
causing an error when flushing the file spool queue.
Ensure the ...
Anja Leichsenring
13:38 Revision 7523178b: [BUGFIX] Do not show empty colPos message for special unused column
Columns, not having a colPos defined, are considered as
inaccessible. A event listener therefore enriches such
column...
Oliver Bartsch
13:35 Revision 9758a7a0: [BUGFIX] Document proper paths for form single value access
Resolves: #95868
Releases: master, 10.4
Change-Id: I443ba87dd97e1efacbaf441a1263dd47ec1e1aa2
Reviewed-on: https://rev...
Mathias Brodala
13:23 Revision d0d568a6: [BUGFIX] Document proper paths for form single value access
Resolves: #95868
Releases: master, 10.4
Change-Id: I443ba87dd97e1efacbaf441a1263dd47ec1e1aa2
Reviewed-on: https://rev...
Mathias Brodala
13:11 Revision 1cfc588b: [BUGFIX] Use search_field value from session again
search_field value from session is never used again anymore, fixed that regression
Resolves: #94898
Releases: 10.4
C...
Martin Neumann
13:05 Revision 5f4142b8: [BUGFIX] Fix redirect on failed login when redirectMode is unset
This commit adds the missing additional check that a redirect happens
only on a successful login or logout, even if p...
Volker Diels-Grabsch
12:20 Revision 7cf2035c: [BUGFIX] Fix overlapping FormEngine fields
Because of normal selectSingle fields having the css property
"width: auto", very long text forces those fields to sp...
Nikita Hovratov
11:29 Revision 36e8427f: [TASK] Remove default values in TCA of core fields
This removes the default values for:
- minitems = 0 in general
- size = 1 with renderType = selectSingle
minitems =...
Nikita Hovratov
11:18 Revision 283c5b73: [TASK] Optimize AC tests to use dataProvider
Currently some acceptance tests do not use a
data provider as intended.
These tests have been optimized to use the
d...
Jochen Roth
11:03 Revision 46318d9a: [TASK] Enhance deprecation message for table pages_language_overlay
Regardless of existance of table pages_langugage_overlay in database,
a deprecation message for TCA migration is logg...
Anja Leichsenring
10:59 Revision fb65ea08: [BUGFIX] Ensure indexed search stats are only written when not empty
This change fixes a regression introduced with #92993 when
removing personalized search statistics.
A simple search ...
Benni Mack
10:57 Revision 16839fac: [BUGFIX] Replace filter_var(FILTER_SANITIZE_STRING) in RequestBuilder
Sanitize filter 'FILTER_SANITIZE_STRING' has been deprecated
since PHP 8.1 and will be removed in PHP 9.
ext:extbase...
Stefan Bürk
09:56 Revision 072a7c49: [TASK] Set word-wrap to avoid a horizontal scrollbar in modal
A long database name currently causes the
modal to show scroll bars.
This has been fixed by setting word-wrap
for li...
Jochen Roth
07:51 Revision ef62556d: [BUGFIX] Show errors when failing to write site configuration
This patch adds an error if the site configuration file cannot be
written or deleted.
Exceptions thrown while failin...
Stephan Großberndt
07:21 Revision 636b3d83: [BUGFIX] Fix cache clearing when publishing from workspace
With #89555 cache clearing has been disabled
if the user is currently in a workspace.
This is fine in most cases, bu...
Benjamin Franzke
06:43 Revision e9dae46a: [BUGFIX] Fix cache clearing when publishing from workspace
With #89555 cache clearing has been disabled
if the user is currently in a workspace.
This is fine in most cases, bu...
Benjamin Franzke

2021-11-03

21:24 Revision c3c3da21: [BUGFIX] Fix problem of disabled buttons in pagination
Due to improvements for accessibility, the contrast between
color and background color was increased for disabled but...
Sybille Peters
21:22 Revision ff70e5e9: [BUGFIX] Keep pagination in redirect module if editing record
Remember the current page in the redirects module if the pagination
is used - just as filter values.
Resolves: #9578...
Georg Ringer
21:11 Revision 5bd58ebf: [BUGFIX] Use callout component on install tool login page
The Install Tool Login page shows informational boxes like the one
that by default the Install Tool password is the o...
Marcin Sągol
21:04 Revision ff10a66f: [BUGFIX] Avoid accessing FAL compatibility layer
When accessing static files via FAL API,
the compatibility layer (storage 0) kicks in.
This compatibility layer has m...
Helmut Hummel
20:37 Revision 276f73e5: [BUGFIX] Avoid calling quote with non-string value in QueryGenerator
ext:lowlevel QueryGenerator calls quote(...) with non string value as
first parameter which ends in a E_DEPRECATED as...
Stefan Bürk
20:26 Revision 22fe7f95: [BUGFIX] Sanitize calling htmlspecialchars(...) in FormViewHelper
htmlspecialchars(...) expects that first argument is a string,
otherwise triggering E_DEPRECATED.
This patch adds a ...
Stefan Bürk
20:18 Revision 22eef509: [TASK] AC test Environment -> Image Processing cards and its modals
Added acceptance test for all missing cards in
"Environment -> Image Processing".
to see headline, buttons and expect...
Jochen Roth
19:45 Revision c100b68a: [BUGFIX] Use CodeMirror auto sizing feature correctly
To use CodeMirror's auto sizing feature, we need
to set the style attribute of the wrapper element
to "auto", instead...
Nikita Hovratov
19:02 Revision 71e54dec: [BUGFIX] Extend condition for isOnSymmetricSide
Instead of holding only the uid as a plain value the given databaseRow
array of the symmetric_field can hold an array...
Tim Karliczek
17:32 Revision ac2e3264: [BUGFIX] Fix Environment overview with using SQLite
This change allows for the db connection parameters 'user',
'host' and 'port' to be empty, as it happens when using S...
Maik Beckmann
17:15 Revision ed782614: [BUGFIX] Restore inconsistent language highlighting
The page module displays a flash message for page
translations with inconsistent ("mixed mode") content
elements. The...
Oliver Bartsch
17:14 Revision 05bf4c86: [BUGFIX] Delete orphans that are deleted or hidden
All restrictions are removed from the query builder that
fetches the orphan records.
A seperate query builder instan...
Alexander Stehlik
17:01 Revision 914d8165: [BUGFIX] Fix various context menu visibility issues
The context menu skeleton is partially visible for a very short time,
before its items are rendered and event listene...
Andreas Fernandez
16:50 Revision 0ccee3fe: [DOCS] Create extension manual for t3editor
Resolves: #95836
Releases: master
Change-Id: Id7667dcfc5b6e16662a1087c7d5591be32510c64
Reviewed-on: https://review.ty...
Lina Wolf
16:31 Revision 3ac8d245: [TASK] Streamline page tree delete modal
The page tree delete modal labels have been
changed to align with all other delete modals.
Resolves: #95817
Related:...
Jochen Roth
16:10 Revision 4d971a54: [BUGFIX] Fix undefined key warning in EXT:form with PHP8
When using a form witch contains a fieldset element,
you will have a PHP warning:
Undefined array key "xs" in GridCol...
Florian Rival
15:41 Revision 129c8e89: [DOCS] Documentation for EXT:redirects
Resolves: #88570
Releases: master, 10.4
Change-Id: Iaf39f5d2b3d8509f405162d25b1de73d71e27c5d
Reviewed-on: https://rev...
Sybille Peters
15:32 Revision 3e9c656f: [BUGFIX] Show relational indices issues in EXT:lowlevel again
This change re-adds the output on "DB Relations"
of the "DB Check" module by having proper (PHP 8) related
checks on ...
Benni Mack
15:25 Revision 58b9d00b: [BUGFIX] Delete orphans that are deleted or hidden
All restrictions are removed from the query builder that
fetches the orphan records.
A seperate query builder instan...
Alexander Stehlik
15:19 Revision 4f5bd63c: [TASK] Use dedicated JavaScript LoginRefresh.initialize(options)
Instead overriding class member variables externally, existing
initialize() method has been extended to support optio...
Oliver Hader
15:17 Revision ca065026: [TASK] Normalize JavaScript initialization of workspaces preview
Ensures workspaces PreviewController uses dedicated method to declare
client-side settings PageRenderer::addInlineSet...
Oliver Hader
15:03 Revision e407449a: [TASK] Use dedicated JavaScript initialization for form manager
To avoid having nested require.js inline JavaScript, initialization
of the form manager uses a dedicated helper modul...
Oliver Hader
14:11 Revision 530eef76: [DOCS] Add README.rst as "about" file to system extensions
Fix links to system extension in composer.json documentation where it
was still missing. Remove reference to docs_ind...
Lina Wolf
13:53 Revision d03867a4: [TASK] Add acceptance test for recycler module
An acceptance test for recycler has been added to
ensure the modules works as expected.
This acceptance test covers ...
Jochen Roth
13:04 Revision 75b261dc: [TASK] Avoid using public property ModuleLoader::$modules
Changes read-access to modules from `ModuleLoader::$modules`
to `ModuleLoader::getModules()`.
Resolves: #95851
Relea...
Oliver Hader
12:40 Revision 288e88db: [DOCS] Documentation for EXT:redirects
Resolves: #88570
Releases: master, 10.4
Change-Id: Iaf39f5d2b3d8509f405162d25b1de73d71e27c5d
Reviewed-on: https://rev...
Sybille Peters
12:25 Revision 1dd425df: [BUGFIX] Prevent array to string conversion in IconFactory
When mapping a 'pages' row to an icon, the 'module' field
might be both an array or a string. Reloading the page tree...
Robert Kärner
11:59 Revision 147b9272: [BUGFIX] Fix IRRE related undefined key warnings
Two occurrences in the DataHandler and another in
InlineRecordContainer needed fallbacks for array access.
Resolves:...
Robert Kärner
11:55 Revision 695c6ad1: [BUGFIX] Fix rendering of specific format body in FluidEmail
Previously it was not possible to trigger the email
body generation for a specific format, since FluidEmail
only impl...
Oliver Bartsch
11:28 Revision fb19a0cc: [TASK] Expose all properties of JavaScriptModuleInstruction as JSON
Resolves: #95847
Releases: master
Change-Id: Ia4bbb85c473fb5c6a9ca0461765756a014cc3492
Reviewed-on: https://review.ty...
Oliver Hader
11:15 Revision fbbdfe7b: [TASK] Upgrade PHPStan to latest version 0.12.99
This is the latest version before 1.0.0 release.
PHPStan 1.0 is going to be PHPStan 0.12.99 + bleeding edge + BC brea...
Wouter Wolters

2021-11-02

13:05 Revision 94682589: [BUGFIX] Avoid calling str_contains(null) in DataHandler
Method convNumEntityToByteValue() has been removed through #95789,
thus the one place it was called was removed also....
Stefan Bürk
13:05 Revision 854669bd: [BUGFIX] Sanitize calling htmlspecialchars(...) in TextareaViewHelper
htmlspecialchars(...) expects that first argument is a string,
otherwise triggering E_DEPRECATED.
This patch adds a ...
Stefan Bürk
13:05 Revision 55c5f66b: [BUGFIX] Sanitize calling htmlspecialchars(...) in SelectViewHelper
htmlspecialchars(...) expects that first argument is a string,
otherwise triggering E_DEPRECATED.
This patch adds a ...
Stefan Bürk
08:59 Revision 586d475b: [BUGFIX] Clean up clipboard before using it in ContextMenu
Some item providers (context menu) access
clipboard information. Since the clipboard was
previously not properly init...
Oliver Bartsch
08:51 Revision 87283af3: [TASK] Set TYPO3 version to 11.5.3-dev
Change-Id: I4572a09db3db194a31ff3c1fd40a08e0b6c7ca23
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/720...
Benni Mack
08:24 Revision 96a71bec: [RELEASE] Release of TYPO3 11.5.2
Change-Id: Ia1abfc52ec70cb81d005d41158c715a585061554
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/720...
Benni Mack
08:10 Revision e7427f83: [BUGFIX] Add missing file extensions of language files
In some places the file extensions of language files are missing and
properly added with this patch.
Resolves: #9584...
Simon Gilli
08:00 Revision 47c4a2f0: [BUGFIX] Keep pagination in redirect module if editing record
Remember the current page in the redirects module if the pagination
is used - just as filter values.
Resolves: #9578...
Georg Ringer

2021-11-01

17:58 Revision 1fabd9a8: [TASK] Update jQuery
Albeit we're removing jQuery step by step, we shall provide updated libs,
which takes effect for jquery.
Executed co...
Andreas Fernandez
12:07 Revision 4362e632: [DOCS] Add link to 11.5.x changelog
Resolves: #95837
Releases: master
Change-Id: I0b7169ec25a7f17ded6735b612ee51c25aa39d4d
Reviewed-on: https://review.ty...
Chris Müller
12:05 Revision 7485a170: [TASK] Refactor localization tests
The XliffParserTest are refactored using a DataProvider which also
eliminates duplicate test code.
The override test...
Simon Gilli
10:56 Revision 29693b8d: [BUGFIX] Don't throw exceptions for private paths
Instead of throwing an exception when resolving
the path to private resources, a deprecation message
is now shown.
R...
Helmut Hummel
10:29 Revision f8927810: [BUGFIX] Fix PHP 8 warnings in FlexFormElementContainer
Resolves: #95804
Releases: master
Change-Id: I884741a4ecb7fdbc0cabd96f4975ea6629726d31
Reviewed-on: https://review.ty...
Nikita Hovratov
10:19 Revision c1cb0ced: [BUGFIX] Undefined array key in install tool
Fixes two undefined array keys in the install system extension's
UpgradeWizardsService.php that cause errors in PHP 8...
Mathias Bolt Lesniak

2021-10-29

13:17 Revision 96e0e384: [BUGFIX] Ensure regexp capture group works with relative target
RedirectService has been using LinkHandler to retrieve
the targeturl, thus supporting all TYPO3 has to offer,
like t3...
Stefan Bürk
08:10 Revision 392edf84: [BUGFIX] Ensure regexp capture group works with relative target
RedirectService has been using LinkHandler to retrieve
the targeturl, thus supporting all TYPO3 has to offer,
like t3...
Stefan Bürk

2021-10-28

10:26 Revision 80ddf137: [TASK] Add missing whitespace after assign operator
Resolves: #95809
Releases: master
Change-Id: I7e5e9edc404ed8131461d112abee4c1cedb2ab1b
Reviewed-on: https://review.ty...
Nikita Hovratov

2021-10-27

19:00 Revision a11869c0: [BUGFIX] Fix warning in BackendUserAuthentication
Check if filemounts are available before accessing those.
Resolves: #95780
Releases: master
Change-Id: I0f475a7add63...
Georg Ringer
19:00 Revision 0770646d: [DOCS] Fix typo in deprecation note
Resolves: #95803
Releases: master
Change-Id: I3c69e40bac77c46a5c2bd0d5bf68a20f36a037a0
Reviewed-on: https://review.ty...
Chris Müller
18:59 Revision 12ae143f: [BUGFIX] Prepare doctrine facades towards PHP 8.1
\PDO::quote() is picky about the type argument
in PHP 8.1. doctrine/dbal partially works around
that and will improve...
Christian Kuhn
09:57 Revision 29651da7: [BUGFIX] Harden types in ImageContentObject linkWrap()
Protected method linkWrap() should only be called
with string arguments - they are for instance fed
to explode(). Ins...
Christian Kuhn

2021-10-26

21:44 Revision f6544df9: [BUGFIX] Fix warning when query result is written to csv file
The function fputcsv gets an enclosure as third parameter. Providing an
empty string as enclosure leads to following ...
Florian Sommer
21:36 Revision e00c3173: [BUGFIX] Catch and log Exception in image size detection
When the mime type of a file can not be correctly determined
by ImageMagick when detecting image sizes, fail silently...
Alexander Stehlik
21:32 Revision 46554c1e: [BUGFIX] Avoid warning in ContentObjectRenderer
getData() may emit E_WARNING accessing $tsfe->page and
$config. Sanitize that by null coalescing to empty
string.
Re...
Christoph Lehmann
21:31 Revision 7e8ea60b: [BUGFIX] Fix PHP warnings in ext:lowlevel DB Check
This prevents exceptions for missing array keys when using
the query generator for the DB Check backend module.
Reso...
Guido Schmechel
21:30 Revision 90e8e66d: [BUGFIX] Explicit string cast for string expecting functions
PHP 8.1 in non strict_types context emits E_DEPRECATED
with various functions that expect strings but are
called givi...
Christian Kuhn
21:30 Revision 7ad00012: [BUGFIX] Avoid broken mock return in ActionControllerTest
ActionControllerTest mocks a view to test things. The subject
calls renderSection() on that mock. renderSection() mus...
Stefan Bürk
21:29 Revision 1a30b82b: [TASK] Add " around ignore in .stylelintrc
.stylelintrc is a json-like config and needs
to quote keys.
Releases: master
Resolves: #95785
Change-Id: I626e956af5...
Kim Christiansen
21:28 Revision 63a387ca: [BUGFIX] Fix warning when query result is written to csv file
The function fputcsv gets an enclosure as third parameter. Providing an
empty string as enclosure leads to following ...
Florian Sommer
21:18 Revision 13990500: [BUGFIX] Sanitize unserialize() in ProcessedFile
Table sys_file_processedfile field configuration is a
blob. It usually contains a serialized array with
processing in...
Christian Kuhn
20:31 Revision 972d623d: [BUGFIX] Drop a strange internal DataHandler method
That's a seldom gem.
Method convNumEntityToByteValue() in DataHandler
is *seriously* strange. It exists since very e...
Christian Kuhn
18:46 Revision 177b087f: [BUGFIX] Avoid calling trim(null) in PageRenderer
PageRender sanitizes array values in two methods, using
array walk with trim(). These values can be other
types then ...
Stefan Bürk
18:42 Revision 8e48aff7: [BUGFIX] Avoid coalescence to null for string expecting functions
Various functions expect string arguments and emit
E_DEPRECATED with PHP 8.1 in non strict_types=1
calls. The patch a...
Christian Kuhn
11:51 Revision 4a87bd2e: [BUGFIX] Properly return path relative to public dir in FilePathSanitizer
The assumption for FilePathSanitizer::sanitize is to return file names
relative to the public directory of TYPO3.
Th...
Florian Rival
11:29 Revision 3b7a862f: [BUGFIX] Fix warning in NewContentElementController
Resolves: #95778
Releases: master
Change-Id: I764dc299cb192e4ebbcb00b21553f474355c55cb
Reviewed-on: https://review.ty...
Nikita Hovratov
08:09 Revision 336a91ef: [BUGFIX] Enforce $GLOBALS['LANG']->sL() returns string
Calling LanguageService->sL() should *always* return
a string, even if it's empty. The patch enforces this.
This rev...
Christian Kuhn

2021-10-25

20:19 Revision 497f313e: [BUGFIX] Avoid trim(null) in ContentObjectRenderer->stdWrap_*()
Calling trim() with something else than a string
emits a E_DEPRECATED error with PHP 8.1.
Some ContentObjectRenderer-...
Christian Kuhn
20:19 Revision 41af981c: [BUGFIX] Avoid str_replace(..., null) in ContentObjectRenderer
Calling str_replace() with second argument non-string is
deprecated as of PHP 8.1. Sanitize stdWrap_brTag() in
Conten...
Christian Kuhn
20:18 Revision 9d559bd5: [BUGFIX] Avoid str_replace(..., null) in AbstractMenuContentObject
PHP 8.1 emits E_DEPRECATED if second argument to
str_replace() is null. Adapt a null coalescence
and add a cast to st...
Christian Kuhn
18:12 Revision 8cc1e210: [BUGFIX] Avoid deprecated FILTER_SANITIZE_STRING in TextValidator
The filter_var() filter FILTER_SANITIZE_STRING is
deprecated as of PHP 8.1.
Extbase TextValidator uses it. Goal of t...
Christian Kuhn
18:03 Revision 3e27e566: [BUGFIX] Let GeneralUtility::getIndpEnv() return string more often
We unfortunately still didn't manage to drop remaining
usages of GeneralUtility::getIndpEnv() and deprecate
the metho...
Christian Kuhn
18:00 Revision cf1a8900: [BUGFIX] Avoid incomplete mock in FluidTemplateContentObjectTest
FluidTemplateContentObject calls:
$headerAssets = $this->view->renderSection(...);
if (!empty(trim($headerAssets))) {...
Christian Kuhn
17:53 Revision c2f7e056: [BUGFIX] Avoid implicit conversion to int in StringUtility
StringUtility::multibyteStringPad() does a happy division
feeding str_repeat() to evenly pad on left and right side.
...
Christian Kuhn
17:50 Revision cbc0b420: [BUGFIX] Avoid calling strlen(null) in FrontendUserAuthentication
GeneralUtility::_POST($this->formfield_permanent) returns
null if that field is not set in $_POST. Feeding null
to st...
Christian Kuhn
14:54 Revision c22da2db: [BUGFIX] Avoid error when loading title of TCA table in New Record Controller
This change uses the PackageManager API to fetch the
extension key title, and also solves a small issue when
the TCA ...
Benni Mack
13:57 Revision 8e2dd7c9: [DOCS] Document changed behavior with Composer and extensions
With #94996 the behavior for composer based installations changed:
- All extensions are always active
- PackageState...
Georg Ringer
13:05 Revision 7cea7737: [BUGFIX] Update composer dev dependencies to min required versions
phpunit released new versions for 8.5.x and 9.5.x, which
no longer automatically throw exception for user deprecation...
Stefan Bürk
12:30 Revision 2db46283: [TASK] Improve error messages for linkvalidator
- Error code 500 used to be displayed as the generic "Network error
/ invalid domain" which was misleading
- Libcur...
Sybille Peters

2021-10-24

17:42 Revision 4ce01c53: [BUGFIX] Deprecation free interfaces in FinisherVariableProvider
Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in FinisherVariabl...
Stefan Bürk
17:22 Revision afac6ed0: [BUGFIX] Deprecation free \Countable in FileCollector
Set int return type for @internal class FileCollector
to satisfy PHP 8.1 strict return on SPL classes.
Resolves: #95...
Stefan Bürk
17:16 Revision a2bf18f5: [BUGFIX] Deprecation free \ArrayAccess in FormRuntime
Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in ext:form FormRu...
Stefan Bürk
17:11 Revision 97623be2: [BUGFIX] Suppress deprecation in EmptyFileSearchResult
Since PHP 8.1 The Countable interface has tentative
return types. This means mismatching return types
trigger depreca...
Nikita Hovratov
17:04 Revision 0c537280: [BUGFIX] Deprecation free \ArrayAccess in LinkResult
Set #[\ReturnTypeWillChange] and corresponding @todo comments
to methods of implemented interfaces in ext:frontend Li...
Stefan Bürk
16:46 Revision 2e0ba1b9: [BUGFIX] Deprecation free \Countable in AbstractCompositeValidator
Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in AbstractComposi...
Stefan Bürk
16:45 Revision 7100961d: [BUGFIX] Deprecation free \ArrayAccess in ArrayAccessClass
Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in ext:extbase Arr...
Stefan Bürk
15:58 Revision 6c7eabdd: [BUGFIX] Use correct return type annotations in validation results
Three methods in Extbase's Result are now
annotated with the correct return type to
make PHPStan happy when they are ...
Robert Kärner
15:46 Revision fcf33351: [BUGFIX] Deprecation free \ArrayAccess and \Iterator in QueryResult
Set #[\ReturnTypeWillChange] and corresponding @todo comments to
methods of implemented interfaces in ext:extbase Que...
Stefan Bürk
15:40 Revision 5db9be7a: [BUGFIX] Use correct return type annotations in validation results
Three methods in Extbase's Result are now
annotated with the correct return type to
make PHPStan happy when they are ...
Robert Kärner
15:37 Revision edd2ef46: [TASK] Streamline log_data fetching
This change now uses allowed_classes=false on all
calls of unserialize() for sys_log.log_data which
we did not have b...
Benni Mack

2021-10-23

22:41 Revision bf903bb6: [BUGFIX] Avoid invalid setup in Typo3StatusTest
Let getLL() return string in tests to avoid a
"sprintf(): Passing null to parameter #1" from
Typo3Status test. Saniti...
Christian Kuhn
22:40 Revision 7d63602e: [BUGFIX] Deprecation free \Iterator in LazyLoadingProxy
PHP 8.1 added concrete return types to internal
interfaces, classes and methods which triggers
deprecation messages, ...
Stefan Bürk
22:10 Revision 9b1849ba: [BUGFIX] Deprecation free ArrayObject in extbase Controller/Arguments
ext:extbase Controller/Arguments extends ArrayObject
which implements several interfaces. Since PHP 8.1
added concret...
Stefan Bürk
22:00 Revision 28c3cacf: [BUGFIX] Avoid passing null as parameter to trim()
To make units test notice free in #85092 a wrong
fallback for array access has been used.
Fallback to null and passi...
Stefan Bürk
21:30 Revision 2baa62ab: [BUGFIX] Use lolli42/finediff over cogpowered/finediff
finediff is used in various core places to render
a HTML "diff" view of two strings. The library didn't
see changes s...
Christian Kuhn
21:29 Revision 526f8a9f: [BUGFIX] Avoid passing null as parameter to trim()
To make units test notice free in #85092 a wrong
fallback for array access has been used.
Fallback to null and passi...
Stefan Bürk
21:29 Revision ead6a2ba: [BUGFIX] Ensure type inheritance compatibility for RouteResultInterface
PageArguments and SiteRouteResult implementing the
\ArrayAccess interface indirectly through implementing
RouteResult...
Stefan Bürk
20:44 Revision 2d60bff0: [BUGFIX] Avoid deprecation message in MetaDataAspect
MetaDataAspect implements multiple interfaces and has return type hints
that match the interfaces. Except for the off...
Stefan Bürk
20:42 Revision ed26bba2: [BUGFIX] Avoid incomplete setup for WebProcessorTest
WebProcessorTests uses GeneralUtillity::getIndpEnv()
directly or indirectly, thus triggering deprecation
message on P...
Stefan Bürk
20:17 Revision 3d0776f2: [BUGFIX] Avoid passing null parameter in SchemaColumnDefinitionListener
SchemaColumnDefinitionListener instantiates a new Column class and
passes the column name retrieved from an array. If...
Stefan Bürk
18:50 Revision a255ae77: [BUGFIX] Avoid incomplete setup in FileHandlingUtilityTest
Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for for...
Stefan Bürk
18:38 Revision 057d9f81: [BUGFIX] Avoid incomplete setup in ExtensionStatusTest
Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for for...
Stefan Bürk
18:36 Revision 19488f74: [BUGFIX] Deprecation free ArrayObject usage in backend tree
Classes TreeeNodeCollection and SortedTreeNodeCollection
extends ArrayObject and override some methods.
PHP 8.1 adde...
Stefan Bürk
18:26 Revision d41488cd: [BUGFIX] Avoid passing null to str_contains in TypoScript Parser
Releases: master
Resolves: #95646
Change-Id: I86d4f73ed49d46a20d20af4f5d10075c86b633dc
Reviewed-on: https://review.ty...
Stephan Sellner
18:21 Revision d64dce23: [BUGFIX] Add PHP 8.1 compatibility in AbstractRecordCollection
Since PHP 8.1, most internal classes are updated
with tentative return types. This will be enforced
with 9.0.
It mea...
Stefan Bürk
18:16 Revision 6c074475: [BUGFIX] Better redirects from sys_domain in redirects upgrade wizard
Feeding a sys_domain url to parse_url('example.com/bar')
gives ['path' => 'example.com/bar'], but we need something
l...
Mohsin Khan
14:56 Revision 5e33da68: [BUGFIX] Deprecation free Serializable usage in backend Tree
Classes TreeNode and TreeNodeCollection implement
deprecated \Serializable either directly, or indirectly
via \ArrayO...
Christian Kuhn
14:55 Revision ade5f9a9: [BUGFIX] Update EXT:blog_example TCA and ext_tables.php
* Adapted the TCA to work with v11.5.
* Cleaned up ext_tables.php
Resolves: #95724
Releases: master
Change-Id: Icd2c...
Jochen Roth

2021-10-22

14:49 Revision c18b9860: [TASK] Remove Web>Modules from TSconfig list
The select list in the module "Info > Page TSconfig" contained
"Module Web>Modules" in the select list. This refers t...
Sybille Peters
06:39 Revision 7bfe6f76: [BUGFIX] Make file paths absolute in GIFBUILDER
In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inc...
Simon Schaufelberger

2021-10-21

15:44 Revision ad7227df: [BUGFIX] Properly encode JSON when forwarding to RequireJS
When forwarding configuration as JSON encoded data when loading
RequireJS modules in form engine, escape sequences ne...
Oliver Hader
15:12 Revision 48e4e495: [BUGFIX] Make file paths absolute in GIFBUILDER
In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inc...
Simon Schaufelberger
13:44 Revision 40e974a1: [BUGFIX] Consider language in redirects:checkintegrity
The ext:redirects integrity check was implemented
without considering site language host and prefix for
the integrity...
Sybille Peters
12:27 Revision 30984658: [TASK] Add extension title to meta data and use it
Instead of reading the composer.json / ext_emconf.php
of extensions at runtime just to retrieve the extension title,
...
Helmut Hummel
11:45 Revision a167909c: [BUGFIX] Avoid using HTML sanitizer in reports module
Reports generated by custom data providers might contain
specific HTML markup (including JavaScript, SVG and styles)....
Oliver Hader
10:35 Revision 476e011e: [BUGFIX] Consider language dependencies in stdwrap.lang
$GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['dependencies']
keeps a list of language fallbacks for ...
Christoph Lehmann
10:26 Revision 1f4ab125: [BUGFIX] Consider language in redirects:checkintegrity
The ext:redirects integrity check was implemented
without considering site language host and prefix for
the integrity...
Sybille Peters
10:14 Revision 60b59034: [BUGFIX] Consider language dependencies in stdwrap.lang
$GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['dependencies']
keeps a list of language fallbacks for ...
Christoph Lehmann
05:44 Revision d4660f89: [BUGFIX] Hide non extension types from Extension lists
To avoid confusion for inexperienced TYPO3 Composer users
and for the time being, Composer packages that are not
of t...
Helmut Hummel

2021-10-20

17:39 Revision 4c36a1a0: [BUGFIX] Remove mssql quotes in QueryHelper::parseJoin()
Recently adding quote syntax to typoscript
definitions has been added through #94715,
which fails in nightly on mssql...
Stefan Bürk
14:11 Revision b671caf4: Revert "[TASK] Deprecation free Serializable usage in ObjectStorage"
This reverts commit c7c47956c054ef68e2847b06f15cf69b4025bc2c.
The patch did not make sense: A class that has methods...
Christian Kuhn
08:00 Revision 1217cea8: [TASK] Add package type to meta data and use that to resolve type
Instead of reading the composer.json of packages on runtime,
use the existing meta data API to store and retrieve thi...
Helmut Hummel

2021-10-19

23:50 Revision c7c47956: [TASK] Deprecation free Serializable usage in ObjectStorage
extbase ObjectStorage always had a serialize() and
unserialize(), even though they always just threw
exceptions. This...
Christian Kuhn
21:40 Revision 358be77b: [BUGFIX] Avoid deprecated methods in DebuggerUtility
Extbase DebuggerUtility uses reflection to determine
information that should be rendered as debug output
in 'renderCo...
Stefan Bürk
21:38 Revision de88d16d: [BUGFIX] Avoid Serializable interface deprecation in extbase tests
\Serializable interface has been deprecated with
PHP 7.4 and the introduction of __serialize() and
__unserialize().
...
Christian Kuhn
20:24 Revision 338910cc: [TASK] Improve exception message for failed url generation
Changing the exception message can help developers to find the issue
faster. The previous message "The page 123 had n...
Georg Ringer
20:02 Revision 94c32400: [BUGFIX] Split ContainerTest fixtures per class
Having more than one class per file is discouraged
and leads to issues with class-alias-loader
if non-namespaced clas...
Christian Kuhn
18:25 Revision 0636d9ae: [TASK] Disable downloading extension archive in composer mode
Disables the possibility to export extension sources as archive
via extension manager when using Composer-based setup...
Oliver Hader
16:28 Revision 589df09c: [TASK] Do not cache phpunit results
phpunit has a default-enabled feature to write test
result to a cache file. phpunit however has no option
to only run...
Christian Kuhn
16:24 Revision 0221f472: [BUGFIX] Use correct selector for caret animation in EXT:form
Currently the expanded tree does not reflect the state
(collapsed/expanded).
This has been fixed by using the correc...
Jochen Roth
16:15 Revision 271de6f6: [TASK] styleguide: Have cacheResult="false" in phpunit xml boilerplate files
Good practice.
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/71890
Christian Kuhn
15:17 Revision f2a3f4e0: [BUGFIX] Consider table name on retrieving extension key
The NewRecordController previously relied on a record
title being a locallang reference. This was used to
determine t...
Oliver Bartsch
14:40 Revision 95bd2ab6: [BUGFIX] Use the same identifier in configuration and wizard class
The current implementation makes it possible to have different wizard
identifiers defined in the class and in the con...
Helmut Hummel
14:31 Revision 9f902c21: [BUGFIX] Ensure cyrilic work as regexp redirects capture group
Requests with special characters like for ex.
cyrilic characters in it would be rawurlencoded
by the used Uri() compo...
neusta infomantis
14:30 Revision de911ccc: [BUGFIX] Ensure slug pieces are strings
Pieces assembled into slugs must be strings.
The pieces may stem from any database field.
Depending on the database d...
Markus Klein
14:13 Revision 4db1b806: [BUGFIX] Ensure slug pieces are strings
Pieces assembled into slugs must be strings.
The pieces may stem from any database field.
Depending on the database d...
Markus Klein
14:10 Revision d438dd70: [BUGFIX] Avoid warning from optional HTTP_ACCEPT_LANGUAGE HTTP header
'Accept-Language' may not be sent by clients, the patch sanitizes access
to $request HTTP_ACCEPT_LANGUAGE using null ...
Georg Ringer
14:08 Revision 346cd70a: [BUGFIX] Fix warning in BackendUtility->getRecordTitle
Resolves: #95687
Releases: master
Change-Id: If4fde4dcac49e043b60686141a5b412c88fc9ade
Reviewed-on: https://review.ty...
Nikita Hovratov
14:00 Revision 07394796: [BUGFIX] Ensure cyrilic work as regexp redirects capture group
Requests with special characters like for ex.
cyrilic characters in it would be rawurlencoded
by the used Uri() compo...
neusta infomantis
13:53 Revision 0db7497b: [TASK] Spell LinkValidator consistently
"LinkValidator" as a proper noun is always spelled in CamelCase with these exceptions:
The namespace is spelled "Lin...
Lina Wolf
13:24 Revision 6e3ec7eb: [BUGFIX] Enforce setCopyMode in clipboard
The clipboard component features helper methods,
which generate a URL to update the clipboard
state with new elements...
Jochen Roth
13:21 Revision 2e1d68b9: [TASK] Add acceptance test for sitemap
To make sure the sitemap works as expected
a acceptance test has been added for
the sitemap overview and detail view....
Jochen Roth
13:20 Revision 3277c45e: [TASK] Quote database identifier in TCA
Add quoting for 'foreign_table_where'
in TCA.
Resolves: #94717
Related: #94697
Releases: master
Change-Id: I9abcf5f6...
Jochen Roth
13:14 Revision 13ee7664: [BUGFIX] Use correct selector for caret animation in EXT:form
Currently the expanded tree does not reflect the state
(collapsed/expanded).
This has been fixed by using the correc...
Jochen Roth
13:07 Revision 3452bdca: [TASK] Quote field names in typoscript
Some TS snippets miss proper DB field name quoting.
This is important to get right to be as DBMS compatible
as possib...
Jochen Roth
12:41 Revision 3ad3ff86: [BUGFIX] Use package information to list extensions in Extension Manager
The CLI command extension:list already uses package information
for listing extensions, whereas Extension Manager sti...
Helmut Hummel
12:04 Revision 989bfcc5: [TASK] Avoid code duplication in splitFunctionalTests.php
Build/Scripts/splitFunctionalTests.php is used in
gitlab-ci via runTests.sh to split functional tests
into smaller an...
Christian Kuhn
12:01 Revision 65d88c93: [BUGFIX] Add PHP 8.1 compatibility in FlashMessageQueue
Since PHP 8.1, most internal classes are updated with
tentative return types. This will be enforced with 9.0.
It mea...
Christian Kuhn

2021-10-18

11:49 Revision 7addc309: [TASK] Simplify error assertion in two functional tests
Property $expectedErrorLogEntries can be set to an
integer when tests expect that DataHandler operations
log errors o...
Christian Kuhn
11:39 Revision 0a90cd3e: [BUGFIX] Avoid php8.1 return type deprecation for (Lazy)ObjectStorage
This patch adds correct return types where possible,
otherwise add the #[\ReturnTypeWillChange] attribute
to temporar...
Stefan Bürk
11:38 Revision 44c8a030: [TASK] Avoid TYPO3_MODE definition in tests
Constant TYPO3_MODE has been deprecated in v11.
It should not be defined for tests anymore.
Resolves: #95685
Related...
Christian Kuhn

2021-10-17

22:19 Revision a1656158: [TASK] styleguide: Do not declare TYPO3_MODE for tests anymore
Christian Kuhn
20:41 Revision 726c876d: [BUGFIX] Avoid php warnings in Indexed Search Repository and Controlller
This change reduces the amount of invalid PHP code
for PHP 8.0 and removes some unused functionality,
also uses prope...
Benni Mack
20:39 Revision eb06531b: [BUGFIX] Prevent PHP 8 warning exception due to missing array keys
This prevents an exception for missing array keys when using an
extbase repository in the "render-preProcess" hook.
...
Daniel Dorndorf
20:16 Revision a6deb29e: [BUGFIX] Avoid php8.1 return type deprecations in LogRecord
PHP SPL class ArrayAccess requires return values in
PHP 8.1. We can not change those since that would be
breaking in ...
Stefan Bürk
20:00 Revision 2e8de1e8: [BUGFIX] Use proper driver for FAL isWithin() check
When checking if an identifier is within the processing folder,
the processing folders driver is used instead of curr...
Tim Schreiner
19:45 Revision 4e0a5764: [BUGFIX] Use proper driver for FAL isWithin() check
When checking if an identifier is within the processing folder,
the processing folders driver is used instead of curr...
Tim Schreiner
19:15 Revision 118c198e: [TASK] Raise typo3/cms-styleguide:~11.5.0
Brings a series of core v11 alignments and PHP 8.1 preparation.
Resolves: #95682
Releases: master
Change-Id: Ib291cc...
Christian Kuhn
18:55 Revision 4af64f10: [BUGFIX] Avoid deprecated redis method in testcase
Redis backend tests has been using native Redis
to verify test results. 'Redis::getKeys()' method
has been deprecated...
Stefan Bürk
18:47 Revision 971c2ea5: [RELEASE] styleguide: 11.5.0 Various core v11 alignments
Christian Kuhn
17:22 Revision 8a9c80b9: [TASK] Avoid call_user_func() in phpunit bootstrap
This patch avoid call_user_func() from phpunit
bootstrap corresponding to merged change in the
testing framework.
Re...
Stefan Bürk
14:24 Revision 29aacefa: [BUGFIX] Fix warning in InlineControlContainer
Resolves: #95663
Releases: master
Change-Id: Iaf10ab1c6e3ab4ee33d755f5f3bd6b82f9fba13a
Reviewed-on: https://review.ty...
Nikita Hovratov
14:24 Revision 6f865ea8: [BUGFIX] Prevent PHP 8 warning in FLUIDTEMPLATE variable resolving
Prevent PHP 8 undefined array key warning when resolving
a FLUIDTEMPLATE variable value from a TypoScript reference:
...
Alexander Stehlik
13:26 Revision 31f9a1ce: [TASK] gitlab-ci: Add nightly PHP 8.1 based linting
Change-Id: I51c915e552f9278104a2b6a8dca779e563d167bb
Resolves: #95677
Releases: master
Reviewed-on: https://review.ty...
Christian Kuhn
12:17 Revision a0a11785: [TASK] Install composer test distribution with PHP 8.1
Same as for the other PHP versions, 8.1 is added now.
Resolves: #95675
Releases: master
Change-Id: I3deb1784a15a6a44...
Christian Kuhn
11:07 Revision 96cf24e9: [DOCS] Document usage of FluidEmail
Feature #90728 added the FluidEmail option to EXT:form
EmailFinishers. The patch adds this very useful feature
to the...
Björn Jacob
11:06 Revision 2f7a5431: [BUGFIX] Fix type error when value in PaddingViewHelper is omitted
As the value is optional, null is given to
StringUtility::multibyteStringPad() which throwed a type error.
Also an in...
Chris Müller
10:50 Revision 05cf49ca: [DOCS] Document usage of FluidEmail
Feature #90728 added the FluidEmail option to EXT:form
EmailFinishers. The patch adds this very useful feature
to the...
Björn Jacob
10:39 Revision fc2fad2b: [BUGFIX] Fix type error when value in PaddingViewHelper is omitted
As the value is optional, null is given to
StringUtility::multibyteStringPad() which throwed a type error.
Also an in...
Chris Müller

2021-10-16

10:44 Revision dba49da7: [TASK] gitlab-ci: Run PHP 8.1 functional tests
Mixes PHP 8.1 into the various PHP / DMBS functional
test setup combinations for pre-merge and nightly runs.
Change-...
Christian Kuhn
09:02 Revision 45b067fa: [BUGFIX] Avoid php8.1 fatal error in FileSessionHandler
PHP8.1 added return types for some internal php
functions, class methods and interfaces, like it
has been added in ph...
Stefan Bürk

2021-10-15

21:03 Revision 0cada618: [TASK] gitlab-ci: Run PHP 8.1 unit tests
* Switches from PHP 8.0 to PHP 8.1 for pre-merge
unit tests. pre-merge now tests 'lower bound' 7.4
and 'upper bou...
Christian Kuhn
19:46 Revision 6b24af83: [BUGFIX] Do not log page access failures
It does not make sense to log page access failures
to the logging framework. Pages are inaccessible
for a reason, no ...
Markus Klein
19:29 Revision 1c87d604: [BUGFIX] Do not log page access failures
It does not make sense to log page access failures
to the logging framework. Pages are inaccessible
for a reason, no ...
Markus Klein
18:56 Revision 89b6d04a: [TASK] Have a FunctionalDeprecated test suite
With functional tests now failing on warnings and notices
and *showing* deprecations, the next step is to make sure
t...
Christian Kuhn
14:36 Revision ee15b5d4: [TASK] phpunit: Enable failOnRisky flag
Let tests fail that are considered 'risky' by phpunit.
We recently had a case during development where this
would hav...
Christian Kuhn
13:22 Revision 2c4981c8: [TASK] Add support for PHP 8.1 functions
This change adds the symfony/polyfill-php81
package as dependency.
Used composer commands:
> composer req symfony/p...
Benni Mack
12:46 Revision ef761359: [TASK] Add support for PHP 8.1 functions
This change adds the symfony/polyfill-php81
package as dependency.
In addition, EXT:form does not explicitly
depend ...
Benni Mack
12:29 Revision eef19bd9: [TASK] gitlab-ci: Enable FF_ENABLE_JOB_CLEANUP flag
This gitlab-runner flag invokes a 'git clean' command
at the end of each job run, after uploading caches, to
remove a...
Christian Kuhn
12:28 Revision e565c254: [TASK] gitlab-ci: Enable FF_ENABLE_JOB_CLEANUP flag
This gitlab-runner flag invokes a 'git clean' command
at the end of each job run, after uploading caches, to
remove a...
Christian Kuhn
11:50 Revision 36875015: [TASK] gitlab-ci: Enable FF_SCRIPT_SECTIONS flag
A new flag adds more "timing bubbles" in job runs.
It helps finding slow commands more easily and
is useful with jobs...
Christian Kuhn
11:50 Revision c6cee9d9: [TASK] gitlab-ci: Enable FF_SCRIPT_SECTIONS flag
A new flag adds more "timing bubbles" in job runs.
It helps finding slow commands more easily and
is useful with jobs...
Christian Kuhn
06:50 Revision 17ed0b8d: [TASK] Have notice and warning free functional tests
This new testing-framework version brings a feature
to let functional test fail if warnings or notices
or deprecation...
Christian Kuhn

2021-10-14

21:21 Revision e4ad4e1b: [TASK] styleguide: Fail on deprecations
Christian Kuhn
21:20 Revision eb965017: [BUGFIX] styleguide: Avoid deprecated StringUtility::beginsWith
Christian Kuhn
21:19 Revision e2ca4716: [TASK] styleguide: Enable functional test fails for notices
Christian Kuhn
21:17 Revision 833c4311: [TASK] styleguide: Show functional warnings and notices
Christian Kuhn
21:16 Revision b0c1f0cf: [TASK] styleguide: Raise typo3/testing-framework:^6.12.0
composer req --dev typo3/testing-framework:^6.12.0 Christian Kuhn
20:44 Revision 836f4dae: [BUGFIX] Add fallback values for backend group wizard
When editing a backend usergroup from within a user
a undefined key warning in PHP8 is thrown.
This is now fixed by ...
Jochen Roth
20:14 Revision a91fa193: [BUGFIX] Avoid undefined array access in PageRenderer
Resolves: #95618
Releases: master
Change-Id: I56521464bfca2237f1d9c0a52a628df249a4c9a1
Reviewed-on: https://review.ty...
Oliver Bartsch
19:17 Revision 9e261a04: [TASK] Skip a broken ext:impexp functional test
The ExportPageTreeViewTest is broken in various
scenarios. It is skipped for now to give us some
time fixing this fun...
Christian Kuhn
18:02 Revision 257bb90a: [BUGFIX] Fix PHP8 warning in NumberWithIconWidget
The subtitle can be considered optional, and if not set a PHP8
warning is raised. Additionally, the other two options...
Chris Müller
17:46 Revision 9b8e11b5: [BUGFIX] Suppress warnings in BackendModuleControllerTest
The hard coded install tool session handling forces a
hack to suppress warnings in a ext:install functional
test.
Re...
Christian Kuhn
17:32 Revision 4216c425: [BUGFIX] Avoid incomplete setup in StorageRepositoryTest
The StorageRepositoryTest tests createLocalStorage() which
calls testCaseSensitivity() to find out if a local filesys...
Christian Kuhn
15:57 Revision 422f0449: [BUGFIX] Avoid warnings in FormEngine
* Editing an orphan metadata record that is no longer
connected to a file can result in a warning. This is
found ...
Christian Kuhn
15:56 Revision 09fa0b5c: [BUGFIX] Avoid warnings in ContentObjectRenderer
And another set of warning fixes in ContentObjectRenderer
found by functional tests, this time in encaps_lineSplit()....
Christian Kuhn
13:58 Revision ef5c5394: [BUGFIX] Avoid dangling error handler registrations in tests
The functional ErrorHandlerTest uses set_error_handler()
to register test subjects. These need to be dropped
afterwar...
Christian Kuhn
13:44 Revision 3e7d57ab: [TASK] Unify label files in indexed_search
The label file locallang_pi.xlf is only used for 2 labels
for newContentElement wizard.
These can be unified, as thi...
Benni Mack
12:02 Revision afd50f53: [BUGFIX] Fix ExportNoPagetree issue
Imported from GitHub Pull Request
Releases: 10.4
Resolves: #95377
Resolves: #95592
Change-Id: I7525d785e2b98e9fbdd82...
Davide Alghi
10:33 Revision 368b81e2: [BUGFIX] Fix session warning from MFA controller tests
Some MFA controller tests trigger backendUser->logOff() which
destroys the backend user session. This backend user is...
Christian Kuhn
09:18 Revision 12316c4b: [BUGFIX] Avoid improper setup in ext:backend controller tests
Controller tests for ext:backend setup server requests
to simulate frontend calls, thus omitting the default
frontend...
Stefan Bürk
09:11 Revision e3cbd98c: [BUGFIX] Make Linkvalidator event listener more robust
A page link may not contain the query parameter uid.
Make sure that the event listener is robust and handles
unfilled...
Sybille Peters
08:22 Revision 4898345d: [BUGFIX] Indexed Search Lexer checks for words instead of letters again
Due to a regression introduced in PHP8 bugfixes
(see https://review.typo3.org/c/Packages/TYPO3.CMS/+/69819)
this chan...
Benni Mack
06:17 Revision a64d78c5: [BUGFIX] Make Linkvalidator event listener more robust
A page link may not contain the query parameter uid.
Make sure that the event listener is robust and handles
unfilled...
Sybille Peters
06:16 Revision aaf23f87: [BUGFIX] Fix dashboard drag and drop handler
Migrate the muuri.js option `dragStartPredicate.handle`
to `dragHandle`, preventing the draggable area to be on
the w...
Ralf Zimmermann
06:10 Revision 75c1ee01: [BUGFIX] Ensure routing works for request with chinese letter
Routing for requests with chinese letters failed. As the used
symfony components internally uses rawlurldecode() on s...
Stefan Bürk

2021-10-13

19:21 Revision 48fe2af6: [BUGFIX] access-restricted subpages of sysfolders return 403
This change addresses a regression of
https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829
where access-restricted p...
Benni Mack
19:19 Revision 96be2e18: [BUGFIX] Ensure routing works for request with chinese letter
Routing for requests with chinese letters failed. As the used
symfony components internally uses rawlurldecode() on s...
Stefan Bürk
19:18 Revision b1583998: [BUGFIX] Prevent exceptions for new user accounts
In case new user accounts are not properly set up
and the user tries to login, some toolbar related
components led to...
Oliver Bartsch
19:06 Revision fc1d86f8: [BUGFIX] Avoid warning in ResourceStorage
ResourceStorage->getUniqueName() is used to return a
unique and sanitized file or folder name. It uses
pathinfo() on ...
Christian Kuhn
19:05 Revision b1dd00dd: [BUGFIX] Add missing field_name to CategoryCollection test setup
CategoryCollectionTest needs to set up 'field_name' for
a collection record to satisfy CategoryCollection::create()
n...
Christian Kuhn
19:04 Revision 6d279c87: [BUGFIX] Avoid warning in LanguageService
LanguageService->sL('LLL:') leads to a warning. Even
though this is of course a broken call, the code should
sanitize...
Christian Kuhn
19:02 Revision b5c631ed: [BUGFIX] Avoid improper method call in PageRepositoryTest
Some PageRepositoryTest tests call getMenu() with a
restricted set of select fields as second argument.
Running this...
Christian Kuhn
18:56 Revision bcd9bb4d: [TASK] Avoid deprecated code in cache:flush TCA loading
With the deprecation of CacheManager usage during TCA/ext_tables
loading in #94979, the console command cache:flush n...
Benjamin Franzke
18:55 Revision 7f374c22: [BUGFIX] Avoid improper setup in PagesTsConfigGuardTest
LanguageService must be initialized after backend
user has been set up.
Resolves: #95633
Releases: master
Change-Id:...
Christian Kuhn
18:55 Revision 7cf24b0f: [BUGFIX] Avoid warnings triggered by SiteHandling tests
A set of fixes for partially incomplete test setup in
functional tests and a series of undefined array index
warnings...
Christian Kuhn
18:53 Revision 8c0f318d: [BUGFIX] Incomplete setup in AuthenticationServiceTest
AuthenticationService relies on 'userid_column' being
set. The functional test setup is incomplete and
adapted with t...
Christian Kuhn
18:43 Revision 8d53c97b: [TASK] Explicitly setup errorHandler in ErrorHandlerTest
The testing framework will soon disable error suppression
by unsetting the default errorHandler for functional tests....
Christian Kuhn
16:35 Revision 3f5c0fe2: [DOCS] Improve description of EXT:form label translations
In case EXT:form labels are translated, using a custom
language file and the labels contain HTML markup, the
labels h...
Markus Timtner
14:53 Revision 57a16fca: [BUGFIX] Fix page link in redirects module pagination
With this patch, the page link (requesting a
dedicated paginated page) in the redirects module
pagination is now work...
Martin Tepper
14:53 Revision 7c99bea7: [BUGFIX] Fix undefined array key warnings in GifBuilder
Resolves: #95613
Releases: master
Change-Id: I3360ed2177c9b34e8c4633d5555c62a8dfa4e274
Reviewed-on: https://review.ty...
Stefan Bürk
14:29 Revision cb69dfb9: [BUGFIX] Fix page link in redirects module pagination
With this patch, the page link (requesting a
dedicated paginated page) in the redirects module
pagination is now work...
Martin Tepper
12:57 Revision f7fb61fc: [DOCS] Add more details to the manual of EXT:impexp
Explanation of almost all configuration parameters.
Automatic creation of almost all screenshots. The file
`Document...
Alexander Nitsche
12:56 Revision 2274afb7: [BUGFIX] Avoid warning when eID is given as array
Calling https://www.example.com/?eID[]= results in $eID being an array
which triggers an 'illegal offset' warning and...
Sebastian Michaelsen
12:47 Revision 641aa36c: [BUGFIX] Pad multibyte strings correctly
A new function StringUtility::multibyteStringPad() is
introduced to handle multibyte strings instead of
str_pad() whi...
Sybille Peters
12:35 Revision 0d17e9dd: [BUGFIX] Avoid fallback to ObjectManager in PropertyMapperTest
The on-the-fly type converters need to be registered
in container to avoid deprecated ObjectManager fallbacks.
Resol...
Christian Kuhn
12:32 Revision 4f45663c: [BUGFIX] Avoid warnings in ShortcutRepository
Some details in (deprecated) ShortcutRepository should
be sanitized to avoid warnings.
Resolves: #95627
Releases: ma...
Christian Kuhn
12:31 Revision 7847fc48: [BUGFIX] Fix "View" button on pages with doktype > 200
When editing a content element on a page with doktype > 200
the view button will not render this page
in the frontend...
Łukasz Uznański
12:29 Revision e05a8580: [BUGFIX] Fix undefined array key warnings in GraphicalFunctions
Resolves: #95622
Releases: master
Change-Id: If8c7ddef423df9b8071f563f24fbd773a6c8bd8f
Reviewed-on: https://review.ty...
Nikita Hovratov
12:27 Revision 40cc3603: [BUGFIX] Avoid warning when eID is given as array
Calling https://www.example.com/?eID[]= results in $eID being an array
which triggers an 'illegal offset' warning and...
Sebastian Michaelsen
12:18 Revision 7301bcd5: [BUGFIX] Prevent htmlSanitize deprecation in ContentObjectRendererTest
htmlSanatize configuration has been marked as mandatory for v12 with
corresponding deprecation message with #94786 if...
Stefan Bürk
12:13 Revision c53565e9: [BUGFIX] Fix "View" button on pages with doktype > 200
When editing a content element on a page with doktype > 200
the view button will not render this page
in the frontend...
Łukasz Uznański
12:04 Revision 723092d0: [BUGFIX] Avoid warning from optional HTTP_ACCEPT_LANGUAGE
HTTP header 'Accept-Language' may not be sent by clients,
the patch sanitizes access to $request HTTP_ACCEPT_LANGUAGE...
Christian Kuhn
12:00 Revision 5ae89655: [BUGFIX] Restore "edit metadata" of translated files in FormEngine
In case a files' metadata were translated in a L>0 language,
whenever the file is references in a record with this L>...
Oliver Bartsch
11:41 Revision 58ed8a7e: [BUGFIX] Avoid access to undefined array key in BackendUtility
The array in question may not exist, sanitize using
null coalescence operator.
Resolves: #95624
Releases: master
Cha...
Christian Kuhn
11:39 Revision 4fda8e57: [BUGFIX] Avoid undefined array key access in PasswordReset
When a client sends a backend reset password request
without providing new password fields, a warning is
raised.
Res...
Christian Kuhn
11:36 Revision a341142b: [BUGFIX] Check for TSFE before use in ContentObjectRenderer
TypoScriptFrontendController has not been injected to a
ContentObjectRenderer instance in a test, thus failing
with d...
Stefan Bürk
11:35 Revision f4848289: [BUGFIX] Avoid undefined array key warning in PageTypeDecorator
Using null coalescing operator in type map access to avoid
undefined array key warning if check value is not defined
...
Stefan Bürk
11:34 Revision f85ae563: [BUGFIX] Fix undefined array key warning in ImageContentObject
Use null coalescing operator to fix undefined array key warning
in ImageContentObject
Resolves: #95615
Releases: mas...
Stefan Bürk
10:57 Revision 820e225f: [TASK] Add required attribute to input fields of filelist module
The forms to add a new media asset and to create a new textfile require
a value. Using the attribute `required` impro...
Georg Ringer
10:55 Revision 21111fe7: [BUGFIX] Fix log level in html sanitizer config docs
Updating Logger configuration as the code gives the following error
otherwise:
The given severity level "debug" for ...
Benjamin Pick
10:32 Revision 939f9db0: [BUGFIX] Fix log level in html sanitizer config docs
Updating Logger configuration as the code gives the following error
otherwise:
The given severity level "debug" for ...
Benjamin Pick
10:21 Revision 45ad8375: [BUGFIX] Fix new keyword replacement in ContainerBuilder
With the introduction of dependency injection a workaround
was added that substitutes `new ClassName(…)` with
`Genera...
Benjamin Franzke
10:09 Revision f5fed2ff: [BUGFIX] Fix undefined array key warning in TitleTagRenderingTest
Test data array had not been consistent, thus throwing undefined
array access warnings.
This patch use null coalesci...
Stefan Bürk
09:59 Revision 6e414874: [BUGFIX] Use correct description for cache clearing in Install Tool
Cache Clearing via Install Tool does a lot more than clearing the caches
in the toolbar.
Additionally the informatio...
Georg Ringer
09:09 Revision 4f8361c7: [BUGFIX] Fix undefined array key access in ModuleLoader
Resolves: #95612
Releases: master
Change-Id: Idbbdb2e69874d51db7bb617a07d3151abe40369a
Reviewed-on: https://review.ty...
Oliver Bartsch
08:52 Revision 7733cf68: [BUGFIX] Use correct description for cache clearing in Install Tool
Cache Clearing via Install Tool does a lot more than clearing the caches
in the toolbar.
Additionally the informatio...
Georg Ringer
08:16 Revision 6912e75c: [BUGFIX] Use correct id for viewpage iframe
While migrating the viewpage JavaScript module
to TypeScript in #87704, an id was falsely renamed.
This is now fixed...
Oliver Bartsch
07:37 Revision f497feb5: [BUGFIX] Add missing borders below tablesort th elements
While fixing an issue with sticky icons, the borders
below th elements with "position: relative" got
removed. This is...
Nikita Hovratov
07:31 Revision bc560349: [TASK] Add example for wildcard redirect
Resolves: #94923
Releases: master, 10.4
Change-Id: I59220d1483303adfa09e4d1e1bb57a29378663a9
Reviewed-on: https://rev...
Bernd Wilke
07:11 Revision 835ec9e0: [TASK] Add example for wildcard redirect
Resolves: #94923
Releases: master, 10.4
Change-Id: I59220d1483303adfa09e4d1e1bb57a29378663a9
Reviewed-on: https://rev...
Bernd Wilke
07:10 Revision e96a5785: [BUGFIX] Bump symfony/polyfill-php80 to ^1.23.1
Since #95466 str_contains() is used with `null`
instead of strings in a lot of cases throughout the core.
This causes...
Benjamin Franzke
02:57 Revision 171c7cbe: [BUGFIX] Add EXTENSIONS array to DefaultConfiguration
$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS'] stores extensions
specific settings - settings created from definitions in
...
Christian Kuhn

2021-10-12

19:36 Revision ca31977c: [BUGFIX] Avoid undefined key access in extbase tests
Some assertions in extbase functional tests access
not existing array keys, which raises PHP 8.0 warnings.
Sanitize t...
Christian Kuhn
18:12 Revision 2d3a193a: [TASK] Update current supported versions in SECURITY.md
Supported versions by the community has been changed
after v11 LTS has been released, Furthermore v9 has
shifted into...
Stefan Bürk
17:30 Revision c4e08f80: [BUGFIX] Transfer minimum password length to the template
Resolves: #95599
Related: #94328
Releases: master
Change-Id: If4fc48d4b279298d4bde9cd338322e5e4598a237
Reviewed-on: h...
Xavier Perseguers
15:47 Revision 1ca1d1f8: [BUGFIX] Fix undefined array key warning in Scheduler
Resolves: #95602
Releases: master
Change-Id: Ic91531aa6d5a95006b99bbf2d8b29db9a41516fa
Reviewed-on: https://review.ty...
Nikita Hovratov
15:28 Revision 502b6d4f: [BUGFIX] Use correct method call for getStatusCode
Resolves: #95586
Related: #94402
Releases: master
Change-Id: I2b6094032523e8bcbbc67edb32b2a2c8f3abcb9f
Reviewed-on: h...
Georg Ringer
15:13 Revision 41a0d0f3: [BUGFIX] PHP 8.0 warnings from ContentObjectRenderer
The Format/HtmlViewHelper is designed to run in backend
without TSFE. The HtmlViewHelperTest with disabled error
supp...
Christian Kuhn
15:09 Revision 6fbdadfb: [BUGFIX] Fix PHP 8.0 warning in ContentObjectRenderer
As found by ext:fluid TypolinkViewHelperTest with
disabled error suppression, ContentObjectRenderer
does not properly...
Christian Kuhn
14:53 Revision 704d97ca: [BUGFIX] Incomplete setup in extbase PersistenceManager tests
The persistence tests use ext:blog_example repositories
and miss to properly setup ConfigurationManager for this
exte...
Christian Kuhn
14:53 Revision b37802d4: [BUGFIX] Return ResponseInterface in test controllers
Extbase functional tests with disabled error suppression
reveal there are still some tests with fixture classes
that ...
Christian Kuhn
12:32 Revision a3c5c805: [TASK] Set TYPO3 version to 11.5.2-dev
Change-Id: I601a246dc057e469876326c7f1d163bbfdf19cad
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/715...
Benni Mack
12:18 Revision dcba2a7c: [RELEASE] Release of TYPO3 11.5.1
Change-Id: I9a38139470a45db0f2f0062165b69180a1b58bc1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/715...
Benni Mack
11:24 Revision f217488e: [TASK] Improve PHPDoc of ResourceStorage::sanitizeFileName
Adapt description and remove hints on exceptions which are not thrown here.
Resolves: #95149
Releases: master, 10.4
...
Stephan Großberndt
11:07 Revision b3790781: [BUGFIX] Restore same height for Tree and Docheader
Resolves: #95450
Releases: master
Change-Id: Ifc008b06c3db26a835d50fa7f07caa23600c9795
Reviewed-on: https://review.ty...
Oliver Bartsch
10:32 Revision 80fa6174: [TASK] Improve PHPDoc of ResourceStorage::sanitizeFileName
Adapt description and remove hints on exceptions which are not thrown here.
Resolves: #95149
Releases: master, 10.4
...
Stephan Großberndt
10:00 Revision 694bdc51: [BUGFIX] Add fallback for undefined key warning in PHP8
These warnings have been fixed by adding a proper
fallback where needed.
Resolves: #95563
Releases: master
Change-Id...
Jochen Roth
09:32 Revision 8585fa77: [TASK] Show name of table when editing record
To make it easier for developers and integrators,
the table name is now shown in the backend when
debugging is active...
Georg Ringer
09:30 Revision d21dcb2b: [TASK] Use str_contains instead of strpos where possible
The (ugly) statement strpos($haystack, 'needle') !== false can be safely
replaced with str_contains($haystack, 'needl...
Nikita Hovratov
08:55 Revision 679ca065: [TASK] Update documentation links
Releases: master
Resolves: #95574
Change-Id: I2587d67c09b317a6a14681fdf2c77a702d0be734
Reviewed-on: https://review.ty...
Susanne Moog
08:54 Revision dc4c9c1b: [BUGFIX] Fix workspace state handling
The WorkspaceMenu JavaScript module is used to
update the topbar elements, related to workspaces.
The required state...
Oliver Bartsch
08:29 Revision bcc2d11e: [BUGFIX] Render HTML tags in CSH
Allow a list of HTML tags in the help content just as for
the configuration details.
Resolves: #95152
Releases: mast...
Oliver Hader
07:01 Revision 2a5c83e1: [TASK] Update composer dev dependencies
composer req --dev composer/package-versions-deprecated:^1.11.99.4
composer req --dev friendsofphp/php-cs-fixer:^3.2
...
Wouter Wolters

2021-10-11

20:36 Revision 7ee4a971: [BUGFIX] Ensure string is passed to f:sanitize.html view helper
Resolves: #95573
Releases: master, 10.4
Change-Id: I13742f80588d8d1d566d08e7b51c165a5139fe50
Reviewed-on: https://rev...
Oliver Hader
20:36 Revision d7d5a5fc: [BUGFIX] Ensure string is passed to f:sanitize.html view helper
Resolves: #95573
Releases: master, 10.4
Change-Id: I13742f80588d8d1d566d08e7b51c165a5139fe50
Reviewed-on: https://rev...
Oliver Hader
19:07 Revision 4582c934: [BUGFIX] Incomplete setup in PhpErrorCodeViewHelperTest
The install tool has a special standing due to the
FailSafeContainer. The default functional test set up
however crea...
Christian Kuhn
18:15 Revision 61d760e7: [BUGFIX] Undefined array keys related to workspaces
Fixes some undefined array key errors which happen in some specific
scenarios related to workspaces usage.
Resolves:...
Francois Suter
18:13 Revision 6eed2f6b: [BUGFIX] Avoid ReferenceIndex->enableRuntimeCache() in EXT:impexp
enableRuntimeCache() has been deprecated with #93038, with
all calls being removed. #94772 re-introduced one case,
pr...
Christian Kuhn
18:10 Revision 47274ba9: [TASK] Upgrade @types/bootstrap to 5.1.6
This resolves a todo in Tooltip.ts, where we've waited
for an updated types definition for bootstrap. Now
some new me...
Nikita Hovratov
15:36 Revision 0a0e7265: [BUGFIX] PHP 8.0 warnings in QueryGenerator
Yet another series of PHP 8 stabilizations for
ext:lowlevel QueryGenerator. This time found by
functional tests when ...
Christian Kuhn
15:19 Revision b08473b7: [BUGFIX] Show broken links for all languages
If no allowed languages are defined for a BE user / group
([allowed_languages] is not set), only broken links in reco...
Sybille Peters
15:02 Revision e256d2e6: [BUGFIX] Return empty stages list in LIVE workspace
When accessing the Workspaces module in the LIVE workspaces, the
underlying code tries to access the list of stages a...
Francois Suter
14:53 Revision 982308b5: [BUGFIX] Show broken links for all languages
If no allowed languages are defined for a BE user / group
([allowed_languages] is not set), only broken links in reco...
Sybille Peters
14:51 Revision c86b2929: [BUGFIX] Allow FilePathSanitizer to return absolute paths
There are few cases where the resulting path from FilePathSanitizer
is needed and used as absolute path to a private ...
Helmut Hummel
13:13 Revision 17890022: [BUGFIX] No exclude for transOrigPointerField
One of the functional test related extensions still sets
'exclude' TCA property for a transOrigPointerField, which
is...
Christian Kuhn
12:42 Revision a39765e0: [BUGFIX] Prevent undefined array key access in modAccess()
This fixes a couple of undefined array key accesses
in BackendUserAuthentication->modAccess().
Besides, the code is ...
Oliver Bartsch
11:50 Revision eef89fac: [BUGFIX] Fix undefined array key errors for PHP 8.0
Releases: master
Resolves: #95490
Change-Id: I8c7f055182e9a4da8ea5a7a4bd946cc69ce26e0f
Reviewed-on: https://review.ty...
Stephan Sellner
11:35 Revision b8942cf2: [BUGFIX] Fix PHP8 warning from PageSlugCandidateProvider
In PageSlugCandidateProvider the pageCandidate MPVar has
been build conditional based on of original MPVar was set.
T...
Stefan Bürk
11:33 Revision 245c13b6: [BUGFIX] Initialize backenduser for RedirectServiceTest
RedirectsServiceTests simulate frontend requests
without executing them really, which prevents from
running through t...
Stefan Bürk
11:32 Revision c4624cae: [BUGFIX] Initialize language object in SlugServiceTest
Tests in SlugServiceTest from ext:redirects depend on
an initialized LanguageService, which has not been done
as ther...
Stefan Bürk
11:30 Revision b6cbade9: [BUGFIX] PHP8.0 warning from ext:recycler tests
Initializing LanguageService in $GLOBALS['LANG'] with
Bootstrap::initalizeLanguageObject() needs a proper setup
$GLOB...
Stefan Bürk
10:43 Revision a5bbdc27: [BUGFIX] (Re)initalize beuser based LanguageService after beuser
BrokenLinkRepositoryTest of ext:linkvalidator initalizes
beuser dynamicly for tests and testdatasets. LanguageService...
Stefan Bürk
10:01 Revision b7ea895c: [BUGFIX] Check for complete database configuration before connecting
Install tool has been trying to connect to the database before
checking if a bare minimum of configuration is given t...
Stefan Bürk
09:55 Revision b7d33abd: [BUGFIX] Move virtual storage 0 back to public path
It was a conceptual mistake to move storage 0 base path
outside the document root (public path), because this complet...
Helmut Hummel
09:17 Revision f489cb50: [TASK] Add class name to deprecated cObj for plugins message
Public property $cObj for plugins has been deprecated in
v11 with #94956 and setContentObjectRenderer() method has
be...
Stefan Bürk
09:16 Revision eb4b65b1: [TASK] Set visibility of Clipboard->getLocalizations to protected
This resolves a todo, where a test was blocking a
method of Clipboard to be protected. The test is
now adjusted as su...
Nikita Hovratov
08:17 Revision bd637d37: [BUGFIX] Fix some minor Composer mode path inconsistencies
* Use config API instead of env vars when building package artifact
* Don't try to scan for extensions in Composer mo...
Helmut Hummel

2021-10-10

18:23 Revision 463597c1: [BUGFIX] access-restricted subpages of sysfolders return 403
This change addresses a regression of
https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829
where access-restricted p...
Benni Mack
12:00 Revision f6c25aae: [BUGFIX] PHP8.0 warning in CleanerTask
CleanerTasks build a query checking if tstamp tca
config is checked. Using null coalescing operator
to sanatize acces...
Stefan Bürk
10:44 Revision 08cd87c0: [BUGFIX] Fix undefined index and offset warning in lowlevel QueryGenerator
This patch fixes undefined index/offset warnings in ext:lowlevel
QueryGenerator using null coalescing operator.
Reso...
Stefan Bürk

2021-10-09

11:05 Revision e8392985: [BUGFIX] Fix the generics annotations for ObjectManager(Interface)
To avoid PHPStan warnings in projects that use ObjectManagerInterface
as a type annotation, the ObjectManager(Interfa...
Oliver Klee
09:29 Revision c746c186: [BUGFIX] Properly set softRefParams in LinkAnalyzer
This correctly sets "subst" as a value of the
softRefParams array. Previously "subst" was
set as key, which only work...
Oliver Bartsch
07:32 Revision 3f844357: [BUGFIX] Add correct value for $itemsCriteriaField
Adding a file collection to the file links
content element leads to undefined array
key warning.
This is fixed by se...
Jochen Roth
07:16 Revision 34a9ff66: [BUGFIX] Align default value of displayThumbs
The "displayThumbs" module setting is
fetched two times in the FileBrowser. One
time to determine whether thumbnails
...
Oliver Bartsch

2021-10-08

22:11 Revision 7fa71a1d: [BUGFIX] Add parenthesis where operation result is enforced
The coalesce operator has a relatively low precedence over other
operators. If used as part of other expressions, it ...
Nikita Hovratov
17:05 Revision 2f96ed6a: [BUGFIX] Set remote identifier for checking extension dependencies
When showing required dependencies (= extensions) in
Extension Manager, e.g. for distributions - downloading
the Intr...
Benni Mack
16:41 Revision 09c651a0: [BUGFIX] Prevent undefined key warnings in ProductionExceptionHandler
Access to $GLOBALS['BE_USER'] must be protected by the
neccessary fallbacks, as no backend user might be logged
in wh...
Robert Kärner
16:40 Revision bd25eb80: [BUGFIX] Add autocomplete attribute to confirmation password
The confirmation password, required for accessing
the install tool through the backend, now uses the
autocomplete att...
Oliver Bartsch
16:31 Revision 8d3e14ed: [TASK] Ensure record_commit parameters are not reused
When using the "saveAndClose" option for a newContentElementWizard
item, the target link forwards directly to the rec...
Marcel Schüßler
16:27 Revision a3ec0dfd: [BUGFIX] Do not prefix source set path with absRefPrefix
The paths for source set images is currently prefixed
with a slash which causes duplicated slashes at the
beginng of ...
Jochen Roth
16:17 Revision 0f0b4b9f: [TASK] Apply ParamTypeDeclarationRector on private methods
Releases: master
Resolves: #95258
Change-Id: Idddbd4c449e2dc891c91f466614f04a8770d5815
Reviewed-on: https://review.ty...
Alexander Schnitzler
16:15 Revision 27360c38: [BUGFIX] Fix undefined array key warnings
This fixes some undefined array key warnings,
that appear on frontend requests.
Resolves: #95542
Releases: master
Ch...
Oliver Bartsch
15:57 Revision 3d3372c8: [BUGFIX] Prevent PHP 8 warnings during content rendering
Prevent access to undefined array keys in content renderer
and menu objects.
Resolves: #95489
Releases: master
Chang...
Alexander Stehlik
15:43 Revision a1cd9b56: [BUGFIX] Prevent undefined key warnings in suggest wizard
Several undefined array key warnings prevented the
TCA suggestion wizard from showing results.
These have been fixed....
Robert Kärner
13:11 Revision 46e8a702: [BUGFIX] Clean up clipboard before using it in ContextMenu
Some item providers (context menu) access
clipboard information. Since the clipboard was
previously not properly init...
Oliver Bartsch
11:00 Revision ec7fc82f: [BUGFIX] Properly store and retrieve task group collapse state
In #86291 the scheduler task list was refactored. A
part of this refactoring was aligning the list with the
one, know...
Oliver Bartsch
09:36 Revision d05aa467: [BUGFIX] Catch UnknownLinkHandlerException in view helper
EXT:redirect is using the TargetPageIdViewHelper to
get the page ID from a "t3://page?uid=" link. If this link
is how...
Oliver Bartsch
08:57 Revision bd237135: Revert "[BUGFIX] Use correct variable in CheckboxElement"
This reverts commit d04a65b5a731fe67af06e0507627b198e8a96a7f.
Reason for revert: Breaks checkboxes in flexform, usin...
Oliver Bartsch
08:11 Revision 0b9d925f: [BUGFIX] Catch UnknownLinkHandlerException in view helper
EXT:redirect is using the TargetPageIdViewHelper to
get the page ID from a "t3://page?uid=" link. If this link
is how...
Oliver Bartsch
07:55 Revision e2c06db7: [BUGFIX] Fix non-matching values in functional test datasets
The values of tx_testdatahandler_group for the second content element
in the default language now match with ImportDe...
Nikita Hovratov
07:48 Revision f35e7100: [TASK] Unify autoSizeMax logic
This unifies the approach of calculating the size attribute value when
having autoSizeMax set.
Resolves: #94476
Rele...
Nikita Hovratov
07:45 Revision cc0c6b27: [BUGFIX] Restore inconsistent language highlighting
The page module displays a flash message for page
translations with inconsistent ("mixed mode") content
elements. The...
Oliver Bartsch
07:43 Revision 4f7416a8: [BUGFIX] Properly handle array key access in ExtendedTemplateService
This fixes the ExtendedTemplateService->ext_getSetup()
method, which now properly handles array key accesses.
A new ...
Oliver Bartsch
06:54 Revision 08643252: [BUGFIX] Rebuild redirect cache after changing slug
If a slug is changed, the redirect cache must be rebuilt to make
the redirect actually work.
Resolves: #94808
Releas...
Georg Ringer
06:19 Revision c9525155: [BUGFIX] PHP 8.0 warning from ContentObjectRenderer
TypoScript options config.spamProtectEmailAddresses_atSubst
and config.spamProtectEmailAddresses_lastDotSubst may not...
Christian Kuhn
06:18 Revision ba513048: [BUGFIX] Fix EXT:felogin FlexForm
EXT:felogin uses checkbox items in their FlexForm
configuration. Since the item key does not start
with 0 but with 1,...
Oliver Bartsch

2021-10-07

21:17 Revision dd0c8301: [BUGFIX] Set fe_user email field to eval "email"
Currently the fe_user field email has a eval value
of "trim". So it does not verify the given email.
This has been f...
Jochen Roth
19:39 Revision 768bd1cd: [BUGFIX] Extbase UriBuilder warning in Backend context
The extbase UriBuilder can be used in backend context,
ActionMenuItemViewHelper does that for instance. The
code acce...
Christian Kuhn
19:35 Revision 2bd19657: [BUGFIX] Add fallback for link details
A link to a folder created in RTE leads to undefined
array key warning in frontend.
This has been fixed by using nul...
Jochen Roth
19:30 Revision ad2a858b: [TASK] Improve links in footer of error page
The links at the error page can be improved:
- link to the official donation page
- show typo3.org without protocol
...
Georg Ringer
19:27 Revision 77056aed: [BUGFIX] Incomplete setup in ImageViewHelperTest
* Arguments with default values are registered with their
default values in fluid by default. Tests that circumvent...
Christian Kuhn
19:10 Revision 8a210a68: [BUGFIX] Use proper call to stdWrapValue
Fix a regression introduced in #91834 to be able to use stdWrap for
text.
Resolves: #95497
Related: #91834
Releases:...
Georg Ringer
19:09 Revision 9aa0acd8: [BUGFIX] Incomplete setup in FileViewHelperTest
The FileViewHelperTest runs in backend scope, a valid
backend user needs to be initialized to satisfy
StoragePermissi...
Christian Kuhn
17:47 Revision 933d5a02: [BUGFIX] Incomplete setup in ScriptViewHelperTest
Argument 'priority' is accessed in ScriptViewHelper
without fallback. This is fine, since fluid sets
arguments to def...
Christian Kuhn
17:46 Revision 602f2f75: [BUGFIX] Correct VH name in HtmlentitiesDecodeViewHelperTest
Fluid Viewhelper class name resolution is case sensitive.
The patch fixes a cases where f:format.htmlentitiesdecode
i...
Christian Kuhn
17:46 Revision 2a2f6288: [TASK] Rename method inside PageLayoutController
Give the actual method the name "generateMessagesForCurrentPage"
as no flash messages are generated.
Resolves: #9342...
Benni Mack
15:06 Revision 9f228e99: [BUGFIX] Return ResponseInterface in ext:fluid_test action
Avoids a deprecation level log error since of this
functional test related extbase test controller action.
Resolves:...
Christian Kuhn
15:05 Revision 84bc062e: [BUGFIX] errorHandling setup in site based functional tests
Some functional tests using SiteBasedTestTrait create
a broken site config, example:
base: 'https://website.local/'
...
Christian Kuhn
15:05 Revision c1d2ad4f: [BUGFIX] Container registration of ext:fluid_test VH's
Viewhelpers need to be registered in Services.yaml.
Add this for a functional test related fixture extension.
Resolv...
Christian Kuhn
14:11 Revision c69be088: [BUGFIX] Rebuild redirect cache after changing slug
If a slug is changed, the redirect cache must be rebuilt to make
the redirect actually work.
Resolves: #94808
Releas...
Georg Ringer
14:09 Revision 3f81eeb3: [BUGFIX] Do not show empty dates of system news
If the creation date of a system news is cleared by an editor, the
rendered news must skip the date.
Resolves: #9457...
Georg Ringer
13:37 Revision 4d00b228: [BUGFIX] Use proper bootstrap styles for "Make Query" in DB check
This refactores the "Make Query" block in the DB check module
to use proper bootstrap styles. This makes the whole bl...
Marcin Sągol
12:56 Revision 1506c257: [BUGFIX] Fix undefined array key errors
Resolves: #95075
Releases: master
Change-Id: I6c2c9981aac3ccf892767c4205032e8aa2a465e6
Reviewed-on: https://review.ty...
Nikita Hovratov
12:32 Revision 5e8886d9: [BUGFIX] Avoid $GLOBALS['TYPO3_REQUEST'] warning in Clipboard
Functional test ext:felogin
ContentVisibleFieldsTest::loginFormContainsExpectedFields
indirectly calls $GLOBALS['TYPO...
Christian Kuhn
11:53 Revision 6307bce4: [DOCS] Recommend $container->hasDefinition() for optional dependencies
ExtensionManagementUtility() usage in Services.php has never been an
intended usage, but was technically possible in ...
Benjamin Franzke
11:51 Revision d04a65b5: [BUGFIX] Use correct variable in CheckboxElement
The 2nd argument for the method `renderSingleCheckboxElement` must be
the number of the element of the given list.
R...
Georg Ringer
11:38 Revision 504a999e: [DOCS] Document overrideConfiguration parameter
Some remarks regarding the overrideConfiguration parameter
have been documented.
Resolves: #89933
Releases: master, ...
Björn Jacob
11:16 Revision f778cfe3: [BUGFIX] Fix TypoScript object browser search
This fixes a couple of array key related PHP warnings,
triggered in the TypoScript object browser while searching.
T...
Oliver Bartsch
10:44 Revision 3a9bac11: [TASK] Quote identifier in messages with " instead of ' for ext:impexp
Log messages generally use double-quotes. This patch fixes the
few stragglers that do not.
This also fixes an issue...
Stefan Bürk
10:39 Revision 363b6b4f: [TASK] Add missing breaking.rst about service injection in validators
With #92238 the objectManager usage has been removed in Extbase
validationResolver. In the same patch it is also ment...
Torben Hansen
10:39 Revision 08c1d863: [TASK] Raise doctrine/dbal:^2.13.4
Brings fix for changed sqlite driver behaviour for php8.1,
which would fix a schemamigrator issue for php8.1.
compo...
Stefan Bürk
10:25 Revision 84d648a7: [BUGFIX] Correctly close anchor tag in object browser
Resolves: #95516
Releases: master
Change-Id: Ic8ff8cb3e10d6ba32c78c7ddf84d81027bde4924
Reviewed-on: https://review.ty...
Oliver Bartsch
08:30 Revision 16804cc5: [BUGFIX] Fix invalid json responses for empty page trees
JsonResponse class constructor needs to encode empty
arrays for [] to be returned as response, instead of an
empty st...
Benjamin Franzke
 

Also available in: Atom